Changes by Ned Deily n...@acm.org:
--
nosy: +amaury.forgeotdarc, belopolsky, meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22552
___
Matej Cepl added the comment:
ping? Could I ask for a review of the refreshed patch, please?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19494
___
Saimadhav Heblikar added the comment:
I mentioned my wording for the comment about lesser than partial ordering using
the code review tool.
In the attached patch(based on issue22515.stoneleaf.patch.01), I have added
test for the case when the other object is not a mapping.
I have also tried
Serhiy Storchaka added the comment:
They all look as false positive. For example:
if (_Unpickler_Read(self, pdata, size) 0)
return -1;
value = _PyLong_FromByteArray((unsigned char *)pdata, (size_t)size,
1 /* little endian */ , 1
Georg Brandl added the comment:
I'm wondering what regs is supposed to stand for. It might be for regions,
but that term is used nowhere else. It should really be named spans to be
consistent.
--
nosy: +georg.brandl
___
Python tracker
Changes by Georg Brandl ge...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22540
___
Ram Rachum added the comment:
Mark, I prefer to leave this to someone else.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18043
___
___
Ram Rachum added the comment:
I don't really understand the refactoring. For example why is `len(self) =
len(other)` needed? For which case? Note that `len` would also catch keys with
`0` value which shouldn't have an effect.
--
___
Python tracker
Serhiy Storchaka added the comment:
Test should be marked with dry_run=False, otherwise it is false passed.
Allocation of growing buffer needs extra memory, in my experiments memuse=2.5
is enough. And I think this test should require the largefile resource. Here is
a patch. It also
Mark Dickinson added the comment:
It seems that str, repr, and '' are using precision 16
None of them is using a fixed precision: they're all using David Gay's
implementation of the shortest string algorithm (à la Burger and Dybvig).
For repr, this is the case since Python 3.1 / 2.7; for
Serhiy Storchaka added the comment:
There are some properties of set comparison:
(a b) == (a = b and a != b)
(a = b) == (a b or a == b)
(a = b and b = a) == (a == b)
(a b and b a) == False
(a = b) == (a - b == set())
if (a = b and b = c) then (a = c)
(a = b and a = c) == (a = (b c))
(a = c
Nick Coghlan added the comment:
opener was new in 3.3, so I suspect it didn't come up because *we're* still
not entirely accustomed to having it available yet :)
I agree providing a suitable opener could be a good way to go.
--
___
Python tracker
Changes by Tommy Andersen andersento...@gmail.com:
--
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22546
___
___
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15244
___
___
Mark Dickinson added the comment:
Here's a proposed fix.
--
keywords: +patch
Added file: http://bugs.python.org/file36798/missing_type_specifier.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22546
Mark Dickinson added the comment:
Hmm; it's only outputs in non-scientific notation that are guaranteed to have
a decimal point. Patch updated.
--
Added file: http://bugs.python.org/file36799/missing_type_specifier2.patch
___
Python tracker
Ram Rachum added the comment:
There are some properties of set comparison:
(a b) == (a = b and a != b)
I don't think so, because counter equality is based on dict equality so it
doesn't ignore zero values.
(a = b) == (a b or a == b)
No, ditto.
(a = b and b = a) == (a == b)
No,
Changes by Mark Dickinson dicki...@gmail.com:
--
nosy: +mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22515
___
___
Steven D'Aprano added the comment:
On Sat, Oct 04, 2014 at 07:57:16AM +, Serhiy Storchaka wrote:
There are some properties of set comparison:
(a b) == (a = b and a != b)
(a = b) == (a b or a == b)
(a = b and b = a) == (a == b)
(a b and b a) == False
(a = b) == (a - b == set())
Serhiy Storchaka added the comment:
At least this condition is false for current implementation:
(a b and b a) == False
Example: a = Counter({'a': -1}), b = Counter({'b': -1}).
--
___
Python tracker rep...@bugs.python.org
Steven D'Aprano added the comment:
On Sat, Oct 04, 2014 at 08:38:17AM +, Ram Rachum wrote:
Ram Rachum added the comment:
There are some properties of set comparison:
(a b) == (a = b and a != b)
I don't think so, because counter equality is based on dict equality so it
Antoine Pitrou added the comment:
Just because something is discussed doesn't mean it needs a PEP.
Also, see http://bugs.python.org/issue22515#msg227852
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22515
Ram Rachum added the comment:
I see that in my implementation for __lt__ and __gt__ I forgot to check whether
the other counter has elements that this counter doesn't, which could flip
`found_strict_difference`.
--
___
Python tracker
Roundup Robot added the comment:
New changeset 911da1072099 by Serhiy Storchaka in branch '2.7':
Issue #22219: The zipfile module CLI now adds entries for directories
https://hg.python.org/cpython/rev/911da1072099
New changeset 981d18930d6d by Serhiy Storchaka in branch '3.4':
Issue #22219: The
Roundup Robot added the comment:
New changeset 3f7519f633ed by Serhiy Storchaka in branch '2.7':
Issue #22518: Fixed integer overflow issues in backslashreplace and
https://hg.python.org/cpython/rev/3f7519f633ed
New changeset ec9b7fd246b6 by Serhiy Storchaka in branch '3.4':
Issue #22518: Fixed
Roundup Robot added the comment:
New changeset d1be1f355f59 by Serhiy Storchaka in branch '2.7':
Fixed compilation error introduced in 3f7519f633ed (issue #22518).
https://hg.python.org/cpython/rev/d1be1f355f59
--
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22219
___
Roundup Robot added the comment:
New changeset 2ba2ee5713bd by Serhiy Storchaka in branch 'default':
Issue #21883: os.path.join() and os.path.relpath() now raise a TypeError with
https://hg.python.org/cpython/rev/2ba2ee5713bd
--
nosy: +python-dev
___
Roundup Robot added the comment:
New changeset a3e18dd8f267 by Serhiy Storchaka in branch '2.7':
Fixed issue number for issue #22470 in Misc/NEWS.
https://hg.python.org/cpython/rev/a3e18dd8f267
New changeset cba365e2117f by Serhiy Storchaka in branch '3.4':
Fixed issue number for issue #22470
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21883
___
Serhiy Storchaka added the comment:
Committed in 3f7519f633ed, ec9b7fd246b6, 2df4cc31c36e (and d1be1f355f59 fixes
an error in 3f7519f633ed).
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker
Stefan Krah added the comment:
libmpdec has always been a separate project, predating the integration
into Python-3.3. Before the Python-3.3 release, Jim Jewett suggested
a cleaner library/module separation (and he was right, it made the
code much more readable).
Then distributors wanted
Stefan Krah added the comment:
Of course Windows is a problem. I do not know how to implement
--with-system-libmpdec on Windows.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22194
___
Francis MB added the comment:
AFAICS, this is an enhancement issue for the currently in maintenance branches
2.7 and 3.2.
Does this still applies to 3.5? (otherwise this issue should/could be closed).
--
nosy: +francismb
type: - enhancement
___
Roundup Robot added the comment:
New changeset 51317c9786f5 by Serhiy Storchaka in branch '3.3':
Issue #22518: Fixed integer overflow issues in backslashreplace,
https://hg.python.org/cpython/rev/51317c9786f5
--
___
Python tracker
Serhiy Storchaka added the comment:
Sorry for noise, these changes are related to issue22470.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22518
___
Roundup Robot added the comment:
New changeset 85de13b746ac by Serhiy Storchaka in branch 'default':
Fixed tests on Windows for issue #21883.
https://hg.python.org/cpython/rev/85de13b746ac
--
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22423
Francis MB added the comment:
Is this issue superseded and duplicated as stated in the history?
Thanks in advance!
--
nosy: +francismb
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10764
Serhiy Storchaka added the comment:
Should I use os.path.realpath?
I don't see other way.
But there is other issue. Following code works now, but will fail with the
patch:
import os, tempfile
os.mkdir('parent')
os.chdir('parent')
t = tempfile.TemporaryDirectory(dir=.)
os.rename('../parent',
Francis MB added the comment:
Just updating the type to 'behavior'.
I can still reproduce this issue:
$ python2.7
Python 2.7.8 (default, Sep 9 2014, 22:08:43)
[GCC 4.9.1] on linux2
Type help, copyright, credits or license for more information.
class Y(long):
... def __oct__(self):
...
Steven D'Aprano added the comment:
On Sat, Oct 04, 2014 at 10:43:02AM +, Antoine Pitrou wrote:
Just because something is discussed doesn't mean it needs a PEP.
I know that in general discussions do not need a PEP, but we seem to be
rushing awfully fast into writing code before we even
Antoine Pitrou added the comment:
Le 04/10/2014 17:24, Steven D'Aprano a écrit :
I know that in general discussions do not need a PEP, but we seem to be
rushing awfully fast into writing code before we even know what the code
is supposed to do.
Writing a patch is useful practice because
Ram Rachum added the comment:
Hi everybody,
I agree we have a mess on our hands, with lots of cases where comparison is
weird. To be honest I've given up on `collections.Counter` at this point. The
fact that it's a hybrid mapping/multiset is the cause of all the problems, so
I just made my
New submission from Eric Fulton:
I believe the diagram showing how slices works from
https://docs.python.org/2/tutorial/introduction.html is incorrect. There
should be no 6.
word = 'Python'
word[6]
IndexError: string index out of range
Original:
+---+---+---+---+---+---+
| P | y | t
Georg Brandl added the comment:
Hi Eric,
this paragraph is about slices, where you *can* do
word[0:6]
'Python'
As such, the paragraph is correct.
--
nosy: +georg.brandl
resolution: - not a bug
status: open - closed
___
Python tracker
Serhiy Storchaka added the comment:
Here is a patch which fixes this issue. Now ValueError with relevant message is
raised instead of SystemError or crash.
--
nosy: +serhiy.storchaka
stage: - patch review
type: behavior - crash
___
Python tracker
Matthew Barnett added the comment:
There's an interesting bit of history here:
http://www.gossamer-threads.com/lists/python/dev/236584
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18043
Georg Brandl added the comment:
IOW: it was already intentionally undocumented back then, and only added for
compatibility reasons.
Probably should be deprecated and removed at some point.
--
resolution: - wont fix
status: open - closed
___
Python
Antoine Pitrou added the comment:
Glenn, are you willing to update your patch to address the review comments?
(I'm assuming you have been notified of them... if not, you can access the code
review tool by clicking the review links near your patch)
--
Claudiu Popa added the comment:
I'm not sure that Glenn receives this, he is not in the nosy list.
2014-07-18 16:45:36 glangford set nosy: - glangford
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
Woops. Thanks for noticing, Claudiu. I guess someone can take over the patch
and finish the work, then :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20516
Roundup Robot added the comment:
New changeset f87c2c4f03da by Antoine Pitrou in branch 'default':
Issue #11271: concurrent.futures.Executor.map() now takes a *chunksize*
https://hg.python.org/cpython/rev/f87c2c4f03da
--
nosy: +python-dev
___
Python
Changes by Claudiu Popa pcmantic...@gmail.com:
--
nosy: +Claudiu.Popa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11694
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Sorry for the delay. I simplified the patch a tiny bit (yield from wasn't
needed, it was sufficient to result the itertools.chain.from_iterable()
result), and committed it. Thank you!
--
resolution: - fixed
stage: patch review - resolved
status: open
Antoine Pitrou added the comment:
For the record, we have realized that pure C code brought less than a 2x
speedup compared to straightforward Python code, so cdecimal support has become
a low-priority concern for Numba. For the curious, the C code is from
libmpdec's own benchmark (Web site
Mark Lawrence added the comment:
This won't go anywhere until a patch is provided on #19904 as requested in
msg205765.
--
nosy: +BreamoreBoy
versions: -Python 2.7, Python 3.3, Python 3.4
___
Python tracker rep...@bugs.python.org
Mark Lawrence added the comment:
Just a reminder that a patch review is needed here guys.
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19960
___
Ethan Furman added the comment:
We are not rushing into code, we are getting some code, and tests, written to
help define what we are talking about.
So far the feedback has given some more tests to add, and some things to change
(such as only comparing with other Counters).
The big question
Francis MB added the comment:
Do have I overseen the patch? or may be doing something wrong?
or isn't anything uploaded?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11145
___
Mark Lawrence added the comment:
Can we please have a response to the question put in msg218050 so we can
investigate?
--
nosy: +BreamoreBoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21428
Mark Lawrence added the comment:
I'm concerned that 3.5 is creeping ever closer and I wouldn't like to see work
done on the installer backed out at the 11th hour because there has been no
agreement here. Does this need a discussion on python-dev? For that matter
has there been one already
Antoine Pitrou added the comment:
One issue with the owner is that there is now a reference cycle between
SSLSocket and SSLObject (something which the original design is careful to
avoid by using weakrefs in the _ssl module).
--
___
Python tracker
Antoine Pitrou added the comment:
Mark Lawrence, please stop acting like you are the project leader. If you want
to make concrete contributions to Python, you're welcome. But we don't need
your project management guidance.
--
nosy: +pitrou
___
Mark Lawrence added the comment:
Pardon me for breathing. As you clearly don't like the way I work would you be
so kind as to reopen the issues that I've helped close in the last few months.
It might bugger the stats on the bug tracker but hey ho.
--
Georg Brandl added the comment:
No response, closing.
--
nosy: +georg.brandl
resolution: - out of date
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21428
___
Georg Brandl added the comment:
Nobody doubts that pinging old issues helps getting some of them closed. But
messages like msg228480 sound a bit pretentious, that's what Antoine is
referring to.
--
nosy: +georg.brandl
___
Python tracker
Serhiy Storchaka added the comment:
Oh, sorry. I again forgot to upload a patch.
--
keywords: +patch
Added file: http://bugs.python.org/file36800/issue11145.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11145
Changes by Antoine Pitrou pit...@free.fr:
--
assignee: eric.araujo -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16314
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
This implementation obeys more set properties.
--
Added file:
http://bugs.python.org/file36801/issue22515_partial_order_counter_v3.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22515
Antoine Pitrou added the comment:
Sorry for the delay, Olivier. Your patch is now pushed. Thank you!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 86ba3bdfac15 by Antoine Pitrou in branch '3.4':
Issue #21905: Avoid RuntimeError in pickle.whichmodule() when sys.modules is
mutated while iterating.
https://hg.python.org/cpython/rev/86ba3bdfac15
New changeset d748a3503ad5 by Antoine Pitrou in
Friedrich Spee von Langenfeld added the comment:
As mentioned before, many packages can not handle paths with spaces. I suppose
that it is because of lacking knowledge on how to prevent such bugs. What would
you think? Should this piece of information be in our documentation? Or is it
already
Georg Brandl added the comment:
As mentioned before, many packages can not handle paths with spaces.
This is common knowledge, yet may not be true anymore. See this recent
python-dev thread:
https://mail.python.org/pipermail/python-dev/2014-September/136434.html
--
New submission from Terry J. Reedy:
Currently auto popup after delay only after '.' or in a string.
--
components: IDLE
messages: 228492
nosy: terry.reedy
priority: normal
severity: normal
stage: needs patch
status: open
title: Idle: optionally auto-pop-up completion window for names
Terry J. Reedy added the comment:
Need extension config dialog before add this. Should then review completion
extension for options that people might want.
--
dependencies: +IDLE - Add an extension configuration dialog
___
Python tracker
eryksun added the comment:
As mentioned before, many packages can not handle paths with
spaces.
This is common knowledge, yet may not be true anymore.
Well, see issue 21699. pip 1.5.6 is still using distlib 0.1.8, so the
executable wrappers it creates are broken when the path to
Antoine Pitrou added the comment:
Thank you for reporting this. Here is a patch with tests.
--
stage: - patch review
versions: +Python 3.5 -Python 3.2, Python 3.3
Added file: http://bugs.python.org/file36802/weakdictlen.patch
___
Python tracker
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +Marcus.Smith, dstufft, ncoghlan, pmoore
priority: normal - critical
stage: - needs patch
versions: +Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21699
Fabian added the comment:
I can confirm this on 3.4.1 and is really annoying. But the patch should set
'_is_raw_payload' to False if the payload is set via 'set_payload' (the
operations in 'set_raw_payload' need to be switched).
--
nosy: +xZise
___
Changes by Francis MB franci...@email.de:
--
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8481
___
___
Python-bugs-list
Changes by Antoine Pitrou pit...@free.fr:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19689
___
___
Python-bugs-list
Changes by Antoine Pitrou pit...@free.fr:
--
resolution: - out of date
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17444
___
Changes by Antoine Pitrou pit...@free.fr:
--
stage: test needed - needs patch
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17636
___
Changes by Francis MB franci...@email.de:
--
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11582
___
___
Python-bugs-list
Antoine Pitrou added the comment:
This is Brett's tests patch updated against default branch.
--
nosy: +pitrou
Added file: http://bugs.python.org/file36803/import_from_tests2.diff
___
Python tracker rep...@bugs.python.org
Changes by Francis MB franci...@email.de:
--
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6396
___
___
Python-bugs-list mailing
Roundup Robot added the comment:
New changeset a6b4add67168 by R David Murray in branch '2.7':
#11866: Eliminate race condition in the computation of names for new threads.
https://hg.python.org/cpython/rev/a6b4add67168
New changeset a6906b9e21d5 by R David Murray in branch '3.4':
#11866:
R. David Murray added the comment:
I committed a version of this that uses Raymond's suggestion and also makes
sure that the first thread is named Thread-1 as it has been in the past (there
was a test failure without that fix, but I also think it makes sense for it to
be Thread-1 since one
R. David Murray added the comment:
It looks like there is nothing left to do here and the issue was left open by
mistake. If I'm wrong, someone can reopen it with a note as to what remains to
be done (or open a new issue).
--
nosy: +r.david.murray
resolution: - fixed
stage: commit
Antoine Pitrou added the comment:
And this is a full patch.
--
stage: needs patch - patch review
Added file: http://bugs.python.org/file36804/import_from_tests2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17636
Changes by Antoine Pitrou pit...@free.fr:
Added file: http://bugs.python.org/file36805/circrelimports.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17636
___
Antoine Pitrou added the comment:
(full patch is actually the latest upload: circrelimports.patch. Sorry for the
glitch)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17636
___
R. David Murray added the comment:
How does this relate to issue 14201? That is, is the answer just use getitem
if you don't want caching? (And apply the doc patch from that issue :)
--
nosy: +r.david.murray
___
Python tracker
Geert Jansen added the comment:
One issue with the owner is that there is now a reference cycle between
SSLSocket and SSLObject (something which the original design is careful to
avoid by using weakrefs in the _ssl module).
Note that owner is a weakref :) Did you look at the code?
Roundup Robot added the comment:
New changeset ae64614b66b7 by R David Murray in branch '2.7':
#14201: Update ctypes docs to match behavior changed from 214b28d7a999.
https://hg.python.org/cpython/rev/ae64614b66b7
New changeset 5518aa0fbc06 by R David Murray in branch '3.4':
#14201: Update
Antoine Pitrou added the comment:
Ahhh. I had forgotten about that. It may be worthwhile to add a comment in
SSLObject.__init__, then. Also, can you provide a cumulated patch?
--
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
Committed. See also issue 22552.
--
nosy: +r.david.murray
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14201
R. David Murray added the comment:
Looks like the status for this one should really be needs decision. It is
sounds like the provided patch is not sufficient regardless, so 'commit
review' is no longer the appropriate state. I'm changing it back to patch
needed as the closest available
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18131
___
___
Python-bugs-list
1 - 100 of 137 matches
Mail list logo
