[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

2015-05-12 Thread Yury Selivanov
Yury Selivanov added the comment: Nick, Guido, Attached is a patch that fixes a refleak in 'async with' implementation. The problem is related to WITH_CLEANUP_START/WITH_CLEANUP_FINISH opcodes. For regular 'with' statements, these opcodes go one after another (essentially, it was one opcode b

[issue24079] xml.etree.ElementTree.Element.text does not conform to the documentation

2015-05-12 Thread Martin Panter
Martin Panter added the comment: Another problem with tostring() is that it seems you have to call it with encoding="unicode". Perhaps it would be better to suggest code like "".join(element.itertext())? I would also improve on Jérôme’s version by making the None case more explicit. And perha

[issue24086] Configparser interpolation is unexpected

2015-05-12 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue24053] Define EXIT_SUCCESS and EXIT_FAILURE constants in sys

2015-05-12 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

2015-05-12 Thread Nick Coghlan
Nick Coghlan added the comment: I'm bothered by the remarkable proliferation of new opcodes for the PEP 492 handling. Is there are a specific reason this implicit exception handler can't be decomposed and implemented using the same opcodes as are used to implement explicit exception handlers?

[issue23193] Please support "numeric_owner" in tarfile

2015-05-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset e5a53d75dc19 by Zachary Ware in branch 'default': Issue #23193: Skip numeric_owner tests on platforms where they don't make sense https://hg.python.org/cpython/rev/e5a53d75dc19 -- ___ Python tracker

[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

2015-05-12 Thread Yury Selivanov
Yury Selivanov added the comment: > Is there are a specific reason this implicit exception handler can't be > decomposed and implemented using the same opcodes as are used to implement > explicit exception handlers? I don't think it's possible to replace ASYNC_WITH_CLEANUP_EXCEPT opcode with

[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

2015-05-12 Thread Nick Coghlan
Nick Coghlan added the comment: I'm going to dig into this one locally, as it sounds to me like something may be going wrong with the refcounts in the complex stack manipulation involved in WITH_CLEANUP. It seems plausible that there's a genuinely missing incref/decref pair somewhere in the no

[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

2015-05-12 Thread Yury Selivanov
Yury Selivanov added the comment: I'd suggest you to look at ceval.c before PEP 492 patch then (where there is just one WITH_CLEANUP opcode). -- ___ Python tracker ___ _

[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

2015-05-12 Thread Nick Coghlan
Nick Coghlan added the comment: Avoiding WITH_CLEANUP entirely in the async case also sounds like a plausible approach. Either way, I'm also on IRC now if you want to thrash this out there. -- ___ Python tracker _

[issue23731] Implement PEP 488

2015-05-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset bbdbc4399b52 by Zachary Ware in branch 'default': Issue #23731: Fix tracemalloc test on Windows. https://hg.python.org/cpython/rev/bbdbc4399b52 -- ___ Python tracker _

[issue23911] Move path-based bootstrap code to a separate frozen file.

2015-05-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset cc2e52878393 by Zachary Ware in branch 'default': Issue #23911: Fix ctypes test on Windows. https://hg.python.org/cpython/rev/cc2e52878393 -- ___ Python tracker __

[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

2015-05-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset e39fd5a8501a by Nick Coghlan in branch 'default': Issue 24017: fix for "async with" refcounting https://hg.python.org/cpython/rev/e39fd5a8501a -- ___ Python tracker __

[issue24017] Implemenation of the PEP 492 - Coroutines with async and await syntax

2015-05-12 Thread Nick Coghlan
Nick Coghlan added the comment: A bit more detail on the patch-as-merged: it has all of Yury's new tests, but the actual bug turned out to just be a missing INCREF/DECREF pair in WITH_CLEANUP_START and WITH_CLEANUP_FINISH. In the success case the reference counting errors cancelled each other

[issue24172] Errors in resource.getpagesize module documentation

2015-05-12 Thread Mahmoud Hashemi
New submission from Mahmoud Hashemi: The resource module's description of resource.getpagesize is woefully misguiding. Reproduced in full for convenience: resource.getpagesize() Returns the number of bytes in a system page. (This need not be the same as the hardware page size.) This funct

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

2015-05-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset d3582826d24c by Zachary Ware in branch 'default': Issue #20172: Convert the winsound module to Argument Clinic. https://hg.python.org/cpython/rev/d3582826d24c New changeset 6e613ecd70f0 by Zachary Ware in branch 'default': Issue #20172: Convert the

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

2015-05-12 Thread Zachary Ware
Zachary Ware added the comment: Committed, thanks for the reviews, guidance, and patience! -- assignee: -> zach.ware resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker _

[issue24042] Convert os._getfullpathname() and os._isdir() to Argument Clinic

2015-05-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Committed in 4d7175af607e. Thank you Mark for the testing. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue22486] Add math.gcd()

2015-05-12 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue24032] urlparse.urljoin does not add query part

2015-05-12 Thread Martin Panter
Martin Panter added the comment: This is not how URL joining is meant to work. For example if the base URL “. . ./foo.php?param=10” produces a HTML file with a relative link to “bar.php”, the parent path should be joined on, but not the query part. I understand the Python implementation is mea

[issue24064] Make the property doctstring writeable

2015-05-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: > If make docstrings writable, it would be good to ensure > that they exactly are strings. I don't see a need for this restriction. Even regular classes don't enforce this. -- assignee: -> rhettinger ___ Pytho

<    1   2