Mark Lawrence added the comment:
Thanks for the comment David. Last time I used any kind of change system in
anger was Visual Source Safe 15 years ago, and VAX/VMS CMS/MMF(?) before that.
Where do I start with Mercurial? I don't even know what the difference is
between setting up the now
Changes by Yury Selivanov yseliva...@gmail.com:
Added file: http://bugs.python.org/file39611/set_coro.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24374
___
Changes by Tim Pierce twpie...@gmail.com:
--
nosy: +Tim Pierce
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22931
___
___
Python-bugs-list
paul j3 added the comment:
An alternative would be to wrap a non-identifier name in 'repr()':
def repr1(self):
def fmt_name(name):
if name.isidentifier():
return name
else:
return repr(name)
type_name =
paul j3 added the comment:
http://bugs.python.org/issue15125
argparse: positional arguments containing - in name not handled well
Discussion on whether positionals 'dest' should translate '-' to '_'.
--
___
Python tracker rep...@bugs.python.org
Petr Viktorin added the comment:
I've posted a patch that fixes the remaining refleak in issue24373.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24268
___
Matthias Bussonnier added the comment:
Namespace(a=1, 'b=2), Namespace(c'=3)
:-) I read that a `prime-b`=2 and `c-prime`=3.
I just feel like having a repr which is closer to the constructor signature is
better, but I guess it's a question of taste. Anyway, both would be fine.
--
Matthias Bussonnier added the comment:
I gave that a shot.
Doing it cleanly in C as the warning module is initialized much earlier.
Though I'm not super used to CPython internals.
Doing just before the repl by using `PyRun_SimpleString` make the patch
relatively small.
--
keywords:
py.user added the comment:
paul j3 wrote:
It's an attempt to turn such flags into valid variable names.
I'm looking at code and see that he wanted to make it handy for use in a
resulting Namespace.
args = argparse.parse_args(['--a-b-c'])
abc = args.a_b_c
If he doesn't convert, he cannot get
paul j3 added the comment:
Yes, the '_' makes it accessible as an attribute name. But the presence of '-'
in the option name has a UNIX history. That is a flag like '--a-b-c' is
typical, '--a_b_c' is not.
There is less of precedent for a flag like '@@a@b' or '--a@b'.
Here's the relevant
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: needs patch - patch review
versions: +Python 3.6 -Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20186
___
Tal Einat added the comment:
Should Argument Clinic conversion patches still be against the 'default'
branch, and not 3.5, even though they don't include any functionality changes?
--
___
Python tracker rep...@bugs.python.org
Martin Panter added the comment:
Looking at https://bugs.python.org/file39586/decomp-optim.patch, the “closed”
property is the first of the three hunks:
1. Adds @property / def closed(self) to Lib/_compression.py
2. Adds def __iter__(self) to Lib/gzip.py
3. Adds def __iter__(self) to
Martin Panter added the comment:
New patch just fixes the spelling error in the comment.
--
stage: needs patch - patch review
Added file: http://bugs.python.org/file39604/decomp-optim.v2.patch
___
Python tracker rep...@bugs.python.org
Larry Hastings added the comment:
I don't see anything about closed in the patch you posted.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18003
___
Antoine Pitrou added the comment:
Yes, this is right.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18003
___
___
Python-bugs-list mailing list
Cory Benfield added the comment:
It is obvious that this case could be treated as a folded (continuation)
line. But in general I think it would be better to ignore the erroneous line,
or to record it as a defect so that the server module or other user can check
it.
Just to clarify, in an
Martin Panter added the comment:
Yes that’s basically right Larry. The __iter__() was previously inherited; now
I am overriding it with a custom version. Similarly for the “closed” property,
but that one is only a member of objects internal to the gzip, lzma and bz2
modules.
--
Tal Einat added the comment:
Indeed, it should be.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24270
___
___
Python-bugs-list mailing list
New submission from Yavuz Selim Komur:
[remember]
eth2.6 = True
eth5 = True
eth5 correct but eth2.6 return exception
--
components: Extension Modules, Library (Lib)
messages: 244730
nosy: Yavuz Selim Komur
priority: normal
severity: normal
status: open
title: configparser hate dot in
Tal Einat added the comment:
Attached is an updated patch for Modules/mathmodule.c.
This is based on Georg's patch, updated to apply to current 3.5, with several
improvements:
* replaced legacy converters
* converted math.ceil() and math.floor() functions
* converted the new math.gcd() and
Changes by Berker Peksag berker.pek...@gmail.com:
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24270
___
Cory Benfield added the comment:
While we're here and I'm recommending to drop as little data as possible: we
need to be really careful about not exposing ourselves to any kind of data
smuggling attack here.
It's really important that we don't let attackers construct bodies of requests
or
Tal Einat added the comment:
Attached is an AC conversion patch for Objects/enumobject.c.
Note that this file contains the implementations of the 'enumerate' and
'reversed' classes, but *not* the 'Enum' class.
This is based on the 3.5 branch.
--
Added file:
Christian Heimes added the comment:
I'd like to deprecate ssl.wrap_socket() in favor of SSLContext.wrap_socket().
Libraries should rather accept a context than expose the awkward interface of
ssl.wrap_socket(). A context object is far more powerful and easier to use.
--
Michael Del Monte added the comment:
Given that obs-fold is technically valid, then can I recommend reading the
entire header first (reading to the first blank line) and then tokenizing the
individual headers using a regular expression rather than line by line? That
would solve the problem
Changes by Christian Heimes li...@cheimes.de:
--
nosy: +christian.heimes
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24372
___
___
Michiel de Hoon added the comment:
I am uploading an updated version of the patch.
I'd be happy to submit a patch to the documentation also, but wasn't able to
find it on Mercurial. Can somebody please point me to the right repository for
the documentation?
--
Added file:
New submission from Yury Selivanov:
Attached (t.py) is a random script that I stumbled upon pretty randomly on the
internet -- someone used it to test different languages VMs performance.
The interesting thing is that 2.7 runs it 20-30% faster than 3.4 3.5
consistently. The script does not
Stefan Krah added the comment:
I think this is much nicer, thank you!
And the XXX comment looks right, updating od_size could be moved
down. I suspect that updating it too early was the cause for
#24361, which is also solved by this patch.
--
___
Eric V. Smith added the comment:
I have a requirement to support 2.7.5, so SSLContext is currently a problem for
me.
I realize that 2.7 could at best get a documentation change.
--
___
Python tracker rep...@bugs.python.org
Changes by Yury Selivanov yseliva...@gmail.com:
--
nosy: +gvanrossum, haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24374
___
___
Michael Del Monte added the comment:
... or perhaps
if ':' in line and line[0] != ':':
to avoid the colon-as-first-char bug that plagued this library earlier, though
the only ill-effect of leaving it alone would be a header with a blank key; not
the end of the world.
--
Tim Graham added the comment:
Unfortunately, the revert wasn't merged to the 2.7 branch until after the
release of 2.7.10. I guess this regression wouldn't be considered serious
enough to warrant a 2.7.11 soon, correct?
--
___
Python tracker
New submission from Petr Viktorin:
The example object in the xxlimited module can be part of a reference loop (it
can contain itself), so it needs GC and tp_traverse.
The tp_dealloc hook was incorrect, and a correct version would be difficult to
generalize for something more complicated than
Martin Panter added the comment:
Okay, here is a version with most of the wording reverted to Jérôme’s
suggestion. I only left my itertext() example, and the grouping of text and
tail together. If there are any more bits that are incorrect or unclear please
identify them.
--
Added
Skip Montanaro added the comment:
What little I could find about Windows INI file syntax didn't identify the
valid character set of the keys. Like other Windows-based file formats, INI
seems to only be operationally defined. It wouldn't surprise me if you needed
to restrict yourself to the
Stefan Krah added the comment:
This is my experience, too: Floating-point calculations are often
20-30% faster on 2.7.
--
nosy: +skrah
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24375
Antoine Pitrou added the comment:
FTR, Python 2.7 was slower until the computed gotos patch was backported.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24375
___
Yury Selivanov added the comment:
This is strange. On one of my gentoo boxes I'm having about the same
performance of 2.7.9 and 3.4.3.
On macos x, 2.7.10 is faster than 3.5.x (make distclean ./configure make).
I don't know if I should close this issue.
--
Alex Grönholm added the comment:
Was __await__() deliberately left out of concurrent.futures.Future or was that
an oversight? Or am I misunderstanding something?
--
nosy: +alex.gronholm
___
Python tracker rep...@bugs.python.org
Yury Selivanov added the comment:
Alright. I'm closing it, as it seems it's not obvious what's really going on
here. I'll try to profile it on my own later.
(also, computing the Mandelbrot set using the CPython interpreter isn't a
very good use case)
Antoine, well, regardless of the
Antoine Pitrou added the comment:
This is strange. On one of my gentoo boxes I'm having about the same
performance of 2.7.9 and 3.4.3.
As I said: the computed gotos patch improved performance between 2.7.9 and
2.7.10.
In any case, if there's no obvious course of action you can suggest, I
Yury Selivanov added the comment:
Was __await__() deliberately left out of concurrent.futures.Future or was
that an oversight? Or am I misunderstanding something?
I don't think concurrent.Future is supposed to be used with asyncio (in 'yield
from' or 'await' expressions).
--
Steve Dower added the comment:
It's more recent, but still only a doc change.
What's the description of the change you're referring to?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24376
paul j3 added the comment:
The code that converts '-' to '_' is independent of the code that uses
'prefix_chars'.
The '-' conversion handles a long standing UNIX practice of allowing that
character in the middle of option flags. It's an attempt to turn such flags
into valid variable names.
paul j3 added the comment:
And the corresponding bug issue
http://bugs.python.org/issue9351
--
nosy: +paul.j3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24251
___
Eric Snow added the comment:
This has been fixed via issue24362.
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24361
Roundup Robot added the comment:
New changeset 6df1b3c6c8e8 by Eric Snow in branch '3.5':
Issue #24377: Fix a ref leak in OrderedDict.__repr__.
https://hg.python.org/cpython/rev/6df1b3c6c8e8
--
nosy: +python-dev
___
Python tracker
Mark Lawrence added the comment:
Try r96496 :(
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24376
___
___
Python-bugs-list mailing list
paul j3 added the comment:
Another example of this patch causing backward compatibility problems
http://bugs.python.org/issue24251
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9351
___
New submission from Eric Snow:
It should be a one-line fix.
--
assignee: eric.snow
messages: 244775
nosy: eric.snow
priority: high
severity: normal
stage: needs patch
status: open
title: Refleak in OrderedDict.__repr__ when an item is not found.
type: behavior
versions: Python 3.5,
Steve Dower added the comment:
I do like this fix, and I'm sorry I didn't get to reviewing it before beta 1
was released - can we consider this something to fix for 3.5 or do we need to
slip it until 3.6?
--
___
Python tracker
Changes by Eric Snow ericsnowcurren...@gmail.com:
--
resolution: - fixed
stage: needs patch - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24377
___
Changes by koobs koobs.free...@gmail.com:
--
stage: resolved - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22359
___
___
paul j3 added the comment:
I mentioned in the related bug/issue that no one has to use odd characters and
spaces in the Namespace. While they are allowed by 'getattr' etc, the
programmer has the option of supplying rational names in the 'dest' parameter.
There's also the question of what
Changes by Rémi Rampin remiram...@gmail.com:
--
nosy: +remram
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24251
___
___
Python-bugs-list mailing
R. David Murray added the comment:
Mark, FYI the 'r' numbers are unique to each mercurial checkout and meaningless
to anyone else. Only the hash numbers can be used to compare revisions between
different repositories. (You *could* refer to the r number from the cpython
repository as seen in
R. David Murray added the comment:
I haven't reviewed the patch, but if it only makes the existing API actually
work for Windows, I think it would be fair game for 3.5. Larry would need to
make the call, though.
--
nosy: +larry, r.david.murray
___
Eric Snow added the comment:
Here's a patch that tracks changes to the C OrderedDict linked list, similar to
how it's done in deque. I've left the pure Python OrderedDict alone.
@Raymond, that state counter works great. :)
--
keywords: +patch
stage: test needed - patch review
Added
Rémi Rampin added the comment:
To me this is much more than a compatibility problem. The way it worked before
made a lot of sense, and just felt like the correct solution to accept a flag
in multiple places.
Having a --verbose flag is something everybody should consider (Python has a
decent
Matthias Bussonnier added the comment:
Sure and anyway if you have a huge namespace, things will become unreadable.
But during development/teaching, having object that have a sane
representation is useful, otherwise your brain (well at least mine), choke on
the output and break the flow of my
Roundup Robot added the comment:
New changeset b8bcc5507541 by Steve Dower in branch '3.5':
Issue #24376: xxlimited.c errors when building 32 and 64 bit on Windows
https://hg.python.org/cpython/rev/b8bcc5507541
New changeset c802fba79554 by Steve Dower in branch 'default':
Issue #24376:
paul j3 added the comment:
Off hand I don't see a problem with this patch (but I haven't tested it yet).
But I have a couple of cautions:
The docs say, regarding the Namespace class:
This class is deliberately simple, just an object subclass with a readable
string representation.
This
Zachary Ware added the comment:
We need to bump the Py_LIMITED_API definition in PCbuild/xxlimited.vcxproj
as well.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24376
___
Roundup Robot added the comment:
New changeset 31301b84ac8d by Steve Dower in branch 'default':
Issue #24376: Bumps xxlimited.vcxproj to use 3.6 limited ABI.
https://hg.python.org/cpython/rev/31301b84ac8d
--
___
Python tracker rep...@bugs.python.org
66 matches
Mail list logo
