[issue24465] Make tar files created by shutil.make_archive() have deterministic sorting

2015-06-18 Thread Sam Thursfield
Changes by Sam Thursfield sam.thursfi...@codethink.co.uk: -- keywords: +patch Added file: http://bugs.python.org/file39728/tarfile-stable-ordering.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24465

[issue24465] Make tarfile have deterministic sorting

2015-06-18 Thread R. David Murray
R. David Murray added the comment: This would go beyond what the tar command itself does. I'm not sure we want to do that, as we are pretty much modeling our behavior on tar. However, that doesn't automatically mean we can't do it. We'll see what other people think. Personally I'm -0.

[issue24464] Got warning when compiling sqlite3 module on Mac OSX

2015-06-18 Thread Vajrasky Kok
New submission from Vajrasky Kok: I got this warning when compiling sqlite3 module. gcc -Wno-unused-result -Wsign-compare -g -O0 -Wall -Wstrict-prototypes -Werror=declaration-after-statement -DMODULE_NAME=sqlite3 -DSQLITE_OMIT_LOAD_EXTENSION=1 -IModules/_sqlite -I/usr/include -I./Include -I.

[issue24465] Make tar files created by shutil.make_archive() have deterministic sorting

2015-06-18 Thread Sam Thursfield
New submission from Sam Thursfield: I want shutil.make_archive() to produce deterministic output when given identical data as inputs. Right now there are two holes in this. One is that mtimes might not match. This can be fixed by the caller. The second is that the order that files in a

[issue24463] Python 3.4 bugs

2015-06-18 Thread Skip Montanaro
Skip Montanaro added the comment: Not a bug. The two elements of w are references to the same list: w = [[0] * 2] * 2 w [[0, 0], [0, 0]] [id(elt) for elt in w] [21743952, 21743952] -- nosy: +skip.montanaro resolution: - not a bug status: open - closed

[issue24465] Make tarfile have deterministic sorting

2015-06-18 Thread Lars Gustäbel
Lars Gustäbel added the comment: You don't need to patch the tarfile module. You could use os.walk() in shutil._make_tarball() and add each file with TarFile.add(recursive=False). -- nosy: +lars.gustaebel ___ Python tracker rep...@bugs.python.org

[issue24450] Add gi_yieldfrom calculated property to generator object

2015-06-18 Thread Benno Leslie
Benno Leslie added the comment: I've tried to address all the issues raised in the review of the first patch. -- Added file: http://bugs.python.org/file39725/gi_yieldfrom.v1.patch ___ Python tracker rep...@bugs.python.org

[issue19542] WeakValueDictionary bug in setdefault()pop()

2015-06-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Yes, we need to fix this. Sorry for being a bit slow. -- versions: +Python 3.5, Python 3.6 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19542

[issue24466] extend_path explanation in documentation is ambiguous

2015-06-18 Thread alanf
New submission from alanf: The description of pkgutil.extend_path in the doc (e.g., https://docs.python.org/2/library/pkgutil.html , https://docs.python.org/3/library/pkgutil.html ) is so ambiguous that I had to run a test to understand its behavior. The doc says: This will add to the

[issue24465] Make tarfile have deterministic sorting

2015-06-18 Thread Sam Thursfield
Sam Thursfield added the comment: Thanks for the comments! Would you be happy for the patch to be merged if it was implemented by modifying shutil.make_archive() instead? I will rework it if so. -- ___ Python tracker rep...@bugs.python.org

[issue19542] WeakValueDictionary bug in setdefault()pop()

2015-06-18 Thread Tin Tvrtković
Tin Tvrtković added the comment: We're actually getting bitten by this in production through the Riak Python client, so this isn't a strictly theoretical problem. -- nosy: +tinchester ___ Python tracker rep...@bugs.python.org

[issue24465] Make tarfile have deterministic sorting

2015-06-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: I don't see any downside for this simple patch and think there is some merit for wanting a reproducible archive. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24465

[issue24419] In argparse action append_const doesn't work for positional arguments

2015-06-18 Thread paul j3
paul j3 added the comment: You can give the positional any custom name (the first parameter). You just can't reuse it (by giving 2 positionals the same name). And if you don't like what the 'help' shows, you can set the 'metavar'. That way only you see the positional's name. The name of a

[issue19235] Add a dedicated subclass for recursion errors

2015-06-18 Thread Elazar Gershuni
Elazar Gershuni added the comment: So what holds it back now? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list

[issue23255] SimpleHTTPRequestHandler refactor for more extensible usage.

2015-06-18 Thread Ent
Ent added the comment: Thanks Ned Berker, I can only imagine the amount of work the core devs have to deal with. Hope my patch makes it through in next version. Regards, Ent -- ___ Python tracker rep...@bugs.python.org

[issue24468] Expose compiler flag constants as code object attributes

2015-06-18 Thread Nick Coghlan
Changes by Nick Coghlan ncogh...@gmail.com: -- dependencies: +Awaitable ABC incompatible with functools.singledispatch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24468 ___

[issue24468] Expose compiler flag constants as code object attributes

2015-06-18 Thread Nick Coghlan
New submission from Nick Coghlan: As part of the PEP 492 implementation, Yury has needed to hardcode compile flag contants in various places, with adjacent comments explaining what the magic numbers mean. It occurred to me that there's a way we could make those constants readily available to

[issue23883] __all__ lists are incomplete

2015-06-18 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: ftplib and threading have more functions I've meant function and exceptions, of course. Sorry for the noise. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23883

[issue24468] Expose compiler flag constants as code object attributes

2015-06-18 Thread Nick Coghlan
Nick Coghlan added the comment: In my last set of review comments on issue 24400 I suggested changing the Python level attributes for coroutine objects to cr_frame, cr_code, and cr_running. It's possible that may provide a different way to eliminate some of the current compiler flag checks.

[issue24468] Expose compiler flag constants as code object attributes

2015-06-18 Thread Larry Hastings
Larry Hastings added the comment: Probably, though I want to see a sample implementation before I agree to anything. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24468 ___

[issue24400] Awaitable ABC incompatible with functools.singledispatch

2015-06-18 Thread Nick Coghlan
Nick Coghlan added the comment: In my last set of review comments, I suggested changing the Python level attributes for coroutine objects to cr_frame, cr_code, and cr_running. That reminded me that now that coroutines are their own type, we should also give them their own state introspection

[issue23883] __all__ lists are incomplete

2015-06-18 Thread Jacek Kołodziej
Changes by Jacek Kołodziej kolodzi...@gmail.com: Added file: http://bugs.python.org/file39734/Issue23883_test_gettext.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23883 ___

[issue24450] Add gi_yieldfrom calculated property to generator object

2015-06-18 Thread Nick Coghlan
Nick Coghlan added the comment: Marking this as dependent on issue 24400, as that refactors the PEP 492 implementation to make coroutines their own type (albeit one that shares a memory layout and some attribute names with generators at the C layer). I'd suggest cr_await as the calculated

[issue23883] __all__ lists are incomplete

2015-06-18 Thread Jacek Kołodziej
Jacek Kołodziej added the comment: Thank you for feedback, Martin. I've amended the the patch. Next, I've prepared some initial test.support.check__all__ helper, based on generalization of all previous patches. Its name/params' descriptions may be a bit rough - amendments/suggestions for such

[issue24400] Awaitable ABC incompatible with functools.singledispatch

2015-06-18 Thread Yury Selivanov
Yury Selivanov added the comment: Another iteration of the patch is attached. Nick, I think it's ready for your review. -- stage: needs patch - patch review type: - enhancement Added file: http://bugs.python.org/file39729/corotype.patch ___ Python

[issue24429] msvcrt error when embedded

2015-06-18 Thread eryksun
eryksun added the comment: shapely's installation instructions from windows are to use chris gohlke's prebuilt binaries from here: http://www.lfd.uci.edu/~gohlke/pythonlibs/ Christoph Gohlke's Shapely‑1.5.9‑cp27‑none‑win_amd64.whl includes a version of geos_c.dll that has the VC90

[issue19235] Add a dedicated subclass for recursion errors

2015-06-18 Thread Elazar Gershuni
Elazar Gershuni added the comment: Well that's a déjà vu. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235 ___ ___ Python-bugs-list mailing

[issue24419] In argparse action append_const doesn't work for positional arguments

2015-06-18 Thread py.user
py.user added the comment: paul j3 wrote: You can give the positional any custom name (the first parameter). The dest argument is not required for giving name for an optional. You can either make it automatically or set by dest, it's handy and clear. import argparse parser =

[issue19235] Add a dedicated subclass for recursion errors

2015-06-18 Thread Yury Selivanov
Yury Selivanov added the comment: +1. This, unfortunately, can't go in 3.5 (too late), but I can commit this in 3.6. -- assignee: - yselivanov nosy: +yselivanov versions: +Python 3.6 -Python 3.5 ___ Python tracker rep...@bugs.python.org

[issue19235] Add a dedicated subclass for recursion errors

2015-06-18 Thread Yury Selivanov
Yury Selivanov added the comment: Larry, is there any chance this can be committed in 3.5 (the change is fully backwards compatible)? -- nosy: +larry ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19235

[issue24419] In argparse action append_const doesn't work for positional arguments

2015-06-18 Thread paul j3
paul j3 added the comment: (Important correction at the end of this post) The test that you are complaining about occurs at the start of the 'add_argument' method: def add_argument(self, *args, **kwargs): add_argument(dest, ..., name=value, ...)

[issue24429] msvcrt error when embedded

2015-06-18 Thread Steve Dower
Steve Dower added the comment: Steve, since you haven't closed this issue, have you considered my suggestion to export _Py_ActivateActCtx and _Py_DeactivateActCtx for use by C extensions such as _ctypes.pyd? These functions are better than manually creating a context from the manifest

[issue24400] Awaitable ABC incompatible with functools.singledispatch

2015-06-18 Thread Yury Selivanov
Changes by Yury Selivanov yseliva...@gmail.com: Added file: http://bugs.python.org/file39730/corotype.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24400 ___

[issue6839] zipfile can't extract file

2015-06-18 Thread Sean Goodwin
Changes by Sean Goodwin sean.e.good...@gmail.com: -- nosy: +Sean Goodwin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6839 ___ ___

[issue18383] test_warnings modifies warnings.filters when running with -W default

2015-06-18 Thread Martin Panter
Martin Panter added the comment: FWIW there is a new message currently being triggered by test___all__. The patch here also stops this message. $ hg update 4335d898be59 $ ./python -bWall -m test test___all__ [1/1] test___all__ Warning -- warnings.filters was modified by test___all__ 1 test

[issue15745] Numerous utime ns tests fail on FreeBSD w/ ZFS (update: and NetBSD w/ FFS, Solaris w/ UFS)

2015-06-18 Thread Martin Panter
Martin Panter added the comment: The commit causes test_os to emit DeprecationWarning warnings, which it didn’t before: [vadmium@localhost cpython]$ hg update 4335d898be59 0 files updated, 0 files merged, 0 files removed, 0 files unresolved [vadmium@localhost cpython]$ ./python -bWdefault -m

[issue23255] SimpleHTTPRequestHandler refactor for more extensible usage.

2015-06-18 Thread Berker Peksag
Berker Peksag added the comment: Ned is correct. I started to review the patch, but couldn't find time to do a complete review. I'll take a look at it in a week or two. Thanks! -- assignee: - berker.peksag ___ Python tracker rep...@bugs.python.org

[issue24462] bytearray.find Buffer Over-read

2015-06-18 Thread DmitryJ
DmitryJ added the comment: Quick analysis tells this can be attributed to the following code (in 2.7): https://hg.python.org/cpython/file/a8e24d776e99/Objects/stringlib/fastsearch.h#l110 https://hg.python.org/cpython/file/a8e24d776e99/Objects/stringlib/fastsearch.h#l116 Suppose i = 0, then

[issue24462] bytearray.find Buffer Over-read

2015-06-18 Thread DmitryJ
DmitryJ added the comment: From the author's page at http://effbot.org/zone/stringlib.htm Note that the above Python code may access s[n], which would result in an IndexError exception. For the CPython implementation, this is not really a problem, since CPython adds trailing NULL entries to

[issue24339] iso6937 encoding missing

2015-06-18 Thread John Helour
Changes by John Helour helo...@gmail.com: Removed file: http://bugs.python.org/file39575/iso6937.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24339 ___

[issue24421] Race condition compiling Modules/_math.c

2015-06-18 Thread Tal Einat
Tal Einat added the comment: Adding Thomas Wouters to the nosy list, since he's listed on the Experts Index under autoconf/makefiles as an interest area. Hopefully he can help move this forward. -- nosy: +twouters ___ Python tracker

[issue23020] New matmul operator crashes modules compiled with CPython3.4

2015-06-18 Thread Tal Einat
Changes by Tal Einat talei...@gmail.com: -- assignee: - docs@python components: +Documentation nosy: +docs@python ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23020 ___

[issue24463] Python 3.4 bugs

2015-06-18 Thread vasya yugov
New submission from vasya yugov: This code: w = [[0] * 2] * 2 w[1][1] = 1 print(w) prints [[0, 1], [0, 1]] Is it a bug? -- components: Macintosh messages: 245460 nosy: ned.deily, ronaldoussoren, vasya yugov priority: normal severity: normal status: open title: Python 3.4 bugs type: