[issue24420] Documentation regressions from adding subprocess.run()

Changes by Martin Panter : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue23750] Clarify difference between os.system/subprocess.call in section "Replacing os.system()"

Martin Panter added the comment: Here is a patch: * Use different return value variable names and point out that they are encoded differently * Add another bullet point about signal handling * Fix os.system() documentation of the return value. My understanding is it is the C standard that does

[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()

Serhiy Storchaka added the comment: New patch touches also unbounded cache version. Larry, do you allow to commit such patch in 3.5? -- nosy: +larry versions: +Python 3.5 Added file: http://bugs.python.org/file39766/clru_cache_known_hash_3.patch ___

[issue14373] C implementation of functools.lru_cache

Serhiy Storchaka added the comment: > If the C version is to remain in Python3.5, please make sure it provides all > of the carefully designed features of the pure python version: > >* The hash function is called no more than once per element Will be satisfied by issue24483. I think all ot

[issue24479] Support LMMS project files in mimetypes.guess_type

Andreas Nilsson added the comment: Here is a decompressed example (use lmms -d to decompress). Shouldn't this be parsed as XML? Here's a log of my experiment with it: Python 2.7.9 (default, Apr 2 2015, 15:33:21) [GCC 4.9.2] on linux2 Type "help", "copyright", "credits" or "license" for more

[issue24439] Feedback for awaitable coroutine documentation

Yury Selivanov added the comment: Martin, if you want to help with the documentation, it would be great if you can help me with updating asyncio coroutines section: https://docs.python.org/3.5/library/asyncio-task.html#coroutines -- ___ Python track

[issue24400] Awaitable ABC incompatible with functools.singledispatch

Yury Selivanov added the comment: An updated patch is attached. I'll commit it tomorrow morning. -- Added file: http://bugs.python.org/file39764/corotype.patch ___ Python tracker ___

[issue23883] __all__ lists are incomplete

Martin Panter added the comment: To avoid the list of patches here getting out of control, I suggest opening a fresh issue for any new patches that aren’t a new version of the patches here. We can mark the new issue as a dependency of this one to keep track of it. Nice work with the check__all

[issue20387] tokenize/untokenize roundtrip fails with tabs

Dingyuan Wang added the comment: The new patch should now pass all tests correctly. The main idea is: * if the token is INDENT, push it on the `indents` stack and continue * if a new line starts, AND the position of the first token >= the length of the last indent level, we assume the indent is

[issue1186900] nntplib shouldn't raise generic EOFError

Martin Panter added the comment: Quick survey of other communication protocol modules: ftplib: uses EOFError; not documented http.client: custom IncompleteRead exception imaplib: custom IMAP4.abort exception poplib: custom error_proto exception smtplib: SMTPServerDisconnected exception, subclass

[issue24484] multiprocessing cleanup occasionally throws exception

Changes by Ned Deily : -- nosy: +davin, sbt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue23684] urlparse() documentation does not account for default scheme

Berker Peksag added the comment: LGTM. Added a minor question on Rietveld. -- assignee: docs@python -> berker.peksag nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker

[issue24408] tkinter.font.Font.measure() broken in 3.5

Ned Deily added the comment: Thanks for the fix, Martin and Serhiy. With Tk 8.4 on OS X, at least, it is possible to have non-ascii font names. I extended the 2.7 test to account for that. -- versions: +Python 2.7 ___ Python tracker

[issue24408] tkinter.font.Font.measure() broken in 3.5

Roundup Robot added the comment: New changeset 20c9290a5de4 by Ned Deily in branch '2.7': Issue #24408: Prevent test_font failures with non-ascii font names. https://hg.python.org/cpython/rev/20c9290a5de4 -- ___ Python tracker

[issue24464] Got warning when compiling sqlite3 module on Mac OS X

Ned Deily added the comment: I agree with Ronald that the proposed patch should not be applied as is. For example, the Pythons installed by the current python.org OS X installers build and link with a newer version of libsqlite3. This is one of several examples of third-party libraries for w

[issue23531] SSL operations cause entire process to hang

johnkw added the comment: This bug is not present on Python 2.7.10 on 64-bit Linux. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue24309] string.Template should be using str.format and/or deprecated

Changes by Dmitry Kazakov : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue14373] C implementation of functools.lru_cache

Raymond Hettinger added the comment: If the C version is to remain in Python3.5, please make sure it provides all of the carefully designed features of the pure python version: * The hash function is called no more than once per element * The key is constructed to be flat as possible *

[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't

Serhiy Storchaka added the comment: I can't reproduce the crash in 3.3+ (this doesn't matter the bug is gone), but can reproduce in 2.7 and 3.2. Here is a reproducer that compatible with 2.7 and 3.x. -- Added file: http://bugs.python.org/file39762/test_segfault.py

[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()

Serhiy Storchaka added the comment: New patch adds _PyDict_DelItem_KnownHash() and uses it to guarantee that the hash is only calculated once. -- Added file: http://bugs.python.org/file39761/clru_cache_known_hash_2.patch ___ Python tracker

[issue1182143] making builtin exceptions more informative

R. David Murray added the comment: What does your patch implement? It's not clear from the issue discussion that an API was decided on. -- ___ Python tracker ___

[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't

Raymond Hettinger added the comment: > Is it expected? No, it is a bug. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()

Changes by Raymond Hettinger : -- Removed message: http://bugs.python.org/msg245600 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()

Raymond Hettinger added the comment: I would like the full functionality of the Python version to be implemented. Guaranteeing that the hash is only calculated once prevents a reentrancy hole and provides a speed benefit as well. Please implement exactly what the pure python version does (n

[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()

Raymond Hettinger added the comment: This is important. -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailin

[issue1182143] making builtin exceptions more informative

George Jenkins added the comment: Reviewer please :) (or, advice on how I can get this to proceed, thx) -- ___ Python tracker ___

[issue23883] __all__ lists are incomplete

Jacek Kołodziej added the comment: I've added previously missing test and docs for test.support.check__all__ in Issue23883_support_check__all__.v2.patch . Awaiting review. :) -- Added file: http://bugs.python.org/file39760/Issue23883_support_check__all__.v2.patch _

[issue24484] multiprocessing cleanup occasionally throws exception

New submission from Jorge Herskovic: I'm writing a library on top of multiprocessing. As part of the test suite, I create and destroy dozens of processes repeatedly. About once in 50 runs, the tests complete successfully but the program crashes with: Error in atexit._run_exitfuncs: Traceback (

[issue24129] Incorrect (misleading) statement in the execution model documentation

Ivan Levkivskyi added the comment: Nick, thank you for a review, I have made a new patch with all the previous comments taken into account. -- Added file: http://bugs.python.org/file39759/classdoc-v4.patch ___ Python tracker

[issue24436] _PyTraceback_Add has no const qualifier for its char * arguments

Serhiy Storchaka added the comment: Thank you for your contribution Michael. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker _

[issue24436] _PyTraceback_Add has no const qualifier for its char * arguments

Roundup Robot added the comment: New changeset 6f659b9f7fbc by Serhiy Storchaka in branch '3.4': Issue #24436: Added const qualifiers for char* arguments of _PyTraceback_Add. https://hg.python.org/cpython/rev/6f659b9f7fbc New changeset 9602b8313dd5 by Serhiy Storchaka in branch '3.5': Issue #244

[issue24436] _PyTraceback_Add has no const qualifier for its char * arguments

Changes by Serhiy Storchaka : -- versions: +Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue24436] _PyTraceback_Add has no const qualifier for its char * arguments

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()

New submission from Serhiy Storchaka: There is a difference between Python and C implementations of functools.lru_cache(). Python implementation caches the hash of the key, C implementation doesn't. May be this is not too important (at least I have no an example that shows the benefit of cachi

[issue24464] Got warning when compiling sqlite3 module on Mac OSX

Ronald Oussoren added the comment: appears to indicate that the function is deprecated on OSX 10.7 and iOS 5.0, but looking at the latest sources on sqlite.org that's not the case, the warning in the documentation appears to be for the ve

[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue24408] tkinter.font.Font.measure() broken in 3.5

Serhiy Storchaka added the comment: Thank you Ned and Martin. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue24408] tkinter.font.Font.measure() broken in 3.5

Roundup Robot added the comment: New changeset 8e90f3ffa784 by Serhiy Storchaka in branch '2.7': Issue #24408: Fixed test for tkinter.Font on OS X. https://hg.python.org/cpython/rev/8e90f3ffa784 New changeset 014ee2df443a by Serhiy Storchaka in branch '3.4': Issue #24408: Fixed test for tkinter.

[issue24426] re.split performance degraded significantly by capturing group

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't

Changes by Ezio Melotti : -- nosy: +rhettinger stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue24426] re.split performance degraded significantly by capturing group

Roundup Robot added the comment: New changeset 7e46a503dd16 by Serhiy Storchaka in branch 'default': Issue #24426: Fast searching optimization in regular expressions now works https://hg.python.org/cpython/rev/7e46a503dd16 -- nosy: +python-dev ___ Pyt

[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't

Changes by Dmitry Odzerikho : Removed file: http://bugs.python.org/file39756/test_segfault.py ___ Python tracker ___ ___ Python-bugs-list mail

[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't

Changes by Dmitry Odzerikho : Added file: http://bugs.python.org/file39757/test_segfault.py ___ Python tracker ___ ___ Python-bugs-list mailin

[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation doesn't

New submission from Dmitry Odzerikho: Hi, I'm using iterators returned by itertools.tee in different threads. The original iterator passed to itertools.tee is thread-safe, however, it doesn't guarantees that the cloned iterators are thread safe too. However the equivalent implementation of it

[issue24482] itertools.tee causes segfault in a multithreading environment, while the equivalent implementation does'nt

Changes by Dmitry Odzerikho : -- components: Library (Lib) nosy: Dmitry Odzerikho priority: normal severity: normal status: open title: itertools.tee causes segfault in a multithreading environment, while the equivalent implementation does'nt type: crash versions: Python 2.7 __

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Martin Panter added the comment: See Issue 1186900 about the NNTP client raising EOFError. As for the “cannot read from timed out object” errors (also reported in Issue 19613), I think the test classes are bad. The test logs don’t seem to be available, but I reckon that the previous test to th

[issue22442] Deprecate PIPE with subprocess.check_call() and call()

Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.6 -Python 3.5 ___ Python tracker ___ ___

[issue22442] Deprecate PIPE with subprocess.check_call() and call()

Akira Li added the comment: Martin, thank you for the review. As Matthias mentioned, the introduction of subprocess.run() perhaps deprecates this issue: old api should be left alone to avoid breaking old code, new code should use new api, those who need old api (e.g., to write 2/3 compatible

[issue24400] Awaitable ABC incompatible with functools.singledispatch

Stefan Behnel added the comment: I added three more comments to the review. The rest looks good to me, too. -- ___ Python tracker ___

[issue24259] tar.extractall() does not recognize unexpected EOF

Martin Panter added the comment: >From the current documentation and limited experience with the module, >ReadError (or a subclass) sounds best. I would only expect OSError only for >OS-level things, like file not found, disk error, etc. The patches look good. One last suggestion is to use ass

[issue16095] urllib2 failing with squid proxy and digest authentication

Martin Panter added the comment: I should point out my patch also adds add_password() methods for the authentication handlers to the documentation. These were only documented by example, but everyone seems to prefer using them rather than the equivalent password manager method. -- __

[issue16095] urllib2 failing with squid proxy and digest authentication

Martin Panter added the comment: There are two problems with the test case, and one bug in Python: 1. HTTPPasswordMgr doesn’t handle realm=None; it has to be a string. You can use HTTPPasswordMgrWithDefaultRealm though. 2. The password managers won’t match a proxy with a non-standard port numb