[issue24630] null pointer dereference in `load_newobj_ex`
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - out of date stage: - resolved status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24644] --help for runnable stdlib modules
R. David Murray added the comment: Please open individual issues to address individual modules that you would like to contribute to improving. Adding/fixing help is often best done by rewriting the argument parsing...contributions have been made to improve several modules already. In most cases we don't have tests for the -m features, and those need to be created first. In some cases we don't really want to continue to support whatever -m code exists (because it exists for no-longer-relevant historical reasons...though that doesn't apply in the two cases you reference). So each module needs to be addressed individually. To address the specific issue you raise: I believe that when we have rewritten things, we have chosen to follow argparse's lead and support both -h and --help for the display of help information. -- nosy: +r.david.murray resolution: - later stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24644 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24645] logging.handlers.QueueHandler should not lock when handling a record
R. David Murray added the comment: I can't see doing io in __repr__ ever making sense, so I'm not sure this is a use case we care about. But Vinay might not have any objection to removing locking if it is redundant, so we'll see what he has to say. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24645 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23601] use small object allocator for dict key storage
Stefan Behnel added the comment: Benchmark results look good to me (although a header line is missing) and seem to match my expectations. Sounds like we should allow this change. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23601 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24632] Improve documentation about __main__.py
Ezio Melotti added the comment: I think this is due to PEP 420 Namespace Packages. It works on Python 2 too: $ ls execdir/ foo.py __main__.py $ cat execdir/foo.py print(foo imported) $ cat execdir/__main__.py import foo; print(main imported) $ python execdir/ foo imported main imported $ python -V Python 2.7.8 I haven't done any tests about the interaction of namespace packages and __main__.py, but if there are additional semantics, they should be documented as well. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24632 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24642] Will there be an MSI installer?
New submission from Alex Walters: I use the *.msi installers for python to automate deployment of... an absurd number of python installations. I have been able to do this relatively easily, as the Windows installer didn't change much between 2.6 and 3.4 (possibly much longer than that, but I don't know about 2.5 or earlier). 3.5 added a new installer (the web installer), and apparently dropped the old standby *.msi installers, for the beta versions. Will there be *.msi installers for 3.5? -- components: Windows messages: 246796 nosy: paul.moore, steve.dower, tim.golden, tritium, zach.ware priority: normal severity: normal status: open title: Will there be an MSI installer? versions: Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24642 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24583] set.update(): Crash when source set is changed during merging
Roundup Robot added the comment: New changeset 5c3812412b6f by Raymond Hettinger in branch '3.5': Issue #24583: Fix crash when set is mutated while being updated. https://hg.python.org/cpython/rev/5c3812412b6f New changeset 05cb67dab161 by Raymond Hettinger in branch 'default': Issue #24583: Fix crash when set is mutated while being updated. https://hg.python.org/cpython/rev/05cb67dab161 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24583 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17359] Mention __main__.py explicitly in command line docs
Ezio Melotti added the comment: See also #24632. -- nosy: +ezio.melotti type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17359 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24642] Will there be an MSI installer?
Changes by STINNER Victor victor.stin...@gmail.com: -- components: +Installation ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24642 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23319] Missing SWAP_INTÂ in I_set_sw
Matthieu Gautier added the comment: The bug is also present in Python 2.7. Is it possible to backport this fix ? -- versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23319 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24583] set.update(): Crash when source set is changed during merging
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24583 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24621] zipfile.BadZipFile: File is not a zip file
Changes by Ronald Oussoren ronaldousso...@mac.com: -- nosy: +ronaldoussoren ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24621 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24632] Improve documentation about __main__.py
Davide Rizzo added the comment: As far as I understand, assuming dir/ contains a __main__.py file $ python dir is equivalent to $ python dir/__main__.py in that it's behaviourally nothing more than executing a script in that dir and setting sys.path accordingly. This is the same in Python 2 and Python 3. This, together with the notion that zip files and directories are treated in the same way, allows running python file.zip since we have no option for executing a file *within* the zip file. Altogether, this is a significantly different behaviour than the one for python -m pkg. That would be closer to: import pkg.__main__ This also explains why the package __init__ is executed first (you import the package first, then the module). A significant difference is that it's not a real import (just as pkg.__init__ is not imported) and sys.modules is not affected. -- nosy: +davide.rizzo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24632 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24621] zipfile.BadZipFile: File is not a zip file
Serhiy Storchaka added the comment: unzip can't proceed this file too. $ unzip -v not_working.zip Archive: not_working.zip End-of-central-directory signature not found. Either this file is not a zipfile, or it constitutes one disk of a multi-part archive. In the latter case the central directory and zipfile comment will be found on the last disk(s) of this archive. unzip: cannot find zipfile directory in one of not_working.zip or not_working.zip.zip, and cannot find not_working.zip.ZIP, period. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24621 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24642] Will there be an MSI installer?
Matthew Barnett added the comment: There's an executable installer; it's a .exe instead of a .msi. -- nosy: +mrabarnett ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24642 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
New submission from James Salter:
For python 3.5, PC/pyconfig.h contains the following for vs2015 support:
/* VS 2015 defines these names with a leading underscore */
#if _MSC_VER = 1900
#define timezone _timezone
#define daylight _daylight
#define tzname _tzname
#endif
This breaks any python extension code that includes pyconfig.h and then defines
any function or variable called 'timezone', 'daylight', or 'tzname'.
My breaking case is a conflict with ucrt/sys/timeb.h from the Windows 10 kit
(for me: c:\program files (x86)\Windows
Kits\10\include\10.0.10056.0\ucrt\sys\timeb.h). This is used during compilation
of gevent, which includes that file via libev/ev_win32.c. timeb.h contains this
innocent structure:
struct __timeb32
{
__time32_t time;
unsigned short millitm;
short timezone;
short dstflag;
};
I think we need a different approach that doesn't conflict with common english
variable names and in particular other windows SDK includes.
--
components: Extension Modules
messages: 246803
nosy: James Salter
priority: normal
severity: normal
status: open
title: VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
type: behavior
versions: Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24643
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
Zachary Ware added the comment: I suppose we'll have to resort to #ifndef _Py_timezone #if _MSC_VER = 1900 #define _Py_timezone _timezone #else #define _Py_timezone timezone #endif #endif ... -- components: +Build, Windows -Extension Modules nosy: +paul.moore, steve.dower, tim.golden, zach.ware stage: - needs patch versions: +Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24643 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
Steve Dower added the comment: Or we could define _timezone on those platforms that don't have the underscore. I'm not hugely fussed either way. We need to fix this though. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24643 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
STINNER Victor added the comment: Can't we move the #define only in .c files where they are needed? Or in a private header (not included by Python.h)? -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24643 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
Steve Dower added the comment: That's probably an option, though it would break extensions that use `timezone` expecting it to work. But it seems like any change is going to cause that. I prefer defining _Py_timezone, since at least we can offer something that is portable for all Python 3.5 platforms (that support timezones), unlike timezone/_timezone (MSVC deprecated `timezone` a few versions ago and has just removed it completely, hence the breakage). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24643 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24644] --help for runnable stdlib modules
New submission from Antony Lee:
Support for python -mrunnable-stdlib-module [-h|--help] is a bit patchy right
now:
$ python -mpdb -h
usage: pdb.py [-c command] ... pyfile [arg] ...
help elided
$ python -mpdb --help
Traceback (most recent call last):
File /usr/lib/python3.4/runpy.py, line 170, in _run_module_as_main
__main__, mod_spec)
File /usr/lib/python3.4/runpy.py, line 85, in _run_code
exec(code, run_globals)
File /usr/lib/python3.4/pdb.py, line 1685, in module
pdb.main()
File /usr/lib/python3.4/pdb.py, line 1629, in main
opts, args = getopt.getopt(sys.argv[1:], 'hc:', ['--help', '--command='])
File /usr/lib/python3.4/getopt.py, line 93, in getopt
opts, args = do_longs(opts, args[0][2:], longopts, args[1:])
File /usr/lib/python3.4/getopt.py, line 157, in do_longs
has_arg, opt = long_has_args(opt, longopts)
File /usr/lib/python3.4/getopt.py, line 174, in long_has_args
raise GetoptError(_('option --%s not recognized') % opt, opt)
getopt.GetoptError: option --help not recognized
# -- not a getopt specialist but --help is actually listed in the call to
getopt!
$ python -mtrace -h
/usr/lib/python3.4/trace.py: option -h not recognized
Try `/usr/lib/python3.4/trace.py --help' for more information
$ python -mtrace --help
Usage: /usr/lib/python3.4/trace.py [OPTIONS] file [ARGS]
help elided
--
components: Library (Lib)
messages: 246808
nosy: Antony.Lee
priority: normal
severity: normal
status: open
title: --help for runnable stdlib modules
versions: Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24644
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24630] null pointer dereference in `load_newobj_ex`
Brad Larsen added the comment: Yeah, this appears to be fixed along with #24552. -- status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24630 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23247] Crash in the reset() method of StreamWriter of CJK codecs
Aaron Hill added the comment: I've added a test case to exercise reset() -- Added file: http://bugs.python.org/file39934/fix-multibytecodec-segfault-with-test.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23247 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24645] logging.handlers.QueueHandler should not lock when handling a record
Justin Bronder added the comment:
On 16/07/15 20:03 +, R. David Murray wrote:
R. David Murray added the comment:
Can you expand on the deadlock? Are you saying that the extra locking is
causing the deadlock?
--
nosy: +r.david.murray, vinay.sajip
versions: -Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24645
___
Sure, here is the simplest example of the deadlock I could come up with. Using
__repr__() in the way presented is pretty stupid in this case but it does make
sense if you have objects which are backed by a database where communication is
handled in a separate thread.
What happens is this:
1. The main thread calls into the logger, handle() grabs the I/O lock.
2. String expansion of the Blah instance begins, this makes a request to the
second thread.
3. The second thread wants to log prior to responding, it gets stuck waiting
for
the I/O lock in handle()
import logging
import logging.handlers
import queue
import types
import threading
fmt = logging.Formatter('LOG: %(message)s')
stream = logging.StreamHandler()
stream.setFormatter(fmt)
log_queue = queue.Queue(-1)
queue_handler = logging.handlers.QueueHandler(log_queue)
queue_listener = logging.handlers.QueueListener(log_queue, stream)
queue_listener.start()
def handle(self, record):
rv = self.filter(record)
if rv:
self.emit(record)
return rv
# Uncomment to remove deadlock
#queue_handler.handle = types.MethodType(handle, queue_handler)
logger = logging.getLogger()
logger.addHandler(queue_handler)
logger.setLevel(logging.DEBUG)
class Blah(object):
def __init__(self):
self._in = queue.Queue()
self._out = queue.Queue()
def pub():
self._in.get(block=True)
logging.info('Got a request')
self._out.put('hi')
self._pub_thread = threading.Thread(target=pub)
self._pub_thread.start()
def __repr__(self):
self._in.put('gimme data')
return self._out.get()
def __del__(self):
self._pub_thread.join()
b = Blah()
logger.info('About to log')
logger.info('blah = %s', b)
queue_listener.stop()
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24645
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19918] PureWindowsPath.relative_to() is not case insensitive
Changes by Aaron Meurer aaron.meu...@continuum.io: -- nosy: +Aaron Meurer ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19918 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24645] logging.handlers.QueueHandler should not lock when handling a record
New submission from Justin Bronder: The Queue backing the QueueHandler is already sufficiently locking for thread-safety. This isn't a huge issue, but the QueueHandler is a very nice built-in which could be used to work around a deadlock I've encountered several times. In brief, functions which can cause other threads to log being called from either __repr__() or __str__(). -- components: Library (Lib) files: queue-handler-no-lock.patch keywords: patch messages: 246812 nosy: jsbronder priority: normal severity: normal status: open title: logging.handlers.QueueHandler should not lock when handling a record versions: Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6 Added file: http://bugs.python.org/file39935/queue-handler-no-lock.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24645 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
Steve Dower added the comment: It's not, but #include python.h in any extension will make it available for you, so it's very likely that extensions have simply used it without adding their own conditional compilation for the various interpretations of whether timezone is standard or not. Bit of a strawman, granted. Maybe working at Microsoft has made me overly cautious about changes that could break *anyone* - it's a big deal in many groups here. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24643 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23601] use small object allocator for dict key storage
Mark Shannon added the comment: +1 from me. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23601 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24646] Python accepts SSL certificate that should be rejected on OSX
New submission from Jussi Pakkanen:
Create a dummy certificate and build an ssl context like this:
ctx = ssl.SSLContext(ssl.PROTOCOL_TLSv1)
ctx.verify_mode = ssl.CERT_REQUIRED
ctx.load_verify_locations(cadata=dummy_certificate)
Then try to connect to a public service like this:
u = urllib.request.urlopen('https://www.google.com', context=ctx)
data = u.read()
Python will validate the server certificate even though it should reject it.
Attached is a script to demonstrate this.
This happens with Python 3.4.3 on OSX 10.10.4. Running the same script in
Ubuntu raises a certificate rejection exception as expected.
--
components: Library (Lib)
files: sslbug.py
messages: 246813
nosy: jpakkane
priority: normal
severity: normal
status: open
title: Python accepts SSL certificate that should be rejected on OSX
type: security
versions: Python 3.4
Added file: http://bugs.python.org/file39936/sslbug.py
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24646
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23247] Crash in the reset() method of StreamWriter of CJK codecs
Roundup Robot added the comment: New changeset 35a6fe0e2b27 by Victor Stinner in branch '3.4': Closes #23247: Fix a crash in the StreamWriter.reset() of CJK codecs https://hg.python.org/cpython/rev/35a6fe0e2b27 -- nosy: +python-dev resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23247 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
STINNER Victor added the comment: For me, it's not the responsability of python.h to ensure that the timezone symbol is available. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24643 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
Steve Dower added the comment: Agreed. However, I also don't want extensions to stop building because of a change we make. But since that's inevitable here, let's go with Zach's original suggestion and use a name that won't conflict. (IIRC, I originally put the #ifdefs in each file and was told to move them to pyconfig.h...) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24643 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24647] Document argparse.REMAINDER as being equal to ...
New submission from Antony Lee:
Currently the argparse docs mention the special values +, * and ? by
their actual values instead of argparse.{ONE_OR_MORE,ZERO_OR_MORE,OPTIONAL},
but argparse.REMAINDER is mentioned as is. It seems easier to just use its
actual value (...) in the docs as well.
--
components: Library (Lib)
messages: 246824
nosy: Antony.Lee
priority: normal
severity: normal
status: open
title: Document argparse.REMAINDER as being equal to ...
versions: Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24647
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24648] Allocation of values array in split dicts should use small object allocator.
New submission from Mark Shannon: Issue 23601 advocates using the small object allocator for dict-keys objects and the results of tests are good. Using the small object allocator for dict value-arrays as well seems like the obvious next step. -- components: Interpreter Core keywords: easy messages: 246828 nosy: Mark.Shannon priority: low severity: normal stage: needs patch status: open title: Allocation of values array in split dicts should use small object allocator. type: performance versions: Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24648 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23601] use small object allocator for dict key storage
Mark Shannon added the comment: Yes, but that shouldn't block this issue. I've opened issue 24648 instead. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23601 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24645] logging.handlers.QueueHandler should not lock when handling a record
R. David Murray added the comment: Can you expand on the deadlock? Are you saying that the extra locking is causing the deadlock? -- nosy: +r.david.murray, vinay.sajip versions: -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24645 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24648] Allocation of values array in split dicts should use small object allocator.
STINNER Victor added the comment: If it's an optimization, we need benchmarks. We should also try to modify PyMem allocator to simply be an alias to PyObject allocator. I expect a little speedup. I'm not talking for the specific case of the dict type, but for all Python. -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24648 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
STINNER Victor added the comment: That's probably an option, though it would break extensions that use `timezone` expecting it to work. Hum, I don't remember that the timezone symbol of part of the Python public API. Which extensions? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24643 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23247] Crash in the reset() method of StreamWriter of CJK codecs
STINNER Victor added the comment: @Aaron Hill: Thanks for your patch! I only kept the minimal test of your patch. If you want to enhance the test suite, you may write new test to test the behaviour of reset(). I prefer to only commit the minimum patch. @Martin: Thanks for your report. The issue is now fixed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23247 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23601] use small object allocator for dict key storage
Serhiy Storchaka added the comment: If use small object allocator for dict key storage, why not use it for dict value storage? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23601 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24643] VS 2015 pyconfig.h #define timezone _timezone conflicts with timeb.h
Zachary Ware added the comment: (IIRC, I originally put the #ifdefs in each file and was told to move them to pyconfig.h...) Yeah, I think I did suggest that, to match what we do with hypot/_hypot for MSC 1600+. We should probably also change that one while fixing timezone, daylight, and tzname. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24643 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21750] mock_open data is visible only once for the life of the class
Changes by Berker Peksag berker.pek...@gmail.com: -- stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21750 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21750] mock_open data is visible only once for the life of the class
Berker Peksag added the comment: LGTM. A minor comment: +def test_mock_open_reuse_issue_21750(self): We can also add an assert to check the data is actually data (e.g. assertEqual(f1.read(), 'data')). -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21750 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24644] --help for runnable stdlib modules
Antony Lee added the comment: To be honest I don't really plan to contribute any patch on this specific issue right now, the CLI interface of e.g. trace has some other serious issues (see e.g. #24649) that I don't want to work out, and writing tests for the CLI are a pain too (also why I haven't made more progress on #23596). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24644 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24649] python -mtrace --help is wrong
New submission from Antony Lee: While working on #24644, I noticed that the help for python -mtrace is quite wrong. $ python -mtrace --help Usage: /usr/lib/python3.4/trace.py [OPTIONS] file [ARGS] Meta-options: --helpDisplay this help then exit. --version Output version information then exit. Otherwise, exactly one of the following three options must be given: -t, --trace Print each line to sys.stdout before it is executed. -c, --count Count the number of times each line is executed and write the counts to module.cover for each module executed, in the module's directory. See also `--coverdir', `--file', `--no-report' below. -l, --listfuncs Keep track of which functions are executed at least once and write the results to sys.stdout after the program exits. -T, --trackcalls Keep track of caller/called pairs and write the results to sys.stdout after the program exits. -r, --report Generate a report from a counts file; do not execute any code. `--file' must specify the results file to read, which must have been created in a previous run with `--count --file=FILE'. elided modifier flags 1. Obviously, there are more than 3 options there. 2. Simple testing suggests that it is at least possible to pass both -t and -c simultaneously. I haven't tested other combinations. -- components: Library (Lib) messages: 246834 nosy: Antony.Lee priority: normal severity: normal status: open title: python -mtrace --help is wrong versions: Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24649 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24645] logging.handlers.QueueHandler should not lock when handling a record
Vinay Sajip added the comment: I'm not sure I want to make a special case just to support what seems like a somewhat pathological use case (no offence intended). If you need this, there's no reason you couldn't subclass QueueHandler and override handle(), is there? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24645 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24645] logging.handlers.QueueHandler should not lock when handling a record
Vinay Sajip added the comment: I agree the lock could be seen as redundant as there are no shared data structures used by the current implementation of the enqueue and prepare methods (which are called after the lock is acquired), but users could potentially override those methods in subclasses in ways that require locking to be thread-safe. Currently, people overriding emit() [or code called from there] know that any state they manipulate there is protected by the handler lock - and this would not be the case if I implemented your suggestion. It could certainly break subclasses of QueueHandler which are out there in the wild. Note that the reference to locking is there in the Handler.handle docstring - https://docs.python.org/library/logging.html#logging.Handler.handle - so changing it would change the contract which is documented. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24645 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24642] Will there be an MSI installer?
Alex Walters added the comment: Related to the exe installer... /? lists only 4 options, none of which are useful in restricting the installation, or changing its location. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24642 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24645] logging.handlers.QueueHandler should not lock when handling a record
Justin Bronder added the comment: On 16/07/15 23:21 +, Vinay Sajip wrote: Vinay Sajip added the comment: I'm not sure I want to make a special case just to support what seems like a somewhat pathological use case (no offence intended). If you need this, there's no reason you couldn't subclass QueueHandler and override handle(), is there? Hey, no offense taken, it wasn't even my code that tripped on this, I just got the pleasure of debugging it! Anyways, it's up to you all if you want to include this, as you mentioned, it's easy enough to work around and I've already done so. However, the reason I submitted the patch is because I believe using the I/O lock is redundant as the Queue is handling the necessary synchronization already. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24645 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24642] Will there be an MSI installer?
Alex Walters added the comment: and...you already addressed that. Ignore previous. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24642 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21238] unittest.mock.Mock should not allow you to use non-existent assert methods
John Allison added the comment: That probably IS a joke. Why not fix the underlying issue instead? -- nosy: +John Allison ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21238 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
