Fabian added the comment:
It is consistent as in it happens on every run of the test suite. But
unfortunately I haven't checked if it's always happening at the same place.
Luckily we have 4 builds on Travis with 3.6 and in all it happened from the
beginning and got 100 matches for
Yury Selivanov added the comment:
Meador, the patch looks OK. Could you please commit it yourself?
--
assignee: - meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24485
___
Ethan Furman added the comment:
My experience is that a module maintainer, or somebody claiming to speak for
the module maintainer, can close any issue in their area at any time regardless
of the number of core devs in favor of a change.
Whatever. I'll leave this open and write up a spec of
Robert Collins added the comment:
Ok, so as a doc bug this should still be tracked here - I'm going to reopen it
to reflect that, hope thats ok.
--
assignee: - docs@python
components: +Documentation
nosy: +docs@python
resolution: not a bug -
status: closed - open
title:
Carl Meyer added the comment:
Er, I meant `AttributeError`, of course...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24651
___
___
Carl Meyer added the comment:
As a frequent and long-time user of mock, the `assert_*` methods being on the
mock object itself has always struck me as an unfortunate wart on an otherwise
great library. The change to raise `AssertionError` on `assert_*` and
`assret_*` feels like piling an ugly
Martin Panter added the comment:
Patch v15. No doc changes, but I refactored the test code:
* Manually merged with recent changes
* Separate assert_equality_only() and assert_total_order() test methods.
Hopefully this is a bit simpler for people to understand and review, and avoids
suggesting
New submission from Raymond Hettinger:
Since the *found_active* exit is like the *found_error* exit in that it makes
no further use of *entry*, it can be moved before the table/entry_key check
whose purpose is to make sure the *entry* pointer is still valid. This change
doesn't apply to
Roundup Robot added the comment:
New changeset 53c0c8914ad0 by Zachary Ware in branch '2.7':
Issue #24603: Update Windows build to use OpenSSL 1.0.2d
https://hg.python.org/cpython/rev/53c0c8914ad0
New changeset f4cd9ac378d7 by Zachary Ware in branch '3.4':
Issue #24603: Update the Windows build
New submission from Carol Willing:
Add a Quick Start: Communications section to devguide (or Q S: Community
Interaction) as discussed on python-dev mailing list today.
The Quick Start: Communications section should be brief, link to other sections
in the devguide, and give contributor's
Roundup Robot added the comment:
New changeset f02c5bf59fbb by Yury Selivanov in branch '3.5':
Issue #24669: Fix inspect.getsource() for 'async def' functions.
https://hg.python.org/cpython/rev/f02c5bf59fbb
New changeset 6629773fef63 by Yury Selivanov in branch 'default':
Merge 3.5 (Issue
Yury Selivanov added the comment:
Thanks, Kai!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
versions: +Python 3.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24669
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22123
___
___
Nick Coghlan added the comment:
Patch test cases look good to me.
I'm so used to thinking of the tokenisation phase as a linear token stream
that it never occurred to me to just count the function nesting directly to
determine if the async def tokenisation rules are in effect - it's a very
Kevin Benton added the comment:
What about other methods/properties like called, call_count, and reset_mock? It
seems that they should be removed as well to be consistent with the reason for
this change.
--
nosy: +kevinbenton
___
Python tracker
Roundup Robot added the comment:
New changeset 91b738cfdc2f by Zachary Ware in branch '2.7':
Issue #24680: Remove random backslash. Patch by cdz.
https://hg.python.org/cpython/rev/91b738cfdc2f
New changeset cf0011b6ebbd by Zachary Ware in branch '3.4':
Issue #24680: Remove random backslash.
New submission from cdz:
In section 3. Building C and C++ Extensions with distutils there is
unnecessary \ in the middle of the line. Seems to be bulk (re)formatting
issue.
Simple patch fixing the issue is attached.
--
assignee: docs@python
components: Documentation
files:
Robert Collins added the comment:
So the 1.1.4 behaviour matches that of a VFS most closely. But, see the earlier
messages, it does do only and precisely because it breaks regular mock idioms.
Thus I think we're better off with the new patch, which addresses the issue
with reuse of the mocks
Berker Peksag added the comment:
I think we can commit documentation and tests separately. I just did a quick
review of the test changes and I will add some review comments later (sorry,
lack of time :)).
--
nosy: +berker.peksag
___
Python tracker
Martin Panter added the comment:
FWIW I have wondered in the past why these constants were missing. I would be
more likely to use them when checking an exit status than when setting one. I
typically do “raise SystemExit()” or “raise SystemExit('Error message')”, which
implicitly sets the
Martin Panter added the comment:
Nice and obvious fix, looks like it also applies to Python 2.
--
nosy: +vadmium
stage: - commit review
versions: +Python 2.7, Python 3.4, Python 3.5
___
Python tracker rep...@bugs.python.org
Zachary Ware added the comment:
Fixed! Thanks for the report and patch, cdz, and thanks for the triage, Martin.
--
nosy: +zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24680
___
Felipe added the comment:
Not sure it's my place to comment here, but here are my 2 cents: I think
Robert's proposal to have module functions is the only way to have a
user-friendly and robust API, and it solves more than just the assert typo
problem. (And yes, it would require moving the
Serhiy Storchaka added the comment:
I would use test.support.swapattr().
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24678
___
Robert Collins added the comment:
Fixup patch. I've tested this with the reported failures and they all work.
--
Added file: http://bugs.python.org/file39967/issue-21750-2.patch
___
Python tracker rep...@bugs.python.org
Fabian added the comment:
Yes see the tests/README.rst. And afaik do you only need to have requests and
six installed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24667
___
Changes by Patrick Westerhoff patrickwesterh...@gmail.com:
--
nosy: +poke
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24651
___
___
New submission from Jacek Kołodziej:
The typo in test_logging was discovered while working on #23883: in two tests
the addCleanup call reverts the raiseEx*ec*ptions value (instead of
raiseExceptions) in logging module and apparently that didn't manifest itself
in any way.
Patch attached.
Robert Collins added the comment:
But - its worth discussing. Perhaps we should roll this all back, and just say
'use a vfs layer for tests like this'. The problem in doing that, is that the
@patch
def test_foo...
use case is actually pretty common IME, and this conflicts with the
@patch
...
Serhiy Storchaka added the comment:
Minimal example:
import array
a = array.array(B)
a.fromstring(b'x'*0x1)
a.fromstring(a)
a.fromstring(a)
In 3.x it doesn't work. An exception is raised:
Traceback (most recent call last):
File stdin, line 1, in module
BufferError: cannot resize an
Serhiy Storchaka added the comment:
LGTM.
--
assignee: - serhiy.storchaka
stage: - commit review
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24678
___
Roundup Robot added the comment:
New changeset 20e2b980bb87 by Serhiy Storchaka in branch '3.4':
Issue #24678: Fixed raiseExceptions typo in logging tests.
https://hg.python.org/cpython/rev/20e2b980bb87
New changeset 7a54e400155f by Serhiy Storchaka in branch '3.5':
Issue #24678: Fixed
Serhiy Storchaka added the comment:
Thank you for your contribution Jacek.
--
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24678
Eric Snow added the comment:
Thanks for the extra info. I'm going to see if I can reproduce the issue by
running the pywikibot test suite locally. What's the best way to set that up?
Are there instructions somewhere?
As to the C implementation, it was first released (as a special
Paul Koning added the comment:
Sure, you can use a vfs. That's true for a lot of mock functions; the benefit
of mock, including mock_open, is that it provides an easier and better packaged
way. The behavior expected is be like a file. So in that last example, if
you open it twice, you've
Changes by Antti Haapala an...@haapala.name:
--
nosy: +ztane
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24653
___
___
Python-bugs-list mailing
Jacek Kołodziej added the comment:
s/swapattr/swap_attr/g :) Done.
--
Added file: http://bugs.python.org/file39968/test_logging_typo.v2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24678
Changes by Serhiy Storchaka storch...@gmail.com:
--
priority: normal - release blocker
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14373
___
___
Changes by Antti Haapala an...@haapala.name:
--
nosy: +ztane
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24651
___
___
Python-bugs-list mailing
Steve Dower added the comment:
Afraid it's not possible - that error comes from the loader, so we haven't had
a chance to run anything yet.
One option would be to put some sort of readme into the zip, but that seems to
be optimising for the wrong behavior. If I were legitimately embedding
Cody Piersall added the comment:
Agreed. An ounce of data is worth a pound of theory as the saying goes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24679
___
New submission from Cody Piersall:
Whenever I tried to run the embeddable zip file from
https://www.python.org/downloads/windows/ for Python 3.5.0b3, the program
crashes with the message
The program can't start because api-ms-win-crt-math-l1-1-0.dll is missing
from your computer. Try
R. David Murray added the comment:
You shouldn't need visual studio to install python using the installer.
What verison of windows are you using?
--
nosy: +r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24679
R. David Murray added the comment:
Woops, I see you already said and I missed it. We'll have to wait for Steve to
take a look.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24679
___
Steve Dower added the comment:
That's exactly the use case, and I might borrow your summary for the docs
that I'll eventually write for it because you've summed it up really well.
My biggest worry right now is that people will treat it as a portable install
and run into exactly the issue that
Cody Piersall added the comment:
Yeah, having embeddable in the name is a good hint, I think. It was almost
enough for me to not even try downloading it.
Is it possible / even worth the time to give a more helpful error message? I'm
not sure that it's possible, based on when the dll is
Robert Collins added the comment:
@pkoning in Python3.3 == mock 1.0.1,
m = mock_open(read_data='f')
m().read()
'f'
m().read()
'f'
x = m()
x.read()
'f'
x.read()
'f'
x = m()
y = m()
x.read()
'f'
y.read()
'f'
in 3.4 == mock 1.1.{0,1,2,3}, and 1.2.0
m = mock_open(read_data='f')
Changes by Cody Piersall cody.piers...@gmail.com:
--
components: +Windows
nosy: +paul.moore, tim.golden, zach.ware
type: - crash
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24679
___
John Beck added the comment:
First, there are two related but somewhat separate issues here.
Regarding the patches attached to http://bugs.python.org/issue20664
they seem fine. In theory, they should not be needed, as though it
is true that dump(1) moved from /usr/ccs/bin to /usr/bin in
Cody Piersall added the comment:
Ah! That makes sense. I still think the embeddable Python could be useful, but
I don't actually have a vested interest in it at the moment. Mostly I feel
like it would be useful if Python is an implementation detail of an
application, and you want to make
dlroo added the comment:
If you are using mx.DateTime make certain you do not use the .strftime method.
If you use .strftime method and have a 60th second in your DateTime object it
will crash python with no error message. This occurs because the .strftime
method is fully inherited from
Meador Inge added the comment:
Will do. Thanks for the review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24485
___
___
Python-bugs-list
Jeff Quast added the comment:
John, What do you think of the patches attached to
http://bugs.python.org/issue20664 ?
crle is not needed at all because the default library path is
a constant on Solaris
I don't believe this to be true, source? crle is absolutely needed to add
additional
Steve Dower added the comment:
Yeah, I need to clearly document that you are responsible for installing the C
Runtime yourself.
My current theory is that embedding applications will also require the CRT (at
least those that intend to load python3.dll or python35.dll directly), and so
it's
Jeff Quast added the comment:
I looked over the focus on default path, thank you for clarifying!
Sadly, I can't help you move either of these patches forward, best wishes!
--
___
Python tracker rep...@bugs.python.org
Martin Panter added the comment:
Actually, this is about a different section of the documentation. But it might
still be best to update /Doc/reference/expressions.rst first in Issue 12067,
and then sort out /Doc/library/stdtypes.rst to match.
Why do we need a dedicated section in Built-in
Fabian added the comment:
Okay I did a test run on all three 3.5 betas available to me through pyenv. The
beta 3 failed as Python 3.6 does that popitem() raises a KeyError. The beta 2
had the bug that popitem() does not support keyword arguments so I wasn't able
to test it there. And the beta
Changes by Ben Finney ben+pyt...@benfinney.id.au:
--
nosy: +bignose
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24651
___
___
Python-bugs-list
Eric Snow added the comment:
I've thus far been unsuccessful in running the pywikibot test suite. I'm
guessing there are some prerequisites (e.g. an account on some wiki site). Is
there a way to run the tests without network access? Also, I ran into some
trouble with i18n.__file__, but
Paul Koning added the comment:
So if I understand right, it seems to me the 3.5/mock 1.1.4 behavior is
correct. mock_open(read_data=f) acts like a file that contains f, and m()
acts like an open() of that file. So if I call open once, I should read the f,
then EOF. If I open twice, then
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14010
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22609
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23655
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21076
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Why have you rejected this issue Ethan? I think this is useful feature and must
be in Python, and other core developers agreed with this. Only minor
implementation details are discussable.
--
___
Python tracker
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17963
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22867
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22656
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
versions: +Python 3.5 -Python 2.7, Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6549
___
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22738
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21406
___
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24195
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17546
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24052
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14376
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21327
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24045
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17576
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23123
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22680
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
resolution: - rejected
stage: needs patch -
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19624
___
Changes by Ethan Furman et...@stoneleaf.us:
--
resolution: - not a bug
stage: patch review -
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1615
___
Carol Willing added the comment:
Closing this issue since a newer issue #24440 addresses devguide documentation
of installing and running a buildbot. Thanks to R. David Murray for submitting
the patch to #24440.
--
nosy: +willingc
resolution: - duplicate
stage: patch review -
Serhiy Storchaka added the comment:
What textwrap does not take into account the width of characters is not the
only problem. It also does not take into account combining characters and
control codes. Implementing all this will significantly complicate the code and
possibly should lie outside
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22625
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23699
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24056
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23572
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18173
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22698
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23556
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22790
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17044
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17421
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16508
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10614
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22555
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15582
___
___
Python-bugs-list
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: -ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
___
Python-bugs-list
Fabian added the comment:
Well as I described in the opening post:
I don't think versions before Python 3.6 are affected as we had tests running
on Python 3.5 (before Travis switched to 3.6 recently) and these all worked.
Now tbh I don't know if a version of 3.5 is affected but was never
1 - 100 of 163 matches
Mail list logo
