[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0681f0a1fe6e by Victor Stinner in branch '3.5': Windows: Decode hostname from ANSI code page https://hg.python.org/cpython/rev/0681f0a1fe6e New changeset 26f6d8cc2749 by Victor Stinner in branch 'default': Merge 3.5: Issue #26227

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread STINNER Victor
STINNER Victor added the comment: Steve: """ I couldn't remember the names of the alternate functions Windows provides to do the encoding for you, but yes. There are socket APIs there that do encoding and handle memory allocation more safely. Apart from bugs like this, it's not really urgent

[issue26222] Missing code in linux_distribution python 2.7.11

2016-01-28 Thread Kevin Dwyer
Kevin Dwyer added the comment: The quoted code doesn't exist in 2.7.10 (https://hg.python.org/cpython/file/v2.7.10/Lib/platform.py) It looks like it's from a patch applied by Debian themselves: see

[issue21201] Uninformative error message in multiprocessing.Manager()

2016-01-28 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue26233] select.epoll.poll() should away calling malloc() each time

2016-01-28 Thread STINNER Victor
STINNER Victor added the comment: > Overallocating by 50% might be overkill here; I wouldn't imagine most users > of epoll.poll would use anything but: (...) See my second message: "My patch also overallocates the buffer by 50% to avoid calling realloc() to many times. Using the selectors

[issue26232] Mock(spec=spec) has no effect

2016-01-28 Thread SilentGhost
Changes by SilentGhost : -- nosy: +michael.foord ___ Python tracker ___ ___

[issue26231] HTTPResponse.close() should consume all remaining data in body if any

2016-01-28 Thread Jacky
Jacky added the comment: In my opinion, HTTPResponse.close() should do really close work. Not only releasing the underlying file obj but also need to consume the remaining data to make sure the request complete. If close() does not consume the remaining data, the user would have to do it

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread Emanuel Barry
Emanuel Barry added the comment: Yes, it's not all that urgent. And Victor's latest patch doesn't work, either :( I wonder if there's a way to (temporarily) modify the output of ``socket.gethostname()`` to be able to test such weird corner cases. --

[issue26233] select.epoll.poll() should away calling malloc() each time

2016-01-28 Thread Josh Rosenberg
Josh Rosenberg added the comment: Overallocating by 50% might be overkill here; I wouldn't imagine most users of epoll.poll would use anything but: 1. Limit to 1 event 2. Limit to some constant K events 3. Use default maxevents (FD_SETSIZE - 1) Even if called in pathological order, that would

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread STINNER Victor
STINNER Victor added the comment: > Yes, it's not all that urgent. And Victor's latest patch doesn't work, either > :( Could you please elaborate? The patch applies cleanly? You rebuild the socket module? Which error message do you get? -- ___

[issue26233] select.epoll.wait() should away calling malloc() each time

2016-01-28 Thread STINNER Victor
STINNER Victor added the comment: I dislike allocating large memory block on the stack, we should not abuse it. I propose instead to store the memory block allocated on the heap in the epoll object. Attached patch implements this idea. The buffer is stolen from the epoll object when

[issue26206] test_socket.testRecvmsgPeek() timeout on "AMD64 Debian root 3.x" buildbot

2016-01-28 Thread Martin Panter
Martin Panter added the comment: The problem has apparently been fixed at the buildbot end -- resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker

[issue26234] The typing module includes 're' and 'io' in __all__

2016-01-28 Thread Martin Panter
Martin Panter added the comment: My concern with pydoc is that currently when you do “python -m pydoc typing” you get stuff like CLASSES builtins.object typing.io typing.re [. . .] io = class typing.io(builtins.object) | Wrapper namespace for IO

[issue25868] test_eintr.test_sigwaitinfo() hangs on "AMD64 FreeBSD CURRENT 3.x" buildbot

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset ddce15b21c21 by Victor Stinner in branch '3.5': Backport fixes on test_eintr https://hg.python.org/cpython/rev/ddce15b21c21 -- ___ Python tracker

[issue25234] test_eintr.test_os_open hangs under Xcode 7

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset ddce15b21c21 by Victor Stinner in branch '3.5': Backport fixes on test_eintr https://hg.python.org/cpython/rev/ddce15b21c21 -- ___ Python tracker

[issue26222] Missing code in linux_distribution python 2.7.11

2016-01-28 Thread Kevin Dwyer
Changes by Kevin Dwyer : -- type: performance -> behavior ___ Python tracker ___ ___

[issue26233] select.epoll.wait() should away calling malloc() each time

2016-01-28 Thread STINNER Victor
STINNER Victor added the comment: > Any benchmarks? Wait, it's easier to write a patch than to cook a benchmark :-) Attached script bench_epoll_poll.py creates a lot of sockets and call epoll.poll() in non-blocking mode (timeout=0). You can decide to create or not events. It looks like

[issue26202] The range() object is deepcopied as atomic

2016-01-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Victor. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue26202] The range() object is deepcopied as atomic

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5772eae17a82 by Serhiy Storchaka in branch '3.5': Issue #26202: copy.deepcopy() now correctly copies range() objects with https://hg.python.org/cpython/rev/5772eae17a82 New changeset d5d0b62c2830 by Serhiy Storchaka in branch 'default': Issue

[issue26198] PyArg_ParseTuple with format "et#" and "es#" detects overflow by raising TypeError instead of ValueError

2016-01-28 Thread Martin Panter
Martin Panter added the comment: One review comment -- nosy: +martin.panter ___ Python tracker ___ ___

[issue26186] LazyLoader rejecting use of SourceFileLoader

2016-01-28 Thread Brett Cannon
Brett Cannon added the comment: I think I'm liking the following approach: if __debug__: hopefully_None = loader.create_module(spec) if hopefully_None is not None: warnings.warn("watch out!", ImportWarning) -- ___ Python tracker

[issue19883] Integer overflow in zipimport.c

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 82ee3c24bb86 by Serhiy Storchaka in branch '2.7': Fixed an infinite loop in zipimport caused by cebcd2fd3e1f (issue #19883). https://hg.python.org/cpython/rev/82ee3c24bb86 -- ___ Python tracker

[issue19883] Integer overflow in zipimport.c

2016-01-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Martin. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26198] PyArg_ParseTuple with format "et#" and "es#" detects overflow by raising TypeError instead of ValueError

2016-01-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is updated patch. -- Added file: http://bugs.python.org/file41746/pyarg_parse_encoded_string_2.patch ___ Python tracker

[issue26232] Mock(spec=spec) has no effect

2016-01-28 Thread Michael Foord
Michael Foord added the comment: create_autospec and Mock(spec=spec) are very different. Mock(spec=spec) creates a mock object with the same *attributes* as the original. It does not create functions like create_autospec can. -- resolution: -> not a bug stage: -> resolved status:

[issue26233] select.epoll.wait() should away calling malloc() each time

2016-01-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Any benchmarks? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19883] Integer overflow in zipimport.c

2016-01-28 Thread Martin Panter
Martin Panter added the comment: This seems to be causing an infinite loop in 2.7, in test_cmd_line_script.CmdLineTest.test_module_in_package_in_zipfile(): test_module_in_package_in_zipfile (test.test_cmd_line_script.CmdLineTest) ... ^C Test suite interrupted by signal SIGINT. 1 test omitted:

[issue26233] select.epoll.poll() should avoid calling malloc() each time

2016-01-28 Thread STINNER Victor
Changes by STINNER Victor : -- title: select.epoll.poll() should away calling malloc() each time -> select.epoll.poll() should avoid calling malloc() each time ___ Python tracker

[issue26198] PyArg_ParseTuple with format "et#" and "es#" detects overflow by raising TypeError instead of ValueError

2016-01-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Martin. This was 64-bit specific bug. -- ___ Python tracker ___

[issue25314] Documentation: argparse's actions store_{true, false} default to False/True (undocumented)

2016-01-28 Thread Martin Panter
Martin Panter added the comment: I definitely agree with removing the remark about the “const” value with store_const. People here seem to be overloading the terms “default” and “argument”. When using store_const, it seems the programmer must also specify a value for the “const” parameter to

[issue25314] Documentation: argparse's actions store_{true, false} default to False/True (undocumented)

2016-01-28 Thread paul j3
paul j3 added the comment: How about: These store the values True and False respectively (and default to False and True if absent). The reference to `store_const` is confusing, since almost no one uses that action. The `store_const` paragraph has: (Note that the const keyword

[issue26229] Make number serialization ES6/V8 compatible

2016-01-28 Thread SilentGhost
Changes by SilentGhost : -- components: +Extension Modules -Interpreter Core nosy: +ezio.melotti, pitrou, rhettinger versions: +Python 3.6 -Python 3.5 ___ Python tracker

[issue26222] Missing code in linux_distribution python 2.7.11

2016-01-28 Thread Martin Panter
Martin Panter added the comment: I think Kevin is right. Debian often carries its own downstream patches. In this case, the patch was proposed in Issue 9514, which is closed as “won’t fix”. In Python 3, linux_distribution() is apparently deprecated (Issue 1322). -- components:

[issue26194] Undefined behavior for deque.insert() when len(d) == maxlen

2016-01-28 Thread Raymond Hettinger
Raymond Hettinger added the comment: Since slicing is going to be added to deques, it is worth thinking about what the behavior should be there as well: d = deque('abcde', maxlen=7) d[3:4] = 'efghijklm' Side note: repetition behaves like extend() using maxlen to decide how much to

[issue26198] PyArg_ParseTuple with format "et#" and "es#" detects overflow by raising TypeError instead of ValueError

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1c690cb4def8 by Serhiy Storchaka in branch '3.5': Issue #26198: Added tests for "es", "et", "es#", "et#" and "C" format units https://hg.python.org/cpython/rev/1c690cb4def8 New changeset 745ad3010384 by Serhiy Storchaka in branch 'default': Issue

[issue19883] Integer overflow in zipimport.c

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 687be1cbe587 by Serhiy Storchaka in branch '3.5': Issue #19883: Fixed possible integer overflows in zipimport. https://hg.python.org/cpython/rev/687be1cbe587 New changeset f4631dc56ecf by Serhiy Storchaka in branch 'default': Issue #19883: Fixed

[issue24841] Some test_ssl network tests fail if svn.python.org is not accessible.

2016-01-28 Thread Martin Panter
Martin Panter added the comment: Yes sorry I did mean Issue 25940 (too many bug numbers!), but only the main change which has already been made (revision adf750b1252d etc). So you don’t have to wait for that. -- ___ Python tracker

[issue26207] test_distutils fails on "AMD64 Windows7 SP1 3.x" buildbot

2016-01-28 Thread Steve Dower
Steve Dower added the comment: This has been confirmed as a bug in VS 2015 RTM that was fixed in Update 1. It only affects debug builds, which are not common and I expect most people using them to be keeping VS up to date. I'd rather not add extra logic to distutils just to detect this case.

[issue26235] argparse docs: Positional * argument in mutually exclusive group requires a default parameter

2016-01-28 Thread paul j3
New submission from paul j3: The documentation for Mutual exclusion https://docs.python.org/3/library/argparse.html#mutual-exclusion needs a note that a mutually exclusive group may contain one positional argument. But that argument must be either nargs='?', or nargs='*'. If '*' it must

[issue19023] ctypes docs: Unimplemented and undocumented features

2016-01-28 Thread Martin Panter
Martin Panter added the comment: Okay I have committed the Array and _Pointer stuff. I suggest if anyone wants to work on the Union classes, they open a separate report. (I never understood what they are for. C doesn’t have much little or big endian stuff; byte order mostly depends on the

[issue20598] argparse docs: '7'.split() is confusing magic

2016-01-28 Thread Martin Panter
Martin Panter added the comment: I don’t want to make any controversial changes. Half the purpose of the patch was to let people see what it would look like. Another option would be to only do the single or empty list changes, and leave most of the longer lists as they are with split().

[issue26198] PyArg_ParseTuple with format "et#" and "es#" detects overflow by raising TypeError instead of ValueError

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset d0b4be7d2134 by Serhiy Storchaka in branch '2.7': Fixed a crash in new tests in test_getargs2 added in 60a2d67dacb3 (issue #26198). https://hg.python.org/cpython/rev/d0b4be7d2134 -- ___ Python tracker

[issue26207] test_distutils fails on "AMD64 Windows7 SP1 3.x" buildbot

2016-01-28 Thread STINNER Victor
STINNER Victor added the comment: > I'd rather not add extra logic to distutils just to detect this case. Hum, does it make sense to skip some tests on VS 2015 without the update? (Is it difficult to detect VS version?) -- ___ Python tracker

[issue26234] The typing module includes 're' and 'io' in __all__

2016-01-28 Thread Guido van Rossum
Changes by Guido van Rossum : -- assignee: -> gvanrossum type: -> behavior ___ Python tracker ___

[issue26198] PyArg_ParseTuple with format "et#" and "es#" detects overflow by raising TypeError instead of ValueError

2016-01-28 Thread Martin Panter
Martin Panter added the comment: Also, test_getargs2 seems faulty on 2.7. I am seeing MemoryError; some of the buildbots are segfaulting. -- ___ Python tracker

[issue25314] Documentation: argparse's actions store_{true, false} default to False/True (undocumented)

2016-01-28 Thread Julien Baley
Julien Baley added the comment: I like paul.j3's suggestion, but it would probably make more sense to have it consistent with python2 and port the change Martin pointed to. How does one do that? -- ___ Python tracker

[issue26207] test_distutils fails on "AMD64 Windows7 SP1 3.x" buildbot

2016-01-28 Thread Jeremy Kloth
Jeremy Kloth added the comment: My buildbot updated to VS2015.1 successfully. test_distutils is passing again. As to the bug title, it should mention the incorrect DLL version error, not the /LTCG *warning*. That's what I get for just doing a quick scan of the comments. --

[issue26234] The typing module includes 're' and 'io' in __all__

2016-01-28 Thread Guido van Rossum
New submission from Guido van Rossum: If you write "from typing import *" you get "re" and "io" for free, which is surprising if this import occurs after an actual "import re" or "import io". The solution is not to include those two in __all__. You can still use them -- use "from typing

[issue19023] ctypes docs: Unimplemented and undocumented features

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 034b077d3015 by Martin Panter in branch '2.7': Issue #19023: Document ctypes array and pointer classes https://hg.python.org/cpython/rev/034b077d3015 -- ___ Python tracker

[issue26234] The typing module includes 're' and 'io' in __all__

2016-01-28 Thread Martin Panter
Martin Panter added the comment: I would argue against changing this. They seem to be documented classes, so I guess this would break pydoc. It is a similar situation to os.open(), threading.enumerate(), etc. But I don’t have a strong opinion, and accept other people like keeping __all__ a

[issue26199] fix broken link to hamcrest.library.integration.match_equality in unittest.mock "getting started" documentation

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset e4b0f003ad13 by Berker Peksag in branch '3.5': Issue #26199: Fix broken link in unittest.mock-examples.rst https://hg.python.org/cpython/rev/e4b0f003ad13 New changeset 7c38a47fd4d5 by Berker Peksag in branch 'default': Issue #26199: Fix broken link

[issue26199] fix broken link to hamcrest.library.integration.match_equality in unittest.mock "getting started" documentation

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Raphael! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: -Python 3.3, Python 3.4 ___ Python tracker

[issue26034] venv documentation out of date

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset d2a32b78be96 by Berker Peksag in branch '3.5': Issue #26034: Sync documentation of --clear with its behavior https://hg.python.org/cpython/rev/d2a32b78be96 New changeset 5764cc02244d by Berker Peksag in branch 'default': Issue #26034: Sync

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread STINNER Victor
STINNER Victor added the comment: By the way, thanks for your reviews. Code review rocks ;-) -- ___ Python tracker ___

[issue20598] argparse docs: '7'.split() is confusing magic

2016-01-28 Thread Martin Panter
Martin Panter added the comment: Here is a patch changing all the '. . .'.split() calls to lists of strings. I think the illustrations are actually less complicated to understand when you see the list directly, and they more consistent with the remaining illustrations that already use lists,

[issue26002] make statistics.median_grouped more efficient

2016-01-28 Thread Upendra Kumar
Upendra Kumar added the comment: Yeah, I slightly modified the functions from the bisect docs to suit for the purpose here. -- ___ Python tracker ___

[issue25314] Documentation: argparse's actions store_{true, false} default to False/True (undocumented)

2016-01-28 Thread Georg Brandl
Georg Brandl added the comment: Hi Julien, thanks for your patch and sorry for the lack of reviews. I find the new wording in the second hunk confusing: ``'store_true'`` and ``'store_false'`` - These store the values ``False`` respectively (Note that these default to ``False`` and ``True``

[issue26002] make statistics.median_grouped more efficient

2016-01-28 Thread Upendra Kumar
Upendra Kumar added the comment: Can someone please review my patch? I think it can increase the performance significantly of the median_grouped() function. But, I don't have any standard way of checking if it would improve or will be an overkill for the median_grouped() function?

[issue26034] venv documentation out of date

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9c5370405393 by Berker Peksag in branch '3.5': Issue #26034: Improve wording of clear parameter https://hg.python.org/cpython/rev/9c5370405393 New changeset 0fb96a43d381 by Berker Peksag in branch 'default': Issue #26034: Improve wording of clear

[issue26230] Cookies do not correct if cookiename includes [ or ]

2016-01-28 Thread Martin Panter
Martin Panter added the comment: Is this a duplicate of Issue 25228? If not, can you please explain what the problem is, perhaps with a demo, what it does wrong, and what you expect the result should be. -- nosy: +martin.panter stage: -> test needed

[issue20598] argparse docs: '7'.split() is confusing magic

2016-01-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Using str.split() for splitting full command line on arguments is anti-idiom. More correct way is to use shlex. But this is overkill for argparse examples (and in most cases we already have a list sys.argv). Explicit lists look clear enough. The patch

[issue16731] xxlimited/xxmodule docstrings ambiguous

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: I think the difference between xxlimited and xxmodule is still a bit ambiguous. I would expect a mention of PEP 384 or a link to https://docs.python.org/3/c-api/stable.html to explain what Py_LIMITED_API really is. +#ifndef Py_LIMITED_API +# error "This file

[issue26136] DeprecationWarning for PEP 479 (generator_stop)

2016-01-28 Thread Ezio Melotti
Changes by Ezio Melotti : -- keywords: +easy nosy: +ezio.melotti ___ Python tracker ___

[issue26160] Tutorial incorrectly claims that (explicit) relative imports don't work in the main module

2016-01-28 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___

[issue26231] HTTPResponse.close() should consume all remaining data in body if any

2016-01-28 Thread Jacky
New submission from Jacky: HTTPResponse.close() in httplib should consume all remaining data in body if any. Or the followed request would get the unread content from the previous request, which result in the wrong result. The following code shown that the second request will get a wrong

[issue26223] decimal.to_eng_string() does not implement engineering notation in all cases.

2016-01-28 Thread Mark Dickinson
Mark Dickinson added the comment: I also agree that we shouldn't change the current code. As Raymond says, it may be worth a doc change. Serge: I was confused by your initial report. If I understand the StackOverflow question correctly, this isn't about the output for *infinite* numbers

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread STINNER Victor
STINNER Victor added the comment: > Added comments on Rietveld. Crap. It's easy to miss a compilation error on extensions :-/ I used "make && ./python -m test -v test_socket" to validate gethostbyaddr_encoding-2.patch and it succeded. Maybe we should setup.py to *fail* if an extension

[issue26230] Cookies do not correct if cookiename includes [ or ]

2016-01-28 Thread Berker Peksag
Changes by Berker Peksag : -- stage: test needed -> resolved superseder: -> Regression in cookie parsing with brackets and quotes ___ Python tracker

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread Eryk Sun
Eryk Sun added the comment: The patch is missing the "errors" parameter of PyUnicode_DecodeLocale. But it should call PyUnicode_DecodeMBCS instead. In the "C" locale, PyUnicode_DecodeLocale is Latin-1 because the CRT mbstowcs just casts the values to wchar_t. socket_getnameinfo also decodes

[issue19023] ctypes docs: Unimplemented and undocumented features

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 732fdd03e708 by Martin Panter in branch '3.5': Issue #19023: Document ctypes array and pointer classes https://hg.python.org/cpython/rev/732fdd03e708 New changeset a78cbb2125a8 by Martin Panter in branch 'default': Issue #19023: Merge ctypes doc

[issue26230] Cookies do not correct if cookiename includes [ or ]

2016-01-28 Thread tom liu
tom liu added the comment: similar to issue25228. -- resolution: -> duplicate status: open -> closed ___ Python tracker ___

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread STINNER Victor
STINNER Victor added the comment: > The patch is missing the "errors" parameter of PyUnicode_DecodeLocale. Woops, I shouldn't write patch in the middle of the night :-) Hopefully, I didn't push it :-) PyUnicode_DecodeLocale() should only be used when the encoding depends on the *currenet*

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread STINNER Victor
Changes by STINNER Victor : Added file: http://bugs.python.org/file41740/gethostbyaddr_encoding-2.patch ___ Python tracker ___

[issue26230] Cookies do not correct if cookiename includes [ or ]

2016-01-28 Thread tom liu
Changes by tom liu : -- components: Extension Modules nosy: tom_lt priority: normal severity: normal status: open title: Cookies do not correct if cookiename includes [ or ] type: behavior versions: Python 3.4 ___ Python tracker

[issue21201] Uninformative error message in multiprocessing.Manager()

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: Looks good to me. Perhaps we can use utils.info() to print the exception. -- nosy: +berker.peksag, davin stage: -> patch review versions: +Python 3.6 -Python 3.4 ___ Python tracker

[issue26231] HTTPResponse.close() should consume all remaining data in body if any

2016-01-28 Thread Martin Panter
Martin Panter added the comment: The documentation already says you have to read the whole response before sending a new request: . So I think this is more like a new feature than a bug fix, and would have to

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Added comments on Rietveld. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue20598] argparse docs: '7'.split() is confusing magic

2016-01-28 Thread SilentGhost
SilentGhost added the comment: I think it's worth saying that this wasn't a random choice intended to confuse beginners. Strings used represent input that is identical to the command-line input: if one wants to test it, one can just copy that string directly into the propmpt, it might be

[issue26194] Undefined behavior for deque.insert() when len(d) == maxlen

2016-01-28 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: full_deque2.diff LGTM. But I have added minor suggestions on Rietveld. -- ___ Python tracker ___

[issue26223] decimal.to_eng_string() does not implement engineering notation in all cases.

2016-01-28 Thread Serge Stroobandt
Serge Stroobandt added the comment: Mark: Don't shoot the messenger! I literally quoted the implemented proprietary specification. However, I do agree that the term "numbers (or bases) with an infinte decimal representation" would be more appropriate in this context. Also, improving

[issue25314] Documentation: argparse's actions store_{true, false} default to False/True (undocumented)

2016-01-28 Thread Julien Baley
Julien Baley added the comment: Hi Georg, thanks for your answer. I think maybe you're missing a bit in there? "``'store_true'`` and ``'store_false'`` - These store the values ``True`` and ``False`` respectively (Note that these default to ``False`` and ``True`` respectively). These are

[issue26230] Cookies do not correct if cookiename includes [ or ]

2016-01-28 Thread SilentGhost
New submission from SilentGhost: You'd have to provide more information if you'd like that looked into. -- nosy: +SilentGhost versions: +Python 3.5 -Python 3.4 ___ Python tracker

[issue26232] Mock(spec=spec) has no effect

2016-01-28 Thread David Szotten
David Szotten added the comment: thanks, and apologies for the noise -- ___ Python tracker ___ ___

[issue20598] argparse docs: '7'.split() is confusing magic

2016-01-28 Thread paul j3
paul j3 added the comment: I can understand changing '7'.split() but this change is IMO ugly: - >>> print(parser.parse_args('--foo B cmd --arg1 XX ZZ'.split())) + >>> print(parser.parse_args(['--foo', 'B', 'cmd', '--arg1', 'XX', 'ZZ'])) I've answered a lot of argparse questions

[issue26155] 3.5.1 installer issue on Win 7 32 bit

2016-01-28 Thread TarotRedhand
TarotRedhand added the comment: Sorry for the delay but RL intervened. Because of the size of the log files (total of 17.7 megs), rather than post the contents in one these windows I placed them into a 7zip 7z archive. I am attaching them to this message. I hope this helps. -- Added

[issue26173] test_ssl.bad_cert_test() exception handling

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset 14463726a4a0 by Martin Panter in branch '2.7': Issue #26173: Fix test_ssl confusion with non-existing cert and wrongcert.pem https://hg.python.org/cpython/rev/14463726a4a0 -- nosy: +python-dev ___ Python

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread Emanuel Barry
Emanuel Barry added the comment: If it worked for you, I assume it's fine and I probably did something wrong on my side. Thanks for the fix! -- ___ Python tracker

[issue22363] argparse AssertionError with add_mutually_exclusive_group and help=SUPPRESS

2016-01-28 Thread Martin Panter
Martin Panter added the comment: I left one review comment, but it seems there is more discussion at Issue 17890, which also originally proposed a very similar fix. -- nosy: +martin.panter resolution: -> duplicate stage: -> patch review status: open -> closed superseder: ->

[issue26236] urllib2 initiate irregular call to gethostbyaddr

2016-01-28 Thread Julia Dolgova
New submission from Julia Dolgova: I'm using python 2.7. My system is windows 7(64-bit). I also use proxy. urllib2.urlopen usually implements 0,2..1sec but sometimes sends a strange UDP to 137 port (netbios-ns) of the remote server, waits 4..6 sec. and then sends HTTP-request. If I disable

[issue26207] test_distutils fails on "AMD64 Windows7 SP1 3.x" buildbot

2016-01-28 Thread Steve Dower
Steve Dower added the comment: For this particular issue, the way to detect it is to read HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\DevDiv\vc\Servicing\14.0\Tools.X86.X64@UpdateVersion and see if it is at least "14.0.23506". This doesn't extend to other VS versions, but it should be

[issue26155] 3.5.1 installer issue on Win 7 32 bit

2016-01-28 Thread TarotRedhand
TarotRedhand added the comment: Please ignore the part about the 7z being attached to the last message. This site wanted me to divulge certain personal information, that I am not prepared to give, before it would upload that file. I have instead placed it into my dropbox/public folder the

[issue17890] argparse: mutually exclusive groups full of help-suppressed args can cause AssertionErrors

2016-01-28 Thread Martin Panter
Martin Panter added the comment: See duplicate Issue 22363 for the traceback, and a workaround. There is also a patch there similar to Garrett’s original fix, but using the RE r'%s *%s ?'. I restored the diff from Garrett’s repository, in case it is still useful. Yogesh: I am not familiar

[issue26189] Interpreter returns control to cmd.exe early

2016-01-28 Thread Eryk Sun
Eryk Sun added the comment: Ensure that the .lnk target is the expected path to python.exe: C:\Temp>py -3 -c ^ More? "from win32com import client^ More? More? lnk = client.Dispatch('WScript.Shell').^ More? CreateShortCut('python.lnk')^ More? More? print('target:\n%s'

[issue26227] Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname

2016-01-28 Thread Steve Dower
Steve Dower added the comment: I couldn't remember the names of the alternate functions Windows provides to do the encoding for you, but yes. There are socket APIs there that do encoding and handle memory allocation more safely. Apart from bugs like this, it's not really urgent and it

[issue24841] Some test_ssl network tests fail if svn.python.org is not accessible.

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: > although they will need updating since the Issue 24841 changeover to > pythontest.net. I think you meant issue 25940, right? :) Do you want me to wait for issue 25940? -- versions: -Python 3.4 ___ Python tracker

[issue26232] Mock(spec=spec) has no effect

2016-01-28 Thread David Szotten
New submission from David Szotten: Unless i misunderstand the docs, i would expect `Mock(foo)` to have the same effect as `create_autospec(foo)`, but that doesn't appear to be the case: >>> m1 = mock.Mock(spec=lambda: None) >>> m2 = mock.create_autospec(spec=lambda: None) >>> m1(1) >>> m2(1)

[issue26199] fix broken link to hamcrest.library.integration.match_equality in unittest.mock "getting started" documentation

2016-01-28 Thread Raphael Das Gupta
Raphael Das Gupta added the comment: You're welcome. Thanks for applying the patch. Shouldn't it be applied to other affected versions (3.3 and 3.4), too, though? -- ___ Python tracker

[issue24705] sysconfig._parse_makefile doesn't expand ${} vars appearing before $() vars

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: I've added a test case for ef84d21f5292. I think this can be closed now. Please reopen if not. -- nosy: +berker.peksag resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker

[issue24705] sysconfig._parse_makefile doesn't expand ${} vars appearing before $() vars

2016-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset dec734dfe2fe by Berker Peksag in branch '3.5': Issue #24705: Add a test case for ef84d21f5292 https://hg.python.org/cpython/rev/dec734dfe2fe New changeset f9a18032cc22 by Berker Peksag in branch 'default': Issue #24705: Add a test case for

[issue26199] fix broken link to hamcrest.library.integration.match_equality in unittest.mock "getting started" documentation

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: 3.3 and 3.4 are in security-fix-only mode, which means they won't get bugfix and documentation updates anymore. See https://docs.python.org/devguide/devcycle.html for details. -- ___ Python tracker

  1   2   >