[issue23214] BufferedReader.read1(size) signature incompatible with BufferedIOBase.read1(size=-1)

2016-03-19 Thread Martin Panter
Martin Panter added the comment: Okay here is a patch implementing read1(-1) in BufferedReader and BytesIO (my original proposal). Other changes: * Changed read1(size=-1) → read1([size]), because BufferedReader and BytesIO do not accept keyword arguments (see also Issue 23738) * Defined

[issue26516] Add PYTHONMALLOC env var and add support for malloc debug hooks in release mode

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7b079adb0774 by Victor Stinner in branch 'default': Enhance documentation on malloc debug hooks https://hg.python.org/cpython/rev/7b079adb0774 -- ___ Python tracker

[issue26553] Write HTTP in uppercase

2016-03-19 Thread Aatish Neupane
Aatish Neupane added the comment: I have attached the patches fixing numerous case errors. -- nosy: +aatishnn ___ Python tracker ___

[issue26576] Tweak wording of decorator docos

2016-03-19 Thread Chris Angelico
Chris Angelico added the comment: I may be a committer, but I don't push to cpython - just to the peps. But sure, pretty little logo :) -- ___ Python tracker

[issue26281] Clear sys.path_importer_cache from importlib.invalidate_caches()

2016-03-19 Thread Brett Cannon
Brett Cannon added the comment: Eric's convinced me this isn't worth it. -- resolution: -> rejected status: open -> closed ___ Python tracker ___

[issue17603] AC_LIBOBJ replacement of fileblocks

2016-03-19 Thread Martin Panter
Martin Panter added the comment: I assume that should have fixed the problem, but I have only tested it in roundabout ways, so it would be good to get confirmation if it helps e.g. the original Ming GW problem. -- resolution: -> fixed status: open -> closed versions: +Python 2.7,

[issue26563] PyMem_Malloc(): check that the GIL is hold in debug hooks

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 959e58cfbde9 by Victor Stinner in branch 'default': Fix usage of PyMem_Malloc() in overlapped.c https://hg.python.org/cpython/rev/959e58cfbde9 -- ___ Python tracker

[issue15660] Clarify 0 prefix for width specifier in str.format doc,

2016-03-19 Thread Eric V. Smith
Eric V. Smith added the comment: > ''' > When no explicit alignment is given, preceding the width field by a zero > ('0') character enables sign-aware zero-padding for numeric types. This is > equivalent to a fill character of '0' with an alignment type of '='. > ''' I think that's good. > I

[issue26572] urlparse does not handle passwords with ? in them.

2016-03-19 Thread Rob Church
New submission from Rob Church: >>> urlparse('http://user:pass?w...@example.com/path?query') ParseResult(scheme='http', netloc='user:pass', path='', params='', query='w...@example.com/path?query', fragment='') Expected output is: ParseResult(scheme='http', netloc='user:pass?w...@example.com',

[issue23723] Provide a way to disable bytecode staleness checks

2016-03-19 Thread Brett Cannon
Brett Cannon added the comment: I realized that importlib.abc.SourceLoader.path_stats() provides a way to override stat collection and basically hard-code the stat number for all files from an import perspective. So if people simply generated their bytecode with a static timestamp and

[issue26040] Improve coverage and rigour of test.test_math

2016-03-19 Thread Jeff Allen
Changes by Jeff Allen : Added file: http://bugs.python.org/file42192/stat_math.py ___ Python tracker ___

[issue26577] inspect.getclosurevars returns incorrect variable when using class member with the same name as other variable

2016-03-19 Thread SilentGhost
Changes by SilentGhost : -- nosy: +yselivanov type: -> behavior versions: -Python 3.3, Python 3.4 ___ Python tracker ___

[issue26563] PyMem_Malloc(): check that the GIL is hold in debug hooks

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: Reopen. I found and fixed two bugs in os and _overlapped modules (_overlapped is used by asyncio on Windows). -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue19450] Bug in sqlite in Windows binaries

2016-03-19 Thread Steve Dower
Steve Dower added the comment: Done. The test_sqlite tests were fine, but that's all I checked. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue26248] Improve scandir DirEntry docs, especially re symlinks and caching

2016-03-19 Thread Ezio Melotti
Changes by Ezio Melotti : -- stage: -> resolved type: -> enhancement ___ Python tracker ___

[issue26582] asyncio documentation links to wrong CancelledError

2016-03-19 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue26567] ResourceWarning: Use tracemalloc to display the traceback where an object was allocated when a ResourceWarning is emitted

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 691fba640266 by Victor Stinner in branch 'default': Issue #26567: enhance ResourceWarning example https://hg.python.org/cpython/rev/691fba640266 -- ___ Python tracker

[issue13601] sys.stderr should be line-buffered when stderr is not a TTY

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: I changed the title, since sys.stderr is already line-buffered when stderr is a TTY. -- ___ Python tracker ___

[issue25643] Python tokenizer rewriting

2016-03-19 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- dependencies: +Double coding cookie ___ Python tracker ___

[issue25934] ICC compiler: ICC treats denormal floating point numbers as 0.0

2016-03-19 Thread Zachary Ware
Zachary Ware added the comment: I closed this prematurely: I successfully added /fp:strict to ICC builds, but it didn't fix the underlying issue. -- resolution: fixed -> stage: resolved -> status: closed -> open ___ Python tracker

[issue19450] Bug in sqlite in Windows binaries

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset fa68df1d5e65 by Steve Dower in branch '2.7': Issue #19450: Update Windows builds to use SQLite 3.8.11.0. https://hg.python.org/cpython/rev/fa68df1d5e65 -- ___ Python tracker

[issue26553] Write HTTP in uppercase

2016-03-19 Thread Aatish Neupane
Changes by Aatish Neupane : Added file: http://bugs.python.org/file42203/2_fix_3.6.patch ___ Python tracker ___

[issue26095] Update porting HOWTO to special-case Python 2 code, not Python 3

2016-03-19 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue26576] Tweak wording of decorator docos

2016-03-19 Thread Chris Angelico
Chris Angelico added the comment: Sure - changing it to "roughly". I started with that wording, and then changed to "broadly", for reasons which I now can't remember - so they can't have been too important. Consistency wins. -- Added file:

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Martin Panter
Martin Panter added the comment: Yeah I would be happy if you want to change to html.escape(quote=False) in list_directory() as well. BTW I am getting Undelivered Mail replies from the review comments. I guess they might be getting rejected due to looking like spam (they tend to be

[issue20186] Derby #18: Convert 31 sites to Argument Clinic across 23 files

2016-03-19 Thread Larry Hastings
Larry Hastings added the comment: >Modules/_opcode.c: Issue 19674 (3.4). Only one function I can see there > (Larry’s original post says two sites). I produced the post with a big grep through the codebase. Which was quite a while ago now. Code changes and moves around; if you can only

[issue26580] Documentation for ftplib still references ftpmirror.py

2016-03-19 Thread Alex Walters
New submission from Alex Walters: in #23130 ftpmirror.py was removed from the python source distribution. The documentation still references this, and sends people looking for the file (ostensibly as an example of how to use ftplib). -- assignee: docs@python components: Documentation

[issue26040] Improve coverage and rigour of test.test_math

2016-03-19 Thread Jeff Allen
Jeff Allen added the comment: Thanks for the prompt acknowledgement and for accepting this to review. I have updated the coverage & tolerance demo program. Usage in the comments (in v3). I have also added the program I used to generate the extra test cases (needs mpmath -- easier to get

[issue26271] freeze.py makefile uses the wrong flags variables

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 599328247e84 by Brett Cannon in branch '3.5': Issue #26271: Fix the Freeze tool to use variables passed in from the https://hg.python.org/cpython/rev/599328247e84 New changeset 364895e54bb0 by Brett Cannon in branch 'default': Merge for issue

[issue26538] regrtest: setup_tests() must not replace module.__path__ (_NamespacePath) with a simple list // importlib & abspath

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: I pushed my minimum fix. I now understand that it is not needed to change importlib, it's ok to keep "abspath" code in site & libregrtest. -- ___ Python tracker

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: I add two tests for html escaping. One for the error message and the other for display name in SimpleHTTPRequesthandler. -- Added file: http://bugs.python.org/file42204/_quote_html_to_html_escape_v2.patch ___ Python

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Xiang Zhang
New submission from Xiang Zhang: In http.server, _quote_html is used to escape content for BaseHTTPServer. The function has already been implemented by html.escape. -- components: Library (Lib) files: _quote_html_to_html_escape.patch keywords: patch messages: 261943 nosy: xiang.zhang

[issue26591] datetime datetime.time to datetime.time comparison does nothing

2016-03-19 Thread jason crockett
New submission from jason crockett: if datetime.time(#blah) > datetime.time(#blah): [a][b] does nothing.. it doesnt raise an error. it doesnt run the if function even though the printout of variables compared says it should. 22:15:00 [a] 16:00:00 [b] True

[issue26563] PyMem_Malloc(): check that the GIL is hold in debug hooks

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 73d8adc0d5ea by Victor Stinner in branch '3.5': Fix usage of PyMem_Malloc() in overlapped.c https://hg.python.org/cpython/rev/73d8adc0d5ea -- ___ Python tracker

[issue26530] tracemalloc: add C API to manually track/untrack memory allocations

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: > So you guarantee tracemalloc itself won't use such a hack for other purposes? ;-) As the defacto maintainer of the module, yes, I can guarantee that. > FWIW, LLVM calls the "domain" "address space", and simply uses an > integer for it (0 being the default

[issue26257] Eliminate buffer_tests.py

2016-03-19 Thread Martin Panter
Martin Panter added the comment: Yes what you say about re-arranging the methods in string_tests.py makes sense to me. There might also be some factorizing possible between specific methods in test_bytes.py and the (currently) string-only test methods. But I would like to handle these as

[issue26563] PyMem_Malloc(): check that the GIL is hold in debug hooks

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5b4f173f0690 by Victor Stinner in branch 'default': faulthandler now works in non-Python threads https://hg.python.org/cpython/rev/5b4f173f0690 New changeset d6d64168ee8c by Victor Stinner in branch 'default': Py_FatalError: disable faulthandler

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Martin Panter
Changes by Martin Panter : -- stage: -> patch review ___ Python tracker ___ ___

[issue3539] Problem with testembed make dependencies in certain circumstances

2016-03-19 Thread Martin Panter
Martin Panter added the comment: The fault still exists for me with the pgen objects. The makefile has changed a few times about automatically compiling pgen (Issue 22359) or not (Issue 14321), so it would depend which version is tested. I’m not an expert on VPATH, but it seems like it would

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: It's BaseHTTPRequestHandler, not BaseHTTPServer. -- ___ Python tracker ___ ___

[issue15660] Clarify 0 prefix for width specifier in str.format doc,

2016-03-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: This came up again on python-list today in thread "Replace weird error message?" by "the.gerenuk--- via Python-list". After reading the discussion, I decided that expecting someone to read and connect together two sentences half a page apart is expecting a

[issue26040] Improve coverage and rigour of test.test_math

2016-03-19 Thread Jeff Allen
Changes by Jeff Allen : Removed file: http://bugs.python.org/file41526/stat_math.py ___ Python tracker ___

[issue26579] Support pickling slots in subclasses of common classes

2016-03-19 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Pickling and copying instances of subclasses of some basic classes pickles and copies instance attributes. Example: >>> class BA(bytearray): ... pass ... >>> b = BA(b'abc') >>> b.x = 10 >>> c = copy.copy(b) >>> c.x 10 >>> c =

[issue13601] sys.stderr should always be line-buffered

2016-03-19 Thread Nick Coghlan
Nick Coghlan added the comment: Changing the target version and summarising my understanding of the status quo: "python3": sys.stderr is line buffered at both the TextIOWrapper layer and may be fully buffered at the binary BufferedWriter layer if the output is redirected to a file "python3

[issue10721] Remove HTTP 0.9 server support

2016-03-19 Thread Martin Panter
Martin Panter added the comment: Does this need any deprecation cycle, or can we just remove everything immediately in 3.6? I suspect that the HTTP 0.9 support never properly worked, but I don’t have enough info to be sure. Wouldn’t a HTTP 0.9 request send b"GET \r\n" with a single line, and

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: sock_finalize() is only called explicitly if there is a reference cycle. This is why sock_dealloc() has to call it. -- ___ Python tracker

[issue26567] ResourceWarning: Use tracemalloc to display the traceback where an object was allocated when a ResourceWarning is emitted

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 543639cdfdb9 by Victor Stinner in branch 'default': Try again to fix test_warnings on Windows https://hg.python.org/cpython/rev/543639cdfdb9 -- ___ Python tracker

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: It's unclear to me if it's needed to call the following code in sock_dealloc(): +if (PyObject_CallFinalizerFromDealloc((PyObject *)s) < 0) +return; It looks like this code is not needed, since sock_finalize() is called before sock_dealloc().

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: Attached patch adds a finalizer to _socket.socket() and use PyErr_ResourceWarning() to log the traceback where the socket was created in the warning logger (if tracemalloc is enabled, see issue #26567). -- keywords: +patch Added file:

[issue18787] Misleading error from getspnam function of spwd module

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset a1d738158390 by Berker Peksag in branch 'default': Issue #18787: spwd.getspnam() now raises a PermissionError if the user https://hg.python.org/cpython/rev/a1d738158390 -- nosy: +python-dev ___ Python

[issue26257] Eliminate buffer_tests.py

2016-03-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I meant that the patch can be smaller if move more tests from CommonTest to BaseTest without changing order. Here is smaller patch. -- Added file: http://bugs.python.org/file42216/buffer_tests_2.patch ___ Python

[issue18787] Misleading error from getspnam function of spwd module

2016-03-19 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue20186] Derby #18: Convert 31 sites to Argument Clinic across 23 files

2016-03-19 Thread Tal Einat
Tal Einat added the comment: My patches haven't been looked at for a while, anyone considering them should make sure they still apply cleanly and don't break anything. Here their status as far as I can tell: Quite a bit of work went into Modules/_operator.c, and it got an "LGTM" from Serhiy,

[issue26331] Tokenizer: allow underscores for grouping in numeric literals

2016-03-19 Thread Stefan Behnel
Stefan Behnel added the comment: Nice one. While reimplementing it for Cython, I noticed that the grammar described in the PEP isn't exactly as it's implemented, though. The grammar says digit (["_"] digit)* whereas the latest patch (v4) says `digit` (`digit` | "_")* and also

[issue26530] tracemalloc: add C API to manually track/untrack memory allocations

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: Nathaniel Smith: > So PyMem_Malloc would just call PyMem_RecordAlloc("heap", ptr, size) (or act > equivalently to something that called that, etc.), but something like PyCuda > might do PyMem_RecordAlloc("gpu", ptr, size) to track allocations in GPU > memory.

[issue26568] Add a new warnings.showwarnmsg() function taking a warnings.WarningMessage object

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9c92352324e8 by Victor Stinner in branch 'default': Fix test_logging https://hg.python.org/cpython/rev/9c92352324e8 -- ___ Python tracker

[issue26313] ssl.py _load_windows_store_certs fails if windows cert store is empty

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8df52636b0dc by Steve Dower in branch '2.7': Issue #26313: ssl.py _load_windows_store_certs fails if windows cert store is empty. Patch by Baji. https://hg.python.org/cpython/rev/8df52636b0dc -- nosy: +python-dev

[issue26582] asyncio documentation links to wrong CancelledError

2016-03-19 Thread awilfox
New submission from awilfox: In the 3.5 and 3.6a0 documentation for asyncio, "CancelledError" is linked to the concurrent.futures.CancelledError. This led me to try catching that exception and finding that it did not work correctly at all. Only after searching for asyncio example code and

[issue19265] Increased test coverage for datetime pickling

2016-03-19 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Colin! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.5, Python 3.6 -Python 3.4 ___ Python tracker

[issue26574] replace_interleave can be optimized for single character byte strings

2016-03-19 Thread Josh Snider
Josh Snider added the comment: Addresses review comments. -- Added file: http://bugs.python.org/file42180/bytes-2.patch ___ Python tracker ___

[issue26554] Missing fclose

2016-03-19 Thread STINNER Victor
Changes by STINNER Victor : -- keywords: +easy ___ Python tracker ___ ___

[issue26583] test_timestamp_overflow of test_importlib fails if PYTHONDONTWRITEBYTECODE is set

2016-03-19 Thread Brett Cannon
Brett Cannon added the comment: LGTM, Ned. -- assignee: -> larry nosy: +larry stage: patch review -> commit review ___ Python tracker ___

[issue26580] Documentation for ftplib still references ftpmirror.py

2016-03-19 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker

[issue26583] test_timestamp_overflow fails

2016-03-19 Thread Peter Inglesby
Peter Inglesby added the comment: The problem is that I have PYTHONDONTWRITEBYTECODE set in my environment. Should the setUp and tearDown methods ensure that PYTHONDONTWRITEBYTECODE is cleared and reset? -- ___ Python tracker

[issue26573] Method Parameters can be Accepted as Keyword Arguments?

2016-03-19 Thread G Young
G Young added the comment: Google indicates that this is indeed a feature of the language. Sorry about that! I guess that was a miscommunication on the PR-end. -- status: open -> closed ___ Python tracker

[issue26258] readline module for python 3.x on windows

2016-03-19 Thread Ezio Melotti
Ezio Melotti added the comment: I'm going to close this, but you can try bringing this up on python-list or python-ideas to see if there's any existing solution that could perhaps be included in Python. -- nosy: +ezio.melotti resolution: -> postponed stage: -> resolved status: open

[issue26587] Possible duplicate entries in sys.path if .pth files are used with zip's

2016-03-19 Thread Wolfgang Langner
New submission from Wolfgang Langner: In site.py there is the internal function _init_pathinfo() This function builds a set of path entries from sys.path. This is used to avoid duplicate entries in sys.path. But this function has a check if it is a directory with os.path.isdir(...). All this

[issue26530] tracemalloc: add C API to manually track/untrack memory allocations

2016-03-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: A n-GPU system will have n+1 address spaces. Such systems exist in high-performance computing. You can also probably find weird systems (embedded, mostly, I'd say) with more than two address spaces. -- ___ Python

[issue26578] Bad BaseHTTPRequestHandler response when using HTTP/0.9

2016-03-19 Thread Xiang Zhang
New submission from Xiang Zhang: BaseHTTPRequestHandler in http.server supports HTTP/0.9. But the response for HTTP/0.9 request is implemented wrong. Response of HTTP/0.9 request returns message body directly without status line and headers. But if you inherit BaseHTTPRequestHandler and set

[issue19265] Increased test coverage for datetime pickling

2016-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset c6649d4477ab by Berker Peksag in branch '3.5': Issue #19265: Improve test coverage of datetime.tzinfo https://hg.python.org/cpython/rev/c6649d4477ab New changeset f1539e7607e4 by Berker Peksag in branch 'default': Issue #19265: Improve test

[issue26560] Error in assertion in wsgiref.handlers.BaseHandler.start_response

2016-03-19 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Peter! I've simplified the test a bit and commit it. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue26576] Tweak wording of decorator docos

2016-03-19 Thread Chris Angelico
Chris Angelico added the comment: Sounds good to me. Replacement patch. -- Added file: http://bugs.python.org/file42182/deco-docos.patch ___ Python tracker

[issue26576] Tweak wording of decorator docos

2016-03-19 Thread Raymond Hettinger
Raymond Hettinger added the comment: Elsewhere we use "roughly equivalent to" instead of "broadly equivalent to". The latter seems a little bit off the mark. -- nosy: +rhettinger ___ Python tracker

[issue26583] test_timestamp_overflow fails

2016-03-19 Thread Peter Inglesby
Peter Inglesby added the comment: I can reproduce it reliably. I ran ./configure with --with-pydebug. I'm not using NFS, and I'm not aware of anything else unusual about my filesystem. The fact that a timestamp overflows in the failing test is a red herring -- the following also fails, with

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Martin Panter
Martin Panter added the comment: Removing the redundant _quote_html() function seems like a good idea to me. I wonder if the code should be using the html.escape(..., quote=False) option though, because it does not need to encode quote signs. It might be good to add a test. It looks like

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 19/03/2016 14:07, STINNER Victor a écrit : > > Example: > --- > import socket > s=socket.socket() > s=None > --- > > With this code, sock_finalize() is called before sock_dealloc(): > > #0 sock_finalize (s=0x70730c28) at >

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: Oops. You have already left new comment. No notify either. :( I like the idea that extract the actual encoding from response header. I will update my patch then. -- ___ Python tracker

[issue26592] _warnings.warn_explicit() should try to import the warnings module

2016-03-19 Thread STINNER Victor
New submission from STINNER Victor: The issue #26567 enhanced the warnings module to pass the destroyed object on ResourceWarning. The implementation to log the traceback where the object was allocated is non trivial, so I chose to only implement it in Python. Problem:

[issue26283] zipfile can not handle the path build by os.path.join()

2016-03-19 Thread Ezio Melotti
Ezio Melotti added the comment: I don't think this is a bug. The ZIP format specification requires the use of forward slashes[0]: 4.4.17 file name: (Variable) 4.4.17.1 The name of the file, with optional relative path. The path stored MUST not contain a drive or

[issue26583] test_timestamp_overflow fails

2016-03-19 Thread Ned Deily
Ned Deily added the comment: Sorry, I am unable to reproduce this on either 10.9.5 or current 10.11.3 OS X systems. Is there something unusual about the working directory you are running the tests from, like residing on an NFS or other networked file system? Any special ./configure options?

[issue13601] sys.stderr should always be line-buffered

2016-03-19 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue26580] Documentation for ftplib still references ftpmirror.py

2016-03-19 Thread SilentGhost
SilentGhost added the comment: This patch removes the offending paragraph. -- keywords: +patch nosy: +SilentGhost stage: -> patch review type: -> behavior versions: +Python 3.6 Added file: http://bugs.python.org/file42187/issue26580.diff ___ Python

[issue25609] Add a ContextManager ABC and type

2016-03-19 Thread Nick Coghlan
Nick Coghlan added the comment: * the ABC should have a structural __issubclass__ check looking for __enter__ and __exit__ methods * I agree with making __exit__ abstract (if you don't define it, you don't need a context manager), but does __enter__ need to be abstract? The "return self"

[issue26569] pyclbr.readmodule() and pyclbr.readmodule_ex() don't support namespace packages

2016-03-19 Thread Eric Snow
Eric Snow added the comment: Well, your patch is correct even if not ideal. :) Landing it as a short-term solution is fine. Just keep this issue open so we can address the problem more completely later. -- components: +Interpreter Core stage: -> commit review type: -> behavior

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: @Antoine: Since you wrote the PEP 442, would you reviewing sock_finalize.patch? I'm only interested to modify Python 3.6, the bug was only trigerred when I changed the code to log a warning. Before, the socket object was not passed to the warning logger so it

[issue26569] pyclbr.readmodule() and pyclbr.readmodule_ex() don't support namespace packages

2016-03-19 Thread Eric Snow
Eric Snow added the comment: And thanks for addressing this here. :) -- ___ Python tracker ___ ___

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: 2016-03-19 11:05 GMT+01:00 Antoine Pitrou : > sock_finalize() is only called explicitly if there is a reference cycle. This > is why sock_dealloc() has to call it. I'm fine with keeping sock_dealloc() to call sock_finalize(), but I

[issue26590] socket destructor: implement finalizer

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: Antoine Pitrou added the comment: > Ah, that's probably because socket.socket is a Python subclass. > What happens if you use _socket.socket directly instead? Oh, I forgot this sublte implementation detail, _socket.socket base class vs socket.socket sublcass.

[issue24959] unittest swallows par t of stack trace when raising AssertionError in a TestCase

2016-03-19 Thread Robert Collins
Robert Collins added the comment: I'm fairly sure its eating the stack frames because the calling frames are annotated __unittest__ - its technically a feature :/. -- title: unittest swallows part of stack trace when raising AssertionError in a TestCase -> unittest swallows par t of

[issue26569] pyclbr.readmodule() and pyclbr.readmodule_ex() don't support namespace packages

2016-03-19 Thread STINNER Victor
STINNER Victor added the comment: > However, you should be able to leave the is_package() call alone. I don't really care how the issue is fixed. As I wrote, I don't know well the importlib module. Feel free to propose a better patch :-) My main concern is to fix test_pyclbr when test becomes

[issue26546] Provide translated french translation on docs.python.org

2016-03-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I agree on the url. It can always redirect to a CCTLD if there is one. You *might* want to discuss the how on python-ideas list. -- nosy: +terry.reedy ___ Python tracker

[issue26585] Use html.escape to replace _quote_html in http.server

2016-03-19 Thread Xiang Zhang
Xiang Zhang added the comment: OK. You left the comment preferring using ascii or utf-8 to encode the filename in test. But actually the response SimpeHTTPRequestHandler send is explicitly encoded in filesystemdefaultencoding. So in such a case, am I doing right? --

[issue26560] Error in assertion in wsgiref.handlers.BaseHandler.start_response

2016-03-19 Thread Peter Inglesby
Peter Inglesby added the comment: I found it while reading the source. Patch attached. -- keywords: +patch Added file: http://bugs.python.org/file42188/issue26560.patch ___ Python tracker

[issue21423] concurrent.futures.ThreadPoolExecutor/ProcessPoolExecutor should accept an initializer argument

2016-03-19 Thread Alexander Mohr
Alexander Mohr added the comment: any chance if this getting into 3.5.2? I have some gross code to get around it (setting global properties) -- nosy: +thehesiod ___ Python tracker

[issue17605] mingw-meta: build interpeter core

2016-03-19 Thread Martin Panter
Changes by Martin Panter : -- dependencies: +mingw: detect REPARSE_DATA_BUFFER ___ Python tracker ___

[issue26331] Tokenizer: allow underscores for grouping in numeric literals

2016-03-19 Thread Georg Brandl
Georg Brandl added the comment: The last patch isn't up to date with the PEP; Serhiy's patch is the closest one. -- ___ Python tracker ___

[issue26538] regrtest: setup_tests() must not replace module.__path__ (_NamespacePath) with a simple list // importlib & abspath

2016-03-19 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue19265] Increased test coverage for datetime pickling

2016-03-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: These lines should be removed again after applying the patch for issue26579. -- nosy: +serhiy.storchaka ___ Python tracker

[issue26271] freeze.py makefile uses the wrong flags variables

2016-03-19 Thread Brett Cannon
Brett Cannon added the comment: Thanks for the patch, Daniel! Added you to the ACKS file. -- stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue26583] test_timestamp_overflow of test_importlib fails if PYTHONDONTWRITEBYTECODE is set

2016-03-19 Thread Ned Deily
Ned Deily added the comment: Pushed for release in 3.5.2 and 3.6.0. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

  1   2   >