[issue26293] Embedded zipfile fields dependent on absolute position

2016-06-03 Thread spoo
spoo added the comment: On 06/03/2016 09:27 PM, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > spoo, can you confirm that the patch fixes your issue? > > -- > > ___ > Python tracker >

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Trying again. And yes, I would like a review. I don't think there is anything system specific, but some deletions required a minor rewrite. -- keywords: +patch Added file: http://bugs.python.org/file43149/require85.diff

[issue27184] Support path objects in the ntpath module

2016-06-03 Thread Ethan Furman
Ethan Furman added the comment: @Serhy: Isn't that backwards? I would think that by doing os.path first most other libraries would not have to change. -- ___ Python tracker

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Kushal Das
Kushal Das added the comment: Uploading the new patch with a new test case for the same. -- Added file: http://bugs.python.org/file43151/issue25548v2.patch ___ Python tracker

[issue19611] inspect.getcallargs doesn't properly interpret set comprehension code objects.

2016-06-03 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: This new patch makes the inspect module treat .0-type names as positional-only and renames them to implicit0. Includes a documentation patch too. I'm not too happy with the wording in the documentation, so suggestions for better naming are appreciated.

[issue27051] Create PIP gui

2016-06-03 Thread Upendra Kumar
Upendra Kumar added the comment: @Terry and @Lorenzo, As shown in the GUI of "install_pyPI_v1.png", I needed to add some tkinter widget into treeview. For example, adding a checkbox to the treeview so that multiple selections are possible. In figure "install_pyPI_v1.png", a checkbox in each

[issue27186] add os.fspath()

2016-06-03 Thread Ethan Furman
Ethan Furman added the comment: Note: My schedule changed -- I won't be at the sprints today, but tomorrow. I'll finish reviewing these patches and commit this afternoon if no one beats me to it. -- ___ Python tracker

[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc

2016-06-03 Thread Xiang Zhang
Xiang Zhang added the comment: Serhiy, actually the patch(issue26915_s2.patch) I uploaded early has tried to make Sequence.index and Sequence.count consistent. Maybe the issue stage is not right. -- ___ Python tracker

[issue24617] os.makedirs()'s [mode] not correct

2016-06-03 Thread Tommy Beadle
Changes by Tommy Beadle : -- nosy: +tbeadle ___ Python tracker ___ ___ Python-bugs-list

[issue15476] Index "code object" and link to code object definition

2016-06-03 Thread Tommy Beadle
Changes by Tommy Beadle : Added file: http://bugs.python.org/file43152/0001-Issue-15476-Make-code-object-its-own-entry-in-the-do.patch ___ Python tracker

[issue22558] Missing doc links to source code for Python-coded modules.

2016-06-03 Thread Nathan Harold
Nathan Harold added the comment: I'll give this a go, per Terry's instructions in msg266846. I've noticed up front that, due to other changes near the headers of a couple of files (specifically fcntl.rst and termios.rst), the patch doesn't apply cleanly anymore. Is it permissible for me to

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Maybe add an assert for the second size negation? -- ___ Python tracker ___

[issue27186] add os.fspath()

2016-06-03 Thread Dusty Phillips
Changes by Dusty Phillips : Removed file: http://bugs.python.org/file43154/issue27186-glossary.buchuki.patch ___ Python tracker ___

[issue27186] add os.fspath()

2016-06-03 Thread Dusty Phillips
Changes by Dusty Phillips : Added file: http://bugs.python.org/file43155/issue27186-glossary.buchuki.patch ___ Python tracker ___

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-03 Thread Kaushik N
Kaushik N added the comment: Applied patch from sean.rodman. Created a tests. Incorporated comments from rdmurray -- Added file: http://bugs.python.org/file43160/Issue16484_rev_python3.6.patch ___ Python tracker

[issue27184] Support path objects in the ntpath module

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think that if some high-level function uses os.path, it likely should convert Path argument to str either because the path should be saved as a string, or for performance if multiple os.path functions are called with the same argument. Note, that some

[issue22558] Missing doc links to source code for Python-coded modules.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: For me, the issue is willingness, not permission ;-). Reviewing a patch includes somehow indicating changes needed to apply it 'today', and a revised patch is the best way. Please say whether the header changes are in 3.6 only (in which case a separate 3.5

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-03 Thread Dave Sawyer
Dave Sawyer added the comment: This can go into bugfix branches. In fact, it's most likely to be helpful there because they are more likely to be running with a version of sqlite 10 years old. I use the sqlite3_libversion_number() call because I'm testing against the version of sqlite

[issue27167] subprocess reports signal as negative exit status, not documented

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 365b5e6163a6 by Gregory P. Smith in branch 'default': signal, socket, and ssl module IntEnum constant name lookups now return a https://hg.python.org/cpython/rev/365b5e6163a6 -- ___ Python tracker

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread R. David Murray
R. David Murray added the comment: The word description of the meaning of the tolerance attributes told me absolutely nothing. The equation from the math.islcose docs makes it prefectly clear. So I think the formula should be included in the documentation. assertAlomstEqual has a delta

[issue15476] Index "code object" and link to code object definition

2016-06-03 Thread Tommy Beadle
Tommy Beadle added the comment: Using .. index:: object: code puts a 'code' entry under 'object' as well as 'object' under 'code'. That's the way it is for every other item that uses "object: XXX". So if you want a new 'code object' top-level item and keep 'object -> code', you're going

[issue27167] subprocess reports signal as negative exit status, not documented

2016-06-03 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-03 Thread Dave Sawyer
Dave Sawyer added the comment: hurray! My first commit -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27184] Support path objects in the ntpath module

2016-06-03 Thread Ethan Furman
Ethan Furman added the comment: The expected scenario, and the purpose of os.fspath(), is to enable high-level libraries to not know or care if they receive a pathlib object or a string. In other words, they already have os.path.join() and os.path.split() calls, and currently break noisily if

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Did you try to run tests with Tk 8.4? -- ___ Python tracker ___ ___

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-03 Thread Thomas Kluyver
Thomas Kluyver added the comment: Congrats! :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27051] Create PIP gui

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: There is apparently no way to insert widgets in a Treeview -- text only. See for instance https://stackoverflow.com/questions/16755176/tkinter-insert-a-combobox-inside-a-treeview-widget. I don't know whether clicks on a row can be pinpointed to a specific

[issue22797] urllib.request.urlopen documentation falsely guarantees that a URLError will be raised on errors

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8b6b6add8e47 by R David Murray in branch 'default': psuedo merge: #22797: clarify when URLErrors are raised by urlopen. https://hg.python.org/cpython/rev/8b6b6add8e47 -- ___ Python tracker

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Brett Cannon
Brett Cannon added the comment: Patch LGTM. Just needs doc and What's New updates. -- assignee: -> kushal.das nosy: +brett.cannon stage: patch review -> commit review ___ Python tracker

[issue27186] add os.fspath()

2016-06-03 Thread Dusty Phillips
Dusty Phillips added the comment: Adding a glossary entry for path-like. The references are all correct except: :class:`os.PathLike` doesn't link to anything because PathLike hasn't been added to the os module yet. Similarly, :meth:`__fspath__` does not link to anything, although I think this

[issue5124] IDLE - pasting text doesn't delete selection

2016-06-03 Thread R. David Murray
R. David Murray added the comment: For what it is worth, as a dedicated X11 user, *if* the target is already hilighted by the application I expect the replace behavior. But in my usage I never select the target myself, since that would replace my selection buffer. So in essence I'm seeing

[issue26983] float() can return not exact float instance

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your review Mark. -- ___ Python tracker ___ ___

[issue26983] float() can return not exact float instance

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 050e5f803999 by Serhiy Storchaka in branch 'default': Issue #26983: float() now always return an instance of exact float. https://hg.python.org/cpython/rev/050e5f803999 -- nosy: +python-dev ___ Python

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
New submission from Chris Barker: In py3.5, the math.isclose() function was added to the standard library. It can be used to compare floating point numbers to see if they are close to each other, rather than exactly equal. It's not a lot of code, but there are nuances that not every python

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-03 Thread Joshua Jay Herman
Joshua Jay Herman added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27199] TarFile expose copyfileobj bufsize to improve throughput

2016-06-03 Thread Jason Fried
New submission from Jason Fried: The default of 16k while good for memory usage it is not well suited for all cases. if we increased this to 4MB we saw a pretty large improvement to tar file creation and extraction on linux servers. For a 1gb tar file containing 1024 random files each of 10MB

[issue27199] TarFile expose copyfileobj bufsize to improve throughput

2016-06-03 Thread Jason Fried
Changes by Jason Fried : -- keywords: +patch Added file: http://bugs.python.org/file43159/copybufsize.patch ___ Python tracker ___

[issue17888] docs: more information on documentation team

2016-06-03 Thread Laura Rupprecht
Laura Rupprecht added the comment: I've updated the patch from Terry with Berker's suggestion. -- nosy: +laura Added file: http://bugs.python.org/file43162/issue17888_2.patch ___ Python tracker

[issue20567] test_idle causes test_ttk_guionly 'can't invoke "event" command: application has been destroyed' messages from Tk

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: This and the followup for 3.x full the TODOs in msg219528, revise README.txt, and in msg221467, change delete order to match new advice. This issue was about conflict between test_idle and test_ttk-guionly and that has apparently been solved. After the 3.x

[issue15476] Index "code object" and link to code object definition

2016-06-03 Thread R. David Murray
R. David Murray added the comment: There are entries for code with object as a subentry? That's not what I was talking about, I was talking about preserving the sub entries for 'code' under the 'object' main entry. -- ___ Python tracker

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: Kushal. If you don't mind, I would like Nofar to be able to do this patch. She's been working on it since before the sprints and was slowed down by a schoolwork crunch. -- ___ Python tracker

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: Nofar is about to upload her patch as well (she's been working on this for a while). Perhaps the two can be compared and reconciled so that both can be credited on the commit. -- ___ Python tracker

[issue27182] PEP 519 support in the stdlib

2016-06-03 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: This patch makes the Python and C versions of open()/io.open() support the fspath protocol. -- keywords: +patch Added file: http://bugs.python.org/file43156/issue27182-open.patch ___ Python tracker

[issue27182] PEP 519 support in the stdlib

2016-06-03 Thread Ethan Furman
Ethan Furman added the comment: Sorry, Serhiy, I had my module names mixed up. `nt` and `posix` are the same, but `ntpath` and `posixpath` are not (I may have those first two names wrong again, but hopefully you get the idea). -- ___ Python tracker

[issue26983] float() can return not exact float instance

2016-06-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue5124] IDLE - pasting text doesn't delete selection

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Thank you David, that does help. Your comment emphasizes that on other systems and many other X-11 apps, the user already chooses 'replace' versus 'insert' by selecting a replacement or not. I presume the 'selection buffer' you refer to is different from

[issue27182] PEP 519 support in the stdlib

2016-06-03 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: FYI, I'm working on a patch for builtins.open to call PyOS_FSPath. -- nosy: +Jelle Zijlstra ___ Python tracker ___

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: Thanks, I'll add the equation to the docstring and docs. As for adding a rel_tol to assertAlmostEqual -- I think that's a bad idea -- it's a pretty different concept -- overloading the same method would be more confusing than anything else. in isclose(),

[issue20041] TypeError when f_trace is None and tracing.

2016-06-03 Thread Xavier de Gaye
Xavier de Gaye added the comment: On a 'call' trace event, the bdb dispatch_call() function returns None when there is nothing to trace in this function (no breakpoints). With the changes made by the patch in ceval.c, the costly maybe_call_line_trace() function is not called on each line in

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-03 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker ___

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-03 Thread Berker Peksag
Berker Peksag added the comment: > Hi, I have alphabetized and [...] Can you please de-alphabetize the list to make patch review a little bit easier? Thanks! -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python tracker

[issue27200] make doctest in CPython has failures

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: I'm going to gather together a patch to fix some of these issues. -- messages: 267166 nosy: Jelle Zijlstra, brett.cannon priority: normal severity: normal status: open title: make doctest in CPython has failures

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Robert Collins
Robert Collins added the comment: Thanks for proposing this. I really don't want to add new assertions to unittest, and I certainly don't want to add narrow usage ones like this, nor ones that are confusingly named (this has nothing to do with files, but 'close' is a verb for files, just like

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-03 Thread Joshua Jay Herman
Joshua Jay Herman added the comment: Undid alphabetization and added additional missing environment variables including debug mode variables. -- Added file: http://bugs.python.org/file43166/addMissingEnvironmentVariables.patch ___ Python tracker

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: No, 3.4 is security fixes only and this is a 3.6 only issue. -- ___ Python tracker ___

[issue5124] IDLE - pasting text doesn't delete selection

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In modern text editors selecting text with a mouse moves text cursor, and moving the cursor by arrow keys cancels the selection (if Shift is not pressed). But in terminal emulators selecting text with a mouse doesn't move text cursor, and moving the cursor

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: I'm not sure it's confusing --what would "close" mean for an assertion for a file? "assertClosed" would be confusing -- and an even more trivial assert :-). But we can bikeshed the name if we decide to put this in. """ I certainly don't want to add narrow usage

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Oren Milman
Changes by Oren Milman : Added file: http://bugs.python.org/file43164/patchedCPythonTestOutput.txt ___ Python tracker ___

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread R. David Murray
Changes by R. David Murray : -- nosy: +mark.dickinson ___ Python tracker ___ ___

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- type: behavior -> performance ___ Python tracker ___

[issue27184] Support path objects in the ntpath module

2016-06-03 Thread Brett Cannon
Brett Cannon added the comment: os.path will be updated to work with __fspath__() as specified by Guido as part of the conversation for PEP 519 (IOW listing os.path as being updated in PEP 519 is not an accident). -- ___ Python tracker

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM (except a trailing space in a comment). Thank you for your contribution Oren. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread R. David Murray
R. David Murray added the comment: On the name, I assumed it had something to do with files when I saw the issue title. I'm not sure that's enough of an argument against it, though. There's an issue where Serhiy is proposing a mixin with additional assert methods. If that has any traction

[issue23306] Within zipfile, use of zlib.crc32 raises OverflowError at argument-parsing time on large strings

2016-06-03 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- dependencies: +zlib: OverflowError while trying to compress 2^32 bytes or more stage: -> needs patch ___ Python tracker

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Oren Milman
Oren Milman added the comment: I considered doing that, but I had already opened another issue (http://bugs.python.org/issue27145) in which I had proposed to replace that in-place negate in long_sub with a call to _PyLong_Negate. But I guess I shouldn't worry about my patches colliding.

[issue20041] TypeError when f_trace is None and tracing.

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This may be worthwhile optimization, but this is different issue. Let first fix a TypeError, and then open new issue for the optimization. -- ___ Python tracker

[issue27073] redundant checks in long_add and long_sub

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset c21bf38a9d07 by Serhiy Storchaka in branch 'default': Issue #27073: Removed redundant checks in long_add and long_sub. https://hg.python.org/cpython/rev/c21bf38a9d07 -- nosy: +python-dev ___ Python

[issue17888] docs: more information on documentation team

2016-06-03 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Laura. I will commit issue17888_2.patch later today. -- ___ Python tracker ___

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: updated patch with the equation in the docs. -- Added file: http://bugs.python.org/file43165/assertClose.patch ___ Python tracker

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I meant Tk 8.4, not Python 3.4. Tests should be either passed or skipped, no errors raised. -- ___ Python tracker

[issue5124] IDLE - pasting text doesn't delete selection

2016-06-03 Thread R. David Murray
R. David Murray added the comment: Note that I would find it *very* confusing if the paste took place at some other location than the cursor location. From Serhiy's description I don't think that's an issue in the proposed change. -- ___ Python

[issue27197] mock.patch interactions with "from" imports

2016-06-03 Thread Robert Collins
Robert Collins added the comment: So its a feature of mock that it can mock a module that doesn't exist. And the semantics of the import system are designed to be very cheap when a module is already imported - so when 'patchbug.a' is in sys.modules, import will correctly return it rather than

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-03 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Joshua. I did a quick review and it looks good to me. I will review and test it more carefully later today. -- ___ Python tracker

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: thanks, that's Issue27152 if anyone's curious. Though I have no idea why you'd want it in a mixin, rather than just there. But sure, this could be "bundled" in with that. Perhaps it's time for a broader discussion / consensus about the future of the unittest

[issue22558] Missing doc links to source code for Python-coded modules.

2016-06-03 Thread Nathan Harold
Nathan Harold added the comment: I went through all the diffs in Rietveld, checking it against msg228576 as I went. There were (naturally) more source links added than there are in that list from 2014, and there were also many more files with slight header reorganizations for consistency.

[issue27162] Add idlelib.interface module

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Import should fail if tk.TkVersion < 8.5. -- ___ Python tracker ___ ___

[issue24254] Make class definition namespace ordered by default

2016-06-03 Thread Eric Snow
Eric Snow added the comment: Here's the full patch, including the addition of __definition_order__, tests, and docs. -- Added file: http://bugs.python.org/file43168/deforder.diff ___ Python tracker

[issue24254] Make class definition namespace ordered by default

2016-06-03 Thread Eric Snow
Changes by Eric Snow : Added file: http://bugs.python.org/file43169/deforder.diff ___ Python tracker ___

[issue27152] Additional assert methods for unittest

2016-06-03 Thread Robert Collins
Robert Collins added the comment: I'm fine with these as a mixin - they are all very generic and unambiguously named. I'd marginally prefer the opt-in mixin over adding them to the base class. Ideally they'd be matchers, but since I haven't ported that upstream yet, thats asking for more

[issue27203] Failing doctests in Doc/faq/programming.rst

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Patch attached. Added testsetup for the shared A variable and skipped doctests that rely on the return value of id(). -- files: faqdoctests.patch keywords: patch messages: 267197 nosy: Jelle Zijlstra priority: normal severity: normal status: open

[issue27205] Failing doctests in Library/collections.rst

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Mostly due to unspecified sorting order. The patch sorts a few tests and skips others that can't easily be sorted (e.g. most_common and str() output). -- assignee: docs@python components: Documentation files: doctests-collections.patch keywords:

[issue25738] http.server doesn't handle RESET CONTENT status correctly

2016-06-03 Thread R. David Murray
R. David Murray added the comment: Well, the reason it makes sense to use send_error, or at least the reason I suspect a lot of people do it, is because then you don't have to call end_headers() yourself. So, acknowleding this, it might be worth mentioning in the docs that the body isn't

[issue27206] Failing doctests in Doc/tutorial/

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Patch adds an import. -- assignee: docs@python components: Documentation files: doctests-tutorial.patch keywords: patch messages: 267202 nosy: Jelle Zijlstra, docs@python priority: normal severity: normal status: open title: Failing doctests in

[issue26373] asyncio: add support for async context manager on streams?

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 883cfb3e28f9 by Gregory P. Smith in branch '3.5': Fixes Issue #26373: subprocess.Popen.communicate now correctly ignores https://hg.python.org/cpython/rev/883cfb3e28f9 New changeset 78e81de6d447 by Gregory P. Smith in branch 'default': merge from

[issue26372] Popen.communicate not ignoring BrokenPipeError

2016-06-03 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks, I looked at this issue just today :) -- ___ Python tracker ___ ___

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: I saw the review comment about adding lines. I do not have 8.4 either, but I get the point: the startup version check does not not guard the unittests. After test.text_idle imports unittest and tkinter (as tk) (line 6), I will add if tk.TkVersion < 8.5:

[issue22558] Missing doc links to source code for Python-coded modules.

2016-06-03 Thread Terry J. Reedy
Terry J. Reedy added the comment: Great report. It appears that the remaining questions are subjective decisions for a core developer: what is the best link, if any, for a package; should the link also be last thing in the section. -- ___ Python

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Robert Collins
Robert Collins added the comment: Future direction: hamcrest style matchers. You can read more about them in the context of unittest https://rbtcollins.wordpress.com/2010/05/10/maintainable-pyunit-test-suites/ and http://testtools.readthedocs.io/en/latest/for-test-authors.html#matchers -

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 64e7c8531131 by R David Murray in branch '3.5': #16484: Fix pydoc doc links to modules whose names are mixed case. https://hg.python.org/cpython/rev/64e7c8531131 New changeset 912b9aad0b45 by R David Murray in branch 'default': Merge: #16484: Fix

[issue27204] Failing doctests in Doc/howto/

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Patch adds some imports, fixes doctests syntax, and skips Py2-only code. -- files: doctests-howto.patch keywords: patch messages: 267198 nosy: Jelle Zijlstra priority: normal severity: normal status: open title: Failing doctests in Doc/howto/ Added

[issue27210] Failing doctests due to environmental dependencies in Lib/*lib.rst

2016-06-03 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: The difflib test fails because "False" is close enough to "apple". The ftplib and nntplib tests rely on things downloaded from the web that are inherently variable. -- assignee: docs@python components: Documentation files: doctests-libs.patch

[issue27209] Failing doctests in Library/email.*.rst

2016-06-03 Thread Jelle Zijlstra
Changes by Jelle Zijlstra : -- assignee: docs@python components: Documentation files: doctests-email.patch keywords: patch nosy: Jelle Zijlstra, docs@python priority: normal severity: normal status: open title: Failing doctests in Library/email.*.rst versions:

[issue27202] make doctest fails on 2.7 release notes

2016-06-03 Thread Martin Panter
Changes by Martin Panter : -- Removed message: http://bugs.python.org/msg267213 ___ Python tracker ___

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: """w.r.t. error messages, a regular function that raises AssertionError with a nice message will be precisely as usable.""" sure -- I totally agree -- but that's not the current unittest API :-( where would you put it? How would people find it and know to use

[issue25738] http.server doesn't handle RESET CONTENT status correctly

2016-06-03 Thread Martin Panter
Martin Panter added the comment: Ah, forget that bit about RESET_CONTENT. If we include Content-Length, it will probably be non-zero, which will be wrong. So your patch is better in that regard. -- ___ Python tracker

[issue25548] Show the address in the repr for class objects

2016-06-03 Thread Emanuel Barry
Emanuel Barry added the comment: I'd probably change all instances of ".*" in the regex matches to be "0x.+" instead. For the docstrings that have "..." in them, I would probably make those " at ..." as well (although you get decide if it hinders readability too much). Other than that patch

[issue27203] Failing doctests in Doc/faq/programming.rst

2016-06-03 Thread Martin Panter
Martin Panter added the comment: make -C Doc/ suspicious fails: WARNING: [faq/programming:1177] ".. testsetup:" found in ".. testsetup::" Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv. If all issues are false positives, append that

[issue27198] Adding an assertClose() method to unittest.TestCase

2016-06-03 Thread Chris Barker
Chris Barker added the comment: Would that make folks more amenable to adding more "specialized" asserts? If so, then sure. I don't know that it takes a PEP (I hope not) but it would be good to have some guidance as to the direction we want unittest to take written down somewhere. --

[issue15476] Index "code object" and link to code object definition

2016-06-03 Thread Martin Panter
Martin Panter added the comment: I haven’t tested, but maybe this will do what you want: .. index:: object; code, code object or .. index:: single: object; code single: code object -- ___ Python tracker

[issue16484] pydoc generates invalid docs.python.org link for xml.etree.ElementTree and other modules

2016-06-03 Thread R. David Murray
R. David Murray added the comment: Thanks Sean and Kaushik. The final patch didn't apply to 2.7. If someone wants to port the patch I'll apply it, but I'm going to close the issue. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed type: behavior ->

  1   2   3   >