[issue16334] Faster unicode-escape and raw-unicode-escape codecs

Serhiy Storchaka added the comment: Thanks Victor! I benchmarked your patch. There is no regression in comparison with my patch. In few cases your patch is even faster! UnpatchedPatch v.4Patch v.5 148 (+76%) 235 (+11%) 260decode unicode-escape 'A'*1 197 (+30%) 257

[issue26970] Replace OpenSSL's CPRNG with system entropy source

Christian Heimes added the comment: No, it won't make it into 3.6. My patch is far from ready. -- versions: +Python 3.7 -Python 3.6 ___ Python tracker

[issue16384] import.c doesn't handle EOFError from PyMarshal_Read*

Sye van der Veen added the comment: I feel this patch (file44424) misses the mark. Any two Python processes that try to import a module, without a pyc, at the same time could suffer race conditions. The first process will start to write the pyc, get interrupted, and the second will fail with an

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Roundup Robot added the comment: New changeset ddc95a9bc2e0 by Christian Heimes in branch 'default': Issue #16113: one more C90 violation in big endian code. https://hg.python.org/cpython/rev/ddc95a9bc2e0 -- ___ Python tracker

[issue26032] Use scandir() to speed up pathlib globbing

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue25776] More compact pickle of iterators etc

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file44430/iterators_pickle_4.patch ___ Python tracker ___

[issue27996] Python 3 ssl module can't use a fileno to create a SSLSocket

SenBin Yu added the comment: Yes, the giving code is what i desiere and shoud be supported. Sorry, i haven't see the patch file.And the next release will include this patch? -- ___ Python tracker

[issue27654] [Patch] Use arc4random_buf() on CloudABI

Christian Heimes added the comment: LGTM, but it's Victor's final call. -- assignee: -> haypo ___ Python tracker ___

[issue27996] Python 3 ssl module can't use a fileno to create a SSLSocket

SenBin Yu added the comment: The issue 27629 describe creating a SSLSocket only with server_hostname argument.But what i said is that we can't creating a SSLSocket with fileno argument from a existing socket.I'm strange about this code design that meaningless branch conditions exists.

[issue25856] The __module__ attribute of non-heap classes is not interned

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file44431/intern_and_cache___module__2.patch ___ Python tracker ___

[issue27364] Deprecate invalid escape sequences in str/bytes

Changes by Emanuel Barry : Added file: http://bugs.python.org/file44435/invalid_stdlib_escapes_4.patch ___ Python tracker ___

[issue27996] Python 3 ssl module can't use a fileno to create a SSLSocket

Berker Peksag added the comment: Did you look at the patch? It adds the following test case: +s = socket.socket() +sfd = s.fileno() +# Create secure socket from fileno +ss = ssl.SSLSocket(fileno=sfd) +self.assertTrue(ss.fileno() == sfd) Isn't that what

[issue27364] Deprecate invalid escape sequences in str/bytes

Changes by Emanuel Barry : Removed file: http://bugs.python.org/file44433/invalid_stdlib_escapes_3_regen.patch ___ Python tracker ___

[issue27364] Deprecate invalid escape sequences in str/bytes

Changes by Emanuel Barry : Added file: http://bugs.python.org/file44433/invalid_stdlib_escapes_3_regen.patch ___ Python tracker ___

[issue27654] [Patch] Use arc4random_buf() on CloudABI

Christian Heimes added the comment: Thanks. The bare call to arc4random_buf() looks wrong at first. Please add a comment that arc4random_buf() cannot fail / does not report back errors. -- ___ Python tracker

[issue27654] [Patch] Use arc4random_buf() on CloudABI

Ed Schouten added the comment: Sure thing! Attached is an updated patch. -- Added file: http://bugs.python.org/file44434/patch-arc4random ___ Python tracker

[issue27996] Python 3 ssl module can't use a fileno to create a SSLSocket

Berker Peksag added the comment: Great, closing this then. > And the next release will include this patch? Christian (one of our SSL module maintainers) just reviewed the patch so the next step is to address his review comments and upload a new patch. If you don't see any movement from

[issue27364] Deprecate invalid escape sequences in str/bytes

Emanuel Barry added the comment: Rebased patch after Victor's commit in #16334. Also regenerated invalid_stdlib_escapes_3 in the hopes that Rietveld picks it up. -- Added file: http://bugs.python.org/file44432/deprecate_invalid_escapes_both_4.patch

[issue27137] Python implementation of `functools.partial` is not a class

Emanuel Barry added the comment: Hi Nick, thank you for letting me know! I started trying to fix this, however I found it very hard to fix the recursive repr issue. I've whipped up an incomplete (but yet working) patch that fixes all but the recursive repr issue. Only those two tests fail

[issue26032] Use scandir() to speed up pathlib globbing

Roundup Robot added the comment: New changeset 927665c4aaab by Serhiy Storchaka in branch 'default': Issue #26032: Optimized globbing in pathlib by using os.scandir(); it is now https://hg.python.org/cpython/rev/927665c4aaab -- nosy: +python-dev ___

[issue27963] null poiter dereference in set_conversion_mode due uncheck _ctypes_conversion_errors

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue27938] PyUnicode_AsEncodedString, PyUnicode_Decode: add fast-path for "us-ascii" encoding

Serhiy Storchaka added the comment: Maybe Windows buildbots failures are related: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/8294/steps/test/logs/stdio == FAIL:

[issue27996] Python 3 ssl module can't use a fileno to create a SSLSocket

Berker Peksag added the comment: Thanks for the report. This looks like a duplicate of issue 27629. Please provide a reproducer if it's different problem than issue 27629. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: ->

[issue27998] Add support of bytes paths in os.scandir()

Changes by Serhiy Storchaka : -- title: Add support of butes paths in os.scandir() -> Add support of bytes paths in os.scandir() ___ Python tracker

[issue25596] Use scandir() to speed up the glob module

Dima Tisnek added the comment: @Serhiy please comment the implications / limitations of the fallback on Windows. Is it that scandir cannot handle bytes argument only? If argument is unicode, but response set contains bytes paths, will that work? --

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Roundup Robot added the comment: New changeset e8884dcace9f by Christian Heimes in branch 'default': Issue #16113: compile the module on Windows, too. https://hg.python.org/cpython/rev/e8884dcace9f -- ___ Python tracker

[issue25596] Use scandir() to speed up the glob module

Serhiy Storchaka added the comment: os.scandir() cannot handle bytes argument on Windows. If an argument is string, os.scandir() yields entries with string names, if an argument is bytes object, os.scandir() yields entries with bytes names. Opened issue27998 for adding support of bytes paths

[issue8800] add threading.RWLock

Kristján Valur Jónsson added the comment: Seems to have fizzled out due to the intense amount of bikeshedding required. -- ___ Python tracker ___

[issue25856] The __module__ attribute of non-heap classes is not interned

Serhiy Storchaka added the comment: Could anyone please make a review? -- assignee: -> serhiy.storchaka ___ Python tracker ___

[issue27629] Cannot create ssl.SSLSocket without existing socket

Christian Heimes added the comment: The patch is incomplete. Please also check that type == SOCK_STREAM. The code can be simplified with a bitmask test: if sock is not None: type = sock.type if type & socket.SOCK_STREAM != socket.SOCK_STREAM: raise NotImplementedError --

[issue26896] mix-up with the terms 'importer', 'finder', 'loader' in the import system and related code

Senthil Kumaran added the comment: Hi Brett, I backported only portions of the patch some this issue that were applicable to the issue that I was fixing. I will backport remain portions so that everything will be consistent now. -- Added file:

[issue7769] SimpleXMLRPCServer.SimpleXMLRPCServer.register_function as decorator

Xiang Zhang added the comment: > Also one side effect that I can not eliminate is when it is used as a normal > function, the function instead of None is returned. I see the former patches > get this problem too. I think this does not matter after seeing functools.singledispatch. The

[issue27998] Add support of bytes paths in os.scandir()

Paul Moore added the comment: In the light of Steve Dower's work to "un-deprecate" bytes paths, I agree this should be added. -- ___ Python tracker ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

Changes by Erik Bray : -- nosy: +erik.bray stage: -> patch review ___ Python tracker ___

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Roundup Robot added the comment: New changeset 4971ca2960c7 by Christian Heimes in branch 'default': Issue #16113: KeccakP-1600-opt64 does not support big endian platforms yet. https://hg.python.org/cpython/rev/4971ca2960c7 -- ___ Python tracker

[issue11551] test_dummy_thread.py test coverage improvement

Senthil Kumaran added the comment: I've updated the patch to use unittest.mock, the removed the old style way of exercising it. -- nosy: +orsenthil Added file: http://bugs.python.org/file44429/issue11551.patch ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Changes by Christian Heimes : -- stage: patch review -> commit review ___ Python tracker ___

[issue27928] Add hashlib.scrypt

Christian Heimes added the comment: Benjamin, what's your take on Alex's suggestion? gutworth: Alex_Gaynor has asked me if hashlib.scrypt() can go into 2.7, too. It's a password-based KDF like hashlib.pbkdf2() but more secure than PBKDF2. It requires OpenSSL 1.1.0. gutworth: I think it'd be

[issue27998] Add support of butes paths in os.scandir()

New submission from Serhiy Storchaka: Bytes paths are deprecated on Windows and their support was not added in os.scandir() for purpose. But this makes harder converting filesystem walking functions to use os.scandir(). We have to add a special case for bytes paths on Windows in every such

[issue27998] Add support of bytes paths in os.scandir()

Eryk Sun added the comment: This is implemented in Steve's latest patch in issue 27781. For example: >>> sys.platform 'win32' >>> os.mkdir('test') >>> f = open('test/\U0001.txt', 'w') >>> next(os.scandir(b'test')).name b'\xf0\x90\x80\x80.txt' >>>

[issue27984] singledispatch register should typecheck its argument

Xiang Zhang added the comment: It's also better to add the typecheck to dispatch. Otherwise sometimes it can generate not obvious exception message. >>> from enum import IntEnum >>> from functools import singledispatch >>> IS = IntEnum("IS", "a, b") >>> @singledispatch ... def foo(x): ...

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Roundup Robot added the comment: New changeset 68df416e94ba by Christian Heimes in branch 'default': Issue #16113: take 2 on big endian machines. https://hg.python.org/cpython/rev/68df416e94ba -- ___ Python tracker

[issue16113] Add SHA-3 and SHAKE (Keccak) support

Christian Heimes added the comment: A buildbot is complaining about strict aliasing: In file included from /buildbot/buildarea/3.x.ware-gentoo-x86.installed/build/Modules/_sha3/sha3module.c:113:0:

[issue26307] no PGO for built-in modules with `make profile-opt`

Gregory P. Smith added the comment: My change means that the build/ directory tree exists but won't have any files other than *.gc?? files in it after a make clean. I doubt this will bother anyone. That felt better for clean than just avoiding the removal of build/ entirely. --

[issue27993] In the argparse there are typos with endings in plural words

Roundup Robot added the comment: New changeset c07aadf9f5cb by Martin Panter in branch '2.7': Issue #27993: Fix problems with the plural “objects” in docs and comments https://hg.python.org/cpython/rev/c07aadf9f5cb -- ___ Python tracker

[issue27895] Spelling fixes

Roundup Robot added the comment: New changeset 9a68ab141c33 by Martin Panter in branch '2.7': Issue #27895: Spelling fixes (Contributed by Ville Skyttä). https://hg.python.org/cpython/rev/9a68ab141c33 -- ___ Python tracker

[issue27570] Avoid memcpy(. . ., NULL, 0) etc calls

Roundup Robot added the comment: New changeset d465da1e5902 by Martin Panter in branch '2.7': Issue #27570: Avoid zero-length memcpy() calls with null source pointers https://hg.python.org/cpython/rev/d465da1e5902 -- ___ Python tracker

[issue27993] In the argparse there are typos with endings in plural words

Martin Panter added the comment: Thanks for the patch. I found a few more related instances to fix too. -- nosy: +martin.panter resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 2.7, Python 3.5 ___ Python tracker

[issue27895] Spelling fixes

Changes by Martin Panter : -- versions: +Python 2.7, Python 3.5 ___ Python tracker ___

[issue26359] CPython build options for out-of-the box performance

Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___

[issue18844] allow weights in random.choice

Serhiy Storchaka added the comment: Using a generator doesn't prevents state to be saved and restored. -- ___ Python tracker ___

[issue15578] Crash when modifying sys.modules during import

Roundup Robot added the comment: New changeset 731e5617cc8d by Gregory P. Smith in branch '2.7': Fix placement of Misc/NEWS item for issue #15578. https://hg.python.org/cpython/rev/731e5617cc8d -- ___ Python tracker

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Martin Panter added the comment: Would it be appropriate to always build with _LINUX_SOURCE_COMPAT enabled or disabled? Or is there a disadvantage (e.g. compatibility with different AIX versions, or less functionality?) Do you know if this would also be applicable to 2.7? -- nosy:

[issue27989] incomplete signature with help function using typing

David E. Franco G. added the comment: as that is the case, how about this as a solution: def formatannotation(annotation, base_module=None): if isinstance(annotation, type): if annotation.__module__ in ('builtins', base_module): return annotation.__qualname__

[issue27445] Charset instance not passed to set_payload()

Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review type: -> behavior versions: +Python 3.5 ___ Python tracker

[issue10740] sqlite3 module breaks transactions and potentially corrupts data

Aymeric Augustin added the comment: The latest patch removes the current statement parsing and unexpected implicit commits. It looks good to me. Unfortunately it also introduces a new kind of statement parsing that detects DDL statements and doesn't open a transaction in that case, while it

[issue27948] f-strings: allow backslashes only in the string parts, not in the expression parts

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue27998] Add support of bytes paths in os.scandir()

Steve Dower added the comment: Heh, totally by accident as well. -- ___ Python tracker ___ ___

[issue433028] SRE: (?flag:...) is not supported

Serhiy Storchaka added the comment: Fixed generating info for fast search for groups with local flags and added some documentation (would appreciate for improving it). -- priority: low -> normal versions: +Python 3.6 -Python 3.5 Added file:

[issue27948] f-strings: allow backslashes only in the string parts, not in the expression parts

Changes by Eric V. Smith : -- stage: needs patch -> patch review ___ Python tracker ___

[issue22493] Deprecate the use of flags not at the start of regular expression

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka versions: +Python 3.6 -Python 3.5 ___ Python tracker ___

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

New submission from Matthieu S: Python build fails on AIX when using the _LINUX_SOURCE_COMPAT flag. When using this flag, the gethostbyname_r subroutine has 6 parameters instead of 3, like on Linux, but Modules/socketmodule.c always expects a gethostbyname_r subroutine with only 3 parameters

[issue27968] test_coroutines generates some warnings

Roundup Robot added the comment: New changeset 234f758449f8 by Benjamin Peterson in branch '3.5': supress coroutine warning when an exception is pending (#27968) https://hg.python.org/cpython/rev/234f758449f8 New changeset f48b00b1ec4f by Benjamin Peterson in branch 'default': merge 3.5

[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag

Changes by Eric N. Vander Weele : -- nosy: +ericvw ___ Python tracker ___ ___

[issue27968] test_coroutines generates some warnings

Roundup Robot added the comment: New changeset 096dfac57e44 by Benjamin Peterson in branch '3.5': capture stderr to silence output during test_coroutines (closes #27968) https://hg.python.org/cpython/rev/096dfac57e44 New changeset b43923ce86f0 by Benjamin Peterson in branch 'default': merge 3.5

[issue23591] enum: Add Flags and IntFlags

Vedran Čačić added the comment: I think we had that discussion in the other thread, and concluded that auto() (or _auto_() if you insist) is quite fine. I think it's important to emphasize it's automatically generated, not that it's really "next" in any particular order. --

[issue27877] Add recipe for "valueless" Enums to docs

Ethan Furman added the comment: New changeset 871bdb06c1cf by Ethan Furman in branch 'default': add recipes for pseudo-valueless enums https://hg.python.org/cpython/rev/871bdb06c1cf -- ___ Python tracker

[issue23591] enum: Add Flags and IntFlags

Ethan Furman added the comment: I would like to add a function that can be used when creating a Flag (and Enum, but that's less important) that will generate the next value. This is important because in Flag the values are an important internal detail, but are largely irrelevant to the user

[issue27877] Add recipe for "valueless" Enums to docs

Ethan Furman added the comment: Thanks for the patch, John and Emanuel! -- ___ Python tracker ___ ___

[issue27928] Add hashlib.scrypt

Gregory P. Smith added the comment: No, scrypt is a simple new feature. An extension module on PyPI is the appropriate place for that for 2.6 through 3.5. Wholly unrelated to PEP466. -- ___ Python tracker

[issue27928] Add hashlib.scrypt

Alex Gaynor added the comment: PEP466 includes hashlib.pbkdf2_hmac(). Any reasoning that includes that surely is applicable to scrypt as well. -- ___ Python tracker

[issue23591] enum: Add Flags and IntFlags

Changes by STINNER Victor : -- nosy: -haypo ___ Python tracker ___ ___

[issue10740] sqlite3 module breaks transactions and potentially corrupts data

Berker Peksag added the comment: Here is an updated patch. I'd like to get this in before 3.6 beta 1. -- Added file: http://bugs.python.org/file44437/issue10740_upstream_v2.diff ___ Python tracker

[issue27948] f-strings: allow backslashes only in the string parts, not in the expression parts

Eric V. Smith added the comment: This patch implements the new logic. It passes all of the fstring tests (except of course the ones that had backslashes in the expressions). I'd still like to add some more tests, because I'm not convinced the named unicode escapes are correct (f"\N{LEFT CURLY

[issue27999] Make "global after use" a SyntaxError

New submission from Ivan Levkivskyi: The documentation at https://docs.python.org/3/reference/simple_stmts.html says that: "Names listed in a global statement must not be used in the same code block textually preceding that global statement" But then later: "CPython implementation detail:

[issue16334] Faster unicode-escape and raw-unicode-escape codecs

STINNER Victor added the comment: Feel free to document the change. It's not my patch, it's yours :-) -- ___ Python tracker ___

[issue23591] enum: Add Flags and IntFlags

Ethan Furman added the comment: I like it! (Although I have no idea which other thread you are talking about.) And yes, it needs the leading and trailing underscore so as not to clash with member names. -- ___ Python tracker

[issue27137] Python implementation of `functools.partial` is not a class

Serhiy Storchaka added the comment: I think we can change C implementation of __repr__ to match straightforward Python implementation. -- ___ Python tracker

[issue27010] email library could "recover" from bad mime boundary like (some?) email clients do

R. David Murray added the comment: Andrea: yes, your patch is different from what I had in mind. The idea would be to recognize the "nested part with duplicate boundary", register the new defect, but produce a Message object with a structure that looked like this: multipart/mixed

[issue21826] Performance issue (+fix) AIX ctypes.util with no /sbin/ldconfig present

Michael Felt added the comment: re: issue 26439 and issue 27435 would like to show: without patch, find_library() is consistently slow, and in default situations, returns nothing. root@x064:[/data/prj/aixtools/python/python-2.7.10]./python -m timeit -n 100 'import ctypes.util;

[issue27989] incomplete signature with help function using typing

Guido van Rossum added the comment: That sounds a fine solution (except the elif should just test for `in 'typing'`). Can one of you prepare a patch? I think it should be fine to fix this in 3.5 as well. There should be a unit test for this. -- ___

[issue27331] Add a policy argument to email.mime.MIMEBase

R. David Murray added the comment: I'm going to commit this, but leave the issue open for someone to provide tests. -- stage: patch review -> test needed ___ Python tracker

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

Christian Heimes added the comment: On 2016-09-07 05:06, Larry Hastings wrote: > > Larry Hastings added the comment: > >> FWIW the cipher list (at least the restricted ones for >> ssl.create_default_context()) is explicitly documented >> as being able to be changed at any time without prior

[issue10839] email module should not allow some header field repetitions

R. David Murray added the comment: I've committed Berker's patch from #27331, and I'm about to take the new email API out of provisional status. Barry is committed to not changing this behavior in 2.7 and I agree. In any case 2.7 doesn't differentiate between headers being added by the user

[issue28002] Some f-strings do not round trip through Tools/parser/test_unparse.py

Changes by Eric V. Smith : -- title: f-strings do not round trip through Tools/parser/test_unparse.py -> Some f-strings do not round trip through Tools/parser/test_unparse.py ___ Python tracker

[issue27331] Add a policy argument to email.mime.MIMEBase

R. David Murray added the comment: Sorry, I must have mispaged or something and missed the tests on the first readthrough. -- ___ Python tracker ___

[issue27331] Add a policy argument to email.mime.MIMEBase

Roundup Robot added the comment: New changeset 481d14cb7595 by R David Murray in branch 'default': #27331: add policy keyword argument to all MIME subclasses. https://hg.python.org/cpython/rev/481d14cb7595 -- nosy: +python-dev ___ Python tracker

[issue1602] windows console doesn't print or input Unicode

Steve Dower added the comment: Updated patch based on some suggestions from Eryk. The PEP has been accepted, so now I just need to land it in the next two days. Currently "normal" usage here is fine, and some edge cases match the Python 3.5 behaviour. I'm going to go through now and bulk out

[issue27781] Change sys.getfilesystemencoding() on Windows to UTF-8

Steve Dower added the comment: PEP 529 has been accepted, so this really needs a review now. But since it's experimental and all the tests pass, I'll be committing it shortly anyway and will be tidying up issues during beta. -- ___ Python tracker

[issue27999] Make "global after use" a SyntaxError

Ivan Levkivskyi added the comment: Yes, nonlocal will be fixed too. This will be a relatively small patch, but I am a bit afraid there could be merge conflicts (the code affected could overlap with changes for PEP 526). Easiest way would be to simply make this a single patch with PEP 526

[issue27989] incomplete signature with help function using typing

Guido van Rossum added the comment: I've lost you -- why don't you upload a patch? -- ___ Python tracker ___

[issue19500] Add client-side SSL session resumption

Christian Heimes added the comment: Session resumption is currently broken in OpenSSL 1.1.0, https://github.com/openssl/openssl/issues/1550 -- ___ Python tracker

[issue27999] Make "global after use" a SyntaxError

Ivan Levkivskyi added the comment: OK, then I think after will be safer. Let us came back to this right after PEP 526. -- ___ Python tracker ___

[issue27137] Python implementation of `functools.partial` is not a class

Emanuel Barry added the comment: Thank you Serhiy for the comments! Here's a new patch. I'm fine with the recursive repr tests failing for now; it's something I believe we can fix during the beta phase if we don't have time before (fix as in modify the C implementation to match the Python

[issue28005] Broken encoding modules are silently skipped.

Changes by Sye van der Veen : -- nosy: +syeberman ___ Python tracker ___ ___

[issue28006] Remove tracing overhead from the fine-grained fast opcodes

Changes by Raymond Hettinger : -- nosy: +benjamin.peterson ___ Python tracker ___

[issue27999] Make "global after use" a SyntaxError

Guido van Rossum added the comment: I strongly prefer to have it as a separate patch (either before or after) to avoid the appearance of piggy-backing this in with a much larger change. -- ___ Python tracker

[issue22233] http.client splits headers on non-\r\n characters

R. David Murray added the comment: I want to stack another patch on top of this, so I committed it. If you see anything I screwed up, Martin, please let me know. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___

[issue27989] incomplete signature with help function using typing

Spencer Brown added the comment: It might be better to just change the if statement to 'if isinstance(annotation, type) and type(annotation).__repr__ is type.__repr__:'. That would make it fallback for any metaclass which overrides repr, instead of special-casing typing. That also ensures

[issue27331] Add a policy argument to email.mime.MIMEBase

R. David Murray added the comment: Thanks, Berker. -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker ___

  1   2   3   >