[issue29034] Fix memory leak and use-after-free in path_converter

2017-01-05 Thread Xiang Zhang
Xiang Zhang added the comment: path_converter-new-2.patch addresses Serhiy's comments. :-) -- Added file: http://bugs.python.org/file46170/path_converter-new-2.patch ___ Python tracker _

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread Nick Coghlan
Nick Coghlan added the comment: And by PEP 528, I actually mean PEP 538 :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread Nick Coghlan
Nick Coghlan added the comment: Docker containers don't have a locale set by default - the approach proposed in PEP 528 actually comes from the way I configure Docker images (which in turn comes from Armin Ronacher's recommendations in click for Python 3 locale handling). In the Dockerfile fo

[issue29170] Curses Module should check for is_keypad and not window flags

2017-01-05 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> duplicate stage: -> resolved superseder: -> Fix curses module compilation with ncurses6 ___ Python tracker ___ ___

[issue29172] blake2: Use lowest-common denominator signature of #pragma pack

2017-01-05 Thread Martin Panter
Martin Panter added the comment: FWIW Issue 28290 was also opened about this pragma directive being not recognized by a compiler called xlC on AIX. -- nosy: +martin.panter ___ Python tracker __

[issue28231] zipfile does not support pathlib

2017-01-05 Thread Berker Peksag
Berker Peksag added the comment: I think the next steps are: 1. Add tests for the cases Serhiy has mentioned in msg277109: > Shouldn't the ZipFile.filename attribute be converted to str? and > The file name of ZipFile is only a part of the issue. There are other uses of file paths:

[issue28231] zipfile does not support pathlib

2017-01-05 Thread Jeremy Freeman
Jeremy Freeman added the comment: OK, I understand. How can I help get this issue fixed? 1) review the patch? 2) update the docs to reflect the patch? 3) find the other uses of pathlib in the zipfile module? 4) something else ... I am a longtime user of python but a first time contributor but

[issue28848] Add CopyingMock to mock.py

2017-01-05 Thread Berker Peksag
Berker Peksag added the comment: Thanks for releasing it on PyPI! It's probably better to keep it as an example in the documentation for now. We can reopen this if there's a demand for CopyingMock in the future. -- nosy: +berker.peksag resolution: -> rejected stage: -> resolved statu

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

2017-01-05 Thread Berker Peksag
Changes by Berker Peksag : -- type: -> behavior versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bugs-

[issue29173] Python 3.6 on Windows wastes a lot of CPU cycles in a while loop

2017-01-05 Thread Eryk Sun
Changes by Eryk Sun : -- stage: -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue29173] Python 3.6 on Windows wastes a lot of CPU cycles in a while loop

2017-01-05 Thread Prahlad Yeri
Prahlad Yeri added the comment: Hi STINNER Victor, Thanks a lot, after adding the sleep function, it has stopped wasting the CPU cycles! A long while ago, I remember coding a similar loop in linux and not faced such issue, so I thought maybe it was a bug in 3.6. Anyway, I'm closing this. ---

[issue29173] Python 3.6 on Windows wastes a lot of CPU cycles in a while loop

2017-01-05 Thread STINNER Victor
STINNER Victor added the comment: The code doesn't seem like a bug in Python, but more a classic inefficient busy loop pattern. Your loop doesn't sleep and so eats all the CPU. I suggest to close the issue and ask Python questions on a place to ask questions, not on the Python *bug tracker*.

[issue29173] Python 3.6 on Windows wastes a lot of CPU cycles in a while loop

2017-01-05 Thread Prahlad Yeri
New submission from Prahlad Yeri: I'm running Python 3.6 on Windows 7. It wastes a lot of cpu cycles when inside a loop. In attached screenshot, you'll find that ~25% cpu is used by Python, while all I'm doing is running a pomodoro script that waits for a specific timeslot to complete. Here is

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

2017-01-05 Thread Milan Oberkirch
Changes by Milan Oberkirch : -- type: behavior -> versions: -Python 3.5, Python 3.6, Python 3.7 Added file: http://bugs.python.org/file46168/ignore_dots-v2.patch ___ Python tracker ___

[issue2771] Test issue

2017-01-05 Thread Ezio Melotti
Ezio Melotti added the comment: another test -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue2771] Test issue

2017-01-05 Thread Ezio Melotti
Ezio Melotti added the comment: testing github integration -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue29172] blake2: Use lowest-common denominator signature of #pragma pack

2017-01-05 Thread Eric N. Vander Weele
New submission from Eric N. Vander Weele: Solaris Studio emits the following during compilation: "/tmp/Python-3.6.0/Modules/_blake2/impl/blake2.h", line 89: warning: ignoring malformed #pragma pack(n) "/tmp/Python-3.6.0/Modules/_blake2/impl/blake2.h", line 119: warning: ignoring malfor

[issue29021] Custom functions in sqlite receive None on invalid UTF-8

2017-01-05 Thread Aviv Palivoda
Aviv Palivoda added the comment: Actually had a small mistake in the patch I uploaded. Uploading a fixed one. -- Added file: http://bugs.python.org/file46166/29021-fixed.patch ___ Python tracker ___

[issue29171] blake2: Remove unused function to avoid undefined references

2017-01-05 Thread Eric N. Vander Weele
Changes by Eric N. Vander Weele : -- title: Remove unused blake2 function to avoid undefined references -> blake2: Remove unused function to avoid undefined references ___ Python tracker __

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread STINNER Victor
STINNER Victor added the comment: > Working with Docker I often end up with an environment where the locale isn't > correctly set. The locale encoding is controlled by 3 environment variables: LC_ALL, LC_CTYPE and LANG. https://www.python.org/dev/peps/pep-0540/#the-posix-locale-and-its-encodin

[issue29171] Remove unused blake2 function to avoid undefined references

2017-01-05 Thread Eric N. Vander Weele
New submission from Eric N. Vander Weele: Compilers are not required to elide static functions which are unused. Some compilers, such as Solaris Studio, always emits the function, even if the function does not get called within the translation unit. This becomes problematic when a static inline

[issue29169] update zlib to 1.2.10

2017-01-05 Thread Raymond Hettinger
Raymond Hettinger added the comment: > I'm inclined to not cherry-pick this, which means it'd > ship in 3.5.4 and 3.4.7, probably in six months. I concur. Looking at the CVEs, these all seem minor and not exploitable through the Python interface. -- nosy: +rhettinger ___

[issue29170] Curses Module should check for is_keypad and not window flags

2017-01-05 Thread Roy Marples
Roy Marples added the comment: It is, sorry for noise. -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue29034] Fix memory leak and use-after-free in path_converter

2017-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: path->length and path->object are set in each way to success_exit (except error_exit). I think these assignment can be moved after success_exit. -- ___ Python tracker __

[issue29170] Curses Module should check for is_keypad and not window flags

2017-01-05 Thread Masayuki Yamamoto
Masayuki Yamamoto added the comment: #25720 is a similar issue that is originated by opaque type WINDOW. -- nosy: +masamoto ___ Python tracker ___ ___

[issue29021] Custom functions in sqlite receive None on invalid UTF-8

2017-01-05 Thread Aviv Palivoda
Aviv Palivoda added the comment: I actually was wrong and there is no problem with the type that is returned from the text_factory as it passes directly as argument for the create_function function. Attached is a patch that change create_function and create_aggregate to use the text_factory w

[issue29170] Curses Module should check for is_keypad and not window flags

2017-01-05 Thread Roy Marples
Roy Marples added the comment: Remove WINDOW test Add is_keypad test Change #define in _cursesmodule.c -- keywords: +patch Added file: http://bugs.python.org/file46163/cursesmodule.patch ___ Python tracker

[issue29159] Regression in bytes constructor

2017-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The code restored by 29159-index-fallback.patch is slightly different from the code before issue27704, but the patch LGTM except that arguments of assertEqual are in reversed order. > Can you explain what your patch does? I don't understand why you single o

[issue27961] remove support for platforms without "long long"

2017-01-05 Thread STINNER Victor
STINNER Victor added the comment: > The backwards compatibility is not as strong as it could be: previously, > HAVE_LONG_LONG was defined to 1; now it's defined but empty. Oh, right. This issue should now be fixed as well. -- ___ Python tracker

[issue27961] remove support for platforms without "long long"

2017-01-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset fad67c66885f by Victor Stinner in branch '3.6': Issue #27961: Define HAVE_LONG_LONG as 1. https://hg.python.org/cpython/rev/fad67c66885f -- ___ Python tracker

[issue29170] Curses Module should check for is_keypad and not window flags

2017-01-05 Thread Roy Marples
New submission from Roy Marples: checking whether WINDOW has _flags... no The ncurses library can be built with an opaque window structure. As such, it's not always possible to query it's flags. Luckily there is the is_keypad function which works regardless of how ncurses was built. If this te

[issue28848] Add CopyingMock to mock.py

2017-01-05 Thread wim glenn
wim glenn added the comment: Guess there was no interest in this. I've released it on pypi instead (pip install copyingmock). https://github.com/wimglenn/copyingmock -- ___ Python tracker

[issue29169] update zlib to 1.2.10

2017-01-05 Thread Larry Hastings
Larry Hastings added the comment: I cut 3.4.6rc1 and 3.5.3rc1 a couple of days ago. Do you think the CVEs are bad enough to warrant cherry-picking this? A quick google suggests they were all low severity: http://www.openwall.com/lists/oss-security/2016/12/05/21 I'm inclined to not cherry-pi

[issue29159] Regression in bytes constructor

2017-01-05 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On the other hand, the documentation for the bytearray constructor [1] lists integer argument first. [1]: https://docs.python.org/3/library/functions.html#bytearray -- ___ Python tracker

[issue29159] Regression in bytes constructor

2017-01-05 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: @inada.naoki Sorry, I still don't understand the role of OverflowError. With respect to my earlier suggestion that buffer protocol should have priority over __index__, note that the documentation implies the same order: >>> help(bytes) class bytes(obje

[issue29057] Compiler failure on Mac OS X - sys/random.h

2017-01-05 Thread Jim Nasby
Jim Nasby added the comment: I take it back... turns out I was building with the unsupported macports gcc. -- ___ Python tracker ___ _

[issue29057] Compiler failure on Mac OS X - sys/random.h

2017-01-05 Thread Larry Hastings
Larry Hastings added the comment: Mr. Nasby, as long as you're in a test-reproducing mood, would you mind downloading the source to 3.5.3rc1 and confirming that it builds correctly for you? I'd appreciate it! (Not that I don't trust Ned et al, but independent confirmation always helps soothe

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread STINNER Victor
STINNER Victor added the comment: > That way each PEP can argue as strongly as it can for the respective authors > preferred approach to tackling the default C locale problem, even if they > point to a common background section in one of the PEPs (similar to the way > PEPs 522 and 524 shared a

[issue29132] shlex.shlex with punctuation_chars and posix doesn't handle punctuation next to quotes

2017-01-05 Thread Vinay Sajip
Vinay Sajip added the comment: Evan, thanks for looking at this. Would you like to submit a completed contributor form? https://www.python.org/psf/contrib/contrib-form/ -- ___ Python tracker _

[issue29057] Compiler failure on Mac OS X - sys/random.h

2017-01-05 Thread Jim Nasby
Jim Nasby added the comment: This is still affecting me on 2.7, even with the new changes. 3.7 seems to be OK (I'm getting a different error on 3.7, but it seems unrelated to this.) OS X 10.11.6. -- nosy: +Jim Nasby ___ Python tracker

[issue29167] Race condition in enum.py:_decompose()

2017-01-05 Thread Ethan Furman
Changes by Ethan Furman : -- assignee: -> ethan.furman stage: -> test needed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue29167] Race condition in enum.py:_decompose()

2017-01-05 Thread Ethan Furman
Ethan Furman added the comment: Simon, can you post the exact line of code that causes the error? It would be useful for creating a test case and the couple things I have tried to duplicate the error have worked fine. -- ___ Python tracker

[issue29169] update zlib to 1.2.10

2017-01-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset ed172054a812 by doko in branch '2.7': - Issue #29169: Update zlib to 1.2.10. https://hg.python.org/cpython/rev/ed172054a812 -- nosy: +python-dev ___ Python tracker ___

[issue29034] Fix memory leak and use-after-free in path_converter

2017-01-05 Thread Xiang Zhang
Xiang Zhang added the comment: The new patch is a try to solve the problems mentioned in this thread. > It can be solved by making path->object referring an original argument (but > some code checks the type of path->object), or making path->object owning a > reference. I prefer the later app

[issue28231] zipfile does not support pathlib

2017-01-05 Thread R. David Murray
R. David Murray added the comment: In 3.5 the stdlib is not supporting PathLib. So this issue only affects 3.6 and 3.7. -- nosy: +r.david.murray ___ Python tracker ___

[issue26865] Meta-issue: support of the android platform

2017-01-05 Thread Xavier de Gaye
Xavier de Gaye added the comment: Removing issues from the dependencies list: issue #22747: Interpreter fails in initialize on systems where HAVE_LANGINFO_H is undefined This issue is fixed for Android. issue #26859: unittest fails with "Start directory is not importable" when try

[issue29168] multiprocessing pickle error

2017-01-05 Thread Davin Potts
Davin Potts added the comment: Simon: You do have a lock object inside the logging handler object. That is what prevents your pickling of the logging handler object. The background information Serhiy shared is focused on why pickling a _thread.RLock object is problematic and unsupportable.

[issue29168] multiprocessing pickle error

2017-01-05 Thread Vinay Sajip
Vinay Sajip added the comment: > Have a look at the sample.py program. It fails on Python 3.4.3 on my Linux system (just renamed to mp_sample.py): python3 mp_sample.py starting (without multiprocessing pool)... worker process 0 worker process 3 worker process 4 worker process 6 worker process

[issue28231] zipfile does not support pathlib

2017-01-05 Thread Jeremy Freeman
Jeremy Freeman added the comment: This also affects python 3.5 on Windows and OSX. Python 3.5.2 (default, Sep 21 2016, 15:07:18) [GCC 4.2.1 Compatible Apple LLVM 7.3.0 (clang-703.0.31)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> from pathlib import Path

[issue29168] multiprocessing pickle error

2017-01-05 Thread Simon Schuler
Simon Schuler added the comment: I don't have any lock object. I just use the multiprocessing pool and a QueueHandler in order to be able to log from all processes. -- ___ Python tracker __

[issue26851] android compilation and link flags

2017-01-05 Thread Xavier de Gaye
Xavier de Gaye added the comment: > Just tried. With my packaging scripts, CPython on ARM is compiled with > -mfloat-abi=softfp -mfpu=vfpv3-d16 while libffi not. test_ctypes pass as > usual. This works as expected, '-mfloat-abi=softfp' and the default '-mfloat-abi=soft' use the same ABI [1]:

[issue29168] multiprocessing pickle error

2017-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: _thread.RLock objects were wrongly pickleable before 3.6. >>> import pickle, pickletools, _thread >>> lock = _thread.RLock() >>> lock.acquire() True >>> lock >>> pickle.loads(pickle.dumps(lock)) >>> pickletools.dis(pickletools.optimize(pickle.dumps(lock)))

[issue29168] multiprocessing pickle error

2017-01-05 Thread Simon Schuler
Simon Schuler added the comment: I want to handle the logging of the main and all my started processes. They should all log to the same Queue. Have a look at the sample.py program. In addition there is a inconsistency in using a multiprocessing pool or just the process class directly. The sam

[issue29169] update zlib to 1.2.10

2017-01-05 Thread Matthias Klose
New submission from Matthias Klose: These are the changes updating zlib from 1.2.8 to 1.2.10. It is only used when building without a system zlib. The new release includes fixes for security issues CVE-2016-9840, CVE-2016-9841, CVE-2016-9842, CVE-2016-9843. Intending to update all active bran

[issue29168] multiprocessing pickle error

2017-01-05 Thread Vinay Sajip
Vinay Sajip added the comment: It may be that _thread.RLock objects were pickleable before 3.6 but aren't now, and if so, then this is unrelated to logging except by coincidence. Why do you want to pickle the *handler*? It's not especially designed for sending over the wire, and that's not sup

[issue29164] make test always fail at 218/405 ( AssertionError: ', ' not found in '1234.5' )

2017-01-05 Thread Eric V. Smith
Changes by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Jan 05, 2017, at 11:11 AM, STINNER Victor wrote: >I'm sure that many Linux, UNIX and BSD systems don't have the "C.UTF-8" >locale. For example, HP-UX has "C.utf8" which is not exactly "C.UTF-8". > >I'm not sure that it's ok in 2017 to always force the UTF-8

[issue29168] multiprocessing pickle error

2017-01-05 Thread Davin Potts
Changes by Davin Potts : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue29168] multiprocessing pickle error

2017-01-05 Thread Davin Potts
Davin Potts added the comment: In your first example (not sample.py), if I make the following change: #queue = multiprocessing.Manager().Queue(-1) queue = 42 I am still able to reproduce the exception you observe. This suggests the issue has nothing to do with the use of multiprocessing but

[issue26851] android compilation and link flags

2017-01-05 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: > Note that the system libffi must also be compiled with these same flags Just tried. With my packaging scripts, CPython on ARM is compiled with -mfloat-abi=softfp -mfpu=vfpv3-d16 while libffi not. test_ctypes pass as usual. Maybe ctypes test suite is not compl

[issue29168] multiprocessing pickle error

2017-01-05 Thread Simon Schuler
Simon Schuler added the comment: Attached is a sample program to illustrate the problem. When I use a multiprocessing pool the exception is raised. -- Added file: http://bugs.python.org/file46160/sample.py ___ Python tracker

[issue26865] Meta-issue: support of the android platform

2017-01-05 Thread Xavier de Gaye
Xavier de Gaye added the comment: issue #28833: cross compilation of third-party extension modules -- dependencies: +byte-compile fails for cross-builds, cross compilation of third-party extension modules ___ Python tracker

[issue4431] Distutils MSVC doesn't create manifest file

2017-01-05 Thread Mark Lawrence
Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread Nick Coghlan
Nick Coghlan added the comment: The trade-offs here are incredibly complex (and are mainly a matter of deciding whose code and configurations we want to break in 3.7+), so I think competing PEPs are going to be better than attempting to create a combined PEP that tries to cover all the options

[issue4431] Distutils MSVC doesn't create manifest file

2017-01-05 Thread Charles Brossollet
Charles Brossollet added the comment: Here with python 2.7.13 and Visual Studio 2013, I get hit by the problem and it looks like link.exe needs the /MANIFEST keyword. Voting to get it fixed! -- nosy: +Charles Brossollet ___ Python tracker

[issue29158] Possible glitch in the interaction of a thread and a multiprocessing manager

2017-01-05 Thread luke_16
luke_16 added the comment: Relating to the idea that it is not recommended to spawn a process whenever there are already spawned threads running, which would be the case of the server side of my example, I have to disagree. If a process is supposed to be completely independent of the current o

[issue26851] android compilation and link flags

2017-01-05 Thread Xavier de Gaye
Xavier de Gaye added the comment: In the code review Victor asked the following question: > I'm a little bit surprised that you need to pass so much options which are > specific to the platform. GCC doesn't have a generic option "hello, please > compile for my architecture?" ARM defines two i

[issue29163] shlex error in posix mode and empty quotes

2017-01-05 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python

[issue29168] multiprocessing pickle error

2017-01-05 Thread Simon Schuler
New submission from Simon Schuler: Hello, the following code doesn't work any longer in the new Python version 3.6. import sys import os import subprocess from multiprocessing import Pool, Value, Queue import multiprocessing import logging import logging.handlers import pickle queue = multipro

[issue29160] pow with three int arguments works like it had two arguments

2017-01-05 Thread Mark Dickinson
Mark Dickinson added the comment: > shall we make a report for 'numpy guys' directly? Yes, please! I'll close here, since this isn't a core Python issue: what 3rd party libraries choose to do in their `__pow__` methods is out of the control of the core language. -- nosy: +mark.dickins

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: While going for the full locale setting may be a good option, perhaps just focusing on the FS encoding for now is a better way forward (and also more in line with the ticket title). So essentially go for the PEP 529 approach on Unix as well (except that we u

[issue29145] failing overflow checks in replace_*

2017-01-05 Thread Xiang Zhang
Xiang Zhang added the comment: > It seems to me that unicodeobject.c should be changed in 3.x too. I don't understand. Would you mind tell me which part? The only suspicious part to me is `PY_SSIZE_T_MAX >> (rkind - 1)`. It seems should be `PY_SSIZE_T_MAX / rkind`. And I missed jan's patch so

[issue29145] failing overflow checks in replace_*

2017-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It seems to me that unicodeobject.c should be changed in 3.x too. -- ___ Python tracker ___ ___ Py

[issue29157] random.c: Prefer getrandom() over getentropy(), handle ENOSYS in py_getentropy()

2017-01-05 Thread Christian Heimes
Christian Heimes added the comment: I'm doing a review now. By the way I did not copy random.c for cryptography. I took bits and pieces out of it. https://github.com/pyca/cryptography/blob/master/src/_cffi_src/openssl/src/osrandom_engine.c and https://github.com/pyca/cryptography/blob/master

[issue29163] shlex error in posix mode and empty quotes

2017-01-05 Thread Evan
Evan added the comment: My mistake, it was addressed directly in issue21999. This is already fixed in 2.7.13 and will be fixed in 3.5.3. -- ___ Python tracker ___ __

[issue29145] failing overflow checks in replace_*

2017-01-05 Thread Xiang Zhang
Xiang Zhang added the comment: > some instances are present in unicodeobject.c too Thanks for your notification. v3 adds the some changes needed I could find in unicodeobject.c. Nothing in v2 is changed. -- Added file: http://bugs.python.org/file46158/replace-overflow-check-v3.patch

[issue29157] random.c: Prefer getrandom() over getentropy(), handle ENOSYS in py_getentropy()

2017-01-05 Thread STINNER Victor
STINNER Victor added the comment: Nick: Thanks for the review! Since random.c is critical for security, I would prefer to have at least a review from another core developer. I added Serhiy and Xiang in the nosy list. I'm also looking at you, Christian! ;-) (Christian reused random.c code in th

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread STINNER Victor
STINNER Victor added the comment: Sorry, I still didn't have enough time to read carefully the PEP 538. But since the discussion already started on this issue, I will add my comments: * I'm sure that many Linux, UNIX and BSD systems don't have the "C.UTF-8" locale. For example, HP-UX has "C.ut

[issue29145] failing overflow checks in replace_*

2017-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: replace-overflow-check-v2.patch LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue29157] random.c: Prefer getrandom() over getentropy(), handle ENOSYS in py_getentropy()

2017-01-05 Thread Nick Coghlan
Nick Coghlan added the comment: New patch looks good to me, and +1 on applying the refactoring to all supported branches. -- ___ Python tracker ___ _

[issue29167] Race condition in enum.py:_decompose()

2017-01-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- components: +IO nosy: +ethan.furman type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-li

[issue29163] shlex error in posix mode and empty quotes

2017-01-05 Thread Evan
Evan added the comment: This is also broken in 3.5.2, but not in 3.6.0: >>> list(shlex.shlex('echo b="",echo bar', posix=True)) ['echo', 'b', '=', '', ',', 'echo', 'bar'] I'm guessing it was fixed incidentally by the changes in issue1521950. -- versions: +Python 3.5 __

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread Nick Coghlan
Nick Coghlan added the comment: The PEP already explains how other runtimes achieve UTF-8 and UTF-18-LE everywhere: by ignoring the C/C++ locale entirely. While this breaks integration with other C/C++ components, the developers of those languages and runtimes simply don't care, as they never

[issue29167] Race condition in enum.py:_decompose()

2017-01-05 Thread Simon Percivall
New submission from Simon Percivall: When called by `_create_pseudo_member_()`, the dictionary iteration of `_value2member_map` in `_decompose()` in enum.py may lead to a "RuntimeError: dictionary changed size during iteration". For me, it happened in `re.compile`. ``` Traceback (most recent c

[issue29157] random.c: Prefer getrandom() over getentropy(), handle ENOSYS in py_getentropy()

2017-01-05 Thread STINNER Victor
STINNER Victor added the comment: New patch (version 2), much larger: it refactors the code, not only fix this specific issue (prefer getrandom() over getentropy()). Changes since getentropy.patch: * Add a lot of comments to explain in depth how each function is implemented, which errors are

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread Nick Coghlan
Nick Coghlan added the comment: No, requesting a locale that doesn't exist doesn't error out, because we don't check the return code - it just keeps working the same way it does now (i.e. falling back to the legacy C locale). However, it would be entirely reasonable to put together a competing

[issue29163] shlex error in posix mode and empty quotes

2017-01-05 Thread Evan
Changes by Evan : -- nosy: +evan_ ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailm

[issue29145] failing overflow checks in replace_*

2017-01-05 Thread jan matejek
jan matejek added the comment: some instances are present in unicodeobject.c too -- Added file: http://bugs.python.org/file46156/unicode-overflow.patch ___ Python tracker ___ ___

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread INADA Naoki
INADA Naoki added the comment: Why I want to add configure option to ignore locale is: 1. C.UTF-8 is not supported by RHEL7 (https://bugzilla.redhat.com/show_bug.cgi?id=1361965) RHEL7 will be used for a long time. And many people uses new Python instead of distro's Python, via pyenv or pytho

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: On 05.01.2017 10:26, Nick Coghlan wrote: > > Anything purely on the Python side of things doesn't work in a traditional C > environment - CPython relies on the C lib to do conversions during startup, > so we need the C locale to be set correctly. We can do

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread INADA Naoki
INADA Naoki added the comment: > Anything purely on the Python side of things doesn't work in a traditional C > environment - CPython relies on the C lib to do conversions during startup, > so we need the C locale to be set correctly. What I propose is non't use mbstowcs, like __ANDROID__ wc

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

2017-01-05 Thread Berker Peksag
Berker Peksag added the comment: Yes, thanks! -- nosy: +martin.panter, xiang.zhang stage: -> patch review type: -> behavior versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___

[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-05 Thread Nick Coghlan
Nick Coghlan added the comment: Anything purely on the Python side of things doesn't work in a traditional C environment - CPython relies on the C lib to do conversions during startup, so we need the C locale to be set correctly. We can do things differently on Mac OS X and iOS because Apple e

[issue29023] Results of random.seed() call with integer argument should be claimed deterministic.

2017-01-05 Thread Raymond Hettinger
Raymond Hettinger added the comment: Attached patch simplifies, improves, and syncs the main docs with the docstrings. -- ___ Python tracker ___

[issue29023] Results of random.seed() call with integer argument should be claimed deterministic.

2017-01-05 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- keywords: +patch Added file: http://bugs.python.org/file46155/random_docs.diff ___ Python tracker ___ __

[issue29023] Results of random.seed() call with integer argument should be claimed deterministic.

2017-01-05 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- Removed message: http://bugs.python.org/msg284677 ___ Python tracker ___ ___ Python-bugs-list mailin

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

2017-01-05 Thread Milan Oberkirch
Milan Oberkirch added the comment: Too bad, I was all exited when I saw that I can paste a PR link here :) I downloaded the patch from the commit using github, I hope that works? -- keywords: +patch Added file: http://bugs.python.org/file46154/ignore_dots-v1.patch _