[issue29463] Add `docstring` attribute to AST nodes

Jeff Allen added the comment: Just terminology ... strictly speaking what you've done here is "add a *field* to the nodes Module, FunctionDef and ClassDef", rather than add an *attribute* -- that is, when one is consistent with the terms used in the ast module

[issue29387] Tabs vs spaces FAQ out of date

Jim DeLaHunt added the comment: PR https://github.com/python/cpython/pull/41 to the new Github repo contains the following wording in Doc/faq/windows.rst: Python raises :exc:`IndentationError` or :exc:`TabError` if mixed tabs and spaces are causing problems in leading whitespace. You may also

[issue29521] Minor warning messages when compiling documentation

Jim DeLaHunt added the comment: I submitted a PR https://github.com/python/cpython/pull/41 to the new Github repo which finishes clearing the warnings in this bug report. I would appreciate review and committing. -- pull_requests: +43 ___ Python

[issue29521] Minor warning messages when compiling documentation

Jim DeLaHunt added the comment: It looks like commit e7ffb99f842ebff97cffa0fc90b18be4e5abecf2 to the new GitHub python/cpython repo, by Ryan Gonzalez, fixed the problems in Doc/conf.py, Doc/Makefile, and Misc/NEWS . It did not fix the problems in Doc/make.bat or Doc/faq/windows.rst . I'll

[issue28941] Update the link to Source Code in Python Docs from hg to github

Changes by Mariatta Wijaya : -- assignee: docs@python -> Mariatta ___ Python tracker ___

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

Changes by Mariatta Wijaya : -- pull_requests: +41 ___ Python tracker ___ ___

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

Changes by Mariatta Wijaya : -- pull_requests: +42 ___ Python tracker ___ ___

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

Changes by Mariatta Wijaya : -- pull_requests: +40 ___ Python tracker ___ ___

[issue29474] Grammatical errors in weakref.WeakValueDictionary docs

Changes by Mariatta Wijaya : -- pull_requests: +39 ___ Python tracker ___ ___

[issue28929] Provide a link from documentation back to its source file

Changes by Mariatta Wijaya : -- pull_requests: +38 ___ Python tracker ___ ___

[issue28929] Provide a link from documentation back to its source file

Changes by Mariatta Wijaya : -- pull_requests: +37 ___ Python tracker ___ ___

[issue28929] Provide a link from documentation back to its source file

Changes by Mariatta Wijaya : -- pull_requests: +36 ___ Python tracker ___ ___

[issue28929] Provide a link from documentation back to its source file

Changes by Mariatta Wijaya : -- pull_requests: +35 ___ Python tracker ___ ___

[issue28929] Provide a link from documentation back to its source file

Changes by Mariatta Wijaya : -- versions: +Python 2.7, Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___

[issue29026] time.time() documentation should mention UTC timezone

Eric Appelt added the comment: As we have moved to GitHub and mandatory reviews with Pull Requests, I have created a new patch in PR#34 which incorporates Victor's suggestions. -- ___ Python tracker

[issue29527] Travis: doc job is broken

Zachary Ware added the comment: PR16 made the Travis build situation better, but we still have some warnings to look into. I thought we had a PR for that, but I can't seem to find it. -- nosy: +zach.ware pull_requests: +34 ___ Python tracker

[issue28739] PEP 498: docstrings as f-strings

Joakim Soderlund added the comment: I got slightly confused here while playing around. Python 3.6.0 (default, Jan 31 2017, 11:39:39) [GCC 4.9.2] on linux Type "help", "copyright", "credits" or "license" for more information. >>> class Huacaya: ... f"""Huacaya!""" ... >>> class Suri: ...

[issue29529] Backport Travis configuration

Brett Cannon added the comment: https://github.com/python/core-workflow/issues/19 should be decided upon before backporting anything. -- nosy: +inada.naoki ___ Python tracker

[issue29536] test_hashlib failure on Ubuntu 16.04

New submission from Sachin Kumar: When executing ./python -m test -v test_hashlib on Python 3.7, the test fails. This is the complete traceback: CPython 3.7.0a0 (default, Feb 8 2017, 03:10:42) [GCC 5.4.0 20160609] == Linux-4.4.0-62-generic-x86_64-with-debian-stretch-sid little-endian ==

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

Steve Dower added the comment: > Does Git support per-file settings like the svn:eol-style property in > Subversion or .hgeol in Mercurial? The .gitattributes file seems to be full of glob patterns, so I assume a full file path will work. However, that doesn't help with tarballs. Fixing the

[issue29514] Add a test case that prevents magic number changes in minor releases

Serhiy Storchaka added the comment: Now I think that it would be safer to omit the function name in error message rather than fixing the compilation and bumping the magic number. Nick, if you want I could write a patch that fixes the possible security issue for .pyc files with old magic

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

Serhiy Storchaka added the comment: Does Git support per-file settings like the svn:eol-style property in Subversion or .hgeol in Mercurial? -- nosy: +serhiy.storchaka ___ Python tracker

[issue29514] Add a test case that prevents magic number changes in minor releases

Serhiy Storchaka added the comment: Could anyone please explain to me the comment from _bootstrap_external.py? # Starting with the adoption of PEP 3147 in Python 3.2, every bump in magic # number also includes a new "magic tag", i.e. a human readable string used # to represent the magic number

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

R. David Murray added the comment: Some of the tests (notably email tests) are *testing* platform line endings. In tests that I rewrote I did my best to make the tests independent of the line endings of checked in files (that is, constructing the files-to-test in the test itself instead of

[issue29463] Add `docstring` attribute to AST nodes

Serhiy Storchaka added the comment: Therefore we loss the possibility to set a breakpoint on the docstring? It doesn't look a great lost. -- ___ Python tracker

[issue29514] Add a test case that prevents magic number changes in minor releases

Brett Cannon added the comment: OK, so it sounds like Serhiy had good reason to do what he did. If we do add a test then I would argue that the message should be very clear that the magic number can change in a bugfix release but that it should be discussed with python-dev first so that

[issue29339] Interactive: Move to same indentation level as previousline

12345 67890 added the comment: I guess the workflow has been fixed so that I can submit a PR! I wasn't expecting this so soon, but I will get around to this as soon as I have time. -- ___ Python tracker

[issue29527] Travis: doc job is broken

Brett Cannon added the comment: It really depends on why the warnings are there. If it's a configuration issue with how Misc/NEWS is being built then that can be fixed to deal with a lot of warnings upfront. Otherwise we can also strip out the references from Misc/NEWS to deal with the

[issue29324] test_aead_aes_gcm fails on Kernel 4.9

Christian Heimes added the comment: Thx Barry, I'll try to find some time to verify the new Kernel API and commit the patch early next week. -- ___ Python tracker

[issue29534] _decimal difference with _pydecimal

Armin Rigo added the comment: Sorry! It should be repr(a) inside the print. Here is the fixed version: class X(Decimal): def __init__(self, a): print('__init__:', repr(a)) X.from_float(42.5) # __init__: Decimal('42.5') X.from_float(42) # with _pydecimal:

[issue22807] uuid.uuid1() should use uuid_generate_time_safe() if available

Changes by Barry A. Warsaw : -- versions: +Python 3.3, Python 3.6, Python 3.7 ___ Python tracker ___

[issue29324] test_aead_aes_gcm fails on Kernel 4.9

Barry A. Warsaw added the comment: Confirmed that test_socket_aead_kernel49.patch fixes the problem for Ubuntu 17.04. It'll probably fix it for Debian Stretch too give its kernel version number, but I haven't tested that yet. -- ___ Python tracker

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

Steve Dower added the comment: My vote would be to make the tests not presume anything about line endings, to the point of converting test files on the fly to be sure. I'm mostly free today (in a different city with nothing to do), so if my hotel internet will let me SSH to github then I can

[issue29531] Update Doc/README.txt to README.rst

Changes by Roger Sachan : -- pull_requests: -29 ___ Python tracker ___ ___

[issue29324] test_aead_aes_gcm fails on Kernel 4.9

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list

[issue29534] _decimal difference with _pydecimal

Stefan Krah added the comment: I get the the same output, perhaps I misunderstand something here: >>> from _decimal import * >>> class X(Decimal): ... def __init__(self, a): ... print('__init__:', a) ... >>> X.from_float(42.5) __init__: 42.5 Decimal('42.5') >>>

[issue29514] Add a test case that prevents magic number changes in minor releases

Serhiy Storchaka added the comment: My apologies for breaking the world. But I considered this bug as security issue. Unlikely, but not impossible. The BUILD_MAP_UNPACK_WITH_CALL opcode is rarely used, but if it is used, it can cause reading arbitrary memory and either crashing or even

[issue29535] datetime hash is deterministic in some cases

Changes by Serhiy Storchaka : -- nosy: +belopolsky versions: +Python 3.6 ___ Python tracker ___

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

Zachary Ware added the comment: We really need to be able to function regardless of the core.autocrlf setting. See #27425 for more about the EOL issues. -- dependencies: +Tests fail because of git's newline preferences on Windows ___ Python tracker

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

Changes by Zachary Ware : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware priority: normal -> critical versions: +Python 2.7, Python 3.5, Python 3.6 ___ Python tracker

[issue29535] datetime hash is deterministic in some cases

Christian Heimes added the comment: I only checked Python 2.7. For Python 3.x it's a bit more complicated: timedelta: PyObject_Hash(), always the same hash value date: _Py_HashBytes(), always a randomized hash value time: _Py_HashBytes() for offset = None, PyObject_Hash() for offset != 0

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

Jeremy Kloth added the comment: Tests are now failing due to end-of-line (?) differences. I did a quick reading of the devguide, but didn't see any mention of the settings to be used for Git on Windows wrt core.autocrlf. -- ___ Python tracker

[issue29535] datetime hash is deterministic in some cases

Armin Rigo added the comment: That's not what the docs say. E.g.: https://docs.python.org/3/reference/datamodel.html#object.__hash__ says By default, the __hash__() values of str, bytes and datetime objects are “salted” with an unpredictable random value. Although they remain constant

[issue2292] Missing *-unpacking generalizations

Serhiy Storchaka added the comment: Issue26213 was opened for documenting bytecode changes. But 21 months and 3 releases after the code patch the documentation is still not updated. -- nosy: +larry, serhiy.storchaka ___ Python tracker

[issue26213] Document BUILD_*_UNPACK opcodes

Serhiy Storchaka added the comment: At the same time the semantic of the BUILD_MAP opcode was changed. However the documentation was not updated and currently it doesn't match the implementation. This caused an issue in third-party projects that operate with bytecode. See also issue28810 for

[issue402227] make BUILD_MAP use it's argument

Serhiy Storchaka added the comment: After all this change was implemented as a part of PEP 448 implementation (issue2292). But it was not documented and current documentation of the BUILD_MAP opcode doesn't match the implementation. See also issue26213. -- nosy: +serhiy.storchaka

[issue29530] Windows buildbots broken by the migration to GitHub (meta issue)

Jeremy Kloth added the comment: After ensuring that Git is available to the buildbot service, the initial update fails due to the existing build directory containing the Mercurial checkout. After manually removing the contents of the build directories, the update task successfully completes.

[issue29535] datetime hash is deterministic in some cases

Christian Heimes added the comment: Only the hash of str and bytes are randomized/ The types date, datetime and time are not subject to hash randomization. Same for int, float, bool and None. -- nosy: +christian.heimes ___ Python tracker

[issue29535] datetime hash is deterministic in some cases

New submission from Armin Rigo: The documentation on the hash randomization says that date, time and datetime have a hash based on strings, that is therefore nondeterministic in several runs of Python. I may either be missing a caveat, or the actual implementation does not follow its promise

[issue29534] _decimal difference with _pydecimal

Changes by Stefan Krah : -- nosy: +mark.dickinson, rhettinger, skrah ___ Python tracker ___

[issue29534] _decimal difference with _pydecimal

New submission from Armin Rigo: A difference in behavior between _decimal and _pydecimal (it seems that _decimal is more consistent in this case): class X(Decimal): def __init__(self, a): print('__init__:', a) X.from_float(42.5) # __init__: Decimal('42.5')

[issue29514] Add a test case that prevents magic number changes in minor releases

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue29514] Add a test case that prevents magic number changes in minor releases

Nick Coghlan added the comment: Providing some additional background: - 3.5.3 was the *first time ever* in more than two decades that CPython changed the magic number in a maintenance release. It *wasn't* necessary to do so - it could have been left alone (as 3.5.0, 3.5.1, and 3.5.2 can read

[issue29532] functools.partial is not compatible between 2.7 and 3.5

Serhiy Storchaka added the comment: Yes, this can be considered a bug. Following patch fixes it. -- components: +Library (Lib) keywords: +patch nosy: +serhiy.storchaka stage: -> patch review versions: +Python 3.7 -Python 3.4 Added file:

[issue19675] Pool dies with excessive workers, but does not cleanup

Changes by Camilla Montonen : -- nosy: +Winterflower ___ Python tracker ___ ___

[issue29533] urllib2 works slowly with proxy on windows

Changes by Julia Dolgova : -- keywords: +patch Added file: http://bugs.python.org/file46632/socket.patch ___ Python tracker ___

[issue29533] urllib2 works slowly with proxy on windows

Changes by Julia Dolgova : Added file: http://bugs.python.org/file46630/test.py ___ Python tracker ___

[issue29533] urllib2 works slowly with proxy on windows

Changes by Julia Dolgova : Added file: http://bugs.python.org/file46631/log.txt ___ Python tracker ___

[issue29533] urllib2 works slowly with proxy on windows

Changes by Julia Dolgova : Added file: http://bugs.python.org/file46629/socket.py ___ Python tracker ___

[issue29533] urllib2 works slowly with proxy on windows

New submission from Julia Dolgova: I've found that urllib works sometimes slowly on windows with proxy. To reproduce the issue: on Windows: 1. Turn on the option "use proxy" in "browser settings" in "control panel". No real proxy needed. The problem will come out before addressing to proxy.

[issue28837] 2to3 does not wrap zip correctly

Stuart Berg added the comment: Patch submitted as github PR #24: https://github.com/python/cpython/pull/24 -- ___ Python tracker ___

[issue29532] functools.partial is not compatible between 2.7 and 3.5

Steven D'Aprano added the comment: Confirmed that in Python 2.7 calling g() before and after modifying the dict prints 3 both times; calling g() before modifying the dict prints 3, then after modifying it prints 5. Python 3.3 behaves like 2.7, so this sounds like a regression in 3.5 or maybe