[issue30378] SysLogHandler does not support IPv6 destinations

2017-05-16 Thread Calvin Cheng
New submission from Calvin Cheng: The attached test script works fine with IPv4 syslog: $ python test_syslog.py 192.168.1.4 (no errors reported) When running the attached script with python 3.5.2 on Ubuntu 16.04, received the following error: $ python3 test_syslog.py ::1 --- Logging error ---

[issue30379] multiprocessing Array create for ctypes.c_char, TypeError unless 1 char string arg used

2017-05-16 Thread Davin Potts
Davin Potts added the comment: Maybe I missed your point but why would you not want to do this instead? >>> mp.Array(ctypes.c_int8, arr) > -- nosy: +davin ___ Python tracker

[issue30377] Unnecessary complexity in tokenize.py around handling of comments and newlines

2017-05-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka stage: -> patch review ___ Python tracker ___

[issue30377] Unnecessary complexity in tokenize.py around handling of comments and newlines

2017-05-16 Thread Roundup Robot
Changes by Roundup Robot : -- pull_requests: +1697 ___ Python tracker ___

[issue30375] Correct stacklevel of warnings when compile regular expressions

2017-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 73fb45df0487144765808c5d25914c67232d83fe by Serhiy Storchaka in branch '3.6': [3.6] bpo-30375: Correct the stacklevel of regex compiling warnings. (GH-1595) (#1604)

[issue30375] Correct stacklevel of warnings when compile regular expressions

2017-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 24b5ed230df65f6a1f9d8dd0c4409377576113d9 by Serhiy Storchaka in branch '3.5': [3.5] bpo-30375: Correct the stacklevel of regex compiling warnings. (GH-1595) (#1605)

[issue30353] ctypes: pass by value for structs broken on Cygwin/MinGW 64-bit

2017-05-16 Thread Iryna Shcherbina
Iryna Shcherbina added the comment: I have added `defined(__aarch64__)` check to the if statement and tested the patch on arm64. The test passed. So could you please also add the check for `defined(__aarch64__)` to the pull request so that it fixes #29804 as well? --

[issue30195] writing non-ascii characters in xml file using python code embedded in C

2017-05-16 Thread mahboubi
mahboubi added the comment: problem solved, It's not related to embedding python in C, Ijust had to use mystring.decode('utf-8') instead of unicode(mystring,"utf-8") -- stage: test needed -> resolved status: open -> closed ___ Python tracker

[issue30379] multiprocessing Array create for ctypes.c_char, TypeError unless 1 char string arg used

2017-05-16 Thread Davin Potts
Davin Potts added the comment: Perhaps I should've used ctypes.c_uint8 in that example/question instead. -- ___ Python tracker ___

[issue30195] writing non-ascii characters in xml file using python code embedded in C

2017-05-16 Thread Xiang Zhang
Changes by Xiang Zhang : -- resolution: -> not a bug ___ Python tracker ___ ___

[issue25324] Importing tokenize modifies token

2017-05-16 Thread Albert-Jan Nijburg
Changes by Albert-Jan Nijburg : -- pull_requests: +1699 ___ Python tracker ___ ___

[issue30377] Unnecessary complexity in tokenize.py around handling of comments and newlines

2017-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The code is correct, it just can be made cleaner. No need to backport the change to other versions. The line "if line[pos] in '#\r\n':" looks a kind of optimization. In common case (not a newline and not a comment) there is only one check. The expression

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

2017-05-16 Thread Berker Peksag
Changes by Berker Peksag : -- pull_requests: +1700 ___ Python tracker ___ ___

[issue19417] Bdb: add a unittest file (test.test_bdb)

2017-05-16 Thread Cheryl Sabella
Cheryl Sabella added the comment: Wondering if it might make sense to use Mock in this patch? -- ___ Python tracker ___

[issue30038] Race condition in how trip_signal writes to wakeup fd

2017-05-16 Thread Nathaniel Smith
Nathaniel Smith added the comment: > While I suggest you to *not* use an event loop (wakeup fd pipe/socket handle > with select) and signal.signal(), you are true that there is a race condition > if you use select() with signal.signal() so I merged your change. Unfortunately this is the only

[issue30301] multiprocessing: AttributeError: 'SimpleQueue' object has no attribute '_poll'

2017-05-16 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for your reply Serhiy. Test added. :-) -- ___ Python tracker ___ ___

[issue30283] [2.7] Backport test_regrtest (partially) on Python 2.7

2017-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could you add a Misc/NEWS entry about backported regrtest features? -- ___ Python tracker ___

[issue30384] traceback.TracebackException.format shouldn't format_exc_only() when __traceback__ is None

2017-05-16 Thread Aaron Meurer
New submission from Aaron Meurer: I'm trying to completely hide an exception from the traceback module. From reading the source, it looks like the only way to do this is to set __traceback__ to None (I can also set __suppress_context__ to True, but that only works if I have another exception

[issue30378] SysLogHandler does not support IPv6 destinations

2017-05-16 Thread Calvin Cheng
Changes by Calvin Cheng : -- nosy: +calcheng -Calvin Cheng ___ Python tracker ___

[issue30377] Unnecessary complexity in tokenize.py around handling of comments and newlines

2017-05-16 Thread Albert-Jan Nijburg
Albert-Jan Nijburg added the comment: Oh yes you're right! I've updated the code on github. Even cleaner this way :). -- ___ Python tracker ___

[issue30372] Status of __builtins__ is not totally clear

2017-05-16 Thread Brett Cannon
Brett Cannon added the comment: You're correct that both are CPython implementation details and could be more clearly marked as such. (In case anyone is curious, the code to look up __import__() can be found at

[issue30301] multiprocessing: AttributeError: 'SimpleQueue' object has no attribute '_poll'

2017-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. But can you convert the reproducer to a test? -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue30378] SysLogHandler does not support IPv6 destinations

2017-05-16 Thread Calvin Cheng
Changes by Calvin Cheng : -- nosy: +Calvin Cheng -calcheng ___ Python tracker ___

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Brett Cannon
Brett Cannon added the comment: Technically it's probably best to do `python3 -m pip install sphinx~=1.5.6` so bugfix releases are picked up. -- ___ Python tracker

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1702 ___ Python tracker ___ ___

[issue23667] IDLE to provide option for making trailing whitespace visible

2017-05-16 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- stage: needs patch -> patch review versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PR 1613 tries to fix a warning by using explicit footnote numbering. -- nosy: +serhiy.storchaka ___ Python tracker

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Brett Cannon
New submission from Brett Cannon: The Travis file uses `make venv` which does `python3 -m pip install --upgrade sphinx` which is pulling in Sphinx 1.6.1 which was released today (under Python 2.7 the pip call is direct instead of using `make venv`). The problem is that Sphinx 1.6.1 adds some

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- pull_requests: +1701 ___ Python tracker ___ ___

[issue18233] SSLSocket.getpeercertchain()

2017-05-16 Thread joernheissler
joernheissler added the comment: Hi, I'd like to see this feature too. My use case is a monitoring script to check the life time of the server certificate, including the chain. I would prefer to have a wrapper around SSL_get_peer_cert_chain. I understand that this is *not* a verified chain.

[issue30211] Bdb: add docstrings

2017-05-16 Thread Cheryl Sabella
Cheryl Sabella added the comment: Thank you. I had some questions that I put on the commit. You're right about it saying it must be in canonic form and then it calls canonic. I figured someone added the call later to prevent an error, but didn't change the warning, but I didn't know if I

[issue30379] multiprocessing Array create for ctypes.c_char, TypeError unless 1 char string arg used

2017-05-16 Thread John Schaefer
New submission from John Schaefer: When creating a multiprocessing Array equivalent for unsigned chars, eg from a numpy.uint8 array, the first argument: typecode_or_type must be specified as a one character string, if a typecode is used the method raises a TypeError. >>> import numpy as np,

[issue30211] Bdb: add docstrings

2017-05-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 0774e79b93cc494b3a957d538c7c112e289973c0 by terryjreedy (csabella) in branch 'master': bpo-30211: bdb: add docstrings (#1350) https://github.com/python/cpython/commit/0774e79b93cc494b3a957d538c7c112e289973c0 --

[issue30371] test_long_lines() fails randomly on AMD64 Windows7 SP1 3.x

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: > Watch this space, but I'm pretty sure that it is (was) bad memory. It's really strange that only one very specific Python test fails if it's a bad memory issue? -- ___ Python tracker

[issue30329] poplib and imaplib should catch "OSError: [WinError 10022] An invalid argument was supplied" on shutdown

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset aaa053652556aa4e59cb68f3983a09ced1d1fe2a by Victor Stinner in branch '3.6': bpo-30329: Catch Windows error 10022 on shutdown() (#1538) (#1620) https://github.com/python/cpython/commit/aaa053652556aa4e59cb68f3983a09ced1d1fe2a --

[issue30371] test_long_lines() fails randomly on AMD64 Windows7 SP1 3.x

2017-05-16 Thread Jeremy Kloth
Jeremy Kloth added the comment: My thinking is that in normal running, the in-use memory is below the bad bit. It is due to that test using such a large chunk of memory that it pushes the data into the bad area. I would wager that if largemem tests were run, the would error as well.

[issue29137] Fix fpectl-induced ABI breakage

2017-05-16 Thread Dima Pasechnik
Dima Pasechnik added the comment: @njs: Fixing this entails switching over from ieeefp to fenv, right? Looks doable, although not trivial. It might potentially be useful for various numerics, IMHO. -- ___ Python tracker

[issue30371] test_long_lines() fails randomly on AMD64 Windows7 SP1 3.x

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: If you are sure that your memory has issues, don't test it, just change it. I had memory issues once but memtest86 was quick to prove memory errors in my case. I changed the memory for free since it was still under the warranty. --

[issue30329] poplib and imaplib should catch "OSError: [WinError 10022] An invalid argument was supplied" on shutdown

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset c9ba45d1b71d86321e5422e8a2cbe6e52aaba6f4 by Victor Stinner in branch '3.5': bpo-30329: Catch Windows error 10022 on shutdown() (#1538) (#1621) https://github.com/python/cpython/commit/c9ba45d1b71d86321e5422e8a2cbe6e52aaba6f4 --

[issue30374] Make win_add2path.py take effect without having to log off

2017-05-16 Thread neeverett
neeverett added the comment: I think the original author adds the relative path "%APPDATA%..." with the intention to keep it effective even when the set path of APPDATA changes. However that compulsively changes the type of PATH var to REG_EXPAND_SZ. It is reasonable that the type of PATH var

[issue30211] Bdb: add docstrings

2017-05-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: The bdb class or __init__ docstring needs to document the data members with a short explanation. Some of the args need better explanation. Some of this I may fill in *after* reviewing the proposed tests, when I understand the code better. Reviewing pdb and

[issue30375] Correct stacklevel of warnings when compile regular expressions

2017-05-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1695 ___ Python tracker ___ ___

[issue30375] Correct stacklevel of warnings when compile regular expressions

2017-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset c7ac7280c321b3c1679fe5f657a6be0f86adf173 by Serhiy Storchaka in branch 'master': bpo-30375: Correct the stacklevel of regex compiling warnings. (#1595) https://github.com/python/cpython/commit/c7ac7280c321b3c1679fe5f657a6be0f86adf173

[issue23667] IDLE to provide option for making trailing whitespace visible

2017-05-16 Thread Louie Lu
Changes by Louie Lu : -- pull_requests: +1693 ___ Python tracker ___ ___ Python-bugs-list

[issue23667] IDLE to provide option for making trailing whitespace visible

2017-05-16 Thread Louie Lu
Changes by Louie Lu : -- pull_requests: +1694 ___ Python tracker ___ ___ Python-bugs-list

[issue23667] IDLE to provide option for making trailing whitespace visible

2017-05-16 Thread Louie Lu
Louie Lu added the comment: PR 1602 add trailing whitespace highlight, which using color from error. PR 1603 add TrimExtension to provide auto trim while saving the file. -- nosy: +louielu ___ Python tracker

[issue30323] concurrent.futures.Executor.map() consumes all memory when big generators are used

2017-05-16 Thread Klamann
Klamann added the comment: Thanks for pointing this out. *closed* -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker

[issue29842] Make Executor.map work with infinite/large inputs correctly

2017-05-16 Thread Klamann
Changes by Klamann : -- nosy: +Klamann ___ Python tracker ___ ___ Python-bugs-list

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

2017-05-16 Thread Berker Peksag
Changes by Berker Peksag : -- stage: test needed -> backport needed ___ Python tracker ___

[issue30323] concurrent.futures.Executor.map() consumes all memory when big generators are used

2017-05-16 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Library (Lib) superseder: -> Make Executor.map work with infinite/large inputs correctly ___ Python tracker

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

2017-05-16 Thread Berker Peksag
Berker Peksag added the comment: New changeset 87fa8a780e9045a26c735f085c07bba4b2d0be60 by Berker Peksag in branch 'master': bpo-29898: Fix incorrect env variable name (GH-1576) https://github.com/python/cpython/commit/87fa8a780e9045a26c735f085c07bba4b2d0be60 -- nosy: +berker.peksag

[issue30301] multiprocessing: AttributeError: 'SimpleQueue' object has no attribute '_poll'

2017-05-16 Thread Xiang Zhang
Xiang Zhang added the comment: Related commit is bdb1cf1ca56db25b33fb15dd91eef2cc32cd8973. A simple reproduce snippet: import multiprocessing as mp def foo(q): q.put('hello') assert not q.empty() if __name__ == '__main__': mp.set_start_method('spawn') q = mp.SimpleQueue()

[issue30301] multiprocessing: AttributeError: 'SimpleQueue' object has no attribute '_poll'

2017-05-16 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +1692 ___ Python tracker ___ ___

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset d97b7dc94b19063f0589d401bdc4aaadc7030762 by Serhiy Storchaka in branch 'master': bpo-30380: Fix Sphinx 1.6.1 warnings. (#1613) https://github.com/python/cpython/commit/d97b7dc94b19063f0589d401bdc4aaadc7030762 --

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1703 ___ Python tracker ___ ___

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1704 ___ Python tracker ___ ___

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1705 ___ Python tracker ___ ___

[issue24960] Can't use lib2to3 with embeddable zip file.

2017-05-16 Thread Kirk Sayre
Kirk Sayre added the comment: I've been fighting with this issue today trying to import networkx in the embedded Python shipped with IDA-Pro. I have implemented a local fix to pgen.py that allows networkx to import and be used in IDAPython scripts. I added a check to see if a .zip archive

[issue30375] Correct stacklevel of warnings when compile regular expressions

2017-05-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1696 ___ Python tracker ___ ___

[issue30375] Correct stacklevel of warnings when compile regular expressions

2017-05-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- versions: +Python 2.7 ___ Python tracker ___

[issue29710] Incorrect representation caveat on bitwise operation docs

2017-05-16 Thread Nick Coghlan
Nick Coghlan added the comment: I think the simplest fix to make the docs "not wrong" would be to just delete the part in parentheses. Beyond that, I'm not quite sure how to concisely describe the actual behaviour, but I think the mention of "2's complement" isn't especially helpful in its

[issue30377] Unnecessary complexity in tokenize.py around handling of comments and newlines

2017-05-16 Thread Albert-Jan Nijburg
New submission from Albert-Jan Nijburg: While porting tokenize.py to javascript I stumbled upon this. The bit of code that checks if it's a newline or a comment, checks for comment twice. These can be split up, this way the code is a bit more readable.

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

2017-05-16 Thread Pranav Deshpande
Pranav Deshpande added the comment: Hello, I would like to work on this issue. Could you guide me on so as how to proceed with this? -- nosy: +Pranav Deshpande ___ Python tracker

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Brett Cannon
Brett Cannon added the comment: New changeset 77606957e71ce477d2c5569718f0fc36f05c6f59 by Brett Cannon in branch '3.5': bpo-30380: Pin the version of Sphinx used to build the documentation (GH-1612) (GH-1618) https://github.com/python/cpython/commit/77606957e71ce477d2c5569718f0fc36f05c6f59

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Brett Cannon
Brett Cannon added the comment: New changeset 97eb2a7d77011605e8fc49e754cd371ead4366bc by Brett Cannon in branch '2.7': [2.7] bpo-30380: Pin the version of Sphinx used to build the docs (GH-1612) (GH-1619) https://github.com/python/cpython/commit/97eb2a7d77011605e8fc49e754cd371ead4366bc

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Brett Cannon
Brett Cannon added the comment: All branches should be green again. Serhiy has a PR out to fix 2.7 for Sphinx 1.6.1, but it isn't passing yet so that branch is pinned to 1.5.6 until then. I will leave this issue open for Serhiy to close once his 2.7 PR is merged. --

[issue29137] Fix fpectl-induced ABI breakage

2017-05-16 Thread Dima Pasechnik
Dima Pasechnik added the comment: While fpectl might be a bit rusty, this is a priceless tool in debugging situations, where one needs to identify components that do something wrong to FPU, see e.g. https://github.com/numpy/numpy/issues/9007 and the related

[issue30181] Correct the parsing of a test case docstring.

2017-05-16 Thread R. David Murray
R. David Murray added the comment: It's not the PSF, it's the dev team, and it is "just" a matter of tooling. Which means help improving the tooling is welcome :) -- ___ Python tracker

[issue30371] test_long_lines() fails randomly on AMD64 Windows7 SP1 3.x

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: New fail, same buildbot: == FAIL: test_long_lines (test.test_email.test_email.TestFeedParsers) -- Traceback (most recent call

[issue30329] test_imaplib.test_login_cram_md5(): OSError: [WinError 10022] An invalid argument was supplied on AMD64 Windows8.1 Non-Debug 3.6

2017-05-16 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1709 ___ Python tracker ___ ___

[issue30329] poplib and imaplib should catch "OSError: [WinError 10022] An invalid argument was supplied" on shutdown

2017-05-16 Thread STINNER Victor
Changes by STINNER Victor : -- components: +Library (Lib) title: test_imaplib.test_login_cram_md5(): OSError: [WinError 10022] An invalid argument was supplied on AMD64 Windows8.1 Non-Debug 3.6 -> poplib and imaplib should catch "OSError: [WinError 10022] An

[issue30329] test_imaplib.test_login_cram_md5(): OSError: [WinError 10022] An invalid argument was supplied on AMD64 Windows8.1 Non-Debug 3.6

2017-05-16 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1710 ___ Python tracker ___ ___

[issue29137] Fix fpectl-induced ABI breakage

2017-05-16 Thread Nathaniel Smith
Nathaniel Smith added the comment: @Dima: are you volunteering to fix and maintain it? I can see why it's useful to have some way to get at the fpu flags, but I don't see how fpectl specifically helps with that issue, and fpectl has always been broken on x86-64. --

[issue30339] test_multiprocessing_main_handling: "RuntimeError: Timed out waiting for results" on x86 Windows7 3.x

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: > New changeset 7d6320ba47a229543acc0af6a64bc4e414932273 by Victor Stinner in > branch 'master': > bpo-30339: test_multiprocessing_main_handling timeout (#1593) > https://github.com/python/cpython/commit/7d6320ba47a229543acc0af6a64bc4e414932273 Sadly, a new

[issue30381] test_smtpnet.test_connect_using_sslcontext_verified() randomly failed with "smtplib.SMTPServerDisconnected: Connection unexpectedly closed" on AMD64 FreeBSD CURRENT Debug 3.x

2017-05-16 Thread STINNER Victor
New submission from STINNER Victor: See also bpo-30331 (test_poplib) and bpo-30328 (test_ssl): other connection reset on the FreeBSD buildbots. http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Debug%203.x/builds/272/steps/test/logs/stdio 0:15:55 load avg: 1.77 [387/405/1]

[issue30371] test_long_lines() fails randomly on AMD64 Windows7 SP1 3.x

2017-05-16 Thread Jeremy Kloth
Jeremy Kloth added the comment: Watch this space, but I'm pretty sure that it is (was) bad memory. It passes memtest86+ but I had issues with these kits in other machines. I swapped out the stick I believe that had the stuck bit. Unfortunately, it is a wait and see solution, as they do

[issue30333] test_multiprocessing_forkserver: poll() failed on AMD64 FreeBSD CURRENT Non-Debug 3.5

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: Other test_multiprocessing_forkserver errors on AMD64 FreeBSD CURRENT Non-Debug 3.6. http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Non-Debug%203.6/builds/150/steps/test/logs/stdio (...) test_import

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b8b9f95f660d00ce9bd11bd9de429176858be3c5 by Serhiy Storchaka in branch '2.7': [2.7] bpo-30380: Fix Sphinx 1.6.1 warnings. (GH-1613) (#1616) https://github.com/python/cpython/commit/b8b9f95f660d00ce9bd11bd9de429176858be3c5 --

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: I don't really care if Jeremy installs Perl on the buildbot or if someone succeed to fix the dependency on the svn repository. I only care of seeing a green buildbot ;-) -- ___ Python tracker

[issue30211] Bdb: add docstrings

2017-05-16 Thread Terry J. Reedy
Terry J. Reedy added the comment: I plan to merge when I can. Possible future improvements for bdb.py. 1. Bdb attributes. 2. Say what user_xyz functions might do. Anything better than 'Intervene in debugging process.'? 3. Clarify what get_stack does. Improvement for bdb.rst (optional for

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Brett Cannon
Brett Cannon added the comment: New changeset fca224f117d25bdfec1bf7160b67438c4fcf6dee by Brett Cannon (Mariatta) in branch 'master': bpo-30380: Pin the version of Sphinx used to build the documentation (GH-1612) https://github.com/python/cpython/commit/fca224f117d25bdfec1bf7160b67438c4fcf6dee

[issue9850] obsolete macpath module dangerously broken and should be removed

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: Ok, I don't see any open task anymore, so I close this issue. The macpath may or may not be removed in Python 3.8, so not before 2018-01-29. IMHO it's ok to remove the module, macpath was used for MacOS 9, but all macOS users are now running macOS X.

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Brett Cannon
Changes by Brett Cannon : -- pull_requests: +1706 ___ Python tracker ___ ___

[issue25324] Importing tokenize modifies token

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: Extract of Lib/lib2to3/pgen2/driver.py: if type in (tokenize.COMMENT, tokenize.NL): ... if debug: self.logger.debug("%s %r (prefix=%r)", token.tok_name[type], value, prefix) The code uses tokenize.COMMENT and

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Brett Cannon
Changes by Brett Cannon : -- pull_requests: +1707 ___ Python tracker ___ ___

[issue25324] Importing tokenize modifies token

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: Another example from Tools/i18n/pygettext.py, TokenEater:: def __call__(self, ttype, tstring, stup, etup, line): # dispatch ##import token ##print >> sys.stderr, 'ttype:', token.tok_name[ttype], \ ## 'tstring:', tstring

[issue30038] Race condition in how trip_signal writes to wakeup fd

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 4ae01496971624c75080431806ed1c08e00f22c7 by Victor Stinner (Nathaniel J. Smith) in branch 'master': bpo-30038: fix race condition in signal delivery + wakeup fd (#1082)

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Brett Cannon
Changes by Brett Cannon : -- pull_requests: +1708 ___ Python tracker ___ ___

[issue30038] Race condition in how trip_signal writes to wakeup fd

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: While I suggest you to *not* use an event loop (wakeup fd pipe/socket handle with select) and signal.signal(), you are true that there is a race condition if you use select() with signal.signal() so I merged your change. Do you consider that it's worth it to

[issue25324] Importing tokenize modifies token

2017-05-16 Thread Albert-Jan Nijburg
Albert-Jan Nijburg added the comment: > I prefer to add tokenize tokens directly in Lib/token.py, and then get > COMMENT, NL and ENCODING using tok_name.index(). That would make more sense from a breaking change perspective, but we would step on the toes of anyone adding `COMMENT`, `NL`, or

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Brett Cannon
Brett Cannon added the comment: New changeset 083f13e34c0b9f9ed4ed64fed3989d4af97843b3 by Brett Cannon (Serhiy Storchaka) in branch '3.5': [3.5] bpo-30380: Fix Sphinx 1.6.1 warnings. (GH-1613) (GH-1615) https://github.com/python/cpython/commit/083f13e34c0b9f9ed4ed64fed3989d4af97843b3

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

2017-05-16 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker

[issue29898] PYTHONLEGACYWINDOWSIOENCODING isn't implemented

2017-05-16 Thread Berker Peksag
Berker Peksag added the comment: New changeset 0d267041c40a3ab655676b885c0ba35ed9685848 by Berker Peksag in branch '3.6': bpo-29898: Fix incorrect env variable name (GH-1576) https://github.com/python/cpython/commit/0d267041c40a3ab655676b885c0ba35ed9685848 --

[issue25324] Importing tokenize modifies token

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: > lib2to3 appears to have it's own token.py as well with NL and COMMENT > withtout ENCODING... Oh you are right: Lib/lib2to3/pgen2/driver.py uses Lib/lib2to3/pgen2/token.py. -- ___ Python tracker

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

2017-05-16 Thread Zachary Ware
Zachary Ware added the comment: The simple fix from my point of view is for Jeremy to install Perl :). But since he also mentioned having a patch ready in bpo-30350, I'd like to see it before declaring that installing Perl is what should be done. -- assignee: christian.heimes ->

[issue25324] Importing tokenize modifies token

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: > I would fix this by making tokenize.tok_name a copy. It looks like this > behaviour dates back to 1997 (see revision 1efc4273fdb7). token.tok_name is part of the Python public API: https://docs.python.org/dev/library/token.html#token.tok_name whereas

[issue30380] Sphinx 1.6.1 raising new warnings in docs build

2017-05-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 8fc1ff51adb52c80f6bf78393413c72543bae3e1 by Serhiy Storchaka in branch '3.6': [3.6] bpo-30380: Fix Sphinx 1.6.1 warnings. (GH-1613) (#1614) https://github.com/python/cpython/commit/8fc1ff51adb52c80f6bf78393413c72543bae3e1 --

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: I really hate script_helper API: keyword arguments are only used to pass environment variables, so the function uses hackish parameteres like __cleanenv=True... I would prefer to pass keywords unchanged to Popen() to be able to use universal_newlines=True

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

2017-05-16 Thread STINNER Victor
STINNER Victor added the comment: > Even if there turn out to be a few uses where having bytes is required, it > would probably be worth catering to the common case and making those > exceptional cases use Popen directly. (Or alternatively provide > assert_python_xxx_binary helpers.) I

[issue25324] Importing tokenize modifies token

2017-05-16 Thread Albert-Jan Nijburg
Albert-Jan Nijburg added the comment: lib2to3 appears to have it's own token.py as well with NL and COMMENT withtout ENCODING... Lib/lib2to3/pgen2/token.py -- ___ Python tracker

  1   2   >