[issue30584] test_os fails on non-English (Russian) Windows

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: New changeset a0b901b8fcfda864070335b249071508ee0c by Victor Stinner (Denis Osipov) in branch '3.5': [3.5] bpo-30584: Fix test_os fails on non-English Windows (GH-1980) (#2000) https://github.com/python/cpython/commit/a0b901b8fcfda864070335b249071508ee0

[issue30592] Bad error message 'bool()() takes no keyword arguments'

2017-06-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It would be possible to make _PyArg_NoKeywords() adding "()" only if the passed argument don't contain them. But since this is a private API, it was easier to just remove "()" from arguments. In any case most uses of _PyArg_NoKeywords() are generated by Argu

[issue30592] Bad error message 'bool()() takes no keyword arguments'

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: Would it be possible to add an assertion to _PyArg_NoKeywords() to prevent regressions? Fail if funcname contains "(" or ")". For example: /* funcname must not contain ( or ), since "()" suffix is added in the error message */ assert(!strchr(funcname, '(') &&

[issue30584] test_os fails on non-English (Russian) Windows

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: New changeset ca1b66fd059758bbd6e2cc62c8f2adecefe8f942 by Victor Stinner (Denis Osipov) in branch '3.6': [3.6] bpo-30584: Fix test_os fails on non-English Windows (GH-1980) (#1999) https://github.com/python/cpython/commit/ca1b66fd059758bbd6e2cc62c8f2adecefe8f94

[issue30529] Incorrect error messages for invalid whitespaces in f-string subexpressions

2017-06-08 Thread Eric V. Smith
Eric V. Smith added the comment: Sorry, I've been busy. I'll get to this soon, though. -- ___ Python tracker ___ ___ Python-bugs-list

[issue30599] test_threaded_import leaks references

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: The leak was introduced by the commit 346cbd351ee0dd3ab9cb9f0e4cb625556707877e. -- ___ Python tracker ___ __

[issue30592] Bad error message 'bool()() takes no keyword arguments'

2017-06-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If you know how to write tests for these cases a patch is welcome. But this may be not easy. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue30592] Bad error message 'bool()() takes no keyword arguments'

2017-06-08 Thread SylvainDe
SylvainDe added the comment: Hi serhiy.storchaka, this is fine by me! I've added a corresponding comment with questions/suggestions on the Github PR. Do you reckon I should open another ticket for the issue mentionned in my previous message ? I'm happy to take care of it :) -- __

[issue30486] Allow setting cell value

2017-06-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your contribution Lisa! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue30486] Allow setting cell value

2017-06-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 64505a1f6c0af4574e17e823b27ffe24eca44df5 by Serhiy Storchaka (Lisa Roach) in branch 'master': bpo-30486: Allow setting cell value (#1840) https://github.com/python/cpython/commit/64505a1f6c0af4574e17e823b27ffe24eca44df5 -- nosy: +serhi

[issue30534] error message for incorrect call degraded in 3.7

2017-06-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 6cca5c8459cc439cb050010ffa762a03859d3051 by Serhiy Storchaka in branch 'master': bpo-30592: Fixed error messages for some builtins. (#1996) https://github.com/python/cpython/commit/6cca5c8459cc439cb050010ffa762a03859d3051 -- _

[issue30592] Bad error message 'bool()() takes no keyword arguments'

2017-06-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 6cca5c8459cc439cb050010ffa762a03859d3051 by Serhiy Storchaka in branch 'master': bpo-30592: Fixed error messages for some builtins. (#1996) https://github.com/python/cpython/commit/6cca5c8459cc439cb050010ffa762a03859d3051 -- _

[issue30599] test_threaded_import leaks references

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: Even when the two latest refleak fixes (ab1cb80b435a34e4f908c97cd2f3a7fe8add6505 and 865de27dd79571a4a5c7a7d22a07fb909c4a9f8e), test_threaded_import still leaks. haypo@selma$ ./python -m test -R 3:3 -m test_side_effect_import test_threaded_import Run tests

[issue30584] test_os fails on non-English (Russian) Windows

2017-06-08 Thread Denis Osipov
Changes by Denis Osipov : -- versions: +Python 3.5, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30584] test_os fails on non-English (Russian) Windows

2017-06-08 Thread Denis Osipov
Denis Osipov added the comment: Tests on Windows buildbots passed. I've made PR for 3.5 and 3.6 backporting. -- ___ Python tracker ___ ___

[issue30597] Show expected input in custom "print" error message

2017-06-08 Thread Eric V. Smith
Eric V. Smith added the comment: You'll need to be careful about fully translating to python 3, though. What do you do with: print >> sys.stderr, "message" or: print "message", ? -- nosy: +eric.smith ___ Python tracker

[issue30584] test_os fails on non-English (Russian) Windows

2017-06-08 Thread Denis Osipov
Changes by Denis Osipov : -- pull_requests: +2067 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue30584] test_os fails on non-English (Russian) Windows

2017-06-08 Thread Denis Osipov
Changes by Denis Osipov : -- pull_requests: +2066 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue30598] Py_NewInterpreter() leaks a reference on warnoptions in _PySys_EndInit()

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: New changeset 865de27dd79571a4a5c7a7d22a07fb909c4a9f8e by Victor Stinner in branch 'master': bpo-30598: _PySys_EndInit() now duplicates warnoptions (#1998) https://github.com/python/cpython/commit/865de27dd79571a4a5c7a7d22a07fb909c4a9f8e -- _

[issue30594] Refcounting mistake in _ssl.c

2017-06-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 54ba41ecc5711f89841342c5f9dd555ee13404b5 by Serhiy Storchaka (Nathaniel J. Smith) in branch '3.5': [3.5] bpo-30594: Fixed refcounting in newPySSLSocket (GH-1992) (#1993) https://github.com/python/cpython/commit/54ba41ecc5711f89841342c5f9dd555ee1

[issue30594] Refcounting mistake in _ssl.c

2017-06-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 854f7ba1d5cbb6a42511beae66c8dbe34f2cbcd3 by Serhiy Storchaka (Nathaniel J. Smith) in branch '3.6': [3.6] bpo-30594: Fixed refcounting in newPySSLSocket (GH-1992) (#1994) https://github.com/python/cpython/commit/854f7ba1d5cbb6a42511beae66c8dbe34f

[issue30594] Refcounting mistake in _ssl.c

2017-06-08 Thread Nathaniel Smith
Changes by Nathaniel Smith : -- pull_requests: +2065 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue22257] PEP 432: Redesign the interpreter startup sequence

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: New changeset ab1cb80b435a34e4f908c97cd2f3a7fe8add6505 by Victor Stinner (Stéphane Wirtel) in branch 'master': bpo-30547: Fix multiple reference leaks (#1995) https://github.com/python/cpython/commit/ab1cb80b435a34e4f908c97cd2f3a7fe8add6505 -- nosy: +

[issue30547] [Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: New changeset ab1cb80b435a34e4f908c97cd2f3a7fe8add6505 by Victor Stinner (Stéphane Wirtel) in branch 'master': bpo-30547: Fix multiple reference leaks (#1995) https://github.com/python/cpython/commit/ab1cb80b435a34e4f908c97cd2f3a7fe8add6505 -- __

[issue30598] Py_NewInterpreter() leaks a reference on warnoptions in _PySys_EndInit()

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-30547 for other refleaks somehow related to that one. -- ___ Python tracker ___ ___ Pyt

[issue30598] Py_NewInterpreter() leaks a reference on warnoptions in _PySys_EndInit()

2017-06-08 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2064 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30598] Py_NewInterpreter() leaks a reference on warnoptions in _PySys_EndInit()

2017-06-08 Thread Nick Coghlan
Nick Coghlan added the comment: I'd suggest that the right fix here would be to move warnoptions into the config struct as proposed in the PEP: https://www.python.org/dev/peps/pep-0432/#supported-configuration-settings The main reason we merged this as a private API was so we could do that se

[issue30599] test_threaded_import leaks references

2017-06-08 Thread STINNER Victor
New submission from STINNER Victor: http://buildbot.python.org/all/builders/x86%20Gentoo%20Refleaks%203.x/builds/28/steps/test/logs/stdio 1:50:39 load avg: 3.66 [302/405/8] test_threaded_import failed -- running: test_tarfile (80 sec) beginning 6 repetitions 123456 .. test_threaded_import l

[issue30547] [Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: I created bpo-30598: Py_NewInterpreter() leaks a reference on warnoptions in _PySys_EndInit(). -- ___ Python tracker ___ __

[issue13691] pydoc help (or help('help')) should show the doc for help

2017-06-08 Thread Nick Coghlan
Nick Coghlan added the comment: Belatedly removing the "easy" tag, since that turned out to be thoroughly incorrect... -- keywords: -easy ___ Python tracker ___ ___

[issue30597] Show expected input in custom "print" error message

2017-06-08 Thread Sanyam Khurana
Sanyam Khurana added the comment: Hi Nick, Can I work on this issue? -- nosy: +CuriousLearner ___ Python tracker ___ ___ Python-bugs-

[issue30598] Py_NewInterpreter() leaks a reference on warnoptions in _PySys_EndInit()

2017-06-08 Thread STINNER Victor
New submission from STINNER Victor: Recently, the Python initialization was reworked to start to implement the PEP 432: - bpo-22257: commits 1abcf6700b4da6207fe859de40c6c1bada6b4fec and 6b4be195cd8868b76eb6fbe166acc39beee8ce36 Now, Py_NewInterpreter() leaks a reference on warnoptions in _PySy

[issue30536] [EASY] SubinterpThreadingTests.test_threads_join_2() of test_threading leaks references

2017-06-08 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- superseder: -> [Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references ___ Python tracker ___ __

[issue30592] Bad error message 'bool()() takes no keyword arguments'

2017-06-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Sorry, SylvainDe, but by the time you expose your desire to work on this issue, I already had written two alternate patches. I needed only a time for deciding what of them is the more appropriate solution. PR 1996 implements the first way. It removes explici

[issue30597] Show expected input in custom "print" error message

2017-06-08 Thread Nick Coghlan
New submission from Nick Coghlan: Back when we added the custom error message for missing parentheses in print calls, I also pre-seeded an explanation of the error on Stack Overflow: https://stackoverflow.com/questions/25445439/what-does-syntaxerror-missing-parentheses-in-call-to-print-mean-in-

[issue30534] error message for incorrect call degraded in 3.7

2017-06-08 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +2063 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30592] Bad error message 'bool()() takes no keyword arguments'

2017-06-08 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +2062 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30596] Add close() to multiprocessing.Process

2017-06-08 Thread Antoine Pitrou
New submission from Antoine Pitrou: multiprocessing.Process (actually, the _popen object attached to it) has a GC-based finalizer to release system resources (such as fds). However, it would be nice to be able to release those resources in a timely manner. Adding a close() method would let u

[issue30547] [Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: Sorry, that issue wasn't [EASY] at all! But I tried to help Stéphane & Louie as much as I could ;-) -- keywords: -easy (C) title: [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references -> [Windows] SubinterpreterTest.

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: bpo-30536 has been marked as a duplicate of this issue: [EASY] SubinterpThreadingTests.test_threads_join_2() of test_threading leaks references. -- ___ Python tracker ___

[issue30536] [EASY] SubinterpThreadingTests.test_threads_join_2() of test_threading leaks references

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: This issue is a duplicate of bpo-30547. I tested that bpo-30547 fixes this issue. -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker __

[issue22257] PEP 432: Redesign the interpreter startup sequence

2017-06-08 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : -- pull_requests: +2061 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue18520] Fixes bugs found by pyfailmalloc during Python initialization

2017-06-08 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : -- pull_requests: +2060 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: -SET_SYS_FROM_STRING_BORROW_INT_RESULT("warnoptions", warnoptions); Oh, it seems like the regression was introduced by me in the commit 8fea252a507024edf00d5d98881d22dc8799a8d3, see: http://bugs.python.org/issue18520#msg201472 Or maybe it comes from recen

[issue28414] SSL match_hostname fails for internationalized domain names

2017-06-08 Thread Christian Heimes
Christian Heimes added the comment: I have an idea for a different approach that can be applied to both ssl and socket module. Stay tuned to this station for a PEP broadcast! -- ___ Python tracker

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

2017-06-08 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: I have pushed a PR, if you can check it. Thanks -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue30592] Bad error message 'bool()() takes no keyword arguments'

2017-06-08 Thread SylvainDe
SylvainDe added the comment: As I was trying to test coverage for a few places where the same error was built, I have discovered another issue where the error message is very misleading: AssertionError: "^index\(\) takes no keyword arguments$" does not match "index() takes at least 1 argumen

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

2017-06-08 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : -- pull_requests: +2059 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue30594] Refcounting mistake in _ssl.c

2017-06-08 Thread Nathaniel Smith
Nathaniel Smith added the comment: posted backports for 3.5 and 3.6. It looks like 2.7 is actually unaffected, because it doesn't have IDNA support, so there's no failure path in between when the reference is stored and when its INCREFed. -- versions: -Python 2.7

[issue30594] Refcounting mistake in _ssl.c

2017-06-08 Thread Nathaniel Smith
Changes by Nathaniel Smith : -- pull_requests: +2057 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue30594] Refcounting mistake in _ssl.c

2017-06-08 Thread Nathaniel Smith
Changes by Nathaniel Smith : -- pull_requests: +2058 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: Oh, 1abcf6700b4da6207fe859de40c6c1bada6b4fec introduced two more reference leaks. -- ___ Python tracker ___ ___

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

2017-06-08 Thread STINNER Victor
STINNER Victor added the comment: SubinterpreterTest.test_subinterps of test_capi also leaks. But it is likely the same bug than this issue (SubinterpreterTest.test_callbacks_leak() of test_atexit leaks). -- ___ Python tracker

[issue17305] IDNA2008 encoding missing

2017-06-08 Thread Nathaniel Smith
Changes by Nathaniel Smith : -- nosy: +njs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

2017-06-08 Thread STINNER Victor
New submission from STINNER Victor: http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/712/steps/test/logs/stdio == ERROR: test_queue_feeder_donot_stop_onexc (test.test_multiprocessing_spawn.WithProcessesTestQu

[issue28414] SSL match_hostname fails for internationalized domain names

2017-06-08 Thread Nathaniel Smith
Nathaniel Smith added the comment: If the SSL module followed the pattern of encoding all str to bytes at the edges while leaving bytes alone, and used exclusively bytes internally (and in this case by "bytes" I mean "bytes objects containing A-labels"), then it would at least fix this bug and

<    1   2