[issue18967] Find a less conflict prone approach to Misc/NEWS

2017-06-19 Thread Brett Cannon
Brett Cannon added the comment: Yep, core-workflow work has superseded this issue. -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker

[issue30383] [3.5] Backport regrtest features from master to Python 3.5

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: I backport all test_regrtest except of test_huntrleaks_fd_leak() which is a deliberate choice, so I now close the issue. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue30383] [3.5] Backport regrtest features from master to Python 3.5

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: Oh, while reading bpo-30283, I see that Serhiy asked me to mention regrtest enhancements. So I reopen the issue. -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue30383] [3.5] Backport regrtest features from master to Python 3.5

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: New changeset a601fcca3bf2061e43d4d2710a730536cf26327b by Victor Stinner in branch '3.5': [3.5] bpo-30383: Backport regrtest and test_regrtest enhancements from master to 3.5 (#2279)

[issue30705] python2.7 -m test -R 3:3 hangs on Refleaks 2.7 buildbots

2017-06-19 Thread STINNER Victor
New submission from STINNER Victor: The Refleaks 2.7 job hangs on "AMD64 Windows8.1 Refleaks 2.7" and "x86 Gentoo Refleaks 2.7" buildbots. (1) Gentoo http://buildbot.python.org/all/builders/x86%20Gentoo%20Refleaks%202.7/builds/21 StartSat Jun 3 00:00:00 2017 Elapsed328 hrs, 17 mins, 37 secs

[issue30404] Make stdout and stderr truly unbuffered when using -u option

2017-06-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Note that if output by lines, the patch speeds up the output! Actually the output is fast enough with buffering and without. The only slowdown is exposed when output by characters, but this is uncommon case. And if you output by characters (in case of

[issue30450] Pull Windows dependencies from GitHub rather than svn.python.org

2017-06-19 Thread schen
schen added the comment: The usage text in build.bat still mentions that svn.exe is required for the '-e' flag. I think it should be updated to reflect the changes made. -- nosy: +schen ___ Python tracker

[issue30704] test_free_different_thread() of test_code leaks references on Python 3.6

2017-06-19 Thread STINNER Victor
New submission from STINNER Victor: haypo@selma$ ./python -m test -m test.test_code.CoExtra.test_free_different_thread -R 3:3 test_code Run tests sequentially test_code leaked [2, 1, 1] memory blocks, sum=4 The regression was introduced by the bpo-30604: commit

[issue30383] [3.5] Backport regrtest features from master to Python 3.5

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: I chose to not backport test_huntrleaks_fd_leak() since I expect bugs, and I'm not interested at this point to fix such issues. -- ___ Python tracker

[issue30703] test_multiprocessing_forkserver hangs on x86-64 Sierra 3.x. buildbot

2017-06-19 Thread STINNER Victor
New submission from STINNER Victor: regrtest hangs while running test_multiprocessing_forkserver in a worker process on the "x86-64 Sierra 3.x" buildbot. Bug seen twice: build 343 and 337. http://buildbot.python.org/all/builders/x86-64%20Sierra%203.x/builds/337/steps/test/logs/stdio Run

[issue30703] test_multiprocessing_forkserver hangs on x86-64 Sierra 3.x. buildbot

2017-06-19 Thread STINNER Victor
Changes by STINNER Victor : -- components: +macOS nosy: +ned.deily, ronaldoussoren ___ Python tracker ___

[issue30383] [3.5] Backport regrtest features from master to Python 3.5

2017-06-19 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2328 ___ Python tracker ___ ___

[issue30404] Make stdout and stderr truly unbuffered when using -u option

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: Hum. It has an huge impact on performances. Would it make sense to have two command line options to choose between unbuffered and line buffered? The C setvbuf() function uses these constants: _IONBF unbuffered _IOLBF line buffered

[issue30404] Make stdout and stderr truly unbuffered when using -u option

2017-06-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Writing separate lines: $ ./python -m timeit -s 'import sys' -s 'with open("setup.py") as f: s = f.readlines()' 'sys.stderr.writelines(s)' 2>/dev/null 200 loops, best of 5: 1.07 msec per loop $ ./python -u -m timeit -s 'import sys' -s 'with open("setup.py")

[issue30176] curses attribute constants list is incomplete

2017-06-19 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks Mariatta and Serhiy! -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker

[issue30176] curses attribute constants list is incomplete

2017-06-19 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset b39a7481ee7e6166d6d2b252a7a514b1f6553dfa by Xiang Zhang in branch '2.7': bpo-30176: Add missing curses cell attributes constants (#2278) https://github.com/python/cpython/commit/b39a7481ee7e6166d6d2b252a7a514b1f6553dfa --

[issue30176] curses attribute constants list is incomplete

2017-06-19 Thread Xiang Zhang
Xiang Zhang added the comment: New changeset 04521c275e47e4df59046ee0297810f06c208350 by Xiang Zhang in branch '3.5': bpo-30176: Add missing curses cell attributes constants (#2277) https://github.com/python/cpython/commit/04521c275e47e4df59046ee0297810f06c208350 --

[issue30176] curses attribute constants list is incomplete

2017-06-19 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +2327 ___ Python tracker ___ ___

[issue30176] curses attribute constants list is incomplete

2017-06-19 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +2326 ___ Python tracker ___ ___

[issue30695] add a nomemory_allocator to the _testcapi module

2017-06-19 Thread Xavier de Gaye
Xavier de Gaye added the comment: Good point. Not freeing the memory made the implementation of set_nomemory_allocator() simpler, no need to call PyMem_GetAllocator(). Forget about this point, sorry :-) -- ___ Python tracker

[issue30695] add a nomemory_allocator to the _testcapi module

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: > I am not sure, failmalloc.enable(range) accepts only range > 1, hook_malloc() > fails only once instead of permanently and hook_free() does free memory. All these things can change :-) > Also what happens then after this call is not very close to real life

[issue30695] add a nomemory_allocator to the _testcapi module

2017-06-19 Thread Xavier de Gaye
Xavier de Gaye added the comment: I am not sure, failmalloc.enable(range) accepts only range > 1, hook_malloc() fails only once instead of permanently and hook_free() does free memory. -- ___ Python tracker

[issue30702] pickle uses getattr(obj, '__reduce__') instead of getattr(type(obj), '__reduce__')

2017-06-19 Thread Dan Snider
New submission from Dan Snider: That is inconsistent with every other object.__dunder_method__ which still work even if the instance gets an attribute with the same name. -- components: Library (Lib) messages: 296337 nosy: assume_away priority: normal severity: normal status: open

[issue29887] test_normalization doesn't work

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: New changeset acdf159b245aaac28f54dd10606911386ab39058 by Victor Stinner in branch '3.6': bpo-29887: test_normalization handles PermissionError (#1196) (#2275) https://github.com/python/cpython/commit/acdf159b245aaac28f54dd10606911386ab39058 --

[issue30351] regrtest hangs on x86 Windows XP 2.7

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%20CURRENT%20Non-Debug%202.7/builds/140/steps/test/logs/stdio ... 0:10:17 [400/404] test_binhex passed -- running: test_threading (474 sec) 0:10:17 [401/404] test_pdb passed -- running: test_threading (474

[issue30351] regrtest hangs on x86 Windows XP 2.7

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: Yet another bug. I see a pattern, a lot of tests ends with test_threading running in background, test_threading is the last test to run, and then regrtest stops logging anything and buildbot kills the test.

[issue30695] add a nomemory_allocator to the _testcapi module

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: Your code can be reproduced with pyfailmalloc using N=0 :-) -- ___ Python tracker ___

[issue13617] Reject embedded null characters in wchar* strings

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: Sorry, I lost track of this issue. Feel free to update and complete my patch :-) -- ___ Python tracker ___

[issue30695] add a nomemory_allocator to the _testcapi module

2017-06-19 Thread Xavier de Gaye
Xavier de Gaye added the comment: The chain of events following a call to set_nomemory_allocator() is deterministic, this is another difference with pyfailmalloc. Also what happens then after this call is not very close to real life as memory is never freed. Having the possibility to trigger

[issue25684] ttk.OptionMenu radiobuttons aren't unique between two instances of OptionMenu

2017-06-19 Thread Cheryl Sabella
Cheryl Sabella added the comment: I submitted a patch based on Bryan's original workaround on SO. Thanks. -- nosy: +csabella ___ Python tracker ___

[issue30495] IDLE: modernize textview module

2017-06-19 Thread Cheryl Sabella
Cheryl Sabella added the comment: Hi Terry, Were you waiting on me for changes to the patch or would you like me to make a PR? Thanks! -- ___ Python tracker

[issue30263] regrtest: log the system load?

2017-06-19 Thread Jeremy Kloth
Jeremy Kloth added the comment: Race conditions, not so much, but definitely helps with random timeout errors ;) -- ___ Python tracker ___

[issue25684] ttk.OptionMenu radiobuttons aren't unique between two instances of OptionMenu

2017-06-19 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +2325 ___ Python tracker ___ ___

[issue16055] incorrect error text for int(base=1000, x='1')

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka: "set keywords: + easy (C)" Thanks for making easy issues as easy and no fixing them :-) But in my experience, even if the issue seems easy to *you*, you should explain which file has to be patched, and what steps should be done to write the

[issue30263] regrtest: log the system load?

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: More general note about load average: at this point, I'm not sure of the usefulness of this information to debug race conditions :-) -- ___ Python tracker

[issue30263] regrtest: log the system load?

2017-06-19 Thread Jeremy Kloth
Jeremy Kloth added the comment: On Mon, Jun 19, 2017 at 6:24 AM, STINNER Victor wrote: > > STINNER Victor added the comment: > >> Pushed utility to github: https://github.com/jkloth/loadavg > > Hum, I see two implementations: > > * LOADAVG_USE_REG: use the registry,

[issue30696] infinite loop in PyRun_InteractiveLoopFlags()

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: See also my old issue #8070 opened 7 years ago :-) -- ___ Python tracker ___

[issue30696] infinite loop in PyRun_InteractiveLoopFlags()

2017-06-19 Thread Xavier de Gaye
Xavier de Gaye added the comment: The patch is far too simplistic. With this patch an exception kills the interactive loop, for example: $ ./python -q >>> x Traceback (most recent call last): File "", line 1, in NameError: name 'x' is not defined $ --

[issue30695] add a nomemory_allocator to the _testcapi module

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: The main difference between your change and pyfailmalloc is the ability in pyfailmalloc to only fail in N allocations. If you want to test various code paths, you need to allow N allocations to reach the deep code that you want to test. My code is something

[issue30263] regrtest: log the system load?

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: > Pushed utility to github: https://github.com/jkloth/loadavg Hum, I see two implementations: * LOADAVG_USE_REG: use the registry, RegQueryValueExW(HKEY_PERFORMANCE_DATA, L"2", ...) * LOADAVG_USE_PDH: PdhOpenQueryW() Are these API accessible by everyone? On

[issue30695] add a nomemory_allocator to the _testcapi module

2017-06-19 Thread Xavier de Gaye
Xavier de Gaye added the comment: > I think the allocators must just return NULL, without setting the error. You are right, thanks. -- ___ Python tracker

[issue30263] regrtest: log the system load?

2017-06-19 Thread Jeremy Kloth
Jeremy Kloth added the comment: Pushed utility to github: https://github.com/jkloth/loadavg It is currently just a command-line utility PoC. The routines of interest would be CalculateLoadReg and the loop in wmain(). -- ___ Python tracker

[issue30695] add a nomemory_allocator to the _testcapi module

2017-06-19 Thread Xavier de Gaye
Xavier de Gaye added the comment: Yes, actually I thought first about re-opening issue 19817 instead of opening this new issue. -- ___ Python tracker

[issue26656] Documentation for re.compile is a bit outdated

2017-06-19 Thread swapnil agarwal
swapnil agarwal added the comment: hello team, I am novice developer. Can I take it up as my first bug. -- nosy: +swapnil agarwal ___ Python tracker ___

[issue29887] test_normalization doesn't work

2017-06-19 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2324 ___ Python tracker ___ ___

[issue30404] Make stdout and stderr truly unbuffered when using -u option

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: While I hope that users of the -u options expect the slow-down, would it be possible to benchmark it? For example, try to write setup.py content character by character to stdout using -u or not, into a TTY, into a pipe and/or a file. I'm curious if the line

[issue30404] Make stdout and stderr truly unbuffered when using -u option

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: Oh, I like https://github.com/python/cpython/pull/1667/ "If write_through is True, calls to write() are guaranteed not to be buffered: any data written on the TextIOWrapper object is immediately handled to its underlying binary buffer." I didn't know

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

2017-06-19 Thread Jeremy Kloth
Jeremy Kloth added the comment: This is ready to be merged, pending any comments from Zach. -- ___ Python tracker ___

[issue30263] regrtest: log the system load?

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: > Before implementing this as a PR, I would like guidance as to the best place > to integrate this: > 1. as os.getloadavg(), > 2. in _testcapi > 3. in winapi (although it is a conglomeration of WinAPIs) > 4. in regrtest (as Python). That's tough question.

[issue30339] test_multiprocessing_main_handling: "RuntimeError: Timed out waiting for results" on x86 Windows7 3.x

2017-06-19 Thread Jeremy Kloth
Jeremy Kloth added the comment: Following up as the last run on my 3.5 buildslave: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.5/builds/198 had the timeout again. It is running at a 50% success rate with the only fault being warnings/errors due to this test.

[issue30263] regrtest: log the system load?

2017-06-19 Thread Jeremy Kloth
Jeremy Kloth added the comment: I've implemented a getloadavg() equivalent using Windows performance counters that could be used to display the load in regrtest, as it happens, before finding this issue. It is implemented in C (although it *can* be done in only Python). It has the identical

[issue29887] test_normalization doesn't work

2017-06-19 Thread STINNER Victor
STINNER Victor added the comment: New changeset 51f40a81a4acbc85cb1034750fb16cb1854b2315 by Victor Stinner (Mariatta) in branch '3.6': [3.6] bpo-29887: Test normalization now fails if download fails (GH-905) (#2271)

[issue30701] Exception parsing certain invalid email address headers

2017-06-19 Thread Tim Bell
New submission from Tim Bell: According to RFC 5322, an email address like this isn't valid: u...@example.com (The display-name "u...@example.com" contains "@", which isn't in the set of atext characters used to form an atom.) How it's handled by the email package varies

[issue30693] tarfile add uses random order

2017-06-19 Thread Bernhard M. Wiedemann
Bernhard M. Wiedemann added the comment: note: recent GNU tar versions (1.28?) added an option --sort=name and the overhead of sorting (e.g. I measured 4ms for 1 files) is negligible compared to the other processing done on the files here. --

[issue30665] pass big values for arg to fcntl.ioctl

2017-06-19 Thread Uwe Kleine-König
Uwe Kleine-König added the comment: So the only option to fix this is to determine the type of arg from the request parameter? I failed to find the implementation of ioctl for linux in glibc, the best I found is one that only seems to be used on powerpc[1] which seems to assume that the third

<    1   2