[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer
New submission from Segev Finer: ..\Modules\_tracemalloc.c(88): warning C4359: '': Alignment specifier is less than actual alignment (8), and will be ignored. For this to actually work we simply need to use #pragma pack instead. -- components: Extension Modules, Windows messages: 29899

[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +2895 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +2896 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: -2896 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread John Still
John Still added the comment: Ok I understand what you mean. I think the only conditions for test failure are (A) $BROWSER is set and (B) $BROWSER is set to an actual executable that should be caught by ``register_standard_browsers`` prior to execution reaching the last if clause of ``registe

[issue22062] Fix pathlib.Path.(r)glob doc glitches.

2017-07-24 Thread Aditya Hase
Aditya Hase added the comment: Should I create a Github PR with given patch? If so, how do I give credit to the original author? -- nosy: +adityahase ___ Python tracker ___

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

2017-07-24 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- versions: -Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue31019] multiprocessing.Pool should join "dead" processes

2017-07-24 Thread STINNER Victor
New submission from STINNER Victor: With debug patches for bpo-26762, I noticed that some unit tests of test_multiprocessing_spawn leaks "dangling" processes: --- haypo@selma$ ./python -m test --fail-env-changed test_multiprocessing_spawn -v --match test.test_multiprocessing_spawn.WithProcesses

[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +2897 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue31019] multiprocessing.Pool should join "dead" processes

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2898 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: I just created bpo-31019 "multiprocessing.Pool should join "dead" processes" to fix dangling processes related to pool, like test.test_multiprocessing_spawn.WithProcessesTestPool.test_context. -- ___ Python tracker

[issue22062] Fix pathlib.Path.(r)glob doc glitches.

2017-07-24 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Aditya: The guideline for converting a patch to the PR is documented here: https://devguide.python.org/pullrequest/#converting-an-existing-patch-from-the-b-p-o-to-github -- nosy: +Mariatta ___ Python tracker

[issue30814] Import dotted name as alias breaks with concurrency

2017-07-24 Thread Ned Deily
Ned Deily added the comment: > Which Git revisions are you testing? On master, do you have my latest commit > e72b1359f81d1dd42bd8a5c5cc2b3928b74f8023 ? Yes, this is with current top of trunk of both branches. Perhaps I wasn't clear about "installed location". The test does not fail if you r

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2899 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue22062] Fix pathlib.Path.(r)glob doc glitches.

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: Since Mike has not responded in more that a week, please go ahead. Just put "“Original patch by Mike Short." in the commit comments (if you can, otherwise add a separate comment). Please add News blurb (see devguide) if you know how, with at least a title l

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This would be not easy. Since the BROWSER environment variable should be patched before the first use the webbrowser module, the test should import webbrowser in a separate process (you can use the test.support.script_helper.assert_python_ok() helper). _syn

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: I rewrote PR 2841 to detect more bugs. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: PR 2850 + PR 2849 (of bpo-31019) fix most dangling process/thread, but one specific test still leaks: test.test_multiprocessing_spawn.WithProcessesTestPool.test_traceback I will try to fix it once other bugs are fixed. --

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Using PR 2841, I wrote a tool to run each test in subprocess to check if a test method leaks. I found these methods: ./python -m test --fail-env-changed test_multiprocessing_spawn -v --match test.test_multiprocessing_spawn.WithProcessesTestBarrier.test_thousa

[issue27099] IDLE: turn builting extensions into regular modules

2017-07-24 Thread Charles Wohlganger
Charles Wohlganger added the comment: The patch moves all config variables to config-main, config-highlight (for highlight colors), and config-keys (for keys). Keys and highlights are configurable in their respective tabs. Parens and Code Context options are in the Highlighting tab, Format Par

[issue30814] Import dotted name as alias breaks with concurrency

2017-07-24 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +2900 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30876] SystemError on importing module from unloaded package

2017-07-24 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +2901 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30853] IDLE: configdialog -- factor out Tracer subclass

2017-07-24 Thread Cheryl Sabella
Cheryl Sabella added the comment: I would like to work on this, but I don't think I'd be able to have something ready for a few days, so I don't want to hold you up if you would like it sooner. -- ___ Python tracker

[issue9566] Compilation warnings under x64 Windows

2017-07-24 Thread Segev Finer
Changes by Segev Finer : -- pull_requests: +2902 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue30999] statistics module: add "key" keyword argument to median, mode, ...

2017-07-24 Thread gerion
gerion added the comment: The position might be useful, if you have a second list with some side data stored in it, and not a list of tuples :). I had the idea to file a bug, when I had a list of coordinates and wanted to use the point with the median of the x-coordinates as "representation" f

[issue30853] IDLE: configdialog -- factor out Tracer subclass

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am going to continue with the tests. -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue27099] IDLE: turn builting extensions into regular modules

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: 'Clean break' is easy to say. I won't decide yet. Other opinions? I think I will post to idle-dev also. Even if no one responds, there will have been the chance. -- ___ Python tracker

[issue30714] test_ssl fails with openssl 1.1.0f: test_alpn_protocols()

2017-07-24 Thread Gregory P. Smith
Gregory P. Smith added the comment: Naturally up to the release managers. If I were one, I'd consider it just because not addressing the failure one way or another will lead to people finding us and asking a question about why it is failing. Adding a SkipTest when the relevant library versio

[issue31020] Add support for custom compressor in tarfile

2017-07-24 Thread insomniacslk
New submission from insomniacslk: Tarfile would benefit from exposing custom compressors. At the moment the only way to use something that is not gzip/bzip/lzma is to separate the archiving and compression steps. A possible approach is to pass a custom compression function to `tarfile.TarFile

[issue30814] Import dotted name as alias breaks with concurrency

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Serhiy on PR 2851: > I forget to include directories with new test files in the list of the > library directories. This caused that these test files were not installed. Oh, too bad that Zach's "x86 Gentoo Installed with X 3.6" buildbot is offline. --

[issue30814] Import dotted name as alias breaks with concurrency

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: I also opened https://github.com/python/devguide/issues/241 : "Document how to add a new file or a new directory". It's not the first time that we make such mistake. -- ___ Python tracker

[issue30980] Calling asyncore.file_wrapper.close twice may close unrelated file descriptor

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: New changeset c648a93ae342ac28d2abbb100161eae4f907d001 by Victor Stinner (Nir Soffer) in branch 'master': bpo-30980: Fix double close in asyncore.file_wrapper (#2789) https://github.com/python/cpython/commit/c648a93ae342ac28d2abbb100161eae4f907d001 --

[issue30980] Calling asyncore.file_wrapper.close twice may close unrelated file descriptor

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Thanks for your fix Nir Soffer! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue26415] Excessive peak memory consumption by the Python parser

2017-07-24 Thread A. Skrobov
A. Skrobov added the comment: To bump this year-old issue, I have delivered a talk at EuroPython 2017, explaining what my patch does, how it does what it does, and why it's a good thing to do. You can watch my talk at https://www.youtube.com/watch?v=dyRDmcsTwhE&t=1h52m38s --

[issue31021] Clarify programming faq.

2017-07-24 Thread Terry J. Reedy
New submission from Terry J. Reedy: https://docs.python.org/3/faq/programming.html#why-does-22-10-return-3 "Why does -22 // 10 return -3? It’s primarily driven by the desire that i % j have the same sign as j. If you want that, and also want: i == (i // j) * j + (i % j) then integer division h

[issue31021] Clarify programming faq.

2017-07-24 Thread Ashok Bakthavathsalam
Changes by Ashok Bakthavathsalam : -- pull_requests: +2904 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue30931] Race condition in asyncore may access the wrong dispatcher

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2905 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: New changeset d7e64d9934d86aa6173229de5af5fe908662a33a by Victor Stinner in branch 'master': test_multiprocessing: Fix dangling process/thread (#2850) https://github.com/python/cpython/commit/d7e64d9934d86aa6173229de5af5fe908662a33a -- __

[issue27099] IDLE: turn builting extensions into regular modules

2017-07-24 Thread Cheryl Sabella
Cheryl Sabella added the comment: I don't think a clean break is possible as there's only one set of config files on the system. So, if someone runs Idle 3.7 (this version) and Idle 2.7, they would probably want their settings to be the same for both since that's how it would currently work.

[issue30985] Set closing variable in asyncore at close

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Proposed change looks more like an enhancement like a bug fix. I consider that features are not welcome anyone in the asyncore module, since it's now deprecated, replaced with selectors and asyncio. I would prefer to reject this issue. Giampaolo, Serhiy, Guid

[issue30801] shoutdown process error with python 3.4 and pyqt/PySide

2017-07-24 Thread Terry J. Reedy
Terry J. Reedy added the comment: You must demonstrate that there is a problem with 3.6 or 3.7 and then write a patch that fixes the problem in those versions. -- nosy: +terry.reedy ___ Python tracker

[issue30985] Set closing variable in asyncore at close

2017-07-24 Thread Nir Soffer
Nir Soffer added the comment: I agree that this change alone is may not be important enough to fix in asyncore today - but this enables easy detection of closed sockets needed for https://github.com/python/cpython/pull/2764 or the alternative https://github.com/python/cpython/pull/2854. Unless

[issue30994] Asyncore does not need to copy map.items() before polling

2017-07-24 Thread Nir Soffer
Nir Soffer added the comment: The advantage is avoiding wasteful copy on each iteration. -- nosy: +Nir Soffer ___ Python tracker ___ _

[issue30931] Race condition in asyncore may access the wrong dispatcher

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: On my PR 2854, Nir added these comments (extract): "And now we try to read from close dispatcher. I think we should wait for #2804 (...)" Sorry, I don't understand. My PR fixes described the bug that you described in msg298682: "If a dispatchers is closed an

[issue30994] Asyncore does not need to copy map.items() before polling

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: asyncore is now deprecated and I prefer to restrict changes to minimum to avoid regressions. While the change makes sense, it only looks like a very cheap micro-optimization. I don't think that it's worth it. -- ___

[issue30985] Set closing variable in asyncore at close

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: "Fixing closing attribute will allow fixing the races during asyncore.poll() and asyncore.poll2(), see https://github.com/python/cpython/pull/2764"; Aha, *slowly* I understand that asyncore is vulnerable to multiple race conditions, and it seems lile we requir

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: > test.test_multiprocessing_spawn.WithProcessesTestPool.test_traceback Oh, this test only "leaks" dangling processes and threads because PR 2841 was too strict. The problem is that multiprocessing.Pool has thread attributes which hold references to the pool: r

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2906 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: New changeset ffb49408f0780ae80a553208aa133bc5bb3ba129 by Victor Stinner in branch 'master': test_multiprocessing detects dangling per test case (#2841) https://github.com/python/cpython/commit/ffb49408f0780ae80a553208aa133bc5bb3ba129 --

[issue31022] ERROR: testRegularFile (test.test_socket.SendfileUsingSendTest) random failure on AppVeyor

2017-07-24 Thread STINNER Victor
New submission from STINNER Victor: https://ci.appveyor.com/project/python/cpython/build/3.7.0a0.4809 (...) testNonRegularFile (test.test_socket.SendfileUsingSendTest) ... ok testOffset (test.test_socket.SendfileUsingSendTest) ... ok testRegularFile (test.test_socket.SendfileUsingSendTest) ... E

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: New changeset b4c52966c810b5c5e088fceff403247f610b7d13 by Victor Stinner in branch 'master': bpo-26762: test_multiprocessing close more queues (#2855) https://github.com/python/cpython/commit/b4c52966c810b5c5e088fceff403247f610b7d13 -- __

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-24 Thread STINNER Victor
STINNER Victor added the comment: Ok, I pushed 3 changes. Only one test still has a minor issue: test.test_multiprocessing_spawn.WithProcessesTestPool.test_context The bpo-31019 fixes it. Later, we will be able to modify ManagerMixin.tearDownClass() to emit a warning immediately if a manager

[issue30999] statistics module: add "key" keyword argument to median, mode, ...

2017-07-24 Thread Steven D'Aprano
Steven D'Aprano added the comment: I've given this some more thought, and I think that a "key" argument would make sense for a general selection function. The general selection problem is: given a set of items A, and a number k between 1 and the number of items, return the k-th item. In Python

[issue30732] json.dumps() lacks information about RecursionError related to default function

2017-07-24 Thread svelankar
Changes by svelankar : -- pull_requests: +2907 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30732] json.dumps() lacks information about RecursionError related to default function

2017-07-24 Thread svelankar
Changes by svelankar : -- pull_requests: +2908 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue31023] Git Bootcamp and Cheat Sheet - Section 32.10 - Creating a Pull request needs an additional step

2017-07-24 Thread svelankar
New submission from svelankar: Section 32.10 - Creating a Pull Request Step 2 should be changed to Step 3 and so on. And a new step i.e. step 2 as "Press new pull request button" -- assignee: docs@python components: Documentation messages: 299039 nosy: docs@python, svelankar priority:

[issue31023] Git Bootcamp and Cheat Sheet - Section 32.10 - Creating a Pull request needs an additional step

2017-07-24 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Hi, the issue tracker for the Dev guide is at https://github.com/python/DevGuide Can you file this issue there? Thanks. -- nosy: +Mariatta resolution: -> not a bug stage: -> resolved status: open -> closed ___ Pyt

[issue11129] logging: allow multiple entries in qualname config

2017-07-24 Thread Craig McQueen
Changes by Craig McQueen : -- nosy: +cmcqueen1975 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue13429] provide __file__ to extension init function

2017-07-24 Thread Stefan Behnel
Stefan Behnel added the comment: This has been resolved by PEP 489, issue 24268. The module initialisation process receives the complete ModuleSpec now, starting with CPython 3.5, and can do with it whatever it likes, before executing any user code. -- resolution: -> duplicate stage:

<    1   2