[issue34601] Typo: "which would rather raise MemoryError than give up", than or then?

2018-09-07 Thread David Lin
New submission from David Lin : https://docs.python.org/3/library/exceptions.html exception OverflowError Raised when the result of an arithmetic operation is too large to be represented. This cannot occur for integers (which would rather raise MemoryError than give up). However, for

[issue34599] improve performance of _Py_bytes_capitalize()

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: Nice optimization Sergey Fedoseev, thanks! -- nosy: +vstinner ___ Python tracker ___ ___

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset 8f735485acf2e35a75d2fa019feb8f905598c4e5 by Victor Stinner (jdemeyer) in branch 'master': bpo-25750: fix refcounts in type_getattro() (GH-6118) https://github.com/python/cpython/commit/8f735485acf2e35a75d2fa019feb8f905598c4e5 --

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-09-07 Thread miss-islington
Change by miss-islington : -- pull_requests: +8547 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-09-07 Thread miss-islington
Change by miss-islington : -- pull_requests: +8546 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-09-07 Thread miss-islington
Change by miss-islington : -- pull_requests: +8548 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +8554 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +8553 stage: -> patch review ___ Python tracker ___ ___

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset 28658485a54ad5f9df52ecc12d9046269f1654ec by Victor Stinner (William Grzybowski) in branch 'master': bpo-34604: Fix possible mojibake in pwd.getpwnam() and grp.getgrnam() (GH-9098)

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: > The Django PR is an unreadable infinitely-long page of miserable arguing. So > the context doesn't help much. In short, some people associate the words "master" and "slave" to slavery. To enhance the diversity in the Python community, I suggest to try to

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

2018-09-07 Thread William Grzybowski
Change by William Grzybowski : -- pull_requests: +8559 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34609] Idle Unitest

2018-09-07 Thread pisc...@yahoo.fr
New submission from pisc...@yahoo.fr : Idle is unable to import unittest. and raises an attributeError. Output of the Python shell Idle is included in the file bug idle. several files raise this exception on of them is included in this report the Trace for Idle is as follows : Python 3.6.5

[issue26544] platform.libc_ver() returns incorrect version number

2018-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for merging PRs Victor, but seems you have merged wrong PR for 2.7. -- ___ Python tracker ___

[issue34605] Avoid master/slave terminology

2018-09-07 Thread Larry Hastings
Larry Hastings added the comment: I'm a little surprised by this. It's not like slavery was acceptable when these computer science terms were coined and it's only comparatively recently that they've gone out of fashion. On the other hand, there are some areas in computer software where

[issue34595] PyUnicode_FromFormat(): add %T format for an object type name

2018-09-07 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +8557 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23057] [Windows] asyncio: support signal handlers on Windows (feature request)

2018-09-07 Thread Chris Warrick
Change by Chris Warrick : -- nosy: +Kwpolska ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34563] invalid assert on big output of multiprocessing.Process

2018-09-07 Thread Oleksandr Buchkovskyi
Oleksandr Buchkovskyi added the comment: thank you for all the help in merging this fix! -- ___ Python tracker ___ ___

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +8556 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34595] PyUnicode_FromFormat(): add %T format for an object type name

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset 886483e2b9bbabf60ab769683269b873381dd5ee by Victor Stinner in branch 'master': bpo-34595: Add %T format to PyUnicode_FromFormatV() (GH-9080) https://github.com/python/cpython/commit/886483e2b9bbabf60ab769683269b873381dd5ee --

[issue34605] Avoid master/slave terminology

2018-09-07 Thread Larry Hastings
Larry Hastings added the comment: > > Have there been any actual complaints? > Yes, but sadly they are private. I'm not super-excited by the idea that Python has to change its behavior based on secret comments. Python has traditionally had a very open governance model where all discussions

[issue34573] Simplify __reduce__() of set and dict iterators.

2018-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps the bug was specific to OrderedDict itrerators. I'll try to write additional tests, and after that I'll merge PR 9050. -- assignee: -> serhiy.storchaka ___ Python tracker

[issue20104] expose posix_spawn(p)

2018-09-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 254a4663d8c5970ae2928185c50ebaa6c7e62c80 by Pablo Galindo in branch 'master': bpo-20104: Add flag capabilities to posix_spawn (GH-6693) https://github.com/python/cpython/commit/254a4663d8c5970ae2928185c50ebaa6c7e62c80 --

[issue34608] gc.get_referrers behavior change 3.6 to 3.7

2018-09-07 Thread Bryan
New submission from Bryan : When called on a local object inside a function, gc.get_referrers no longer returns a Frame as one of the references. I could not find anything in the release notes or changeling that indicated that this is an intentional change. The following script generates

[issue34605] Avoid master/slave terminology

2018-09-07 Thread Larry Hastings
Larry Hastings added the comment: As a counter-example: A quick grep finds 555 occurrences of the word "kill" in CPython master. Everybody knows killing is bad and using the term might upset certain people. Yet I would not support expunging the word "kill" from Python. --

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

2018-09-07 Thread William Grzybowski
Change by William Grzybowski : -- pull_requests: +8558 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34605] Avoid master/slave terminology

2018-09-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: To me, there is nothing wrong with the word 'master', as such. I mastered Python to become a master of Python. Purging Python of 'master' seems ill-conceived. The word 'slave' is different matter to me. In tk and tkinter, the 'parent' and 'master' of a

[issue34594] Some tests use hardcoded errno values

2018-09-07 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset 18d7dff1bb6f5ca7060b0b2e2a2e74493619178f by Benjamin Peterson (Zackery Spytz) in branch '3.7': [3.7] bpo-34594: Don't hardcode errno values in the tests. (GH-9094)

[issue34594] Some tests use hardcoded errno values

2018-09-07 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset 9eeecfd5d03cfd6d5cef71de31eed7f65f0e658b by Benjamin Peterson (Zackery Spytz) in branch '3.6': [3.6] bpo-34594: Don't hardcode errno values in the tests. (GH-9096)

[issue34605] Avoid master/slave terminology

2018-09-07 Thread Matthew Barnett
Matthew Barnett added the comment: Not all uses of the word "master" are associated with slavery, e.g. "master craftsman", "master copy", "master file table". I think it's best to avoid use of master/slave where practicable, but other uses of "master" are not necessarily a problem.

[issue34546] Add encryption support to zipfile

2018-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What is the reason of using such weak encryption? It looks to me that creating a non-encrypted ZIP file and encrypting it with third-party tools is the right way if you need an encryption. -- nosy: +christian.heimes

[issue34606] Unable to read zip file with extra

2018-09-07 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34606] Unable to read zip file with extra

2018-09-07 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: It's also reproducible on master. git blame tells me this is introduced with feccdb2a249a71be330765be77dee57121866779 (https://bugs.python.org/issue29774) ➜ cpython git:(master) commit feccdb2a249a71be330765be77dee57121866779 Author: Serhiy

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset 7e610bcdf128f61b925654e4fa80fbac83537d0e by Victor Stinner in branch 'master': bpo-34605: childs => children (GH-9102) https://github.com/python/cpython/commit/7e610bcdf128f61b925654e4fa80fbac83537d0e --

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: > Have there been any actual complaints? Yes, but sadly they are private. -- ___ Python tracker ___

[issue33083] math.factorial accepts non-integral Decimal instances

2018-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since this is potentially breaking change, please add a What's New entry for it. -- ___ Python tracker ___

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

2018-09-07 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +vstinner versions: +Python 2.7 -Python 3.4, Python 3.5 ___ Python tracker ___ ___

[issue34601] Typo: "which would rather raise MemoryError than give up", than or then?

2018-09-07 Thread Josh Rosenberg
Josh Rosenberg added the comment: "than" is correct; "giving up" in this context would mean "not even trying to allocate the memory and just preemptively raising OverflowError, like non-integer numeric types with limited ranges". Rather than giving up that way, it chooses to try to allocate

[issue34590] "Logging HOWTO" should share an example of best practices for using logging in a library

2018-09-07 Thread Vinay Sajip
Vinay Sajip added the comment: > Should I make use of a single logger object in my library, multiple loggers > in a tree, or multiple unrelated loggers? Since I have just one public module, > I'm tempted to say that I should just use one logger object. Yes. The advanced logging tutorial (part

[issue34605] Avoid master/slave terminology

2018-09-07 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Just want to add that it's a constant source of problem with respect to Redis and antirez wrote a detailed blog post about it yesterday : http://antirez.com/news/122 . It causes a lot of energy and emotional drain when issues like this get to

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

2018-09-07 Thread William Grzybowski
Change by William Grzybowski : -- keywords: +patch pull_requests: +8552 stage: -> patch review ___ Python tracker ___ ___

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: IMHO it's ok to keep the "master" term for: * Git "master" branch * "webmaster" * "postmaster" To find all impacted files, I used the commend: git grep -i -E 'master|slave'|grep -v -E 'webmaster|postmaster|/blob/master/' --

[issue34607] test_multiprocessing_forkserver is altering the environment on AMD64 FreeBSD 10.x Shared 3.7

2018-09-07 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : test_multiprocessing_forkserver is altering the environment on AMD64 FreeBSD 10.x Shared 3.7: https://buildbot.python.org/all/#/builders/124/builds/545/steps/4/logs/stdio == Tests result: ENV CHANGED == 393 tests OK. 10 slowest tests: - test_tools:

[issue22543] -W option cannot use non-standard categories

2018-09-07 Thread Thrlwiti
Change by Thrlwiti : -- nosy: +THRlWiTi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

2018-09-07 Thread William Grzybowski
New submission from William Grzybowski : Issue was spotted by @vstinner while reviewing https://github.com/python/cpython/pull/7081 pwd.getpwnam and grp.getgrnam are susceptible to mojibake as they are using encoded bytes instead of unicode in the error message. -- components:

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: > bpo-34605, libregrtest: Rename --slaveargs to --worker-args (GH-9099) I don't think that this change should be backported to 3.7 and older, since it *might* break the backward compatibility. -- ___ Python

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: I'm working on patches to change that. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue34513] test_multiprocessing_spawn fails on x86 Windows7 3.7 buildbot

2018-09-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New failure on x86 Windows7 3.x: https://buildbot.python.org/all/#/builders/58/builds/1295/steps/3/logs/stdio test_no_import_lock_contention (test.test_multiprocessing_spawn.WithProcessesTestQueue) ... ok Timeout (0:15:00)! Thread 0x0f10 (most

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: In the C API, PyMemoryViewObject has a mbuf.master attribute, Include/memoryview.h: --- typedef struct { PyObject_HEAD int flags; /* state flags */ Py_ssize_t exports; /* number of direct memoryview exports */ Py_buffer master; /*

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: nis module contains the error message: NisError("No NIS master found for any map"), but libnis has a yp_master() function, it's no like Python picked this name. I suggest to keep "master" here to keep Python consistent with libnis. And "NIP master" gives

[issue34602] python3 resource.setrlimit strange behaviour under macOS

2018-09-07 Thread Ronald Oussoren
Ronald Oussoren added the comment: I get the same error, also with python3.7. Both for homebrew and a python.org installer. -- components: +macOS nosy: +ned.deily, ronaldoussoren versions: +Python 3.7 ___ Python tracker

[issue34606] Unable to read zip file with extra

2018-09-07 Thread Kyle Altendorf
New submission from Kyle Altendorf : This was first found over in Twisted tests. We probably aren't too terribly worried about it but I wanted to report here anyways. https://twistedmatrix.com/trac/ticket/9525 Both 3.6 and 3.7 write the same file (sha at the end) based on the script in the

[issue34597] Python needs to check existence of functions at runtime for targeting older macOS platforms

2018-09-07 Thread Zorg
Zorg added the comment: The minimum OS target (which looks like 10.13) should ideally be well defined and tested using the latest SDK, rather than there being "no promises". Or at least it should be documented that this isn't currently supported, or how to disable specific features and

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: sqlite3.dump._iterdump() access to the "sqlite_master" table Hum, I don't think that Python chose the name of this table. This issue should be addressed in SQLite, not in Python. -- ___ Python tracker

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: Ok, with these 3 PRs, I should have replaced most usages of master and slave terms. -- ___ Python tracker ___

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
Change by STINNER Victor : -- components: -2to3 (2.x to 3.x conversion tool), Argument Clinic, Build, Cross-Build, Demos and Tools, Distutils, Documentation, Extension Modules, FreeBSD, IDLE, IO, Installation, Library (Lib), Regular Expressions, SSL, Tests, Tkinter, Unicode,

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +8555 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34605] Avoid master/slave terminology

2018-09-07 Thread Yury Selivanov
Change by Yury Selivanov : -- components: -asyncio nosy: -yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: (Oops, I didn't want to put so many people in the nosy list, sorry about the spam.) -- nosy: -Alex.Willmer, asvetlov, barry, docs@python, dstufft, eric.araujo, ezio.melotti, koobs, larry, mrabarnett, ned.deily, paul.moore, r.david.murray,

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset 012f5b968a738b15ae9b40c499a1c0778b0615a9 by Victor Stinner in branch 'master': bpo-34605, libregrtest: Rename --slaveargs to --worker-args (GH-9099) https://github.com/python/cpython/commit/012f5b968a738b15ae9b40c499a1c0778b0615a9 --

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset 5e922658fb55734bf8b4c6246033ea93af172ff7 by Victor Stinner in branch 'master': bpo-34605: Avoid master/slave terms (GH-9101) https://github.com/python/cpython/commit/5e922658fb55734bf8b4c6246033ea93af172ff7 --

[issue34563] invalid assert on big output of multiprocessing.Process

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: Thanks Alexander Buchkovsky for the fix: it has been merged into 3.6, 3.7 and master branches. Thanks Oleksandr Buchkovskyi for the bug report! -- I looked at the Python 2.7 code and it doesn't look to be impacted by this bug.

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
New submission from STINNER Victor : For diversity reasons, it would be nice to try to avoid "master" and "slave" terminology which can be associated to slavery. For more context, see: * https://github.com/antirez/redis/issues/3185 * https://www.drupal.org/node/2275877 *

[issue34354] Memory leak on _testCongestion

2018-09-07 Thread Chih-Hsuan Yen
Change by Chih-Hsuan Yen : -- nosy: +yan12125 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34587] test_socket: testCongestion() hangs on my Fedora 28

2018-09-07 Thread Chih-Hsuan Yen
Change by Chih-Hsuan Yen : -- nosy: +yan12125 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34605] Avoid master/slave terminology

2018-09-07 Thread Ammar Askar
Ammar Askar added the comment: Do you have examples of where this occurs? >From >https://github.com/python/cpython/search?p=1=master+slave_q=master+slave > I really only found the openpty function, and the man pages/argument names >there already use this terminology so it wouldn't make

[issue34601] Typo: "which would rather raise MemoryError than give up", than or then?

2018-09-07 Thread Mark Dickinson
Mark Dickinson added the comment: See https://www.collinsdictionary.com/dictionary/english/would-rather for an example: > I have no information one way or the other, but I would rather he do it > than not do it. -- nosy: +mark.dickinson resolution: -> not a bug stage: -> resolved

[issue34605] Avoid master/slave terminology

2018-09-07 Thread Ammar Askar
Ammar Askar added the comment: The libregrtest change looks good but I disagree on the pty/openpty changes. If you look at all the current Linux man pages and documentation, they follow the master/slave terminology. Generally, Python documentation for underlying os functions like fork, stat

[issue34513] test_multiprocessing_spawn fails on x86 Windows7 3.7 buildbot

2018-09-07 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New failure on x86 Windows7 3.6 buildbot: https://buildbot.python.org/all/#/builders/90/builds/519/steps/3/logs/stdio -- ___ Python tracker

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: nntplib.NNTP() has a slave() method, but this method sends a "SLAVE" command to the NNTP server. Changing that would require to modify the NNTP protocol, that's out of the scope of this issue... RFC 977 "Network News Transfer Protocol" (NNTP) Section 3.12:

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: The doctest module has doctest.master symbol: --- # For backward compatibility, a global instance of a DocTestRunner # class, updated by testmod. master = None --- I'm not sure about changing this one. Here there is no slave, so it's less confusing. But

[issue34605] Avoid master/slave terminology

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: Tkinter and IDLE are full of "master" variables: master: parent for widgets. It seems to be a keep concept of Tkinter windows. -- ___ Python tracker

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-09-07 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +8549 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34586] collections.ChainMap should have a get_where method

2018-09-07 Thread Zahari Dim
Zahari Dim added the comment: > ISTM that this is the wrong stage to perform validation of allowable values. > That should occur upstream when the underlying mappings are first created. > At that earlier stage it possible to give a more timely response to erroneous > input and there is

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-09-07 Thread miss-islington
miss-islington added the comment: New changeset f862f3abaed59b83763707ae529f0fe487961ba9 by Miss Islington (bot) in branch '3.7': bpo-25750: fix refcounts in type_getattro() (GH-6118) https://github.com/python/cpython/commit/f862f3abaed59b83763707ae529f0fe487961ba9 -- nosy:

[issue34590] "Logging HOWTO" should share an example of best practices for using logging in a library

2018-09-07 Thread Raymond Hettinger
Raymond Hettinger added the comment: > Then we could establish the "gold standard" for logging and write > about it in the HOWTO. There really isn't a gold standard. There are many widely varied logging practices, each adapted to the needs of the application. The module is complicated

[issue34594] Some tests use hardcoded errno values

2018-09-07 Thread Zackery Spytz
Change by Zackery Spytz : -- pull_requests: +8551 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-09-07 Thread Armin Rigo
Change by Armin Rigo : -- nosy: -arigo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset 3ee07432f2e607cc6e7e6ea2d3695b672ceb1cea by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-25750: fix refcounts in type_getattro() (GH-6118) (GH-9088) https://github.com/python/cpython/commit/3ee07432f2e607cc6e7e6ea2d3695b672ceb1cea

[issue34586] collections.ChainMap should have a get_where method

2018-09-07 Thread Raymond Hettinger
Raymond Hettinger added the comment: > I would argue that all of the examples would benefit from error > checking done along the lines of the snippet above. ISTM that this is the wrong stage to perform validation of allowable values. That should occur upstream when the underlying mappings

[issue34590] "Logging HOWTO" should share an example of best practices for using logging in a library

2018-09-07 Thread pms.coder
pms.coder added the comment: I would be happy to see such HOWTO, so we could relay on actual documentation instead of the "Internet". I think the best approach would be to get those 10-20 questions you ( Nathaniel Manista) just asked and post them to python-dev mailing list, so senior

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: The bug has been fixed in 2.7, 3.6, 3.7 and master branches. Thanks Jeroen Demeyer for your tenacity and hard work :-) Let's see what we do with the unit test: PR 9084. -- ___ Python tracker

[issue25750] tp_descr_get(self, obj, type) is called without owning a reference to "self"

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: New changeset bf2bd8f8a1d88de60c114de957f50fe2433e3937 by Victor Stinner in branch '2.7': bpo-25750: fix refcounts in type_getattro() (GH-6118) (GH-9091) https://github.com/python/cpython/commit/bf2bd8f8a1d88de60c114de957f50fe2433e3937 --

[issue34594] Some tests use hardcoded errno values

2018-09-07 Thread Zackery Spytz
Change by Zackery Spytz : -- pull_requests: +8550 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34600] python3 regression ElementTree.iterparse() unable to capture comments

2018-09-07 Thread Martin Hosken
New submission from Martin Hosken : This is a regression from python2 by being forced to use cElementTree. I have code that uses iterparse to process an XML file, but I also want to process comments and so I have a comment handling function called by the parser during iterparse. Under

[issue34602] python3 resource.setrlimit strange behaviour under macOS

2018-09-07 Thread marche147
New submission from marche147 : Consider the following code: ``` import resource s, h = resource.getrlimit(resource.RLIMIT_STACK) resource.setrlimit(resource.RLIMIT_STACK, (h, h)) ``` Running this under macOS with python 3.6.5 gives the following exception: ``` bash-3.2$ uname -a Darwin

[issue34605] Avoid master/slave terminology

2018-09-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: Having said that, there are situations where words are used confusingly or inappropriately, and better choices are available. (I am sometimes confused, for instance, by the use of 'client' and 'server'.) In such situations, change can be justified without

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

2018-09-07 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.8 ___ Python tracker ___

[issue34486] "RuntimeError: release unlocked lock" when starting a thread

2018-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This looks similar to to problems with the "with" statement: see issue29988 and issue34067. Except that there is no a "with" statement, and resolving that issues will not solve this issue. -- ___ Python tracker

[issue34609] Idle Unitest

2018-09-07 Thread Terry J. Reedy
Terry J. Reedy added the comment: I cannot confirm this. I tested 3.6.6 on Windows 10 with tem3.py containing import unittest print unittest I ran this twice, without and with debug on. The output: RESTART: F:\Python\a\tem3.py >>> [DEBUG

[issue34546] Add encryption support to zipfile

2018-09-07 Thread Christian Heimes
Christian Heimes added the comment: -1 from me, too. Serhiy already made a valid point and suggested a better alternative. -- ___ Python tracker ___

[issue32055] Reconsider comparison chaining for containment tests

2018-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This had not been discussed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34606] Unable to read zip file with extra

2018-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The value of the extra attribute is not an arbitrary bytes object. It is a sequence of blocks in the following format: 16-bit identifier followed by 16-bit size of the block followed by the specified amount of bytes. Your example creates invalid ZIP file.

[issue34595] PyUnicode_FromFormat(): add %T format for an object type name

2018-09-07 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: IIRC there is similar issue or a discussion on one of mailing lists. But the idea about adding this feature on Python side too was considered. It would be better to find this discussion before pushing this change. In some cases we have the type itself,

[issue26544] platform.libc_ver() returns incorrect version number

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: > Thank you for merging PRs Victor, but seems you have merged wrong PR for 2.7. Oh. I didn't notice that there were two PRs for 2.7. Do you want to rebase your PR 9062 on 2.7, or revert the commit that I merged? It's up to you ;-) I reopen the issue. It

[issue30977] reduce uuid.UUID() memory footprint

2018-09-07 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +8560 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34606] Unable to read zip file with extra

2018-09-07 Thread Kyle Altendorf
Kyle Altendorf added the comment: Python 3.7 works with 2-byte elements, I managed to find the wrong section in the doc-linked docs. 4.5 Extensible data fields -- 4.5.1 In order to allow different programs and different types of information to

[issue34546] Add encryption support to zipfile

2018-09-07 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34606] Unable to read zip file with extra

2018-09-07 Thread Kyle Altendorf
Kyle Altendorf added the comment: Turns out the docs do document this. My apologies. https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT 4.3.11 Archive extra data record: archive extra data signature4 bytes (0x08064b50) extra field length 4

[issue28307] Accelerate 'string' % (value, ...) by using formatted string literals

2018-09-07 Thread Tal Einat
Tal Einat added the comment: I'm +1 on this optimization. -- nosy: +taleinat ___ Python tracker ___ ___ Python-bugs-list mailing

[issue33625] Release GIL for grp.getgr{nam, gid} and pwd.getpw{nam, uid}

2018-09-07 Thread STINNER Victor
STINNER Victor added the comment: I was waiting for the encoding fix to close this issue, but bpo-34604 has been created. -- ___ Python tracker ___

  1   2   >