[issue34580] sqlite doc: clarify the scope of the context manager

2018-09-08 Thread Daniel Jakots
Daniel Jakots added the comment: Thanks, I lacked the greater picture. Yes, adding a "con.close()" line to the snippet would clarify for me! -- ___ Python tracker ___

[issue34580] sqlite doc: clarify the scope of the context manager

2018-09-08 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the comments. I will add `con.close()` to the examples linked. Should I remove or change this line as per Daniel's comment "Note that this does not automatically call :meth:`close` on the connection object." Thanks -- Regards,

[issue31734] crash or SystemError in sqlite3.Cache in case it is uninitialized or partially initialized

2018-09-08 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34612] doc Some classes are treated as functions in Built-in Functions

2018-09-08 Thread Andrés Delfino
New submission from Andrés Delfino : Beyond other classes documented as functions (classmethod, enumerate, filter, map, reversed, staticmethod, super and zip), the following issues exist: * memoryview, range, and tuple are marked as functions * complex and object treat themselves as functions

[issue34608] gc.get_referrers behavior change 3.6 to 3.7

2018-09-08 Thread Xiang Zhang
Change by Xiang Zhang : -- nosy: +inada.naoki, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34580] sqlite doc: clarify the scope of the context manager

2018-09-08 Thread Berker Peksag
Berker Peksag added the comment: We always explicitly document what the context manager does even if it simply calls an object's close() method. See https://docs.python.org/3/library/fileinput.html#fileinput.input and https://docs.python.org/3/library/shelve.html#shelve.Shelf for example.

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Stefan Krah
Stefan Krah added the comment: Trying to remove myself from the nosy list again (I know that the interface sometimes surprisingly adds/removes persons). -- ___ Python tracker

[issue34580] sqlite doc: clarify the scope of the context manager

2018-09-08 Thread Berker Peksag
Berker Peksag added the comment: PR 9079 looks good to me. I think we can use this as an opportunity to make the rest of the examples in the sqlite3 documentation more consistent and add missing "conn.close()" calls. -- ___ Python tracker

[issue34588] traceback formatting can drop a frame

2018-09-08 Thread Benjamin Peterson
Benjamin Peterson added the comment: It actually does save space because each traceback entry is usually two lines (frame id and source snippet). I don't really have an opinion about what should happen be printed on the boundary cases. My current PR seems like a strict improvement to the

[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'

2018-09-08 Thread Leo Singer
Leo Singer added the comment: I just hit this bug. Would the proposed patch get any more attention if submitted as a pull request? -- nosy: +Leo Singer ___ Python tracker

[issue31652] make install fails: no module _ctypes

2018-09-08 Thread David Spahn
David Spahn added the comment: I'm getting the same error File "/usr/src/Python-3.7.0/Lib/ctypes/__init__.py", line 7, in from _ctypes import Union, Structure, Array ModuleNotFoundError: No module named '_ctypes' Makefile:1122: recipe for target 'install' failed make: *** [install]

[issue34421] Cannot install package with unicode module names on Windows

2018-09-08 Thread Éric Araujo
Change by Éric Araujo : -- assignee: -> eric.araujo resolution: -> fixed stage: patch review -> commit review status: open -> pending type: crash -> behavior versions: +Python 3.7, Python 3.8 ___ Python tracker

[issue34421] Cannot install package with unicode module names on Windows

2018-09-08 Thread miss-islington
miss-islington added the comment: New changeset 77b92b15a5e5c84b91d3fd9d02f63db432fa8903 by Miss Islington (bot) in branch '3.7': bpo-34421 avoid unicode error in distutils logging (GH-8799) https://github.com/python/cpython/commit/77b92b15a5e5c84b91d3fd9d02f63db432fa8903 --

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Stefan Krah
Change by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20178] Derby #9: Convert 52 sites to Argument Clinic across 11 files

2018-09-08 Thread Berker Peksag
Berker Peksag added the comment: I'm working on converting Modules/_sqlite/* to Argument Clinic. -- nosy: +berker.peksag versions: +Python 3.8 -Python 3.5 ___ Python tracker

[issue34580] sqlite doc: clarify the scope of the context manager

2018-09-08 Thread Daniel Jakots
Daniel Jakots added the comment: Yes, I would totally support this move as it would show users that it's important to close it! -- ___ Python tracker ___

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Matej Cepl
Change by Matej Cepl : -- nosy: -mcepl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34596] [unittest] raise error if @skip is used with an argument that looks like a test method

2018-09-08 Thread Zachary Ware
Zachary Ware added the comment: I don't agree that this change makes the implementation significantly more cumbersome. I also think there's a backward compatibility argument to be made for allowing the uncalled usage, particularly considering the OP's published example and other similar

[issue34580] sqlite doc: clarify the scope of the context manager

2018-09-08 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks, I have pushed a change adding `con.close` at the end of the example and also verified that `./python.exe Doc/includes/sqlite3/ctx_manager.py` works as expected. Thanks -- ___ Python tracker

[issue34546] Add encryption support to zipfile

2018-09-08 Thread 大野隆弘
大野隆弘 added the comment: My original reason of this is supporting Windows Explore decryption. That doesn't support AES but support only this traditional PKWARE encryption. In my work, some recipients who received the zip file cannot install 3rd party tools on their Windows

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Berker Peksag
Berker Peksag added the comment: Personally, I find parent/child more descriptive if it can be used in the same context with master/slave, so I'm in favor of replacing master/slave with parent/child where applicable. However, I agree that the code changes in PR 9100 are a bit excessive. It

[issue34421] Cannot install package with unicode module names on Windows

2018-09-08 Thread miss-islington
Change by miss-islington : -- pull_requests: +8570 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34421] Cannot install package with unicode module names on Windows

2018-09-08 Thread Éric Araujo
Éric Araujo added the comment: New changeset 0afada163c7ef25c3a9d46ed445481fb69f2ecaf by Éric Araujo (Julien Malard) in branch 'master': bpo-34421 avoid unicode error in distutils logging (GH-8799) https://github.com/python/cpython/commit/0afada163c7ef25c3a9d46ed445481fb69f2ecaf --

[issue34421] Cannot install package with unicode module names on Windows

2018-09-08 Thread miss-islington
Change by miss-islington : -- pull_requests: +8571 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34612] doc Some classes are treated as functions in Built-in Functions

2018-09-08 Thread Eric V. Smith
Eric V. Smith added the comment: I'm not sure this is an improvement. While it's true that 'complex' is a class, it's described here as a function. Same as 'int'. The fact that it's a function or class isn't so important here. I suspect it will confuse people to have something described as

[issue34612] doc Some classes are treated as functions in Built-in Functions

2018-09-08 Thread Andrés Delfino
Andrés Delfino added the comment: Please note that several classes are marked as such (e.g., int, float, str, dict, list) and bool for example treats itself as a class in it's description. Perhaps your concerns applies to all those ocurrences too? --

[issue34612] doc Some classes are treated as functions in Built-in Functions

2018-09-08 Thread Raymond Hettinger
Raymond Hettinger added the comment: I concur with Eric. These were marked as functions in the function section of the docs. Their role as classes is noted in the body. And their role as complete classes with a listing of their methods is documented elsewhere. -- nosy:

[issue34611] some examples in 'itertools' modules docs are inaccuracy.

2018-09-08 Thread taketakeyyy
Change by taketakeyyy : -- keywords: +patch pull_requests: +8573 stage: -> patch review ___ Python tracker ___ ___

[issue34580] sqlite doc: clarify the scope of the context manager

2018-09-08 Thread Berker Peksag
Berker Peksag added the comment: > Should I remove or change this line as per Daniel's comment "Note that > this does not automatically call :meth:`close` on the connection object." I'd prefer to keep the current wording as-is. -- ___ Python

[issue34580] sqlite doc: clarify the scope of the context manager

2018-09-08 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Sounds good to me too since I copy paste from there time to time and also an unclosed connection doesn't seem to trigger a ResourceWarning it seems. I have pushed a commit to the same PR. I have changed it manually for all the include files. I

[issue34421] Cannot install package with unicode module names on Windows

2018-09-08 Thread miss-islington
miss-islington added the comment: New changeset 3b36642924a51e6bceb7033916c3049764817166 by Miss Islington (bot) in branch '3.6': bpo-34421 avoid unicode error in distutils logging (GH-8799) https://github.com/python/cpython/commit/3b36642924a51e6bceb7033916c3049764817166 -- nosy:

[issue34612] doc Some classes are treated as functions in Built-in Functions

2018-09-08 Thread Andrés Delfino
Change by Andrés Delfino : -- keywords: +patch pull_requests: +8572 stage: -> patch review ___ Python tracker ___ ___

[issue28879] smtplib send_message should add Date header if it is missing, per RFC5322

2018-09-08 Thread Jens Troeger
Jens Troeger added the comment: Any updates on this? Looks like the proposed change has not been merged into mainstream yet? I’m having problems with Google rejecting emails: (555, b'5.5.2 Syntax error, goodbye. r10-v6sm7321838qtj.41 - gsmtp', '…') and using IETF’s message linter

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Raymond Hettinger
Raymond Hettinger added the comment: Mostly, I don't think these changes should be made, particularly in cases where "slave" isn't mentioned at all. The word "master" is used in many contexts where master/slave doesn't apply (such as "master key"). Also, I think the PR disrespects all

[issue34611] some examples in 'itertools' modules docs are inaccuracy.

2018-09-08 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I don't know if it's worth it to edit the results to return Python data structures in the linked PR. The current version is more concise and indicates the general result of the function instead of the actual return values of the function calls

[issue34612] doc Some classes are treated as functions in Built-in Functions

2018-09-08 Thread Eric V. Smith
Eric V. Smith added the comment: Ah, you're correct. I just looked for the word "class" inside the "int" text, and it doesn't appear there: I thought it was deliberately left out. But it does show up in the sub-section header (before "int" itself). Sorry about that. The text changes look

[issue34608] gc.get_referrers behavior change 3.6 to 3.7

2018-09-08 Thread Benjamin Peterson
Benjamin Peterson added the comment: Likely fallout from 5a625d0aa6a6d9ec6574ee8344b41d63dcb9897e. get_referrers() doesn't really guarantee anything. It's more of a clever hack based on however the Python GC works at the moment. So, this it probably WONTFIX. -- nosy:

[issue34611] some examples in 'itertools' modules docs are inaccuracy.

2018-09-08 Thread taketakeyyy
Change by taketakeyyy : -- assignee: docs@python components: Documentation nosy: docs@python, taketake...@gmail.com priority: normal severity: normal status: open title: some examples in 'itertools' modules docs are inaccuracy. versions: Python 3.8

[issue34611] some examples in 'itertools' modules docs are inaccuracy.

2018-09-08 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- assignee: docs@python -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list

[issue34595] PyUnicode_FromFormat(): add %T format for an object type name

2018-09-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think we need to handle only two cases: short and fully qualified names. __qualname__ without __module__ doesn't make sense, and the value of tp_name depends on implementation details (is it Python class or builtin class, heap class or dynamic class?).

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

2018-09-08 Thread miss-islington
Change by miss-islington : -- pull_requests: +8569 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

2018-09-08 Thread miss-islington
Change by miss-islington : -- pull_requests: +8568 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22807] uuid.uuid1() should use uuid_generate_time_safe() if available

2018-09-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This breaks pickle compatibility. UUIDs pickled in 3.7 can't be unpickled in older Python versions because they do not have the SafeUUID class. See issue30977 for possible solution. -- nosy: +serhiy.storchaka, taleinat

[issue34611] some examples in 'itertools' modules docs are inaccuracy.

2018-09-08 Thread Mark Dickinson
New submission from Mark Dickinson : @taketakeyyy: Did you mean to include information about *which* examples are inaccurate? This issue isn't really useful without that information. -- nosy: +mark.dickinson ___ Python tracker

[issue34604] Possible mojibake in pwd.getpwnam and grp.getgrnam

2018-09-08 Thread William Grzybowski
William Grzybowski added the comment: What is the policy to amend a new commit to master for %R? Create a new PR? Wont that cause problem with NEWS entry? -- ___ Python tracker

[issue20104] expose posix_spawn(p)

2018-09-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset d700f97b627989d41cd4629dc02969f9a6b56d2f by Serhiy Storchaka in branch 'master': bpo-20104: Change the file_actions parameter of os.posix_spawn(). (GH-6725) https://github.com/python/cpython/commit/d700f97b627989d41cd4629dc02969f9a6b56d2f

[issue20104] expose posix_spawn(p)

2018-09-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your contribution Pablo. This issue have appeared much more complex and less obvious than it looked initially. -- ___ Python tracker

[issue34586] collections.ChainMap should have a get_where method

2018-09-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I concur with Raymond. The purpose of ChainMap is providing a mapping that hides the implementation detail of using several mappings as fallbacks. If you don't want to hide the implementation detail, you don't need to use ChainMap. ChainMap exposes

[issue34600] python3 regression ElementTree.iterparse() unable to capture comments

2018-09-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > But the C version XMLParser requires that its TreeBuilder not be a subclass, > when used in iterparse. Creating a TreeBuilder subclass looks the Right Way. What are problems with this? Could you please provide a complete script that works in 2.7, but

[issue34596] [unittest] raise error if @skip is used with an argument that looks like a test method

2018-09-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It doesn't look like a good design to me if allow a function be a decorator and a decorator fabric at the same time. It always lead to cumbersome and errorprone implementation. Currently there is only one example of such design in the stdlib, other

[issue34600] python3 regression ElementTree.iterparse() unable to capture comments

2018-09-08 Thread Stefan Behnel
Stefan Behnel added the comment: There are dedicated handler methods that you can implement: "def comment(self, comment)" and "def pi(self, target, data)". Both (c)ElementTree and lxml support those. I think the "target" argument to the parser is a bit underdocumented, and the standard

[issue34574] OrderedDict iterators are exhausted during pickling

2018-09-08 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list

[issue34580] sqlite doc: clarify the scope of the context manager

2018-09-08 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- assignee: docs@python -> berker.peksag nosy: +berker.peksag, ghaering ___ Python tracker ___ ___

[issue34610] Incorrect iteration of Manager.dict() method of the multiprocessing module.

2018-09-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: DictProxy needs to provide the __iter__() method. And perhaps methods keys(), values() and items() need to be reworked in Python 3. has_key() is unneeded in Python 3. It is worth to test also other special and new in Python 3 methods. -- nosy:

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Gabriel Marko
Gabriel Marko added the comment: @vstinner: > For diversity reasons, it would be nice to try to avoid "master" and "slave" > terminology which can be associated to slavery. This is too vague. Define what "diversity reasons" are and elaborate your point. Referring to some online discussions

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Matej Cepl
Matej Cepl added the comment: Guys, really, don't we have anything better to do with your time than this silliness? Even if the terminology would be used in the strictest and most brutal meaning, i.e., slave must mindlessly follow orders of its master, there is nothing of approval of the

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Gabriel Marko
Gabriel Marko added the comment: @mcepl: I completely agree with you that we shouldn't waste time with this. I would be better not to dig into the discussion about "master-slave" terminology. IMO we don't even need to go into that as the problem here is more substantial: This case can

[issue34597] Python needs to check existence of functions at runtime for targeting older macOS platforms

2018-09-08 Thread Christoph Reiter
Christoph Reiter added the comment: related: issue31359 -- nosy: +lazka ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34610] Incorrect iteration of Manager.dict() method of the multiprocessing module.

2018-09-08 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +8567 stage: -> patch review ___ Python tracker ___ ___

[issue34588] traceback formatting can drop a frame

2018-09-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In case of 4 repeated lines it doesn't make much sense to output 3 repeated lines and replace the forth line with "Previous line repeated 1 more time". This doesn't save space and doesn't help reading the traceback. I think it is better to output the

[issue34595] PyUnicode_FromFormat(): add %T format for an object type name

2018-09-08 Thread STINNER Victor
STINNER Victor added the comment: An alternative would be to add multiple formatters. Example: * %Tn: type name, type.__name__, Py_TYPE(obj)->tp_name * %Tq: qualified name, type.__qualname__ * %Ts: short name, never contains "." * %Tf: fully qualified name, "module.qualified.name" What do

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Eric V. Smith
Change by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34602] python3 resource.setrlimit strange behaviour under macOS

2018-09-08 Thread marche147
marche147 added the comment: Thanks for the repro! It did help for pinpointing the issue. So I took a little spare time and dived into xnu kernel code, here is my assumption based on what I found (N.B. : My assumption comes from a simple experiment and a brief skim of the source code within

[issue34610] Incorrect iteration of Manager.dict() method of the multiprocessing module.

2018-09-08 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +davin, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Cheryl Sabella
Cheryl Sabella added the comment: This is certainly a topic that generates a lot of opinions both ways, not just here, but on many other projects. Based on that, I don't think it's fair to blame Victor for bringing it up for discussion. This is and has been an industry discussion for many

[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL

2018-09-08 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I take this. -- assignee: -> serhiy.storchaka nosy: +serhiy.storchaka ___ Python tracker ___

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Ammar Askar
Ammar Askar added the comment: Most of the opposition seems to be against a blanket replacing of all master and slave usages, which seems fairly reasonable to me. For example, I'm all for the libregrtest change since it conveys the meaning just as well and is an internal tool. However,

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Stefan Krah
Change by Stefan Krah : -- nosy: -skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Stefan Krah
Stefan Krah added the comment: I commented here to explain the master <-> view terminology of memoryview. If anyone wants to change that, please open a separate issue and add me as the author to the nosy list. -- ___ Python tracker

[issue34586] collections.ChainMap should have a get_where method

2018-09-08 Thread Zahari Dim
Zahari Dim added the comment: On Sat, Sep 8, 2018 at 1:15 PM Serhiy Storchaka wrote: > > > Serhiy Storchaka added the comment: > > I concur with Raymond. The purpose of ChainMap is providing a mapping that > hides the implementation detail of using several mappings as fallbacks. If > you

[issue34605] Avoid master/slave terminology

2018-09-08 Thread Gabriel Marko
Gabriel Marko added the comment: @cheryl.sabella let me challenge some points in your arguments: > Based on that, I don't think it's fair to blame Victor for bringing it up for > discussion. Ok, but where was the discussion? @vstinner didn't even make a point and some of the PRs were

[issue34580] sqlite doc: clarify the scope of the context manager

2018-09-08 Thread Daniel Jakots
Daniel Jakots added the comment: Thanks for working on this bug! My message focussed on the closing aspect because that was my problem. :) Maybe the wording should be more general like: - "Note that this does not automatically call :meth:`close` on the connection object." + "Note that this