[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

Pablo Galindo Salgado added the comment: I am playing with passing weakreferences into the iterator objects, but this may not be enough. For example, take the code of ApplyResult.get: def get(self, timeout=None): if self._pool() is None: raise RuntimeError("The pool is dead!")

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg331441 ___ Python tracker ___ ___ Python-bugs-list

[issue27004] Handle script shbang options

Miro Hrončok added the comment: As a distro Python maintainer, I have to say that having yet another Python executable would no be accepted well by the other distro contributors or even users. I'll try to work on a proper solution that would merge the options, hopefully soon (but most

[issue22005] datetime.__setstate__ fails decoding python2 pickle

Gregory P. Smith added the comment: It is fundamentally impossible for pickled data to magically cross the 2 and 3 language boundary unscathed. The basic str/bytes/unicode types in the language changed meaning. Code must be written manually by the data owners to fix that up based on what

[issue33725] Python crashes on macOS after fork with no exec

Davin Potts added the comment: Do we really need to disable the running of test_multiprocessing_fork entirely on MacOS? My understanding so far is that not *all* of the system libraries on the mac are spinning up threads and so we should expect that there are situations where fork alone

[issue35448] ConfigParser .read() - handling of nonexistent files

New submission from Adrian Wielgosik : Documentation of ConfigParser says: > If a file named in filenames cannot be opened, that file will be ignored. > This is designed so that you can specify an iterable of potential > configuration file locations (for example, the current directory, the

[issue22005] datetime.__setstate__ fails decoding python2 pickle

Gregory P. Smith added the comment: New changeset e328753d91379274b699b93decff45de07854617 by Gregory P. Smith in branch 'master': bpo-22005: Document the reality of pickle compatibility. (GH-11054) https://github.com/python/cpython/commit/e328753d91379274b699b93decff45de07854617

[issue20239] Allow repeated deletion of unittest.mock.Mock attributes

Karthikeyan Singaravelan added the comment: I find this to be a reasonable behavior as with normal objects that support setting the attribute after deletion. It also seems to be an easy issue since @michael.foord has already attached the patch for this from the original report. The patch

[issue22577] local variable changes lost after pdb jump command

Change by Henry Chen : -- nosy: +henry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22005] datetime.__setstate__ fails decoding python2 pickle

miss-islington added the comment: New changeset 331bfa4f2c3026a35e111303df0f198d06b4e0c8 by Miss Islington (bot) in branch '3.7': bpo-22005: Document the reality of pickle compatibility. (GH-11054) https://github.com/python/cpython/commit/331bfa4f2c3026a35e111303df0f198d06b4e0c8 --

[issue35447] Redundant try-except block in urllib

Change by Shishmarev Pavel : -- keywords: +patch pull_requests: +10287 stage: -> patch review ___ Python tracker ___ ___

[issue35448] ConfigParser .read() - handling of nonexistent files

Change by Karthikeyan Singaravelan : -- nosy: +lukasz.langa ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35447] Redundant try-except block in urllib

New submission from Shishmarev Pavel : https://github.com/python/cpython/blob/master/Lib/urllib/parse.py#L875 It's redundant to raise and then catch exception. -- components: Library (Lib) messages: 331436 nosy: PashaWNN priority: normal severity: normal status: open title: Redundant

[issue35433] Correctly detect installed SDK versions

Jeremy Kloth added the comment: Sorry for the delay, but I wanted to get an environment that still had an older VS2015 install to test against. VS2015 prior to Update 3 use a different heuristic to determine the SDK version for building. I've made the following changes: - version checking

[issue35447] Redundant try-except block in urllib

Change by Shishmarev Pavel : -- pull_requests: +10288 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35449] documenting objects

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22005] datetime.__setstate__ fails decoding python2 pickle

Change by miss-islington : -- pull_requests: +10290 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22005] datetime.__setstate__ fails decoding python2 pickle

Change by Gregory P. Smith : -- pull_requests: +10289 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22005] datetime.__setstate__ fails decoding python2 pickle

Gregory P. Smith added the comment: Serhiy: should this one be marked fixed? -- assignee: -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker ___

[issue22005] datetime.__setstate__ fails decoding python2 pickle

Serhiy Storchaka added the comment: With Gregory's addition I think this issue can be considered fixed. Thank you Gregory. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

tzickel added the comment: https://bugs.python.org/issue35267 -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23864] issubclass without registration only works for "one-trick pony" collections ABCs.

Géry added the comment: Guido, could we add those missing __subclasshook__ for consistency? -- nosy: +gvanrossum, maggyero ___ Python tracker ___

[issue33725] Python crashes on macOS after fork with no exec

Barry A. Warsaw added the comment: I think it make sense to disable this test; the only possible modification would be to only disable it for macOS <= 10.13. AFAIK, that's the first version where core dumps were possible. (Aside: I also saw these core dumps for a long time on 10.13 and

[issue35433] Correctly detect installed SDK versions

Steve Dower added the comment: New changeset f46eccd0ffe65333035c3820886295b71c41ab6e by Steve Dower (Jeremy Kloth) in branch 'master': bpo-35433: Properly detect installed SDK versions (GH-11009) https://github.com/python/cpython/commit/f46eccd0ffe65333035c3820886295b71c41ab6e --

[issue35433] Correctly detect installed SDK versions

Change by miss-islington : -- pull_requests: +10292 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35447] Redundant try-except block in urllib

Martin Panter added the comment: Code in question: try: # non-sequence items should not work with len() # non-empty strings will fail this if len(query) and not isinstance(query[0], tuple): raise TypeError # [. . .] except TypeError: ty, va, tb = sys.exc_info()

[issue35449] documenting objects

Stefan Seefeld added the comment: Exactly ! I'm fully aware of the ubiquity of objects in Python, and it is for that reason that I had naively expected `pydoc` to simply DoTheRightThing when encountering an object containing a `__doc__` attribute. rather than only working for types and

[issue35449] documenting objects

Stefan Seefeld added the comment: On 2018-12-09 18:35, Steven D'Aprano wrote: > Steven D'Aprano added the comment: > >> Is there any discussion concerning what syntax might be used for >> docstrings associated with objects ? > I don't know about PyDoc in general, but I would expect help(obj)

[issue35449] documenting objects

Steven D'Aprano added the comment: > Is there any discussion concerning what syntax might be used for > docstrings associated with objects ? I don't know about PyDoc in general, but I would expect help(obj) to just use obj.__doc__ which will return the instance docstring if it exists, and

[issue35433] Correctly detect installed SDK versions

Steve Dower added the comment: Thanks for being thorough. I've merged the change now. -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue35433] Correctly detect installed SDK versions

Change by Steve Dower : -- pull_requests: +10293 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20239] Allow repeated deletion of unittest.mock.Mock attributes

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +10291 stage: needs patch -> patch review ___ Python tracker ___

[issue35449] documenting objects

Steven D'Aprano added the comment: Minor note on terminology: classes and functions are themselves objects. I think that help() (or in particular PyDoc in general) should support any instance with a __doc__ attribute. Its failure to do so is causing pain, see #12154. -- nosy:

[issue35122] Process not exiting on unhandled exception when using multiprocessing module

Change by Pablo Galindo Salgado : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___

[issue35449] documenting objects

Karthikeyan Singaravelan added the comment: There was a related proposal in https://www.python.org/dev/peps/pep-0258/#attribute-docstrings -- ___ Python tracker ___

[issue23864] issubclass without registration only works for "one-trick pony" collections ABCs.

Guido van Rossum added the comment: No, I consider this is a documentation problem. I don't recall why the docs say that (I don't even know if they still say that or whether Martijn misread them), but IMO this should not be changed. -- ___ Python

[issue35449] documenting objects

Stefan Seefeld added the comment: On 2018-12-09 19:48, Karthikeyan Singaravelan wrote: > There was a related proposal in > https://www.python.org/dev/peps/pep-0258/#attribute-docstrings Right, but that was rejected (for unrelated reasons). The idea itself was rejected by Guido

[issue35447] Redundant try-except block in urllib

Shishmarev Pavel added the comment: https://github.com/python/cpython/blob/master/Lib/urllib/parse.py#L875 It's redundant to raise and then catch exception. I mean: if len(query) and not isinstance(query[0], tuple): ty, va, tb = sys.exc_info() raise TypeError("not a valid non-string

[issue35433] Correctly detect installed SDK versions

Steve Dower added the comment: Not making this change for Python 3.6, as that apparently breaks with the latest SDK (seen in the Pipelines build). So we'll leave 10.0.15063.0 as the maximum version for that - it's about to go into security mode anyway, and we don't rely on anything from the

[issue35433] Correctly detect installed SDK versions

miss-islington added the comment: New changeset c83ec055a09137e4b24f70e3bb5f887dc0ae6e8e by Miss Islington (bot) in branch '3.7': bpo-35433: Properly detect installed SDK versions (GH-11009) https://github.com/python/cpython/commit/c83ec055a09137e4b24f70e3bb5f887dc0ae6e8e -- nosy:

[issue35447] Redundant try-except block in urllib

Martin Panter added the comment: That would not include the custom error message for the first two cases I listed. I suggest closing this. -- ___ Python tracker ___

[issue33779] Error while installing python 3.6.5 on windows 10

BobClown added the comment: An addition to the record, as Google returns this issue as one of the top results for "python install \"Error 0x80070005: Failed to register bundle.\"": In my case, I had removed access for all users on the HKCU/RunOnce key and was getting this error. The

[issue33779] Error while installing python 3.6.5 on windows 10

Steve Dower added the comment: Thanks for the extra info! I think the registration is put in there during install in case the PC restarts part way through, but it doesn't have to hang around after install is complete. Your explanation makes sense, and is a good reason to disable antivirus

[issue35433] Correctly detect installed SDK versions

Change by Jeremy Kloth : -- pull_requests: +10294 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35433] Correctly detect installed SDK versions

Jeremy Kloth added the comment: I've added a PR for 3.6 using a different methodology for finding the available SDK. Without some change, my buildbot will continue to stay in the red (for 3.6). It does not the the highest SDK currently (previously?) listed the hard-coded list. It has the

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

Change by Andrew Tennikoff : -- nosy: +atenni ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35257] Avoid leaking linker flags into distutils.

Ned Deily added the comment: > Unfortunately, it appears this won't be resolved in time for 3.7.2rc1 and > 3.6.8rc1 An update: the cutoff for these releases has been extended until about 30 hours from now so there is perhaps a small chance that the PR for this could still be updated,

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

Karthikeyan Singaravelan added the comment: Thanks @nekobon for the patch. I am triaging old mock related issues. I think dict insertion order is maintained from 3.6 and guaranteed with 3.7 and above. But it would be good to add the unit test in the patch as a PR. I ran the test on master

[issue33725] Python crashes on macOS after fork with no exec

Davin Potts added the comment: @ned.deily: Apologies, I misread what you wrote -- I would like to see the random segfaults that you were seeing on Mojave if you can still point me to a few. -- ___ Python tracker

[issue34079] Multiprocessing module fails to build on Solaris 11.3

Clint Allen added the comment: Agreed, that is a better approach. I have tested your patch successfully with gcc on Solaris 11.3. -- ___ Python tracker ___

[issue35449] documenting objects

New submission from Stefan Seefeld : On multiple occasions I have wanted to add documentation not only to Python classes and functions, but also instance variables. This seems to involve (at least) two orthogonal questions: 1) what is the proper syntax to associate documentation (docstrings

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

Pablo Galindo Salgado added the comment: I am playing with weakreferences inside the iterator objects, but this may not be enough. For example, take the code of ApplyResult.get: def get(self, timeout=None): if self._pool() is None: raise RuntimeError("The pool is dead!") <--- new

[issue35378] multiprocessing.Pool.imaps iterators do not maintain alive the multiprocessing.Pool objects

Pablo Galindo Salgado added the comment: Also, making tests that do not leak threads for this case is very difficult as if we go with weakrefs, the test *has* to leak a pool (the pool is dead but never calls join/close) to check that when you use the iterator the exception happens. Also,

[issue35450] venv module doesn't create a copy of python binary by default

New submission from Marcin : Hello, from documentation: https://docs.python.org/3/library/venv.html "python3 -m venv /path/to/new/virtual/environment Running this command creates the target directory (creating any parent directories that don’t exist already) and places a pyvenv.cfg file in it

[issue35450] venv module doesn't create a copy of python binary by default

Change by Ned Deily : -- nosy: +vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28015] configure --with-lto builds fail when CC=clang on Linux, requires gold linker

Ned Deily added the comment: New changeset f83ee476d48dbeb90ddf3526b04936a49a87973a by Ned Deily (stratakis) in branch '3.6': bpo-28015: Support LTO build with clang (GH-9908) (GH-10922) https://github.com/python/cpython/commit/f83ee476d48dbeb90ddf3526b04936a49a87973a -- nosy:

[issue28015] configure --with-lto builds fail when CC=clang on Linux, requires gold linker

Ned Deily added the comment: See also Issue31354, Issue35351, and Issue35257. -- versions: +Python 3.6 ___ Python tracker ___ ___

[issue35351] LTOFLAGS are passed to BASECFLAGS when using LTO

Change by miss-islington : -- pull_requests: +10282 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35351] LTOFLAGS are passed to BASECFLAGS when using LTO

miss-islington added the comment: New changeset f2d2cb12f2d3bd68a13c4098311e725f776768ad by Miss Islington (bot) in branch '3.6': bpo-35351: Pass link time optimization flags to CFLAGS_NODIST (GH-10797) https://github.com/python/cpython/commit/f2d2cb12f2d3bd68a13c4098311e725f776768ad

[issue35351] LTOFLAGS are passed to BASECFLAGS when using LTO

Ned Deily added the comment: See also Issue28015, Issue31354, and Issue35257. -- nosy: +ned.deily resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker

[issue31354] Fixing a bug related to LTO only build

Ned Deily added the comment: OK, I think we are in better shape for 3.6.8 now. I've merged the backports to 3.6 of Issue28015 / PR 9908 (LTO with clang) and Issue35351 / PR 10797 (prevent LTO CFLAGS leakage into distutils). So, at the moment, master, 3.7, and 3.6 should behave the same in

[issue35257] Avoid leaking linker flags into distutils.

Ned Deily added the comment: Unfortunately, it appears this won't be resolved in time for 3.7.2rc1 and 3.6.8rc1 and it would not be appropriate to merge something this potentially disruptive without prior exposure. Since 3.6.8 is planned to be the final 3.6.x bugfix release, unless some

[issue35443] Add Tail Call Optimization

New submission from Muhammed Alkan : I see nothing wrong with adding Tail Call Optimization to Python. -- messages: 331420 nosy: midnio priority: normal severity: normal status: open title: Add Tail Call Optimization type: enhancement versions: Python 3.8

[issue22005] datetime.__setstate__ fails decoding python2 pickle

Christian Tanzer added the comment: Paul Ganssle wrote at Fri, 07 Dec 2018 17:22:36 +: > > Gregory P. Smith (gregory.p.smith) 2017-03-02 18:57 > > TL;DR - Just one more example of why nobody should *ever* use pickle > > under any circumstances. It is useless for data that is not

[issue35443] Add Tail Call Optimization

Steven D'Aprano added the comment: > I see nothing wrong with adding Tail Call Optimization to Python. That's nice. Is that supposed to be an argument that convinces us? You are hardly the first person ever to suggest TCO for Python:

[issue35443] Add Tail Call Optimization

Karthikeyan Singaravelan added the comment: Guido had some thoughts on Tail Recursion Optimization (TRE). http://neopythonic.blogspot.com/2009/04/tail-recursion-elimination.html -- nosy: +xtreak ___ Python tracker

[issue35444] Unify and optimize the helper for getting a builtin object

New submission from Serhiy Storchaka : _PyIter_GetBuiltin() was introduced in issue14288 (31668b8f7a3efc7b17511bb08525b28e8ff5f23a). This was used for getting references to the builtin "iter" and "reverse". It was renamed to _PyObject_GetBuiltin() in a701388de1135241b5a8e4c970e06c0e83a66dc0.

[issue35444] Unify and optimize the helper for getting a builtin object

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +10283 stage: -> patch review ___ Python tracker ___ ___

[issue17185] unittest mock create_autospec doesn't correctly replace mocksignature

Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +10284 stage: -> patch review ___ Python tracker ___ ___

[issue35443] Add Tail Call Optimization

Change by Muhammed Alkan : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue35337] Check index in PyTuple_GET_ITEM/PyTuple_SET_ITEM in debug mode

Stefan Krah added the comment: I'm using _GET_ITEM(args, 0), so Serhiy's concern is not theoretical. I think if people want the safe version they should use PyTuple_GetItem(). -- nosy: +skrah ___ Python tracker

[issue20602] sys.flags and sys.float_info disappear at shutdown

Zackery Spytz added the comment: Ping. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35445] Do not ignore errors when create posix.environ

New submission from Serhiy Storchaka : Currently most errors during creating posix.environ are ignored except an error of creating an empty dict. The initial revision 85a5fbbdfea617f6cc8fae82c9e8c2b5c424436d contained the comment "XXX This part ignores errors". Later changes removed "XXX"

[issue35446] incorrect example

New submission from Alistsair Lenhard : under: https://docs.python.org/3/tutorial/errors.html Original it says: "Note that if the except clauses were reversed (with except B first), it would have printed B, B, B — the first matching except clause is triggered." It should read: "Note that if

[issue35445] Do not ignore errors when create posix.environ

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +10285 stage: -> patch review ___ Python tracker ___ ___

[issue35337] Check index in PyTuple_GET_ITEM/PyTuple_SET_ITEM in debug mode

Stefan Krah added the comment: Since this feature mainly helps when running a test suite using a debug build: The same can be achieved by running the test suite under Valgrind, which catches invalid accesses and a lot more. So I'd prefer to keep the macro in its current form. --

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

Karthikeyan Singaravelan added the comment: Thanks @asottile for the patch. I think the original AttributeError is resolved with issue28919 where they were silenced. It seems similar to issue32153 though the exception occurs from mock instead of partial object as in issue32153. The fix was

[issue35337] Check index in PyTuple_GET_ITEM/PyTuple_SET_ITEM in debug mode

Stefan Krah added the comment: If the feature is for the Python test suite itself, one solution would be to add -DPY_BOUNDS_CHECKS and use that on the buildbots. I still think making all of the test suite Valgrind-ready (most of it is, except test_multiprocessing and a few others) would

[issue17088] ElementTree incorrectly refuses to write attributes without namespaces when default_namespace is used

Change by Maarten ter Huurne : -- pull_requests: +10286 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing

[issue17088] ElementTree incorrectly refuses to write attributes without namespaces when default_namespace is used

Maarten ter Huurne added the comment: I think I have a good solution now, see the pull request for details. It does touch a lot of code, but I split all the changes into small consistent units, so it should be easier to verify whether they are correct. --

[issue28054] Diff for visually comparing actual with expected in mock.assert_called_with.

Karthikeyan Singaravelan added the comment: It seems that TestCase in unittest.case accepts failureException attribute that is raised on assertion failure. My initial approach is to subclass TestCase and add a custom failure exception like MockException that is caught to add the diff to the