[issue35634] kwargs regression when there are multiple entries with the same key

2019-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ammar is right. This is a consequence of issue27358. Issue27358 was merely an optimization necessary for bytecode changes in 3.6. It was not noticed that it changes also the behavior for multidict kwargs. But I think that it was correct change. Specifying

[issue35633] test_eintr: test_lockf() fails with "PermissionError: [Errno 13] Permission denied" on AIX

2019-01-05 Thread Michael Felt
Michael Felt added the comment: I had tried “wb+”, not “w+b”. Is there a difference? I forget if I tried just “w+”. But I’ll do them anyway/again to be sure. Sent from my iPhone > On 4 Jan 2019, at 23:43, STINNER Victor wrote: > > > Change by STINNER Victor : > > > -- >

[issue35662] Windows #define _PY_EMULATED_WIN_CV 0 bug

2019-01-05 Thread Jeff Robbins
Jeff Robbins added the comment: I searched harder. :-) https://bugs.python.org/issue29871 I see that someone else already noticed this broken function, but I guess it was left broken because of other issues with using condition variables instead of the emulated ones? Still, the code is

[issue35653] All regular expression match groups are the empty string

2019-01-05 Thread adiba
Change by adiba : -- nosy: -adiba, ezio.melotti, mrabarnett ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: No problem :) I think the test can use a context manager instead of using test() and a decorator but that can be discussed on the PR. Thanks! -- ___ Python tracker

[issue35666] Update design FAQ about assignment expression

2019-01-05 Thread Carl Bordum Hansen
New submission from Carl Bordum Hansen : Hi there, In ``Doc/faq/design.rst`` there is an explanation of why Python does not have assignment in expressions. This is dated since PEP 572 / Python 3.8. Online version:

[issue35633] test_eintr fails on AIX since fcntl functions were modified

2019-01-05 Thread Michael Felt
Michael Felt added the comment: On 04/01/2019 23:42, STINNER Victor wrote: > STINNER Victor added the comment: > > Does the test pass if you open the file in read+write ("w+b") mode rather > than write-only ("wb") mode? > > I'm talking about this line: > > open(support.TESTFN, 'wb') > > Note:

[issue35651] PEP 257 (active) references PEP 258 (rejected) as if it were active

2019-01-05 Thread Guido van Rossum
Guido van Rossum added the comment: A rejected PEP still exists in perpetuity, and can still be used as a reference. Also, the reason for PEP 258's rejection is not that it is invalid, but that it's not slated for stdlib inclusion. So I think that the reference is still useful, and I don't

[issue35666] Update design FAQ about assignment expression

2019-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This can be changed only after implementing PEP 572. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue35666] Update design FAQ about assignment expression

2019-01-05 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- dependencies: +PEP 572: Assignment Expressions ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35660] IDLE: Remove import * from window.py

2019-01-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: 'import *' is a PEP 8 violation. Depending in the * import to import sys is a bug. -- type: enhancement -> behavior ___ Python tracker ___

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2019-01-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I have added a doc note under make_file docs which has docs for fromdesc and todesc. make_table refers to make_file for fromdesc and todesc docs. I have added a screenshot of the rendering using note and warning directive. I feel note directive is

[issue35634] kwargs regression when there are multiple entries with the same key

2019-01-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > (Just curious, what does d['a'] return?) I was curious too and some results $ python Python 3.7.1rc2 (v3.7.1rc2:6c06ef7dc3, Oct 13 2018, 05:10:29) [Clang 6.0 (clang-600.0.57)] on darwin Type "help", "copyright", "credits" or "license" for more

[issue35665] Function ssl.create_default_context raises exception on Windows 10 when called with ssl.Purpose.SERVER_AUTH) attribute

2019-01-05 Thread Vladimir Perić
New submission from Vladimir Perić : In Python 3.7.1 on Windows 10 ssl library function call ssl.create_default_context(ssl.Purpose.SERVER_AUTH) raises an ssl error: File "C:\Python37\lib\ssl.py", line 471, in _load_windows_store_certs self.load_verify_locations(cadata=certs) ssl.SSLError:

[issue35634] kwargs regression when there are multiple entries with the same key

2019-01-05 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch, patch pull_requests: +10875, 10876 stage: test needed -> patch review ___ Python tracker ___

[issue35634] kwargs regression when there are multiple entries with the same key

2019-01-05 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch, patch, patch pull_requests: +10875, 10876, 10877 stage: test needed -> patch review ___ Python tracker ___

[issue35634] kwargs regression when there are multiple entries with the same key

2019-01-05 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +10875 stage: test needed -> patch review ___ Python tracker ___

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-05 Thread Emmanuel Arias
Change by Emmanuel Arias : -- pull_requests: +10871 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2019-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Yes, please make a documentation PR. Since this behavior can cause a security hole in the user code, make this note visually attractive (maybe use the "note" directive). -- stage: patch review -> needs patch

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-05 Thread Emmanuel Arias
Emmanuel Arias added the comment: Sorry I was wrong. On ```python foo = OrderedDict() foo['a'] = object() foo['b'] = 'something' ``` I was write "first" and "second" like key and fail in ```python @patch.dict(foo, OrderedDict(update_values)) def test(): self.assertEqual(list(foo),

[issue35660] IDLE: Remove import * from window.py

2019-01-05 Thread Cheryl Sabella
Change by Cheryl Sabella : -- pull_requests: -10863 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35660] IDLE: Remove import * from window.py

2019-01-05 Thread Cheryl Sabella
Change by Cheryl Sabella : -- pull_requests: -10864 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34838] Improve arg clinic code generation for cases with type checking

2019-01-05 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- dependencies: +Argument Clinic: inline parsing code for 1-argument functions, Argument Clinic: inline parsing code for functions with only positional parameters ___ Python tracker

[issue35622] RFE: Add os.sched_setattr() and os.sched_getattr() functions

2019-01-05 Thread Michael Büsch
Michael Büsch added the comment: I would like to implement this feature. So if somebody thinks that it's a bad idea to have this feature, please speak up now. -- nosy: +vstinner ___ Python tracker

[issue8538] Add FlagAction to argparse

2019-01-05 Thread Rémi Lapeyre
Rémi Lapeyre added the comment: > I also removed myself from the issue, I'm not interested to implement it. I would like to try and implement the change. I will open a PR shortly. -- nosy: +remi.lapeyre ___ Python tracker

[issue35582] Argument Clinic: inline parsing code for functions with only positional parameters

2019-01-05 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35636] remove redundant check in unicode_hash(PyObject *self)

2019-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: For historical reasons. In Python 2, str and unicode consisting of ASCII characters can be equal. Equal values should have the same hash. In Python 3, bytes and str are always different. This can cause subtle bugs in the code ported from Python 2. Options

[issue35606] Add prod() function to the math module

2019-01-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: For the record, I would have to look up the documentation everytime I encounter "comb" and "perm", while the full names are intuitive to me. "prod" and "fact" feel somewhat less obscure. I suppose there are two possible audiences here: - the expert math /

[issue35638] Introduce fixed point locale aware format type for floating point numbers

2019-01-05 Thread Łukasz Stelmach
Łukasz Stelmach added the comment: Indeed. Thank you. I was sure I had tried this. However, this is still only a workaround and not the solution I need. I am working on a project now which uses pint https://pint.readthedocs.io/en/latest/ which uses format() and its relatives. With "n"

[issue35665] Function ssl.create_default_context raises exception on Windows 10 when called with ssl.Purpose.SERVER_AUTH) attribute

2019-01-05 Thread Vladimir Perić
Vladimir Perić added the comment: Same outcome in Python 3.7.2. See first comment for detailed explanation of issue. -- ___ Python tracker ___

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-05 Thread Emmanuel Arias
Emmanuel Arias added the comment: Hi xtreak, > Thanks @nekobon for the patch. I am triaging old mock related issues. I think > dict insertion order is maintained from 3.6 and guaranteed with 3.7 and > above. But it would be good to add the unit test in the patch as a PR. I ran > the test

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Can you please post the error and the command to run the test? On applying the patch on master I cannot see any errors with below commands : # Applying the patch with only test $ wget https://bugs.python.org/file40488/issue24928.patch $ git apply

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-05 Thread Emmanuel Arias
Change by Emmanuel Arias : -- pull_requests: +10871, 10872, 10873 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-05 Thread Emmanuel Arias
Change by Emmanuel Arias : -- pull_requests: +10871, 10872 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35584] Wrong statement about ^ in howto/regex.rst

2019-01-05 Thread Julien Palard
Julien Palard added the comment: yes. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35625] Comprehension doc doesn't mention buggy class scope behavior

2019-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also issue3692. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Seems PR 11328 introduced a compiler warning: In file included from ./Include/Python.h:64:0, from ./Python/sysmodule.c:17: ./Python/sysmodule.c:1597:14: warning: ‘sys_clear_type_cache__doc__’ defined but not used [-Wunused-variable]

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2019-01-05 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +10878, 10879, 10880 stage: needs patch -> patch review ___ Python tracker ___

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2019-01-05 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +10878 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2019-01-05 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +10878, 10879 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Tal Einat added the comment: Thanks Serhiy! The compiler doesn't warn about that on Windows. See PR GH-11444 with a fix. -- ___ Python tracker ___

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10894 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10892 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Change by Tal Einat : -- pull_requests: -10893 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10892, 10893 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2019-01-05 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +10892, 10893, 10894 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35661] Store the venv prompt in pyvenv.cfg

2019-01-05 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch pull_requests: +10881 stage: test needed -> patch review ___ Python tracker ___ ___

[issue35661] Store the venv prompt in pyvenv.cfg

2019-01-05 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch, patch, patch pull_requests: +10881, 10882, 10883 stage: test needed -> patch review ___ Python tracker ___

[issue35661] Store the venv prompt in pyvenv.cfg

2019-01-05 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: +patch, patch pull_requests: +10881, 10882 stage: test needed -> patch review ___ Python tracker ___

[issue35616] Change references to '4.0'.

2019-01-05 Thread Emmanuel Arias
Emmanuel Arias added the comment: Hello! IMHO I don't think is good say that they will remove on a version that is not planned yet. I agree with Marc-Andre is better say " they will be remove in the next major release" -- ___ Python tracker

[issue35625] Comprehension doc doesn't mention buggy class scope behavior

2019-01-05 Thread Seval Geyik
Change by Seval Geyik : -- components: +email nosy: +barry, r.david.murray type: behavior -> security Added file: https://bugs.python.org/file48026/keyfile.png ___ Python tracker

[issue34431] Docs does not eval allows code object as argument

2019-01-05 Thread Cheryl Sabella
Cheryl Sabella added the comment: Hi Jonathan, Did you have any additional questions about opening a pull request for these changes? Thanks! -- nosy: +cheryl.sabella ___ Python tracker

[issue35668] Improve test coverage for idlelib

2019-01-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: I (we) agree that idlelib needs even better test coverage. Some history: 1. I added idle_test/ 5-1/2 years ago. Only the calltip module had automated tests easily converted to unittests (test_calltip). 2. Other exiting tests, requiring human judgement, were

[issue35606] Add prod() function to the math module

2019-01-05 Thread Tim Peters
Tim Peters added the comment: I'd like to divorce `prod()` from floating-point complications. The `sum()` builtin has proved extremely handy, even for floats, in large part because it's type-agnostic and straightforward. While I'd usually use `prod()` on ints and Fractions, in almost all

[issue35616] Change references to '4.0'.

2019-01-05 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Why not change the wording to read "... will be considered for removal in the next major Python release". Note that removal of Py_UNICODE APIs will not only break compatibility with Python 2, but also with the early Python 3 releases. And please also

[issue13127] xml.dom.Attr.name is not labeled as read-only

2019-01-05 Thread Ashwin Ramaswami
Ashwin Ramaswami added the comment: This behavior appears to be working as expected per the documentation when using Python 3.7.1. I am able to change name, but changing localName gives me a NoModificationAllowedErr error. -- nosy: +Ashwin Ramaswami versions: +Python 3.7 -Python

[issue21257] Document parse_headers function of http.client

2019-01-05 Thread Ashwin Ramaswami
Change by Ashwin Ramaswami : -- keywords: +patch pull_requests: +10888 stage: needs patch -> patch review ___ Python tracker ___

[issue21257] Document parse_headers function of http.client

2019-01-05 Thread Ashwin Ramaswami
Change by Ashwin Ramaswami : -- keywords: +patch, patch, patch pull_requests: +10888, 10889, 10890 stage: needs patch -> patch review ___ Python tracker ___

[issue21257] Document parse_headers function of http.client

2019-01-05 Thread Ashwin Ramaswami
Change by Ashwin Ramaswami : -- keywords: +patch, patch, patch, patch pull_requests: +10888, 10889, 10890, 10891 stage: needs patch -> patch review ___ Python tracker ___

[issue21257] Document parse_headers function of http.client

2019-01-05 Thread Ashwin Ramaswami
Change by Ashwin Ramaswami : -- keywords: +patch, patch pull_requests: +10888, 10889 stage: needs patch -> patch review ___ Python tracker ___

[issue35668] Improve test coverage for idlelib

2019-01-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: Great. I suggest then that you start with untested, normal, non-GUI (non-tkinter) code, assuming that you can find some. This can mean segregating functional code from gui code if they are currently intertwined. As point 1 above suggested, IDLE, which

[issue35667] activate for venv containing apostrophe doesn't work in powershell

2019-01-05 Thread Cheryl Sabella
New submission from Cheryl Sabella : On Windows 10, when I try to activate a venv in powershell where the name contains an apostrophe, I get the following error ("don't" is the name of the venv): PS N:\projects\cpython\don't\Scripts> .\activate.ps1 At

[issue35649] http.client doesn't close. Infinite loop

2019-01-05 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch, patch, patch, patch pull_requests: +10884, 10885, 10886, 10887 stage: -> patch review ___ Python tracker ___

[issue34831] Asyncio Tutorial

2019-01-05 Thread Caleb Hattingh
Caleb Hattingh added the comment: A quick note to say I have not abandoned this, it's just that life got complicated for me in late 2018. I intend to pick up progress again within the next month or two. -- ___ Python tracker

[issue30487] DOC: automatically create a venv and install Sphinx when running make

2019-01-05 Thread Caleb Hattingh
Caleb Hattingh added the comment: @cheryl.sabella I am ok with closing this, but the original motivation for this work was from @zack.ware so he should weigh in. I am not going to work on this any further for the forseeable future (I've got my hands full already with the asyncio docs I'm

[issue23057] [Windows] asyncio: support signal handlers on Windows (feature request)

2019-01-05 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 67ba547cf001d6b975cf6900aaf2bd5508dc6a87 by Andrew Svetlov (Vladimir Matveev) in branch 'master': bpo-23057: Use 'raise' to emulate ctrl-c in proactor tests (#11274)

[issue4696] email module does not unfold headers

2019-01-05 Thread Cheryl Sabella
Cheryl Sabella added the comment: Although email policies are marked as provisional, I believe the changes in issue14731 would fix the original request in this issue. If so, would it be possible to close this issue as resolved? Thanks. -- nosy: +cheryl.sabella

[issue35668] Improve test coverage for idlelib

2019-01-05 Thread anthony shaw
anthony shaw added the comment: thanks terry, Some great pointers there, I'll review the exiting work and the README doc. With regards to my experience, I have quite extensive experience with python testing. Most of which would be open-source on my Github profile

[issue35668] Improve test coverage for idlelib

2019-01-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: I like that choice. There are 15 open issues for debugger and I have notes on a few possible enhancements. -- ___ Python tracker ___

[issue35668] low test coverage for idlelib

2019-01-05 Thread anthony shaw
New submission from anthony shaw : idlelib is one of the lesser-tested libraries in cpython: https://codecov.io/gh/python/cpython/tree/master/Lib/idlelib Raising this issue and also volunteering to extend the test module to get coverage across major behaviours and functions that are missing

[issue31887] docs for email.generator are missing a comment on special multipart/signed handling

2019-01-05 Thread Cheryl Sabella
Change by Cheryl Sabella : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7 ___ Python tracker

[issue33393] update config.guess and config.sub

2019-01-05 Thread Cheryl Sabella
Cheryl Sabella added the comment: Is this intended as a global ticket to be used to update these files on a regular basis? Or should a new ticket be created every time the files are updated? Thanks! -- nosy: +cheryl.sabella ___ Python tracker

[issue30487] DOC: automatically create a venv and install Sphinx when running make

2019-01-05 Thread Cheryl Sabella
Cheryl Sabella added the comment: I believe this can be closed as resolved? Thanks. -- nosy: +cheryl.sabella ___ Python tracker ___

[issue35649] http.client doesn't close. Infinite loop

2019-01-05 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +10884 stage: -> patch review ___ Python tracker ___ ___

[issue35649] http.client doesn't close. Infinite loop

2019-01-05 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch, patch, patch pull_requests: +10884, 10885, 10887 stage: -> patch review ___ Python tracker ___

[issue35649] http.client doesn't close. Infinite loop

2019-01-05 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch, patch pull_requests: +10884, 10885 stage: -> patch review ___ Python tracker ___

[issue35668] Improve test coverage for idlelib

2019-01-05 Thread anthony shaw
anthony shaw added the comment: I was looking at the debugger.py module as being a good place the start, writing test cases for the Idb, Debugger, StackViewer and NamespaceViewer by patching out the dependant components (bdb, Idb, etc. I might start there, raise a PR against it and do a

[issue35661] Store the venv prompt in pyvenv.cfg

2019-01-05 Thread Cheryl Sabella
Change by Cheryl Sabella : -- pull_requests: -10882 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35661] Store the venv prompt in pyvenv.cfg

2019-01-05 Thread Cheryl Sabella
Change by Cheryl Sabella : -- pull_requests: -10883 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: