[issue27513] email.utils.getaddresses does not handle Header objects

2019-05-31 Thread Jeffrey Kintscher
Change by Jeffrey Kintscher : -- nosy: +Jeffrey.Kintscher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34368] ftplib __init__ function can't handle 120 or 4xy reply when connect to the server

2019-05-31 Thread Jeffrey Kintscher
Change by Jeffrey Kintscher : -- nosy: +Jeffrey.Kintscher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36379] nb_inplace_pow is always called with an invalid argument

2019-05-31 Thread miss-islington
miss-islington added the comment: New changeset c7f803b08ed5211701c75f98ba9ada85d45ac155 by Miss Islington (bot) (Zackery Spytz) in branch 'master': bpo-36379: __ipow__ must be a ternaryfunc, not a binaryfunc (GH-13546)

[issue34368] ftplib __init__ function can't handle 120 or 4xy reply when connect to the server

2019-05-31 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: >From RFC-959: If the server is unable to accept input right away, a 120 "expected delay" reply should be sent immediately and a 220 reply when ready. The user will then know not to hang up if there is a delay. Seems to make

[issue37111] Logging - Inconsistent behaviour when handling unicode

2019-05-31 Thread Jonathan
New submission from Jonathan : Python is inconsistent in how it handles errors that have some unicode characters. It works to screen but fails to log This works: ``` >>> import logging >>> logging.error('จุด1') ERROR:root:จุด1 ``` The following breaks: ``` >>> import logging >>>

[issue35547] email.parser / email.policy does not correctly handle multiple RFC2047 encoded-word tokens across RFC5322 folded headers

2019-05-31 Thread Jeffrey Kintscher
Change by Jeffrey Kintscher : -- nosy: +Jeffrey.Kintscher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37106] python re.escape doesn't escape some special characters.

2019-05-31 Thread Eric V. Smith
Eric V. Smith added the comment: Could you show a problem caused by the characters that are unescaped? I assume you're talking about the ` and ' characters, since that's what your example shows. But those aren't listed as "special characters"

[issue36548] Make the repr of re flags more readable

2019-05-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 14a0e16c8805f7ba7c98132ead815dcfdf0e9d33 by Serhiy Storchaka in branch 'master': bpo-36548: Improve the repr of re flags. (GH-12715) https://github.com/python/cpython/commit/14a0e16c8805f7ba7c98132ead815dcfdf0e9d33 --

[issue26836] Add memfd_create to os module

2019-05-31 Thread Antoine Pitrou
Antoine Pitrou added the comment: Davin, Pierre, it looks like this could simplify lifetime management of shared memory pools, what do you think? -- nosy: +davin, pierreglaser, pitrou ___ Python tracker

[issue37110] Clarify hashability of custom class instances

2019-05-31 Thread Christoph Zwerschke
New submission from Christoph Zwerschke : The Python documentation says about hashability in the glossary (https://docs.python.org/3/glossary.html#term-hashable): "Objects which are instances of user-defined classes are hashable by default." This is not quite true. Objects of a user-defined

[issue21314] Document '/' in signatures

2019-05-31 Thread Terry J. Reedy
Terry J. Reedy added the comment: Hooray! Now that PEP570 is implemented in 3.8: >>> def f(a, /, *, b): return 3 ... >>> f(0, b=2) 3 # other combinations raise and somewhat documented, ('/' in grammar of '8.6 Function definitions', though not explained, should its status become final and

[issue36411] Python 3 f.tell() gets out of sync with file pointer in binary append+read mode

2019-05-31 Thread PEW's Corner
PEW's Corner added the comment: Your proposal sounds good to me, Jeffrey. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue37107] ensurepip --upgrade doesn't change the version of pip used by venv

2019-05-31 Thread Chris Withers
New submission from Chris Withers : $ python3.7 -m ensurepip --upgrade Looking in links: /var/folders/m6/tsd59qsj7pd_lldh4mhwh6khgn/T/tmpqk_vncev Requirement already up-to-date: setuptools in /Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages (39.0.1)

[issue35144] TemporaryDirectory clean-up fails with unsearchable directories

2019-05-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset e9b51c0ad81da1da11ae65840ac8b50a8521373c by Serhiy Storchaka in branch 'master': bpo-26660, bpo-35144: Fix permission errors in TemporaryDirectory cleanup. (GH-10320)

[issue31829] Portability issues with pickle

2019-05-31 Thread miss-islington
Change by miss-islington : -- pull_requests: +13579 pull_request: https://github.com/python/cpython/pull/13693 ___ Python tracker ___

[issue26660] tempfile.TemporaryDirectory() cleanup exception if nonwriteable or non-searchable files or directories created

2019-05-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset e9b51c0ad81da1da11ae65840ac8b50a8521373c by Serhiy Storchaka in branch 'master': bpo-26660, bpo-35144: Fix permission errors in TemporaryDirectory cleanup. (GH-10320)

[issue37106] python re.escape doesn't escape some special characters.

2019-05-31 Thread MANI M
MANI M added the comment: sorry my bad query = "insert into table(column) values('{}')".format(escape("Hello'`~world")) -- ___ Python tracker ___

[issue37109] Inacurrate documentation regarding return type of math.factorial

2019-05-31 Thread Antony Lee
Antony Lee added the comment: oops, missed that, thanks for pointing that out. -- stage: -> resolved status: open -> closed ___ Python tracker ___

[issue34155] email.utils.parseaddr mistakenly parse an email

2019-05-31 Thread Abhilash Raj
Abhilash Raj added the comment: How about we go a slightly different route than suggested by jpic and instead of returning a None value, we return the entire rest of the string as the domain? That would take care of the security issue since it won't be a valid domain anymore. msg =

[issue37106] python re.escape doesn't escape some special characters.

2019-05-31 Thread Eric V. Smith
Eric V. Smith added the comment: re.escape() is designed to only escape characters that have special meaning in regular expressions. It is not a general purpose escaping mechanism, and it is especially dangerous to use it for building SQL statements. You should be using parameterized SQL

[issue34271] Please support logging of SSL master secret by env variable SSLKEYLOGFILE

2019-05-31 Thread Christian Heimes
Christian Heimes added the comment: New changeset c7f7069e77c58e83b847c0bfe4d5aadf6add2e68 by Christian Heimes in branch 'master': bpo-34271: Add ssl debugging helpers (GH-10031) https://github.com/python/cpython/commit/c7f7069e77c58e83b847c0bfe4d5aadf6add2e68 --

[issue37106] python re.escape doesn't escape some special characters.

2019-05-31 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: It's a behavior change from 3.6 and it's present from 3.7.0a1 -- ___ Python tracker ___

[issue36988] zipfile: string IndexError on extract

2019-05-31 Thread Jeffrey Kintscher
Change by Jeffrey Kintscher : -- nosy: -Jeffrey.Kintscher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35545] asyncio.base_events.create_connection doesn't handle scoped IPv6 addresses

2019-05-31 Thread Michael Felt
Michael Felt added the comment: On 30/05/2019 23:11, Andrew Svetlov wrote: > Andrew Svetlov added the comment: > > Guys, thank you for investigation. > If there is AIX "idiosyncrasy" -- please feel free to skip failed tests on > AIX. > > If you have access to AIX box it would be much easier

[issue37109] Inacurrate documentation regarding return type of math.factorial

2019-05-31 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Is this same as issue25735 ? -- nosy: +xtreak ___ Python tracker ___ ___

[issue35964] shutil.make_archive (xxx, tar, root_dir) is adding './' entry to archive which is wrong

2019-05-31 Thread Jeffrey Kintscher
Change by Jeffrey Kintscher : -- nosy: +Jeffrey.Kintscher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37104] logging.Logger.disabled is not documented

2019-05-31 Thread Mario Corchero
Mario Corchero added the comment: Thanks! I was wondering about it but saw no comment about it, issue or anything in the history. At least we have now this issue :). Would you like that I move this to `_disabled` and have a setter for `disabled` that emits a deprecation warning so we can

[issue37108] Positional-only arguments break super()

2019-05-31 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : See the example pep570super.py. super() without arguments does not work for positional-only arguments. Traceback (most recent call last): File "pep570super.py", line 13, in print(C()) File "pep570super.py", line 10, in __new__ return

[issue31829] Portability issues with pickle

2019-05-31 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 38ab7d4721b422547f7b46b9d68968863fa70573 by Serhiy Storchaka in branch 'master': bpo-31829: Make protocol 0 pickles be loadable in text mode in Python 2. (GH-11859)

[issue37109] Inacurrate documentation regarding return type of math.factorial

2019-05-31 Thread Antony Lee
New submission from Antony Lee : https://docs.python.org/3/library/math.html says The following functions are provided by this module. Except when explicitly noted otherwise, all return values are floats. and math.factorial(x) Return x factorial. Raises ValueError if x is not integral or is

[issue37101] Filterer.filter can be rewritten using built-ins just as efficient much more readable

2019-05-31 Thread Vinay Sajip
Vinay Sajip added the comment: I grant that your version is more compact, but I don't find it more readable in general (perhaps it is for very experienced Python developers/developers who like a functional style, but I persoanlly don't think it improves readability). Since the rationale

[issue26835] Add file-sealing ops to fcntl

2019-05-31 Thread Christian Heimes
Change by Christian Heimes : -- pull_requests: +13580 pull_request: https://github.com/python/cpython/pull/13694 ___ Python tracker ___

[issue37109] Inacurrate documentation regarding return type of math.factorial

2019-05-31 Thread Antony Lee
Change by Antony Lee : -- nosy: -Antony.Lee ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36910] Certain Malformed email causes email.parser to throw AttributeError

2019-05-31 Thread Jeffrey Kintscher
Jeffrey Kintscher added the comment: My mistake for responding to the wrong issue. -- ___ Python tracker ___ ___ Python-bugs-list

[issue12178] csv writer doesn't escape escapechar

2019-05-31 Thread Jeffrey Kintscher
Change by Jeffrey Kintscher : -- nosy: +Jeffrey.Kintscher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37106] python re.escape doesn't escape some special characters.

2019-05-31 Thread MANI M
MANI M added the comment: I've scripts which insert data into MySQL database. The values may contain symbols. Hence in order to escape that I use re.escape(). @erik.smith isn't re.escape() supposed to escape all the symbols. If not why is this introduced in 3.7 whereas previous versions

[issue37104] logging.Logger.disabled is not documented

2019-05-31 Thread Vinay Sajip
Vinay Sajip added the comment: Thanks for looking at this, Mario, but I'd rather not document this attribute, for the reason stated on the PR when I closed it: "I'd like to avoid documenting this attribute, as it's really meant for internal use by the configuration machinery. I realise that

[issue37109] Inacurrate documentation regarding return type of math.factorial

2019-05-31 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- resolution: -> duplicate superseder: -> math.factorial doc should mention integer return type ___ Python tracker ___

[issue37104] logging.Logger.disabled is not documented

2019-05-31 Thread Mario Corchero
Mario Corchero added the comment: Note that even if not in the standard library I've seen this attributed used and documented quite often. Example: https://docs.python-guide.org/writing/logging/#or-print I would really suggest making it private as mentioned before to make sure this does

[issue37111] Logging - Inconsistent behaviour when handling unicode

2019-05-31 Thread SilentGhost
SilentGhost added the comment: > Given that the file created by the logger is utf-8 I don't think this is true. Default file handler created using filename argument is opened with encoding None (meaning that it relies on system-default encoding, which is on Windows is not utf-8). And it

[issue37113] 'ß'.upper() should return 'ẞ'

2019-05-31 Thread Richard Neumann
Richard Neumann added the comment: See also: https://en.wikipedia.org/wiki/Capital_%E1%BA%9E -- ___ Python tracker ___ ___

[issue37116] Use PEP 570 syntax for positional-only parameters

2019-05-31 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Two PRs apply PEP 570 syntax to the existing code. PR 13700 contains only compatible changes and can be applied to 3.8. It removes existing *args or naming tricks and makes self and cls arguments positional-only (if needed). PR 12620 contains breaking

[issue37116] Use PEP 570 syntax for positional-only parameters

2019-05-31 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +13585 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13700 ___ Python tracker

[issue37116] Use PEP 570 syntax for positional-only parameters

2019-05-31 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +13586 pull_request: https://github.com/python/cpython/pull/12620 ___ Python tracker ___

[issue37104] logging.Logger.disabled is not documented

2019-05-31 Thread Vinay Sajip
Vinay Sajip added the comment: As it's not documented, people would come across it by browsing the source. I'd just mention in the source (Logger constructor) that it's for internal use, and leave it at that. -- ___ Python tracker

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

2019-05-31 Thread Michael Felt
Michael Felt added the comment: hmm - i had just synced with master. must have just missed something since there is a strike-out through GH-13251. If so, please ignore. BBL. -- ___ Python tracker

[issue37111] Logging - Inconsistent behaviour when handling unicode

2019-05-31 Thread Jonathan
Jonathan added the comment: It definitely claims to be "utf-8" in NotePad++. I've attached it if you want to double-check. (Windows 7) -- Added file: https://bugs.python.org/file48380/my_log.log ___ Python tracker

[issue37113] 'ß'.upper() should return 'ẞ'

2019-05-31 Thread Eric V. Smith
Eric V. Smith added the comment: See http://unicode.org/faq/casemap_charprop.html, search for "Why does ß (U+00DF LATIN SMALL LETTER SHARP S) not uppercase to U+1E9E LATIN CAPITAL LETTER SHARP S by default?" -- nosy: +eric.smith ___ Python tracker

[issue37115] Support annotations in positional-only arguments

2019-05-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- components: Interpreter Core nosy: pablogsal priority: normal severity: normal status: open title: Support annotations in positional-only arguments versions: Python 3.8 ___ Python tracker

[issue37108] Positional-only arguments break super()

2019-05-31 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thank you very much, Serhiy, for the catch! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue37108] Positional-only arguments break super()

2019-05-31 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 3a46d5c293d39995dc5218bf46a7d92b16fb2a15 by Pablo Galindo in branch 'master': bpo-37108: Support super with methods that use positional-only arguments (GH-13695)

[issue37112] Error in compilig the AST for functions with optional positional arguments

2019-05-31 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : >>> import ast >>> sample = 'def f(a=1, /): pass' >>> compile(sample, '?', 'exec') at 0x7f7cacdfd5c0, file "?", line 1> >>> compile(ast.parse(sample, '?'), '?', 'exec') Traceback (most recent call last): File "", line 1, in ValueError: more positional

[issue37113] 'ß'.upper() should return 'ẞ'

2019-05-31 Thread Richard Neumann
New submission from Richard Neumann : Currently, calling the method .upper() on a string containing 'ß' will replace this character by 'SS'. It should, however, be replaced by 'ẞ'. -- components: Unicode messages: 344065 nosy: Richard Neumann, ezio.melotti, vstinner priority: normal

[issue29447] Add/check os.PathLike support for the tempfile module's 'dir' arguments

2019-05-31 Thread Cheryl Sabella
Cheryl Sabella added the comment: The pull request attached to this issue has been closed as the repository was marked as unknown. This issue is now available for a new pull request. -- nosy: +cheryl.sabella stage: -> needs patch versions: +Python 3.9

[issue36974] Implement PEP 590

2019-05-31 Thread Petr Viktorin
Petr Viktorin added the comment: I found an issue in PEP 590: When inheriting a heap subclass from a vectorcall class that sets .tp_call=PyVectorcall_Call (as recommended), the subclass does not inherit _Py_TPFLAGS_HAVE_VECTORCALL, and thus PyVectorcall_Call does not work for it. Possible

[issue37108] Positional-only arguments break super()

2019-05-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +13581 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13695 ___ Python tracker

[issue37112] Error in compilig the AST for functions with optional positional arguments

2019-05-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- assignee: -> pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37101] Filterer.filter can be rewritten using built-ins just as efficient much more readable

2019-05-31 Thread Dale Visser
Dale Visser added the comment: It is with great surprise and sadness that I report that I found that performance measurements don't support merging this change. I'm attaching my performance test script. I ran it with/without the logging filters for 100 iterations, e.g., ./python all

[issue37101] Filterer.filter can be rewritten using built-ins just as efficient much more readable

2019-05-31 Thread Dale Visser
Dale Visser added the comment: Correction on that example of running the test script: ./python test_filter_perf.py all 100 I simply prepended this with the Linux `time` command for measuring. -- ___ Python tracker

[issue37115] Support annotations in positional-only arguments

2019-05-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37115] Support annotations in positional-only arguments

2019-05-31 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : New changeset a0c01bf1364f2996bb0186ddfc41d74350e01c39 by Pablo Galindo in branch 'master': bpo-37115: Support annotations in positional-only arguments (GH-13698) https://github.com/python/cpython/commit/a0c01bf1364f2996bb0186ddfc41d74350e01c39

[issue36974] Implement PEP 590

2019-05-31 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +13584 pull_request: https://github.com/python/cpython/pull/13699 ___ Python tracker ___

[issue36889] Merge StreamWriter and StreamReader into just asyncio.Stream

2019-05-31 Thread Michael Felt
Michael Felt added the comment: FYI: since: commit 23b4b697e5b6cc897696f9c0288c187d2d24bff2 Author: Andrew Svetlov Date: Mon May 27 22:56:22 2019 +0300 bpo-36889: Merge asyncio streams (GH-13251) https://bugs.python.org/issue36889 AIX bot 'hangs' during test_sendfile

[issue37092] LoggerAdapter doesn't have fatal() like Logger

2019-05-31 Thread SilentGhost
SilentGhost added the comment: fatal is an undocumented feature, it's probably better not to use it in the first place. -- nosy: +SilentGhost, vinay.sajip versions: +Python 3.8 ___ Python tracker

[issue37112] Error in compilig the AST for functions with optional positional arguments

2019-05-31 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks again, Serhiy :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37114] lstrip remove extra characters in the presence of a matching number

2019-05-31 Thread Akilesh K
New submission from Akilesh K : When the argument to lstrip / strip has a number and it matches the string it begins to act different. >>> text = "apiv1appliance" >>> text.strip("apiv1") 'liance' >>> text.strip("apiv2") '1appliance' >>> text.strip("a") 'piv1appliance' >>> text.strip("ap")

[issue37112] Error in compilig the AST for functions with optional positional arguments

2019-05-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +13582 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13697 ___ Python tracker

[issue37111] Logging - Inconsistent behaviour when handling unicode

2019-05-31 Thread SilentGhost
Change by SilentGhost : -- versions: +Python 3.7, Python 3.8 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18911] minidom does not encode correctly when calling Document.writexml

2019-05-31 Thread Stefan Behnel
Stefan Behnel added the comment: Asking users unconditionally to use the "xmlcharrefreplace" replacement method seems wrong for UTF-8. It should not be necessary. We should, however, document explicitly that the file will receive text and not bytes, i.e. that users are themselves

[issue37111] Logging - Inconsistent behaviour when handling unicode

2019-05-31 Thread SilentGhost
Change by SilentGhost : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware type: -> behavior ___ Python tracker ___

[issue37113] 'ß'.upper() should return 'ẞ'

2019-05-31 Thread SilentGhost
SilentGhost added the comment: Python implements Unicode standard when it comes to capitalisation rules. According to the latest standard 'ß' is upper-cased to 'SS'. -- nosy: +SilentGhost resolution: -> not a bug stage: -> resolved status: open -> closed

[issue37114] lstrip remove extra characters in the presence of a matching number

2019-05-31 Thread Christian Heimes
Christian Heimes added the comment: It's not a bug. strip() does not work like you think. Please read the documentation https://docs.python.org/3/library/stdtypes.html?highlight=strip#str.strip -- nosy: +christian.heimes resolution: -> not a bug stage: -> resolved status: open ->

[issue37112] Error in compilig the AST for functions with optional positional-only arguments

2019-05-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- title: Error in compilig the AST for functions with optional positional arguments -> Error in compilig the AST for functions with optional positional-only arguments ___ Python tracker

[issue37112] Error in compilig the AST for functions with optional positional-only arguments

2019-05-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37112] Error in compilig the AST for functions with optional positional-only arguments

2019-05-31 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 2f58a84104ef64f71deb71d264305bcd73e59c97 by Pablo Galindo in branch 'master': bpo-37112: Allow compile to work on AST with positional only arguments with defaults (GH-13697)

[issue37115] Support annotations in positional-only arguments

2019-05-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +13583 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13698 ___ Python tracker

[issue37029] PyObject_Free is O(N) where N = # of arenas

2019-05-31 Thread Tim Peters
Tim Peters added the comment: Thank you so much, Inada! That's very good to hear :-) -- ___ Python tracker ___ ___

[issue37094] Provide an example for TestCase.skipTest in unittest doc

2019-05-31 Thread miss-islington
miss-islington added the comment: New changeset ffed76b6fc4d7dd0244b662d6e5738eb496d9def by Miss Islington (bot) (Makdon) in branch 'master': bpo-37094: Add example for TestCase.skipTest in unittest doc (GH-13645)

[issue37094] Provide an example for TestCase.skipTest in unittest doc

2019-05-31 Thread miss-islington
Change by miss-islington : -- keywords: +patch pull_requests: +13587 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13701 ___ Python tracker ___

[issue12639] msilib Directory.start_component() fails if keyfile is not None

2019-05-31 Thread Steve Dower
Steve Dower added the comment: New changeset c8d5bf6c3fa09b43f6a5ee779d493d251dbcc53c by Steve Dower (Zackery Spytz) in branch 'master': bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not None (GH-13688)

[issue12639] msilib Directory.start_component() fails if keyfile is not None

2019-05-31 Thread miss-islington
Change by miss-islington : -- pull_requests: +13591 pull_request: https://github.com/python/cpython/pull/13705 ___ Python tracker ___

[issue36896] clarify in types.rst that FunctionTypes & co constructors don't have stable signature

2019-05-31 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Although I completely agree with the decision of figuring out an explicit consensus regarding these APIs, I will explain a bit my +1: My +1 is not about the usage of PyCode_New, is about the usage of `types.CodeType`. The constructor for the later

[issue25735] math.factorial doc should mention integer return type

2019-05-31 Thread miss-islington
miss-islington added the comment: New changeset fc3b8437c86167983cc75e5a9a3ed1dc542a1b79 by Miss Islington (bot) in branch '3.7': bpo-25735: math.factorial doc should mention integer return type (GH-6420) https://github.com/python/cpython/commit/fc3b8437c86167983cc75e5a9a3ed1dc542a1b79

[issue37094] Provide an example for TestCase.skipTest in unittest doc

2019-05-31 Thread Zachary Ware
Zachary Ware added the comment: Thanks for the patch! -- nosy: +zach.ware resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker

[issue36540] PEP 570: Python Positional-Only Parameters

2019-05-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +13593 pull_request: https://github.com/python/cpython/pull/13706 ___ Python tracker ___

[issue36842] Implement PEP 578

2019-05-31 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +13594 pull_request: https://github.com/python/cpython/pull/13707 ___ Python tracker ___

[issue37029] PyObject_Free is O(N) where N = # of arenas

2019-05-31 Thread Inada Naoki
Inada Naoki added the comment: master: build time 0:48:53.664428 teardown time 4:58:20.132930 patched: build time 0:48:08.485639 teardown time 0:01:10.466707 About 250x speedup! -- Added file: https://bugs.python.org/file48382/result.txt ___

[issue37109] Inacurrate documentation regarding return type of math.factorial

2019-05-31 Thread Cheryl Sabella
Cheryl Sabella added the comment: Thanks for pointing out the other issue. I've now merged it. -- nosy: +cheryl.sabella ___ Python tracker ___

[issue25735] math.factorial doc should mention integer return type

2019-05-31 Thread Cheryl Sabella
Cheryl Sabella added the comment: @John.Yeung, thank you for the report. @mine0901, thanks for the initial patch and @akshaysharma, thank you for the PR. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python

[issue12639] msilib Directory.start_component() fails if keyfile is not None

2019-05-31 Thread Steve Dower
Steve Dower added the comment: Thanks, Zackery! The backports are running CI now and should merge if everything passes. -- stage: patch review -> backport needed ___ Python tracker

[issue12639] msilib Directory.start_component() fails if keyfile is not None

2019-05-31 Thread miss-islington
Change by miss-islington : -- pull_requests: +13590 pull_request: https://github.com/python/cpython/pull/13704 ___ Python tracker ___

[issue12639] msilib Directory.start_component() fails if keyfile is not None

2019-05-31 Thread miss-islington
Change by miss-islington : -- pull_requests: +13589 pull_request: https://github.com/python/cpython/pull/13703 ___ Python tracker ___

[issue12639] msilib Directory.start_component() fails if keyfile is not None

2019-05-31 Thread miss-islington
miss-islington added the comment: New changeset 49fc57abf5fcf60129e460046d78c9bf20a19931 by Miss Islington (bot) in branch '3.7': bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not None (GH-13688)

[issue37092] LoggerAdapter doesn't have fatal() like Logger

2019-05-31 Thread Vinay Sajip
Vinay Sajip added the comment: FATAL and fatal() are synonyms for CRITICAL and critical(), and they are only around because of backward compatibility constraints on the Logger class at the time logging was added to Python. Because LoggerAdapter has no backward compatibility constraints,

[issue37094] Provide an example for TestCase.skipTest in unittest doc

2019-05-31 Thread miss-islington
miss-islington added the comment: New changeset 8135455c840b9e169a6cd527cb1ee922cafb9109 by Miss Islington (bot) in branch '3.7': bpo-37094: Add example for TestCase.skipTest in unittest doc (GH-13645) https://github.com/python/cpython/commit/8135455c840b9e169a6cd527cb1ee922cafb9109

[issue26835] Add file-sealing ops to fcntl

2019-05-31 Thread Christian Heimes
Christian Heimes added the comment: New changeset 8cbb5b6625268400d6e9092b75b06d6f90398dc9 by Christian Heimes in branch 'master': bpo-26835: Add file sealing constants to fcntl (GH-13694) https://github.com/python/cpython/commit/8cbb5b6625268400d6e9092b75b06d6f90398dc9 --

[issue37116] Use PEP 570 syntax for positional-only parameters

2019-05-31 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36839] Support the buffer protocol in code objects

2019-05-31 Thread Brett Cannon
Brett Cannon added the comment: RE: "I think it needs significant benefits for typical users, not only for Instagram. If only Instagram get benefit from this, keep it as Instagram's internal patch." But who's typical in this case? You? Me? We're talking code objects, something that the

[issue37101] Filterer.filter can be rewritten using built-ins just as efficient much more readable

2019-05-31 Thread Dale Visser
Dale Visser added the comment: Adding the patch file associated with GitHub pull request #13683, as well as the performance test I just reported. -- Added file: https://bugs.python.org/file48383/pr13683.diff ___ Python tracker

[issue37111] Logging - Inconsistent behaviour when handling unicode

2019-05-31 Thread Vinay Sajip
Vinay Sajip added the comment: > Given that the file created by the logger is utf-8, it's unclear why it > doesn't work ... I found a workaround by using a Handler Loggers don't create files - handlers do. The file that you attached seems to be just a text file containing ASCII text. Any

  1   2   >