[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2019-09-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Closing this as the docs are merged with the initial patch to escape header reverted. Thanks all for the reviews. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-22 Thread Nathaniel Smith
New submission from Nathaniel Smith : Just noticed this while looking at the code to asyncio.Task.__step asyncio Futures have two different error states: they can have an arbitrary exception set, or they can be marked as cancelled. asyncio Tasks handle this by detecting what exception was

[issue38249] Optimize out Py_UNREACHABLE in the release mode

2019-09-22 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Py_UNREACHABLE is used to indicate that a specific point in the program cannot be reached, even if the compiler might otherwise think it can. This is exact the case for __builtin_unreachable in GCC and Clang. I propose to extend Py_UNREACHABLE() to

[issue38251] urllib.request memory leak / overflow

2019-09-22 Thread Ofer Sadan
Ofer Sadan added the comment: Just to note: I'm using Python 3.7.4 on Windows 10 (64bit), the issue exists on both the 32bit/64bit python versions I could test on. -- ___ Python tracker

[issue38252] micro-optimize ucs1lib_find_max_char in Windows 64-bit build

2019-09-22 Thread Ma Lin
New submission from Ma Lin : C type `long` is 4-byte integer in 64-bit Windows build. [1] But `ucs1lib_find_max_char()` function [2] uses SIZEOF_LONG, so it loses a little performance in 64-bit Windows build. Below is the benchmark of using SIZEOF_SIZE_T and this change: - unsigned

[issue38101] Update devguide triaging keywords

2019-09-22 Thread Ido Michael
Ido Michael added the comment: Hi Lisa, I can take this (first commit), where can I edit the dev guide? I could see someone did update the easy keyword in it? Ido -- nosy: +Ido Michael ___ Python tracker

[issue15436] __sizeof__ is not documented

2019-09-22 Thread Ido Michael
Ido Michael added the comment: I can add those changes if someone didn't take it already? Ido -- nosy: +Ido Michael ___ Python tracker ___

[issue27873] multiprocessing.pool.Pool.map should take more than one iterable

2019-09-22 Thread Ido Michael
Ido Michael added the comment: Hey, Is it still open? What else needs to be done? Ido -- nosy: +Ido Michael ___ Python tracker ___

[issue38251] urllib.request memory leak / overflow

2019-09-22 Thread Kumar Akshay
Kumar Akshay added the comment: JFYI, Not reproducible on macOS. -- nosy: +kakshay ___ Python tracker ___ ___ Python-bugs-list

[issue38251] urllib.request memory leak / overflow

2019-09-22 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38251] urllib.request memory leak / overflow

2019-09-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Is this related to https://bugs.python.org/issue35941 given that it's related to windows. Similar report https://bugs.python.org/issue37498 -- nosy: +xtreak ___ Python tracker

[issue38101] Update devguide triaging keywords

2019-09-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I think devguide has it's own repo that accepts PRs https://github.com/python/devguide -- nosy: +xtreak ___ Python tracker ___

[issue38251] urllib.request memory leak / overflow

2019-09-22 Thread Kumar Akshay
Kumar Akshay added the comment: Yes, https://bugs.python.org/issue37498 is indeed the same issue -- ___ Python tracker ___ ___

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-22 Thread Kyle Stanley
Kyle Stanley added the comment: > Is there an "aesthetic code cleanup" patch that's ever turned out well? ;-) >From what I can tell, any remotely extensive aesthetic code patch I've seen >has been highly controversial. I think they can have value in some cases, but >the value relative to

[issue38172] Python 3.8 Segfult with Bandersnatch pytest Suite

2019-09-22 Thread Cooper Lees
Cooper Lees added the comment: Happy to close, just was not 100% sure if the fix is merged into the 3.8 branch. I mainly opened this bug to ensure that has been done. -- ___ Python tracker

[issue38254] Pickle not deserializing an aiohttp ClientConnectorError exception as expected

2019-09-22 Thread David Parks
Change by David Parks : -- title: Pickle not deserializing an OSError exception as expected -> Pickle not deserializing an aiohttp ClientConnectorError exception as expected ___ Python tracker

[issue38254] Pickle not deserializing an OSError exception as expected

2019-09-22 Thread David Parks
New submission from David Parks : Below is a minimum reproducible test case of what appears to be an issue in pickle. Before pickling the exception ClientConnectionError, from aiohttp, the property ClientConnectionError._os_error is a PermissionError object (a subclass of OSError). After

[issue38172] Python 3.8 Segfult with Bandersnatch pytest Suite

2019-09-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Victor, am I correct in thinking that this should be closed as either intermittent, lacking in sufficient information for us to do anything, or possibly a 3rd party issue? -- nosy: +vstinner ___ Python tracker

[issue38251] urllib.request memory leak / overflow

2019-09-22 Thread hongweipeng
Change by hongweipeng : -- nosy: +hongweipeng ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36274] http.client cannot send non-ASCII request lines

2019-09-22 Thread Jason R. Coombs
Jason R. Coombs added the comment: I should say, though, this issue is a long-standing regression from Python 3.0. Although intentional, the inability for a client to override the encoding of the request line does make it impossible without replacing all of .putrequest to override that

[issue38253] Fix typo of Py_SET_ERANGE_IF_OVERFLOW in pyport.h

2019-09-22 Thread hai shi
Change by hai shi : -- keywords: +patch pull_requests: +15906 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16230 ___ Python tracker ___

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

2019-09-22 Thread Jason R. Coombs
Jason R. Coombs added the comment: In https://github.com/cherrypy/cherrypy/pull/1807, I discovered that there is already a fairly straightforward means for a third-party package to override the putrequest character validation (just monkeypatch http.client._contains_disallowed_url_pchar_re

[issue38101] Update devguide triaging keywords

2019-09-22 Thread Ido Michael
Ido Michael added the comment: Thanks Karthikeyan! Found it, so for the last one pep3121, would you like to describe PEP in general or Extension Module Initialization and Finalization? Ido -- ___ Python tracker

[issue38253] Fix typo of Py_SET_ERANGE_IF_OVERFLOW in pyport.h

2019-09-22 Thread hai shi
New submission from hai shi : Py_SET_ERANGE_ON_OVERFLOW should be changed to Py_SET_ERANGE_IF_OVERFLOW in pyport.h. -- assignee: docs@python components: Documentation messages: 352981 nosy: docs@python, shihai1991 priority: normal severity: normal status: open title: Fix typo of

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

2019-09-22 Thread Jason R. Coombs
Jason R. Coombs added the comment: Also, with the CherryPy approach, the Python 2.7 story is more complicated. I haven't yet addressed that in the CherryPy 17 maintenance branch (which supports Python 2.7). -- ___ Python tracker

[issue38249] Optimize out Py_UNREACHABLE in the release mode

2019-09-22 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +15905 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16329 ___ Python tracker

[issue38209] Simplify dataclasses.InitVar by using __class_getitem__()

2019-09-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset b4d0b39a9b4cd203bcc5b236dc96456e9658119a by Serhiy Storchaka in branch 'master': bpo-38209: Simplify dataclasses.InitVar by using __class_getitem__(). (GH-16255)

[issue38250] enum.Flag should be more set-like

2019-09-22 Thread John Belmonte
New submission from John Belmonte : I would like Flag class instances to have more set-like abilities: 1. iteration, to walk through each set bit of the value 2. len corresponding to #1 3. subset operator I may be told "implement it yourself as instance methods", or that #3 has an idiom

[issue38251] urllib.request memory leak / overflow

2019-09-22 Thread Ofer Sadan
New submission from Ofer Sadan : running `urllib.request.urlopen` multiple times causes the memory usage to increase with each run, even after calling `close()` on the request or using `del` on the result To recreate this problem, run code: import urllib.request def ip(): r

[issue36947] [Good first issue] Fix 3.3.3.1 Metaclasses Documentation

2019-09-22 Thread Ido Michael
Ido Michael added the comment: Hey, Is someone working on this issue? Can I take it? Ido -- nosy: +Ido Michael ___ Python tracker ___

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

2019-09-22 Thread Ned Deily
Ned Deily added the comment: I am certainly not a domain expert but, at a high level, I think the approach in PR 16321 is a reasonable compromise and I would support merging it to 3.7 and 3.6 (I'll let Larry and Benjamin speak for 3.5 and 2.7) assuming there are no review objections. Since

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-22 Thread Yury Selivanov
Yury Selivanov added the comment: > The obvious fix would be to modify the 'except StopIteration' branch to > handle this case by calling super().cancel() instead of > super().set_exception(...). Yeah, I think this is the solution we should do in 3.8. --

[issue38216] Fix for issue30458 (HTTP Header Injection) prevents crafting invalid requests

2019-09-22 Thread Ned Deily
Ned Deily added the comment: Also, besides the normal news entry (via blurb), there should probably be a "Notable changes in x.y.z" entry added to the end of each affected release's Doc/whatsnew/x.y.rst file. -- ___ Python tracker

[issue38248] inconsistency in asyncio.Task between cancellation while running vs. cancellation immediately after it finishes

2019-09-22 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +15907 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16330 ___ Python tracker ___

[issue38251] urllib.request memory leak / overflow

2019-09-22 Thread Steve Dower
Steve Dower added the comment: Closing as a duplicate of issue35941 -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> ssl.enum_certificates() regression ___ Python tracker