[issue38789] difflib lacks a way to check if results are empty

2019-11-18 Thread Simon Friedberger
Simon Friedberger added the comment: Hi Tim! Sorry, if my explanation wasn't clear. For some of the iterators - like the one produced by ndiff - the iterator will always return data, even if there is no difference in the files. My current solution is to run difflib.unified_diff and check

[issue38789] difflib lacks a way to check if results are empty

2019-11-18 Thread Simon Friedberger
Simon Friedberger added the comment: And, just to state this explicitly, I think you are right that there are general idioms for checking if a generator can produce an item but I think it would be nicer if iterators which could do this is in a cheap way (like in this case) would allow it

[issue22367] Add open_file_descriptor parameter to fcntl.lockf() (use the new F_OFD_SETLK flag)

2019-11-18 Thread Michael Felt
Michael Felt added the comment: FYI: I loaded the pr just now and tested on AIX. $ ./python -m test test_fcntl 0:00:00 Run tests sequentially 0:00:00 [1/1] test_fcntl == Tests result: SUCCESS == 1 test OK. Total duration: 767 ms Tests result: SUCCESS $ git status On branch pr_17154

[issue38811] Pathlib crashes when os module is missing 'link' method

2019-11-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16720 pull_request: https://github.com/python/cpython/pull/17219 ___ Python tracker ___

[issue38815] test_ssl: test_min_max_version() fails on AMD64 FreeBSD Shared 3.x

2019-11-18 Thread STINNER Victor
STINNER Victor added the comment: And the last one, AMD64 FreeBSD Shared 3.7: https://buildbot.python.org/all/#/builders/367/builds/25 FAIL: test_min_max_version (test.test_ssl.ContextTests) FAIL: test_min_max_version_mismatch (test.test_ssl.ThreadedTests) --

[issue37228] UDP sockets created by create_datagram_endpoint() allow by default multiple processes to bind the same port

2019-11-18 Thread Jukka Väisänen
Jukka Väisänen added the comment: I definitely propose changing the default for UDP sockets. Having multiple processes binding to a the same port and load-balancing incoming UDP traffic intentionally is a rare scenario which should be supported but not the default. For TCP the default is

[issue9625] argparse: Problem with defaults for variable nargs when using choices

2019-11-18 Thread Mihail Milushev
Mihail Milushev added the comment: It looks like choices are broken for nargs='*' even without using default: >>> import argparse >>> parser = argparse.ArgumentParser() >>> parser.add_argument('test', nargs='*', choices=['foo', 'bar', 'baz']) _StoreAction(option_strings=[], dest='test',

[issue38656] mimetypes for python 3.7.5 fails to detect matroska video

2019-11-18 Thread Florian Bruhin
Florian Bruhin added the comment: I'm seeing the same in ranger and I'm currently trying to debug this - I'm still not quite sure what I'm seeing as there seem to be various issues/weirdnesses which overlap each other. This strikes me as odd: >>> import mimetypes >>>

[issue37228] UDP sockets created by create_datagram_endpoint() allow by default multiple processes to bind the same port

2019-11-18 Thread Jukka Väisänen
Jukka Väisänen added the comment: Can we still consider this for 3.9? I still think this is an easy way to accidentally blow your foot off with something that will probably only show up in production. -- versions: +Python 3.9 -Python 3.7 ___

[issue37228] UDP sockets created by create_datagram_endpoint() allow by default multiple processes to bind the same port

2019-11-18 Thread Andrew Svetlov
Andrew Svetlov added the comment: I see two proposals: 1. Change the default for reuse_address flag 2. Document existing behavior as dangerous. What is the suggestion? Pick one, please :) -- ___ Python tracker

[issue38811] Pathlib crashes when os module is missing 'link' method

2019-11-18 Thread STINNER Victor
STINNER Victor added the comment: The change failed on x86 Windows7 3.x buildbot: https://buildbot.python.org/all/#/builders/58/builds/3257 Moreover, PR 17170 was merged whereas the CLA was not signed. So I created PR 17219 to revert the change to fix the Windows 7 failure and to wait until

[issue38811] Pathlib crashes when os module is missing 'link' method

2019-11-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 59c80889ff3f74230a613732aacf93d4de1e0e04 by Victor Stinner in branch 'master': Revert "bpo-38811: Check for presence of os.link method in pathlib. (GH-17170)" (#17219)

[issue38656] mimetypes for python 3.7.5 fails to detect matroska video

2019-11-18 Thread Florian Bruhin
Florian Bruhin added the comment: I now bisected this with the following script: #!/bin/bash git clean -dxf ./configure || exit 125 make -j2 || exit 125 output=$(./python -c "import mimetypes; mt = mimetypes.MimeTypes(); print(mt.guess_type('E01.mkv')[0])") echo "$output" echo "$(git

[issue38830] `A Qt GUI for logging` produces TypeError

2019-11-18 Thread Vinay Sajip
Change by Vinay Sajip : -- keywords: +patch pull_requests: +16721 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17220 ___ Python tracker ___

[issue38830] `A Qt GUI for logging` produces TypeError

2019-11-18 Thread Vinay Sajip
Change by Vinay Sajip : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5, Python 3.6 ___ Python tracker ___

[issue16576] ctypes: structure with bitfields as argument

2019-11-18 Thread miss-islington
Change by miss-islington : -- pull_requests: +16724 pull_request: https://github.com/python/cpython/pull/17223 ___ Python tracker ___

[issue16576] ctypes: structure with bitfields as argument

2019-11-18 Thread miss-islington
Change by miss-islington : -- pull_requests: +16725 pull_request: https://github.com/python/cpython/pull/17224 ___ Python tracker ___

[issue26978] Implement pathlib.Path.link (Using os.link)

2019-11-18 Thread Toke Høiland-Jørgensen
Change by Toke Høiland-Jørgensen : -- pull_requests: +16727 pull_request: https://github.com/python/cpython/pull/17225 ___ Python tracker ___

[issue38656] mimetypes for python 3.7.5 fails to detect matroska video

2019-11-18 Thread Florian Bruhin
Florian Bruhin added the comment: Ah, I think I see what's happening now. Before that commit, when doing "mt = mimetypes.MimeTypes()", its self.types_map is populated as follows: - Its __init__ method calls the mimetypes.init() function. - That then reads all the files in

[issue38656] mimetypes for python 3.7.5 fails to detect matroska video

2019-11-18 Thread Florian Bruhin
Change by Florian Bruhin : -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38830] `A Qt GUI for logging` produces TypeError

2019-11-18 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 5383956583bb758f3828513bcdd011871f24a0e8 by Vinay Sajip in branch 'master': bpo-38830: Correct slot signature in Qt example. (GH-17220) https://github.com/python/cpython/commit/5383956583bb758f3828513bcdd011871f24a0e8 --

[issue38830] `A Qt GUI for logging` produces TypeError

2019-11-18 Thread Vinay Sajip
Change by Vinay Sajip : -- pull_requests: +16723 pull_request: https://github.com/python/cpython/pull/17222 ___ Python tracker ___

[issue38830] `A Qt GUI for logging` produces TypeError

2019-11-18 Thread Vinay Sajip
Change by Vinay Sajip : -- pull_requests: +16722 pull_request: https://github.com/python/cpython/pull/17221 ___ Python tracker ___

[issue38830] `A Qt GUI for logging` produces TypeError

2019-11-18 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 9a4c5c30d93278e420a7dadafbaa35a5b52325ec by Vinay Sajip in branch '3.7': [3.7] bpo-38830: Correct slot signature in Qt example. (GH-17220) (GH-17222) https://github.com/python/cpython/commit/9a4c5c30d93278e420a7dadafbaa35a5b52325ec --

[issue38830] `A Qt GUI for logging` produces TypeError

2019-11-18 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 21eb731057d614fb642c609ae89f66d75fa0ac3a by Vinay Sajip in branch '3.8': [3.8] bpo-38830: Correct slot signature in Qt example. (GH-17220) (GH-17221) https://github.com/python/cpython/commit/21eb731057d614fb642c609ae89f66d75fa0ac3a --

[issue38811] Pathlib crashes when os module is missing 'link' method

2019-11-18 Thread Toke Høiland-Jørgensen
Change by Toke Høiland-Jørgensen : -- pull_requests: +16726 pull_request: https://github.com/python/cpython/pull/17225 ___ Python tracker ___

[issue38656] mimetypes for python 3.7.5 fails to detect matroska video

2019-11-18 Thread David K. Hess
David K. Hess added the comment: Hi, I'm the author of the commit that's been fingered. Some comments about the behavior being reported First, as pointed out by @xtreak, indeed the mimetypes module uses mimetypes files present on the platform to add to the built in list of mimetypes. In

[issue38656] mimetypes for python 3.7.5 fails to detect matroska video

2019-11-18 Thread Florian Bruhin
Florian Bruhin added the comment: Ah, I only saw dhess' comment after already submitting mine. > By historical design, instantiating a MimeTypes class instance directly will > not use host OS system mime type files. Yet that wasn't what happened before that commit, and it's also not the

[issue38823] Improve stdlib module initialization error handling.

2019-11-18 Thread miss-islington
miss-islington added the comment: New changeset 42a4359390b78b3360e100fc9c075495e48354b2 by Miss Islington (bot) in branch '3.8': bpo-38823: Clean up refleaks in _tkinter initialization. (GH-17206) https://github.com/python/cpython/commit/42a4359390b78b3360e100fc9c075495e48354b2 --

[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-18 Thread STINNER Victor
New submission from STINNER Victor : The bpo-29137 removed the fpectl module. But two macros were kept in pyfpe.h: /* These macros used to do something when Python was built with --with-fpectl, * but support for that was dropped in 3.7. We continue to define them though, * to avoid breaking

[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-18 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +16730 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17228 ___ Python tracker ___

[issue38823] Improve stdlib module initialization error handling.

2019-11-18 Thread miss-islington
miss-islington added the comment: New changeset 9e4d0312101cc2bc44a9549974d4a25f80e1dc12 by Miss Islington (bot) in branch '3.7': bpo-38823: Clean up refleaks in _tkinter initialization. (GH-17206) https://github.com/python/cpython/commit/9e4d0312101cc2bc44a9549974d4a25f80e1dc12 --

[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16731 pull_request: https://github.com/python/cpython/pull/17231 ___ Python tracker ___

[issue29137] Fix fpectl-induced ABI breakage

2019-11-18 Thread STINNER Victor
STINNER Victor added the comment: I propose PR 17231: "PyFPE_START_PROTECT() and PyFPE_END_PROTECT() macros are empty: they do nothing for one year (since commit 735ae8d), stop using them." -- nosy: +vstinner ___ Python tracker

[issue16576] ctypes: structure with bitfields as argument

2019-11-18 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset bef2815533011be9f0ce5fa2965bcada76b509b8 by Vinay Sajip (Miss Islington (bot)) in branch '3.8': bpo-16576: Add checks for bitfields passed by value to functions. (GH-17097) (GH-17223)

[issue38656] mimetypes for python 3.7.5 fails to detect matroska video

2019-11-18 Thread David K. Hess
David K. Hess added the comment: The documentation you quoted does read to me as compatible? The database it is referring to is the one hardcoded in the module – not the one assembled from that and the host OS. But, maybe this is just the vagaries of language and perspective at play. Anyway

[issue38835] pyfpe.h: Exclude PyFPE_START_PROTECT and PyFPE_END_PROTECT from the Py_LIMITED_API

2019-11-18 Thread STINNER Victor
STINNER Victor added the comment: Python/pyfpe.c still contains two variables (PyFPE_jbuf and PyFPE_counter) and one function (PyFPE_dummy) for ABI compatibility: --- /* These variables used to be used when Python was built with --with-fpectl, * but support for that was dropped in 3.7. We

[issue38823] Improve stdlib module initialization error handling.

2019-11-18 Thread miss-islington
Change by miss-islington : -- pull_requests: +16729 pull_request: https://github.com/python/cpython/pull/17227 ___ Python tracker ___

[issue38823] Improve stdlib module initialization error handling.

2019-11-18 Thread miss-islington
miss-islington added the comment: New changeset 289cf0fbf78c4f38c38ac71ac8b772be7ec2672f by Miss Islington (bot) (Brandt Bucher) in branch 'master': bpo-38823: Clean up refleaks in _tkinter initialization. (GH-17206)

[issue38823] Improve stdlib module initialization error handling.

2019-11-18 Thread miss-islington
Change by miss-islington : -- pull_requests: +16728 pull_request: https://github.com/python/cpython/pull/17226 ___ Python tracker ___

[issue38631] Replace Py_FatalError() with regular Python exceptions

2019-11-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16732 pull_request: https://github.com/python/cpython/pull/17232 ___ Python tracker ___

[issue37228] UDP sockets created by create_datagram_endpoint() allow by default multiple processes to bind the same port

2019-11-18 Thread Yury Selivanov
Yury Selivanov added the comment: I'd be -1 on changing the default of an existing method, at least without consulting with a wider audience. We can add a new method to the loop and deprecate create_datagram_endpoint. I suggest to post to python-dev and discuss this before making any

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread Jason Killen
Jason Killen added the comment: Tests working now. PR submitted. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue38644] Pass explicitly tstate to function calls

2019-11-18 Thread STINNER Victor
STINNER Victor added the comment: One further step would be to change the VECTORCALL/FASTCALL calling convention to pass tstate. But I am not sure what is the risk to do that in Python 3.9? Cython uses FASTCALL internally for example. -- ___

[issue38631] Replace Py_FatalError() with regular Python exceptions

2019-11-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset bc7d3aa6d74b718699b7a6bced9b0dfdfbf95c13 by Victor Stinner in branch 'master': bpo-38631: Avoid Py_FatalError() in _multibytecodec init (GH-17233) https://github.com/python/cpython/commit/bc7d3aa6d74b718699b7a6bced9b0dfdfbf95c13 --

[issue38631] Replace Py_FatalError() with regular Python exceptions

2019-11-18 Thread STINNER Victor
STINNER Victor added the comment: New changeset 04394df74b3d0783893da7dafa7803a003516402 by Victor Stinner in branch 'master': bpo-38631: Avoid Py_FatalError() in float.__getformat__() (GH-17232) https://github.com/python/cpython/commit/04394df74b3d0783893da7dafa7803a003516402 --

[issue38812] Comparing datetime.time objects incorrect for TZ aware and unaware

2019-11-18 Thread Jason Killen
Jason Killen added the comment: Yep I wasn't seeing the forest for the trees. Thanks for clearing that up. I'll swoop back in and see what I can do. -- ___ Python tracker

[issue38823] Improve stdlib module initialization error handling.

2019-11-18 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16735 pull_request: https://github.com/python/cpython/pull/17235 ___ Python tracker ___

[issue23407] os.walk always follows Windows junctions

2019-11-18 Thread Steve Dower
Steve Dower added the comment: At a minimum, it needs to be turned into a GitHub PR. We've made some significant changes in this area in 3.8, so possibly the best available code is now in shutil.rmtree (or shutil.copytree) rather than the older patch files. --

[issue38823] Improve stdlib module initialization error handling.

2019-11-18 Thread Brandt Bucher
Change by Brandt Bucher : -- pull_requests: +16736 pull_request: https://github.com/python/cpython/pull/17236 ___ Python tracker ___

[issue38631] Replace Py_FatalError() with regular Python exceptions

2019-11-18 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +16733 pull_request: https://github.com/python/cpython/pull/17233 ___ Python tracker ___

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread Jason Killen
Change by Jason Killen : -- keywords: +patch pull_requests: +16734 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17234 ___ Python tracker ___

[issue38836] Links are duplicated in documentation search result

2019-11-18 Thread MaT1g3R
New submission from MaT1g3R : When I do a search in documentation, for example: https://docs.python.org/3.9/search.html?q=os.walk The links in the results are sometimes duplicated, for example this link below shows up twice in the search result:

[issue38836] Links are duplicated in documentation search result

2019-11-18 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +mdk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33125] Windows 10 ARM64 platform support

2019-11-18 Thread Steve Dower
Steve Dower added the comment: If the patches are for Tcl/Tk, then you should submit it to them. I'm not a Tk maintainer, and I never want to be one, so frankly I'd be happier to say it's not supported on ARM :) But if it builds fine with our PCbuild/prepare_tcltk.bat script and people want

[issue38822] Inconsistent os.stat behavior for directory with Access Denied

2019-11-18 Thread Steve Dower
Steve Dower added the comment: I haven't debugged it, but I'm guessing we're not handling the trailing slash properly when falling back to asking the parent directory for information. Looking at the actual stat result for "C:\System Volume Information" vs. "C:\Windows", most of the

[issue38837] struct.pack: Unable to pack more than 256 bytes at a time

2019-11-18 Thread Dave Lotton
New submission from Dave Lotton : Using struct.pack it is not possible (Python 3.6.8 and 2.7.15) to pack more than 256 bytes at a time. This seems like an arbitrarily small number, and seems to be inconsistent with the capabilities of the unpack function, which is able to unpack a larger

[issue38597] C Extension import limit

2019-11-18 Thread Steve Dower
Steve Dower added the comment: Could you share just one of your .pyd files? Without being able to see whether they are compiled incorrectly, it's hard to be sure whether this is the same cause as before. It certainly looks like distutils is still going to link correctly. --

[issue38809] On Windows, build scripts should prefer using python.exe from an active virtual env

2019-11-18 Thread miss-islington
Change by miss-islington : -- pull_requests: +16738 pull_request: https://github.com/python/cpython/pull/17238 ___ Python tracker ___

[issue38809] On Windows, build scripts should prefer using python.exe from an active virtual env

2019-11-18 Thread miss-islington
miss-islington added the comment: New changeset ee703cbb418b7458bebb1d26a5e19d6b55280b28 by Miss Islington (bot) (Tal Einat) in branch 'master': bpo-38809: Windows build scripts use python.exe from virtual envs (GH-17164)

[issue38809] On Windows, build scripts should prefer using python.exe from an active virtual env

2019-11-18 Thread miss-islington
Change by miss-islington : -- pull_requests: +16737 pull_request: https://github.com/python/cpython/pull/17237 ___ Python tracker ___

[issue38453] ntpath.realpath() does not fully resolve relative paths

2019-11-18 Thread Steve Dower
Steve Dower added the comment: Closing this as I believe it's done, but happy to reopen if we find another edge case (or start a new issue). -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38821] argparse calls ngettext with deprecated non-integer value

2019-11-18 Thread paul j3
Change by paul j3 : -- nosy: +paul.j3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38809] On Windows, build scripts should prefer using python.exe from an active virtual env

2019-11-18 Thread miss-islington
miss-islington added the comment: New changeset 2b928d9bf75d82b86dc3b4fcbc243d36a7958f4c by Miss Islington (bot) in branch '3.7': bpo-38809: Windows build scripts use python.exe from virtual envs (GH-17164) https://github.com/python/cpython/commit/2b928d9bf75d82b86dc3b4fcbc243d36a7958f4c

[issue38809] On Windows, build scripts should prefer using python.exe from an active virtual env

2019-11-18 Thread miss-islington
miss-islington added the comment: New changeset cbbf1098f383e575d93841e555329eb66283c2f1 by Miss Islington (bot) in branch '3.8': bpo-38809: Windows build scripts use python.exe from virtual envs (GH-17164) https://github.com/python/cpython/commit/cbbf1098f383e575d93841e555329eb66283c2f1

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread miss-islington
Change by miss-islington : -- pull_requests: +16740 pull_request: https://github.com/python/cpython/pull/17241 ___ Python tracker ___

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread Tal Einat
Tal Einat added the comment: Thanks Steve! I hadn't realized that we'd made such a declaration WRT opening of code files in general. In that case, this is certainly at least a bug fix, and should be backported. -- type: enhancement -> security versions: +Python 3.8

[issue38622] _ctypes.dlsym (py_dl_sym) does not trigger audit hooks

2019-11-18 Thread Steve Dower
Steve Dower added the comment: Typically, as soon as I merge, I spot an edge case issue. PySys_Audit(n, "O", a) is deliberately going to treat 'a' as the tuple of arguments (when it is a tuple). This lets us simplify/optimise events where the event arguments match the function arguments

[issue38622] _ctypes.dlsym (py_dl_sym) does not trigger audit hooks

2019-11-18 Thread miss-islington
miss-islington added the comment: New changeset bec7015dcc421a68cde030c5e4ca8e28408ef52d by Miss Islington (bot) in branch '3.8': bpo-38622: Ensure ctypes.PyObj_FromPtr audit event passes tuples as a single argument (GH-17243)

[issue38622] _ctypes.dlsym (py_dl_sym) does not trigger audit hooks

2019-11-18 Thread miss-islington
Change by miss-islington : -- pull_requests: +16744 pull_request: https://github.com/python/cpython/pull/17245 ___ Python tracker ___

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread miss-islington
miss-islington added the comment: New changeset e37767bee1f7f1940b30768d21bfe2ae68c20a5f by Miss Islington (bot) in branch '3.8': bpo-38722: Runpy use io.open_code() (GH-17234) https://github.com/python/cpython/commit/e37767bee1f7f1940b30768d21bfe2ae68c20a5f --

[issue38597] C Extension import limit

2019-11-18 Thread Yurii Leonov
Yurii Leonov added the comment: Done: .pyd files are added in https://github.com/Yuriy-Leonov/cython_imports_limit_issue/commit/2f9e7c02798fb52185dabfe6ce3811c439ca2839 folder with name "dist_example_with_error" -- versions: +Python 3.6 -Python 3.7, Python 3.8, Python 3.9

[issue38809] On Windows, build scripts should prefer using python.exe from an active virtual env

2019-11-18 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38838] Exception ignored in: module 'threading' in _shutdown, _signal_handler

2019-11-18 Thread wesinator
New submission from wesinator <13hu...@gmail.com>: macOS 10.14.6 python 3.7.5 Exception ignored in: Traceback (most recent call last): File "/usr/local/Cellar/python/3.7.5/Frameworks/Python.framework/Versions/3.7/lib/python3.7/threading.py", line 1274, in _shutdown def _shutdown():

[issue38818] Modify PyInterpreterState.eval_frame to pass tstate (PyThreadState)

2019-11-18 Thread Brett Cannon
Brett Cannon added the comment: I think bpo-38500 needs to get resolved first before this as that will affect whether this is acceptable or not as an API-breaking change. -- ___ Python tracker

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread Tal Einat
Tal Einat added the comment: I don't see why this should be considered a security issue. This should likely have been done when io.open_code() was initially added, but now that 3.8 is out, I don't think backporting this would be wise. -- nosy: +taleinat type: security -> enhancement

[issue17013] Allow waiting on a mock

2019-11-18 Thread Ilya Kulakov
Ilya Kulakov added the comment: I have submitted an alternative implementation of this feature heavily inspired by _AwaitEvent I wrote for asynctest [0]. There was recently an interest from the community towards asynctest to the point that got some of its measures merged into CPython [1].

[issue38622] _ctypes.dlsym (py_dl_sym) does not trigger audit hooks

2019-11-18 Thread miss-islington
Change by miss-islington : -- pull_requests: +16741 pull_request: https://github.com/python/cpython/pull/17242 ___ Python tracker ___

[issue38622] _ctypes.dlsym (py_dl_sym) does not trigger audit hooks

2019-11-18 Thread Steve Dower
Steve Dower added the comment: New changeset 00923c63995e34cdc25d699478f113de99a69df9 by Steve Dower in branch 'master': bpo-38622: Add missing audit events for ctypes module (GH-17158) https://github.com/python/cpython/commit/00923c63995e34cdc25d699478f113de99a69df9 --

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread Steve Dower
Steve Dower added the comment: > I hadn't realized that we'd made such a declaration WRT opening of code files > in general. It wasn't exactly a hugely publicised declaration :) The relevant quote from PEP 578 is: > All import and execution functionality involving code from a file will be

[issue38622] _ctypes.dlsym (py_dl_sym) does not trigger audit hooks

2019-11-18 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +16742 pull_request: https://github.com/python/cpython/pull/17243 ___ Python tracker ___

[issue22593] Automate update of doc references to UCD version when it changes.

2019-11-18 Thread Batuhan
Batuhan added the comment: I want to work on this. What do you think about using include directive and include a static file like UCD_VERSION.txt in the documents? makeunicodedata.py can write the current version every run to UCD_VERSION.txt -- nosy: +BTaskaya

[issue37228] UDP sockets created by create_datagram_endpoint() allow by default multiple processes to bind the same port

2019-11-18 Thread Jukka Väisänen
Jukka Väisänen added the comment: Sure, I fully appreciate implications of changing default behaviour and will post on python-dev. -- ___ Python tracker ___

[issue38622] _ctypes.dlsym (py_dl_sym) does not trigger audit hooks

2019-11-18 Thread miss-islington
miss-islington added the comment: New changeset 47db7439dd858c3634212c71137eb130f811bda4 by Miss Islington (bot) in branch '3.8': bpo-38622: Add missing audit events for ctypes module (GH-17158) https://github.com/python/cpython/commit/47db7439dd858c3634212c71137eb130f811bda4 --

[issue22367] Add open_file_descriptor parameter to fcntl.lockf() (use the new F_OFD_SETLK flag)

2019-11-18 Thread Łukasz Langa
Łukasz Langa added the comment: Note: this is affecting the release of Python 3.9.0a1. I will be continuing with the release in 12 hours. If the failing macOS test is not fixed by then, alpha1 will ship in this state. However, I will be blocking alpha2 if this is still the case. Please

[issue35943] PyImport_GetModule() can return partially-initialized module

2019-11-18 Thread Valentyn Tymofieiev
Valentyn Tymofieiev added the comment: Do we plan to backport the change by nanjekyejoannah to 3.7 branch? -- nosy: +Valentyn Tymofieiev ___ Python tracker ___

[issue35004] Odd behavior when using datetime.timedelta under cProfile

2019-11-18 Thread Batuhan
Batuhan added the comment: This bug is fixed in both 3.8 and 3.7, @p-ganssle what do you think about closing this? -- nosy: +BTaskaya ___ Python tracker ___

[issue38838] Exception ignored in: module 'threading' in _shutdown, _signal_handler

2019-11-18 Thread wesinator
wesinator <13hu...@gmail.com> added the comment: didn't see this was a third party package. disregard. sorry -- resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread Zachary Ware
Change by Zachary Ware : -- nosy: +steve.dower ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread Tal Einat
Tal Einat added the comment: Thanks for reporting this, Dominic! Thanks for the PR, Jason! -- ___ Python tracker ___ ___

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38721] modulefinder should use import hooks properly

2019-11-18 Thread Dominic Littlewood
Dominic Littlewood <11dlittlew...@gmail.com> added the comment: I now have a PR which - dare I say it - appears to be working as it should. I'll just write some tests for it and then I'll send it off for review. -- ___ Python tracker

[issue37228] UDP sockets created by create_datagram_endpoint() allow by default multiple processes to bind the same port

2019-11-18 Thread Guido van Rossum
Guido van Rossum added the comment: I agree that this is a bad default (and whoever wrote it, probably me, didn't know what this does for UDP). I think the right solution is to change the default, not to introduce a new method. Maybe we can deprecate the default somehow? There currently is

[issue38622] _ctypes.dlsym (py_dl_sym) does not trigger audit hooks

2019-11-18 Thread Steve Dower
Steve Dower added the comment: New changeset dcf1f83de8678b09df5bd7d04ca5f4ef1cd02aca by Steve Dower in branch 'master': bpo-38622: Ensure ctypes.PyObj_FromPtr audit event passes tuples as a single argument (GH-17243)

[issue38722] runpy should use io.open_code() instead of open()

2019-11-18 Thread miss-islington
Change by miss-islington : -- pull_requests: +16743 pull_request: https://github.com/python/cpython/pull/17244 ___ Python tracker ___

[issue25172] Unix-only crypt should not be present on Windows.

2019-11-18 Thread Xavier de Gaye
Xavier de Gaye added the comment: test_crypt fails on android following last changes made at 243a73deee4ac61fe06602b7ed56b6df01e19f27. The android libc does not have a crypt() function and the _crypt module is not built. generic_x86_64:/data/local/tmp/python $ python Python 3.9.0a0

[issue32371] Delay-loading of python dll is impossible when using some C macros

2019-11-18 Thread Batuhan
Batuhan added the comment: Can you give us a case where we can reproduce this locally? -- nosy: +BTaskaya ___ Python tracker ___

[issue38500] Provide a way to get/set PyInterpreterState.frame_eval without needing to access interpreter internals

2019-11-18 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +16739 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17187 ___ Python tracker ___

[issue37228] UDP sockets created by create_datagram_endpoint() allow by default multiple processes to bind the same port

2019-11-18 Thread Nathaniel Smith
Nathaniel Smith added the comment: Ouch, that's nasty. It also has security implications. For example, suppose you have a multi-user computer, where one user is has a video call going, which transfers packets over UDP. Another user could check what port they're using, bind to the same port,

  1   2   >