[issue39573] Make PyObject an opaque structure in the limited C API

2020-03-06 Thread Andy Lester
Change by Andy Lester : -- pull_requests: +18167 pull_request: https://github.com/python/cpython/pull/18809 ___ Python tracker ___

[issue39877] Daemon thread is crashing in PyEval_RestoreThread() while the main thread is exiting the process

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18166 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18808 ___ Python tracker ___

[issue39874] Heappush of Maxheap version does not exist

2020-03-06 Thread Raymond Hettinger
Raymond Hettinger added the comment: The maxheap is not part of the public API. It is for internal use by merge() and nsmallest(). -- assignee: -> rhettinger nosy: +rhettinger resolution: -> rejected stage: patch review -> resolved status: open -> closed

[issue39872] Remove unused args from two functions in Python/symtable.c

2020-03-06 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset 9566842e892c1f600e1dcfadaab4643be8f32901 by Andy Lester in branch 'master': closes bpo-39872: Remove unused args from symtable_exit_block and symtable_visit_annotations. (GH-18800)

[issue39876] csv.DictReader.fieldnames interprets unicode as ascii

2020-03-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: csv.DictReader does not work with encodings. It works with already decoded strings. You have to specify the correct encoding in open() (and "t" in mode is ignored): with open(filename, "r", encoding="utf-8") as csvfile: By default open() uses locale

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18165 pull_request: https://github.com/python/cpython/pull/18807 ___ Python tracker ___

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 1fb5a9f394a6fdf62e21b96080c3257c959cf8c9 by Victor Stinner in branch 'master': bpo-39873: PyObject_Init() uses PyObject_INIT() (GH-18804) https://github.com/python/cpython/commit/1fb5a9f394a6fdf62e21b96080c3257c959cf8c9 --

[issue39877] Daemon thread is crashing in PyEval_RestoreThread() while the main thread is exiting the process

2020-03-06 Thread STINNER Victor
STINNER Victor added the comment: Patch to get a cleaner error if the bug occurs, but also to make the bug more reliable: diff --git a/Python/ceval.c b/Python/ceval.c index ef4aac2f9a..8bf1e4766d 100644 --- a/Python/ceval.c +++ b/Python/ceval.c @@ -382,7 +382,8 @@ PyEval_SaveThread(void)

[issue39877] Daemon thread is crashing in PyEval_RestoreThread() while the main thread is exiting the process

2020-03-06 Thread STINNER Victor
STINNER Victor added the comment: > This issue should be the root cause of bpo-39088: "test_concurrent_futures > crashed with python.core core dump on AMD64 FreeBSD Shared 3.x", (...) I marked bpo-39088 as a duplicate of this issue. -- ___ Python

[issue39088] test_concurrent_futures crashed with python.core core dump on AMD64 FreeBSD Shared 3.x

2020-03-06 Thread STINNER Victor
STINNER Victor added the comment: I identified the root cause: bpo-39877. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Daemon thread is crashing in PyEval_RestoreThread() while the main thread is exiting the process

[issue39877] Daemon thread is crashing in PyEval_RestoreThread() while the main thread is exiting the process

2020-03-06 Thread STINNER Victor
STINNER Victor added the comment: To reproduce the bug on Linux: * apply attached slow_exit.patch to sleep 1 second just before exiting the process, in the main() function * run: ./python daemon_threads_exit.py # attached file Example: --- $ ./python daemon_threads_exit.py Start 100 daemon

[issue39868] Stale Python Language Reference docs (no walrus).

2020-03-06 Thread SHANKAR JHA
SHANKAR JHA added the comment: I got it that I have to fill the "Assignment expression" section in the code. I am working on it and send you the for review once I am done. -- ___ Python tracker

[issue39877] Daemon thread is crashing in PyEval_RestoreThread() while the main thread is exiting the process

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : Added file: https://bugs.python.org/file48958/daemon_threads_exit.py ___ Python tracker ___ ___ Python-bugs-list

[issue39875] urllib.request.urlopen sends POST data as query string

2020-03-06 Thread henrik242
henrik242 added the comment: Here's the wireshark output. It seems that urllib adds a "Connection: close" which curl doesn't. Solr doesn't seem to like that. Curl message: POST /solr/my_coll/update?commit=true HTTP/1.1 Host: solr.example.no:12699 User-Agent: curl/7.64.1 Accept: */*

[issue39852] IDLE: Goto should remove selection and update the status bar

2020-03-06 Thread Dave Liptack
Dave Liptack added the comment: Like goto, right-click also exhibits this behavior. Should selection_clear also be added to right-click code? -- ___ Python tracker ___

[issue39875] urllib.request.urlopen sends POST data as query string

2020-03-06 Thread henrik242
henrik242 added the comment: The following gives the same failing result too :( >>> import urllib.request >>> data = 'KEY__9927.1>> name="value">{"result":0,"jobId":"9459695","jobNumber":"9927.1"}' >>> url = 'http://solr.example.no:12699/solr/my_coll/update?commit=true' >>> res =

[issue39877] Daemon thread is crashing in PyEval_RestoreThread() while the main thread is exiting the process

2020-03-06 Thread STINNER Victor
New submission from STINNER Victor : Sometimes, test_multiprocessing_spawn does crash in PyEval_RestoreThread() on FreeBSD with a coredump. This issue should be the root cause of bpo-39088: "test_concurrent_futures crashed with python.core core dump on AMD64 FreeBSD Shared 3.x", where the

[issue39875] urllib.request.urlopen sends POST data as query string

2020-03-06 Thread henrik242
henrik242 added the comment: Also, it seems that urllib.urlopen just creates a similar Request object when given a data paramenter: def open(self, fullurl, data=None, timeout=socket._GLOBAL_DEFAULT_TIMEOUT): # accept a URL or a Request object if isinstance(fullurl, str):

[issue39875] urllib.request.urlopen sends POST data as query string

2020-03-06 Thread henrik242
henrik242 added the comment: Further: method should be a string that indicates the HTTP request method that will be used (e.g. 'HEAD'). If provided, its value is stored in the method attribute and is used by get_method(). The default is 'GET' if data is None or 'POST' otherwise.

[issue39868] Stale Python Language Reference docs (no walrus).

2020-03-06 Thread SHANKAR JHA
SHANKAR JHA added the comment: I am also checking your commit for this: (https://github.com/python/cpython/commit/8bae21962bab2fac7630982abd73676b89930902) and see that you are changing the "expression: to "assignment_expression". Do I have to fill what assignment expression does with some

[issue39875] urllib.request.urlopen sends POST data as query string

2020-03-06 Thread henrik242
henrik242 added the comment: But why can't the payload be in the Request object? >From the api docs: class urllib.request.Request(url, data=None, headers={}, origin_req_host=None, unverifiable=False, method=None) data must be an object specifying additional data to send to the

[issue39868] Stale Python Language Reference docs (no walrus).

2020-03-06 Thread SHANKAR JHA
SHANKAR JHA added the comment: Thank you for helping me out brandtbucher. As per my understanding, I am looking into the code (https://github.com/python/cpython/blob/master/Doc/reference/expressions.rst) and finding where the code doesn't follow the pattern described in

[issue39876] csv.DictReader.fieldnames interprets unicode as ascii

2020-03-06 Thread Andreas Spar
New submission from Andreas Spar : with open(filename, "rt") as csvfile: csv_reader = csv.DictReader(csvfile, delimiter=csv_delimiter) filednames = csv_reader.fieldnames In Python 3.8 csv expects utf-8 encoded files but apperently doens't read the header with utf-8 format. If

[issue39871] math.copysign raises SystemError with non-float x and custom y

2020-03-06 Thread Zackery Spytz
Zackery Spytz added the comment: I have created a pull request to fix this issue. Please consider taking a look. -- ___ Python tracker ___

[issue39871] math.copysign raises SystemError with non-float x and custom y

2020-03-06 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 2.0 -> 3.0 pull_requests: +18164 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/18806 ___ Python tracker

[issue39875] urllib.request.urlopen sends POST data as query string

2020-03-06 Thread Adrian Petrescu
Adrian Petrescu added the comment: (Oops, that was a bad paste! I meant this link: https://docs.python.org/2/library/urllib.html#urllib.urlopen) -- ___ Python tracker ___

[issue39875] urllib.request.urlopen sends POST data as query string

2020-03-06 Thread Adrian Petrescu
Adrian Petrescu added the comment: This is not a bug, you've just misunderstood the urllib API. If you want to pass POST data as a payload, it's the second `data` parameter to `urlopen`: https://bugs.python.org/?@action=confrego=KX9AqsI0JnOLkplIY1AGKXAmDKa38COy -- nosy: +apetresc

[issue39875] urllib.request.urlopen sends POST data as query string

2020-03-06 Thread henrik242
New submission from henrik242 : curl correctly posts data to Solr: $ curl -v 'http://solr.example.no:12699/solr/my_coll/update?commit=true' \ --data 'KEY__9927.1\ {"result":0,"jobId":"9459695","jobNumber":"9927.1"}' The solr query log says: [20200306T111354,131] [my_coll_shard1_replica_n85]

[issue39874] Heappush of Maxheap version does not exist

2020-03-06 Thread BongK
Change by BongK : -- keywords: +patch pull_requests: +18163 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18805 ___ Python tracker ___

[issue3874] documentation bug: HTMLParser needs to document unknown_decl

2020-03-06 Thread BongK
Change by BongK : -- nosy: +vbnmzx1 nosy_count: 4.0 -> 5.0 pull_requests: +18162 pull_request: https://github.com/python/cpython/pull/18805 ___ Python tracker ___

[issue39874] Heappush of Maxheap version does not exist

2020-03-06 Thread BongK
Change by BongK : -- components: +Library (Lib) type: -> enhancement versions: +Python 3.8 ___ Python tracker ___ ___

[issue39874] Heappush of Maxheap version does not exist

2020-03-06 Thread BongK
New submission from BongK : heappush of maxheap version does not exist in heapq.py -- messages: 363501 nosy: vbnmzx1 priority: normal severity: normal status: open title: Heappush of Maxheap version does not exist ___ Python tracker

[issue39573] Make PyObject an opaque structure in the limited C API

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18161 pull_request: https://github.com/python/cpython/pull/18804 ___ Python tracker ___

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +inada.naoki, pablogsal, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
STINNER Victor added the comment: See also bpo-38392: "Ensure that objects entering the GC are valid". I fixed this one with commit 1b1845569539db5c1a6948a5d32daea381f1e35f. -- ___ Python tracker

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18160 pull_request: https://github.com/python/cpython/pull/18804 ___ Python tracker ___

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +18159 stage: -> patch review pull_request: https://github.com/python/cpython/pull/18803 ___ Python tracker ___

[issue39873] Debug mode: check if objects are valid

2020-03-06 Thread STINNER Victor
New submission from STINNER Victor : One of the worst issue that I had to debug is a crash in the Python garbage collector. It is usually a crash in visit_decref(). See my notes: https://pythondev.readthedocs.io/debug_tools.html#debug-crash-in-garbage-collection-visit-decref My previous

[issue39837] Remove Azure Pipelines from GitHub PRs

2020-03-06 Thread Steve Dower
Steve Dower added the comment: It would make the job definition significantly more complicated, and I don't want to do that just to work around an issue with github until we've got positive confirmation that the behaviour is intentional and won't change. --

[issue39856] glob : some 'unix style' glob items are not supported

2020-03-06 Thread Je GeVa
Je GeVa added the comment: well ; 1) tilde expansion this is an issue 2) brace expansion have no clue how the engineers at the fruity company maimed your bash and zsh man but brace expansion is core to both of them. https://www.gnu.org/software/bash/manual/html_node/Brace-Expansion.html

[issue39871] math.copysign raises SystemError with non-float x and custom y

2020-03-06 Thread Mark Dickinson
Mark Dickinson added the comment: No problem; I'll likely pick it up (if no-one else does) in the next few days. -- assignee: -> mark.dickinson ___ Python tracker ___

[issue39871] math.copysign raises SystemError with non-float x and custom y

2020-03-06 Thread David Vo
David Vo added the comment: I'm currently rather busy with other work, but if this happens to still be open in a couple of months I might pick it up. -- ___ Python tracker

[issue39573] Make PyObject an opaque structure in the limited C API

2020-03-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 8767ce92d24d3687405848442e6c67cf0af1c657 by Andy Lester in branch 'master': bpo-39573: Make Py_IS_TYPE() take constant parameters (GH-18799) https://github.com/python/cpython/commit/8767ce92d24d3687405848442e6c67cf0af1c657 --

<    1   2