[issue40176] unterminated string literal tokenization error messages could be better

2020-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It could be even better. Inside the tokenizer we know where the string literal starts and what quotes it uses. The line and the offset of the *start* of the literal can be set in a SyntaxError. -- nosy: +serhiy.storchaka

[issue40145] Pyshellext room for binary size improvement

2020-04-03 Thread Alexander Riccio
Alexander Riccio added the comment: Ahh, ok. Even though I question the usefulness of manually maintaining MSBuild files instead of something like CMake, I can work with that. Is there a preferred way to do it? It looks like I can do a

[issue40110] multiprocessing.Pool.imap() should be lazy

2020-04-03 Thread Tim Peters
Tim Peters added the comment: Whenever there's parallel processing with communication, there's always the potential for producers to pump out data faster than consumers can process them. But builtin primitives generally don't try to address that directly. They don't - and can't - know

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1f

2020-04-03 Thread Steve Dower
Steve Dower added the comment: I've pushed new binaries for OpenSSL 1.1.1f on Windows. I'll try and to the rest over the weekend, but if someone else wants to do the PCbuild PR feel free. -- ___ Python tracker

[issue40160] documentation example of os.walk should be less destructive

2020-04-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: One possibility is a gathering cumulative directory statistics that include totals from all descendants (i.e. how many bytes of files would you save by removing the directory with rm -rf). Outside of aggregating statistics, the normal reason to use

[issue40126] Incorrect error handling in unittest.mock

2020-04-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think that the current code is not correct. __exit__ should not be called if __enter__ is failed. If some __enter__ implementation calls other __enter__s it should manually call corresponding __exit__s. -- nosy: +michael.foord, ncoghlan,

[issue40126] Incorrect error handling in unittest.mock

2020-04-03 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +18714 pull_request: https://github.com/python/cpython/pull/19351 ___ Python tracker ___

[issue40145] Pyshellext room for binary size improvement

2020-04-03 Thread Steve Dower
Steve Dower added the comment: In general, no settings rely on both Platform AND Configuration, so you likely only need to check one or the other. Look at PCbuild/pyproject.props for the best examples. IIRC, properties are set assuming Win32/Release, and then we override those that need to

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

2020-04-03 Thread Steve Dower
Steve Dower added the comment: New changeset 7f70456b92c9ff0bcc4df2a2cec213ab2a897591 by Miss Islington (bot) in branch '3.7': bpo-40158: Fix CPython MSBuild Properties in NuGet Package (GH-19343) https://github.com/python/cpython/commit/7f70456b92c9ff0bcc4df2a2cec213ab2a897591 --

[issue40158] MSBuild Extensions in CPython NuGet Package has Bad Expression

2020-04-03 Thread Steve Dower
Steve Dower added the comment: New changeset e6685ad05385f8cb492e8e1c7c07889a94517f55 by Miss Islington (bot) in branch '3.8': bpo-40158: Fix CPython MSBuild Properties in NuGet Package (GH-19343) https://github.com/python/cpython/commit/e6685ad05385f8cb492e8e1c7c07889a94517f55 --

[issue40175] Add support for removing zip entry in ZipInfo

2020-04-03 Thread Kyle Stanley
Kyle Stanley added the comment: > ZipInfo currently only allow adding entries to zip archives but doesn't have > the ability to remove entries from them - pretty useful feature. This public API enhancement seems substantial enough to warrant a python-ideas ML thread or topic in the "Ideas"

[issue40160] documentation example of os.walk should be less destructive

2020-04-03 Thread Kyle Stanley
Kyle Stanley added the comment: Serhiy Storchaka wrote: > I do not think there is clearer example of topdown=False than recursive > remove. > > If you think that this example is destructive, consider how destructive is > any possible example for shutil.rmtree()! I concur with Serhiy. If the

[issue40160] documentation example of os.walk should be less destructive

2020-04-03 Thread John Taylor
John Taylor added the comment: I made the suggested change to just print the os.remove() statements (instead of executing them) and also removed the 'skip news'. -- ___ Python tracker

<    1   2