[issue42140] asyncio.wait function creates futures set two times

Change by Denis S. Otkidach : -- nosy: +ods ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue41835] Speed up dict vectorcall creation using keywords

Inada Naoki added the comment: @Mark.Shannon I had seen some speedup on tornado benchmark when I didn't use PGO+LTO. but it was noise. Now I use PGO+LTO. master vs PR-22909: $ ./python -m pyperf compare_to master-opt.json speedup_kw-opt.json -G --min-speed=1 Slower (11): - spectral_norm: 14

[issue41835] Speed up dict vectorcall creation using keywords

Inada Naoki added the comment: @Marco Sulla > @methane: well, to be honest, I don't see much difference between the two > pulls. The major difference is that you merged insertdict_init in > dict_merge_init. Not only it but also some simplification which make 10% faster than GH-22346. > But

[issue42130] AsyncIO's wait_for can hide cancellation in a rare race condition

Change by Chris Jerdonek : -- nosy: +chris.jerdonek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue41835] Speed up dict vectorcall creation using keywords

Inada Naoki added the comment: I confirmed _PyDict_FromItems() can be used to optimize _PyStack_AsDict() too. See https://github.com/methane/cpython/pull/25 But I can not confirm significant performance gain from it too. -- ___ Python tracker

[issue42096] zipfile.is_zipfile incorrectly identifying a gzipped file as a zip archive

Change by Irit Katriel : -- nosy: +gregory.p.smith, vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24165] Free list for single-digits ints

Serhiy Storchaka added the comment: I agree that it is not worth to add this optimization. -- ___ Python tracker ___ ___ Python-bug

[issue35823] Use vfork() in subprocess on Linux

Ronald Oussoren added the comment: > From what I can tell, vfork probably also works on macOS (darwin). > > Lets let this run for a bit on Linux and it can be a separate issue to > open vfork usage up to other platforms. I'd prefer to not use vfork on macOS. For one I don't particularly trus

[issue41835] Speed up dict vectorcall creation using keywords

Marco Sulla added the comment: I commented out sqlalchemy in the requirements.txt in the pyperformance source code, and it worked. I had also to skip tornado: pyperformance run -r -b,-sqlalchemy_declarative,-sqlalchemy_imperative,-tornado_http -o ../perf_master.json This is my result: pyp

[issue33987] IDLE: use ttk.Frame for ttk widgets

Change by Mark Roseman : -- pull_requests: +21859 pull_request: https://github.com/python/cpython/pull/22941 ___ Python tracker ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

Change by Mark Roseman : -- pull_requests: +21860 pull_request: https://github.com/python/cpython/pull/22942 ___ Python tracker ___

[issue33987] IDLE: use ttk.Frame for ttk widgets

Change by Mark Roseman : -- pull_requests: +21861 pull_request: https://github.com/python/cpython/pull/22943 ___ Python tracker ___

[issue42132] Use specs instead of just __loader__ in C code

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue35823] Use vfork() in subprocess on Linux

Change by Alexey Izbyshev : -- pull_requests: +21862 pull_request: https://github.com/python/cpython/pull/22944 ___ Python tracker ___ _

[issue35823] Use vfork() in subprocess on Linux

Alexey Izbyshev added the comment: > Thank you for taking this on! I'm calling it fixed for now as the buildbots > are looking happy with it. If issues with it arise we can address them. Thank you for reviewing and merging! Using POSIX_CALL for pthread_sigmask() is incorrect, however, sinc

[issue35823] Use vfork() in subprocess on Linux

Gregory P. Smith added the comment: New changeset 473db47747bb8bc986d88ad81799bcbd88153ac5 by Alexey Izbyshev in branch 'master': bpo-35823: subprocess: Fix handling of pthread_sigmask() errors (GH-22944) https://github.com/python/cpython/commit/473db47747bb8bc986d88ad81799bcbd88153ac5

[issue35823] Use vfork() in subprocess on Linux

Gregory P. Smith added the comment: regarding excluding the setsid() case: I was being conservative as I couldn't find a reference of what was and wasn't allowed after vfork. I found one thing suggesting that on macOS setsid() was not safe after vfork(). But that appeared to be a Darwin-ism

[issue31484] Cache single-character strings outside of the Latin1 range

Change by Serhiy Storchaka : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue41052] Opt out serialization/deserialization for heap type

Serhiy Storchaka added the comment: New changeset 8cd1dbae32d9303caac3a473d3332f17bc98c921 by Serhiy Storchaka in branch 'master': bpo-41052: Fix pickling heap types implemented in C with protocols 0 and 1 (GH-22870) https://github.com/python/cpython/commit/8cd1dbae32d9303caac3a473d3332f17bc

[issue40001] ignore errors in SimpleCookie

Aviram added the comment: Hi all, still waiting for review. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue35823] Use vfork() in subprocess on Linux

Change by Gregory P. Smith : -- pull_requests: +21863 pull_request: https://github.com/python/cpython/pull/22945 ___ Python tracker ___

[issue42096] zipfile.is_zipfile incorrectly identifying a gzipped file as a zip archive

Gregory P. Smith added the comment: for what it's worth: false positives are always going to be possible in any such "magic" check as is_zipfile is. we don't check the start of the file because zip files are defined by their end of file central directory which contains length information to

[issue35823] Use vfork() in subprocess on Linux

Gregory P. Smith added the comment: New changeset be3c3a0e468237430ad7d19a33c60d306199a7f2 by Gregory P. Smith in branch 'master': bpo-35823: Allow setsid() after vfork() on Linux. (GH-22945) https://github.com/python/cpython/commit/be3c3a0e468237430ad7d19a33c60d306199a7f2 -- _

[issue35823] Use vfork() in subprocess on Linux

Alexey Izbyshev added the comment: > regarding excluding the setsid() case: I was being conservative as I couldn't > find a reference of what was and wasn't allowed after vfork. Yes, there is no list of functions allowed after vfork(), except for the conservative POSIX.1 list consisting only

[issue35823] Use vfork() in subprocess on Linux

Alexey Izbyshev added the comment: @ronaldoussoren > I'd prefer to not use vfork on macOS. For one I don't particularly trust that > vfork would work reliably when using higher level APIs, but more importantly > posix_spawn on macOS has some options that are hard to achieve otherwise and >

[issue35823] Use vfork() in subprocess on Linux

Gregory P. Smith added the comment: Nice links. LOL, yes, musl source was going to be my next stop if the larger libc sources proved impossible for a mere mortal to reason about. :) regarding macOS, agreed. If someone needs vfork() to work there, I believe it could be made to. Options like

[issue17942] IDLE Debugger: Improve GUI

Change by Mark Roseman : -- pull_requests: +21864 pull_request: https://github.com/python/cpython/pull/22947 ___ Python tracker ___

[issue17942] IDLE Debugger: Improve GUI

Mark Roseman added the comment: have updated/cleaned up the previous patch, and there's a new PR. i realize this is unfortunately a somewhat monolithic change which might make reviewing it a bit tough... -- ___ Python tracker

[issue17942] IDLE Debugger: Improve GUI

Change by Mark Roseman : -- versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python

[issue42141] Speedup various dict inits

New submission from Marco Sulla : The PR #22948 is an augmented version of #22346. It speeds up also the creation of: 1. dicts from other dicts that are not "perfect" (combined and without holes) 2. fromkeys 3. copies of dicts with many holes 4. dict from keywords, as in #22346 A sample bench

[issue42130] AsyncIO's wait_for can hide cancellation in a rare race condition

Chris Jerdonek added the comment: It looks like issue 37658 might be the relevant change rather. Here is the new logic it introduced: https://github.com/python/cpython/blob/db455296be5f792b8c12b7cd7f3962b52e4f44ee/Lib/asyncio/tasks.py#L483-L488 (via https://github.com/python/cpython/pull/218

[issue37658] In some cases asyncio.wait_for can lead to socket leak.

Chris Jerdonek added the comment: Issue #42130 that was recently filed appears related to this change. -- nosy: +chris.jerdonek ___ Python tracker ___

[issue37203] Correct classmethod emulation in Descriptor HowTo Guide

Change by Géry : -- pull_requests: +21866 pull_request: https://github.com/python/cpython/pull/22934 ___ Python tracker ___ ___ Pytho

[issue37203] Correct classmethod emulation in Descriptor HowTo Guide

Change by Géry : -- versions: +Python 3.9 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue37203] Correct classmethod emulation in Descriptor HowTo Guide

Change by Géry : -- resolution: not a bug -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue42142] FAIL tkinter ttk LabeledScale test_resize

New submission from Terry J. Reedy : This appears to have timed out as there was no other error indication. Azure Pipelines, retested gave 2nd failure. Passed on another PR. test_resize (tkinter.test.test_ttk.test_extensions.LabeledScaleTest) ... Timeout (0:20:00)! Thread 0x7f787182e080 (

[issue33987] IDLE: use ttk.Frame for ttk widgets

Terry J. Reedy added the comment: New changeset e53e54425d9b7b9b7b082817da104d60bb25e3a2 by Mark Roseman in branch 'master': bpo-33987: Use ttk Label on IDLE statusbar (GH-22941) https://github.com/python/cpython/commit/e53e54425d9b7b9b7b082817da104d60bb25e3a2 -- __

[issue33987] IDLE: use ttk.Frame for ttk widgets

Change by miss-islington : -- pull_requests: +21867 pull_request: https://github.com/python/cpython/pull/22949 ___ Python tracker ___ __

[issue33987] IDLE: use ttk.Frame for ttk widgets

Change by miss-islington : -- pull_requests: +21868 pull_request: https://github.com/python/cpython/pull/22950 ___ Python tracker ___ __

[issue33987] IDLE: use ttk.Frame for ttk widgets

Change by miss-islington : -- pull_requests: +21869 pull_request: https://github.com/python/cpython/pull/22951 ___ Python tracker ___ __

[issue33987] IDLE: use ttk.Frame for ttk widgets

Terry J. Reedy added the comment: New changeset c579ad14d3b5bb9a45d7b9cc708eaf0bf4884c50 by Mark Roseman in branch 'master': bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943) https://github.com/python/cpython/commit/c579ad14d3b5bb9a45d7b9cc708eaf0bf4884c50 -- __

[issue33987] IDLE: use ttk.Frame for ttk widgets

Change by miss-islington : -- pull_requests: +21870 pull_request: https://github.com/python/cpython/pull/22952 ___ Python tracker ___ __

[issue42143] Corruptions in func_dealloc() with partially-created function object

New submission from Yonatan Goldschmidt : While reading funcobject.c, I noticed that PyFunction_NewWithQualName() may exit early if it fails retrieving __name__ from the globals dict. It will destroy the partially-created PyFunction object. However, this is done before ever initializing ->func

[issue33987] IDLE: use ttk.Frame for ttk widgets

miss-islington added the comment: New changeset 4efd2defb899c5c45334814234c842f8f513879e by Miss Skeleton (bot) in branch '3.9': bpo-33987: Use ttk Label on IDLE statusbar (GH-22941) https://github.com/python/cpython/commit/4efd2defb899c5c45334814234c842f8f513879e -- __

[issue33987] IDLE: use ttk.Frame for ttk widgets

miss-islington added the comment: New changeset c1b620eecc2ca0f9ae9d5ee2d973e823db295ad2 by Miss Skeleton (bot) in branch '3.8': bpo-33987: Use ttk Label on IDLE statusbar (GH-22941) https://github.com/python/cpython/commit/c1b620eecc2ca0f9ae9d5ee2d973e823db295ad2 -- __

[issue42143] Corruptions in func_dealloc() with partially-created function object

Change by Yonatan Goldschmidt : -- keywords: +patch pull_requests: +21871 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22953 ___ Python tracker

[issue33987] IDLE: use ttk.Frame for ttk widgets

miss-islington added the comment: New changeset 253c8eb40ec5a87aa539f913fcd83d1759069981 by Miss Skeleton (bot) in branch '3.8': bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943) https://github.com/python/cpython/commit/253c8eb40ec5a87aa539f913fcd83d1759069981 -- __

[issue42141] Speedup various dict inits

Inada Naoki added the comment: > 1. dicts from other dicts that are not "perfect" (combined and without holes) > 3. copies of dicts with many holes Note that I have optimized and rejected it by myself already. See https://github.com/python/cpython/pull/21669 and https://bugs.python.org/issue41

[issue33962] IDLE: use ttk.spinbox with configdialog

Change by Mark Roseman : -- keywords: +patch pull_requests: +21872 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/22954 ___ Python tracker

[issue33987] IDLE: use ttk.Frame for ttk widgets

miss-islington added the comment: New changeset 2d493893c7aa9af633c4ebeb56ecce42e3a82e9f by Miss Skeleton (bot) in branch '3.9': bpo-33987: Use master ttk Frame for IDLE config dialog (GH-22943) https://github.com/python/cpython/commit/2d493893c7aa9af633c4ebeb56ecce42e3a82e9f -- __

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +21873 pull_request: https://github.com/python/cpython/pull/22955 ___ Python tracker _

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

Raymond Hettinger added the comment: New changeset 48be6b1ef7a6201e13c87a317361cdb60bd5faa8 by Raymond Hettinger in branch 'master': bpo-42127: Document effect of cached_property on key-sharing dictionaries (GH-22930) https://github.com/python/cpython/commit/48be6b1ef7a6201e13c87a317361cdb6

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker ___ _

[issue42127] functools.cached_property possibly disables key-sharing instance dictionaries

Raymond Hettinger added the comment: New changeset 427cb0aa78813b89a3f100073bf7d70a53510f57 by Miss Skeleton (bot) in branch '3.9': bpo-42127: Document effect of cached_property on key-sharing dictionaries (GH-22930) (GH-22955) https://github.com/python/cpython/commit/427cb0aa78813b89a3f100

[issue29981] Update Index for set, dict, and generator 'comprehensions'

miss-islington added the comment: New changeset 229eaf20694006c03af0f4740abdf8ae5579 by Miss Skeleton (bot) in branch '3.9': bpo-29981: Add examples and update index for set, dict, and generator comprehensions'(GH-20272) https://github.com/python/cpython/commit/229eaf20694006c03af0f4

[issue29981] Update Index for set, dict, and generator 'comprehensions'

miss-islington added the comment: New changeset 60bef61f717dde915058b03159b2c2e97d765858 by Miss Skeleton (bot) in branch '3.8': bpo-29981: Add examples and update index for set, dict, and generator comprehensions'(GH-20272) https://github.com/python/cpython/commit/60bef61f717dde915058b03159

[issue29981] Update Index for set, dict, and generator 'comprehensions'

Change by Inada Naoki : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.7 ___ Python tracker ___ __

[issue42142] FAIL tkinter ttk LabeledScale test_resize, and more

Terry J. Reedy added the comment: Azure Pipelines Ubuntu, as before, but Combobox test_virtual_event. test_virtual_event (tkinter.test.test_ttk.test_widgets.ComboboxTest) ... Timeout (0:20:00)! Thread 0x7fb09e3f3080 (most recent call first): File "/home/vsts/work/1/s/Lib/tkinter/__init_

[issue33987] IDLE: use ttk.Frame for ttk widgets

Change by miss-islington : -- pull_requests: +21874 pull_request: https://github.com/python/cpython/pull/22956 ___ Python tracker ___ __

[issue33987] IDLE: use ttk.Frame for ttk widgets

Terry J. Reedy added the comment: New changeset 5df6c99cb450fe2f30be681dbf68cd1d34d3bbe4 by Mark Roseman in branch 'master': bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942) https://github.com/python/cpython/commit/5df6c99cb450fe2f30be681dbf68cd1d34d3bbe4 -- __

[issue33987] IDLE: use ttk.Frame for ttk widgets

Change by miss-islington : -- pull_requests: +21875 pull_request: https://github.com/python/cpython/pull/22957 ___ Python tracker ___ __

[issue33987] IDLE: use ttk.Frame for ttk widgets

miss-islington added the comment: New changeset 9cf26b00e42787bc668c62f1b5dde814f8307259 by Miss Skeleton (bot) in branch '3.9': bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942) https://github.com/python/cpython/commit/9cf26b00e42787bc668c62f1b5dde814f8307259 -- __

[issue33987] IDLE: use ttk.Frame for ttk widgets

miss-islington added the comment: New changeset 8485d3b911c3cb73ed6217a47c7720f9277efc01 by Miss Skeleton (bot) in branch '3.8': bpo-33987: Add master ttk Frame to IDLE search dialogs (GH-22942) https://github.com/python/cpython/commit/8485d3b911c3cb73ed6217a47c7720f9277efc01 -- __

[issue33962] IDLE: use ttk.spinbox with configdialog

Terry J. Reedy added the comment: #27755 was about replacing uses of our custom DynOptionMenu with ttk.Combobox, which I believe we can do now, wherever we don't replace it with something else. One use is for font size choice; Spinbox was suggested as an alternative replacement. Spinbox w

[issue33987] IDLE: use ttk.Frame for ttk widgets

Terry J. Reedy added the comment: Thanks for hopefully finishing this issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue42144] A missing "goto" in the _ssl module!

New submission from Zackery Spytz : In the _ssl_configure_hostname() function, there's a missing "goto error;" if SSL_set_tlsext_host_name() fails. -- assignee: christian.heimes components: Extension Modules, SSL messages: 379562 nosy: ZackerySpytz, christian.heimes priority: normal sev

[issue42144] A missing "goto" in the _ssl module!

Change by Zackery Spytz : -- keywords: +patch pull_requests: +21876 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22959 ___ Python tracker ___ __

[issue14556] telnetlib Telnet.expect fails with timeout=0

Zackery Spytz added the comment: Python 2.7 is no longer supported, so I think this issue should be closed. -- nosy: +ZackerySpytz ___ Python tracker ___ _

[issue42145] test_io is leaking references

New submission from Pablo Galindo Salgado : ❯ ./python -m test test_io -m test.test_io.CTextIOWrapperTest.test_read_one_by_one -R : 0:00:00 load avg: 1.59 Run tests sequentially 0:00:00 load avg: 1.59 [1/1] test_io beginning 9 repetitions 123456789 . test_io leaked [3, 3, 3, 3] reference

[issue41919] Modify test_codecs to use the new codecs.unregister() function

Pablo Galindo Salgado added the comment: Commit c9f696cb96d1c362d5cad871f61da520572d9b08 introduced a reference leak in the test suite. See https://bugs.python.org/issue42145: c9f696cb96d1c362d5cad871f61da520572d9b08 is the first bad commit commit c9f696cb96d1c362d5cad871f61da520572d9b08 Autho

[issue42145] test_io is leaking references

Pablo Galindo Salgado added the comment: Commit c9f696cb96d1c362d5cad871f61da520572d9b08 introduced a reference leak in the test suite. See https://bugs.python.org/issue42145: c9f696cb96d1c362d5cad871f61da520572d9b08 is the first bad commit commit c9f696cb96d1c362d5cad871f61da520572d9b08 Autho

[issue41919] Modify test_codecs to use the new codecs.unregister() function

Pablo Galindo Salgado added the comment: AS this is masking other issues in the build bots, we need to revert the commit unless is fixed in 24 hours per the buildbot workflow -- ___ Python tracker _

[issue41919] Modify test_codecs to use the new codecs.unregister() function

Change by Pablo Galindo Salgado : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailin

[issue41919] Modify test_codecs to use the new codecs.unregister() function

Change by Pablo Galindo Salgado : -- pull_requests: +21877 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/22961 ___ Python tracker ___ ___

[issue35823] Use vfork() in subprocess on Linux

Gregory P. Smith added the comment: Performance improvement measured on a 1.4Ghz quad aarch64 A57 (nvidia jetson nano): #define VFORK_USABLE 1 test_subprocess: 36.5 seconds #undef VFORK_USABLE test_subprocess: 45 seconds Nice. I really didn't expect a 20% speedup on its testsuite alone!

[issue26228] pty.spawn hangs on FreeBSD 9.3, 10.x, 12.1

Change by Soumendra Ganguly : -- pull_requests: +21879 pull_request: https://github.com/python/cpython/pull/22962 ___ Python tracker ___ ___

[issue41818] Lib/pty.py major revision

Change by Soumendra Ganguly : -- keywords: +patch pull_requests: +21878 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22962 ___ Python tracker __