[issue2191] SubProcess Startup error

2008-02-25 Thread Madhusudan SK
Madhusudan SK added the comment: hi, thanks so much for the clarification but i never faced this problem with 2.5.2. This is the only instance of pyhton that causes the mentioned error. On 2/26/08, Facundo Batista <[EMAIL PROTECTED]> wrote: > > Facundo Batista added the comment: > > IDLE works i

[issue1167] gdbm/ndbm 1.8.1+ needs libgdbm_compat.so

2008-02-25 Thread Ian Kelly
Ian Kelly added the comment: I'm not sure why you think this patch would be backwards incompatible. I've tested it with gdbm-1.8.0 and gdbm-1.7.3, and it works for those. __ Tracker <[EMAIL PROTECTED]> __

[issue1986] io.StringIO allows any parameter

2008-02-25 Thread Georg Brandl
Georg Brandl added the comment: Okay, then I see this as a intended feature. -- resolution: -> wont fix status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ __

[issue1569] Add VS CRT redist to the MSI installer

2008-02-25 Thread Jeroen Ruigrok van der Werven
Jeroen Ruigrok van der Werven added the comment: The hints that the vcredist cannot/should not be installed nested, but should be chained. The details on the full flags used/supported by the vcredist files. And the last one how to do the merge modules (and some other scenario's) way of adding t

[issue1569] Add VS CRT redist to the MSI installer

2008-02-25 Thread Martin v. Löwis
Martin v. Löwis added the comment: asmodai, which details in these postings are you referring to specifically? I find none of them helpful, wrt to packaging Python. __ Tracker <[EMAIL PROTECTED]> _

[issue1569] Add VS CRT redist to the MSI installer

2008-02-25 Thread Jeroen Ruigrok van der Werven
Jeroen Ruigrok van der Werven added the comment: As taken from http://blogs.msdn.com/astebner/ archive/2006/08/23/715755.aspx "Hi Didier - You should not try to install this vcredist package using a nested install. Performing nested installs causes problems with installing hotfixes for the ch

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Neal Norwitz
Neal Norwitz added the comment: Can you add more tests? It seems that almost all the examples given in this thread are good examples. Also something like: while 1: if cond: return 1 return 2 return 3 There are a bunch more cases that could be added for where the code should be opt

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-25 Thread Neal Norwitz
Changes by Neal Norwitz: -- assignee: nnorwitz -> tiran _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list mailing list Unsubscrib

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-25 Thread Neal Norwitz
Neal Norwitz added the comment: I looked over the new patch Christian uploaded and I think I understand what's going on. I didn't do a through comparison, but if all the tests pass, I think that's good enough. Good work! Here are the issues I would like to see fixed before check in (all small

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: Okay. Will drop None in favor of bool() in ifilter and ifilterfalse. Also, it looks like there agreement on dropping None for map() and going forward with the operator.identity() patch. Will check these in in the next couple of days.

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Guido van Rossum
Guido van Rossum added the comment: > What do you guys think about just making the predicate argument optional? > >filter([-2,0,2]) --> -2, 2 >filter(pred, iterable) > > One arg is the first case and two args is the second case. -1. Apart from range() this is used nowhere else in Pytho

[issue1740] use unittest for test_logging

2008-02-25 Thread Brett Cannon
Brett Cannon added the comment: On Mon, Feb 25, 2008 at 11:39 AM, Antoine Pitrou <[EMAIL PROTECTED]> wrote: > > Antoine Pitrou added the comment: > > Out of curiosity, what were the PEP 8 violations? Usually I try to > respect the coding guidelines. There were three that pervaded the code. 1

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > I think the motivation behind your other use case will likey be > addressed in a more general way with an identify function being > added to the operator module. Quite true, but I thought operator.identity was dead and buried. Can you update issue16732

[issue2193] Cookie Colon Name Bug

2008-02-25 Thread BM
New submission from BM: According to David M. Kristol, only comma, space and semi-colon are forbidden in the cookie Name. However, Python's Cookie.py rejects a colon too. At the same time, Java Cookie in the servlet implementation allows a colon and Perl too. The fix would be to add a colon s

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > What do you guys think about just making the predicate argument > optional? You've read my mind! That what I was going to suggest if I realized that optional argument does not have to be the last one. Looks like it would make sense to keep filterfalse

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: What do you guys think about just making the predicate argument optional? filter([-2,0,2]) --> -2, 2 filter(pred, iterable) One arg is the first case and two args is the second case. __ Tracker <[EMAIL PROTECTED]>

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Paul, You are right. I misunderstood that comment myself. I've tried the attached modification to your patch (unreachable-code-1.diff) and it passes all tests while fixing msg62953 problem: $ cat t.py def f(): return 1 1+2 from dis import di

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Paul Pogonyshev
Paul Pogonyshev added the comment: Thanks for writing the test. Yes, I did read the comment. As I understood it, RETURN_VALUE is needed only so that various optimization can assume codestr[] cannot suddenly end without one. E.g. if you match for BINARY_ADD, you can safely check the next comman

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: It appears Facundo fixed your problem. -- nosy: +benjamin.peterson __ Tracker <[EMAIL PROTECTED]> __ ___ Py

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Attached patch adds test_elim_unreachable() unit test. Last two assertions should fail with unpatched python. I am still trying to convince myself that the transformation are correct. > I propose that codestr[] array is made one byte > longer and RETUR

[issue1986] io.StringIO allows any parameter

2008-02-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: According to the docs: "When a StringIO object is created, it can be initialized to an existing string by passing the string to the constructor." So, it seems that that the docs are being too strict, or the code is being too open. The conversion to str in the

[issue2168] gdbm needs to be iterable

2008-02-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thx. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailm

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: Alexander, please contact me directly at python at rcn dot com. Need to figure-out why this works on my build but not yours. There may be an include file issue. __ Tracker <[EMAIL PROTECTED]>

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Raymond, it looks like you just broke the build for me: /Users/sasha/Work/python-svn/trunk/Modules/itertoolsmodule.c: In function 'ifilter_next': /Users/sasha/Work/python-svn/trunk/Modules/itertoolsmodule.c:2058: error: invalid operands to binary == /Us

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Raymond Hettinger
Changes by Raymond Hettinger: -- assignee: -> rhettinger nosy: +rhettinger __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list

[issue1720705] thread + import => crashes?

2008-02-25 Thread Nick Coghlan
Nick Coghlan added the comment: (oh, one thing - the 'crashes' mentioned in my proposed wording are due to explicit calls to PyErr_FatalError rather than a segfault or anything like that. The one specifically reported by the OP is due to sys.modules being gone by the time an import is attempted)

[issue1720705] thread + import => crashes?

2008-02-25 Thread Nick Coghlan
Nick Coghlan added the comment: Proposed wording for a warning pointing that threads and imports can get you in trouble. It might be better to squirrel off into a new subsection on threaded imports, rather than giving it too much prominence (since the recommended approach to creating subthreads s

[issue2189] urllib.quote() throws KeyError when passed an iterator

2008-02-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: Does something in the docs lead you to believe urllib.quote should accept a list of strings? The stdlib tends to shun type-checking to make cleaner and faster code, and let the client get exceptions like these. -- nosy: +benjamin.peterson ___

[issue2168] gdbm needs to be iterable

2008-02-25 Thread Facundo Batista
Facundo Batista added the comment: Applied in r61072. Raymond, I stole this from you, because I had the same conclusion and it was very needed for the buildbot. Thank you all! -- nosy: +facundobatista resolution: -> accepted status: open -> closed __

[issue2168] gdbm needs to be iterable

2008-02-25 Thread Neal Norwitz
Neal Norwitz added the comment: Thomas, thanks for fixing this. I didn't see any specific problems with the patch, but I'm wondering why the code doesn't just call has_key in both cases? -- nosy: +nnorwitz __ Tracker <[EMAIL PROTECTED]>

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: FWIW, I didn't disagree on filter(). Am taking your suggestion under advisement for a couple days. At this point, I'm leaning towards accepting the request (although with a different version of the patch). For map(None, ...), I happy to live with examples l

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: > I presume you meant "are *not* just for bugfixes". (Sigh) Yes, of course. __ Tracker <[EMAIL PROTECTED]> __ ___ Py

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Guido van Rossum
Guido van Rossum added the comment: On Mon, Feb 25, 2008 at 1:32 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > Unit tests are just for bugfixes. I presume you meant "are *not* just for bugfixes". __ Tracker <[EMAIL PROTECTED]>

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: >Yes, help with unit tests would be appreciated. Especially since it is >not supposed to fix anything, so I'm not sure what unit tests should be >like... Unit tests are just for bugfixes. They let us make sure Python is doing what we want it to do in a given

[issue2191] SubProcess Startup error

2008-02-25 Thread Facundo Batista
Facundo Batista added the comment: IDLE works in a server/client configuration with itself. Most probably the firewall is blocking IDLE's connections. Best way to try this is full disabling the firewall, and trying. If it works, remember to activate the firewall back, and configure it properly

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Raymond, There must be a reason why we constantly disagree. Do you live in California by any chance? :-) I am not sure if map(None, ..) fate is still up for voting given your changes at r60206, but your own patch illustrates the problem that I highlighte

[issue2191] SubProcess Startup error

2008-02-25 Thread Madhusudan SK
Madhusudan SK added the comment: One more thing i am already running Python 2.5.2 and concurrently installed Python 3.0 a without uninstalling the 2.5.2. __ Tracker <[EMAIL PROTECTED]> __

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Paul Pogonyshev
Paul Pogonyshev added the comment: Speaking of which, I propose that codestr[] array is made one byte longer and RETURN_VALUE opcode wrote in that extra byte. It will be removed by this patch anyway (if it is accepted), but we'll remove a way to accidentally disable peephole optimizer. I mean,

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Paul Pogonyshev
Paul Pogonyshev added the comment: Yes, help with unit tests would be appreciated. Especially since it is not supposed to fix anything, so I'm not sure what unit tests should be like... BTW, trying to understand why the patch didn't remove unreachable code in your first example, I noticed this

[issue2192] error with backslash as last character in raw string

2008-02-25 Thread Raghuram Devarakonda
Raghuram Devarakonda added the comment: This is as per the design. Please see http://www.python.org/doc/faq/general/#why-can-t-raw-strings-r-strings-end-with-a-backslash. -- nosy: +draghuram resolution: -> invalid status: open -> closed __ Tracker <[EMAI

[issue2192] error with backslash as last character in raw string

2008-02-25 Thread aka
New submission from aka: When creating a raw string ending with a backslash the systems answers with an error: >>> r'c:\' SyntaxError: EOL while scanning single-quoted string This happens on many systems with many versions, so it is propably a problem of the interpreter itself. -- comp

[issue2191] SubProcess Startup error

2008-02-25 Thread Madhusudan SK
New submission from Madhusudan SK: After installing the Python.msi x86 installer on an Intel P4 machine running Windows XP SP2, I am getting the error "Subprocess startup error" and when i click OK on the dialog box the Python IDLE closes. I do not have Microsoft Visual Studio installed on my

[issue1740] use unittest for test_logging

2008-02-25 Thread Antoine Pitrou
Antoine Pitrou added the comment: Out of curiosity, what were the PEP 8 violations? Usually I try to respect the coding guidelines. __ Tracker <[EMAIL PROTECTED]> __ ___

[issue1193577] add server.shutdown() method and daemon arg to SocketServer

2008-02-25 Thread Pedro Werneck
Pedro Werneck added the comment: I had some code here to do the exact same thing with XML-RPC server. The patch adds the feature to SocketServer, with a server.shutdown() method to stop serve_forever(), and change the unittest to use and test the feature. I disagree on adding the daemon_threads

[issue1524825] ConfigParser: accept leading whitespace on options+comments

2008-02-25 Thread Ken Lalonde
Ken Lalonde added the comment: Quentin: I didn't appreciate the line-continuation issue. Breaking existing code is out of the question, so I'd like to retract that part of the patch. _ Tracker <[EMAIL PROTECTED]> _

[issue1394] simple patch, improving unreachable bytecode removing

2008-02-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I figured that out: >>> def g(): ... raise RuntimeError ... Before the patch: >>> dis(g) 2 0 LOAD_GLOBAL 0 (RuntimeError) 3 RAISE_VARARGS1 6 LOAD_CONST 0 (None)

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Raymond Hettinger
Raymond Hettinger added the comment: Will think about ifilter() and ifilterfalse() for a day or two. The None argument handles the common use-case and there may be a good case for keeping it. If I do decide to drop it, will put in my own patch that optimized for the case with the filter functio

[issue1193577] add server.shutdown() method and daemon arg to SocketServer

2008-02-25 Thread Rafael Zanella
Changes by Rafael Zanella: -- nosy: +zanella _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue2177] Update compiler module to handle class decorators

2008-02-25 Thread Facundo Batista
Facundo Batista added the comment: Applied in r61067. Thank you! -- nosy: +facundobatista resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ ___

[issue1533] Bug in range() function for large values

2008-02-25 Thread Robert Bradshaw
Robert Bradshaw added the comment: Alexander Belopolsky's patch looks like the right fix for range() to me. The xrange limits still hold, but that should probably be a separate issue/ticket. __ Tracker <[EMAIL PROTECTED]> _

[issue2187] map and filter objects shouldn't call themselves itertools.imap and itertools.ifilter objects

2008-02-25 Thread Guido van Rossum
Changes by Guido van Rossum: -- assignee: -> rhettinger nosy: +rhettinger __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list

[issue2187] map and filter objects shouldn't call themselves itertools.imap and itertools.ifilter objects

2008-02-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Can you assign this to Raymond as well? If this is done first, issue2186 patch will be simpler (at least in the documentation portion). The same question on the fate of ifilterfalse is pertinent here as well. -- nosy: +belopolsky __

[issue2163] test_socket is flakey

2008-02-25 Thread Guido van Rossum
Guido van Rossum added the comment: It seems to work now for me too. I'll keep an eye out though. -- resolution: -> works for me status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ _

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Guido van Rossum
Guido van Rossum added the comment: Let me assign this to Raymond for the answering of the question about ifilterfalse. -- assignee: -> rhettinger nosy: +rhettinger __ Tracker <[EMAIL PROTECTED]> ___

[issue2190] MozillaCookieJar ignore HttpOnly cookies

2008-02-25 Thread Dou Yuan
New submission from Dou Yuan: HttpOnly cookie in Firefox's cookies.txt begins with "#HttpOnly_" now, just like a comment, e.g.: #HttpOnly_.rad.live.comTRUE/FALSE125821FC09FB= #HttpOnly_service.ilib.cnFALSE/FALSE1209905939 .ASPXANONYMOUS JMeD5-aty

[issue2186] map and filter shouldn't support None as first argument (in Py3k only)

2008-02-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Attached patch removes support for None from filter and itertools.ifilter. My objections for removing that from map do not apply because bool function can be used instead of None in filter achieving similar performance and better clarity. None support

[issue1691070] Speed up PyArg_ParseTupleAndKeywords() and improve error msg

2008-02-25 Thread Christian Heimes
Christian Heimes added the comment: I did some cleanup (style, var names, <80 chars per line) and combined the patch set into a single patch. The regression tests are passing for a pydebug build. I'm too busy to profile and test the patch with a vanilla Python right now. Pybench is showing a sma

[issue1540617] Use Py_ssize_t for rangeobject members

2008-02-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > What specific event triggered your working on this? That was a long time ago, but IIRC, we had some code dealing with large files that grew up beyond 2G. The files contained fixed-length records and we used xrange to iterate over record offsets. We wo

[issue1524] os.system() fails for commands with multiple quoted file names

2008-02-25 Thread Christian Heimes
Christian Heimes added the comment: Yes, it's necessary whenever the command part contains a space or other special characters. __ Tracker <[EMAIL PROTECTED]> __ ___

[issue919238] Recursive variable definition causes sysconfig infinite loop

2008-02-25 Thread Ralf Schmitt
Ralf Schmitt added the comment: distutils.extension has: if warnings is not None: warnings.warn(msg) else: sys.stderr.write(msg + '\n') Tracker <[EMAIL PROTECTED]> _

[issue1725737] Distutils default exclude doesn't match top level .svn

2008-02-25 Thread Ralf Schmitt
Ralf Schmitt added the comment: The original patch should by betelgeus should be applied to 2.5 branch. Georg, this is complete from my point of view and could be applied. Unless you want *~ and .#* to also be excluded? -- versions: +Python 2.5, Python 2.6 _

[issue2189] urllib.quote() throws KeyError when passed an iterator

2008-02-25 Thread djc
New submission from djc: >>> urllib.quote(['', 'aa']) Traceback (most recent call last): File "", line 1, in File "/usr/lib/python2.5/urllib.py", line 1205, in quote res = map(safe_map.__getitem__, s) KeyError: '' I think this is a weird error message to throw. quote() is obviously assu

[issue2163] test_socket is flakey

2008-02-25 Thread Michael Otteneder
Michael Otteneder added the comment: I'm not able to reproduce this with latest svn on OS X 10.5.2. test_socket never fails. -- nosy: +motteneder __ Tracker <[EMAIL PROTECTED]> __

[issue2188] [patch] urllib2 hint - disabled ProxyHandler()

2008-02-25 Thread anatoly techtonik
New submission from anatoly techtonik: Patch documents that empty dictionary is used to make ProxyHandler() with disabled proxy autodetection. Empty constructor doesn't give the desired effect. P.S. An ideal approach would be, of course, to change the API. Even though it can be changed drastical

[issue2124] xml.sax and xml.dom fetch DTDs by default

2008-02-25 Thread A.M. Kuchling
A.M. Kuchling added the comment: I mention urllib because, as noted earlier in the discussion, code that fetches resources over HTTP should really be caching (looking at the Expires header, sending an ETag and an If-Modified-Since header, etc.). It's difficult for us to add these features to the