[issue5753] CVE-2008-5983 python: untrusted python modules search path

2009-05-05 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

I disagree that this issue is release critical. I'm still skeptical that
this is a security bug; if it is, any solution created needs to be
applied to all active branches - including the ones that would be
blocked by this issue right now. IOW, it's still possible to fix it
after the release.

--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5753
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5630] Create alternative CObject API that is safe and clean

2009-05-05 Thread Larry Hastings

Larry Hastings la...@hastings.org added the comment:

dalcinl: Thanks, I've fixed the doc wrt writing int where I meant
void *.

As for using disambiguate in many places: there are a couple of
sentences that are repeated in the documentation for several functions.
 Those repeated sentences all use ambiguous and disambiguate. 
Having them read almost exactly the same is a subtle cue to the reader,
suggesting they will behave similarly, which is correct.  Is that a problem?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5630
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5938] Noddy examples haven't been updated to match PEP 3123

2009-05-05 Thread Larry Hastings

New submission from Larry Hastings la...@hastings.org:

The changes in PEP 3123 require that all type objects be statically
declared with PyVarObject_HEAD_INIT.  However, the Noddy examples in
Doc/ still use PyObject_HEAD_INIT.

--
assignee: georg.brandl
components: Documentation
messages: 87214
nosy: benjamin.peterson, georg.brandl, larry
severity: normal
status: open
title: Noddy examples haven't been updated to match PEP 3123
type: behavior
versions: Python 2.7, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5938
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5939] Ensure that PyCapsule_GetPointer calls in ctypes handle errors appropriately

2009-05-05 Thread Larry Hastings

New submission from Larry Hastings la...@hastings.org:

If my patch in issue 53046 is accepted, I hereby agree to figure out if
the calls to PyCapsule_GetPointer() in Modules/_ctypes/callproc.c need
more error checking or what.

--
components: Interpreter Core
messages: 87215
nosy: benjamin.peterson, larry
severity: normal
status: open
title: Ensure that PyCapsule_GetPointer calls in ctypes handle errors 
appropriately
type: behavior
versions: Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5939
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5932] _json: _convertPyInt_AsSsize_t() never raise any error

2009-05-05 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

Applied in r72314.

--
nosy: +georg.brandl
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5932
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3585] pkg-config support

2009-05-05 Thread sol

sol simon.hen...@wiktory.org added the comment:

 - Shouldn't this file be installed only if the pkg-config utility is
 present, or if the directory $(LIBDIR)/pkgconfig already exists?

 Technically I suppose so


That would mean that, if you first install Python and afterwards
pkg-config, pkg-config would not work for Python, right? I'm not sure if
that would be desirable.

--
nosy: +sol

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3585
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5938] Noddy examples haven't been updated to match PEP 3123

2009-05-05 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

Thanks, fixed in r72317.

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5938
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5938] Noddy examples haven't been updated to match PEP 3123

2009-05-05 Thread Larry Hastings

Larry Hastings la...@hastings.org added the comment:

Whoops, I thought PEP 3123 applied to 2.7 as well.  PEP *3*123.  Duh, me
slow today.

--
versions:  -Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5938
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5630] Create alternative CObject API that is safe and clean

2009-05-05 Thread Larry Hastings

Larry Hastings la...@hastings.org added the comment:

A nice fresh patch, against r72309.  Incorporates changes based on
Benjamin's latest batch of Rietveld comments.  They're thinning out, so
we must be near the end--and with a day to spare.  Also strips out
almost-all documentation from pycapsule.h.

Note: this still has CObject flagged as deprecated, both in doc and with
a runtime warning.  Dare I hope these will survive into the accepted patch?

--
Added file: http://bugs.python.org/file13892/lch.capsule.r72309.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5630
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5923] turtle.py update: 1.0 -- 1.1

2009-05-05 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

OK, I committed turtle30_to_31.diff, and additionally commented the
print(_ver) out and updated the version in the comment at the file's
top, and committed issues5923.doc.patch in r72318.

--
resolution:  - accepted
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5923
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5912] import deadlocks when using fork

2009-05-05 Thread Stefan Ring

Changes by Stefan Ring stefan...@gmail.com:


--
nosy: +Ringding

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5912
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1068477] linecache.py::updatecache strips directory info from files

2009-05-05 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
dependencies:  -linecache module returns wrong results
resolution:  - duplicate
status: open - closed
superseder:  - linecache module returns wrong results

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068477
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1754483] linecache package handling

2009-05-05 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

Setting #1309567 as superseder.

--
dependencies:  -linecache module returns wrong results
resolution:  - duplicate
status: open - closed
superseder:  - linecache module returns wrong results

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1754483
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1068477] linecache.py::updatecache strips directory info from files

2009-05-05 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

Setting #1309567 as superseder.

--
nosy: +georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1068477
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5940] Wrong type check in check_library_list

2009-05-05 Thread Cournapeau David

New submission from Cournapeau David da...@ar.media.kyoto-u.ac.jp:

There is a bug in the function check_library_list. Assuming there are
some libraries in the distribution instance, the function checks that
lib[0] is a string, but the test checks exactly the contrary (line 137
of build_clib.py).

This is pretty serious, as any code using libraries will fail to build
on python3. The fix is trivial, though. I think this should be fixed for
python 3.1

--
assignee: tarek
components: Distutils
messages: 87224
nosy: cdavid, tarek
severity: normal
status: open
title: Wrong type check in check_library_list
versions: Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5940
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1309567] linecache module returns wrong results

2009-05-05 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

Applied patch and added test suite in r72319.

--
nosy: +georg.brandl
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1309567
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5902] Stricter codec names

2009-05-05 Thread Marc-Andre Lemburg

Marc-Andre Lemburg m...@egenix.com added the comment:

On 2009-05-04 19:04, Georg Brandl wrote:
 Georg Brandl ge...@python.org added the comment:
 
 So, do you also think utf and latin should stay?

For Python 3.x, I think those can be removed. For 2.x it's better to
keep them.

Note that UTF-8 was the first official Unicode transfer encoding,
that's why it's sometimes referred to as UTF.

The situation is similar for Latin-1. It was the first of a series of
encodings defined by ECMA which was later published by ISO under the name
ISO-8859 - long after the name Latin-1 became popular which is why
it's the default name in Python.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5902
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5504] ctypes should work with systems where mmap can't be PROT_WRITE and PROT_EXEC

2009-05-05 Thread Thomas Heller

Thomas Heller thel...@ctypes.org added the comment:

 Try this as root, then repeat your test:
 semanage boolean -m --off allow_execstack

Ok, I can reproduce the problem now.  Thanks!

--
title: ctypes should work with systems where mmap can't be PROT_WRITE and 
PROT_EXEC - ctypes should work with systems where mmap can't be  
PROT_WRITE and PROT_EXEC

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5504
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5142] pdb feature request: Ability to skip standard lib modules and other selected packages/modules

2009-05-05 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

Applied the patch, added documentation and committed it as r72322. Thanks!

--
resolution:  - accepted
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5142
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5920] Confusing float formatting for empty presentation type.

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Updated patch, that removes the 's' type code.

--
Added file: http://bugs.python.org/file13893/issue5920_v2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5920
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3585] pkg-config support

2009-05-05 Thread Clinton Roy

Clinton Roy clinton@gmail.com added the comment:

Hi Sol,

It's just a data file I suppose, Python should not need a dependency on
pkg-config, and neither should there be a python-pkgconfig package that
just contains the python.pc file.

I think the approach to just always install the python.pc file is the
right one.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3585
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5941] customize_compiler broken

2009-05-05 Thread Cournapeau David

New submission from Cournapeau David da...@ar.media.kyoto-u.ac.jp:

The customize_compiler function is broken in python 3.1. The archiver
for a 'standard' unix compiler is set as ['ar', '-cr'], but in python
3.*, customize_compiler overwrites self.archiver from
get_sysconfig_var('AR'), and AR is defined as ar, which breaks
create_static_library.

I think the solution is to define a new env variable AR_something or to
set AR to 'ar -rc' (like LDSHARED is set to ['gcc', '-shared'] on gnu
systems, for example).

--
assignee: tarek
components: Distutils
messages: 87231
nosy: cdavid, tarek
severity: normal
status: open
title: customize_compiler broken
versions: Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5941
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5799] Change ntpath functions to implicitly support UNC paths

2009-05-05 Thread Eric Smith

Eric Smith e...@trueblade.com added the comment:

This looks okay to me. (The itertools import isn't needed, but easy
enough to fix on checkin.)

I'd still like someone else to look it over, but if no one does before
the beta, I'll check it in.

--
keywords: +needs review
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5799
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1356969] Tix.py class HList missing info_bbox

2009-05-05 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
assignee: loewis - gpolo
nosy: +gpolo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1356969
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5941] customize_compiler broken

2009-05-05 Thread Tarek Ziadé

Tarek Ziadé ziade.ta...@gmail.com added the comment:

Hi David, do you have an example that breaks, I can reuse to write the
test ?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5941
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5933] fix gcc -Wextra warnings (compare signed/unsigned)

2009-05-05 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
assignee:  - marketdickinson
nosy: +marketdickinson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5933
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5941] customize_compiler broken

2009-05-05 Thread Cournapeau David

Cournapeau David da...@ar.media.kyoto-u.ac.jp added the comment:

Hi Tarek,

Yes, I have a simple example, which show both 5940 and 5941 bugs:


from distutils.core import setup

# How to install libfoo.a/foo.lib in say pkg_dir/lib ?
setup(name='yo', libraries=[('foo', {'sources': ['foo.c']})])


foo.c can be an empty file.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5941
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5940] Wrong type check in check_library_list

2009-05-05 Thread Tarek Ziadé

Tarek Ziadé ziade.ta...@gmail.com added the comment:

Good catch !

Obviously this was introduced when the Python 2 version was
refactored for Python 3

(in python 2 its if type(lib[0]) is not StringType)

I shall fix this today or tonite (I need to add test coverage
for this command)

--
priority:  - critical

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5940
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5929] warnings in unicodeobject.c

2009-05-05 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

Fixed in r72326.

--
nosy: +georg.brandl
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5929
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5941] customize_compiler broken

2009-05-05 Thread Cournapeau David

Cournapeau David da...@ar.media.kyoto-u.ac.jp added the comment:

Both should be set as serious, in the sense that build_clib is totally
broken ATM, with no simple workaround. OTOH, maybe numpy is the only
user of build_clib, in which case it is not so serious (I use my own
fixed, copied versions of the original code for the time being in numpy
distutils extensions).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5941
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5919] pygettext documentation

2009-05-05 Thread Georg Brandl

Georg Brandl ge...@python.org added the comment:

This depends on how the distribution installs pygettext.  For example,
on Gentoo it isn't installed as a command at all.

Since the original name in the Python source archive is pygettext.py,
I'll not change this.

--
resolution:  - works for me
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5919
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5753] CVE-2008-5983 python: untrusted python modules search path

2009-05-05 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Ok, downgrading to critical.
I'm awaiting the reporter's answer anyway.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5753
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5753] CVE-2008-5983 python: untrusted python modules search path

2009-05-05 Thread Antoine Pitrou

Changes by Antoine Pitrou pit...@free.fr:


--
priority: release blocker - critical

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5753
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5933] fix gcc -Wextra warnings (compare signed/unsigned)

2009-05-05 Thread STINNER Victor

STINNER Victor victor.stin...@haypocalc.com added the comment:

About sign_warning_resource.patch: I don't know if RLIM_INFINITY 
constant is standard (always defined if getrlimit() is present).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5933
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5920] Confusing float formatting for empty presentation type.

2009-05-05 Thread Eric Smith

Eric Smith e...@trueblade.com added the comment:

I've reviewed this and it looks good. I'll check it in to py3k shortly.
Then I'll backport it to 2.7 and fix the user documentation.

--
resolution:  - accepted
stage: patch review - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5920
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5942] Ambiguity in dbm.open flag documentation

2009-05-05 Thread Mitchell Model

New submission from Mitchell Model m...@acm.org:

It isn't clear from the explanation of dbm.open's flag values at the
beginning of the dbm documentation page whether 'c' and 'n' open the
database just for writing or for reading and writing. I'm sure it's
obvious to anyone familiar with dbm, and the example demonstrates that
'c' opens the database for reading and writing, but I think it's worth
making it explicit by adding a few words to the paragraph describing the
flags.

--
assignee: georg.brandl
components: Documentation
messages: 87243
nosy: MLModel, georg.brandl
severity: normal
status: open
title: Ambiguity in dbm.open flag documentation
versions: Python 3.0, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5942
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5943] Bus error in test_posix on Mac OS

2009-05-05 Thread Eric Smith

New submission from Eric Smith e...@trueblade.com:

I get a bus error in test_lchflags in test_posix.py on my Mac OS X 10.5 box.

I'll try and spend some time later today to debug this, but here's the
backtrace if anyone wants to look at it:

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_PROTECTION_FAILURE at address: 0x0004
bytes2str (o=0x0, lock=1) at posixmodule.c:545
545 if(PyBytes_Check(o))
(gdb) bt
#0  bytes2str (o=0x0, lock=1) at posixmodule.c:545
#1  0x000e5d3c in posix_lchflags (self=0x353a08, args=0x0) at
posixmodule.c:1986
#2  0x000a6037 in PyEval_EvalFrameEx (f=0x25ff30, throwflag=0) at
Python/ceval.c:3744
#3  0x000a6e42 in PyEval_EvalFrameEx (f=0x25c4f0, throwflag=0) at
Python/ceval.c:3832
#4  0x000a78cb in PyEval_EvalCodeEx (co=0x624380, globals=0x601420,
locals=0x0, args=0x69c154, argcount=2, kws=0x255410, kwcount=0,
defs=0x4ae4bc, defcount=1, kwdefs=0x0, closure=0x0) at Python/ceval.c:3180
#5  0x00033cc5 in function_call (func=0x4b1660, arg=0x69c148,
kw=0x6a8ed0) at Objects/funcobject.c:628
#6  0x85c9 in PyObject_Call (func=0x4b1660, arg=0x69c148,
kw=0x6a8ed0) at Objects/abstract.c:2161
#7  0x000a352b in PyEval_EvalFrameEx (f=0x25c380, throwflag=0) at
Python/ceval.c:4045
#8  0x000a78cb in PyEval_EvalCodeEx (co=0x6243c8, globals=0x601420,
locals=0x0, args=0x690dac, argcount=2, kws=0x0, kwcount=0, defs=0x0,
defcount=0, kwdefs=0x0, closure=0x0) at Python/ceval.c:3180
#9  0x00033cc5 in function_call (func=0x4b16a8, arg=0x690da0, kw=0x0) at
Objects/funcobject.c:628
#10 0x85c9 in PyObject_Call (func=0x4b16a8, arg=0x690da0, kw=0x0) at
Objects/abstract.c:2161
#11 0x0001ecfe in method_call (func=0x4b16a8, arg=0x69af70, kw=0x0) at
Objects/classobject.c:323
#12 0x85c9 in PyObject_Call (func=0x45dc88, arg=0x69af70, kw=0x0) at
Objects/abstract.c:2161
#13 0x0005cec7 in slot_tp_call (self=0x0, args=0x69af70, kwds=0x0) at
Objects/typeobject.c:4956
#14 0x85c9 in PyObject_Call (func=0x6a37d0, arg=0x69af70, kw=0x0) at
Objects/abstract.c:2161
#15 0x000a4ef8 in PyEval_EvalFrameEx (f=0x25c210, throwflag=0) at
Python/ceval.c:3957
#16 0x000a6e42 in PyEval_EvalFrameEx (f=0x25c090, throwflag=0) at
Python/ceval.c:3832
#17 0x000a78cb in PyEval_EvalCodeEx (co=0x62e7b8, globals=0x601420,
locals=0x0, args=0x690d84, argcount=2, kws=0x203e10, kwcount=0,
defs=0x0, defcount=0, kwdefs=0x0, closure=0x4aeab0) at Python/ceval.c:3180
#18 0x00033cc5 in function_call (func=0x4b56f0, arg=0x690d78,
kw=0x6a8e40) at Objects/funcobject.c:628
#19 0x85c9 in PyObject_Call (func=0x4b56f0, arg=0x690d78,
kw=0x6a8e40) at Objects/abstract.c:2161
#20 0x000a352b in PyEval_EvalFrameEx (f=0x25bf20, throwflag=0) at
Python/ceval.c:4045
#21 0x000a78cb in PyEval_EvalCodeEx (co=0x62e608, globals=0x601420,
locals=0x0, args=0x69cf14, argcount=2, kws=0x0, kwcount=0, defs=0x0,
defcount=0, kwdefs=0x0, closure=0x0) at Python/ceval.c:3180
#22 0x00033cc5 in function_call (func=0x4b55d0, arg=0x69cf08, kw=0x0) at
Objects/funcobject.c:628
#23 0x85c9 in PyObject_Call (func=0x4b55d0, arg=0x69cf08, kw=0x0) at
Objects/abstract.c:2161
#24 0x0001ecfe in method_call (func=0x4b55d0, arg=0x69ad30, kw=0x0) at
Objects/classobject.c:323
#25 0x85c9 in PyObject_Call (func=0x45db48, arg=0x69ad30, kw=0x0) at
Objects/abstract.c:2161
#26 0x0005cec7 in slot_tp_call (self=0x0, args=0x69ad30, kwds=0x0) at
Objects/typeobject.c:4956
#27 0x85c9 in PyObject_Call (func=0x69afb0, arg=0x69ad30, kw=0x0) at
Objects/abstract.c:2161
#28 0x000a4ef8 in PyEval_EvalFrameEx (f=0x25bc50, throwflag=0) at
Python/ceval.c:3957
#29 0x000a78cb in PyEval_EvalCodeEx (co=0x62e5c0, globals=0x601420,
locals=0x0, args=0x690d34, argcount=2, kws=0x203e00, kwcount=0,
defs=0x0, defcount=0, kwdefs=0x0, closure=0x0) at Python/ceval.c:3180
#30 0x00033cc5 in function_call (func=0x4b5588, arg=0x690d28,
kw=0x6a8db0) at Objects/funcobject.c:628
#31 0x85c9 in PyObject_Call (func=0x4b5588, arg=0x690d28,
kw=0x6a8db0) at Objects/abstract.c:2161
#32 0x000a352b in PyEval_EvalFrameEx (f=0x25bae0, throwflag=0) at
Python/ceval.c:4045
#33 0x000a78cb in PyEval_EvalCodeEx (co=0x62e608, globals=0x601420,
locals=0x0, args=0x690d5c, argcount=2, kws=0x0, kwcount=0, defs=0x0,
defcount=0, kwdefs=0x0, closure=0x0) at Python/ceval.c:3180
#34 0x00033cc5 in function_call (func=0x4b55d0, arg=0x690d50, kw=0x0) at
Objects/funcobject.c:628
#35 0x85c9 in PyObject_Call (func=0x4b55d0, arg=0x690d50, kw=0x0) at
Objects/abstract.c:2161
#36 0x0001ecfe in method_call (func=0x4b55d0, arg=0x69a910, kw=0x0) at
Objects/classobject.c:323
#37 0x85c9 in PyObject_Call (func=0x45dbe8, arg=0x69a910, kw=0x0) at
Objects/abstract.c:2161
#38 0x0005cec7 in slot_tp_call (self=0x0, args=0x69a910, kwds=0x0) at
Objects/typeobject.c:4956
#39 0x85c9 in PyObject_Call (func=0x69acd0, arg=0x69a910, kw=0x0) at
Objects/abstract.c:2161
#40 0x000a4ef8 in PyEval_EvalFrameEx (f=0x25b390, throwflag=0) at
Python/ceval.c:3957
#41 0x000a6e42 in PyEval_EvalFrameEx (f=0x25a390, throwflag=0) at

[issue5943] Bus error in test_posix on Mac OS

2009-05-05 Thread R. David Murray

R. David Murray rdmur...@bitdance.com added the comment:

FreeBSD 6.3 also gives a segfault in test_posix.  Gentoo runs fine.

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5943
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5847] IDLE/Win Installer: drop -n switch for 2.7/3.1; install 3.1 as idle3

2009-05-05 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

The -n switch is now removed in r72335, r72336.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5847
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5643] test__locale fails with RADIXCHAR on Windows

2009-05-05 Thread Hirokazu Yamamoto

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

Crashes at Lib/test/test__locale.py(107) test_float_parsing.

 from _locale import setlocale, LC_NUMERIC
 setlocale(LC_NUMERIC, 'es_ES.ISO8859-1')
(crash)

Yes, I agree that workaround should be placed in test rather than
_locale module. I'll create such patch as short as possible.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5643
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5847] IDLE/Win Installer: drop -n switch for 2.7/3.1; install 3.1 as idle3

2009-05-05 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

I'm not sure what the necessary action is on the idle script. It's not
used on Windows; it isn't even installed. So unassigning myself.

--
assignee: loewis - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5847
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5943] Bus error in test_posix on Mac OS

2009-05-05 Thread Eric Smith

Eric Smith e...@trueblade.com added the comment:

Fedora Core 6 works okay.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5943
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5943] Bus error in test_posix on Mac OS

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Does this patch fix the problem?

--
keywords: +patch
nosy: +marketdickinson
Added file: http://bugs.python.org/file13894/issue5943.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5943
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5643] test__locale fails with RADIXCHAR on Windows

2009-05-05 Thread Hirokazu Yamamoto

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

Revised patch against HEAD. (With VC6 workaround)

--
Added file: http://bugs.python.org/file13895/py3k_locale_test_on_windows.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5643
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5943] Bus error in test_posix on Mac OS

2009-05-05 Thread Eric Smith

Eric Smith e...@trueblade.com added the comment:

Yes, that patch fixes the problem for me on Mac OS.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5943
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1368247] unicode in email.MIMEText and email/Charset.py

2009-05-05 Thread Ben Gamari

Ben Gamari bgam...@gmail.com added the comment:

What is the status of this?

--
nosy: +bgamari

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1368247
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4487] Add utf8 alias for email charsets

2009-05-05 Thread Ben Gamari

Ben Gamari bgam...@gmail.com added the comment:

Has this patch been merged yet?

--
nosy: +bgamari

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4487
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5933] fix gcc -Wextra warnings (compare signed/unsigned)

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Thanks for the patches.

The first patch looks fine;  I'll apply it shortly.

For the second, I don't understand why you want to
compare the return result with RLIM_INFINITY:  PyInt_AsLong
returns -1 to signal failure;  is there some guarantee that
RLIM_INFINITY == -1 if it's defined?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5933
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5943] Bus error in test_posix on Mac OS

2009-05-05 Thread R. David Murray

R. David Murray rdmur...@bitdance.com added the comment:

Fixes it on FreeBSD 6.3 as well.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5943
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5937] Problems with dbm documentation

2009-05-05 Thread Mitchell Model

Mitchell Model m...@acm.org added the comment:

Further confusion:
dbm.dumb._Database objects DO support items(), DO NOT support
iteritems(), and DO support iterkeys()

My previous comments referred to the general dbm documentation and the
specifics of dbm.gnu. I haven't checked any of this against the Unix
ndbm implementation.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5943] Bus error in test_posix on Mac OS

2009-05-05 Thread Eric Smith

Eric Smith e...@trueblade.com added the comment:

My Fedora Core 6 box still works with the patch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5943
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5799] Change ntpath functions to implicitly support UNC paths

2009-05-05 Thread Larry Hastings

Larry Hastings la...@hastings.org added the comment:

Whoops, yeah, that was me forgetting that in py3k itertools.izip became
just zip.  I'll remove it in my branch in case I generate another patch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5799
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5943] Bus error in test_posix on Mac OS

2009-05-05 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

This is now fixed in r72340 (I came up with the same patch
independently, and just hadn't got around to commit it).

--
nosy: +loewis
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5943
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5884] pydoc to return error status code

2009-05-05 Thread R. David Murray

R. David Murray rdmur...@bitdance.com added the comment:

This seems like a resonable thing for pydoc to do.  However, I took a
quick look, and pydoc has no notion of error status. Adding one would
require a non-trival refactoring of the code (at least to do it
right...a hackish version might not be too difficult).  

So, I doubt this is going to happen unless you can contribute a patch.

On the other hand, your test suite should be catching any errors pydoc
would catch, so I can't say I really understand your stated reason for
the request.  Unless you are building documentation for packages you
don't maintain?

--
nosy: +r.david.murray
priority:  - low
stage:  - needs patch
versions: +Python 2.7, Python 3.1 -Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5884
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5861] test_urllib fails on windows

2009-05-05 Thread Senthil

Senthil orsent...@gmail.com added the comment:

Fixed this in the revision: 72343. Agree to the comment on replacing '|'
to ':' in pathname2url as windows recognizes it. test_urllib passes.

--
resolution:  - fixed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5861
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5799] Change ntpath functions to implicitly support UNC paths

2009-05-05 Thread Larry Hastings

Larry Hastings la...@hastings.org added the comment:

Just 'cause I like you, here's an updated patch.  The only change is the
removal of import itertools and the update of the base version.

--
Added file: http://bugs.python.org/file13896/lch.ntpath.r72345.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5799
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue918368] urllib doesn't correct server returned urls

2009-05-05 Thread Senthil

Changes by Senthil orsent...@gmail.com:


--
resolution:  - fixed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue918368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5944] test_os failure on OS X, probably related to PEP 383

2009-05-05 Thread Mark Dickinson

New submission from Mark Dickinson dicki...@gmail.com:

I'm getting what looks like a PEP 383-related failure in test_os, on OS 
X 10.5.6.  Here's the tail end of running Lib/test/test_os.py, on a
standard non-debug build of py3k.

test_setuid (__main__.PosixUidGidTests) ... ok
test_listdir (__main__.Pep383Tests) ... FAIL
test_open (__main__.Pep383Tests) ... ok
test_stat (__main__.Pep383Tests) ... ok

==
FAIL: test_listdir (__main__.Pep383Tests)
--
Traceback (most recent call last):
  File Lib/test/test_os.py, line 725, in test_listdir
self.assertEquals(found, expected)
AssertionError: Items in the first set but not the second:
'fooöbar'
'foo%F6bar'
Items in the second set but not the first:
'foo\udcf6bar'
'fooöbar'

--
Ran 60 tests in 0.079s

FAILED (failures=1)
Traceback (most recent call last):
  File Lib/test/test_os.py, line 758, in module
test_main()
  File Lib/test/test_os.py, line 754, in test_main
Pep383Tests
  File /Users/dickinsm/svn/python/py3k/Lib/test/support.py, line 878, 
in run_unittest
_run_suite(suite)
  File /Users/dickinsm/svn/python/py3k/Lib/test/support.py, line 861, 
in _run_suite
raise TestFailed(err)
test.support.TestFailed: Traceback (most recent call last):
  File Lib/test/test_os.py, line 725, in test_listdir
self.assertEquals(found, expected)
AssertionError: Items in the first set but not the second:
'fooöbar'
'foo%F6bar'
Items in the second set but not the first:
'foo\udcf6bar'
'fooöbar'

--
messages: 87264
nosy: loewis, marketdickinson
priority: critical
severity: normal
status: open
title: test_os failure on OS X, probably related to PEP 383
type: behavior
versions: Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5944] test_os failure on OS X, probably related to PEP 383

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

One other piece of information that may be relevant:

Macintosh-4:py3k dickinsm$ echo $LANG
en_US.UTF-8

If I unset the LANG environment variable then I get a different failure  
(see output below).

I'll investigate this further and see if I can figure out what's going 
wrong.



test_setreuid (__main__.PosixUidGidTests) ... ok
test_setuid (__main__.PosixUidGidTests) ... ok
test_listdir (__main__.Pep383Tests) ... FAIL
test_open (__main__.Pep383Tests) ... ok
test_stat (__main__.Pep383Tests) ... ok

==
FAIL: test_listdir (__main__.Pep383Tests)
--
Traceback (most recent call last):
  File Lib/test/test_os.py, line 758, in module
test_main()
  File Lib/test/test_os.py, line 754, in test_main
Pep383Tests
  File /Users/dickinsm/svn/python/py3k/Lib/test/support.py, line 878, 
in run_unittest
_run_suite(suite)
  File /Users/dickinsm/svn/python/py3k/Lib/test/support.py, line 853, 
in _run_suite
result = runner.run(suite)
  File /Users/dickinsm/svn/python/py3k/Lib/unittest.py, line 1455, in 
run
result.printErrors()
  File /Users/dickinsm/svn/python/py3k/Lib/unittest.py, line 1424, in 
printErrors
self.printErrorList('FAIL', self.failures)
  File /Users/dickinsm/svn/python/py3k/Lib/unittest.py, line 1431, in 
printErrorList
self.stream.writeln(%s % err)
  File /Users/dickinsm/svn/python/py3k/Lib/unittest.py, line 1340, in 
writeln
self.write(arg)
UnicodeEncodeError: 'ascii' codec can't encode character '\u0308' in 
position 194: ordinal not in range(128)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5933] fix gcc -Wextra warnings (compare signed/unsigned)

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Applied the first patch in r72344, r72345, r72346, r72347.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5933
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5920] Confusing float formatting for empty presentation type.

2009-05-05 Thread Eric Smith

Eric Smith e...@trueblade.com added the comment:

Committed in py3k r72333 and trunk r72348. I also updated the
documentation. Closing the issue.

--
components: +Interpreter Core
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5920
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1153027] http_error_302() crashes with 'HTTP/1.1 400 Bad Request

2009-05-05 Thread Senthil

Senthil orsent...@gmail.com added the comment:

Fixed in the Revision 43132.

--
assignee:  - orsenthil
nosy: +orsenthil
resolution:  - fixed
stage: test needed - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1153027
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1153027] http_error_302() crashes with 'HTTP/1.1 400 Bad Request

2009-05-05 Thread Senthil

Senthil orsent...@gmail.com added the comment:

fixed in revision 43132 ( smaller 'r' for the roundup to auto-hyperlink). :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1153027
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5937] Problems with dbm documentation

2009-05-05 Thread Mitchell Model

Mitchell Model m...@acm.org added the comment:

And, checking the methods of dbm.ndbm, I find get() and setdefault() but
nothing like iterkeys() or iteritems(), just keys().

I think it might also be worth pointing out that a particular variation
of dbm may be chosen to create a database file by calling the
submodule's open function -- dbm.gdbm.open(), dbm.ndbm.open(), or
dbm.dumb.open().

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5937
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1153027] http_error_302() crashes with 'HTTP/1.1 400 Bad Request

2009-05-05 Thread Senthil

Changes by Senthil orsent...@gmail.com:


--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1153027
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1153027] http_error_302() crashes with 'HTTP/1.1 400 Bad Request

2009-05-05 Thread Senthil

Senthil orsent...@gmail.com added the comment:

Sorry, I meant fixed in revision 72351.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1153027
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue918368] urllib doesn't correct server returned urls

2009-05-05 Thread Senthil

Changes by Senthil orsent...@gmail.com:


--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue918368
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5861] test_urllib fails on windows

2009-05-05 Thread Senthil

Changes by Senthil orsent...@gmail.com:


--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5861
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5944] test_os failure on OS X, probably related to PEP 383

2009-05-05 Thread R. David Murray

R. David Murray rdmur...@bitdance.com added the comment:

OS/X needs to be special cased in the tests, since it transforms the
invalid filenames on write.  And if I remember correctly older versions
do something different...throw an error, maybe?

The case where the letter looks the same (at least in my email) but is
apparently different may require some thought, too.

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5944] test_os failure on OS X, probably related to PEP 383

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

 The case where the letter looks the same (at least in my email) but is
 apparently different may require some thought, too.

In case it's useful, when I do a list(map(ord, ...)) on those two 
lookalike strings I get (where 'expected' comes from the explicit .decode, 
while 'found' comes from listdir):

expected: [102, 111, 111, 246, 98, 97, 114]
found:[102, 111, 111, 111, 776, 98, 97, 114]

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5504] ctypes should work with systems where mmap can't be PROT_WRITE and PROT_EXEC

2009-05-05 Thread Thomas Heller

Thomas Heller thel...@ctypes.org added the comment:

Here is a patch for Python trunk (linux only).

--
Added file: http://bugs.python.org/file13897/issue5504.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5504
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5944] test_os failure on OS X, probably related to PEP 383

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Even better:

 for s in map(unicodedata.name, found): print(s)
... 
LATIN SMALL LETTER F
LATIN SMALL LETTER O
LATIN SMALL LETTER O
LATIN SMALL LETTER O
COMBINING DIAERESIS
LATIN SMALL LETTER B
LATIN SMALL LETTER A
LATIN SMALL LETTER R
 for s in map(unicodedata.name, expected): print(s)
... 
LATIN SMALL LETTER F
LATIN SMALL LETTER O
LATIN SMALL LETTER O
LATIN SMALL LETTER O WITH DIAERESIS
LATIN SMALL LETTER B
LATIN SMALL LETTER A
LATIN SMALL LETTER R
 found == expected
False
 unicodedata.normalize('NFC', found) == unicodedata.normalize('NFC', 
expected)
True

So there are two separate issues, both of which just require fixing the 
tests:  one issue is that OS X transforms invalid filenames;  the other is 
that it normalizes valid filenames.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4875] find_library can return directories instead of files

2009-05-05 Thread Thomas Heller

Thomas Heller thel...@ctypes.org added the comment:

Fixed in trunk (rev 72352), release26-maint (rev 72353), py3k (rev
72354), and release30-maint (rev 72355).

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4875
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1648957] HP-UX: _ctypes/libffi/src/ia64/ffi/__attribute__/native cc

2009-05-05 Thread Thomas Heller

Changes by Thomas Heller thel...@ctypes.org:


--
components:  -Build
stage: test needed - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1648957
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1581906] test_sqlite fails on OS X if test_ctypes is run

2009-05-05 Thread Thomas Heller

Thomas Heller thel...@ctypes.org added the comment:

So, should this be closed as some kind of 'works for me' + 'wont fix' +
 'third-party-bug' in Apple's sqlite?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1581906
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1581906] test_sqlite fails on OS X if test_ctypes is run

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Probably.

I do remember investigating this further, but I don't entirely remember 
what I found.  I think Ronald's comment about flat namespaces turned out 
to be highly relevant though.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1581906
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5643] test__locale fails with RADIXCHAR on Windows

2009-05-05 Thread Benjamin Peterson

Benjamin Peterson benja...@python.org added the comment:

I think the patch is good to go.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5643
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5944] test_os failure on OS X, probably related to PEP 383

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Here's a patch that fixes the test failures for me.  It's not ideal, 
because it no longer tests that on OS X, it's possible to open a file 
created with an invalid filename, using that same name.

--
keywords: +patch
Added file: http://bugs.python.org/file13898/issue5944.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5753] CVE-2008-5983 python: untrusted python modules search path

2009-05-05 Thread Jan Lieskovsky

Jan Lieskovsky ian...@seznam.cz added the comment:

Antoine,

  (re: #msg87083, #msg87084) -- while the API change is acceptable and
reasonable, it doesn't solve the core of the problem. I understand
the change needs to be 'backward compatible' and shouldn't break
the existing Python behavior, but the current proposed patch:

1, doesn't avoid the need to fix the issue (by calling
PySys_SetArgvEx(argc, argv, 0);) in all current applications embedding
Python,

2, doesn't dismiss the risk of future appearance of application, 
embedding Python interpreter and using it in a vulnerable way
(in fact, all what it does, is adding recommendation / alternative
to use more safer PySys_SetArgv(*, *, 0) for such cases. I don't think
we can just rely on the fact, the developers will use it in a safe
way in the future -- or did I overlooked something?

Wouldn't be possible to fix it 'only in Python' and prevent such
potential future malicious (mis)uses?

To Martin (re: #msg87212):

What's the question of 'security nature' of the issue, Glyph in
message #msg86927 already uncovered potential implications --
if the application was written either 'by accident', or 'by intention',
it shouldn't just allow to execute anything with the privileges of
superuser, and even worse, doing it silently (then the only warranty
for the unprivileged user would be to rely on the fact, the function
was called 'in a safe way' in the application and I suppose such
assumption would completely discourage him from running it).

I recommend the final fix should be applied to all active Python
branches (just comment on second part of Martin's comment).

Regards, Jan.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5753
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5899] test_capi crashes when called more than once

2009-05-05 Thread Benjamin Peterson

Benjamin Peterson benja...@python.org added the comment:

Fixed in r72357.

--
nosy: +benjamin.peterson
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5899
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5944] test_os failure on OS X, probably related to PEP 383

2009-05-05 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

I think skipping the test entirely would be even better on Darwin. The
test is really meant to pass only on systems that treat file names as
uninterpreted byte sequences (as such, it may also fail on Linux if the
file system driver enforces UTF-8).

To skip it, it probably would be best to move it out of the not win32
block, and into a neither win32 nor darwin block - or use the skipIf
decorator.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5799] Change ntpath functions to implicitly support UNC paths

2009-05-05 Thread Eric Smith

Eric Smith e...@trueblade.com added the comment:

Looking at Guido's removal of this back in 1999, he says:

* Lib/ntpath.py:
Withdraw the UNC support from splitdrive().  Instead, a new function
splitunc() parses UNC paths.  The contributor of the UNC parsing in
splitdrive() doesn't like it, but I haven't heard a good reason to
keep it, and it causes some problems.  (I think there's a
philosophical problem -- to me, the split*() functions are purely
syntactical, and the fact that \\foo is not a valid path doesn't mean
that it shouldn't be considered an absolute path.)


Do you have any comment on his philosophical problem?

--
assignee:  - eric.smith

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5799
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5753] CVE-2008-5983 python: untrusted python modules search path

2009-05-05 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

 What's the question of 'security nature' of the issue, Glyph in
 message #msg86927 already uncovered potential implications --

The question is whether these are theoretical or real problems.
I ran gedit (as proposed by Glyph) under strace(1), and it didn't
try to open any files in the current directory.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5753
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5944] test_os failure on OS X, probably related to PEP 383

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

 I think skipping the test entirely would be even better on Darwin.

Sounds good to me!  Here's a new (one-line) patch, using skipIf.

--
Added file: http://bugs.python.org/file13899/issue5944_v2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5944] test_os failure on OS X, probably related to PEP 383

2009-05-05 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

Fine with me, please apply.

--
assignee:  - marketdickinson
resolution:  - accepted

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5799] Change ntpath functions to implicitly support UNC paths

2009-05-05 Thread Larry Hastings

Larry Hastings la...@hastings.org added the comment:

I've never understood what is the philosophical problem per se.  It's
clear from his implementation--Guido created splitunc when he removed
my patch--that he thinks these should be precise string operations. 
Whereas I propose making these slightly higher-level abstract operations
on paths with drives (really mount points).  I think my approach
is more pleasant to use.

As for whether or not \\foo should be considered an absolute
path--perhaps my 1999 patch changed this behavior, but this patch does
not.  This:
   import ntpath
   ntpath.isabs(//foo)
  True
is unchanged by the attached patch.  (Or, at the very least, the latest
patch.)

At the time I guess I did a poor job of demonstrating the use case, but
I think the chorus of +1s shows there is one.

On the other hand, I'm not a Windows programmer anymore, and I barely
touch Windows boxes.  I'm doing this out of the kindness of my heart ;)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5799
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5944] test_os failure on OS X, probably related to PEP 383

2009-05-05 Thread Mark Dickinson

Mark Dickinson dicki...@gmail.com added the comment:

Committed, r72359.

--
resolution: accepted - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5944
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5945] PyMapping_Check returns 1 for lists

2009-05-05 Thread John Millikin

New submission from John Millikin jmilli...@gmail.com:

In Python 2, PyMapping_Check will return 0 for list objects. In Python
3, it returns 1. Obviously, this makes it rather difficult to
differentiate between mappings and other sized iterables. In addition,
it differs from the behavior of the ``collections.Mapping`` ABC --
isinstance([], collections.Mapping) returns False.

Since most of the PyMapping_* functions don't seem to work properly on
lists, I believe this behavior is erroneous.

The behavior can be seen from a C extension, or if you're lazy, using
ctypes:

Python 2.6.2 (release26-maint, Apr 19 2009, 01:56:41)
[GCC 4.3.3] on linux2
Type help, copyright, credits or license for more information.
 import ctypes
 ctypes.CDLL('libpython2.6.so').PyMapping_Check(ctypes.py_object([]))
0

Python 3.0.1+ (r301:69556, Apr 15 2009, 15:59:22)
[GCC 4.3.3] on linux2
Type help, copyright, credits or license for more information.
 import ctypes
 ctypes.CDLL('libpython3.0.so').PyMapping_Check(ctypes.py_object([]))
1

--
components: Library (Lib)
messages: 87291
nosy: jmillikin
severity: normal
status: open
title: PyMapping_Check returns 1 for lists
type: behavior
versions: Python 3.0

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5945
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1368247] unicode in email.MIMEText and email/Charset.py

2009-05-05 Thread R. David Murray

R. David Murray rdmur...@bitdance.com added the comment:

It looks to me like MIMEText doesn't actually support unicode input.  .

One way to get the example to work is to do this:

 MIMEText(u'\u043a\u0438\u0440\u0438\u043b\u0438\u0446\u0430'.encode('utf-8'), 
'plain', 'utf-8')

The above call produces valid output from as_string:

'Content-Type: text/plain; charset=utf-8\nMIME-Version:
1.0\nContent-Transfer-Encoding: base64\n\n0LrQuNGA0LjQu9C40YbQsA==\n'

How you'd get it to use 8bit, I have no idea.  Still, I'm inclined to
close this as invalid unless Barry tells me my analysis is wrong.

(CF: http://mg.pov.lt/blog/unicode-emails-in-python for a good example
of handling unicode using the email package, which I found after
figuring out the above.)

Clearly, the documentation of this could be better, but I suspect the
developers would rather spend their time fixing the email module in py3.
 A doc patch would certainly be accepted.  (Maybe someone could ask the
above blogger if we could borrow his example for the docs.)

--
nosy: +r.david.murray
resolution:  - invalid
stage:  - committed/rejected
status: open - pending
type:  - behavior
versions: +Python 2.6, Python 2.7, Python 3.0, Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1368247
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5799] Change ntpath functions to implicitly support UNC paths

2009-05-05 Thread Eric Smith

Changes by Eric Smith e...@trueblade.com:


--
assignee: eric.smith - 

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5799
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5721] msi.py still tries to copy non-existent test/README

2009-05-05 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

Thanks for the patch. Committed as r72361, r72362.

--
resolution:  - accepted
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5721
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4709] Mingw-w64 and python on windows x64

2009-05-05 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

Lowering the priority. It's too difficult to setup the environment to be
able to reproduce the issue being fixed.

--
priority: critical - normal

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4709
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3061] time.strftime() always decodes result with UTF-8

2009-05-05 Thread Martin v. Löwis

Martin v. Löwis mar...@v.loewis.de added the comment:

Is it possible to find out what specific encoding is being used?

In most cases, nl_langinfo(CODESET) would be the right choice, but that
depends on the LC_CTYPE category. If available, wcsftime should be used.

In any case, I think issue5903 and issue5562 are related. We should
close some of them as duplicates.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3061
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5630] Create alternative CObject API that is safe and clean

2009-05-05 Thread Benjamin Peterson

Benjamin Peterson benja...@python.org added the comment:

Applied in r72363.

--
nosy: +benjamin.peterson
resolution:  - accepted
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5630
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5643] test__locale fails with RADIXCHAR on Windows

2009-05-05 Thread Benjamin Peterson

Benjamin Peterson benja...@python.org added the comment:

Applied in r72365.

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5643
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5846] Deprecate obsolete functions in unittest

2009-05-05 Thread Michael Foord

Michael Foord mich...@voidspace.org.uk added the comment:

So it turns out that unittest.makeSuite is used about 100 times
throughout the standard library tests.

More than half the time it can be replaced with
unittest.TestLoader().loadTestsFromTestCase(...)

Some of the other times a loader needs to be constructed and then a
testMethodPrefix of 'Check' set (yuck!).

I'm about halfway through a patch that does this. Think it is worth
continuing or shall I drop it. I don't mind doing it so long as
*someone* thinks it is worthwhile... :-)

(I haven't yet checked for getTestCaseNames but I imagine there will be
a bunch of these to fix as well.)

Another possibility is to move the functions into test_support
(deprecating first) where at least they are out of unittest.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5846
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5753] CVE-2008-5983 python: untrusted python modules search path

2009-05-05 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Hello Jan,

 1, doesn't avoid the need to fix the issue (by calling
 PySys_SetArgvEx(argc, argv, 0);) in all current applications embedding
 Python,

As you said yourself, we don't want to break backwards compatibility for
C API users -- especially between two minor versions such as 2.6.2 and
2.6.3. The current behaviour is certainly by design, otherwise it
wouldn't be so complicated.

Besides, the patch you proposed is fragile as it relies on a hard coded
value for the executable name, and it also complexifies the behaviour
even more. I don't think we should apply it in core Python. On the other
hand, adding an /explicit/ option in the API minimizes the risk for
confusion and signals clearly that an alternative is available.

 I don't think
 we can just rely on the fact, the developers will use it in a safe
 way in the future

Well, you can always shoot yourself in the foot in C, even without using
the Python API. The patch just provides a practical way for
Python-embedding applications to be safer. Then, it's up to application
developers to do their job.

 Wouldn't be possible to fix it 'only in Python' and prevent such
 potential future malicious (mis)uses?

AFAICT, not without risking breaking compatibility for perfectly
well-behaved apps which would rely on the current behaviour.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5753
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5753] CVE-2008-5983 python: untrusted python modules search path

2009-05-05 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

 The question is whether these are theoretical or real problems.
 I ran gedit (as proposed by Glyph) under strace(1), and it didn't
 try to open any files in the current directory.

You have to use a Python-written gedit plugin for that to happen. For
example, if I enable the Python console plugin, I get the following
lines in strace:

17569:open(gconf.so, O_RDONLY)  = -1 ENOENT (No such file
or directory)
17570:open(gconfmodule.so, O_RDONLY)= -1 ENOENT (No such file
or directory)
17571:open(gconf.py, O_RDONLY)  = -1 ENOENT (No such file
or directory)
17572:open(gconf.pyc, O_RDONLY) = -1 ENOENT (No such file
or directory)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5753
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5946] Fix spelling error in Capsule docs

2009-05-05 Thread Larry Hastings

New submission from Larry Hastings la...@hastings.org:

In the comments for the Capsule patch:
  http://bugs.python.org/issue5630 
dalcinl correctly pointed out that I had misspelled disambiguate,
which I missed.  This patch fixes that mistake.

--
assignee: georg.brandl
components: Documentation
files: lch.capsuledoc.r72363.diff
keywords: patch
messages: 87301
nosy: dalcinl, georg.brandl, larry
severity: normal
status: open
title: Fix spelling error in Capsule docs
type: behavior
versions: Python 3.1
Added file: http://bugs.python.org/file13900/lch.capsuledoc.r72363.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5946
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5947] Deprecate CObject

2009-05-05 Thread Larry Hastings

New submission from Larry Hastings la...@hastings.org:

With the Capsule API patch accepted, I'd like to officially deprecate
CObject.  This patch causes Python to emit a single runtime warning the
first time a CObject is constructed in a particular Python instance.  If
those aren't the right semantics for a deprecation warning, please let
me know and I'll fix it.

--
components: Interpreter Core
files: lch.deprecatecobject.r72363.diff
keywords: patch
messages: 87302
nosy: larry
severity: normal
status: open
title: Deprecate CObject
type: behavior
versions: Python 3.1
Added file: http://bugs.python.org/file13901/lch.deprecatecobject.r72363.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5947
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >