Sindre Myren smyr...@gmail.com added the comment:
Thank you very much for the clarification :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5220
___
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
In issue3343, we chose to mark this function as private.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6543
___
Mark Dickinson dicki...@gmail.com added the comment:
Nitpick: shouldn't that
len(line) 79
be
len(line) 80
? Either that, or strip the line ending from the line before computing its
length.
--
nosy: +mark.dickinson
___
Python tracker
Mark Dickinson dicki...@gmail.com added the comment:
Similarly, isn't
line[-1].isspace()
always going to be true (well, except possibly at the end of the file), thanks
to the line-ending character?
--
___
Python tracker rep...@bugs.python.org
anatoly techtonik techto...@gmail.com added the comment:
No.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8940
___
___
Python-bugs-list
Changes by Daniel Urban urban.dani...@gmail.com:
--
nosy: +durban
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8998
___
___
Python-bugs-list
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file17672/patchcheck-pep7.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8912
___
anatoly techtonik techto...@gmail.com added the comment:
Raymond mention your reasons please. I may need them one day for describing
development process.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8903
Éric Araujo mer...@netwok.org added the comment:
Forgot readling kept the line end, thanks for catching. Updated (yay for
Mercurial Queues!)
--
Added file: http://bugs.python.org/file17673/patchcheck-pep7.diff
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
s/readling/readline/
s/readline/iterating over the file/
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8912
___
Mark Dickinson dicki...@gmail.com added the comment:
Thanks for the additional suggestions and patch. I've implemented most of them
in revisions r81992 through r81995.
I've left the note about 'native size and alignment': native alignment *is*
determined using sizeof, and I think this is
Mark Dickinson dicki...@gmail.com added the comment:
Sorry to be nitpicky, but:
(a) the line[-2] produces IndexError: string index out of range on empty
lines, and
(b) this won't detect trailing whitespace on the last line of a file, if
there's no newline at the end of the file. Actually, it
Mark Dickinson dicki...@gmail.com added the comment:
s/actually//g
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8912
___
___
Python-bugs-list
New submission from Éric Araujo mer...@netwok.org:
I got bored of manually changing the svn status command to hg status when
testing my patch for #8912, so I made a proper patch once and for all. (Did I
already say yay for Mercurial Queues?)
--
components: Demos and Tools
files:
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file17673/patchcheck-pep7.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8912
___
Georg Brandl ge...@python.org added the comment:
May I ask why?
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8940
___
___
Tom Zych freethin...@pobox.com added the comment:
The problem went away by itself after a while. I suspect a Windows update.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7936
___
Éric Araujo mer...@netwok.org added the comment:
Thanks for the helpful reviews. I have fixed the trailing whitespace check with
“line[-2:-1].isspace()”, but I have a bug with my file counting. Before I go
further, I’d like feedback from people using patchcheck:
1) Reindenting Python is a
Éric Araujo mer...@netwok.org added the comment:
Another one: I’d like to move the file name filtering from the worker functions
into the main function. With that change, looping over all file names to get
only the C files would be written and run only once, even if there are four
functions
Christian Schubert b...@apexo.de added the comment:
added a patch which fixes both issues
before releasing the GIL we take a copy of the ufds pointer and its len,
erasing the ufds pointer in the poll object (to make sure nobody else fiddles
with it); when we're done we either but it back into
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +exarkun
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8865
___
___
Python-bugs-list mailing
Mark Dickinson dicki...@gmail.com added the comment:
Answering as a rather infrequent user of 'make patchcheck', but someone who
vows to use it more often in future... :)
(1) Well, it would be awkward to use grep or wc on Windows, so it's convenient
not to need external tools.
(2) +1 to a
Changes by Éric Araujo mer...@netwok.org:
--
nosy: -d...@python
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8865
___
___
Python-bugs-list
Mark Dickinson dicki...@gmail.com added the comment:
and your proposed refactoring sounds fine to me. I can't really see any
backwards compatibility concerns.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8912
Changes by James Teh ja...@nvaccess.org:
--
nosy: +jteh
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8959
___
___
Python-bugs-list mailing list
Éric Araujo mer...@netwok.org added the comment:
Adding nosy from the other patchcheck bug, hope it doesn’t annoy anyone.
--
nosy: +belopolsky, brett.cannon, mark.dickinson, pitrou
___
Python tracker rep...@bugs.python.org
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8940
___
___
anatoly techtonik techto...@gmail.com added the comment:
1. No time
2. Looks complicated
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8940
___
Changes by R. David Murray rdmur...@bitdance.com:
--
status: open - languishing
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8940
___
___
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8998
___
___
Antoine Pitrou pit...@free.fr added the comment:
I've taken a quick look at the source tree (there doesn't seem to be any
separate docs) and here is my opinion:
- the evp.py API is too low-level (it's a one-to-one mapping to the OpenSSL C
API); we would want at least some kind of
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
Yes, though it may be a while before I find time to do so.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8647
___
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
Yes, though it may be a while before I find time to do so.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8646
___
Daniel Stutzbach dan...@stutzbachenterprises.com added the comment:
I'm not really clear on what PyUnicode_AsEncodedObject does (as opposed to
PyUnicode_AsEncodedString). Someone already familiar with those two functions
would have a much easier time writing a documentation patch.
--
geremy condra debat...@gmail.com added the comment:
On Tue, Jun 15, 2010 at 9:21 AM, Antoine Pitrou rep...@bugs.python.org wrote:
Antoine Pitrou pit...@free.fr added the comment:
I've taken a quick look at the source tree (there doesn't seem to be any
separate docs) and here is my opinion:
Damjan Georgievski gdam...@users.sourceforge.net added the comment:
AFAIK, what the stdlib needs is a high-level crypto module, analogous to hashlib
--
nosy: +gdamjan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8998
Changes by Nils Philippsen n...@redhat.com:
--
nosy: +nils
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2504
___
___
Python-bugs-list mailing
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Reopening to add some minor fixes to tests and documentation. See
issue5094h.diff. Ezio, thanks for finding these issues.
--
status: closed - open
Added file: http://bugs.python.org/file17676/issue5094h.diff
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
--
nosy: +ezio.melotti
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5094
___
Ronald Oussoren ronaldousso...@mac.com added the comment:
This is no longer a problem, I cannot reproduce the issue with the current
trunk.
--
resolution: - invalid
status: open - closed
___
Python tracker rep...@bugs.python.org
New submission from Alexander Belopolsky belopol...@users.sourceforge.net:
Recently added datetime.timezone class does not have a custom repr, so one gets
timezone.utc
datetime.timezone object at 0x100681ef0
instead of parseable
datetime.timezone(datetime.timedelta(0))
This is inconsistent
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
--
dependencies: +datetime lacks concrete tzinfo implementation for UTC
versions: +Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9000
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Merged issue5094 nosy list.
--
nosy: +ajaksu2, akira, brett.cannon, doerwalter, durban, ezio.melotti,
gagenellina, kawai, l0nwlf, mark.dickinson, merwok, pitrou, r.david.murray,
rafe, techtonik, tim_one
Ronald Oussoren ronaldousso...@mac.com added the comment:
I've fixed this issue for the 3.2 branch in r81999.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8577
New submission from Renato Cunha ren...@renatocunha.com:
PyFile_FromFd has a wrong argument cound and, consequently, a wrong description
in py3k docs. The errors is never mentioned.
--
assignee: d...@python
components: Documentation
files: correct-py3k-c-api-doc.diff
keywords: patch
Antoine Pitrou pit...@free.fr added the comment:
Looks like this just broke the 3.x buildbots.
==
FAIL: test_get_python_inc (distutils.tests.test_sysconfig.SysconfigTestCase)
New submission from Renato Cunha ren...@renatocunha.com:
Even though the File Objects section in py3k documentation makes it clear
that the functions there listed are just wrappers over the io module, it took
me a bit to find which function PyFile_FromFd was wrapping.
So, what about making it
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
dependencies: +PyFile_FromFd wrong documentation
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9002
___
Antoine Pitrou pit...@free.fr added the comment:
Le mardi 15 juin 2010 à 14:49 +, geremy condra a écrit :
The goals of the library are simplicity and ease of use. I've
frequently found that out of fear of making incorrect choices, people
will simply decide not to use crypto at all, or
Senthil Kumaran orsent...@gmail.com added the comment:
The reason the the password is prompted is because, on 401 authentication
failure, there is a retry logic by default. When the authentication is retried,
it is prompted for username:password using getpass. When using GUI modules it
is
Ronald Oussoren ronaldousso...@mac.com added the comment:
Sigh. test.test_distutils behaves different when run through regrtest than when
run directly.
I have a fix, but am running an extended test cycle before committing (that is,
both with and without srcdir==builddir)
--
geremy condra debat...@gmail.com added the comment:
On Tue, Jun 15, 2010 at 9:49 AM, Antoine Pitrou rep...@bugs.python.org wrote:
Antoine Pitrou pit...@free.fr added the comment:
Le mardi 15 juin 2010 à 14:49 +, geremy condra a écrit :
The goals of the library are simplicity and ease of
Éric Araujo mer...@netwok.org added the comment:
+1 for replacing math range notation with English. Much easier for non-math
people that do Python :)
One more nit: Your docstrings use verb forms like “Returns” where PEP 257
advises to use “Return”: “[the docstring] prescribes the function or
Antoine Pitrou pit...@free.fr added the comment:
Thank you! This was committed in r82000, and I improved other text a bit in
r82001.
--
nosy: +pitrou
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
Antoine Pitrou pit...@free.fr added the comment:
Same resolution as in #9001. Thanks again.
--
nosy: +pitrou
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9002
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
What about
.. method:: datetime.utcoffset()
If :attr:`tzinfo` is ``None``, returns ``None``, else returns ...
Should this use return too?
--
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
.. method:: datetime.utcoffset()
Return ``None`` if :attr:`tzinfo` is ``None``, else else return ...
That said, to keep diffs readable, perhaps stick with the existing
convention know, and later a PEP 257 compliance diff can be made.
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
How to specify offset range horse got its beating above. See msg107554. The
current wording is the best compromise between verbosity and precision.
Replacing the patch with one that fixes other nits.
--
Added
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Removed file: http://bugs.python.org/file17676/issue5094h.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5094
___
Éric Araujo mer...@netwok.org added the comment:
Suggestion for one line:
“The *dt* argument must be aware with ``tzinfo`` set to ``self``.”
“The *dt* argument must be an aware datetime, with ``tzinfo`` set to ``self``.”
If there is a reST construct for aware datetime, use it. Since “self” is
anatoly techtonik techto...@gmail.com added the comment:
Good job. Thanks for working on this.
It is possible to backport this to future of Python 2.7?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5094
Antoine Pitrou pit...@free.fr added the comment:
It is possible to backport this to future of Python 2.7?
No.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5094
___
Antoine Pitrou pit...@free.fr added the comment:
Reopening. I think it would be nice to provide the appropriate convenience
function(s) as part of the ssl module, even if the user has to call them
explicitly.
--
assignee: janssen -
nosy: +pitrou
resolution: rejected -
status: closed
Ronald Oussoren ronaldousso...@mac.com added the comment:
This should be fixed in r82005, this passes all tests both with and without
srcdir==builddir
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8577
Tarek Ziadé ziade.ta...@gmail.com added the comment:
As I said earlier, I am going to revert Distutils state in py3k so it's like
the 3.1 branch. So the changes in distutils/ in py3k that are not backported in
3.1 will be lost.
I had a lack of time lately, but I should be able to do it this
Thomas Vander Stichele thoma...@users.sourceforge.net added the comment:
What do you mean, it's frozen ? Without the patch you're already breaking a
third party tool, namely rpm. What other tool worth caring about that uses
bdist_rpm could possibly get broken by fixing an obvious bug ? Why is
René Schümann whitet...@gmail.com added the comment:
Roumen thanks for this work, but will you upload a new version?
Just because i can't get it to work, i can't even patch it^^
Maybe it's the SVN Client i use (Tortoise SVN) or that i don't know how to
apply this patch :D It would be nice when
New submission from geremy condra debat...@gmail.com:
urllib currently blindly accepts bad certificates when passed an https address.
This behavior, clearly not desirable for many users, is also not documented. I
propose one of two changes:
1) add mechanisms for enforcing correct behavior to
Changes by Senthil Kumaran orsent...@gmail.com:
--
assignee: - orsenthil
nosy: +orsenthil
resolution: - accepted
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9003
___
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
On this happy note, I am closing this issue. Doc changes have been committed
in r82004, test changes in r82003. For repr(timezone(..)) development, please
follow issue #9000.
--
status: open - closed
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3129
___
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Added file: http://bugs.python.org/file17681/issue6641.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6641
___
Changes by Alexander Belopolsky belopol...@users.sourceforge.net:
Removed file: http://bugs.python.org/file17667/issue6641.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6641
___
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
Mark,
I am reassigning this to you for a commit review.
--
assignee: belopolsky - mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6641
Craig McQueen pyt...@craig.mcqueen.id.au added the comment:
From my limited experience using cx_Freeze 4.1.2 with Python 2.6.5, it seems
that this issue is triggered in a cx_Frozen program simply by having `import
threading` in the program. I'm not sure what cx_Freeze is doing that makes
this
Craig McQueen pyt...@craig.mcqueen.id.au added the comment:
Sorry I should have said, I'm running on Windows 2000 SP4.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1596321
___
Changes by R. David Murray rdmur...@bitdance.com:
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9003
___
___
Python-bugs-list
Senthil Kumaran orsent...@gmail.com added the comment:
Yes, the problem is observed in py3k. Pickle module when used via Interactive
console is trying to import the class as __console__.ClassName and it is
failing to see the __console__ module.
_pickle.PicklingError: Can't pickle class
New submission from Alexander Belopolsky belopol...@users.sourceforge.net:
I find the following quite misleading:
from datetime import datetime
import time
time.strftime('%c %z %Z', datetime.utcnow().utctimetuple())
'Wed Jun 16 03:26:26 2010 -0500 EST'
As far as I can tell, the only other
New submission from Alexander Belopolsky belopol...@users.sourceforge.net:
Current datetime.timetuple() implementation goes out of its way to support edge
cases that produce timetuples beyond the naive datetime range:
t1 = datetime.min.replace(tzinfo=timezone.max)
t2 =
Changes by geremy condra debat...@gmail.com:
--
nosy: +debatem1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1589
___
___
Python-bugs-list
Changes by Brett Cannon br...@python.org:
--
nosy: -brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9000
___
___
Python-bugs-list
Ronald Oussoren ronaldousso...@mac.com added the comment:
Tarek: I'm not 100% that all my changes in Lib/distutils were backported to
3.1. This last patch definitely wasn't, but isn't also isn't relevant for 3.1.
--
___
Python tracker
83 matches
Mail list logo
