Raymond Hettinger rhettin...@users.sourceforge.net added the comment:
See attached.
--
keywords: +patch
Added file: http://bugs.python.org/file21208/peep.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11510
Changes by Daniel Urban urban.dani...@gmail.com:
--
nosy: +durban
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11549
___
___
Python-bugs-list
Filip Gruszczyński grusz...@gmail.com added the comment:
I had some time today, so I managed to fix the patch. I hope now everything is
ok.
--
Added file: http://bugs.python.org/file21209/6584_3.patch
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
I'm not using if zlib is not None since the archive_utils module
never explicitly imports zlib.
Well, you can import zlib in that module too to detect in advance whether
zipfile will work.
--
___
Éric Araujo mer...@netwok.org added the comment:
Thanks for the test. The patch is minimal and makes distutils work correctly
with the new pyc handling in 3.2+, so I will apply it in a few days unless
Tarek disagrees.
--
assignee: tarek - eric.araujo
stage: patch review - commit
New submission from Graham Wideman initcont...@grahamwideman.com:
The overall scope of this issue is that current Python documentation gives
vague, sometimes incorrect, information about the set of Python features
involved in modularizing functionality. This issue presents an obstacle to
Changes by Nick Coghlan ncogh...@gmail.com:
--
nosy: +dmalcolm, ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11549
___
___
Nick Coghlan ncogh...@gmail.com added the comment:
There may be some legitimate use cases when embedding Python and you *know*
that the checks performed by the PyObject_* versions aren't needed.
It may also be historical - the PyEval versions may predate the PyObject ones.
--
Nick Coghlan ncogh...@gmail.com added the comment:
Michael pointed out that I had completely missed the point of what the msg
argument was about. Sorry for the noise.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10775
Natalia B. Bidart nataliabid...@gmail.com added the comment:
On Tue, Mar 15, 2011 at 7:15 AM, Éric Araujo rep...@bugs.python.org wrote:
Éric Araujo mer...@netwok.org added the comment:
I'm not using if zlib is not None since the archive_utils module
never explicitly imports zlib.
Well,
SilentGhost ghost@gmail.com added the comment:
I left a comment on the review.
You need to publish your comment if you want others to see it.
--
nosy: +SilentGhost
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10775
Andreas Stührk andy-pyt...@hammerhartes.de added the comment:
Any reason why the patch removes the `list()` calls? Without them, no parsing
happens at all.
--
nosy: +Trundle
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11550
Brian Curtin br...@python.org added the comment:
I showed robquad how to do the review stuff at PyCon but I forgot about the
publish part. Robbie, if you hit Publish + Mail Comments near the top of the
page after you've left comments, it'll send them out.
What he noticed was that changing to
SilentGhost ghost@gmail.com added the comment:
A couple more minor issues:
1. Double space required at the beginning of the Here is a ... sentence in
Doc/library/smtplib.rst
2. in __exit__ method: msg is the variable name assigned from docmd('QUIT')
but errmsg is used when raising
Steffen Daode Nurpmeso sdao...@googlemail.com added the comment:
On Tue, Mar 15, 2011 at 04:21:24AM +, R. David Murray wrote:
Please test and let me know if it works; it should, since the code patch is
very close to the one you suggested.
;-)
Hello David, hope you have a good time at
Natalia B. Bidart nataliabid...@gmail.com added the comment:
Attaching a new patch with latest changes from trunk merged in (conflicts
resolved).
--
Added file: http://bugs.python.org/file21211/pycon-issue11501.patch
___
Python tracker
Nick Coghlan ncogh...@gmail.com added the comment:
Armin: yeah, I learned better in the course of trying to fix this misbehaviour
in CPython. I've adjusted assorted sq_concat methods to return NotImplemented
in the sandbox where I'm working on this, along with modifying abstract.c to
Ben Hayden hayden...@gmail.com added the comment:
I was unclear as to why the list() calls were there. I thought it would just
change the iterator into a list - I didn't know that actually was needed for
the test - my mistake. I'll change it back to the list() - but I'll need to
loop over the
Nick Coghlan ncogh...@gmail.com added the comment:
My work in progress is on the respect_LHS_precedence branch in
http://hg.python.org/sandbox/ncoghlan
Current status is that I have tests for correct handling of sq_concat and
sq_repeat, and am close to having sq_concat and sq_inplace_concat
Roundup Robot devnull@devnull added the comment:
New changeset f2e04ce75f0b by briancurtin in branch 'default':
Fix #11509. Significantly increase test coverage for fileinput.
http://hg.python.org/cpython/rev/f2e04ce75f0b
--
nosy: +python-dev
___
Brian Curtin br...@python.org added the comment:
Many thanks for the patch, Denver!
--
assignee: - brian.curtin
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
Ross Lagerwall rosslagerw...@gmail.com added the comment:
The Charles' patch fixes the problem but breaks [test_os test_poll test_popen
test_select test_uuid] when running make test.
Those two lines were introduced by Guido in [1f7891d84d93] but that was back in
2007 when subprocess used
New submission from Michael Henry pyt...@drmikehenry.com:
test_email_codecs.py in the email module should be ported to Python 3.
The attached patch ports test_email_codecs.py and hooks it into the email test
suite.
--
components: Library (Lib)
files: port-test_email_codecs.py.patch
New submission from Michael Henry pyt...@drmikehenry.com:
The function email.Message.as_string has an out-of-date comment:
This is a convenience method and may not generate the message exactly
as you intend because by default it mangles lines that begin with
From . For more flexibility, use
New submission from Michael Henry pyt...@drmikehenry.com:
In email.Message.get_payload, there is the following out-of-date comment:
# payload can be bytes here, (I wonder if that is actually a bug?)
The code can actually handle bytes payloads.
--
components: Library (Lib)
messages:
New submission from Natalia B. Bidart nataliabid...@gmail.com:
Current coverage is:
Name Stmts Miss Cover
--
Lib/logging/__init__ 73916278%
Lib/logging/config 571 9883%
Lib/logging/handlers 601325
New submission from Michael Henry pyt...@drmikehenry.com:
The attached test program, test_email_attach_to_string.py, demonstrates the
desire for email.message.Message.attach to raise a more helpful exception when
the user incorrectly invokes attach() after setting the payload to a string.
Roundup Robot devnull@devnull added the comment:
New changeset 9448691fe084 by briancurtin in branch 'default':
Add news item for #11509.
http://hg.python.org/cpython/rev/9448691fe084
--
___
Python tracker rep...@bugs.python.org
Changes by Gregory P. Smith g...@krypto.org:
--
assignee: - gregory.p.smith
keywords: +patch
nosy: +gregory.p.smith
Added file: http://bugs.python.org/file21215/_cursesmodule.c.diff
___
Python tracker rep...@bugs.python.org
Changes by Michael Foord mich...@voidspace.org.uk:
Removed file:
http://bugs.python.org/file21125/test_posixpath_with_same_device.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11503
___
Changes by Michael Foord mich...@voidspace.org.uk:
Removed file: http://bugs.python.org/file21124/test_posixpath.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11503
___
Changes by Michael Foord mich...@voidspace.org.uk:
Removed file: http://bugs.python.org/file21122/test_posixpath.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11503
___
Changes by R. David Murray rdmur...@bitdance.com:
--
assignee: - r.david.murray
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11556
___
___
Michael Foord mich...@voidspace.org.uk added the comment:
Note that instead of try finally constructs you can create a cleanup function
and call self.addCleanup(...). This reduces extra levels of indentation in your
test code.
In the new code in test_ismount, from # Non-existent mountpoint
Winston Ewert winstonew...@gmail.com added the comment:
The public methods were using both callable_obj and callableObj. Perhaps the
patch should standardize on callableObj and accept callable_obj with a warning?
--
___
Python tracker
Michael Foord mich...@voidspace.org.uk added the comment:
Scratch the comment about symlink - in test_mount. I see you already protect
that code with if support.can_symlink().
--
___
Python tracker rep...@bugs.python.org
Michael Foord mich...@voidspace.org.uk added the comment:
Will posixpath.sameopenfile work on Windows? That may need skipping.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11503
___
Changes by Gregory P. Smith g...@krypto.org:
--
assignee: gregory.p.smith -
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1006238
___
Changes by Gregory P. Smith g...@krypto.org:
--
assignee: gregory.p.smith -
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3718
___
Gregory P. Smith g...@krypto.org added the comment:
a test would still be a good thing but this should be fixed regardless.
--
resolution: - accepted
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6873
Roundup Robot devnull@devnull added the comment:
New changeset 013a1cd673fc by R David Murray in branch '3.2':
#11554: reactivate test_email_codecs, and make it pass.
http://hg.python.org/cpython/rev/013a1cd673fc
New changeset a6390ebff835 by R David Murray in branch 'default':
Merge #11554
Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11554
___
Barry A. Warsaw ba...@python.org added the comment:
After discussion, it's probably a good idea to back port this to Python 3.2.
--
nosy: +barry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11505
Nick Coghlan ncogh...@gmail.com added the comment:
Trying out the hg integration MvL added to Roundup.
--
hgrepos: +3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Nick Coghlan ncogh...@gmail.com:
--
keywords: +patch
Added file: http://bugs.python.org/file21216/85d7c99fd31e.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file21216/85d7c99fd31e.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Nick Coghlan ncogh...@gmail.com:
Added file: http://bugs.python.org/file21217/b9b7d4c10bc4.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Ronald Oussoren ronaldousso...@mac.com added the comment:
To reproduce install ActiveState Tcl 8.5.9 and then build python using:
../configure --enable-framework --enable-universalsdk=/
--with-universal-archs=intel MACOSX_DEPLOYMENT_TARGET=10.6
Both 3.2 and 3.3 fail can be used. Install the
Changes by R. David Murray rdmur...@bitdance.com:
--
versions: +Python 3.1, Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11555
___
Changes by R. David Murray rdmur...@bitdance.com:
--
versions: +Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11556
___
___
R. David Murray rdmur...@bitdance.com added the comment:
Fixed, thanks.
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11556
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11459
___
___
Python-bugs-list
Roundup Robot devnull@devnull added the comment:
New changeset ee5350f1d0c2 by Ezio Melotti in branch '2.7':
#11515: fix several typos. Patch by Piotr Kasprzyk.
http://hg.python.org/cpython/rev/ee5350f1d0c2
--
___
Python tracker
Ezio Melotti ezio.melo...@gmail.com added the comment:
Fixed, thanks for the patch!
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11515
Changes by Michael Foord mich...@voidspace.org.uk:
--
assignee: - michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10775
___
___
Changes by Michael Foord mich...@voidspace.org.uk:
--
assignee: docs@python - michael.foord
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11385
___
Matthew Barnett pyt...@mrabarnett.plus.com added the comment:
I've fixed the problem with iterators for both Python 3 and Python 2. They can
now be shared safely across threads.
I've updated the release on PyPI.
--
___
Python tracker
Ronald Oussoren ronaldousso...@mac.com added the comment:
Please ignore the patch, it doesn't work after all. It was too good to be true
after all.
--
nosy: -kbk
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11055
Nick Coghlan ncogh...@gmail.com added the comment:
I generated a patch between my sandbox and the main repository using the rdiff
extension immediately after syncing with the main line of development. (hg
diff --reverse cpython where cpython is aliased to the main repository)
This is the
Changes by Nick Coghlan ncogh...@gmail.com:
Added file: http://bugs.python.org/file21220/2f5db44c98f2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Changes by Nick Coghlan ncogh...@gmail.com:
Removed file: http://bugs.python.org/file21220/2f5db44c98f2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
___
Ronald Oussoren ronaldousso...@mac.com added the comment:
This does seem to be gone in 3.2 with a up-to-date Tk 8.5 from ActiveState.
--
nosy: +ronaldoussoren
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11088
Evan Dandrea e...@ubuntu.com added the comment:
Updated the patch to address Michael's concerns.
--
Added file:
http://bugs.python.org/file21221/test_posixpath_with_same_device.patch
___
Python tracker rep...@bugs.python.org
Nick Coghlan ncogh...@gmail.com added the comment:
I think the roundup/Hg integration may be getting confused by the merges of the
cpython main line of development with my sandbox.
--
___
Python tracker rep...@bugs.python.org
Evan Dandrea e...@ubuntu.com added the comment:
I've looked at the sameopenfile code, and can see no reason why it would not
work on Windows. I've asked Brian to verify this.
--
___
Python tracker rep...@bugs.python.org
Evan Dandrea e...@ubuntu.com added the comment:
I haven't used addCleanup here, but have noted it for the future. In this
case, using it would require adding another function to handle the
reassignment, which I think is a bit more messy than the extra bit of
indentation.
--
Benjamin Peterson benja...@python.org added the comment:
Is that a patch you can put on Rietveld then? (/me wanting to review)
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
Barry A. Warsaw ba...@python.org added the comment:
Thanks for the contribution! It seems like a reasonable new feature, so I'll
get this landed in 3.3. Probably should use :versionadded: instead (thanks
gps). I'll address SilentGhost's issues in the commit.
--
assignee: - barry
Ned Deily n...@acm.org added the comment:
I can still reproduce it in 3.2 with A/S Tk 8.5. The script needs to be run
from a separate editor window, not the PyShell window.
--
___
Python tracker rep...@bugs.python.org
Ronald Oussoren ronaldousso...@mac.com added the comment:
On 15 Mar, 2011, at 13:57, Ned Deily wrote:
Ned Deily n...@acm.org added the comment:
I can still reproduce it in 3.2 with A/S Tk 8.5. The script needs to be run
from a separate editor window, not the PyShell window.
That's
Roundup Robot devnull@devnull added the comment:
New changeset 2804a78a123e by R David Murray in branch '3.1':
#11555: update doc for 3.x change to as_string mangle_from default.
http://hg.python.org/cpython/rev/2804a78a123e
New changeset 9daa9a4c4cc4 by R David Murray in branch '3.2':
Merge
Changes by R. David Murray rdmur...@bitdance.com:
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11555
Evan Dandrea e...@ubuntu.com added the comment:
*facepalm* Indeed, thanks for pointing that out and nice catch on the race
condition. Attached is a patch to fix the issue as you've suggested, and adds
a test case for it.
--
keywords: +patch
Added file:
Changes by Evan Dandrea e...@ubuntu.com:
Added file:
http://bugs.python.org/file21223/tarfile-fix-multiple-exception-on-enoent.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11513
___
Changes by Evan Dandrea e...@ubuntu.com:
Removed file:
http://bugs.python.org/file21222/tarfile-fix-multiple-exception-on-enoent.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11513
___
Ned Deily n...@acm.org added the comment:
Sorry, forgot one crucial step: you have to use the keyboard accelerator (F5)
to run the script, not the mouse and the menu. It seems like a number of the
problems out there with Cocoa Tk 8.5 have to do with using the keyboard
accelerators.
Brian Curtin br...@python.org added the comment:
Tested the patch on Windows -- all tests pass.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11503
___
Changes by Dave Malcolm dmalc...@redhat.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9263
___
___
Python-bugs-list mailing
SilentGhost ghost@gmail.com added the comment:
The work on smtplib context manager continues in #11289. I'm putting it as a
dependency here.
--
dependencies: +smtplib context manager
nosy: +SilentGhost
versions: +Python 3.3
___
Python tracker
Changes by Dave Malcolm dmalc...@redhat.com:
--
resolution: - accepted
stage: patch review - committed/rejected
status: open - closed
versions: -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10288
Antoine Pitrou pit...@free.fr added the comment:
How about turning these asserts into Py_FatalError()s and then enabling
Victor's faulthandler extension?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9263
Changes by Dave Malcolm dmalc...@redhat.com:
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9635
___
___
Python-bugs-list mailing
Giampaolo Rodola' g.rod...@gmail.com added the comment:
@barry I have commit privileges, but no problem if you want to commit it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11289
___
New submission from Matias Bordese mbord...@gmail.com:
Attaching patch to add new tests for dis module.
--
components: Tests
files: add_dis_tests.patch
keywords: patch
messages: 131018
nosy: matiasb
priority: normal
severity: normal
status: open
title: Increase test coverage in dis
Barry A. Warsaw ba...@python.org added the comment:
On Mar 15, 2011, at 06:40 PM, Giampaolo Rodola' wrote:
Giampaolo Rodola' g.rod...@gmail.com added the comment:
@barry I have commit privileges, but no problem if you want to commit it.
@giampaolo: I'd like to do it (and am almost ready to),
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Go on, no prob.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11289
___
___
Benjamin Peterson benja...@python.org added the comment:
1. Use splitlines() instead of split('\n')
2. Use try finally when replacing sys.stdout.
3. Why is dist(None) a RuntimeError and anything else invalid TypeError?
--
nosy: +benjamin.peterson
___
Nick Coghlan ncogh...@gmail.com added the comment:
MvL says the review creation script should be able to cope with the rdiff
output within the next day or so.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11477
Giampaolo Rodola' g.rod...@gmail.com added the comment:
Closing out as per msg128969.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11257
___
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11257
___
Matias Bordese mbord...@gmail.com added the comment:
Updated patch following Benjamin advice (1. and 2.).
Re 3. Why is dist(None) a RuntimeError and anything else invalid TypeError?
When the dis argument is None, the last traceback is disassembled; if something
different to None and that does
Roundup Robot devnull@devnull added the comment:
New changeset a6a94cfb75e9 by Barry Warsaw in branch 'default':
- Issue #11289: `smtp.SMTP` class becomes a context manager so it can be used
http://hg.python.org/cpython/rev/a6a94cfb75e9
--
nosy: +python-dev
Changes by Barry A. Warsaw ba...@python.org:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11289
___
___
Python-bugs-list
Changes by Barry A. Warsaw ba...@python.org:
--
resolution: - accepted
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11289
___
___
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
stage: - committed/rejected
type: - feature request
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11289
___
Terry J. Reedy tjre...@udel.edu added the comment:
I want to thank you all too, both for the changes themselves and for the
bundling.
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11515
Changes by Tarek Ziadé ziade.ta...@gmail.com:
Removed file: http://bugs.python.org/file21137/pycon-issue11501.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11501
___
Changes by Tarek Ziadé ziade.ta...@gmail.com:
Removed file: http://bugs.python.org/file21142/pycon-issue11501.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11501
___
Changes by Tim Lesher tles...@gmail.com:
--
nosy: +tlesher
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1189811
___
___
Python-bugs-list mailing
Changes by Nick Coghlan ncogh...@gmail.com:
--
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8754
___
___
Python-bugs-list mailing
1 - 100 of 184 matches
Mail list logo
