[issue7833] Bdist_wininst installers fail to load extensions built with Issue4120 patch

2011-10-02 Thread Mark Hammond
Mark Hammond added the comment: This is biting people (including me :) so I'm going to try hard to get this fixed. One user on the python-win32 mailing list resorts to rebuilding every 3rd party module he uses with this patch to get things working again (although apps which use only builtin

[issue13071] IDLE refuses to open on windows 7

2011-10-02 Thread jfalskfjdsl;akfdjsa;l laksfj;aslkfdj;sal
jfalskfjdsl;akfdjsa;l laksfj;aslkfdj;sal added the comment: That is the traceback given when I run idle.py through windows command prompt -- ___ Python tracker ___

[issue13071] IDLE refuses to open on windows 7

2011-10-02 Thread jfalskfjdsl;akfdjsa;l laksfj;aslkfdj;sal
jfalskfjdsl;akfdjsa;l laksfj;aslkfdj;sal added the comment: Traceback (most recent call last): File "C:\Python32\Lib\idlelib/idle.py", line 11, in idlelib.PyShell.main() File "C:\Python32\Lib\idlelib\PyShell.py",line 1377, in main shell = flist.open_shell() File "C:\Python32\Lib\

[issue12753] \N{...} neglects formal aliases and named sequences from Unicode charnames namespace

2011-10-02 Thread Ezio Melotti
Ezio Melotti added the comment: > But it still has to happen at compile time, of course, so I don't know > what you could do in Python. Is there any way to change how the compiler > behaves even vaguely along these lines? I think things like "from __future__ import ..." do something similar, b

[issue12753] \N{...} neglects formal aliases and named sequences from Unicode charnames namespace

2011-10-02 Thread Tom Christiansen
Tom Christiansen added the comment: >> Really? White space makes things harder to read? I thought Pythonistas >> believed the opposite of that. > I was surprised at that too ;-). One person's opinion in a specific > context. Don't generalize. The example I initially showed probably wasn't t

[issue13062] Introspection generator and function closure state

2011-10-02 Thread Nick Coghlan
Nick Coghlan added the comment: The function case is simpler - AttributeError or TypeError if there's no __closure__ attribute, empty mapping if there's no closure. I've also changed my mind on the "no frame" generator case - since that mapping will evolve over time as the generator executes

[issue12943] tokenize: add python -m tokenize support back

2011-10-02 Thread Meador Inge
Meador Inge added the comment: Fixed a few more nits pointed out in review. -- Added file: http://bugs.python.org/file23304/issue12943-6.patch ___ Python tracker ___ ___

[issue13062] Introspection generator and function closure state

2011-10-02 Thread Nick Coghlan
Nick Coghlan added the comment: Because a generator can legitimately have no locals: >>> def gen(): ... yield 1 ... >>> g = gen() >>> g.gi_frame.f_locals {} Errors should be reported as exceptions - AttributeError or TypeError if there's no gi_frame and then ValueError or RuntimeError if

[issue13062] Introspection generator and function closure state

2011-10-02 Thread Meador Inge
Meador Inge added the comment: Here is a first cut at a patch. There is one slight deviation from the original spec: > some nice error checking for when the generator's frame is already gone > (or > the supplied object isn't a generator iterator). The attached patch returns empty mappings f

[issue13091] ctypes: memory leak

2011-10-02 Thread Meador Inge
Meador Inge added the comment: > this pointer is tied to a CDataObject; its tp_alloc should free the > memory The free in 'PyCData_clear' is conditional: if ((self->b_needsfree) && ((size_t)dict->size > sizeof(self->b_value))) PyMem_Free(self->b_ptr); As written, 'PyCData

[issue13073] message_body argument of HTTPConnection.endheaders is undocumented

2011-10-02 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is fixed the following changesets. changeset a3f2dba93743 changeset 1ed413b52af3 changeset 277688052c5a Thanks for the patch, Ben Hayden. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed _

[issue5001] Remove assertion-based checking in multiprocessing

2011-10-02 Thread Vlad Riscutia
Vlad Riscutia added the comment: Thanks for the quick review! I attached second iteration addressing feedback + changed all occurrences of checks like "type(x) is y" to "isinstance(x, y)". I would appreciate a second look because this patch has many small changes and even though I ran full te

[issue13053] Add Capsule migration documentation to "cporting"

2011-10-02 Thread Larry Hastings
Larry Hastings added the comment: In case you're curious, here's how I tested "capsulethunk.h". I added the file to Python 2.7 (hg head), 3.0.0 (tarball), and 3.1.0 (tarball). For 2.7 ad 3.0.0 I quickly hacked four files to use the Capsule API instead of CObjects: * Python/compile.c * Pyth

[issue13053] Add Capsule migration documentation to "cporting"

2011-10-02 Thread Larry Hastings
Larry Hastings added the comment: Attached is r2 of the patch, incorporating Nick's suggestions. Base revision hasn't changed. -- Added file: http://bugs.python.org/file23301/larry.cporting.capsules.r2.diff ___ Python tracker

[issue12804] "make test" fails on systems without internet access

2011-10-02 Thread Nadeem Vawda
Nadeem Vawda added the comment: Oh, neat. I'll take a look at that when I get a chance. -- assignee: -> nadeem.vawda ___ Python tracker ___

[issue13091] ctypes: memory leak

2011-10-02 Thread Meador Inge
Meador Inge added the comment: I can reproduce this with: valgrind --tool=memcheck --log-file=leaks.txt --leak-check=full --suppressions=Misc/valgrind-python.supp ./python -m test test_ctypes Where as: valgrind --tool=memcheck --log-file=leaks.txt --leak-check=full --suppressions=Misc/valgr

[issue6715] xz compressor support

2011-10-02 Thread Dan Stromberg
Dan Stromberg added the comment: On Sun, Oct 2, 2011 at 3:49 PM, Nadeem Vawda wrote: > > Nadeem Vawda added the comment: > > Thanks for investigating the Windows situation. > > > - liblzma can't be compiled by Visual Studio: too many C99 isms, mostly > > variables declared in the middle of a

[issue12911] Expose a private accumulator C API

2011-10-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: New patch implementing Martin's suggested optimization (only instantiate the large list when necessary). -- Added file: http://bugs.python.org/file23299/accu3.patch ___ Python tracker

[issue6715] xz compressor support

2011-10-02 Thread Nadeem Vawda
Nadeem Vawda added the comment: Thanks for investigating the Windows situation. > - liblzma can't be compiled by Visual Studio: too many C99 isms, mostly > variables declared in the middle of a block. It's doable for sure, but it's a > lot of work. I don't think that creating our own MSVC-fri

[issue12804] "make test" fails on systems without internet access

2011-10-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: > > If it is easy to detect network availability programmatically, we could > > just use the skip system. > > +1. I don't know if there is a reasonable way to do this, but if so, that > would be the best solution. Actually, the skip system is already supposed

[issue13053] Add Capsule migration documentation to "cporting"

2011-10-02 Thread Nick Coghlan
Nick Coghlan added the comment: Mostly looks good - couple of minor comments in Reitveld. As far as the patch flow goes, the 2.x and 3.x branches are actually handled independently (they're too divergent for merging to make sense). So 2.7 and 3.2 will be independent commits, then the changes

[issue12804] "make test" fails on systems without internet access

2011-10-02 Thread Nadeem Vawda
Nadeem Vawda added the comment: > Change reverted. "make test" should run a comprehensive test of > Python's facilities Fair enough. > If it is easy to detect network availability programmatically, we could > just use the skip system. +1. I don't know if there is a reasonable way to do this,

[issue13091] ctypes: memory leak

2011-10-02 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc added the comment: How did you obtain this? the resize() function is not called by test_multiprocessing. And are you sure that it's not some kind of reference leak? (this pointer is tied to a CDataObject; its tp_alloc should free the memory) -- __

[issue12753] \N{...} neglects formal aliases and named sequences from Unicode charnames namespace

2011-10-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: > Really? White space makes things harder to read? I thought Pythonistas > believed the opposite of that. I was surprised at that too ;-). One person's opinion in a specific context. Don't generaliza. > English titling rules > only capitalize the first word

[issue1625] bz2.BZ2File doesn't support multiple streams

2011-10-02 Thread Nadeem Vawda
Nadeem Vawda added the comment: > This is all fine and well, but this is clearly a bug and not a feature. No, it is not at all clear that this is a bug. I agree that this is a desirable capability to have, but nowhere does the module claim to support multi-stream files. Nor is it an inherent f

[issue5001] Remove assertion-based checking in multiprocessing

2011-10-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you. I've attached some comments, click on the "review" link to read them. -- assignee: jnoller -> nosy: +pitrou -BreamoreBoy stage: needs patch -> patch review versions: +Python 3.3 -Python 3.1 ___ Python tra

[issue5001] Remove assertion-based checking in multiprocessing

2011-10-02 Thread Vlad Riscutia
Vlad Riscutia added the comment: I attached a patch which replaces all asserts with checks that raise exceptions. I used my judgement in determining exception types but I might have been off in some places. Also, this patch replaces ALL asserts. It is possible that some of the internal functi

[issue12753] \N{...} neglects formal aliases and named sequences from Unicode charnames namespace

2011-10-02 Thread Tom Christiansen
Tom Christiansen added the comment: Ezio Melotti wrote on Sun, 02 Oct 2011 06:46:26 -: > Actually Python doesn't seem to support \N{LINE FEED (LF)}, most likely bec= > ause that's a Unicode 1 name, and nowadays these codepoints are simply mark= > ed as ''. Yes, but there are a lot of

[issue13084] test_signal failure

2011-10-02 Thread Charles-François Natali
Changes by Charles-François Natali : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue12458] Tracebacks should contain the first line of continuation lines

2011-10-02 Thread lesmana
Changes by lesmana : -- nosy: +lesmana ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue4147] xml.dom.minidom toprettyxml: omit whitespace for text-only elements

2011-10-02 Thread R. David Murray
R. David Murray added the comment: Heh, you happened to post your patch at a time when I wanted something to do as a break from something I didn't want to do...and I *thought* I understood the problem, after reading the various links. But clearly I didn't. We don't have someone who has step

[issue10141] SocketCan support

2011-10-02 Thread Charles-François Natali
Charles-François Natali added the comment: So, Victor, what do you think of the last version? This patch has been lingering for quite some time, and it's really a cool feature. -- ___ Python tracker __

[issue13001] test_socket.testRecvmsgTrunc failure on FreeBSD 7.2 buildbot

2011-10-02 Thread Charles-François Natali
Charles-François Natali added the comment: > @requires_freebsd_version should be factorized with > @requires_linux_version. Patches attached. > Can we workaround FreeBSD (< 8) bug in C/Python? Not really. > Or should we remove the function on FreeBSD < 8? There's really no reason to do that

[issue13084] test_signal failure

2011-10-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset e4f4272479d0 by Charles-François Natali in branch 'default': Issue #13084: Fix a test_signal failure: the delivery order is only defined for http://hg.python.org/cpython/rev/e4f4272479d0 -- nosy: +python-dev ___

[issue13092] pep-393: memory leaks #2

2011-10-02 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13090] posix_read: memory leak

2011-10-02 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13093] Redundant code in PyUnicode_EncodeDecimal()

2011-10-02 Thread Stefan Krah
New submission from Stefan Krah : I can't see what this code is supposed to accomplish (see patch): while (collend < end) { if ((0 < *collend && *collend < 256) || !Py_UNICODE_ISSPACE(*collend) || Py_UNICODE_TODECIMAL(*collend)) break; } Since 'collend'

[issue13091] ctypes: memory leak

2011-10-02 Thread Meador Inge
Changes by Meador Inge : -- components: +ctypes nosy: +amaury.forgeotdarc, belopolsky, meador.inge ___ Python tracker ___ ___ Python-b

[issue13089] parsetok.c: memory leak

2011-10-02 Thread Meador Inge
Changes by Meador Inge : -- nosy: +meador.inge ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue3902] Packages containing only extension modules have to contain __init__.py

2011-10-02 Thread Éric Araujo
Éric Araujo added the comment: We’re working on a patch on the core-mentorship list. -- components: +Distutils nosy: +alexis stage: needs patch -> patch review versions: +Python 2.7, Python 3.2, Python 3.3 ___ Python tracker

[issue12804] make test should not enable the urlfetch resource

2011-10-02 Thread Éric Araujo
Éric Araujo added the comment: I don’t have a flaky connection, I have none at all; until this change I could always run just use “make test” for all Python versions. OTOH, I agree with your point that testing networking facilities in the standard test suite makes sense, as most people proba

[issue4147] xml.dom.minidom toprettyxml: omit whitespace for text-only elements

2011-10-02 Thread Dan Kenigsberg
Dan Kenigsberg added the comment: btw, http://www.w3.org/TR/xml/#sec-white-space is a bit vague on how should a parser deal with whitespace, and seems to allow non-preservation of text nodes. Preserving "simple" text nodes is allowed, too, and is more polite to applications reading the pretty

[issue4147] xml.dom.minidom toprettyxml: omit whitespace for text-only elements

2011-10-02 Thread Dan Kenigsberg
Dan Kenigsberg added the comment: Oh dear. Thanks, Enzio, for pointing out that former patch is wrong. It is also quite naive, since the whole NATURE of toprettyprint() is to add whitespace to Text nodes. Tomas Lee's http://bugs.python.org/file11832/minidom-toprettyxml-01.patch made an effor

[issue7689] Pickling of classes with a metaclass and copy_reg

2011-10-02 Thread Lance Hepler
Changes by Lance Hepler : -- nosy: +nlhepler ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13084] test_signal failure

2011-10-02 Thread Stefan Krah
Stefan Krah added the comment: Patch looks good to me (and it fixes the problem). -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue13076] Bad links to 'time' in datetime documentation

2011-10-02 Thread Ezio Melotti
Ezio Melotti added the comment: This should be fixed now, thanks for the report. FTR with Sphinx 1.0 all the links to :class:`time` and also :class:`datetime` needed to be fixed because they were pointing to the modules, with 0.6 only the :class:`time` in the body of attribute/method directive

[issue13092] pep-393: memory leaks #2

2011-10-02 Thread Stefan Krah
New submission from Stefan Krah : I found a couple of additional leaks related to the PEP-393 changes. -- components: Interpreter Core files: pep-393-leaks-2.diff keywords: patch messages: 144767 nosy: loewis, skrah priority: normal severity: normal stage: patch review status: open title

[issue13076] Bad links to 'time' in datetime documentation

2011-10-02 Thread Roundup Robot
Roundup Robot added the comment: New changeset 854e31d80151 by Ezio Melotti in branch '2.7': #13076: fix links to datetime.time. http://hg.python.org/cpython/rev/854e31d80151 New changeset 95689ed69097 by Ezio Melotti in branch '3.2': #13076: fix links to datetime.time and datetime.datetime. ht

[issue13091] ctypes: memory leak

2011-10-02 Thread Stefan Krah
New submission from Stefan Krah : Seen in test_multiprocessing: ==31662== 44 bytes in 1 blocks are definitely lost in loss record 687 of 10,548 ==31662==at 0x4C2154B: malloc (vg_replace_malloc.c:236) ==31662==by 0x41CC27: PyMem_Malloc (object.c:1699) ==31662==by 0x127D9F51: resize (c

[issue13090] posix_read: memory leak

2011-10-02 Thread Stefan Krah
New submission from Stefan Krah : Seen in test_multiprocessing: ==31662== 37 bytes in 1 blocks are definitely lost in loss record 629 of 10,548 ==31662==at 0x4C2154B: malloc (vg_replace_malloc.c:236) ==31662==by 0x53BBE9: PyBytes_FromStringAndSize (bytesobject.c:98) ==31662==by 0x4E2

[issue13089] parsetok.c: memory leak

2011-10-02 Thread Stefan Krah
New submission from Stefan Krah : Seen in test_mailbox: ==31621== 6 bytes in 2 blocks are definitely lost in loss record 27 of 10,370 ==31621==at 0x4C2154B: malloc (vg_replace_malloc.c:236) ==31621==by 0x5271A5: parsetok (parsetok.c:179) ==31621==by 0x526E8A: PyParser_ParseStringFlag

[issue13076] Bad links to 'time' in datetime documentation

2011-10-02 Thread Georg Brandl
Georg Brandl added the comment: No, it's not, it's how Sphinx works. Use :class:`.time` to refer to the datetime class. -- ___ Python tracker ___ __

[issue13076] Bad links to 'time' in datetime documentation

2011-10-02 Thread Ezio Melotti
Ezio Melotti added the comment: The broken links seem to be only in the "time objects" section, and only in the body of attribute/method directives. The attached patch fixes the issue by using :class:`~datetime.time` explicitly where the links are broken. Georg, is this a bug in Sphinx? ---

[issue12753] \N{...} neglects formal aliases and named sequences from Unicode charnames namespace

2011-10-02 Thread Ezio Melotti
Ezio Melotti added the comment: Attached a new patch with more tests and doc. -- Added file: http://bugs.python.org/file23291/issue12753-3.diff ___ Python tracker ___ __

[issue13073] message_body argument of HTTPConnection.endheaders is undocumented

2011-10-02 Thread Ben Hayden
Ben Hayden added the comment: I added in docs for the method from the actual method docstring from the http.client module. -- keywords: +patch nosy: +beardedp Added file: http://bugs.python.org/file23290/issue13073.patch ___ Python tracker