[issue14065] Element should support cyclic GC

Changes by Eli Bendersky : -- nosy: +eli.bendersky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue14178] Failing tests for ElementTree

Eli Bendersky added the comment: Correction: extended slices are supported. The problem appears to be just with 'del', because element_ass_subscr doesn't treat it specially and thinks we just want to assign a 0-len value to a non-0-len slice. -- __

[issue14178] Failing tests for ElementTree

Eli Bendersky added the comment: I can confirm that this indeed fails for the C implementation, while succeeding for the Python implementation. The C implementation doesn't appear to support extended slices for getting and setting items. Looking into it. -- _

[issue14171] warnings from valgrind about openssl as used by CPython

Zooko O'Whielacronx added the comment: Oh, I'm sorry I didn't make that clear at first. First of all, so that others who encounter these warnings can see how I worked-around them so that they can do that as well. Second, because Python comes with a valgrind suppressions file. Here is a patch

[issue14177] marshal.loads accepts unicode strings

Antoine Pitrou added the comment: I've committed the patch in 3.2 and 3.3. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker __

[issue14177] marshal.loads accepts unicode strings

Roundup Robot added the comment: New changeset 4966907d3661 by Antoine Pitrou in branch '3.2': Issue #14177: marshal.loads() now raises TypeError when given an unicode string. http://hg.python.org/cpython/rev/4966907d3661 New changeset e67b3a9bd2dc by Antoine Pitrou in branch 'default': - Issue

[issue14169] compiler.compile fails on "if" statement in attached file

Changes by Antoine Pitrou : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue14177] marshal.loads accepts unicode strings

guilherme-pg added the comment: Guilherme Gonçalves Thanks for the quick review. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue14177] marshal.loads accepts unicode strings

Antoine Pitrou added the comment: Thank you! What is your full name, for credits? -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue14177] marshal.loads accepts unicode strings

guilherme-pg added the comment: Oops, sorry, that was unintended. I uploaded a new version of the patch with the correct documentation update, making it explicit that loads() expects a bytes object. -- Added file: http://bugs.python.org/file24717/14177-marshal-loads-deny-strings-2.pa

[issue14171] warnings from valgrind about openssl as used by CPython

Martin v. Löwis added the comment: Why are you reporting this issue here? -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-lis

[issue14177] marshal.loads accepts unicode strings

Antoine Pitrou added the comment: Thank you. The patch looks almost perfect, just one nit: apparently you changed the documentation for marshal.dumps. Is that intended? -- ___ Python tracker _

[issue13964] os.utimensat() and os.futimes() should accept (sec, nsec), drop os.futimens()

Changes by STINNER Victor : -- title: os.utimensat() and os.futimes() should accept Decimal, drop os.futimens() -> os.utimensat() and os.futimes() should accept (sec, nsec), drop os.futimens() ___ Python tracker

[issue13550] Rewrite logging hack of the threading module

Roundup Robot added the comment: New changeset 8ec51b2e57c2 by Victor Stinner in branch 'default': Close #13550: Remove the debug machinery from the threading module: remove http://hg.python.org/cpython/rev/8ec51b2e57c2 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rej

[issue13964] os.utimensat() and os.futimes() should accept Decimal, drop os.futimens()

STINNER Victor added the comment: > Um, doesn't the rejection of PEP 410 mean this should be discontinued? There is an issue in shutil.copystat() on copying the timestamp: in this specific use case, we need nanosecond resolution. Guido proposes (in a private mail thread) to add st_atime_ns, s

[issue13964] os.utimensat() and os.futimes() should accept Decimal, drop os.futimens()

Larry Hastings added the comment: Um, doesn't the rejection of PEP 410 mean this should be discontinued? -- nosy: +larry ___ Python tracker ___ _

[issue13964] os.utimensat() and os.futimes() should accept Decimal, drop os.futimens()

STINNER Victor added the comment: I created the issue #14180 to prepare a refactoring before changing os.*utime*() functions. -- ___ Python tracker ___

[issue14180] Factorize code to convert int/float to time_t, timeval or timespec

New submission from STINNER Victor : There are various ways to convert a Python int/float to a C time_t, timeval or timespec structure. Attached patch factorize code by adding functions to convert a Python object to a C type (time_t, timeval or timespec). My patch changes how datetime rounds m

[issue14161] python2 file __repr__ does not escape filename

Philip Jenvey added the comment: I think you want to decref the result of PyObject_Repr after the fact, too -- nosy: +pjenvey ___ Python tracker ___

[issue14177] marshal.loads accepts unicode strings

guilherme-pg added the comment: The attached patch attempts to solve the issue. It makes sure marshal.loads only accepts objects conforming to the buffer protocol, updates the documentation for the method accordingly, adds a test case and updates existing test cases that rely on this issue.

[issue14176] Fix unicode literals

Terry J. Reedy added the comment: > That would mean in Python 3, '...' works and u'...' will not work. You misunderstand the PEP: in 3.3, '...' and u'...' will be *exactly* the same. The only change is that the interpreter will ignore the u prefix instead of raising SyntaxError. It will be as

[issue14176] Fix unicode literals

Jean-Michel Fauth added the comment: You do not get it or I do not explain it correctly. I do not care if Py 3.3 accepts '...' ou u'...'. I'm only affraid, Py 3.3 is suffering from the same non working behaviour Python 2 is suffering. I have seen so many things... I can only use an Py2/Py3 ana

[issue14176] Fix unicode literals

Terry J. Reedy added the comment: As I explained to J-M when he posted much the same to python-list, Idle's French keyboard support is faulty because tcl/tk's French keyboard support is faulty. A patch for this was recently applied to tcl/tk. I hope it will be in a released version that we ca

[issue13964] os.utimensat() and os.futimes() should accept Decimal, drop os.futimens()

Roundup Robot added the comment: New changeset 67d9595a833c by Victor Stinner in branch 'default': Issue #13964: signal.sigtimedwait() timeout is now a float instead of a tuple http://hg.python.org/cpython/rev/67d9595a833c -- ___ Python tracker

[issue13981] time.sleep() should use nanosleep() if available

STINNER Victor added the comment: The PEP 410 has been rejected, so I close the issue. -- resolution: -> wont fix status: open -> closed ___ Python tracker ___

[issue14169] compiler.compile fails on "if" statement in attached file

Terry J. Reedy added the comment: Please provide a *minimal* example that exhibits the problem. 'Minimal' means that if a single line is removed, the problem disappears. -- nosy: +terry.reedy ___ Python tracker _

[issue14126] Speed up list comprehensions by preallocating the list where possible

Raymond Hettinger added the comment: This seems like a reasonable optimization to me. -- assignee: rhettinger -> ___ Python tracker ___

[issue13882] PEP 410: Use decimal.Decimal type for timestamps

STINNER Victor added the comment: The PEP has been rejected, so I close the issue. -- resolution: -> wont fix status: open -> closed ___ Python tracker ___

[issue14146] IDLE: source line in editor doesn't highlight when debugging

Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue14141] 2.7.2 64-bit Windows library has __impt_Py* for several symbols instead of __imp__Py*

Terry J. Reedy added the comment: I am building and running 2.7.2 on 64-bit Win 7 from the repository but not linking to anything else. Please look at the 2.7.3 release candidate. -- nosy: +terry.reedy ___ Python tracker

[issue14126] Speed up list comprehensions by preallocating the list where possible

Terry J. Reedy added the comment: I think this proposal should be rejected for three reasons. 1. I believe the idea is faulty in that it can only work if the single source iterable *has* a known length. The compiler cannot, in general, determine that and in practice seldom would be able to. F

[issue14176] Fix unicode literals

R. David Murray added the comment: I'm changing the title since PEP 414 has no bearing here. -- title: Fix unicode literals (for PEP 414) -> Fix unicode literals ___ Python tracker

[issue14176] Fix unicode literals (for PEP 414)

R. David Murray added the comment: OK, so I still don't understand what problem it is you are reporting. What do you mean by "can't craete non-valid strings"? Of course you can't. (I don't see how you could do that programatically, either, although that depends heavily on your definition o

[issue14176] Fix unicode literals (for PEP 414)

Jean-Michel Fauth added the comment: Sorry, I neglected the most important information. Python 3.2 is working perfectly. It is simply impossible to create non valid strings (type/class 'str') from a keyboard. (non programmatically created). Like the limited characters set I used when I wrote m

[issue6784] byte/unicode pickle incompatibilities between python2 and python3

Merlijn van Deen added the comment: And a complete patch that implements the tests, the python implementation and the C implementation. I'm not completely happy with the code duplication in read_string/read_binstring/read_short_binstring C implementation, so that might be an improvement (howe

[issue14176] Fix unicode literals (for PEP 414)

R. David Murray added the comment: Unless I'm misunderstanding, this is a duplicate of issue 1602. You will note that the problem is *not* with Python (or open source software in general), the problem is that Microsoft treats the command line as a second (or third, or fourth) class citizen.

[issue14176] Fix unicode literals (for PEP 414)

Georg Brandl added the comment: Well, let me soothe your mind then: in Python 3, '...' and u'...' will be absolutely equal, so you won't find any more "mess" with the changes from PEP 414. -- nosy: +georg.brandl ___ Python tracker

[issue14176] Fix unicode literals (for PEP 414)

Jean-Michel Fauth added the comment: I deliberately hid the information about the used interactive interpreter; just to show you the "experience" of new Python user. (This is what I'm showing to potential Python devs who are interested in this tool; I know Python and use it since v. 1.5.6 as a n

[issue14163] tkinter: problems with hello doc example

Terry J. Reedy added the comment: G, another but in the original ;-) Thank you! I will incorporate into the doc now. -- Added file: http://bugs.python.org/file24713/tk_hello.py ___ Python tracker _

[issue14163] tkinter: problems with hello doc example

Changes by Terry J. Reedy : Removed file: http://bugs.python.org/file24712/tk_hello.py ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue14163] tkinter: problems with hello doc example

Roger Serwy added the comment: Ah, that's subtle. There's a comma at the end of that ["text"] line which is making the string a one-element tuple. Removing it fixes the issue. -- ___ Python tracker __

[issue14163] tkinter: problems with hello doc example

Changes by Terry J. Reedy : Removed file: http://bugs.python.org/file24693/tk_hello.py ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue14163] tkinter: problems with hello doc example

Terry J. Reedy added the comment: Do you know anything about spaces in the button text causing the addition of {bra ces}? I would prefer not to have to use an underscore in Hello_World. I fixed the long line and also updated pack calls pass options by name instead of a dict. -- Added

[issue14144] urllib2 HTTPRedirectHandler not forwarding POST data in redirect

Jay Deiman added the comment: Senthil, The HTTPRedirectHandler is already breaking RFC2616 by it's own admission in the code comments (from the source): # Strictly (according to RFC 2616), 301 or 302 in response # to a POST MUST NOT cause a redirection without confirmation # from the user (of

[issue14163] tkinter: problems with hello doc example

Roger Serwy added the comment: I tried your tk_hello.py code and it works on Python 3. The code for creating the QUIT button exceeds 80 columns. I'd insert a \n after the second argument: self.QUIT = tk.Button(self, text = "QUIT", fg = "red", command =

[issue14163] tkinter: problems with hello doc example

Roger Serwy added the comment: I tried your tk_hello.py code and it works on Python 3. The code for creating the QUIT button exceeds 80 columns. I'd insert a \n after the second argument: self.QUIT = tk.Button(self, text = "QUIT", fg = "red", command =

[issue14179] Test coverage for lib/re.py

Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> patch review type: -> enhancement versions: +Python 2.7, Python 3.2 ___ Python tracker ___ __

[issue14179] Test coverage for lib/re.py

Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> patch review type: -> enhancement versions: +Python 2.7, Python 3.2 ___ Python tracker ___ __

[issue14179] Test coverage for lib/re.py

New submission from Florian M : I added one small test in lib/test/test_re.py for complete coverage of 're._compile' method. -- components: Tests files: re_coverage.patch keywords: patch messages: 154785 nosy: flomm priority: normal severity: normal status: open title: Test coverage for

[issue14172] ref-counting leak in buffer usage in Python/marshal.c

Antoine Pitrou added the comment: Fixed. Apparently 2.7 isn't affected. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue14172] ref-counting leak in buffer usage in Python/marshal.c

Roundup Robot added the comment: New changeset 185a6ae76479 by Antoine Pitrou in branch '3.2': Issue #14172: Fix reference leak when marshalling a buffer-like object (other than a bytes object). http://hg.python.org/cpython/rev/185a6ae76479 New changeset b1303cf15e01 by Antoine Pitrou in branc

[issue14176] Fix unicode literals (for PEP 414)

Martin v. Löwis added the comment: What operating system and what terminal are you using? If Windows: what code page does your terminal run in? -- nosy: +loewis ___ Python tracker

[issue4773] HTTPMessage not documented and has inconsistent API across 2.6/3.0

Joel Verhagen added the comment: There is a difference in what HTTPResponse.getheaders() returns. Python 2.7.2 (default, Jun 12 2011, 14:24:46) [MSC v.1500 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import httplib >>> c = httplib.HTTPCon

[issue14178] Failing tests for ElementTree

Changes by Ezio Melotti : -- nosy: +eli.bendersky, ezio.melotti, flox stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-li

[issue14178] Failing tests for ElementTree

New submission from Stefan Behnel : These are tests from lxml's ET compatibility test suite that now fail in ElementTree: def test_delslice_step(self): Element = self.etree.Element SubElement = self.etree.SubElement a = Element('a') b = SubElement(a, 'b')

[issue14175] broken links on /download/ page

Georg Brandl added the comment: I fixed the links on /download/ and added the other versions on /releases/. -- nosy: +georg.brandl resolution: -> fixed status: open -> closed ___ Python tracker __

[issue14177] marshal.loads accepts unicode strings

New submission from Antoine Pitrou : >>> marshal.loads('T') True >>> marshal.loads(b'T') True Contrast with: >>> marshal.load(io.BytesIO(b'T')) True >>> marshal.load(io.StringIO('T')) Traceback (most recent call last): File "", line 1, in TypeError: f.read() returned not bytes but str -

[issue14167] document return statement in finally blocks

Yury Selivanov added the comment: Well, I guess the best place to put it would be http://docs.python.org/py3k/reference/compound_stmts.html#finally I've attached the patch, please take a look. If it's possible to make it more clear, feel free to rephrase it. But please include the example,

[issue4080] unittest: display time used by each test case

Pawel Prokop added the comment: I agree with Ezio, this feature should have an option to enable/disable. Anyway, I use it in different way. Since 2008, I've used this feature for performance comparision, whether some implementation changes in application code did not slow down application. T

[issue14172] ref-counting leak in buffer usage in Python/marshal.c

Changes by Antoine Pitrou : -- stage: -> patch review versions: -Python 3.1 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14172] ref-counting leak in buffer usage in Python/marshal.c

Antoine Pitrou added the comment: Here is a patch. -- keywords: +patch nosy: +pitrou, skrah Added file: http://bugs.python.org/file24708/marshalbufs.patch ___ Python tracker ___

[issue11379] Remove "lightweight" from minidom description

Stefan Behnel added the comment: Yes, I think that's better. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11379] Remove "lightweight" from minidom description

Éric Araujo added the comment: s/Mininal/Minimal/ in the synopsis -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue11379] Remove "lightweight" from minidom description

Éric Araujo added the comment: Right, patch for 3.2. Also edited the module docstring (info taken from the docstring of xml.dom). BTW I really think we could have avoided some verbosity by adding the recommendation to use xml.etree in the first paragraph of Doc/library/xml.dom.minidom.rst.

[issue4080] unittest: display time used by each test case

Éric Araujo added the comment: Also, when you’re tracking down slow tests, you may want to run your tests with the time needed by each test file and then each test method. Nite that I don’t know of a way to have unittest print each test file to stdout now (i.e. a level of verbosity between “j

[issue14170] print unicode string error in win8 cmd console

STINNER Victor added the comment: It looks like a duplicate of the issue #11395 which has been fixed in Python 3.2.1, but not backported to Python 2.7. Can you please try your program with Python 3.2.1? And maybe also attach the whole test script? -- ___

[issue4080] unittest: display time of each test case

Ezio Melotti added the comment: Because it looks like line noise and doesn't provide an useful information in most of the cases (at least for me), see e.g.: + test_format (__main__.MyTestCase) ... [0.000612s] skipped 'not supported in this library version' + test_nothing (__main__.MyTestC

[issue14170] print unicode string error in win8 cmd console

Changes by Antoine Pitrou : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue14173] PyOS_FiniInterupts leaves signal.getsignal segfaulty

Antoine Pitrou added the comment: I needed to modify the script to make it crash under 3.2/3.3. Attaching modified version. Here is the relevant part of the gdb traceback: Program received signal SIGSEGV, Segmentation fault. 0x0052b87b in signal_getsignal (self=, args=(1,)) at ./

[issue11379] Remove "lightweight" from minidom description

Ezio Melotti added the comment: "Minimal" sounds good to me, it also matches the name of the module. -- ___ Python tracker ___ ___ Py

[issue11379] Remove "lightweight" from minidom description

Antoine Pitrou added the comment: > I think I’ve always understood “lightweight” to mean “minimal”. Then how about saying "minimal" instead of "lightweight"? (also, it seems it really means "incomplete" or "partial", which are of course less positive sounding) --

[issue14176] Fix unicode literals (for PEP 414)

Changes by Ezio Melotti : -- components: +Unicode -None nosy: +ezio.melotti type: -> behavior ___ Python tracker ___ ___ Python-bugs-

[issue14133] improved PEP 409 implementation

Changes by Patrick Westerhoff : -- nosy: +poke ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue14176] Fix unicode literals (for PEP 414)

Benjamin Peterson added the comment: What exactly is the bug you're reporting? Python 2.7.2 (default, Oct 27 2011, 22:35:02) [GCC 4.5.3] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> print u'abcœé€' abcœé€ -- nosy: +benjamin.peterson ___

[issue10181] Problems with Py_buffer management in memoryobject.c (and elsewhere?)

Nick Coghlan added the comment: It occurs to me that one thing that *could* be backported to early versions are some of the documentation improvements on how to correctly handle the lifecycle of fields in Py_buffer. That gets messy though because memoryview doesn't behave nicely in those vers

[issue14176] Fix unicode literals (for PEP 414)

New submission from Jean-Michel Fauth : Now, that the PEP 414 has been accepted, I can only strongly recommend to fix the problem of unicode literals as a partial workaround. >>> print u'abcœé€' abcé >>> If these six characters are not rendered correctly, you shoud read: LATIN SMALL LETTER A L

[issue14175] broken links on /download/ page

New submission from Florent Xicluna : The links for the latest RC are broken on the official page. http://www.python.org/download/ And the "release" page only list 3.2.3 rc1 and forget the other 3: http://www.python.org/download/releases/ -- messages: 154762 nosy: flox priority: normal

[issue14174] argparse.REMAINDER fails to parse remainder correctly

Changes by Arnout van Meer : Added file: http://bugs.python.org/file24704/worker.py ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue14174] argparse.REMAINDER fails to parse remainder correctly

Changes by Arnout van Meer : Removed file: http://bugs.python.org/file24704/worker.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14174] argparse.REMAINDER fails to parse remainder correctly

Changes by Arnout van Meer : Removed file: http://bugs.python.org/file24704/worker.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14174] argparse.REMAINDER fails to parse remainder correctly

Changes by Arnout van Meer : Added file: http://bugs.python.org/file24705/bug_argparse.py ___ Python tracker ___ ___ Python-bugs-list mailing

[issue14174] argparse.REMAINDER fails to parse remainder correctly

Changes by Arnout van Meer : Added file: http://bugs.python.org/file24704/worker.py ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue14174] argparse.REMAINDER fails to parse remainder correctly

Changes by Arnout van Meer : Removed file: http://bugs.python.org/file24704/worker.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue14174] argparse.REMAINDER fails to parse remainder correctly

New submission from Arnout van Meer : Reproduction case is attached and should speak for itself, but the short brief is that the argparse.REMAINDER behaviour is very inconsistent based on what (potentially) defined argument handlers come before it. Tested this on Python 2.7 on OS X, but also g

[issue11379] Remove "lightweight" from minidom description

Éric Araujo added the comment: I think I’ve always understood “lightweight” to mean “minimal”. xml.dom provides minidom, a basic implementation, pulldom, a different implementation, and other libraries such as 4Dom are full-fledged implementations. So “lightweight” is not a problem to me (b

[issue11379] Remove "lightweight" from minidom description

Eli Bendersky added the comment: Stefan, frankly I'm not familiar enough with either xml.dom or xml.dom.minidom to have a solid opinion at this point. -- ___ Python tracker ___

[issue14173] PyOS_FiniInterupts leaves signal.getsignal segfaulty

New submission from Ferringb : During Py_Finalize (pythonrun.c), it does the following: 1) suppress signal handling PyOs_FiniInterupts 2) clear caches 3) force gc collection; first for objects, then via wiping modules. The problem is that for unix OSs, Modules/signal.c's PyOs_FiniInterrupts leav

[issue13462] Improve code and tests for Mixin2to3

Changes by Eli Bendersky : -- priority: -> normal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue14128] _elementtree should expose types and factory functions consistently with ElementTree

Eli Bendersky added the comment: Attaching a patch that exposes ET.Element as a type, instead of as a factory function. I'd really love to get a review for this, since I'm still relatively inexperienced when it comes to writing C extension code. -- keywords: +patch Added file: http:/

[issue11379] Remove "lightweight" from minidom description

Stefan Behnel added the comment: Thanks Eli. What about the "Lightweight DOM implementation", though? Following Martin's comment that performance characteristics (like "fast", "memory friendly" or "lightweight") should normally not be documented, I'm still suggesting to replace it with a les

[issue14170] print unicode string error in win8 cmd console

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue14172] ref-counting leak in buffer usage in Python/marshal.c

New submission from Stefan Behnel : Line 428 in Python/marshal.c calls pb->bf_releasebuffer() without dec-refing the view.obj field afterwards. I don't think this is really so truly performance critical that it can't accept the couple of nanoseconds that it takes to go through PyBuffer_Release

[issue14158] test_mailbox fails if file or dir named by support.TESTFN exists

Vinay Sajip added the comment: > Is 2.7 not affected? It might be, but the code for regrtest looked somewhat different. I will revisit this once the buildbots have run for a few days with the 3.x changes, to confirm that they are OK. Marking as pending to remind me. -- status: closed

[issue14168] Bug in minidom 3.3 after optimization patch

Éric Araujo added the comment: Agreed :) Needs unit tests that use the public attributes. -- keywords: +easy -3.2regression stage: -> needs patch title: minidom behaves differently in 3.3 compared to 3.2 -> Bug in minidom 3.3 after optimization patch

[issue14168] minidom behaves differently in 3.3 compared to 3.2

Vinay Sajip added the comment: Upon inspection, _ensure_attributes() is only called in _get_attributes(), setAttributeNode() and _set_attribute_node(). The last of these is only called by setAttributeNode(), and it would appear that setAttributeNode() is only called if there *are* attributes.

[issue14168] minidom behaves differently in 3.3 compared to 3.2

Vinay Sajip added the comment: The error which prompted this issue was not caused by external code peeking into the internals - it was just my toy test script which did that. The error came up in Django testing: == ERROR: tes

[issue8754] quote bad module name in ImportError-like messages

Éric Araujo added the comment: > With issue1559549 adding a 'name' argument, I'm going to push to have it gain > a reasonable default > __str__ if 'name' is set but nothing else. That patch also contains some > helper functions which > should simplify Eric's patch. Maybe you’re talking about

[issue8706] accept keyword arguments on most base type methods and builtins

Éric Araujo added the comment: See also #13386 for the doc part. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri