Larry Hastings la...@hastings.org added the comment:
Serihy: for the followlinks patch, how about we plan ahead: I give you
feedback for just the code (if there is any), and then I take over the patch
and do the doc rewrite that I will find irresistable.
--
R. David Murray rdmur...@bitdance.com added the comment:
I think that sounds reasonable. The message should say files in all three
cases', since the individual test file summary method will be similar but
talking about numbers of tests.
--
___
Tim Golden m...@timgolden.me.uk added the comment:
On 30/06/2012 06:45, Daniel Lenski wrote:
My preferred solution would be to replace the binary delete argument of the
current NamedTemporaryFile implementation with finer-grained options:
delete=False # don't delete
Serhiy Storchaka storch...@gmail.com added the comment:
If it produces different output today, we should investigate why.
Lib/stringprep.py differs from updated Tools/unicode/mkstringprep.py output
only by additional entity 0x130:'i\u0307' in b3_exceptions.
In 3.2 and lower '\u0130'.lower()
Borja Ruiz Castro br...@alienvault.com added the comment:
Hi Murray!
I use a lot od parametrized tests. I usually use the ENV to pass these
parameters and/or a custon configuration file.
What is your approach to parametrize all the test stuff?
Regards,
Borja.
On 31 May 2012 03:57, R. David
Borja Ruiz Castro br...@alienvault.com added the comment:
Sorry, I failed to mention that I use Testify to launch all my tests!
On 2 July 2012 13:23, Borja Ruiz Castro rep...@bugs.python.org wrote:
Borja Ruiz Castro br...@alienvault.com added the comment:
Hi Murray!
I use a lot od
Amaury Forgeot d'Arc amaur...@gmail.com added the comment:
In PyPy, datetime.py is a pure Python module (similar to the one in 3.x, but
without the _datetime acceleration module). So comparison with CPython is not
relevant here.
In CPython, __module__ is not an attribute of the type, but a
Richard Oudkerk shibt...@gmail.com added the comment:
I wrote in an earlier message that a file opened with O_TEMPORARY must be
reopened with O_TEMPORARY. This is not quite accurate.
Using O_TEMPORARY causes the FILE_SHARE_DELETE sharing mode to be used, and a
file currently opened with
Larry Hastings la...@hastings.org added the comment:
Storchaka: change of plan. Since doc changes are much lower risk than code
changes, how about we go with your existing patch and I'll fix up the docs
separately.
So, please make the relevant code changes I proposed on Rietveld (adding *,
Larry Hastings la...@hastings.org added the comment:
Here's a patch. I read the implementation to find out what it does, then
documented it. Happily it does the sane thing.
--
keywords: +patch
Added file: http://bugs.python.org/file26230/larry.atexit.1.diff
Antoine Pitrou pit...@free.fr added the comment:
Here's a patch. I read the implementation to find out what it does,
then documented it. Happily it does the sane thing.
Is it tested for?
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka storch...@gmail.com added the comment:
So, please make the relevant code changes I proposed on Rietveld (adding *,
everywhere was it iirc) and resubmit and we can get that in. I'll give you a
code-only review of the other patch too--I'll start on that now.
Here is a
Antoine Pitrou pit...@free.fr added the comment:
What's the urge to make parameters keyword-only?
Also, copyfile() shouldn't change signature.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15202
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file:
http://bugs.python.org/file26232/symlinks-to-follow_symlinks-4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15202
___
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file26233/symlinks-to-follow_symlinks-4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15202
___
Serhiy Storchaka storch...@gmail.com added the comment:
What's the urge to make parameters keyword-only?
If anyone uses these functions with a new symlinks parameter in 3.3b1,
he will get loud error (follow_symlinks == not symlinks).
Also, copyfile() shouldn't change signature.
Why not?
Antoine Pitrou pit...@free.fr added the comment:
Also, copyfile() shouldn't change signature.
Why not?
Seems like I have misread the docs. Apparently the symlinks parameter was added
in 3.3.
--
___
Python tracker rep...@bugs.python.org
Petri Lehtinen pe...@digip.org added the comment:
This might be the only way to fix #1599254, see
http://bugs.python.org/issue1599254#msg30590. If another program is waiting on
the fcntl lock (and doesn't use dotlocking), as soon as mailbox.py closes the
original file (to replace it with a
Brett Cannon br...@python.org added the comment:
Changeset b7463ec1980c has the fix and test update (went with a simple solution
for the tests which uses the mock to verify). Thanks to Ronan and Marc for
helping out!
--
dependencies: -Split .pyc parsing from module loading
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 818db871d29a by Brett Cannon in branch 'default':
Issue #15210: If _frozen_importlib is not found in sys.modules by
http://hg.python.org/cpython/rev/818db871d29a
--
nosy: +python-dev
Changes by Brett Cannon br...@python.org:
--
assignee: - brett.cannon
resolution: - fixed
stage: test needed - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15210
Changes by Brett Cannon br...@python.org:
--
dependencies: +Implement imp.get_tag() using sys.implementation
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15056
___
Éric Araujo mer...@netwok.org added the comment:
See #9788 for previous discussion.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15233
___
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset b36bed82c9d0 by Brett Cannon in branch 'default':
Issue #15166: Re-implement imp.get_tag() using sys.implementation.
http://hg.python.org/cpython/rev/b36bed82c9d0
--
nosy: +python-dev
Brett Cannon br...@python.org added the comment:
I ended up applying Eric's patch from #14797 and then comparing against Jeff's
patch here since Eric's cleaned up the C code. Thanks to both for the work!
--
resolution: - fixed
stage: needs patch - committed/rejected
status: open -
Brett Cannon br...@python.org added the comment:
I meant issue #13959 for Eric's patch; wrong tab. =)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15166
___
Changes by Brett Cannon br...@python.org:
--
resolution: - out of date
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2345
___
Changes by Brett Cannon br...@python.org:
--
resolution: out of date - wont fix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2345
___
___
Brett Cannon br...@python.org added the comment:
Is this still worth doing, Georg? Or should we make Larry do it? =)
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4011
___
Changes by Brett Cannon br...@python.org:
--
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11207
___
___
Python-bugs-list
Brett Cannon br...@python.org added the comment:
Closing since 2.7 is already out the door.
--
resolution: - wont fix
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2876
Brett Cannon br...@python.org added the comment:
Never heard back from OP.
--
resolution: - works for me
status: pending - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14070
___
New submission from Vincent Pelletier plr.vinc...@gmail.com:
When storing a ctype function pointer in a ctype structure field, a reference
remains even when that field is overwritten with some values:
- None
- None cast into a function pointer
But the reference is somehow removed when
Éric Araujo mer...@netwok.org added the comment:
Maybe there is a section in the documentation that could be enhanced to make
readers expect this behavior? (reference for list or tutorial)
--
nosy: +eric.araujo
title: list.startswith() and list.remove() fails to catch consecutive
Vincent Pelletier plr.vinc...@gmail.com added the comment:
Trying to generate a graph on several python and several uncommented lines, I
see that my test case is incomplete. Time to review my copy.
--
resolution: - invalid
status: open - closed
___
Éric Araujo mer...@netwok.org added the comment:
Attached patch does the trick. (Also removes extra whitespace in three lines
and groups the ignored names by topic for ease of reading.)
No test fails before or after the patch; there are some pydoc tests that check
full text or HTML output,
Éric Araujo mer...@netwok.org added the comment:
This strikes me as a bugfix that does not get backported because code might
depend on
the bug. If the policy for exception messages, such as it is, documented
somewhere?
I don’t know if it’s written anywhere, but the rule I follow is that
Antoine Pitrou pit...@free.fr added the comment:
Looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15163
___
___
Python-bugs-list
Changes by Jesús Cea Avión j...@jcea.es:
--
nosy: +jcea
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15240
___
___
Python-bugs-list mailing list
Antoine Pitrou pit...@free.fr added the comment:
If the policy for exception messages, such as it is, documented
somewhere?
I think we are quite free to change exception messages, as long as the change
is motivated. They are not part of the API definitions, and people shouldn't
rely on them
Éric Araujo mer...@netwok.org added the comment:
Patch looks good. Left some comments on Rietveld and +1 to Antoine’s note
about quotes :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15180
Éric Araujo mer...@netwok.org added the comment:
As I said in the other bug, symlinks handling in not fully specified: some
functions (like copy_file and copy_tree) have arguments to control
copy/link/symlink, but the higher-level commands don’t expose that choice to
the user. At present I
Éric Araujo mer...@netwok.org added the comment:
AFAICT using hard links only serves to save up a little time and disk space; it
seems to me that always copying would solve one or two bugs at a small cost
(not so small for large projects, I don’t know). Could this impact setup
scripts?
Éric Araujo mer...@netwok.org added the comment:
(Hm OK “del os.link” is definitely a hack :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15205
___
Éric Araujo mer...@netwok.org added the comment:
Of course the conservative fix would be to try linking as of now and do a copy
when an exception is caught, as was proposed.
FTR python.org link to the thread mentioned:
http://mail.python.org/pipermail/distutils-sig/2005-August/004954.html
Éric Araujo mer...@netwok.org added the comment:
samtygier’s patch to implement the fallback-to-copy idea looks good. Not sure
if an automated test would be written, but samtygier says it was manually
tested.
--
components: -Distutils2
keywords: +needs review
stage: needs patch -
Éric Araujo mer...@netwok.org added the comment:
Suggest closing or marking “remind” and see if people use / request /
reimplement SimpleNamespace.
--
versions: +Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
Changes by Éric Araujo mer...@netwok.org:
--
keywords: +easy
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15033
___
___
Éric Araujo mer...@netwok.org added the comment:
Any opposition?
--
nosy: +benjamin.peterson, georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15020
___
Éric Araujo mer...@netwok.org added the comment:
Joshua: what command did you run under strace?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15020
___
Marc Abramowitz msabr...@gmail.com added the comment:
Hi Brett, can I get an ack in Misc/ACKS please (to make my Mom proud :-))?
Attaching patch.
--
Added file: http://bugs.python.org/file26236/Misc_ACKS.patch
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
Thanks for the report and patch. Would you mind turning it into a patch for
the CPython 2.7 repository, with a unit test? Guidelines are in the devguide;
if you don’t have the time I’ll take it over.
--
stage: - test needed
Changes by Éric Araujo mer...@netwok.org:
--
stage: - needs patch
type: - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13943
___
___
Éric Araujo mer...@netwok.org added the comment:
One small thing: this comment from import.c was not copied to sysmodule.c and
is now deleted:
- TAG must change for each major Python release. The magic number will take
- care of any bytecode changes that occur during development.
Antoine Pitrou pit...@free.fr added the comment:
This sounds reasonable. Is there any reason that this change might be
detrimental?
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15020
Antoine Pitrou pit...@free.fr added the comment:
AFAICT using hard links only serves to save up a little time and disk
space; it seems to me that always copying would solve one or two bugs
at a small cost
I agree with this.
--
___
Python tracker
Raymond Hettinger raymond.hettin...@gmail.com added the comment:
The patch wording is fine. However, I would avoid the note markup. It is
visually distracting and there isn't a reason to pull this out of the main text.
--
___
Python tracker
Martin v. Löwis mar...@v.loewis.de added the comment:
Marc, can you please submit a contributor form?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15030
___
Éric Araujo mer...@netwok.org added the comment:
The disadvantage of graft is that by default it commits before you can run
tests. Recommending to run “graft --edit” would help (as long as you don’t
close your editor you can go to the repo in another shell).
--
Éric Araujo mer...@netwok.org added the comment:
Hi Jeroen, thanks for the report. Did you run into this while building a
distribution or did you find it just reading the code? Distutils is in a
special state where we only fix bugs but don’t do any improvement for the sake
of improvements,
Eric Snow ericsnowcurren...@gmail.com added the comment:
Good catch. However, do we need that comment? The tag is programmatically
derived from the version (in Python/sysmodule.c).
--
___
Python tracker rep...@bugs.python.org
Marc Abramowitz msabr...@gmail.com added the comment:
Hi Martin,
I already did. See http://bugs.python.org/msg164162 and
http://bugs.python.org/msg164164. Maybe it's not on file yet?
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Ah, good, if it’s automatically derived then we don’t need the comment.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15166
___
Terry J. Reedy tjre...@udel.edu added the comment:
This is definitely a motivated change ;-). I would like this re-typed as
behavior and applied to 2.7, 3.2, and 3.3. I see the current message as being
much like a garbled sentence in the docs that people can only understand if
they already
Changes by Axel Wegen axel.we...@googlemail.com:
--
nosy: +Axel.Wegen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13498
___
___
Python-bugs-list
Changes by Axel Wegen axel.we...@googlemail.com:
--
nosy: +Axel.Wegen
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12716
___
___
Python-bugs-list
Changes by Éric Araujo mer...@netwok.org:
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4011
___
___
Python-bugs-list
New submission from Éric Araujo mer...@netwok.org:
I did not find any doc or test for the behavior of the interpreter in virtual
mode, only for venv and pyvenv.
A new paragraph in site.py exists, but it’s missing from site.rst, contains
what I think is an error (saying that sys.prefix is
Patrick Andrew pand...@isilon.com added the comment:
Sure, I'll have that for you shortly.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14978
___
Changes by moijes12 moije...@gmail.com:
--
nosy: +moijes12
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1660009
___
___
Python-bugs-list mailing
Éric Araujo mer...@netwok.org added the comment:
Closing as duplicate. I have new tests for resolve_name (need to port them
from p7g to d2 and upload a patch); if your patch makes them pass or if it can
be merged with another patch that fixes the function, it’s easier to have all
on one
Changes by Éric Araujo mer...@netwok.org:
Removed file: http://bugs.python.org/file25773/resolve_name.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14964
___
Changes by moijes12 moije...@gmail.com:
--
nosy: +moijes12
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11664
___
___
Python-bugs-list mailing
Changes by Éric Araujo mer...@netwok.org:
Added file: http://bugs.python.org/file25773/resolve_name.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14964
___
Éric Araujo mer...@netwok.org added the comment:
http://bugs.python.org/file25773/resolve_name.patch is a patch that cleans up
the function; I’ll see if it can be used to solve our problems without having
to follow my drastic find_object idea.
--
Éric Araujo mer...@netwok.org added the comment:
BTW modules in the standard library all use the dotted notation AFAIK, not the
colon notation, so I would strongly prefer avoiding the colon notation.
--
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
Please keep the discussion in one place, the other bug report.
--
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14967
Éric Araujo mer...@netwok.org added the comment:
Did a first review on Rietveld, but I see that the patch may be outdated (it
had no tests).
--
versions: +3rd party, Python 3.4 -Python 3.3
___
Python tracker rep...@bugs.python.org
Éric Araujo mer...@netwok.org added the comment:
SilentGhost, could you submit a contributor agreement to the PSF for your
patches? See http://www.python.org/psf/contrib/ . Thanks.
--
___
Python tracker rep...@bugs.python.org
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset a56cebff113a by Éric Araujo in branch '2.7':
Ignore .nfs* files in distutils (#7719).
http://hg.python.org/cpython/rev/a56cebff113a
--
nosy: +python-dev
___
Python
Glenn Linderman v+pyt...@g.nevcal.com added the comment:
For the win_console.patch, it seems like adding the line
self.errors='strict'
inside UnicodeOutput.__init__ resolves the problem with input causing
exceptions.
Not sure if the sys_write_stdout.patch has the same sort of problem. Sure
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset f833e7ec4de1 by Éric Araujo in branch '2.7':
Create ~/.pypirc securely (#13512).
http://hg.python.org/cpython/rev/f833e7ec4de1
--
nosy: +python-dev
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
Reopening for d2. According to our rules a unit test would be required, but if
we don’t have machinery to test upload already in place then I would just
commit it; we definitely want to have automated tests for all commands, but it
needn’t
Larry Hastings la...@hastings.org added the comment:
What's the urge to make parameters keyword-only?
I suggest that boolean parameters are best made keyword-only. Otherwise you
have mystery meat like
shutil.copyfile(src, dst, True)
Also, all the extant uses of follow_symlinks in os are
Éric Araujo mer...@netwok.org added the comment:
Will port to 3.2 soon.
Release managers: there are CVE and ocert numbers for this; do we take that as
indication that it should be fixed in security releases too or do we stand by
our own assessment that it’s just a bugfix?
--
Larry Hastings la...@hastings.org added the comment:
Note: I don't have Macs, so I can't run OmniGiraffe. And a quick gander at the
Graphviz website suggests its output lacks the sublime elegance Python
documentation has become known for.
--
___
Terry J. Reedy tjre...@udel.edu added the comment:
3.3b0, Win7, 64 bit. Original test script stops at
File C:\Programs\Python33\lib\encodings\cp437.py, line 19, in encode
return codecs.charmap_encode(input,self.errors,encoding_map)[0]
UnicodeEncodeError: 'charmap' codec can't encode character
87 matches
Mail list logo
