Gregory P. Smith added the comment:
something to include in your statistics is the lengths of the already hashed
data being compared.
i expect there to be a minimum length before this optimization is useful.
--
nosy: +gregory.p.smith
___
Python
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16278
___
___
Python-bugs-list
New submission from Ned Deily:
The Developer's Guide needs to be updated to reflect the release of 3.3.
Primarily, this involves adding the 3.3 branch and updating the sequence of
branch names and other release number references. The attached patch does so.
It's pretty much a
Serhiy Storchaka added the comment:
I can reproduce this on Linux (3.3+ only):
$ name=$(printf \xff)
$ echo print('Hello, world') $name
$ ./python $name
python: failed to set __main__.__loader__
The issue is in PyRun_SimpleFileExFlags() function, which gets raw char * as
the file name (the
Serhiy Storchaka added the comment:
Here is a patch which fixes filename decoding error in
PyRun_SimpleFileExFlags().
--
keywords: +patch
Added file: http://bugs.python.org/file27630/pythonrun_filename_decoding.patch
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Library (Lib)
nosy: +larry, serhiy.storchaka
versions: +Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15872
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +3.3regression
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15872
___
___
Serhiy Storchaka added the comment:
In a normal loop we copy into the output buffer for each iteration the element
and the separator. As you know, the processor can copy large amounts of data
several times more efficiently than byte-for-byte. Therefore, filling the
buffer by memset more
STINNER Victor added the comment:
The patch looks correct, but a test is missing.
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16218
___
Michele Orrù added the comment:
The patch should not unconditionally use `python2` since many distributions
do not yet install a `python2` link
to the interpreter nor is there one when running python2.7 from a build
directory. The Makefile could
conditionally try `python2` and then
Antoine Pitrou added the comment:
Ok, but does it really make a difference and in which cases?
In other words, do you have benchmark numbers? :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12805
New submission from Mark Dickinson:
See thread starting at
http://mail.python.org/pipermail/python-dev/2012-October/122241.html
The cmath module functions don't accept custom types that define __complex__,
but whose __complex__ method returns a float rather than a complex number:
Python
Mark Dickinson added the comment:
Here's a patch
--
keywords: +patch
Added file: http://bugs.python.org/file27631/issue16290.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16290
___
Changes by Ezio Melotti ezio.melo...@gmail.com:
--
nosy: +ezio.melotti
stage: - test needed
type: crash - behavior
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16218
___
Ezio Melotti added the comment:
LGTM
--
type: - enhancement
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16289
___
___
Python-bugs-list mailing
Serhiy Storchaka added the comment:
Where we have tests for Python launch? I can't find. runpy is not affected.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16218
___
Serhiy Storchaka added the comment:
Here is a tests for most of fixed overflows. Some errors are difficult or
impossible to reproduce.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15989
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file27632/long_aslong_overflow_tests.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15989
___
Serhiy Storchaka added the comment:
Patch LGTM.
Is there a new feature, not a bugfix? If yes, then I expect some documentation
changes.
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16290
Giampaolo Rodola' added the comment:
+self.assertEqual(shutil.rmtree(os.path.join(tmpdir, tstfile),
+ ignore_errors=True), None)
I wouldn't use assertEqual as the return value is not meaningful.
--
nosy: +giampaolo.rodola
Mark Dickinson added the comment:
Is there a new feature, not a bugfix?
There's an ongoing argument about that on the python-dev thread. :-) But yes,
I think this needs a doc update---even if it's considered a bugfix, the current
docs could be clarified.
Djoume Salvetti added the comment:
This patch introduces a slight change in behaviour.
Now compilation will only happen if there is a difference in the number of
seconds in the timestamp of files, before this patch any difference in mtime
will trigger a rebuild. This is because the timestamp
Mark Dickinson added the comment:
A new patch (with tests), and a fuller explanation:
At work, we've got Python talking to a customer's existing COM library; we're
using Thomas Heller's 'comtypes' library to do that. Unfortunately, comtypes
depends quite a lot on __del__-time cleanup, so
Changes by Mark Dickinson dicki...@gmail.com:
--
nosy: +jnoller, sbt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16284
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
My interpretation of that is that __int__ should return an int, __float__ a
float, __complex__ a complex number;
It's a reasonable interpretation. Changing it can be confusing.
On the other hand, int and float look like specialized subclasses of complex
Changes by Chris Mayo aklh...@gmail.com:
--
nosy: +cjmayo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2350
___
___
Python-bugs-list mailing list
Mark Dickinson added the comment:
This means that you should add a branch for integers too.
I'd rather not go that far, at least in this issue: we'd also end up changing
__float__ to allow it to return an int, in that case. If we're considering
that, the discussion should go back to
Changes by Mike Hoy mho...@gmail.com:
--
nosy: +mikehoy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16288
___
___
Python-bugs-list mailing list
Antoine Pitrou added the comment:
Sounds fine to me. You might want to make the test CPython-specific.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16284
___
Antoine Pitrou added the comment:
It doesn't sound very useful to mention both 3.2 and 3.3, since 3.2 maintenance
will soon stop.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16289
R. David Murray added the comment:
The special handling of special methods is baked into the attribute lookup
machinery. The discussion of this is in the language reference somewhere, as
is the explanation of what descriptors are and how they work.
--
type: - enhancement
Chris Jerdonek added the comment:
So the relevant code is this:
def getDescription(self, test):
...
43 return str(test)
...
What I'd like is to have this be something like:
44 return test.id()
Or anther way this could be done would be to make TestCase.__str__ call
self.id()
Note
Éric Araujo added the comment:
http://docs.python.org/reference/datamodel.html#special-method-lookup-for-new-style-classes
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16288
Éric Araujo added the comment:
NotADirectoryError not being caught makes sense to me: not passing a directory
as argument to rmtree is a programmer error, not something coming from the OS
or filesystem.
--
nosy: +eric.araujo, pitrou
___
Python
Antoine Pitrou added the comment:
To be honest I don't really understand the point of the ignore_errors flag on
rmtree. If rmtree fails to delete the directory tree (which will happen if one
of the files can't be deleted), why would you want it to return succesfully?
--
nosy: +hynek
Serhiy Storchaka added the comment:
Ok, but does it really make a difference and in which cases?
Up to 40% on Athlon and up to 70% on Atom.
In other words, do you have benchmark numbers? :)
Attached results for AMD Athlon 64 X2 4600+ and Intel Atom N570 @ 1.66GHz
under 32-bit Linux. You
Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10888
___
___
Serhiy Storchaka added the comment:
Now shutil.rmtree has different behavior when called for non-directory on
systems with and without at-functions.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15872
Serhiy Storchaka added the comment:
If rmtree fails to delete the directory tree (which will happen if one of the
files can't be deleted), why would you want it to return succesfully?
At least it free some disk space. ;-)
--
___
Python tracker
Hynek Schlawack added the comment:
To be honest I don't really understand the point of the ignore_errors flag on
rmtree. If rmtree fails to delete the directory tree (which will happen if
one of the files can't be deleted), why would you want it to return
succesfully?
I presume it’s
Antoine Pitrou added the comment:
Ok, here are the benchmark results here with a 1-byte separator:
10 x 10 0.244 usec 0.202 usec +21%
100 x 10 0.325 usec 0.326 usec-0%
1000 x 10 0.691 usec 0.689 usec+0%
10 x 1000 18.2 usec14.2 usec +28%
100 x
Serhiy Storchaka added the comment:
Indeed, 1-char separator is more common for strings, but I found several
b'\n'.join or b','.join even in stdlib. 3 lines of difference are only 2.3% of
Objects/stringlib/join.h.
Here is a patch with dropped the 1-byte separator case.
--
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file27636/bytes_join_optimization_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12805
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file25857/encode-utf32.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15027
___
Serhiy Storchaka added the comment:
Patch updated to 3.4.
Is anyone interested in 7x speedup of UTF-32 encoder?
--
keywords: +needs review
versions: +Python 3.4 -Python 3.3
Added file: http://bugs.python.org/file27637/encode_utf32_2.patch
___
Python
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file25278/decode_utf32_a.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14625
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file25279/decode_utf32_b.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14625
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file25537/decode_utf32_a_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14625
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file25538/decode_utf32_b_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14625
___
Serhiy Storchaka added the comment:
Patches updated to 3.4.
--
keywords: +needs review
versions: +Python 3.4 -Python 3.3
Added file: http://bugs.python.org/file27638/decode_utf32_a_3.patch
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +3.3regression
Added file: http://bugs.python.org/file27639/decode_utf32_b_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14625
Serhiy Storchaka added the comment:
I suggest apply patch A to 3.3 as it fixes performance regression (2x) and is
very simple.
--
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14625
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14625
___
___
Georg Brandl added the comment:
Very simple? You're changing most of the code there.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14625
___
Serhiy Storchaka added the comment:
It was too complicated code. Actually patched code is smaller.
1 file changed, 71 insertions(+), 80 deletions(-)
UTF-16 codec was modified in some way.
--
___
Python tracker rep...@bugs.python.org
Changes by Serhiy Storchaka storch...@gmail.com:
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15186
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
keywords: +needs review
stage: test needed -
versions: +Python 3.4 -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1470548
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
Removed message: http://bugs.python.org/msg162876
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1598083
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: -serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1598083
___
___
Georg Brandl added the comment:
That the new code is smaller is no guarantee that it's as correct :)
That is exactly the reason we don't put optimizations in bugfix releases.
--
___
Python tracker rep...@bugs.python.org
Todd Rovito added the comment:
David,
Thanks for your bug report. Indeed os.rename does not exhibit the same
behavior as the documentation describes.
For Python 3.4 here is the fix I came up with:
Rename the file or directory src to dst. If dst is a directory that is not
empty, OSError
Roundup Robot added the comment:
New changeset c0a423ce4b96 by Ned Deily in branch '2.7':
Issue #10405: Document IDLE context menus in Standard Library document
http://hg.python.org/cpython/rev/c0a423ce4b96
New changeset 566b7574becb by Ned Deily in branch '3.2':
Issue #10405: Document IDLE
Ned Deily added the comment:
Thanks for your suggestions, Nick and Todd. While reviewing them, I realized
that there is also a small context (right-click) menu for the IDLE shell window
as well. I expanded the doc changes to include it and included several other
minor doc updates. I also
Serhiy Storchaka added the comment:
I understand you, it's a patch against 2.7.
+def readline(self, size=-1):
In io.IOBase.readline() and in io.TextIOBase.readline() this parameter named
limit.
+if size is not None and len(str) == size:
+break
It
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: test needed - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16013
___
Roundup Robot added the comment:
New changeset 2f682e133960 by Ned Deily in branch 'default':
Issue #16289: Update Developer's Guide for the 3.4 development cycle.
http://hg.python.org/devguide/rev/2f682e133960
--
nosy: +python-dev
___
Python tracker
Ned Deily added the comment:
Antoine, I think if possible it is best to always have the devguide reflect the
current process. Once 3.2 moves to security mode, it is a trivial process to
update devguide again (no release involved!).
--
resolution: - fixed
stage: patch review -
Roundup Robot added the comment:
New changeset bfa715f98c0f by Antoine Pitrou in branch 'default':
Issue #12805: Make bytes.join and bytearray.join faster when the separator is
empty.
http://hg.python.org/cpython/rev/bfa715f98c0f
--
nosy: +python-dev
Antoine Pitrou added the comment:
I have committed the simple optimization patch, thank you!
--
resolution: - fixed
stage: - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12805
John O'Connor added the comment:
I think that's a good compromise and much better than what I had originally.
- John
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12805
___
Silverback Networks added the comment:
Same errors in 3.3. Some names are decorated, some aren't, seemingly at random.
For instance, python32.lib contains:
35B20 _PyObject_Dump
35B20 __imp__PyObject_Dump
and just below that,
2924A PyObject_Free
2924A __imp_PyObject_Free
But
Changes by Silverback Networks silverback...@gmail.com:
--
versions: +Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15772
___
___
New submission from Ray Donnelly:
I've fixed up the very few missing configure bits and one issue with
PYTHON_FOR_BUILD using srcdir instead of builddir. I also rolled in a simple
warning fix that I ran into (the #ifdef HAVE_CHROOT added to posixmodule.c)
configured with:
$srcdir/configure
Serhiy Storchaka added the comment:
I analyzed all 1-valued usages of Py_BuildValue and found similar bags only in
Modules/_sre.h. Here is a patch.
Bugs should be evident on big-endian platform with sizeof(int) sizeof(size_t)
or sizeof(long) sizeof(size_t). Standard tests should fail on
Changes by Serhiy Storchaka storch...@gmail.com:
--
components: +Regular Expressions
nosy: +ezio.melotti, mrabarnett
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10182
___
Ned Deily added the comment:
I'm curious as to what value there would be in adding support for cross
building an OS X variant of Python on Linux. It seems to me that such an
animal would be fragile and incomplete at best. For example, normal Python
builds on OS X normally require certain OS
New submission from Ray Donnelly:
This patch fixes 2 cross compilation bugs and improves a comment.
--
components: Cross-Build
files: 0005-cross-fixes.patch
keywords: patch
messages: 173423
nosy: Ray.Donnelly, doko
priority: normal
severity: normal
status: open
title: Cross compilation
Ray Donnelly added the comment:
It seems to me that such an animal would be fragile and incomplete at best.
There's no reason for it to be either fragile or incomplete. My cross builds
have a goal of being comprehensive.
Python builds on OS X normally require certain OS X frameworks outside
Changes by Ray Donnelly mingw.andr...@gmail.com:
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16292
___
___
Python-bugs-list
New submission from Julian Berman:
The following code now raises an OverflowError on 3.3:
import curses
def test_screen(screen):
screen.nodelay(True)
key = screen.getch()
screen.nodelay(False)
curses.ungetch(key)
curses.wrapper(test_screen)
or equivalently just
def
Jeff McNeil added the comment:
Yeah clearly the wrong behavior on Winders.
I think that moving to 'normpath' instead of 'normcase' is likely the right
thing to do. Patch is attached, so if someone with commit powers could review
real quick I'll address whatever needs to be addressed.
IMHO,
Changes by Todd Rovito rovit...@gmail.com:
Removed file:
http://bugs.python.org/file27615/RightClickContextMenuUpdatedFor3point4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1207589
___
Changes by Todd Rovito rovit...@gmail.com:
Removed file:
http://bugs.python.org/file27616/RightClickContextMenuUpdatedFor2point7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1207589
___
Todd Rovito added the comment:
Same patch as before but updated the documentation and help.txt file for IDLE.
This is for Python 2.7.
--
Added file:
http://bugs.python.org/file27644/RightClickContextMenuUpdatedWithDocs2point7.patch
___
Python
Todd Rovito added the comment:
Same patch as before but updated the documentation and help.txt file for IDLE.
This is for Python 3.4.
--
Added file:
http://bugs.python.org/file27645/RightClickContextMenuUpdatedWithDocs3point4.patch
___
Python
Kevin Chen added the comment:
Hi Nick,
Thank you so much for rolling out this change. I think your implementation of
the fix is more elegant. I have learned a few things from you.
I would love to keep helping to test/fix bugs for Python on Windows. Please
contact me if there is anything you
Nick Coghlan added the comment:
No worries. If you could do a fresh build of the 2.7 branch and confirm this
fix works for you, that would be great.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6074
Changes by R. David Murray rdmur...@bitdance.com:
--
components: +email
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16042
___
___
Changes by Ramchandra Apte maniandra...@gmail.com:
--
status: pending - open
title: impove 27 percent performance on stringpbject.c( by prefetch and loop
optimization) - improve 27 percent performance on stringpbject.c (by prefetch
and loop optimization)
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15869
___
___
Python-bugs-list
Changes by Todd Rovito rovit...@gmail.com:
--
nosy: +Todd.Rovito
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15392
___
___
Python-bugs-list
91 matches
Mail list logo
