[issue17044] Implement PEP 422: Simple class initialisation hook

2013-01-26 Thread Daniel Urban
Daniel Urban added the comment: Thanks for the review Ezio! I've fixed the order of the arguments of assertEqual. Regarding your other comment: I agree that your code is shorter and clearer, but it doesn't do exactly the same thing. cls.__init_class__ can be None, and in that case, we should

[issue17046] test_subprocess test_executable_without_cwd fails when run with installed python

2013-01-26 Thread Ned Deily
New submission from Ned Deily: ./configure --enable-shared --with-pydebug --prefix=/py/root && make && make install cd export LD_LIBRARY_PATH=/py/root/lib /py/root/bin/python3.4 -m test -w -uall,-largefile test_subprocess == F

[issue7576] Avoid warnings in PyModuleDef_HEAD_INIT

2013-01-26 Thread Stefan Behnel
Stefan Behnel added the comment: This is a duplicate of issue 9518 (or the other way round) and should be closed as fixed in 3.2. -- components: +Extension Modules nosy: +scoder ___ Python tracker _

[issue13997] Clearly explain the bare minimum Python 3 users should know about Unicode

2013-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: Current status: #14015 is still valid (i.e. surrogateescape is not well documented) #4153: the Unicode HOWTO still covers more than the bare minimum people need to know Ned Batchelder's "Pragmatic Unicode" is one of the best intros to the topic I have seen: http

[issue3871] cross and native build of python for mingw* hosts

2013-01-26 Thread Luke Kenneth Casson Leighton
Luke Kenneth Casson Leighton added the comment: the last time this was brought up on python-dev the opinions of the primary python developers was made very very clear: anything that is not written by them is treated with extreme hostile and predudicial contempt. what i mean by that is that the

[issue1777134] minidom pretty xml output improvement

2013-01-26 Thread Ezio Melotti
Ezio Melotti added the comment: I think this can be closed, since #4147 already improved tpprettyxml(). -- nosy: +ezio.melotti resolution: -> out of date stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue1778410] removeTest() method patch for unittest.TestSuite

2013-01-26 Thread Ezio Melotti
Ezio Melotti added the comment: Michael, what's the situation now? -- nosy: +ezio.melotti versions: +Python 3.4 -Python 3.2 ___ Python tracker ___ _

[issue1681974] mkdtemp fails on Windows if username has non-ASCII character

2013-01-26 Thread Ezio Melotti
Ezio Melotti added the comment: On Win 7 with a non-ASCII username, this seems to work fine on both 2.7 and 3.3. 2.7 returns str or unicode depending on the type of the "prefix=", whereas 3.3 only accepts str (I think this is expected). I'm going to close this as out of date, feel free to reo

[issue4153] Unicode HOWTO up to date?

2013-01-26 Thread Nick Coghlan
Nick Coghlan added the comment: The section in the HOWTO on Python's unicode support also misses the fact that the easiest way to include a Unicode character in a string literal in Python 3 is to *include that character in the string literal* (since source code is now treated as UTF-8 by defau

[issue16487] Allow ssl certificates to be specified from memory rather than files.

2013-01-26 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Manually edited the .patch file The build changes are gone but should probably go in separately in some form later. -- Added file: http://bugs.python.org/file28866/sslpatch2.patch ___ Python tracker

[issue16487] Allow ssl certificates to be specified from memory rather than files.

2013-01-26 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: I wasn't pushing it anymore because there seemed to be no interest and Antoine attitude made me lose interest in contributing this. No one liked to comment on my approach except Antoine and I had grown tired of his persistent negativity and aloof mann

[issue4153] Unicode HOWTO up to date?

2013-01-26 Thread Chris Rebert
Changes by Chris Rebert : -- nosy: +cvrebert ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue14018] OS X installer does not detect bad symlinks created by Xcode 3.2.6

2013-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 49294e55311f by Ned Deily in branch '2.7': Issue #14018: fix merge error http://hg.python.org/cpython/rev/49294e55311f New changeset 58646b0c5226 by Ned Deily in branch '3.2': Issue #14018: fix merge error http://hg.python.org/cpython/rev/58646b0c52

[issue16487] Allow ssl certificates to be specified from memory rather than files.

2013-01-26 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Kristján, are you pursuing this yet?. Can we move on? -- nosy: +jcea title: Allow ssl certificates to be speficfied from memory rather than files. -> Allow ssl certificates to be specified from memory rather than files. ___

[issue17045] Improve C-API doc for PyTypeObject

2013-01-26 Thread Eric Snow
Changes by Eric Snow : Removed file: http://bugs.python.org/file28864/typeobj-doc.diff ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue17045] Improve C-API doc for PyTypeObject

2013-01-26 Thread Eric Snow
Eric Snow added the comment: Here's an updated patch after feedback. Thanks Ezio! -- Added file: http://bugs.python.org/file28865/typeobj-doc.diff ___ Python tracker ___ ___

[issue16485] FD leaks in aifc module

2013-01-26 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16486] Add context manager support to aifc module

2013-01-26 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue16488] Add context manager support to epoll object

2013-01-26 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13886] readline-related test_builtin failure

2013-01-26 Thread Ezio Melotti
Ezio Melotti added the comment: This problem still exists on 3.4. The attached patch seems to solve it. -- nosy: +ezio.melotti versions: +Python 3.4 ___ Python tracker ___ __

[issue17005] Add a topological sort algorithm

2013-01-26 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- nosy: +terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue14017] Make it easy to create a new TextIOWrapper based on an existing

2013-01-26 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +pitrou stage: -> needs patch type: -> enhancement versions: +Python 3.4 -Python 3.3 ___ Python tracker ___ _

[issue8144] muliprocessing shutdown infinite loop

2013-01-26 Thread Ezio Melotti
Ezio Melotti added the comment: Can you still reproduce the issue? -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list m

[issue1479255] Fix building with SWIG's -c++ option set in setup.py

2013-01-26 Thread Ezio Melotti
Changes by Ezio Melotti : -- keywords: +easy stage: needs patch -> test needed versions: +Python 3.3, Python 3.4 -Python 3.1 ___ Python tracker ___

[issue4972] context managerment support in imaplib, smtplib, ftplib

2013-01-26 Thread Ezio Melotti
Ezio Melotti added the comment: ftplib.FTP and smtplib.SMTP support the "with" statement since 3.2 and 3.3 respectively. imaplib seems to be the only one left. Can someone review and commit the patch for 3.4? -- stage: needs patch -> patch review versions: +Python 3.4 -Python 3.2, Pytho

[issue17037] Use a test.support helper to wrap the PEP 399 boilerplate

2013-01-26 Thread Eric Snow
Eric Snow added the comment: > I think something similar has already been proposed and rejected on another > issue. Wouldn't surprise me. I'll look for it. I know there's been a bunch of traffic relative to PEP 399 and to test discovery, so I'm guessing I missed it in there. Thanks for the

[issue13997] Clearly explain the bare minimum Python 3 users should know about Unicode

2013-01-26 Thread Ezio Melotti
Ezio Melotti added the comment: What's the status of this? Issue #4153 might also be related. -- ___ Python tracker ___ ___ Python-bu

[issue16817] test___all__ affects other tests by doing too much importing

2013-01-26 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue17037] Use a test.support helper to wrap the PEP 399 boilerplate

2013-01-26 Thread Ezio Melotti
Ezio Melotti added the comment: I think something similar has already been proposed and rejected on another issue. -- nosy: +ezio.melotti ___ Python tracker ___

[issue17037] Use a test.support helper to wrap the PEP 399 boilerplate

2013-01-26 Thread Eric Snow
Eric Snow added the comment: (changing the title to disassociate it from a particular solution) >> * make sure the original test case does not get used (#16835), > > PEP 399 dictates that the base class does not inherit from > unittest.TestCase, so why would it be used? Sorry for any confusion.

[issue17045] Improve C-API doc for PyTypeObject

2013-01-26 Thread Ezio Melotti
Changes by Ezio Melotti : -- assignee: -> docs@python components: +Documentation nosy: +docs@python, ezio.melotti stage: -> patch review type: -> enhancement versions: +Python 3.3, Python 3.4 ___ Python tracker

[issue5289] ctypes.util.find_library does not work under Solaris

2013-01-26 Thread Skip Montanaro
Skip Montanaro added the comment: Is there still time to get this bug fixed in 2.7.3? I patched my 2.7 ctypes/util.py with the latest version (offset a few lines, but no other problems) and verified that it seems to fix the issue. When running util.py as a main program I see this before runni

[issue17042] Example in C-API memory management doc has confusing order

2013-01-26 Thread Eric Snow
Eric Snow added the comment: Sorry, I'd meant something like this: char *buf1 = PyMem_New(char, BUFSIZ); char *buf2 = (char *) malloc(BUFSIZ); char *buf3 = (char *) PyMem_Malloc(BUFSIZ); ... /* in reverse order */ PyMem_Del(buf3); /* Wron

[issue17045] Improve C-API doc for PyTypeObject

2013-01-26 Thread Eric Snow
New submission from Eric Snow: http://docs.python.org/dev/c-api/typeobj.html I found the the documentation for PyTypeObject to be somewhat harder to use than it need be. In the end I distilled the info down for my own use. I'm comfortable with what I came up with, so I'd like to at least add

[issue17042] Example in C-API memory management doc has confusing order

2013-01-26 Thread Stefan Krah
Stefan Krah added the comment: Moderately opposed, yes. PyMem_Malloc()/PyMem_Free() and PyMem_New()/PyMem_Del() are already explained in depth above. -- ___ Python tracker ___ __

[issue10156] Initialization of globals in unicodeobject.c

2013-01-26 Thread Stefan Krah
Changes by Stefan Krah : -- resolution: -> fixed stage: patch review -> committed/rejected ___ Python tracker ___ ___ Python-bugs-lis

[issue10156] Initialization of globals in unicodeobject.c

2013-01-26 Thread Stefan Krah
Changes by Stefan Krah : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue10156] Initialization of globals in unicodeobject.c

2013-01-26 Thread Stefan Krah
Stefan Krah added the comment: Buildbots etc. look all good. Thanks for fixing this. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue16468] argparse only supports iterable choices

2013-01-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: > the choice part of the error message (passed to ArgumentError) will just be > 'invalid choice: '. That's right. With the patch it looks like this: >>> p = argparse.ArgumentParser(prog='test.py') >>> p.add_argument('--foo', choices=c) >>> p.parse_args(['--fo

[issue17042] Example in C-API memory management doc has confusing order

2013-01-26 Thread Eric Snow
Eric Snow added the comment: Thanks for clarifying, Stefan. Are you opposed to a comment in the example? -- ___ Python tracker ___ __

[issue17041] Fix tests for build --without-doc-strings

2013-01-26 Thread Stefan Krah
Stefan Krah added the comment: I left some comments but have no indication that they got mailed. -- ___ Python tracker ___ ___ Python-

[issue17041] Fix tests for build --without-doc-strings

2013-01-26 Thread Stefan Krah
Stefan Krah added the comment: The patches are really small, so +1 for committing this before the rc1 for 2.7.4 is released. -- ___ Python tracker ___ ___

[issue17043] Invalid read in test_codecs

2013-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- components: +Interpreter Core, Unicode nosy: +ezio.melotti stage: -> patch review type: -> behavior versions: +Python 2.7, Python 3.2, Python 3.4 ___ Python tracker __

[issue17043] Invalid read in test_codecs

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here are patches for all 4 versions. -- keywords: +patch Added file: http://bugs.python.org/file28860/decodeunicodeinternal_overflow-2.7.patch Added file: http://bugs.python.org/file28861/decodeunicodeinternal_overflow-3.2.patch Added file: http://b

[issue17037] Add conforms_to_pep399() to test.support

2013-01-26 Thread Eli Bendersky
Eli Bendersky added the comment: On Sat, Jan 26, 2013 at 9:10 AM, Eric Snow wrote: > > Eric Snow added the comment: > > In my case I've been doing PEP 399 for collections.OrderedDict. It struck > me that the boilerplate could be stowed away in a decorator. It's more > than just adding a coupl

[issue17044] Implement PEP 422: Simple class initialisation hook

2013-01-26 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue17044] Implement PEP 422: Simple class initialisation hook

2013-01-26 Thread Daniel Urban
New submission from Daniel Urban: The attached patch implements PEP 422 -- Simple class initialisation hook (__init_class__). It includes tests, but it doesn't include documentation yet. -- components: Interpreter Core, Library (Lib) files: pep422_1.patch keywords: needs review, patch m

[issue16770] Selection in IDLE often skips first character

2013-01-26 Thread Ned Deily
Ned Deily added the comment: OK, I *did* spend a little more time on this and am now able to reproduce the behavior solely running the following Tcl code with tclsh: package require Tk set w .text catch {destroy $w} toplevel $w text $w.text -setgrid 1 -height 30 -font "Courier 20" pack $w.text

[issue16903] subprocess.Popen.communicate with universal_newlines=True doesn't accept strings on 3.2

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch which adds support of strings in communicate(). It also contains a backported test from changeset 4af2c0687970 which tests this behavior. -- assignee: -> serhiy.storchaka keywords: +patch nosy: +asvetlov stage: needs patch -> patch r

[issue17043] Invalid read in test_codecs

2013-01-26 Thread Stefan Krah
Stefan Krah added the comment: Same in test_codeccallbacks: test_badhandlerresults (test.test_codeccallbacks.CodecCallbackTest) ... ==11604== Invalid read of size 1 ==11604==at 0x44AF37: _PyUnicode_DecodeUnicodeInternal (unicodeobject.c:6133) ==11604==by 0x4DEB5C: unicode_internal_deco

[issue16468] argparse only supports iterable choices

2013-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: I think we have converged on the right solution. The patch looks good as far as it goes, assuming that it passes the current + unwritten new tests. It will also be a good basis for reconsidering what to do with long/infinite iterables in #16418. I think the d

[issue17043] Invalid read in test_codecs

2013-01-26 Thread Stefan Krah
New submission from Stefan Krah: Found this in test_codecs running under Valgrind (Python 3.3): test_bug1251300 (test.test_codecs.UnicodeInternalTest) ... ==11511== Invalid read of size 1 ==11511==at 0x44AF37: _PyUnicode_DecodeUnicodeInternal (unicodeobject.c:6133) ==11511==by 0x4DEB5

[issue3871] cross and native build of python for mingw* hosts

2013-01-26 Thread Roumen Petrov
Roumen Petrov added the comment: As patch 0005-CROSS-revert-issue13150-i.e.-python-solution-with-_s.patch (CROSS-revert issue13150, i.e. python solution with _sysconfigdata.py instead Makefile) from issue3754 is now obsolete by issue 13547, 14774, 16342, 15298 it is save to switch sysconfig

[issue3871] cross and native build of python for mingw* hosts

2013-01-26 Thread Ray Donnelly
Ray Donnelly added the comment: Roumen, I think it would be really great if you could split py3k-20121004-MINGW.patch up into separate bits. The pthread stuff and libffi stuff being two obvious candidates for atomic parts. -- ___ Python tracker

[issue16723] io.TextIOWrapper on urllib.request.urlopen terminates prematurely

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch which fixes HTTPResponse's end. "closed" property no longer settled automatically, but only after explicit close(). -- components: +IO, Library (Lib) keywords: +patch nosy: +orsenthil stage: -> patch review versions: +Python 3.2, Pyth

[issue3871] cross and native build of python for mingw* hosts

2013-01-26 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: This discussion got very long and it's not clear (to me at least) what the status of the patch is and whether it has been accepted for inclusion. Maybe it makes sense to bring this up to python-dev mailing list instead of keep stressing this thread? ---

[issue3871] cross and native build of python for mingw* hosts

2013-01-26 Thread Roumen Petrov
Roumen Petrov added the comment: Matthias Klose wrote: > > Matthias Klose added the comment: > > some random comments about py3k-20121004-MINGW.patch: > > - Modules/_ctypes/libffi_msvc/win32.S >Please can you get rid of libffi_msvc and use libffi? >afaics, libffi has support for mingw32.

[issue3871] cross and native build of python for mingw* hosts

2013-01-26 Thread Ray Donnelly
Ray Donnelly added the comment: Re: basing the patches against the latest master branch or targeting released versions, I wasn't clear enough about my thinking. For sure, when trying to get any patches merged, the submitted patch must be re-based (forward ported) and tested against the master

[issue13896] Make shelf instances work with 'with' as context managers

2013-01-26 Thread Terry J. Reedy
Terry J. Reedy added the comment: The patch did not update the doc. See #17040, with proposed patch. -- ___ Python tracker ___ ___ Pyt

[issue3754] cross-compilation support for python build

2013-01-26 Thread Roumen Petrov
Roumen Petrov added the comment: Matthias Klose wrote: > > Matthias Klose added the comment: > about py3k-20121004-CROSS.tgz: >[SNIP] > - 0002-CROSS-restore-graminit.-to-source-directory.patch >[SNIP] > - 0003-CROSS-restore-importlib-header-to-source-directory-a.patch >[SNIP] > - 0004

[issue11204] re module: strange behaviour of space inside {m, n}

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Then let's leave all as is. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue16096] Get rid of dangerous integer overflow tricks

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I withdraw my patches for 2.7 and 3.2 due to the fact that they have no visible effect on supported platforms. Patches for 3.3+ already committed, therefore I  close this issue. -- resolution: -> fixed stage: -> committed/rejected status: open -> cl

[issue8821] Range check on unicode repr

2013-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue16802] fileno argument to socket.socket() undocumented

2013-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- keywords: +easy stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue17042] Example in C-API memory management doc has confusing order

2013-01-26 Thread Ezio Melotti
Changes by Ezio Melotti : -- resolution: -> rejected stage: needs patch -> committed/rejected status: open -> closed type: -> enhancement ___ Python tracker ___ ___

[issue17042] Example in C-API memory management doc has confusing order

2013-01-26 Thread Stefan Krah
Stefan Krah added the comment: Please don't change this: It's a common pattern in C to undo memory allocations in the opposite order. -- nosy: +skrah ___ Python tracker ___ _

[issue17042] Example in C-API memory management doc has confusing order

2013-01-26 Thread Eric Snow
New submission from Eric Snow: In http://docs.python.org/dev/c-api/memory.html#examples: char *buf1 = PyMem_New(char, BUFSIZ); char *buf2 = (char *) malloc(BUFSIZ); char *buf3 = (char *) PyMem_Malloc(BUFSIZ); ... PyMem_Del(buf3); /* Wrong

[issue8865] select.poll is not thread safe

2013-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: test needed -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue10905] zipfile: fix arcname with leading '///' or '..'

2013-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: -> committed/rejected status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list m

[issue8865] select.poll is not thread safe

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a test made from Charles-François's crasher. Let's go. -- Added file: http://bugs.python.org/file28855/issue8865_test.patch ___ Python tracker

[issue3871] cross and native build of python for mingw* hosts

2013-01-26 Thread Matthias Klose
Matthias Klose added the comment: > However, we must go further and add that the patches *cannot* break any > other native or cross-compilation, which - as I think Matthias is > alluding to - is probably not the case with your patch. This issue is > called "cross and native build of python for mi

[issue3871] cross and native build of python for mingw* hosts

2013-01-26 Thread Matthias Klose
Matthias Klose added the comment: > IMHO, updating these patches to track the latest Python is a pointless goal. sorry, no. it's the *only* way to get these patches upstream. The mingw patches will never see the light of the 3.3 branch. So the best thing to do is to actively submit the patches

[issue3718] environment variable MACHDEP and python build system

2013-01-26 Thread Matthias Klose
Matthias Klose added the comment: now checked in the configure change. I think that the cross-build documentation deserves an extra issue. Therefore now closing this issue. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___

[issue3718] environment variable MACHDEP and python build system

2013-01-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8c49dd8e4d22 by doko in branch '3.3': - Issue #3718: Use AC_ARG_VAR to set MACHDEP in configure.ac. http://hg.python.org/cpython/rev/8c49dd8e4d22 New changeset 6866384d9ccb by doko in branch 'default': - Issue #3718: Use AC_ARG_VAR to set MACHDEP in

[issue15483] CROSS: initialise include and library paths in setup.py

2013-01-26 Thread Roumen Petrov
Roumen Petrov added the comment: > Matthias Klose added the comment: > I don't think this one is still necessary. can it be closed? If is difficult to confirm. In scope of issue title initialization is fixed. Another part of proposed path is to insert at first position current directory if cro

[issue10740] sqlite3 module should allow DDL statements in transactions

2013-01-26 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue16991] Add OrderedDict written in C

2013-01-26 Thread Ezio Melotti
Ezio Melotti added the comment: These are indeed good reasons. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue3718] environment variable MACHDEP and python build system

2013-01-26 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- nosy: -gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue16968] Fix test discovery for test_concurrent_futures.py

2013-01-26 Thread Chris Jerdonek
Chris Jerdonek added the comment: Okay, I think I understand the issue better now. The threading._dangling warning happens because when leaving the saved_test_environment context manager in regrtest: http://hg.python.org/cpython/file/fcdb35b114ab/Lib/test/regrtest.py#l1271 the context manage

[issue17005] Add a topological sort algorithm

2013-01-26 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue16991] Add OrderedDict written in C

2013-01-26 Thread Eric Snow
Eric Snow added the comment: > What's the reason for moving the OrderedDict tests in a separate file? Following the precedent of collections.deque and collections.defaultdict: * a big chunk of code * the default implementation will be coming via _collections. -- __

[issue17003] Unification of read() and readline() argument names

2013-01-26 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue17041] Fix tests for build --without-doc-strings

2013-01-26 Thread Stefan Krah
Stefan Krah added the comment: Serhiy Storchaka wrote: > > It seems like it would make more sense to combine both checks into one > > decorator. > > These are different cases. @unittest.skipIf(sys.flags.optimize >= 2) is about > docstrings in Python implemented modules, and @support.requires_

[issue17037] Add conforms_to_pep399() to test.support

2013-01-26 Thread Eric Snow
Eric Snow added the comment: > Do you have a real use case for the 'names' argument? My use case was with the tests for OrderedDict. The existing tests don't refer to collections.OrderedDict, but rather to OrderedDict (looked up from the globals). The names argument facilitates the replaceme

[issue17037] Add conforms_to_pep399() to test.support

2013-01-26 Thread Eric Snow
Eric Snow added the comment: In my case I've been doing PEP 399 for collections.OrderedDict. It struck me that the boilerplate could be stowed away in a decorator. It's more than just adding a couple subclasses. Here's what it covers: * add the test case subclasses, * make sure the original

[issue3718] environment variable MACHDEP and python build system

2013-01-26 Thread Roumen Petrov
Roumen Petrov added the comment: Matthias Klose wrote: > > Matthias Klose added the comment: > > the change to the configure script looks ok. however you could change the > README too. This is 5 years old issue. README is not more in repository. As result python lack documentation related to

[issue4844] ZipFile doesn't range check in _EndRecData()

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patch updated. Now the test use io.BytesIO() for input too. A loop limit changed from len() -2 to len(). If there are no objections I'll commit this patch next week. -- assignee: mcherm -> serhiy.storchaka Added file: http://bugs.python.org/file28853

[issue16996] Reuse shutil.which() in webbrowser module

2013-01-26 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue4844] ZipFile doesn't range check in _EndRecData()

2013-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file28178/zipfile_unpack_check.patch ___ Python tracker ___ ___ Python-bugs-

[issue16991] Add OrderedDict written in C

2013-01-26 Thread Ezio Melotti
Ezio Melotti added the comment: What's the reason for moving the OrderedDict tests in a separate file? -- ___ Python tracker ___ ___ P

[issue6972] zipfile.ZipFile overwrites files outside destination path

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Can anyone review the patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue17009] "Thread Programming With Python" should be removed

2013-01-26 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue15731] Mechanism for inheriting docstrings and signatures

2013-01-26 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue12397] re match object methods have no docstrings

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Fixed in issue16443. -- nosy: +serhiy.storchaka resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> Add docstrings to regular expression match objects ___ Python tracker <

[issue17041] Fix tests for build --without-doc-strings

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > It seems like it would make more sense to combine both checks into one > decorator. These are different cases. @unittest.skipIf(sys.flags.optimize >= 2) is about docstrings in Python implemented modules, and @support.requires_docstrings is about docstring

[issue17041] Fix tests for build --without-doc-strings

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patches updated incorporating Stefan's patch. -- Added file: http://bugs.python.org/file28850/tests_without_docstrings-2.7_3.patch Added file: http://bugs.python.org/file28851/tests_without_docstrings-3.2_3.patch Added file: http://bugs.python.org/f

[issue17041] Fix tests for build --without-doc-strings

2013-01-26 Thread R. David Murray
R. David Murray added the comment: Once upon a time (two years ago?) we fixed the tests so that they ran successfully (skipped when appropriate) with -OO set, which omits docstrings. We were checking for the optimization level (sys.flags.optimize) then. It seems like it would make more sense

[issue17037] Add conforms_to_pep399() to test.support

2013-01-26 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'm not sure how the "lots of repetition" is a problem. The following: class CCoverage(Coverage): decimal = C class PyCoverage(Coverage): decimal = P is quite trivial compared to the actual base test case (the Coverage class). Not only it is quite triv

[issue17037] Add conforms_to_pep399() to test.support

2013-01-26 Thread Eli Bendersky
Eli Bendersky added the comment: Antoine - I think I can see the use case. ATM, to conform to PEP399, every test _class_ has to be subclassed twice with appropriate assignment to the relevant tested class. This leads to a lot of repetition. As an example, see test_decimal.py, which does this a

[issue17041] Fix tests for build --without-doc-strings

2013-01-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, I see Stefan already fixed some failures. Here are updated patches. -- Added file: http://bugs.python.org/file28847/tests_without_docstrings-2.7_2.patch Added file: http://bugs.python.org/file28848/tests_without_docstrings-3.2_2.patch Added file:

  1   2   >