[issue16098] Bisect optimization in heapq.nsmallest is never used

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset aa9ed98a49cb by Raymond Hettinger in branch '2.7': Issue #16098: Update heapq.nsmallest to use the same algorithm as nlargest. http://hg.python.org/cpython/rev/aa9ed98a49cb -- ___ Python tracker

[issue17128] OS X system openssl deprecated - installer should build local libssl

2013-03-04 Thread Senthil Kumaran
Senthil Kumaran added the comment: Ronald: Sorry for the delay in response. I was referring to this: https://github.com/capistrano/capistrano/issues/250#issuecomment-8055991 " Mountain Lion no longer includes OpenSSL as it uses a different SSL implementation. So, you need to have RVM install O

[issue16098] Bisect optimization in heapq.nsmallest is never used

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset de6627cf81f4 by Raymond Hettinger in branch '3.3': Issue #16098: Update heapq.nsmallest to use the same algorithm as nlargest. http://hg.python.org/cpython/rev/de6627cf81f4 -- ___ Python tracker

[issue17344] checking size of size_t... configure: error:

2013-03-04 Thread Trent Nelson
Trent Nelson added the comment: Shilpi, can you paste the exact ./configure invocation you're using? -- status: pending -> open ___ Python tracker ___ ___

[issue17353] Plistlib outputs empty data tags when deeply nested

2013-03-04 Thread Jacques Fortier
Jacques Fortier added the comment: Quick source inspection suggests this is present in the latest version. -- versions: +Python 3.4, Python 3.5 ___ Python tracker ___ ___

[issue16278] os.rename documentation slightly inaccurate

2013-03-04 Thread Todd Rovito
Todd Rovito added the comment: Ezio, Thank you or the feedback I will continue to polish the test cases. As far as the documentation I really like the table and find it easy to read but I could go either way. If you read the history of this issue other Python Core Developers asked to write

[issue13477] tarfile module should have a command line

2013-03-04 Thread Berker Peksag
Berker Peksag added the comment: > Patch looks good! Some minor comments on Rietveld. Thanks for the review, Éric. > Could you add tests? Done. Here's the new patch with Éric's comments addressed. -- Added file: http://bugs.python.org/file29311/issue13477_v2.diff __

[issue3290] python-config --cflags includes irrelevant flags

2013-03-04 Thread Matthias Braun
Matthias Braun added the comment: I hacked up a proof-of-concept patch which filters out the most annoying flags (warnings, -Ox and -DNDEBUG flags). (Though IMO the only really robust solution would be not having code but just declarations in the public headers, so --includes is enough. In my

[issue16848] Mac OS X: python-config --ldflags and location of Python.framework

2013-03-04 Thread Ned Deily
Changes by Ned Deily : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue16848] Mac OS X: python-config --ldflags and location of Python.framework

2013-03-04 Thread Ned Deily
Ned Deily added the comment: Other than the tabs, the patch LGTM. I originally noticed the problem when addressing Issue14197, a Python 3 only issue, and fixed it there. But I did not go back and check that the python-config part was also an issue for 2.7. Now committed for release in 2.7.4.

[issue17301] An in-place version of many bytearray methods is needed

2013-03-04 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue16848] Mac OS X: python-config --ldflags and location of Python.framework

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset bab708624dc4 by Ned Deily in branch '2.7': Issue #16848: python-config now returns proper --ldflags values for OS X http://hg.python.org/cpython/rev/bab708624dc4 -- nosy: +python-dev ___ Python tracker <

[issue11732] Skip decorator for tests requiring manual intervention on Windows

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: Attached an updated patch: - renamed the context manager from no_crash_popups to suppress_crash_popup, as suggested by Brian (I also made it singular, because there shouldn't be more than one crash/popup per call); - used the context manager on all the crashing t

[issue17301] An in-place version of many bytearray methods is needed

2013-03-04 Thread Terry J. Reedy
Terry J. Reedy added the comment: Gregory, if an in-place version of .translate is all you want, only ask for that. Change the title and let us focus on the best case. Forget what others *might* want. Serhiy, what is 'tacts per byte'? -- ___ Python

[issue17343] Add a version of str.split which returns an iterator

2013-03-04 Thread Brett Cannon
Brett Cannon added the comment: There is no string view that I know of. Interesting idea, though, thanks to the immutability of strings. Would much have to be different other than boundary checking and __hash__ (and hoping extension authors are changing things in-place)? I say go ahead and op

[issue17025] reduce multiprocessing.Queue contention

2013-03-04 Thread Richard Oudkerk
Richard Oudkerk added the comment: On 04/03/2013 8:01pm, Charles-François Natali wrote: >> It looks like queues_contention.diff has the line >> >> obj = pickle.dumps(obj) >> >> in both _feed() and put(). Might that be why the third set of benchmarks >> was slower than the second? > > _feed(

[issue17066] Fix test discovery for test_robotparser.py

2013-03-04 Thread Zachary Ware
Changes by Zachary Ware : Added file: http://bugs.python.org/file29308/test_robotparser_discovery.v3.diff ___ Python tracker ___ ___ Python-bu

[issue17066] Fix test discovery for test_robotparser.py

2013-03-04 Thread Zachary Ware
Zachary Ware added the comment: I got to looking over my patch here again, and thought of another possible fix. I'm not sure which is uglier, though :) The problem is that most of the test cases are created using a custom subclass of unittest.TestCase which takes extra constructor arguments.

[issue17343] Add a version of str.split which returns an iterator

2013-03-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: Indeed, a bytearray version would require the talked about but not implemented due to complexity (in pep3118) support for locking a buffer from other mutations. best concentrate on bytes then. Do we have a memoryview equivalent for PyUnicode? If not, we sh

[issue14266] pyunit script as shorthand for python -m unittest

2013-03-04 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue17353] Plistlib outputs empty data tags when deeply nested

2013-03-04 Thread Jacques Fortier
Jacques Fortier added the comment: My second print should have been: print plistlib.writePlistToString({'test': plistlib.Data('aa')}) -- ___ Python tracker

[issue17353] Plistlib outputs empty data tags when deeply nested

2013-03-04 Thread Jacques Fortier
New submission from Jacques Fortier: To reproduce: import plistlib print plistlib.writePlistToString([{'test': plistlib.Data('aa')}]) Compare to: print plistlib.writePlistToString({'test': Data('aa')}) It looks like the max line length calculation in the

[issue17025] reduce multiprocessing.Queue contention

2013-03-04 Thread Charles-François Natali
Charles-François Natali added the comment: > It looks like queues_contention.diff has the line > > obj = pickle.dumps(obj) > > in both _feed() and put(). Might that be why the third set of benchmarks > was slower than the second? _feed() is a Queue method, put() its SimpleQueue() counterpar

[issue14266] pyunit script as shorthand for python -m unittest

2013-03-04 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Mar 04, 2013, at 07:45 PM, Antoine Pitrou wrote: > >Antoine Pitrou added the comment: > >> We're not going to want to install all possible flavors of >> `pyunit2.6`, `pyunit2.7`, `punit2.6-dbg`, `pyunit-3.2-dbg`, etc. etc. > >Why not? We don't know at packa

[issue17025] reduce multiprocessing.Queue contention

2013-03-04 Thread Richard Oudkerk
Richard Oudkerk added the comment: It looks like queues_contention.diff has the line obj = pickle.dumps(obj) in both _feed() and put(). Might that be why the third set of benchmarks was slower than the second? -- ___ Python tracker

[issue17278] SIGSEGV in _heapqmodule.c

2013-03-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, committed, thank you! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue14266] pyunit script as shorthand for python -m unittest

2013-03-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: > We're not going to want to install all possible flavors of > `pyunit2.6`, `pyunit2.7`, `punit2.6-dbg`, `pyunit-3.2-dbg`, etc. etc. Why not? -- ___ Python tracker ___

[issue17278] SIGSEGV in _heapqmodule.c

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 905b02749c26 by Antoine Pitrou in branch '3.2': Issue #17278: Fix a crash in heapq.heappush() and heapq.heappop() when the list is being resized concurrently. http://hg.python.org/cpython/rev/905b02749c26 New changeset 451299b97b4f by Antoine Pitro

[issue14266] pyunit script as shorthand for python -m unittest

2013-03-04 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: As I mentioned on python-dev, having a `pyunit` script is nice (whatever it's called), but we need to keep the `-m invocation` which will probably be the recommendation on distros such as Debian which provide multiple versions of Python. We're not going to w

[issue14266] pyunit script as shorthand for python -m unittest

2013-03-04 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17278] SIGSEGV in _heapqmodule.c

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 21ded74b51fa by Antoine Pitrou in branch '2.7': Issue #17278: Fix a crash in heapq.heappush() and heapq.heappop() when the list is being resized concurrently. http://hg.python.org/cpython/rev/21ded74b51fa -- nosy: +python-dev _

[issue17025] reduce multiprocessing.Queue contention

2013-03-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: IMHO the simple version is good enough. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17025] reduce multiprocessing.Queue contention

2013-03-04 Thread Charles-François Natali
Charles-François Natali added the comment: So, what do you think? Is the simple version offloading the serialization to queue enough, or should we go for a full-blown atomic Connection/Pipe/etc? I find the performance gain quite appreciable (basically queue didn't scale at all, now it scales wit

[issue17330] Stop checking for directory cache invalidation in importlib

2013-03-04 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17343] Add a version of str.split which returns an iterator

2013-03-04 Thread Santoso Wijaya
Changes by Santoso Wijaya : -- nosy: +santa4nt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue12768] docstrings for the threading module

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: FWIW it applies cleanly on 3.3, but unless we decide to target 3.3+ only, the patch needs to be adapted for 2.7/3.2. -- ___ Python tracker ___ __

[issue12768] docstrings for the threading module

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: 3.2$ hg imp --no-c http://bugs.python.org/file29268/12768_2.patch applying http://bugs.python.org/file29268/12768_2.patch patching file Lib/threading.py Hunk #3 FAILED at 58 Hunk #4 FAILED at 79 Hunk #5 FAILED at 92 Hunk #6 FAILED at 125 Hunk #10 FAILED at 252 Hunk

[issue11787] File handle leak in TarFile lib

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: Closing as duplicate then. -- resolution: -> duplicate stage: test needed -> committed/rejected status: open -> closed superseder: -> tarfile fails to close file handles in case of exception ___ Python tracker

[issue15866] encode(..., 'xmlcharrefreplace') produces entities for surrogate pairs

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: > I doubt about '\ud83d\udc9d' on wide build. Is it right to encode it as > b'💝' and not as b'��'? I don't think so. IIRC surrogates are invalid in UTF-32, and certainly shouldn't be recombined. > This will be compatible with narrow build but will break compat

[issue16851] Hint about correct ismethod and isfunction usage

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: I checked the tests on 2.7 and found this: # contrary to spec, ismethod() is also True for unbound methods # (see #1785) self.assertIn(('f', B.f), inspect.getmembers(B, inspect.ismethod)) #1785 also has some discussion about this. ---

[issue17344] checking size of size_t... configure: error:

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: The SPARC Solaris buildbot with cc compilers run configure without problems, whereas the ones with gcc are broken because of gcc (and they don't even reach the configure step that checks for size_t). If we cannot confirm that there is a problem on a currently mai

[issue12768] docstrings for the threading module

2013-03-04 Thread moijes12
moijes12 added the comment: Hi I am seen the review comments and made the changes accordingly. I am not sure if my changes apply to 3.2. How do I do that ? -- ___ Python tracker _

[issue17332] typo in json docs - "convered" should be "converted"

2013-03-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- keywords: +easy stage: -> needs patch versions: -Python 2.6, Python 3.1, Python 3.5 ___ Python tracker ___

[issue17301] An in-place version of many bytearray methods is needed

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: How *just and *strip can modify an argument in-place? All other methods except title (lower, swapcase, upper) are partial cases of translate. I.e. you need only in-place translate. However I doubt that difference will be more than several percents. Actually

[issue16278] os.rename documentation slightly inaccurate

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: Adding more tests is good, even though there are still a few things that should be improved (see comments on rietveld). Regarding the documentation I'm not sure it's a good idea to be so detailed. On one hand, if we test the behavior we can make sure that the do

[issue14123] Indicate that there are no current plans to deprecate printf-style formatting

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: The only issue seems about the use of the word "deprecate", but I think it's fine, so I'll close this issue. -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue12921] http.server.BaseHTTPRequestHandler.send_error and trailing newline

2013-03-04 Thread karl
karl added the comment: orsenthil, When you have done a patch for testing I would love to see it. I could not find a proper way of doing it. I'm eager to learn. Thanks. -- ___ Python tracker

[issue17339] bytes() TypeError message is misleadingly narrow

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: > 'object' object cannot be converted to bytes This is not entirely accurate for the bytes(int) case though, since it's not converting the int to bytes. OTOH if we want to keep the message short we have to make compromises about accuracy and completeness.

[issue13477] tarfile module should have a command line

2013-03-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue16997] subtests

2013-03-04 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17338] Add length_hint parameter to list, dict, set constructors to allow efficient presizing

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This unlikely will be useful. C code uses __length_hint__ because C code is fast enough and fill time can be comparable to resize time. But Python code will be one or two order slower and resize time is insignificant fraction of total time for any real code.

[issue12921] http.server.BaseHTTPRequestHandler.send_error and trailing newline

2013-03-04 Thread Senthil Kumaran
Senthil Kumaran added the comment: Karl, Ack. The patch looks good. I shall go about with testing + committing this.. -- ___ Python tracker ___ __

[issue17338] Add length_hint parameter to list, dict, set constructors to allow efficient presizing

2013-03-04 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue17343] Add a version of str.split which returns an iterator

2013-03-04 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue12921] http.server.BaseHTTPRequestHandler.send_error and trailing newline

2013-03-04 Thread karl
karl added the comment: orsenthil, I made a proper patch for it with hg diff. It is very short. See issue-12921-2.patch -- Added file: http://bugs.python.org/file29306/issue-12921-2.patch ___ Python tracker __

[issue16997] subtests

2013-03-04 Thread Michael Foord
Michael Foord added the comment: So, if it's not documented behaviour I think it's fine to lose it. -- ___ Python tracker ___ ___ Pyth

[issue16997] subtests

2013-03-04 Thread Nick Coghlan
Nick Coghlan added the comment: The docs are fairly explicit about the intended use case: "Mark the test as an expected failure. If the test fails when run, the test is not counted as a failure." (from http://docs.python.org/3/library/unittest#unittest.expectedFailure) Nothing there about bei

[issue16997] subtests

2013-03-04 Thread Michael Foord
Michael Foord added the comment: That's a use case that I'm not very *interested* in supporting personally - however it may well be a use case that was "designed in" and that others have a need for (I didn't implement expectedFailure support). I think expectedFailure should be used sparingly

[issue17322] urllib.request add_header() currently allows trailing spaces (and other weird stuff)

2013-03-04 Thread R. David Murray
R. David Murray added the comment: Aren't the folding rules are the same? The character set rules are different, I think, but the email package is going to be flexible in that regard. The email package also uses a data structure that is not a python dictionary (it is actually a list with an e

[issue17352] Be clear that __prepare__ must be declared as a class method

2013-03-04 Thread Nick Coghlan
Nick Coghlan added the comment: Class method, not static method (super() breaks if you declare it as a static method) -- title: Be clear that __prepare__ must be declared as a static method -> Be clear that __prepare__ must be declared as a class method ___

[issue17341] Poor error message when compiling invalid regex

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also issue14462. It will be easier to include a full group name than an invalid character. -- nosy: +serhiy.storchaka ___ Python tracker

[issue16575] ctypes: unions as arguments

2013-03-04 Thread Armin Rigo
Armin Rigo added the comment: See also http://bugs.python.org/issue16576. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17352] Be clear that __prepare__ must be declared as a static method

2013-03-04 Thread Nick Coghlan
New submission from Nick Coghlan: The docs on __prepare__ don't make it clear that it should be a staticmethod, and the error message if you forget is not obvious at all. (This is particularly so, since the examples in PEP 3115 had it as an ordinary method). -- messages: 183463 nosy: n

[issue16004] Add `make touch` to 2.7 Makefile

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: Nick, is the attached patch ok? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue16575] ctypes: unions as arguments

2013-03-04 Thread Eli Bendersky
Eli Bendersky added the comment: A minimal fix would be to update the documentation. A more comprehensive fix would be to tweak ctypes to reject unions and bit-fields when running on non-x86 (does this work for ARM and other non-Intel archs?) An even more comprehensive fix would be to make th

[issue17328] Fix reference leak in dict_setdefault() in case of resize failure

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1a589001d752 by Benjamin Peterson in branch '3.3': fix possible setdefault refleak (closes #17328) http://hg.python.org/cpython/rev/1a589001d752 New changeset fac46cf6af3f by Benjamin Peterson in branch 'default': merge 3.3 (#17328) http://hg.python

[issue17322] urllib.request add_header() currently allows trailing spaces (and other weird stuff)

2013-03-04 Thread karl
karl added the comment: R. David.: > A crazy idea that occurred to me was to create an "rfc822-style-header > management" module, and share it between email, http, and urllib. Yes it is basically what I had in mind when I said: >Maybe the way forward in the future is to have a header factory s

[issue8273] move generally useful test.support functions into the unittest package

2013-03-04 Thread Zachary Ware
Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17351] Fixed python3 descriptor documentation example + removal of explicit "object" inheritance in docs

2013-03-04 Thread Phil Elson
New submission from Phil Elson: The example at http://docs.python.org/3.4/howto/descriptor.html#properties does not run due to the old style "raise AttributeError, message" form. This patch fixes the problem, and also goes through the docs to remove explicit sub-classing from "object". The o

[issue10967] move regrtest over to using more unittest infrastructure

2013-03-04 Thread Zachary Ware
Changes by Zachary Ware : -- nosy: +zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue10590] Parameter type error for xml.sax.parseString(string, ...)

2013-03-04 Thread Eli Bendersky
Eli Bendersky added the comment: Serhiy, OK - I'll look at #2175 first. But yes, Christian is right, let's wait for the security issues to be resolved first. -- ___ Python tracker _

[issue16986] ElementTree incorrectly parses strings with declared encoding not UTF-8

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Eli, this issue no longer has open pre-requisites. Issue10590 was replaced by issue17089 which closed now. Issue17089 fixed Python interface to expat parser, but cElementTree uses C interface of expat directly and the proposed pathes fix it. -- ___

[issue10590] Parameter type error for xml.sax.parseString(string, ...)

2013-03-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file28757/sax_parse.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue10590] Parameter type error for xml.sax.parseString(string, ...)

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Low-level part already extracted to issue17089 and committed. Issue16986 has a similar patch for cElementTree. The main part of path was moved to issue2175 which is now pre-requisite for issue16986 and for this issue. It contains additional tests and additio

[issue16997] subtests

2013-03-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: > However, I'm wondering if it might still be possible to avoid the > need for a thread local context to handle the combination of > expected failures and subtests when we have access to the test > caseby adding the annotation that I expected to be there in the >

[issue13598] string.Formatter doesn't support empty curly braces "{}"

2013-03-04 Thread Vinay Sajip
Vinay Sajip added the comment: > I believe the case is covered by the block: [snip] Ah, right. I wasn't sure that was the exact same code path that was being exercised. But I didn't look very closely. > If you think it is worthwhile? Only if it exercises a different code path. -- __

[issue16997] subtests

2013-03-04 Thread Michael Foord
Michael Foord added the comment: Getting rid of the thread local would be an improvement, and the change to how expected failures is done sounds good too. -- ___ Python tracker

[issue17322] urllib.request add_header() currently allows trailing spaces (and other weird stuff)

2013-03-04 Thread R. David Murray
R. David Murray added the comment: A crazy idea that occurred to me was to create an "rfc822-style-header management" module, and share it between email, http, and urllib. We'd probably break too many things backward-compatibility wise if we did that, but I still think it is an interesting th

[issue16997] subtests

2013-03-04 Thread Nick Coghlan
Nick Coghlan added the comment: I think I have figured out what bothers me about the expectedfailure changes, and they actually relate to how expectedfailure was implemented in the first place: I had previously assumed that decorator was an *annotating* decorator - that it set an attribute on

[issue17346] Pickle tests do not test protocols 0, 1, and 2 for bytes

2013-03-04 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the report and the patch! -- assignee: -> ezio.melotti resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker __

[issue17346] Pickle tests do not test protocols 0, 1, and 2 for bytes

2013-03-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset a982feb29584 by Ezio Melotti in branch '3.2': #17346: make sure pickle tests are run against all protocols. Initial patch by Marius Gedminas. http://hg.python.org/cpython/rev/a982feb29584 New changeset 796de4f7df07 by Ezio Melotti in branch '3.3':

[issue11787] File handle leak in TarFile lib

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Actually it was fixed in issue16477. ;) -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue15866] encode(..., 'xmlcharrefreplace') produces entities for surrogate pairs

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I prefer a little different (simpler for me) form: for (p = collstart; p < collend;) { Py_UCS4 ch = *p++; if ((0xD800 <= ch && ch <= 0xDBFF) && (p < collend) &&

[issue17094] sys._current_frames() reports too many/wrong stack frames

2013-03-04 Thread Stefan Ring
Stefan Ring added the comment: (Regarding your test) I have also noticed in the past that joining threads after a fork has caused hangs occasionally, although that might have resulted from the messed up _current_frames. -- ___ Python tracker

[issue17350] Use STAF call python script will case 1124861 issue in 2.7.2 version

2013-03-04 Thread Tomgu
New submission from Tomgu: Here I get one problem use STAF call python and need help. In python 2.7.2 version I write a script "test.py" as below ### import subprocess fileID=file('test1.log','w') process_response = subprocess.call('netsh wlan show\ interface',stdout=fileID,shell=True) fileID.f

[issue16382] Better warnings exception for bad category

2013-03-04 Thread Phil Elson
Phil Elson added the comment: Ok. I think I've done all of the actions from the reviews. I'm not sure if I should remove the old patches or not? Thanks, -- Added file: http://bugs.python.org/file29304/pelson_warnings_fix_4.diff ___ Python tracker <

[issue1124861] subprocess fails on GetStdHandle in interactive GUI

2013-03-04 Thread Tomgu
Tomgu added the comment: Update, the python version is '2.7.2 (default, Jun 12 2011, 15:08:59) [MSC v.1500 32 bit (Intel)]' -- ___ Python tracker ___ _

[issue1124861] subprocess fails on GetStdHandle in interactive GUI

2013-03-04 Thread Tomgu
Tomgu added the comment: Here I get one problem need help. In python 2.7.5 version I write a script "test.py" as below ### import subprocess fileID=file('test1.log','w') process_response = subprocess.call('netsh wlan show\ interface',stdout=fileID,shell=True) fileID.flush() fileID.close() ### I

[issue17094] sys._current_frames() reports too many/wrong stack frames

2013-03-04 Thread Stefan Ring
Stefan Ring added the comment: When I originally worked on this, I noticed that _PyThread_CurrentFrames also iterates over all interpreters. Because I have no experience with or use for multiple interpreters, I intentionally left it out of my patch, but shouldn't it be taken into account for a

[issue16851] Hint about correct ismethod and isfunction usage

2013-03-04 Thread Thomas Kluyver
Thomas Kluyver added the comment: I agree that the docs for inspect.ismethod() for Python 2 are wrong. The docs say: "Return true if the object is a bound method written in Python." However, it also returns True for an unbound method: >>> class A: ... def meth(self): ... pass ...

[issue17346] Pickle tests do not test protocols 0, 1, and 2 for bytes

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- nosy: +serhiy.storchaka versions: +Python 3.2, Python 3.4 ___ Python tracker ___ ___ Pyth

[issue17349] wsgiref.simple_server.demo_app is not PEP-3333 compatible

2013-03-04 Thread Andrey Lebedev
New submission from Andrey Lebedev: Under certain circumstances, wsgiref.simple_server.demo_app may return unicode data, but that is prohibited by PEP-. This happens if environ with unicode key is passed to demo_app. Unicode keys are then written to StringIO instance, automatically making

[issue17299] Test cPickle with real files

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: David, yes, this is 2.7 only issue. The code was broken recently (see msg182979 in issue13555) due to insufficient testing. -- ___ Python tracker ___

[issue17299] Test cPickle with real files

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have added comments on Rietveld. Perhaps it will be worth to create mixings for cStringIO.StringIO, BytesIO and file object and then mix them to other tests. Note that there is no sense to change pure Python pickle tests. Python implementation uses the sa

[issue13598] string.Formatter doesn't support empty curly braces "{}"

2013-03-04 Thread Phil Elson
Phil Elson added the comment: > I didn't see a test case relating to the example in his comment, namely > > f.format("{0:{}}", 'foo', 5) > > Did I miss it? The example should fail, which it wouldn't have done with the patch previously proposed. I believe the case is covered by the block:

[issue16620] Avoid using private function glob.glob1() in msi module and tools

2013-03-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I have added some comments on Rietveld. Note that glob.glob() and glob.glob1() returns different filenames. The first returns full paths and the second returns bare filenames without a directory path. Workarounding this may require more in-depth changes to t

[issue17347] bsddb._openDBEnv() should not touch current directory

2013-03-04 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: This is a standard Berkeley DB behavior. Can I suggest you to report this "issue" to Oracle forums? http://docs.oracle.com/cd/E17276_01/html/programmer_reference/env_db_config.html https://forums.oracle.com/forums/forum.jspa?forumID=271 Closing as "invalid".

[issue17348] Unicode - encoding seems to be lost for inputs of unicode chars

2013-03-04 Thread Pradyun Gedam
New submission from Pradyun Gedam: In IDLE, I have spotted a peculiar problem. I have attached an .png file which is a screen capture of 'session' on IDLE. It seems that the Unicode character that has been input, loses its encoding. My 'session' Python 2.7.2 (default, Jun 12 2011, 15:08:59) [M

[issue17347] bsddb._openDBEnv() should not touch current directory

2013-03-04 Thread Florian Weimer
New submission from Florian Weimer: This code: def _openDBEnv(cachesize): e = db.DBEnv() if cachesize is not None: if cachesize >= 20480: e.set_cachesize(0, cachesize) else: raise error, "cachesize must be >= 20480" e.set_lk_detect(db.DB_LOCK_D

[issue17346] Pickle tests do not test protocols 0, 1, and 2 for bytes

2013-03-04 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

  1   2   >