Serhiy Storchaka added the comment:
LGTM. But why not just inline expat_unknown_encoding_handler()?
For 2.7 we perhaps should add SetStartDoctypeDeclHandler and SetEncoding in the
exported C API. Shouldn't we update the C API version (for this issue and for
issue16986)?
--
Antoine Pitrou added the comment:
User code should generally not see any SystemErrors (even when choosing wacky
module names :-)), so IMHO this is a regression.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
It works only if input also supports slicing and this slicing is corresponded
to bytes-slicing. It perhaps doesn't catch a non C-continuous buffers.
Actually we need something like (unlikely cast() doesn't work with empty
buffers):
s = memoryview(s)
Serhiy Storchaka added the comment:
Are there any objections?
--
assignee: docs@python - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18011
___
New submission from Serhiy Storchaka:
There are two test files for the same feature -- defining Python source code
encodings (PEP 263). It is not clear where new tests should be added. Perhaps
two files should be merged into the one file.
test_pep263.py was added in 2002, test_coding.py was
Martin v. Löwis added the comment:
LGTM.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18038
___
___
Python-bugs-list mailing
Changes by Martin v. Löwis mar...@v.loewis.de:
--
nosy: +loewis, tim.golden
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18040
___
___
Martin v. Löwis added the comment:
What does churn mean?
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18041
___
___
Serhiy Storchaka added the comment:
Here is a better patch with tests (see also issue18048).
--
Added file:
http://bugs.python.org/file30358/tokenizer_encoding_problem_msg.patch
___
Python tracker rep...@bugs.python.org
Oscar Benjamin added the comment:
Renato Silva added the comment:
I must note that GCC 4.x *does* support -mno-cygwin, at least until 4.4,
and at least the MinGW version.
MinGW has never supported the -mno-cygwin option. It has simply tolerated
it. The option never did anything useful and at
Roundup Robot added the comment:
New changeset f4981d8eb401 by Ronald Oussoren in branch '2.7':
Issue #17269: Workaround for a platform bug in getaddrinfo on OSX
http://hg.python.org/cpython/rev/f4981d8eb401
New changeset 3c4a5dc29417 by Ronald Oussoren in branch '3.3':
Issue #17269: Workaround
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file:
http://bugs.python.org/file30345/tokenizer_encoding_problem_msg.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18038
___
Martin v. Löwis added the comment:
For a bug fix release, I consider refactoring of test cases inappropriate.
If they really ought to be merged, I consider neither file name particularly
descriptive, so perhaps a new file name should be used altogether (e.g.
test_source_encoding).
--
Christian Heimes added the comment:
I finally found the correct RFC for wildcard matching. I think our
implementation violates some recommendations.
http://tools.ietf.org/html/rfc6125#section-6.4.2
http://tools.ietf.org/html/rfc6125#section-6.4.3
--
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: - ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13266
___
___
Python-bugs-list
Changes by Nick Coghlan ncogh...@gmail.com:
--
assignee: - ncoghlan
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17482
___
___
Python-bugs-list
Nick Coghlan added the comment:
Georg, just a heads up that I was informed of a fairly significant bug in the
__wrapped__ handling which some folks doing function introspection had been
assuming was a feature.
I'd like to fix it for 3.3.3, but need your +1 as RM since it *will* break
Changes by Łukasz Langa luk...@langa.pl:
--
nosy: +lukasz.langa
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17482
___
___
Python-bugs-list
Changes by Ronald Oussoren ronaldousso...@mac.com:
--
resolution: - fixed
stage: patch review - committed/rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17269
Ronald Oussoren added the comment:
At first I didn't like the proposal, but when I looked at the JSON module I
noticed it has similar functionality for ignoring keys that cannot be
represented in a JSON file.
I'll look into this after merging #14455.
The JSON library has two other options
New submission from Ronald Oussoren:
I recently notied that
test.test_threading.ThreadingExceptionTests.test_recursion_limit is disabled
for debug builds.
The attached patch re-enables this test case and fixes the crash be increasing
the stack size for new threads.
The disadvantage of the
Mark Lawrence added the comment:
Bump as IDLE is now being actively developed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2053
___
___
Mark Lawrence added the comment:
Can someone answer the question pointed to by msg109816 i.e. can all of the
buildbots build all of the expected extensions?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4304
Roundup Robot added the comment:
New changeset 51c5870144e7 by Senthil Kumaran in branch 'default':
Fix #17272 - Make Request.full_url and Request.get_full_url return same result
under all circumstances.
http://hg.python.org/cpython/rev/51c5870144e7
--
Éric Araujo added the comment:
Looks good.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17701
___
___
Python-bugs-list mailing list
Ronald Oussoren added the comment:
I've started work on integrating the latest patch.
Some notes (primarily for my own use):
* I'll drop support for the JSON format, that format is not used
by Apple's libraries (although the plutil tool can convert plists
to JSON)
* The patch
Senthil Kumaran added the comment:
This is fixed in 3.4. I dont think backporting is a good idea just to support
assignment to .full_url. Thinking of this further, the idea of reusing request
by assigning to .full_url may not be a good idea, because if you set .full_url
to a completely
Serhiy Storchaka added the comment:
Updating tests I found some related errors.
XML-RPC doesn't work in general case for non UTF-8 encoding:
import xmlrpclib
xmlrpclib.dumps(('\u20ac',), encoding='iso-8859-1')
'params\nparam\nvaluestring\\u20ac/string/value\n/param\n/params\n'
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file: http://bugs.python.org/file30339/xmlrpc_dump_invalid_string.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7727
___
Éric Araujo added the comment:
Moving things around.
--
nosy: +eric.araujo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18041
___
___
Changes by Serhiy Storchaka storch...@gmail.com:
Removed file:
http://bugs.python.org/file30343/xmlrpc_dump_invalid_string-2.7.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7727
___
Éric Araujo added the comment:
Tshepang is referring to cases where a patch changes one line but affects ten
other lines because a paragraph was rewrapped, modernizing code, updating tests
to use latest helpers, etc.
I’ve actually seen two contrary kinds of advice: do cleanups when you touch
Éric Araujo added the comment:
The other bug report classifies the request behavior as a new feature, so it
could not go into 2.7.
--
nosy: +eric.araujo, pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18000
Éric Araujo added the comment:
A higher-level interface to abstract differences between gzip, xz and others is
actually provided in the tarfile module. (zipfile is left out and its file
objects have different methods, but that’s another issue. shutil provides even
higher-level functions to
New submission from Samuel John:
As also discussed at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704084
and https://github.com/mxcl/homebrew/pull/19300, Python 2.7.4 and 2.7.5 seem to
have added an `from _sre import MAXREPEAT` to the sre_compile.py, sre_parse.py
and sre_constants.py
Terry J. Reedy added the comment:
I have not looked at the details, so cannot currently comment as to whether the
idea should be pursued or dropped. Perhaps when Roger is done with overt bugs
he will take a look and offer an opinion.
--
assignee: kbk -
nosy: +roger.serwy
versions:
New submission from Craig McDaniel:
Running setup.py bdist_rpm throws an exception on some libraries (e.g. -
simplejson) since 2.7.4 due to introduction of get_python_version():
Traceback (most recent call last):
File setup.py, line 103, in module
run_setup(True)
File setup.py, line
Craig McDaniel added the comment:
Closing; duplicate of 18045
--
resolution: - duplicate
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18051
___
Changes by Terry J. Reedy tjre...@udel.edu:
--
nosy: +terry.reedy
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18009
___
___
Python-bugs-list
Martin v. Löwis added the comment:
As a policy, the standard library should accept non-ASCII host names
(U-labels) wherever possible. I.e the hostname parameter of match_hostname
should allow for U-labels (as well as A-labels).
When returning names, it should always return the data as-is,
A.M. Kuchling added the comment:
Here's a proposed patch to the c-api manual that describes these two pointers.
I put them in the 'very high-level API' section. Maybe they belong in the
Operating System Utilities section instead, but I think they're intertwined
with the interpreter loop and
Terry J. Reedy added the comment:
I am not a C-api user, but the entries are pretty clear to me and seem ready to
apply. The usage examples are a nice touch. OS Utilites is not where I would
expect interpreter loop hooks, so I think the current location is better.
--
stage: - commit
Ned Deily added the comment:
Attached is a refreshed version of the patch against current 2.7 tip. I did a
quick visual comparison with the original but make no guarantees that it is
totally accurate. I have no plans to work on it further myself.
--
nosy: +ned.deily
Added file:
Changes by Alex Burka durk...@gmail.com:
--
nosy: +Alex.Burka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18050
___
___
Python-bugs-list mailing
A.M. Kuchling added the comment:
One question about the patch: how to give the prototype expected for the
function? I currently have it as:
char *(*PyOS_ReadlineFunctionPointer)(FILE *stdin, FILE *stdout, char *prompt)
Would it be better with a trivial function name, as in:
char *func(FILE
Roundup Robot added the comment:
New changeset 4f8160e45cb7 by Brett Cannon in branch '3.3':
Issue #17953: document that sys.modules shouldn't be replaced (thanks
http://hg.python.org/cpython/rev/4f8160e45cb7
New changeset b60ae4ebf981 by Brett Cannon in branch 'default':
merge fix for issue
Brett Cannon added the comment:
Thanks for the patch, Yogesh, but I went with different wording that I came up
with on the train the other day while offline. But you did remind me to update
Misc/NEWS (which led to a discussion on python-committers), so thanks for that.
--
resolution:
Roundup Robot added the comment:
New changeset 7935844c6737 by Benjamin Peterson in branch '3.3':
indicate that read/write work with bytes (closes #18009)
http://hg.python.org/cpython/rev/7935844c6737
--
nosy: +python-dev
resolution: - fixed
stage: - committed/rejected
status: open -
Changes by Ned Deily n...@acm.org:
--
nosy: +ned.deily
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18050
___
___
Python-bugs-list mailing list
Terry J. Reedy added the comment:
Can one of you three answer Kuchling's question about formatting a data entry
that consists of a function pointer with function signature?
--
nosy: +eric.araujo, ezio.melotti, georg.brandl
___
Python tracker
New submission from Terry J. Reedy:
Windows 7 (32 bit?), 32 bit IDLE 3.3.2: When I start from the start menu, the
taskbar icon is the red Tk icon instead of the IDLE icon. If I try to pin the
Tk icon to the task bar, a useless pythonw icon is pinned instead. The Tk icon
goes when the program
Yogesh Chaudhari added the comment:
You are most welcome Brett. I am just starting to contribute with this doc fix.
Didn't think a small detail in it will generate such a long debate in the
python-committers mailing list.
Is there a plan in action for 'fixing' Misc/NEWS. I now realize that
R. David Murray added the comment:
I think that is a reasonable suggestion for an enhancement to patchcheck
(though I think Brett had a good reason to add a news entry in this particular
case). You could open a new issue with that suggestion. On the other hand,
patchcheck always warns about
Yogesh Chaudhari added the comment:
That sounds good. I will open up an issue (if not for anything else other than
to get more eyes on this issue)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17953
Renato Silva added the comment:
MinGW has never supported the -mno-cygwin option. It has simply
tolerated it. The option never did anything useful and at some point
it became an error to even supply it. I'm not sure exactly when but
some time after 4.4 sounds reasonable to me.
Hi Oscar!
Renato Silva added the comment:
ERRATA.
Where you see: [1] clearly did not come to reality.
Please read: [0] clearly did not come to reality.
[0] http://cygwin.com/ml/cygwin/2009-03/msg00802.html
--
___
Python tracker rep...@bugs.python.org
New submission from Yogesh Chaudhari:
Based on the threads about
http://mail.python.org/pipermail/python-committers/2013-May/002529.html and
discussion on http://bugs.python.org/issue17953; It would be good to add some
(very high level)checks inside patchcheck that will tell the user if
Yogesh Chaudhari added the comment:
I am not sure which component patchcheck corresponds to, so I have left that
out and added people on nosy list in http://bugs.python.org/issue17953. If I
have missed the concerned maintainer, kindly let me know.
--
nosy: +brett.cannon, pitrou,
58 matches
Mail list logo
