[issue15805] Add stdout redirection tool to contextlib

2013-07-22 Thread Nick Coghlan
Nick Coghlan added the comment: Can we go paint bikesheds somewhere else now, please? Raymond has persuaded me as contextlib maintainer that this small addition is worth making as a way of factoring out repeated calls to print with a file redirection in simple user scripts where thread safety

[issue16809] Tk 8.6.0 introduces TypeError. (Tk 8.5.13 works)

2013-07-22 Thread alejandro autalan
alejandro autalan added the comment: Hello. I tried 'tkinter_split.patch' patch against 3.3.2, but a fix for grid_info function is also needed. #test.py import tkinter as tk root = tk.Tk() b = tk.Button(root, text='Button') b.grid() print(b.grid_info()) root.mainloop() Here's is the script's

[issue18534] File "name" attribute should always be a text string

2013-07-22 Thread Nick Coghlan
New submission from Nick Coghlan: Currently, if a byte sequence is passed to open() as the file name, the resulting file will have that object as its name: >>> open(os.path.expanduser(b"~/.hgrc")) <_io.TextIOWrapper name=b'/home/ncoghlan/.hgrc' mode='r' encoding='UTF-8'> >>> open(os.path.expand

[issue18502] CDLL does not use same paths as util.find_library

2013-07-22 Thread Steven Johnson
Steven Johnson added the comment: Should the docs then be changed for find_library to inform that "It is not guaranteed that a found library can be opened" (at least for linux)? Or would a feature request for full paths from find_library for linux be more appropriate? It seems hackish to me,

[issue15805] Add stdout redirection tool to contextlib

2013-07-22 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Yes, I did miss Victor's dup2() comment. (It looks like I did not subscribe to this issue from the start and missed early discussion - sorry.) The simple feature is not very useful for me. I have to deal with too many cases of misguided code like this:

[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-22 Thread Larry Hastings
Larry Hastings added the comment: And here's an updated patch for 3.3; the only change from the previous 3.3 patch is that I call path_error before calling close. -- Added file: http://bugs.python.org/file31021/larry.3.3.listdir.fd.leakage.bug.2.patch _

[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-22 Thread Larry Hastings
Larry Hastings added the comment: If someone will give me an LGTM I'll check these in tonight, honest, cross my heart. -- ___ Python tracker ___

[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-22 Thread Larry Hastings
Larry Hastings added the comment: Attached is a new patch for trunk, removing the #undef HAVE_FDOPENDIR debug scaffolding, and rearranging the lines of error handling so close doesn't clear the errno before we use it. By cracky, while most days I do enjoy the exacting pedantry of the Python c

[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-22 Thread Larry Hastings
Larry Hastings added the comment: I've been staring at the code. I just realized: we really should call path_error() as soon as possible once we detect the error--as Christian's patch points out, close() will clear the error. So instead of playing footsie with assigning (further) to errno, I

[issue18504] IDLE:Improvements- Improving Mock_Text

2013-07-22 Thread R. Jayakrishnan
Changes by R. Jayakrishnan : -- nosy: +Todd.Rovito ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue18504] IDLE:Improvements- Improving Mock_Text

2013-07-22 Thread Phil Webster
Changes by Phil Webster : -- nosy: +philwebster ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue15805] Add stdout redirection tool to contextlib

2013-07-22 Thread Nick Coghlan
Nick Coghlan added the comment: Alexander, please read the earlier comments on the issue: we're deliberately *not* doing that. Such functionality is more advanced, and more appropriate for an API in the subprocess module. Anyone interested in exploring that option further should create a separ

[issue18502] CDLL does not use same paths as util.find_library

2013-07-22 Thread Meador Inge
Meador Inge added the comment: On Linux gcc and ld are used to implement 'find_library' and 'dlopen' is used to implement 'CDLL'. ld searches /usr/local/lib. 'dlopen' might not if the LD_LIBRARY_PATH isn't set up to do so. For example: [meadori@li589-207 cpython]$ ls /usr/local/lib libfoo.

[issue15805] Add stdout redirection tool to contextlib

2013-07-22 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: In my post "fd 0" should have been "fd 1", of course. (Proving that it is not trivial to get it right:-) -- ___ Python tracker ___ _

[issue15805] Add stdout redirection tool to contextlib

2013-07-22 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: It would be nice if this context manager had an option to redirect the file descriptor 0 rather than just sys.stdout. (For those familiar with py.test, I am asking for an equivalent of --capture=fd functionality.) Unlike patching sys.stdout, which is wi

[issue15805] Add stdout redirection tool to contextlib

2013-07-22 Thread Nick Coghlan
Nick Coghlan added the comment: I'd prefer to keep the separate stream argument rather than duplicating the signature of open. Separation of concerns and all that :) -- ___ Python tracker __

[issue18533] Avoid error from repr() of recursive dictview

2013-07-22 Thread Jan Kaliszewski
Jan Kaliszewski added the comment: As I wrote on the list -- IMHO it's still a bug (even though not so painful as segfault) that should also be fixed in 2.7 and 3.2/3.3. In other cases (such as `d={}; d[42]=d; repr(d)`) Python does its best to avoid an error -- why in this case (`d={}; d[42]=

[issue18533] Avoid error from repr() of recursive dictview

2013-07-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Fixing 3.3 is more likely that 3.4. I can view RuntimeError as a bug less obnoxious than crash, but others may differ. Ultimately, the release managers can decide. This is definitely appropriate for 3.4, so please add tests. If the patch is for 2.7, please do

[issue18520] Fixes bugs found by pyfailmalloc during Python initialization

2013-07-22 Thread STINNER Victor
STINNER Victor added the comment: I ran my test for more than 30 minutes and I didn't find any interesting bug anymore, so I'm closing the issue. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue18533] Avoid error from repr() of recursive dictview

2013-07-22 Thread Ben North
New submission from Ben North: #18019 noted the following crash in earlier 2.7: >>> d={} >>> d[42]=d.viewvalues() >>> d This issue has been fixed; the behaviour now is that a RuntimeError is produced for a recursive dictionary view: >>> d={} >>> d[42]=d.viewvalues() >>> d # (output line-broke

[issue18533] Avoid error from repr() of recursive dictview

2013-07-22 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18293] ssl.wrap_socket (cert_reqs=...), getpeercert, and unvalidated certificates

2013-07-22 Thread Derek Wilson
Derek Wilson added the comment: Custom cert validation may make sense in edge cases, so this looks interesting. But I got here looking to file a bug on the returning empty dict from SSLContext.getpeercert - I don't feel like that makes sense. Its not like a peer cert doesn't exist just because

[issue18532] hashlib.HASH objects should officially expose the hash name

2013-07-22 Thread Daniel Holth
Daniel Holth added the comment: fwiw pypy 2 supports HASH.name but the older 1.9 (still part of some Linux distributions) did not. -- nosy: +dholth ___ Python tracker ___ __

[issue18520] Fixes bugs found by pyfailmalloc during Python initialization

2013-07-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset fc718c177ee6 by Victor Stinner in branch 'default': Issue #18520: Add a new PyStructSequence_InitType2() function, same than http://hg.python.org/cpython/rev/fc718c177ee6 New changeset 9b77b3ee6fb8 by Victor Stinner in branch 'default': Issue #18520

[issue13153] IDLE crashes when pasting non-BMP unicode char on Py3

2013-07-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: In 3.3.2, 3.4.0 the traceback says that the invalid continuation byte (immediately, when '𐒢' is pasted) is ED. Snipped version is File "F:\Python\dev\py33\lib\tkinter\__init__.py", line 1071, self.tk.mainloop(n) UnicodeDecodeError: 'utf-8' codec can't dec

[issue16741] `int()`, `float()`, etc think python strings are null-terminated

2013-07-22 Thread Benjamin Peterson
Benjamin Peterson added the comment: Yeah, let's just fix Python 3. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue18532] hashlib.HASH objects should officially expose the hash name

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: Sounds like a good idea. -- nosy: +christian.heimes, gregory.p.smith stage: -> needs patch type: -> enhancement ___ Python tracker ___ _

[issue18532] hashlib.HASH objects should officially expose the hash name

2013-07-22 Thread Jason R. Coombs
New submission from Jason R. Coombs: In hashlib, the HASH objects currently supply a 'name' attribute, reflecting the name used to initialize the hash object, and they have since Python 2.5. However, this interface is not published so isn't honored by other platforms (namely pypy). I propose

[issue9035] os.path.ismount on windows doesn't support windows mount points

2013-07-22 Thread Christian Tismer
Christian Tismer added the comment: Hi Tim, Yes, this would be great to get sorted out. Then we could make watchdog.py automatically configure itself for network mounts. Right now this makes no nense because of windows. cheers - chris -- nosy: +Christian.Tismer __

[issue18523] test_signal failure under Windows

2013-07-22 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> duplicate status: open -> closed superseder: -> test_signal.test_issue9324() fails on buildbot AMD64 Windows7 SP1 3.x ___ Python tracker

[issue18405] crypt.mksalt() result has unnecessarily low entropy

2013-07-22 Thread STINNER Victor
STINNER Victor added the comment: I prefer to avoid conversion to/from base64, and use random.choice() instead: see attached patch. -- keywords: +patch nosy: +haypo Added file: http://bugs.python.org/file31018/crypt_salt_choice.patch ___ Python track

[issue16741] `int()`, `float()`, etc think python strings are null-terminated

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: I don't like the idea to change the behavior of 2.7 so late in its release cycle. Benjamin, what's your opinion? -- nosy: +benjamin.peterson, christian.heimes ___ Python tracker

[issue18531] Undocumented different between METH_KEYWORDS and **kws

2013-07-22 Thread Alex Gaynor
Alex Gaynor added the comment: I'll confirm that PyPy raises a KeyError on the format() code. -- nosy: +alex ___ Python tracker ___ __

[issue18531] Undocumented different between METH_KEYWORDS and **kws

2013-07-22 Thread Barry A. Warsaw
New submission from Barry A. Warsaw: A colleague discovered an interesting implementation different between C-defined functions and Python-defined functions called with **kws arguments. He tried to do this: >>> from collections import defaultdict >>> '{foo}{bar}'.format(**defaultdict(str)) ''

[issue15805] Add stdout redirection tool to contextlib

2013-07-22 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: May I suggest a simpler patch that closes the fd sooner? -- Added file: http://bugs.python.org/file31017/listdir_fd.patch ___ Python tracker _

[issue17944] Refactor test_zipfile

2013-07-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > This bug should be fixed in 2.7 if it exists. It doesn't exists in 2.7. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 240adc564539 by Brian Curtin in branch 'default': Fix #18530. Remove extra stat call from posixpath.ismount http://hg.python.org/cpython/rev/240adc564539 -- nosy: +python-dev ___ Python tracker

[issue16741] `int()`, `float()`, etc think python strings are null-terminated

2013-07-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: If there are no objections I'm going to commit patches soon. -- ___ Python tracker ___ ___ Python-

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Brian Curtin
Brian Curtin added the comment: ^That takes care of default. I misspoke in an earlier comment about 3.3 - that should probably be determined by that RM (Georg?) -- ___ Python tracker __

[issue17944] Refactor test_zipfile

2013-07-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset bb63f813a00f by Serhiy Storchaka in branch '3.3': Issue #17944: test_zipfile now discoverable and uses subclassing to http://hg.python.org/cpython/rev/bb63f813a00f New changeset 5812a3683402 by Serhiy Storchaka in branch 'default': Issue #17944: tes

[issue13153] IDLE crashes when pasting non-BMP unicode char on Py3

2013-07-22 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: serhiy.storchaka -> stage: committed/rejected -> ___ Python tracker ___ ___ Python-bugs-l

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Brian Curtin
Brian Curtin added the comment: Benjamin probably has the final say on backporting this to 2.7. I'm doing the 3.3/default commit right now. -- nosy: +brian.curtin ___ Python tracker ___

[issue18528] Possible fd leak in socketmodule

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: Am 22.07.2013 16:00, schrieb Antoine Pitrou: > Have you tried to reset errno at the beginning of the function? It doesn't affect Coverity's report: BEGIN_SELECT_LOOP(s) Py_BEGIN_ALLOW_THREADS +errno = 0; timeout = internal_select_ex(s, 0, i

[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Larry, you forgot to remove "#undef HAVE_FDOPENDIR" at the start of the file. Beside this line the patch LGTM. I withdraw my objections in msg190887 because `close(fd)` can fail and change errno. -- ___ Python tra

[issue18528] Possible fd leak in socketmodule

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: This patch does the trick. -- Added file: http://bugs.python.org/file31016/closesock3.patch ___ Python tracker ___ ___

[issue18181] PEP447: Add type.__locallookup__

2013-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: The crash was due to a bug in the test extension. Fixed in version 2b. -- title: Add type.__locallookup__ -> PEP447: Add type.__locallookup__ Added file: http://bugs.python.org/file31014/issue-18181-full-v2b.txt ___

[issue18528] Possible fd leak in socketmodule

2013-07-22 Thread Christian Heimes
Changes by Christian Heimes : Removed file: http://bugs.python.org/file31007/closesock2.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: LGTM -- nosy: +christian.heimes stage: -> patch review type: -> resource usage versions: +Python 3.3, Python 3.4 ___ Python tracker ___

[issue18528] Possible fd leak in socketmodule

2013-07-22 Thread Christian Heimes
Changes by Christian Heimes : Removed file: http://bugs.python.org/file31004/closesock.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue18191] urllib2/urllib.parse.splitport does not handle IPv6 correctly

2013-07-22 Thread Samwyse
Samwyse added the comment: Handles "raw" IPv6 URLs -- Added file: http://bugs.python.org/file31015/urllib.diff ___ Python tracker ___

[issue18191] urllib2/urllib.parse.splitport does not handle IPv6 correctly

2013-07-22 Thread Samwyse
Samwyse added the comment: Fixes Serhiy Storchaka's complaints, removes duplicate test. -- nosy: +samwyse Added file: http://bugs.python.org/file31013/test_urlparse.diff ___ Python tracker _

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Alex Gaynor
Alex Gaynor added the comment: Attached patch is against default. I don't have my ssh keys set up for this machine, so if someone else could land I'd be appreciative :) (Not sure if this qualifies for a backport) -- Added file: http://bugs.python.org/file31012/ismount-3k.diff

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Alex Gaynor
Alex Gaynor added the comment: Addresses the review comments: returns to catching all oserrors -- Added file: http://bugs.python.org/file31011/ismount.diff ___ Python tracker ___

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Alex Gaynor
Alex Gaynor added the comment: Attached is a simple first pass at a diff against 2.7, shoudl be easy to port it to default. -- keywords: +patch Added file: http://bugs.python.org/file31010/ismount.diff ___ Python tracker

[issue12669] test_curses skipped on buildbots

2013-07-22 Thread Ronald Oussoren
Changes by Ronald Oussoren : -- versions: +Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue18530] posixpath.ismount performs extra lstat calls

2013-07-22 Thread Alex Gaynor
New submission from Alex Gaynor: Right now it calls islink(), which does an lstat, and then does its own lstat on the same path. This can be optimized by inlining the body of islink and reusing the stat result. (This has been identified as an actual issue in openstack-swift https://review.ope

[issue16964] Add 'm' format specifier for mon_grouping etc.

2013-07-22 Thread Matthew Barnett
Matthew Barnett added the comment: I've attached my attempt at a patch. -- keywords: +patch nosy: +mrabarnett Added file: http://bugs.python.org/file31009/issue16964.patch ___ Python tracker ___

[issue18418] Thread.isAlive() sometimes True after fork

2013-07-22 Thread A. Jesse Jiryu Davis
A. Jesse Jiryu Davis added the comment: Bump. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue18181] Add type.__locallookup__

2013-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: issue-18181-full-v2.txt adds more tests to v1 and has slightly better documentation (still not good enough). A major issue with the patch: for some reason the tests pass when run standalone ("./python.exe -m test.regrtest test_pep447"), but crash when I run

[issue15805] Add stdout redirection tool to contextlib

2013-07-22 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: In general, I like where this is going. I agree that a stdout redirector is probably the most common case, and for that, it almost always (for me) redirects to an open file. The use case for stderr redirection is usually, but not always, to redirect stderr to

[issue18528] Possible fd leak in socketmodule

2013-07-22 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Coverity may not understand the interaction with errno at all. Or it > may simple point out that some operating systems are not standard > conform and our assumption is not universally true. Have you tried to reset errno at the beginning of the function?

[issue18528] Possible fd leak in socketmodule

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: Coverity may not understand the interaction with errno at all. Or it may simple point out that some operating systems are not standard conform and our assumption is not universally true. Here is a patch that raises an exception when newfd != INVALID_SOCKET.

[issue18529] Use long dash

2013-07-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is an alternative patch which replaces spaced hyphens and en-dashes and non-spaced em-dashes to em-dashes with spaces. -- assignee: -> docs@python components: +Documentation nosy: +docs@python stage: -> patch review type: -> enhancement versio

[issue18529] Use long dash

2013-07-22 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Currently Python documentation uses four type of dashes for same meaning: 1. Hyphen with spaces. 2. En-dash with spaces. 3. Em-dash with spaces. 4. Em-dash without spaces. Definitely the first case is just wrong and other three cases should be unified. Her

[issue18528] Possible fd leak in socketmodule

2013-07-22 Thread Antoine Pitrou
Antoine Pitrou added the comment: What if you add "errno = 0" at the beginning of the function? Perhaps Coverity is confused by the fact that we use CHECK_ERRNO() to infer whether accept() succeeded or not, rather than simply checking the return value. I don't like your patch, because it adds

[issue18528] Possible fd leak in socketmodule

2013-07-22 Thread Christian Heimes
Changes by Christian Heimes : -- nosy: +pitrou, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18528] Possible fd leak in socketmodule

2013-07-22 Thread Christian Heimes
New submission from Christian Heimes: Coverity claims that sock_accept() may leak a fd. I have been starring at the code for a while and I'm still not sure if Coverity is right. The macros make the code paths hard to follow. The attached patch is simple and should not be a performance issue.

[issue17933] format str bug in urllib request.py

2013-07-22 Thread Rock Lee
Rock Lee added the comment: Any progress for this issue? I changed the title of the issue. -- title: test_ftp failure / ftplib error formatting issue -> format str bug in urllib request.py ___ Python tracker

[issue5120] Change _tkinter initialization for new versions of Aqua Tk on OS X

2013-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: As mentioned by Ned this is a duplicate of #8716. The proposed change to tkinter initialization in msg81468 might be useful to look into, but I'm not interested in doing that work because I don't use Tkinter myself which makes it harder to test if the change

[issue15905] Copy to fixed size buffer w/o check in sys_update_path

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: Thanks! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue15905] Copy to fixed size buffer w/o check in sys_update_path

2013-07-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset dca92e8a011a by Christian Heimes in branch '3.3': Issue #15905: Fix theoretical buffer overflow in handling of sys.argv[0], http://hg.python.org/cpython/rev/dca92e8a011a New changeset 01597384531f by Christian Heimes in branch 'default': Issue #1590

[issue4079] new urllib2.Request 'timeout' attribute needs to have a default

2013-07-22 Thread Indra Talip
Indra Talip added the comment: patch adds regressions tests to ensure timeout value from OpenerDirector is honoured and a failing test for a default value for Request.timeout that passes when the patch that initialises Request.timeout is applied. -- Added file: http://bugs.python.org/f

[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: Preferable both but Coverity Scan uses only trunk. We could commit the patch to trunk first and test if Coverity still detects the leak. -- ___ Python tracker __

[issue18525] Shutil cannot import WindowsError on windows

2013-07-22 Thread Saurabh Gupta
Saurabh Gupta added the comment: Thank you all for your inputs! Now I understand what the issue really is & would be fixing it by removing the imports in the legacy software. I agree with the won't fix resolution of the ticket. -- ___ Python tracker

[issue15905] Copy to fixed size buffer w/o check in sys_update_path

2013-07-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Agree. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-22 Thread Larry Hastings
Larry Hastings added the comment: Patch for 3.3. or trunk? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue15905] Copy to fixed size buffer w/o check in sys_update_path

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: Good point, but I think it should be `q[MAXPATHLEN + 1] = L'\0';`. -- ___ Python tracker ___ ___ P

[issue18527] Upgrade Modules/zlib to 1.2.8

2013-07-22 Thread Christian Heimes
New submission from Christian Heimes: According to http://hg.python.org/cpython/file/878dc9dfc565/Modules/zlib/ChangeLog our repository has zlib 1.2.5. zlib 1.2.8 is out for a while, http://zlib.net/ I'd like to update our copy of zlib to 1.2.8. -- assignee: christian.heimes component

[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: I'd like to have a patch by tonight. This issue is one of two remaining bugs that are considered "high impact" by Coverity Scan. The other one looks like a false positive. I have an interview with Coverity tomorrow about the development style and quality of

[issue18525] Shutil cannot import WindowsError on windows

2013-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: I agree that this should be closed. -- resolution: -> wont fix status: open -> closed versions: +Python 2.7, Python 3.3 ___ Python tracker ___

[issue18525] Shutil cannot import WindowsError on windows

2013-07-22 Thread Tim Golden
Tim Golden added the comment: Really this should be a wont-fix: the fact that it's possible to import WindowsError from shutil (on Linux) is an accident of its internal implementation. It's certainly not documented as such. Saurabh: WindowsError is a builtin on Windows. If you want to mimic sh

[issue18525] Shutil cannot import WindowsError on windows

2013-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: WindowsError is not part of the documented interface of shutil, but is an implementation detail. "from shutil import WindowsUtil" works on Unix platforms because shutil contains a compatibility definition: try: WindowsError except NameError: WindowsE

[issue18525] Shutil cannot import WindowsError on windows

2013-07-22 Thread Saurabh Gupta
Saurabh Gupta added the comment: I have a legacy software that has things like: try: some stuff except OSError, why: if WindowsError is not None and isinstance(why, WindowsError): do something else: do something else So I'd ideally like to

[issue18525] Shutil cannot import WindowsError on windows

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: Seems legit ... I don't have access to a Windows system right now so I can't test it. WindowsError is globally available on Windows. You don't have to import it from shutil. Portable application should use OSError instead of WindowsError. WindowsError is a

[issue18525] Shutil cannot import WindowsError on windows

2013-07-22 Thread Saurabh Gupta
Saurabh Gupta added the comment: And, the same thing on linux: >>> import shutil >>> print shutil.__file__ /software/package/linux64_centos6/python/2.6.7/lib/python2.6/shutil.pyc >>> print dir(shutil) ['Error', 'WindowsError', '__all__', '__builtins__', '__doc__', '__file__', '__n ame__', '__pac

[issue18525] Shutil cannot import WindowsError on windows

2013-07-22 Thread Saurabh Gupta
Saurabh Gupta added the comment: >>> import shutil >>> shutil.__file__ 'C:\\Python26\\lib\\shutil.pyc' >>> dir(shutil) ['Error', '__all__', '__builtins__', '__doc__', '__file__', '__name__', '__package__', '_basename', '_samefile', 'abspath', 'copy', 'copy2', 'copyfile', 'copyfileobj', 'copymod

[issue18524] BufferedReader.read1() documentation/implementation difference

2013-07-22 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +benjamin.peterson, hynek, pitrou, serhiy.storchaka, stutzbach ___ Python tracker ___ ___ Pytho

[issue18525] Shutil cannot import WindowsError on windows

2013-07-22 Thread Christian Heimes
Christian Heimes added the comment: Please open an interactive interpreter shell and show us the output of import shutil print shutil.__file__ print dir(shutil) -- nosy: +christian.heimes ___ Python tracker __

[issue1687125] cannot catch KeyboardInterrupt when using curses getkey()

2013-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: I cannot reproduce this with a recent 2.7 build from mercurial, but can reproduce with /usr/bin/python (2.7.2) on OSX 10.8 and python 2.7.3 on Centos 6.4 system. -- nosy: +ronaldoussoren versions: +Python 2.7 -Python 2.6 _

[issue18510] dict.__contains__ and dict.keys().__contains__ raises exception instead of returning False

2013-07-22 Thread Ronald Oussoren
Ronald Oussoren added the comment: I agree, and the thread on python-dev[1] also came to that conclusion, I'm therefore closing this issue. [1] http://code.activestate.com/lists/python-dev/123385/ -- resolution: -> invalid stage: -> committed/rejected status: open -> closed

[issue18510] dict.__contains__ and dict.keys().__contains__ raises exception instead of returning False

2013-07-22 Thread Raymond Hettinger
Raymond Hettinger added the comment: There's no bug here. It is the way Python has worked for 23 years. -- nosy: +rhettinger versions: -Python 2.7, Python 3.2, Python 3.3 ___ Python tracker __