[issue18989] reuse of enum names in class creation inconsistent

2013-09-14 Thread Georg Brandl
Georg Brandl added the comment: It can be changed up to beta1, with good reasons of course. Many PEPs are actually out of date with respect to the actual implementation in minor points. -- nosy: +georg.brandl ___ Python tracker

[issue18989] reuse of enum names in class creation inconsistent

2013-09-14 Thread Georg Brandl
Georg Brandl added the comment: That said, for a PEP that has seen so much discussion before being accepted, the agreed-on API should not be changed lightly. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18989

[issue18968] Find a way to detect incorrectly skipped tests

2013-09-14 Thread Xavier de Gaye
Changes by Xavier de Gaye xdeg...@gmail.com: -- nosy: +xdegaye ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18968 ___ ___ Python-bugs-list

[issue16248] Security bug in tkinter allows for untrusted, arbitrary code execution.

2013-09-14 Thread Georg Brandl
Georg Brandl added the comment: Should be fixed now in 3.2 too. -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16248 ___

[issue16248] Security bug in tkinter allows for untrusted, arbitrary code execution.

2013-09-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset c18c18774e24 by Georg Brandl in branch '3.2': Fix tkinter regression introduced by the security fix in #16248. http://hg.python.org/cpython/rev/c18c18774e24 -- ___ Python tracker rep...@bugs.python.org

[issue18993] There is an overshadowed and invalid test in testmock.py

2013-09-14 Thread Xavier de Gaye
Xavier de Gaye added the comment: The duplicate_code_names.py script in issue 16079 did find that there are duplicate test_attribute_deletion tests in testmock.py (see http://bugs.python.org/file27376/std_lib_duplicates.txt). -- nosy: +xdegaye ___

[issue18907] urllib2.open FTP open times out at 20 secs despite timeout parameter

2013-09-14 Thread Charles-François Natali
Changes by Charles-François Natali cf.nat...@gmail.com: -- status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18907 ___ ___

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4238)

2013-09-14 Thread Georg Brandl
Georg Brandl added the comment: Christian, is the -py32 patch still up to date? -- nosy: +larry priority: critical - release blocker ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18709 ___

[issue16201] socket.gethostbyname incorrectly parses ip

2013-09-14 Thread Charles-François Natali
Charles-François Natali added the comment: Alright, I committed it to default. I don't think it should go into 2.7 or 3.3, since it's more an enhancement than a bug fix. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16201

[issue18825] Making msg optional on logging.exception() and similar variants

2013-09-14 Thread Vinay Sajip
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: -- status: pending - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18825 ___ ___

[issue18824] Adding LogRecord attribute traceback

2013-09-14 Thread Vinay Sajip
Vinay Sajip added the comment: basicConfig() is for simple usage only. You can use a custom Formatter subclass to meet your specific requirements. -- nosy: +vinay.sajip resolution: - invalid status: open - closed ___ Python tracker

[issue18993] There is an overshadowed and invalid test in testmock.py

2013-09-14 Thread Michael Foord
Michael Foord added the comment: On balance I think that this test failing is *correct* (after deleting an attribute the old mock should *not* come back). I'd rather adjust the test to assert this than just remove it though. -- ___ Python tracker

[issue18993] There is an overshadowed and invalid test in testmock.py

2013-09-14 Thread Vajrasky Kok
Vajrasky Kok added the comment: Michael, attached the patch to accommodate your request. Yeah, I think this is the best way because I have seen no possible solutions to make both tests work without altering them. Xavier, that's cool. I didn't know such tool exists. Usually I found the

[issue16248] Security bug in tkinter allows for untrusted, arbitrary code execution.

2013-09-14 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: Fix still needs to be applied on 3.1 branch. -- priority: deferred blocker - release blocker status: closed - open versions: +Python 3.1 -Python 3.2 ___ Python tracker rep...@bugs.python.org

[issue19016] autospecced namedtuples should be truthy by default

2013-09-14 Thread Shawn Krisman
New submission from Shawn Krisman: import mock from collections import namedtuple Foo = namedtuple('Foo', bar) mock_foo = mock.create_autospec(Foo) if mock_foo: print('the namedtuple is truthy') else: print('the namedtuple is not truthy') The expected behavior is that it should print

[issue18989] reuse of enum names in class creation inconsistent

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le samedi 14 septembre 2013 à 07:03 +, Georg Brandl a écrit : Georg Brandl added the comment: That said, for a PEP that has seen so much discussion before being accepted, the agreed-on API should not be changed lightly. I agree with that. Also, I think

[issue1602] windows console doesn't print or input Unicode

2013-09-14 Thread Drekin
Drekin added the comment: Hello again. I have rewritten the custom stdio objects and implemented them as raw io reading and writing bytes in UTF-16-LE encoding. They are then wrapped in standard BufferedReader/Writer and TextIOWrapper objects. This approach also solves a bug of wrong string

[issue19017] selectors: towards uniform EBADF handling

2013-09-14 Thread Charles-François Natali
New submission from Charles-François Natali: Currently, in case of invalid file descriptor (which can happen easily e.g. if the user closes the FD before unregistering it), selector.select() will react differently depending on the backend: SelectSelector fails with EBADF PollSelector returns

[issue19017] selectors: towards uniform EBADF handling

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Another possibility would be to silently fix those, i.e. in case of EBADF/POLLNVAL in select/poll, remove the offending FD from the list of monitored FDs. Or we could remove the fd *and* still raise an error the first time, or at least a warning. It sounds

[issue19017] selectors: towards uniform EBADF handling

2013-09-14 Thread Charles-François Natali
Charles-François Natali added the comment: Or we could remove the fd *and* still raise an error the first time, or at least a warning. It sounds like a programming error, so I'm not sure it's a good idea to silence it. Yeah, sure. By silently I meant without user intervention, sorry for

[issue19017] selectors: towards uniform EBADF handling

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Now I'm not sure between raising an error or just logging it. If logged, it should be a Warning rather than an actual logging call, IMO. -- ___ Python tracker rep...@bugs.python.org

[issue16201] socket.gethostbyname incorrectly parses ip

2013-09-14 Thread Charles-François Natali
Charles-François Natali added the comment: Closing, thanks for the report! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed versions: -Python 2.7, Python 3.3 ___ Python tracker rep...@bugs.python.org

[issue13758] compile() should not encode 'filename' (at least on Windows)

2013-09-14 Thread Drekin
Drekin added the comment: Since this issue was fixed, shouldn't it be marked fixed here? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13758 ___

[issue18989] reuse of enum names in class creation inconsistent

2013-09-14 Thread Eli Bendersky
Eli Bendersky added the comment: On Fri, Sep 13, 2013 at 7:11 PM, Nick Coghlan rep...@bugs.python.orgwrote: Nick Coghlan added the comment: +1 from me to just allow the names to be overwritten, even by another enum member. Even though I was in favor of this in the initial discussions

[issue18059] Add multibyte encoding support to pyexpat

2013-09-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: 1) Expat itself responsible for this guard. It has all necessary information and provides an input of required size for custom converter. 2) Yes, this is a problem. I'm working on another approach, when full encoding table built at first request for the

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4238)

2013-09-14 Thread Charles-François Natali
Changes by Charles-François Natali cf.nat...@gmail.com: -- nosy: -neologix ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18709 ___ ___

[issue13758] compile() should not encode 'filename' (at least on Windows)

2013-09-14 Thread STINNER Victor
STINNER Victor added the comment: Closed. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13758 ___

[issue18986] Add a case-insensitive case-preserving dict

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Note: I haven't renamed transformdict to TransformDict yet. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18986 ___

[issue18986] Add a case-insensitive case-preserving dict

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Updated patch adding the getitem() method. -- Added file: http://bugs.python.org/file31757/transformdict2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18986

[issue11798] Test cases not garbage collected after run

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'd rather not propagate more options all the way through, especially as this is some thing that should be decided by the test framework and is unlikely to be something you want to turn on and off per test run (which is what command line options are for).

[issue11798] Test cases not garbage collected after run

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: For the record, this change broke the --forever option in Tulip's test script, which is why I'm caring. Setting the _cleanup flag to False seems to restore old behaviour, except that _cleanup is (obviously) a private API. --

[issue11798] Test cases not garbage collected after run

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Note: ideally, the --forever flag wouldn't reuse TestCase instances but rather create new ones. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11798 ___

[issue18022] Inconsistency between quopri.decodestring() and email.quoprimime.decode()

2013-09-14 Thread R. David Murray
R. David Murray added the comment: As I said, not exactly any of the above. I'll get back to this after I finish the new email code (which should happen before the end of the month). I need to take some time to look over the RFCs and real world examples and come up with the most appropriate

[issue19012] liburl2: bad proxy configuration throws getaddrinfo error

2013-09-14 Thread R. David Murray
R. David Murray added the comment: The getaddrinfo error message should *not* refer to proxies, because getaddrinfo does not do anything involving proxy configuration. Presumably the error occurred when liburl2 tried to resolve the proxy. So, it is liburl2 that needs to make sure that

[issue18989] reuse of enum names in class creation inconsistent

2013-09-14 Thread Nick Coghlan
Nick Coghlan added the comment: OK, rechecking PEP 435, I see that disallowing reuse of a name was indeed explicitly accepted as part of the defined API: http://www.python.org/dev/peps/pep-0435/#duplicating-enum-members-and-values In that case, I switch my perspective to agree with Ethan that

[issue19017] selectors: towards uniform EBADF handling

2013-09-14 Thread STINNER Victor
STINNER Victor added the comment: Would it be possible to emit an event invalid fd with the fd? So the user can decide what to do on such case: ignore, log, raise an exception, ... -- ___ Python tracker rep...@bugs.python.org

[issue18907] urllib2.open FTP open times out at 20 secs despite timeout parameter

2013-09-14 Thread John Nagle
John Nagle added the comment: The server operator at the US Securities and Exchange Commission writes to me: There was a DNS issue that affected the availability of FTP at night. We believe it is resolved. Please let us know if you encounter any further problems. Thanks, SEC Webmaster. So

[issue18206] The license url in site.py should always use X.Y.Z form of version number

2013-09-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7c18b799841e by R David Murray in branch '3.3': #18206: Fix test for existence of license URL. http://hg.python.org/cpython/rev/7c18b799841e New changeset 321c3c9cd1b5 by R David Murray in branch 'default': Merge #18206: Fix test for existence of

[issue18206] The license url in site.py should always use X.Y.Z form of version number

2013-09-14 Thread R. David Murray
R. David Murray added the comment: You are right, there was a further typo in the 3.4 URL that I missed. Yes, requires_resource('network') is what I was referring to (though using transient_internet is also a very good idea :). I also changed the urllib call to only do a HEAD request. No

[issue18937] add unittest assertion for logging

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: David told me he was in favour of keeping INFO the default, so I'll leave it like that. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18937 ___

[issue18937] add unittest assertion for logging

2013-09-14 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18937 ___

[issue18937] add unittest assertion for logging

2013-09-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4f5815747f58 by Antoine Pitrou in branch 'default': Issue #18937: Add an assertLogs() context manager to unittest.TestCase to ensure that a block of code emits a message using the logging module. http://hg.python.org/cpython/rev/4f5815747f58

[issue18206] The license url in site.py should always use X.Y.Z form of version number

2013-09-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks for making these changes (and correcting some of my mistakes), RDM. They are much better now. On Sat, Sep 14, 2013 at 10:38 AM, R. David Murray rep...@bugs.python.orgwrote: R. David Murray added the comment: You are right, there was a further typo

[issue18059] Add multibyte encoding support to pyexpat

2013-09-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a totally rewritten patch, which builds decoding table at first request for encoding and save it in the cache. Decoding should be very fast. Do you have large testing XML files with multibyte encodings? Could you please measure the time of parsing

[issue18059] Add multibyte encoding support to pyexpat

2013-09-14 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file31758/pyexpat_multibyte_encodings.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18059 ___

[issue18059] Add multibyte encoding support to pyexpat

2013-09-14 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file31759/pyexpat_multibyte_encodings_5.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18059 ___

[issue19018] Heapq.merge suppreses IndexError from user generator

2013-09-14 Thread Artem Fokin
New submission from Artem Fokin: Suppose we have the following code: from heapq import merge def iterable(): lst = range(10) for i in xrange(20): yield lst[i] it1, it2= iterable(), iterable() print list(merge(it1, it2)) # no IndexError

[issue18945] Name collision handling in tempfile is not covered by tests

2013-09-14 Thread Benjamin Peterson
Benjamin Peterson added the comment: I don't object to adding the tests. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18945 ___ ___

[issue19018] Heapq.merge suppreses IndexError from user generator

2013-09-14 Thread Artem Fokin
Changes by Artem Fokin ar.fo...@gmail.com: -- versions: -3rd party, Python 2.6, Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19018 ___

[issue19018] Heapq.merge suppreses IndexError from user generator

2013-09-14 Thread Artem Fokin
Artem Fokin added the comment: Oh, it seems that in current cpython branch this problem is fixed by checking condition _len(h) 1: http://hg.python.org/cpython/file/1dc925ee441a/Lib/heapq.py#l373 But is it possible to fix it for the previous branches? --

[issue19018] Heapq.merge suppreses IndexError from user generator

2013-09-14 Thread Antoine Pitrou
Changes by Antoine Pitrou pit...@free.fr: -- nosy: +rhettinger, stutzbach ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19018 ___ ___

[issue19019] Investigate using Apple clang for building OS X installers

2013-09-14 Thread Ned Deily
New submission from Ned Deily: On the python-dev mailing list, Raymond Hettinger asks: I was exercising the alpha two release of 3.4 and noticed that it is still being built under GCC 4.2.1. Is there any reason we have to use an old compiler? Yes, kinda. It's because the 64-bit/32-bit

[issue19018] Heapq.merge suppreses IndexError from user generator

2013-09-14 Thread R. David Murray
R. David Murray added the comment: It was checked in as an optimization, but if it fixes a bug I don't see why it couldn't be backported. A unit test would be helpful, if you feel like writing one. -- nosy: +r.david.murray versions: -Python 3.1, Python 3.2

[issue19018] Heapq.merge suppreses IndexError from user generator

2013-09-14 Thread Raymond Hettinger
Raymond Hettinger added the comment: This seems like a good reason for a backport. Add a unittest and I'll take care of the rest. -- assignee: - rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19018

[issue19018] Heapq.merge suppreses IndexError from user generator

2013-09-14 Thread Artem Fokin
Artem Fokin added the comment: Which branch should I add a unit-test to? Here is a patch that adds a unit-test to the current one. -- keywords: +patch Added file: http://bugs.python.org/file31760/unittest_patch.diff ___ Python tracker

[issue18986] Add a case-insensitive case-preserving dict

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Uploading new patch with added transform_func property. -- Added file: http://bugs.python.org/file31761/transformdict3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18986

[issue11798] Test cases not garbage collected after run

2013-09-14 Thread Michael Foord
Michael Foord added the comment: Can that be fixed in tulip? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11798 ___ ___ Python-bugs-list

[issue11798] Test cases not garbage collected after run

2013-09-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Yes, but that's not the point. Legitimate use cases can be broken by the change, so at least there should be an easy way to disable the new behaviour. -- ___ Python tracker rep...@bugs.python.org

[issue19020] Regression: Windows-tkinter-idle, unicode, and 0xxx filename

2013-09-14 Thread Terry J. Reedy
New submission from Terry J. Reedy: Current 3.3.2+ repository build (32 bit) and 3.4.0a2 repository build (32 bit) and installation (64 bit) have a problem that did not exist in my Win6 3.3.2 installation (64 bit). (Bruce Sherwood discovered the symption with some installed version of

[issue6699] IDLE: Warn user about overwriting a file that has a newer version on filesystem

2013-09-14 Thread Terry J. Reedy
Changes by Terry J. Reedy tjre...@udel.edu: -- nosy: +bsherwood ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue6699 ___ ___ Python-bugs-list

[issue19021] AttributeError in Popen.__del__

2013-09-14 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Sometimes closing IDLE I got such exception: Exception ignored in: bound method Popen.__del__ of subprocess.Popen object at 0xb5b8618c Traceback (most recent call last): File /home/serhiy/py/cpython/Lib/subprocess.py, line 890, in __del__ TypeError:

[issue19020] Regression: Windows-tkinter-idle, unicode, and 0xxx filename

2013-09-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps this is caused by issue18101. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19020 ___ ___

[issue18856] Added test coverage for calendar print functions

2013-09-14 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the patch! -- assignee: - ezio.melotti resolution: - fixed stage: patch review - committed/rejected status: open - closed versions: -Python 2.7 ___ Python tracker rep...@bugs.python.org

[issue18856] Added test coverage for calendar print functions

2013-09-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 442e23bbec48 by Ezio Melotti in branch '3.3': #18856: improve test coverage of the calendar module. Patch by Madison May. http://hg.python.org/cpython/rev/442e23bbec48 New changeset 81da2ed0c563 by Ezio Melotti in branch 'default': #18856: merge

[issue18995] Enum does not work with reversed

2013-09-14 Thread Ethan Furman
Ethan Furman added the comment: Well, I totally messed up the commit message, but the code is now in place. Thanks, Vajrasky Kok! -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker

[issue18929] inspect.classify_class_attrs ignores metaclass

2013-09-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset b0517bb271ad by Ethan Furman in branch 'default': Close #18929: inspect.classify_class_attrs will now search the metaclasses (last) to find where an attr was defined. http://hg.python.org/cpython/rev/b0517bb271ad -- nosy: +python-dev

[issue18693] help() not helpful with enum

2013-09-14 Thread Ethan Furman
Ethan Furman added the comment: Okay, here's the patch after the inspect portion was committed in #18929. Summary: - added __objclass__ to each enum member - added __module__ to the class dir - aded any extra methods defined to the instance dir - changed _RouteClassAttributeToGetattr to

[issue19018] Heapq.merge suppreses IndexError from user generator

2013-09-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0ff5bb61c6a1 by Raymond Hettinger in branch '3.3': Issue #19018: The heapq.merge() function no longer suppresses IndexError http://hg.python.org/cpython/rev/0ff5bb61c6a1 -- nosy: +python-dev ___ Python

[issue18958] Exception('No JSON object could be decoded') when parsing a valid JSON

2013-09-14 Thread Anoop Thomas Mathew
Anoop Thomas Mathew added the comment: Patch for BOM signature documentation in json.loads -- keywords: +patch nosy: +Anoop.Thomas.Mathew Added file: http://bugs.python.org/file31764/json_BOM_signature_documentation.patch ___ Python tracker

[issue11344] Add os.path.splitpath(path) function

2013-09-14 Thread Martin Panter
Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11344 ___ ___ Python-bugs-list

[issue16650] Popen._internal_poll() references errno.ECHILD outside of the local scope

2013-09-14 Thread Terry J. Reedy
Changes by Terry J. Reedy tjre...@udel.edu: -- versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16650 ___ ___ Python-bugs-list

[issue16650] Popen._internal_poll() references errno.ECHILD outside of the local scope

2013-09-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: sorry for noise -- nosy: +terry.reedy versions: +Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16650 ___

[issue19021] AttributeError in Popen.__del__

2013-09-14 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com: -- nosy: +Arfrever ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19021 ___

[issue19018] Heapq.merge suppreses IndexError from user generator

2013-09-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 56a3c0bc4634 by Raymond Hettinger in branch '2.7': Issue #19018: The heapq.merge() function no longer suppresses IndexError http://hg.python.org/cpython/rev/56a3c0bc4634 -- ___ Python tracker

[issue12085] subprocess.Popen.__del__ raises AttributeError if __init__ was called with an invalid argument list

2013-09-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: I think this patch is a false solution and should be reverted. Oleg should have been told to use sys.version to make the correct call. Given how Python is, that is the correct solution to his problem. The result of this patch is #19021: an AttributeError on

[issue19018] Heapq.merge suppreses IndexError from user generator

2013-09-14 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19018 ___

[issue12085] subprocess.Popen.__del__ raises AttributeError if __init__ was called with an invalid argument list

2013-09-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: The same issue arises when an exception is raised during the __init__ execution, rather than in the call argument match phase, and the exception is caught. class C(): def __init__(self): self.a = self.b def __del__(self): self.a try: C() except

[issue19021] AttributeError in Popen.__del__

2013-09-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: The condition was changed from self._child_created to the getattr call in #12085. As explained in msg197748, I think that change should be reverted (and this issue closed). I think elaborating a bad patch only makes it worse. --