Terry J. Reedy added the comment:
For me, FLAT is about as mushy as the default, while SOLID actually looks like
a divider. I find the sash easier to 'grab' and move. I plan to go with that.
If it looks substantially worse on some other system, we could make the
argument conditional on
Terry J. Reedy added the comment:
I plan to commit the sash patch before reviewing this. I would wait until then
to do a separate patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21933
Terry J. Reedy added the comment:
MOUSEWHEEL should continue to scroll.
CONTROL+MOUSEWHEEL should change font size, as you said at the beginning.
At least on Windows, this seems pretty standard: Internet Explorer, Firefox,
Notepad++, LibreOffice (and, I imagin, OpenOffice, and Word),
Lita Cho added the comment:
Sounds good. I can wait till the sash code gets incorporated in order to
add in the font code.
I would have to generate a MOUSEWHEEL event and see if it fails. I have
generated mouse clicks before. I'll try to see if I can generate a
MOUSEWHEEL event and if it
Ned Deily added the comment:
Lita, I tried the patch. From the perspective of an OS X user, while I might
expect that using the zoom gesture on a mousepad or using a mousewheel (the
equivalent) to increase or decrease the font size, I would even more expect
scrolling to work especially if
Lita Cho added the comment:
I completely agree about the mousewheel. However, would it make sense for
OS X to combine command with mousewheel? I have never seen that before. I
am not sure if I can bind the zoom gesture with tkinter, but I can find
out.
I also think the shortcuts are not
Changes by Ned Deily n...@acm.org:
--
nosy: +steve.dower, zach.ware
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22028
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
See also issue15381.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22003
___
___
Python-bugs-list mailing
Ned Deily added the comment:
On OS X, the actions associated with trackpad gestures are controlled by the
Trackpad panel of System Preferences. The default settings map the pinch with
two fingers gesture to Zoom in or out which Tk apps see as Mousewheel
events: no programming needed!
Roundup Robot added the comment:
New changeset 4b98961748f1 by Senthil Kumaran in branch '3.4':
Fix localhost checking in FileHandler. Raised in #21970.
http://hg.python.org/cpython/rev/4b98961748f1
New changeset 2c660948bb41 by Senthil Kumaran in branch 'default':
Merge 3.4
Senthil Kumaran added the comment:
I have addressed the mistake where req.host is self.get_names() was done
instead of req.host in self.get_names() in the first commit as it was an
obvious problem.
I will come up with patch/solution addressing the other behavior mentioned in
this report.
Lita Cho added the comment:
What really? That is so awesome! I will check that out!
However, I figure I still need to create separate bindings for Linux,
Windows and Mac, right? Or does Tkinter unify all the mousewheel events?
Lita
On Tue, Jul 22, 2014 at 12:18 AM, Ned Deily
New submission from Raymond Hettinger:
Victor, how does this look?
--
assignee: haypo
files: set_calloc.diff
keywords: patch
messages: 223638
nosy: haypo, rhettinger
priority: normal
severity: normal
stage: patch review
status: open
title: Use calloc in set resizing
type: performance
Ned Deily added the comment:
However, I figure I still need to create separate bindings for Linux,
Windows and Mac, right? Or does Tkinter unify all the mousewheel events?
I'm not sure I understand: I think that Tk only provides one MouseWheel event
binding. Keyboard or menu items might
STINNER Victor added the comment:
Be careful. In my tests, calloc() was slower than malloc() + memset() for
memory blocks smaller than 1 MB. Calloc() can be interesting if only a few
pages (4096 bytes) are modified.
You must provide benchmarks.
--
STINNER Victor added the comment:
See also issue #21644 (bytearray).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22030
___
___
STINNER Victor added the comment:
See also issue #22030 (set).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21644
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 10b83036c723 by Serhiy Storchaka in branch '3.4':
Issue #15759: make suspicious, make linkcheck and make doctest in Doc/
http://hg.python.org/cpython/rev/10b83036c723
New changeset c755a3b58fa6 by Serhiy Storchaka in branch 'default':
Issue #15759:
Roundup Robot added the comment:
New changeset 51699f5f5430 by Serhiy Storchaka in branch '2.7':
Backout 308f3c1e36d3. This change (issue21044) does not need to be merged on
http://hg.python.org/cpython/rev/51699f5f5430
--
___
Python tracker
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22030
___
Serhiy Storchaka added the comment:
Thanks Zachary for pointing to buildbot failure.
Also, Serhiy, I think you may have got me mixed up with someone else.
Indeed, I either missed you with Antoine Pietri or missed this issue with
issue19524. In any case thanks you for your activity on the
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: docs@python - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15759
Lita Cho added the comment:
Oh I see. And then pinch on the trackpad just generates a overall MouseWheel
event, not a specific zoom-in event. For some reason, I thought there was a
different event depending on operating systems. Before, Linux would trigger
Button-4 and Button-5 events and not
New submission from Serhiy Storchaka:
Default repr of an instance looks as:
object()
object object at 0xb71a14a8
Many specialized reprs follow a pattern ... at {hexadecimal id} But there
are few deviations:
1. Reprs of WeakValueDictionary and WeakKeyDictionary in the weakref module
STINNER Victor added the comment:
The patch looks good to me.
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22031
___
___
New submission from Serhiy Storchaka:
Often when class name is reported in stdlib (e.g. in reprs), it used together
with module name: '%s.%s' % (self.__class__.__module__,
self.__class__.__name__). But this code is wrong when a class is nested. The
__qualname__ attribute should be used
New submission from Serhiy Storchaka:
Some reprs in stdlib are subclass friendly. They contains class name or even
fully qualified class name and substitute appropriate subclass name in
subclasses. But some reprs contains hardcoded either class name, or module
name, or fully qualified class
STINNER Victor added the comment:
The patch looks good to me.
For Python 3.4, may it break the backward compatibility? For example, breaking
doctests relying on the exact representation? If there is a risk, it's maybe
safer to only modify Python 3.5.
--
nosy: +haypo
Roundup Robot added the comment:
New changeset 4cef7b0ec659 by Serhiy Storchaka in branch 'default':
Issue #22031: Reprs now always use hexadecimal format with the 0x prefix
http://hg.python.org/cpython/rev/4cef7b0ec659
--
nosy: +python-dev
___
Serhiy Storchaka added the comment:
Thanks Victor. Applied only in default because this issue is too minor.
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker
New submission from Serhiy Storchaka:
posixpath.join() raises misleading exception in case when all arguments are
bytearrays:
import posixpath
posixpath.join(bytearray(b'foo'), bytearray(b'bar'))
Traceback (most recent call last):
File stdin, line 1, in module
File
Changes by Serhiy Storchaka storch...@gmail.com:
Added file: http://bugs.python.org/file36029/posixpath_join_bytearray-3.5.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22034
___
Les Bothwell added the comment:
In my example, the import statement can be removed (dammit)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22026
___
Serhiy Storchaka added the comment:
Here is alternative patch. I believe it makes a code simpler.
Microbenchmarks:
$ ./python -m timeit -n 10 -s from ntpath import splitdrive
splitdrive('c:foo')
Before: 10 loops, best of 3: 20 usec per loop
After: 10 loops, best of 3: 11.5 usec
STINNER Victor added the comment:
I like ntpath_cleanup.diff, I don't think that it makes the code worse.
FYI os.fsencode() accepts str too, you can simplify:
if isinstance(path, bytes):
-userhome = userhome.encode(sys.getfilesystemencoding())
+userhome =
New submission from Serhiy Storchaka:
It is possible to crash Python by breaking opened gdbm database.
import _gdbm as dbm
db = dbm.open('x.db', 'n')
open('x.db', 'wb').close()
db[b'a'] = b'b'
gdbm fatal: read error
Proposed patch tries to convert fatal gdbm into regular exception or in
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17665
___
Serhiy Storchaka added the comment:
Next iteration of the patch addressed Victor's comments.
--
Added file: http://bugs.python.org/file36032/pyio_fileio_4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21859
Steven D'Aprano added the comment:
Many specialized reprs follow a pattern ... at {hexadecimal id}
But there are few deviations:
[...]
Proposed patch makes these cases to conform with other reprs.
I oppose making this change. The exact format of this generic repr of
instances is not a
STINNER Victor added the comment:
Changing the repr risks breaking doctests.
That's why the change was only done in Python 3.5. To port your application to
Python 3.5, you can modify you doctests to use ... (ellipsis option of
doctests).
That *might* be acceptable if there was some obvious
Serhiy Storchaka added the comment:
It broke Python tests (test_traceback and test_unittest), and the patch
contains fixes for this. Yes, it can break user test if they test nested
subclasses of classes touched by this patch. This is not very likely, but on
other hand I don't see what can
STINNER Victor added the comment:
If an application relies on the exact representation in an unit test, it would
be annoying to check the minor Python version to support the old and the new
format.
Using the qualified name is better, but it can wait Python 3.5 IMO. They are
enough complains
Roundup Robot added the comment:
New changeset fe3c98313855 by Serhiy Storchaka in branch 'default':
Issue #22032: __qualname__ instead of __name__ is now always used to format
http://hg.python.org/cpython/rev/fe3c98313855
--
nosy: +python-dev
___
Serhiy Storchaka added the comment:
I agree with you. Thank for your review Victor.
All these issues are precursors to issue22033.
--
assignee: - serhiy.storchaka
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python
Serhiy Storchaka added the comment:
OK. In any case I don't like this patch, it breaks simplicity and elegance of
current code.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21988
___
STINNER Victor added the comment:
New patch to rebase the code and document the new function. It fixed also the
docstring.
--
Added file: http://bugs.python.org/file36033/signal_socket-3.patch
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
The point *should* be that if you have something like:
/home/me/some/directory/my/stuff/a
/home/me/some/directory/my/stuff/b
/home/me/some/other/directory
and you set rootdir to '/home/me/some' and
base_dir='/home/me/some/directory/my' then the file
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22033
___
___
Python-bugs-list
Changes by Donald Stufft don...@stufft.io:
--
nosy: +dstufft
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22028
___
___
Python-bugs-list mailing
New submission from Martin Matusiak:
bits shared by the stringobject and unicodeobject implementations (and
possibly other modules, in a not too distant future).
stringobject should be bytesobject
--
components: Interpreter Core
files: fix_typo_stringlib.diff
keywords: patch
messages:
Alex Gaynor added the comment:
Reviewed more closely today, I think the docs probably need updating, but
otherwise this LGTM, massive improvement! Thanks!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22023
Steve Dower added the comment:
You can always deselect pip from the installation. Running it separately after
installation will no doubt show what the actual problem is.
--
nosy: +loewis
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
No, if *path* is not bytes, *userhome* shouldn't be converted to bytes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15275
___
New submission from Aaron Hill:
The last sentence in the explanation of the TCP echo client currently reads:
At run_until_complete() exit, the loop is no more running, so there is no need
to stop the loop in case of an error.
The grammar should be improved to something like ...the loop is no
Changes by Zachary Ware zachary.w...@gmail.com:
--
nosy: +georg.brandl
stage: - patch review
versions: -Python 3.1, Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22025
Zachary Ware added the comment:
I believe this is a change in Tk itself, I can get your 2.7.6 result with
Python 2.7.8+ compiled against Tcl/Tk 8.5.2, and your 2.7.8 result with Python
2.7.6 compiled against Tcl/Tk 8.5.15. I would guess that Tk is trying to avoid
getting glyph in your
Zachary Ware added the comment:
2.7.8 seems fine and there haven't been any reports about Tkinter not working
on Win2k yet, so I'll go ahead and change the 2.7 buildbot scripts and close
the issue.
--
assignee: - zach.ware
___
Python tracker
New submission from Vitor de Lima:
The atomic operations listed in the pyatomic.h header file were implemented
only for the x86 architecture, this patch uses the atomic bultins available in
GCC = 4.7 to implement such operations, allowing it to work properly in other
platforms.
--
Roundup Robot added the comment:
New changeset 73fcf00b9e0c by Zachary Ware in branch '2.7':
Closes #21665: Don't use OPTS=noxp or -DWINVER=0x0500 when compiling Tcl/Tk
http://hg.python.org/cpython/rev/73fcf00b9e0c
--
resolution: - fixed
stage: - resolved
status: open - closed
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +jyasskin, neologix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22038
___
___
New submission from Antoine Pitrou:
PyObject_SetAttr, when called with value == NULL, actually deletes the
attribute, but the documentation doesn't say it. It mentions PyObject_DelAttr,
but it is only a macro and can therefore not be looked up using e.g. ctypes.
--
assignee:
Alex Gaynor added the comment:
I've tested in my local dev with my SSL patches applied, and I've confirmed
that it fixes the segfaults.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22023
Guido van Rossum added the comment:
This does appear to be a bug. Please research the C code that originates the
error message -- there's probably a simple logic mistake.
--
nosy: +gvanrossum
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
There's also the following code in numpy's getbuffer method:
/*
* If a read-only buffer is requested on a read-write array, we return a
* read-write buffer, which is dubious behavior. But that's why this call
* is guarded by
Stefan Krah added the comment:
Actually we have an extra safety net in memory_hash() apart from
the readonly check: We also check if the underlying object is
hashable.
This might be applicable here, too. Unfortunately mmap objects
*are* hashable, leading to some funny results:
import mmap
Stefan Krah added the comment:
I think the mmap behavior is probably worse than the NumPy example.
I assume that in the example the exporter sets view.readonly=0.
mmap objects set view.readonly=1 and can still be mutated.
--
___
Python tracker
Zachary Ware added the comment:
It looks like we have a bit of a mess here. 2.7 has a return there (and thus
doesn't fall back to TerminateProcess if GenerateConsoleCtrlEvent fails), added
40 commits after the initial implementation in b1c00c7d3c85, but 3.x was never
changed so 2.7 and 3.x
New submission from Paul Moore:
It would be useful for shutil.rmtree to have a force argument that overrode
read-only permission issues, essentially replicating the behaviour of the -f
flag in rm -rf (Unix) and the -force parameter of del (Windows Powershell).
It's possible to use the onerror
Charles-François Natali added the comment:
On Unix at least, this doesn't apply: rm -f doesn't mean ignore permissions,
but but rather don't ask confirmation which the rm commands asks in some cases
(empty file, directory, etc).
Ans the code posted wouldn't work, since the permission to remove
R. David Murray added the comment:
Actually it does apply on unix:
rdmurray@session:~/tmpls -ld foo
drwxr-x--- 2 rdmurray rdmurray 4096 Jul 22 16:09 foo
rdmurray@session:~/tmpls -l foo
total 0
-r--r- 1 rdmurray rdmurray 0 Jul 22 16:09 bar
rdmurray@session:~/tmprm -r foo
rm: remove
Changes by Charles-François Natali cf.nat...@gmail.com:
--
resolution: - duplicate
stage: - resolved
status: open - closed
superseder: - handle EINTR in the stdlib
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21772
Changes by Charles-François Natali cf.nat...@gmail.com:
--
resolution: - duplicate
stage: needs patch - resolved
status: open - closed
superseder: - handle EINTR in the stdlib
___
Python tracker rep...@bugs.python.org
New submission from Alejandro MJ:
I'm trying this specific method with python, in order to use a different ip
source, to do a POST request:
import http.client, urllib.parse
data = urllib.parse.urlencode({'QLastname': 'DIAZ HERNANDEZ', 'QFirstname':
'JAIME'})
headers = {Content-type:
Charles-François Natali added the comment:
Actually it does apply on unix:
No, it does not apply: here's what I've written:
rm -f doesn't mean ignore permissions, but but rather don't ask
confirmation which the rm commands asks in some cases (empty file,
directory, etc).
Having a file
Serhiy Storchaka added the comment:
Nice. Could you please comment multiple dirname()-s in load_package_tests() as
it done for basename in Lib/test/test_tools/__init__.py?
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 7238c6a05ca6 by Charles-François Natali in branch '3.4':
Issue #21901: Cap the maximum number of file descriptors to use for the test.
http://hg.python.org/cpython/rev/7238c6a05ca6
New changeset 89665cc05592 by Charles-François Natali in branch
David Wilson added the comment:
Stefan, I like your new idea. If there isn't some backwards compatibility
argument about mmap.mmap being hashable, then it could be considered a bug, and
fixed in the same hypothetical future release that includes this BytesIO
change. The only cost now is that
Charles-François Natali added the comment:
Thanks for the patch, but I'm not even sure AIX is an officially supported
platform, so I'm not sure what to do with this patch.
--
nosy: +neologix
___
Python tracker rep...@bugs.python.org
R. David Murray added the comment:
In other words, on unix shutil.rmtree is *already* 'rm -rf'. This then argues
that it *not* deleting read only files on Windows is a bug, albeit one we may
not be able to fix for backward compatibility reasons.
Ah, and now my memory is jogged. This is a
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21860
___
___
Python-bugs-list
Charles-François Natali added the comment:
Sorry for the delay, should be fixed now.
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21901
Charles-François Natali added the comment:
Jerrfey, thanks for your patch, but apparently in the - long - meantime, the
declaration has already been moved up.
--
nosy: +neologix
resolution: - out of date
stage: - resolved
status: open - closed
___
Jeffrey Armstrong added the comment:
Next time I see a bug I'll be sure to wait rather than actually submit a
patch...
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17391
___
STINNER Victor added the comment:
Oh you're right sorry.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15275
___
___
Python-bugs-list mailing
Charles-François Natali added the comment:
Jeffrey Armstrong added the comment:
Next time I see a bug I'll be sure to wait rather than actually submit a
patch...
I understand your frustration, but please don't do that: you have to
understand that we don't have any automatic reminder of
Serhiy Storchaka added the comment:
Indeed. I got different results with different versions of Tk. Here is Tcl
script which demonstrates this.
--
status: pending - closed
Added file: http://bugs.python.org/file36036/issue22026.tcl
___
Python tracker
Neil Muller added the comment:
Poking at the source of the error suggests the problem is in symtable.c:
The offending logic looks to be (around line 1124 in python 2.7 at revision
91767:4cef7b0ec659):
if (s-v.Exec.globals) {
...
}
else
{
st-st_cur-ste_unoptimized |= OPT_BARE_EXEC;
}
Changes by Zachary Ware zachary.w...@gmail.com:
--
stage: - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22026
___
___
Python-bugs-list
Paul Moore added the comment:
Doh. And I was even involved in the previous issue. Sorry for the noise.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22040
___
Charles-François Natali added the comment:
In other words, on unix shutil.rmtree is *already* 'rm -rf'.
Exactly :-)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22040
___
Mark Lawrence added the comment:
I'd like to see this in 3.5 as I often use sqlite so what needs doing here?
--
nosy: +BreamoreBoy
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue13299
David Edelsohn added the comment:
Huh? What does officially supported platform mean? CPython builds and runs on
AIX.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17293
___
Milan Oberkirch added the comment:
I agree that there is not much we can do on the server side (see issue 19806)
and with the fix for issue 19662 the server won't recognize this error at all
(patiently waiting for b'\r\n\' which is unlikely to appear in the first
handshake-message from the
Antoine Pitrou added the comment:
I don't like the idea of trying to hash the object. It may be a time-consuming
operation, while the result will be thrown away.
I think restricting the optimization to bytes objects is fine. We can whitelist
other types, such as memoryview.
--
STINNER Victor added the comment:
I talked with Charles-François. He doesn't like the idea of a new function
because it would be harder to write portable code: which function should be
used? signal.set_wakeup_fd() already works with sockets on UNIX.
Here is a new patch version 4 which tries
STINNER Victor added the comment:
I tried to modify signal.set_wakeup_socket() to automatically make the file
descriptor non-blocking. Problem: fcntl() function and O_NONBLOCK flag don't
exist on Windows. Non-blocking operations are only supported for sockets...
Calling a blocking function
New submission from STINNER Victor:
I think that signal.set_wakeup_fd(fd) must set the file descriptor to the
non-blocking mode, instead of requiring the file descriptor mode to be
non-blocking.
Atttached patch implements this idea.
See also the issue #22018 which proposes to support sockets
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +neologix
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22042
___
___
Antoine Pitrou added the comment:
Please run the actual benchmark suite to get interesting numbers:
http://hg.python.org/benchmarks
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21955
Antoine Pitrou added the comment:
I think it would be much better to expose a generic function to make a fd
non-blocking, rather than bake it inside signal.set_wakeup_fd().
Also, given set_wakeup_fd() is rather specialized and uncommon, I don't see
much point in making it more convenient.
1 - 100 of 113 matches
Mail list logo