Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22470
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22286
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
versions: +Python 3.3, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22517
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
versions: +Python 2.7, Python 3.3, Python 3.5
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22519
___
Serhiy Storchaka added the comment:
Gregory just has committed an equivalent of unicode_2.patch in a404bf4db6a6.
--
nosy: +gregory.p.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22207
Gregory P. Smith added the comment:
modify it as you see fit, i hadn't noticed this issue; just the warnings.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22207
___
Serhiy Storchaka added the comment:
Yes, these warning annoyed me too. But Victor's patch is purposed to check
input data of public C API functions.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22207
Serhiy Storchaka added the comment:
Here is original Victor's patch synchronized with the tip.
--
Added file: http://bugs.python.org/file36757/issue22207_unicode_3.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22207
Marc-Andre Lemburg added the comment:
I think it's better to keep pybench speed performance oriented and rather use a
new tool for memory performance tests.
I've recently done a lightning talk at PyCon UK on the subject and found the
current tools we have for memory testing a bit
Serhiy Storchaka added the comment:
I have reviewed the patch and found only few checks which looks good to me.
Also I found two possible overflows (not fixed by the patch). All other changes
looks redundant to me and just churn a code.
--
___
STINNER Victor added the comment:
Sorry, I'm coming later after the review and the commit, but I worry about
performances of _run_once() since it's the core of asyncio. Yury proposed to
only iterate once on self._scheduled when removing delayed calls, and I have
the same concern.
Here is a
Roundup Robot added the comment:
New changeset 8e5e19b3cd4e by Victor Stinner in branch '3.4':
Issue #22396: On 32-bit AIX platform, don't expose os.posix_fadvise() nor
https://hg.python.org/cpython/rev/8e5e19b3cd4e
New changeset 5ade1061fa3d by Victor Stinner in branch 'default':
(Merge 3.4)
STINNER Victor added the comment:
Or can we simply keep the function and skip the test?
Usually, we prefer to not provide the function in Python if it is known to be
broken. Other examples:
- HAVE_BROKEN_POLL: don't declare select.poll()
- HAVE_BROKEN_PTHREAD_SIGMASK: don't declare
STINNER Victor added the comment:
It looks like compilation of Python 3.5 fails on FreeBSD 6.4 because of the
changeset bbe57429eba0a9ec21fb0f1178f409f1bba44c22:
http://buildbot.python.org/all/builders/x86%20FreeBSD%206.4%203.x/builds/5061
Compile log:
---
building '_ctypes' extension
New submission from STINNER Victor:
On buildbots FreeBSD 6.4 and 7.2, the compilation of the ctypes module fails
because the function ffi_call_win32 is missing. I don't understand why a
win32 function would be needed on FreeBSD!?
Antoine Pitrou added the comment:
I haven't really followed, but now that the PEP is accepted, what is the
progress on this one?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11406
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
components: +ctypes
keywords: +buildbot
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22521
___
STINNER Victor added the comment:
I don't understand why a win32 function would be needed on FreeBSD!?
I see the function defined in libffi, but I don't see it used in the ctypes
module.
Note: the system libffi is not used, these buildbots compile the embedded
version of libffi: checking
New submission from Claudiu Popa:
It seems that sys.excepthook doesn't receive the traceback when an error occurs
during a code.InteractiveInterpreter run. The problem is here:
https://hg.python.org/cpython/file/5ade1061fa3d/Lib/code.py#l168. last_tb was
previously set to None right before.
Ben Hoyt added the comment:
Yes, PEP 471 has been accepted, and I've got a mostly-finished C implementation
of os.scandir() for CPython 3.5, as well as tests and docs. If you want a sneak
preview, see posixmodule_scandir*.c, test/test_scandir.py, and os.rst here:
STINNER Victor added the comment:
There is a similar error on OpenIndiana buildbot, Python cannot be compiled
since this build:
http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/8664/steps/compile/logs/stdio
gcc -fPIC -Wsign-compare -g -O0 -Wall -Wstrict-prototypes
Mathieu Dupuy added the comment:
But I think md5-sess should really be integrated. It's a standard mechanism
described by a RFC (https://www.ietf.org/rfc/rfc2617.txt), and people need it,
however insecure it may be (aren't other method (md5) insecure too ?).
--
Changes by Georg Brandl ge...@python.org:
--
versions: -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16038
___
___
Python-bugs-list
Changes by Georg Brandl ge...@python.org:
--
versions: -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18747
___
___
Python-bugs-list
Changes by Georg Brandl ge...@python.org:
--
versions: -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16042
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Thanks for noticing this.
Looking at an old build, the ctypes and curses compile errors under OpenIndiana
are not new:
http://buildbot.python.org/all/builders/AMD64%20OpenIndiana%203.x/builds/8658/steps/compile/logs/stdio
Simply, it seems that a ctypes compile
Antoine Pitrou added the comment:
Those FreeBSD versions are totally obsolete, perhaps we should simply ignore
any failures on them.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22521
STINNER Victor added the comment:
the ctypes and curses compile errors under OpenIndiana are not new
FYI the compilation error of curses on OpenIndiana is *old*, at least 3 years
old :-(
http://bugs.python.org/issue13552
I just opened the issue #22521 for the compilation error of ctypes on
Jonas Wagner added the comment:
I don't understand where this error comes from...
The compilation commands are exactly the same in both the before and after
logs. The order of commands is also the same.
The only difference is this message:
*** WARNING: renaming _ssl since importing it
Changes by Georg Brandl ge...@python.org:
--
versions: -Python 3.1
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16041
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset 783e7b4375ac by Georg Brandl in branch '3.2':
Issue #16038: CVE-2013-1752: ftplib: Limit amount of data read by
https://hg.python.org/cpython/rev/783e7b4375ac
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 0f362676460d by Georg Brandl in branch '3.2':
Issue #16042: CVE-2013-1752: smtplib: Limit amount of data read by
https://hg.python.org/cpython/rev/0f362676460d
--
___
Python tracker
Roundup Robot added the comment:
New changeset deee87d61436 by Georg Brandl in branch '3.2':
Issue #16037: HTTPMessage.readheaders() raises an HTTPException when more than
https://hg.python.org/cpython/rev/deee87d61436
--
___
Python tracker
Roundup Robot added the comment:
New changeset 76be07730f8d by Georg Brandl in branch '3.2':
Issue #16041: CVE-2013-1752: poplib: Limit maximum line lengths to 2048 to
https://hg.python.org/cpython/rev/76be07730f8d
--
___
Python tracker
Roundup Robot added the comment:
New changeset 386b0f478117 by Georg Brandl in branch '3.2':
Issue #18709: Fix CVE-2013-4238. The SSL module now handles NULL bytes
https://hg.python.org/cpython/rev/386b0f478117
--
___
Python tracker
Roundup Robot added the comment:
New changeset bdf73458df5f by Christian Heimes in branch '3.2':
Issue #18747: document issue with OpenSSL's CPRNG state and fork
https://hg.python.org/cpython/rev/bdf73458df5f
--
___
Python tracker
Changes by Georg Brandl ge...@python.org:
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18709
___
___
Python-bugs-list
Georg Brandl added the comment:
Since it's been out in 3.2.x for so long, I won't apply this for 3.2 since at
this point a behavior change might do more harm than good.
--
resolution: - fixed
status: open - closed
versions: +Python 3.3, Python 3.4 -Python 3.2
Changes by Georg Brandl ge...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18747
___
Changes by Georg Brandl ge...@python.org:
--
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16041
___
___
Python-bugs-list
Changes by Georg Brandl ge...@python.org:
--
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16042
___
___
Python-bugs-list
Changes by Georg Brandl ge...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16038
___
Matthias Klose added the comment:
causing #22523, still referencing _ssl.sslwrap.
--
nosy: +doko
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21308
___
New submission from Matthias Klose:
the backport in issue #21308 caused this regression. _ssl.sslwrap is still
referenced in some files.
--
components: Library (Lib)
messages: 227896
nosy: alex, benjamin.peterson, christian.heimes, doko, dstufft,
giampaolo.rodola, janssen, pitrou
Changes by Georg Brandl ge...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16037
___
Matthias Troffaes added the comment:
Chiming in here: Sphinx's testing framework does include a feature that allows
easily read/write files into/from text/bytes directly from path-like objects.
There is thus a demand out there. If this feature were to make it into stdlib,
it would be loved at
Matthias Klose added the comment:
forwarded from https://bugs.debian.org/762010
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22523
___
___
Ram Rachum added the comment:
Matthias: Do you prefer having both `write_bytes` and `write_text` instead of
just `write` with a `binary` option? Do you prefer `append` and `exclusive`
modes to be allowed or not?
--
___
Python tracker
Roundup Robot added the comment:
New changeset 94af1af93670 by Antoine Pitrou in branch 'default':
Remove pointless vile hack that can cause the build step to fail when some
extension modules can't be imported.
https://hg.python.org/cpython/rev/94af1af93670
--
nosy: +python-dev
Roundup Robot added the comment:
New changeset 94af1af93670 by Antoine Pitrou in branch 'default':
Remove pointless vile hack that can cause the build step to fail when some
extension modules can't be imported.
https://hg.python.org/cpython/rev/94af1af93670
--
anupama srinivas murthy added the comment:
I have documented the function in object.rst file. I do not know the use of the
function and have not mentioned that. My documentation is based on what I
understood from the comments below and the explanation here:
Roundup Robot added the comment:
New changeset 0d115d14adfd by Georg Brandl in branch '3.2':
Issue #22419: Limit the length of incoming HTTP request in wsgiref server to
https://hg.python.org/cpython/rev/0d115d14adfd
--
___
Python tracker
Roundup Robot added the comment:
New changeset 4fa5239624b8 by Georg Brandl in branch '3.2':
Issue #22517: When a io.BufferedRWPair object is deallocated, clear its
https://hg.python.org/cpython/rev/4fa5239624b8
--
___
Python tracker
Antoine Pitrou added the comment:
The change I just pushed should fix the failures, waiting for the buildbots to
compile now.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5309
___
Antoine Pitrou added the comment:
Looks ok on OpenIndiana, closing now.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5309
___
STINNER Victor added the comment:
New changeset f86fde20e9ce by Benjamin Peterson in branch 'default':
merge 3.4 (closes #22518)
https://hg.python.org/cpython/rev/f86fde20e9ce
This changeset added other. It looks like you commited a conflict.
-if (requiredsize2*outsize)
+if
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +georg.brandl
resolution: rejected -
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20218
___
STINNER Victor added the comment:
It would be nice to have a bigmem test checking that repr(b'\x00'*(2**30+1))
doesn't crash anymore.
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22519
STINNER Victor added the comment:
It would be nice to add a bigmem test to check that repr('\x00'*(2**30+1))
doesn't crash anymore.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22518
STINNER Victor added the comment:
It would be nice to add a bigmem test to check that repr('\x00'*(2**30+1))
doesn't crash anymore.
--
nosy: +haypo
resolution: fixed -
status: closed - open
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: fixed -
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22519
___
STINNER Victor added the comment:
It would be nice to add a bigmem test to check that repr('\x00'*(2**30+1))
doesn't crash anymore.
Ooops, wrong issue, the test is : (\u * (2**29)).encode(latin1,
errors=xmlcharrefreplace).
--
___
Python
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: fixed -
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22518
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: patch review - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16037
___
___
Georg Brandl added the comment:
Note that these methods were already part of Jason's path.py when I imported it
for use by Sphinx.
I think these convenience methods are useful indeed, so if it is fine with your
philosophy for pathlib, I'd be happy to see them there. The
Matthias Troffaes added the comment:
Thanks for the quick response. I agree with Georg on all points, i.e. longer
function names and no extra options.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20218
Serhiy Storchaka added the comment:
I'm not sure that this change is correct. Why not raising an exception on
overflow?
This is correct. This check prevents overflow.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22518
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: needs patch - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2399
___
___
STINNER Victor added the comment:
This is correct. This check prevents overflow.
Oh, I didn't understand that requiredsize = 2*outsize; is only used for
performances, to overallocate the buffer. So I agree that it's fine to not
overallocate if it would overflow.
--
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21831
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
type: crash - security
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22518
___
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
type: crash - security
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22519
___
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
type: crash - security
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22520
___
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
type: crash - security
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22517
___
___
Roundup Robot added the comment:
New changeset 02dae04b3e2b by Georg Brandl in branch '3.2':
Issue #22421 - Secure pydoc server run. Bind it to localhost instead of all
interfaces.
https://hg.python.org/cpython/rev/02dae04b3e2b
--
___
Python tracker
STINNER Victor added the comment:
Turned out that single loop approach is not faster than loop+comprehension
IMO it makes the code simpler and easier to understand.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22448
Yury Selivanov added the comment:
IMO it makes the code simpler and easier to understand.
But it's a tad slower, like 2-3% ;) You can test it yourself, we only tested it
on huge tasks list of 1M items.
FWIW, I'm not opposed to your patch.
--
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22421
___
Antoine Pitrou added the comment:
It's an actual crash, AFAIK.
--
type: security - crash
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22517
___
Georg Brandl added the comment:
Benjamin, could you make a patch for 3.2 as well?
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22518
___
Georg Brandl added the comment:
I wouldn't consider this important enough for 3.2; since it lacks the means to
do the opt-back-in.
--
nosy: +georg.brandl
versions: -Python 3.2
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Ooops, wrong issue, the test is : (\u * (2**29)).encode(latin1,
errors=xmlcharrefreplace).
(\u * (sys.maxsize//8+1)).encode(latin1, errors=xmlcharrefreplace)
or
(\xff * (sys.maxsize//6+1)).encode(ascii, errors=xmlcharrefreplace)
--
Roundup Robot added the comment:
New changeset 5d1c03316af7 by Georg Brandl in branch '3.2':
Issue #16039: CVE-2013-1752: Change use of readline in imaplib module to limit
https://hg.python.org/cpython/rev/5d1c03316af7
--
___
Python tracker
Changes by Georg Brandl ge...@python.org:
--
versions: -Python 3.1, Python 3.2
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16039
___
___
Georg Brandl added the comment:
Next try.
--
Added file: http://bugs.python.org/file36761/pathlib_readwrite_v5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20218
___
STINNER Victor added the comment:
New changeset 5d1c03316af7 by Georg Brandl in branch '3.2':
Issue #16039: CVE-2013-1752: Change use of readline in imaplib module to limit
https://hg.python.org/cpython/rev/5d1c03316af7
I'm not sure that this change is correct, the test failed on Windows. Or
Georg Brandl added the comment:
Let me check that.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16039
___
___
Python-bugs-list mailing list
Antoine Pitrou added the comment:
Given that os.scandir() will solve this issue (as well as the bigger
performance problem due to listdir throwing away file type info), can we
close this issue and open another one to track the implementation of
os.scandir() / PEP 471?
This makes sense.
Yury Selivanov added the comment:
Victor,
During the code review we tried the single loop approach. At the end Joshua
wrote a small benchmark to test if it's really faster to do it in one loop or
not. Turned out that single loop approach is not faster than loop+comprehension
(but it's not
Roundup Robot added the comment:
New changeset 97c329849ef3 by Ned Deily in branch '3.2':
Issue #20939: Use www.example.com instead of www.python.org to avoid test
https://hg.python.org/cpython/rev/97c329849ef3
--
___
Python tracker
Arfrever Frehtes Taifersar Arahesis added the comment:
This error is rather related to issue #16042, not issue #16039.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16039
___
Changes by Georg Brandl ge...@python.org:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16039
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
stage: - test needed
type: crash - behavior
versions: -Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14156
___
Arfrever Frehtes Taifersar Arahesis added the comment:
New changeset 4065c4539fcb by Georg Brandl in branch '3.2':
Fix-up for 0f362676460d: add missing size argument to SSLFakeFile.readline(),
as in 2.6 backport
https://hg.python.org/cpython/rev/4065c4539fcb
--
New submission from Ben Hoyt:
Opening this to track the implementation of PEP 471: os.scandir() [1]. This
supercedes Issue #11406 (and possibly others)?
The implementation is most of the way there, but not yet done as a CPythono 3.5
patch. Before I have a proper patch, it's available on
Ben Hoyt added the comment:
Okay, I've opened http://bugs.python.org/issue22524, but I don't have the
permissions to close this one, so could someone with bugs.python.org
superpowers please do that?
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Georg, what is your decision?
--
nosy: +serhiy.storchaka
stage: - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19529
___
Nick Coghlan added the comment:
This approach has been rejected in favour of the accepted PEP 471 proposal to
add os.scandir() (issue #22524)
--
resolution: - rejected
stage: needs patch - resolved
status: open - closed
superseder: - PEP 471 implementation: os.scandir() directory
Georg Brandl added the comment:
Looks obvious and is potentially a security fix, so it can/should go in.
Please add a NEWS entry.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19529
___
Changes by Giampaolo Rodola' g.rod...@gmail.com:
--
nosy: +giampaolo.rodola
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22524
___
___
1 - 100 of 235 matches
Mail list logo
