Changes by Robert Collins robe...@robertcollins.net:
Added file: http://bugs.python.org/file37769/linecache_2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17911
___
Robert Collins added the comment:
This is a WIP patch, including it to just share progress.
--
Added file: http://bugs.python.org/file37770/frame_1.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17911
Robert Collins added the comment:
And this improves the scaling of the cache stating overhead, but we may well
want to fix this more fundamentally - e.g. by linking the cache ownership into
the import system somehow, so that when a file is reimported, the cached source
is automatically
Martin Panter added the comment:
Would also be good to document that errors='ignored' is not allowed. Currently
the documentation says
The following string values are defined and implemented by all standard Python
codecs:
* 'strict'
* 'ignore'
--
Ent added the comment:
I am having some issues with replying to comments on review page. It is giving
500 error hence posting replies here.
@berker.peksag: Thanks! I will add the methods' documentation examples into
the Doc/library/http.server.rst. As well as include a few unit tests.
I
Martin Panter added the comment:
Is this patch likely to go ahead? It has been sitting around a while and would
conflict with patches I am working on.
If so, I reckon it would be good to factor out some of the new bits of code
(_check_strict, _StrictErrors) into a common place, like the
Tim Smith added the comment:
Homebrew's interest in this ticket was resolved by the release of pip 6, which
includes Vinay's change to distlib to use sys.executable instead of
__PYVENV_LAUNCHER__. Many thanks!
I'm not marking this fixed in case it is useful to leave this open to discuss
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
stage: test needed - patch review
versions: +Python 3.5 -Python 3.4
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17840
Martin Panter added the comment:
Personally I don’t have a problem with the names; I would consider str(),
bytes(), bytearray() types all to be “strings”. However there is precedent in
the “base64” module for renaming to en/decodebytes(); see Issue 3613.
--
nosy: +vadmium
Berker Peksag added the comment:
Thanks for the patch. I left a couple of comments on Rietveld.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17840
___
Martin Panter added the comment:
Three slightly different points here:
1. Decoding trailing whitespace: My understanding is quoted-printable encoding
aims to be tolerant of whitespace being added to and removed from the end of
encoded lines. So I assume the “binascii” module is wrong to leave
Martin Panter added the comment:
Regarding decoding trailing whitespace,
https://tools.ietf.org/html/rfc1521.html#section-5.1 rule #3 says:
“When decoding a Quoted-Printable body, any trailing white space on a line must
be deleted, as it will necessarily have been added by intermediate
Robert Collins added the comment:
One thing I noticed while working on this, traceback today stats each included
file once per frame per call into e.g. format_list. This might actually account
for quite some of the overhead. I'll include an optimisation for this in my new
API.
Georg Brandl added the comment:
Well, go ahead I guess.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23181
___
___
Serhiy Storchaka added the comment:
If you want to decrease the number of executed instructions, I suggest to
duplicate lookup functions (actually add boolean flag and switch one of two
branches). On read lookup function should ignore dummy entries, on modification
it should behave as now.
New submission from Serhiy Storchaka:
For now dict views are not pickleable in Python 3 (unlike to Python 2 and
unlike to dict view iterators). Proposed patch adds pickle support of dict
views.
--
components: Interpreter Core
files: pickle_dictviews.patch
keywords: patch
messages:
Serhiy Storchaka added the comment:
In some cases the slowdown is over 100x.
$ ./python -m timeit -s s = set(range(10**4)) -- s.discard(0); s.add(0)
Unpatched: 100 loops, best of 3: 1.68 usec per loop
Patched: 1 loops, best of 3: 183 usec per loop
--
Changes by Serhiy Storchaka storch...@gmail.com:
--
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23181
___
___
Anne Moroney added the comment:
This ticket's patch appears to have already been merged, yet it is open?
On 2.7.9 docs [1], it has the exact language. The tutorial page [2] has a nice
description as well. Finding this ticket really helped me understand argparse a
bit better, and now I vote
Roundup Robot added the comment:
New changeset 0353c7e5e0c2 by Serhiy Storchaka in branch '3.4':
Issue #23181: More codepoint - code point.
https://hg.python.org/cpython/rev/0353c7e5e0c2
New changeset c79abee84a39 by Serhiy Storchaka in branch 'default':
Issue #23181: More codepoint - code
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: docs@python - serhiy.storchaka
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23181
___
Serhiy Storchaka added the comment:
Could you please update the patch Victor?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9393
___
___
New submission from i01100101:
The Python standard library includes lzma and support for *tar.xz archives
since Python 3.3 but the distutils' 'sdist' command cannot output source
distributions as such tarball.
I suggest the changed version of distutils.archive_util module attached to this
New submission from Markus:
I found the code used to collapse addresses to be very slow on a large number
(64k) of island addresses which are not collapseable.
The code at
https://github.com/python/cpython/blob/0f164ccc85ff055a32d11ad00017eff768a79625/Lib/ipaddress.py#L349
was found to be
Antoine Pitrou added the comment:
Here is an updated patch with a fix to the tests and docstrings.
--
Added file: http://bugs.python.org/file37764/collapse.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23266
Antoine Pitrou added the comment:
This is great, thank you. Can you sign the contributor's agreement?
https://www.python.org/psf/contrib/contrib-form/
--
nosy: +pitrou, pmoody
___
Python tracker rep...@bugs.python.org
Changes by Antoine Pitrou pit...@free.fr:
--
nosy: +davin, sbt
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23267
___
___
Python-bugs-list
Roundup Robot added the comment:
New changeset f7508a176a09 by Antoine Pitrou in branch 'default':
Issue #23266: Much faster implementation of ipaddress.collapse_addresses() when
there are many non-consecutive addresses.
https://hg.python.org/cpython/rev/f7508a176a09
--
nosy:
Antoine Pitrou added the comment:
Ok, I've committed the patch. Thank you!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23266
Markus added the comment:
I just signed the agreement, ewa@ is processing it.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23266
___
___
STINNER Victor added the comment:
Could you please update the patch Victor?
You can update this old patch if you want.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9393
___
Antoine Pitrou added the comment:
What is the right way to do it then? It should also remain compatible with
Firefox 36.
--
nosy: +pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23262
STINNER Victor added the comment:
Python 3 is not affected:
Python 3.5.0a0 (default:61a045ac0006, Jan 15 2015, 00:05:43)
[GCC 4.9.2 20141101 (Red Hat 4.9.2-1)] on linux
Type help, copyright, credits or license for more information.
temppath = uD:\\你好新建文件夹\\a
import shelve
cache =
Antoine Pitrou added the comment:
Please let's stop it. Mentioning the GIL in every place in the documentation
will only make people more worried and confused about something they shouldn't
be confused or worried about.
If you think some docs should discuss the GIL and its effect on running
Brett Cannon added the comment:
If you want a robust measurement of startup impact, the benchmark suite has two
benchmarks specifically for startup (w/ and w/o site.py).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23253
STINNER Victor added the comment:
I will not have to work on optimization before the alpha 1 (February 8, 2015).
Ethan: just commit your patch when you consider that it's ready to be
merged, we will have time to refactor and enhance the code later.
IMO it's more important to have the feature
Akira Li added the comment:
Only if the behaviour was unintuitive (i.e. if it *didn't* release the
GIL) would it make sense to document it.
There is no intuitive interface, not even the nipple. It's all learned. [1]
Yes, on consideration I agree with Antoine. That last sentence should
be
STINNER Victor added the comment:
Python 3 is not affected:
Oh sorry, dbm_open_unicode-32.patch is still needed. Currently, filenames are
encoded to UTF-8 which works when the filesystem encoding is UTF-8, but it
doesn't work on Windows.
--
versions: +Python 3.4, Python 3.5
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23257
___
___
Python-bugs-list
Changes by Brett Cannon br...@python.org:
--
nosy: +brett.cannon
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23253
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Committed to 2.7 with small change: stat() and makedev() should return int
instead of long if possible.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker
Serhiy Storchaka added the comment:
If there are no objections I'm going to commit the patch.
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18518
___
Ned Deily added the comment:
Thanks for the suggested patch. Distutils support for xz compression is the
subject of already open Issue16314. Perhaps you can review and/or comment on
the suggested patch there.
--
nosy: +ned.deily
resolution: - duplicate
stage: - resolved
status:
Markus added the comment:
Added the testrig.
--
Added file: http://bugs.python.org/file37763/testrig.tar.gz
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23266
___
Changes by Al Sweigart asweig...@gmail.com:
Added file: http://bugs.python.org/file37760/idle_find_ui_redesign2.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23218
___
Changes by Antoine Pitrou pit...@free.fr:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23266
___
___
Python-bugs-list
Antoine Pitrou added the comment:
This looks good to me, thank you.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23264
___
___
New submission from shani:
Multiprocessing pool.py gets SimpleQueue objects as inqueue and outqueue.
when it terminates, it doesn't call the close() method of the queues' readers
and writers.
As a results, 4 file pipes leak in one pool termination.
Expected: The pool closes reader and writer
Roundup Robot added the comment:
New changeset 7ee09e2fec13 by Serhiy Storchaka in branch '2.7':
Issue #23098: 64-bit dev_t is now supported in the os module.
https://hg.python.org/cpython/rev/7ee09e2fec13
New changeset 18703ffea2b3 by Serhiy Storchaka in branch '3.4':
Issue #23098: 64-bit
Changes by Al Sweigart asweig...@gmail.com:
Added file: http://bugs.python.org/file37759/idle_grep_compare2.png
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23218
___
Serhiy Storchaka added the comment:
If there are no objections I'm going to commit the patch.
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23094
___
Serhiy Storchaka added the comment:
That way a virtual sequence with PY_SSIZE_T_MAX-1 items would still work
(instead of failing unexpectedly).
Actually with PY_SSIZE_T_MAX+1 items (indices from 0 to PY_SSIZE_T_MAX
inclusive).
If Raymond insists I can write more complicated patch, but I
Al Sweigart added the comment:
I've made some minor updates: Adding colons to the labels and right-justifying
them. These updates can be seen in the second comparison screenshot.
--
___
Python tracker rep...@bugs.python.org
Ethan Furman added the comment:
Here's the patch -- the code for % and %= is in place for bytes and bytearray;
I still need to get the doc patch done. I'll commit Wednesday-ish barring
problems.
Big question
Background
--
There is a Python C ABI function called
Ethan Furman added the comment:
Thanks, Victor, for the feedback.
I was able to figure out some more of the C side thanks to Georg, and I think
the code is looking pretty good.
There may be room for optimization by having the bytes code call the unicode
implementation for more of the
New submission from Serhiy Storchaka:
Here is a patch which fixes following errors in comparison of ipaddress classes.
1. Ordering comparison raised AttributeError when compared with foreign classes.
2. Ordering comparison didn't return NotImplemented when compared with foreign
classes. This
Serhiy Storchaka added the comment:
Details: https://bugzilla.mozilla.org/show_bug.cgi?id=1080319
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23262
___
Changes by Antoine Pitrou pit...@free.fr:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23248
___
Serhiy Storchaka added the comment:
Now patterns which could match only an empty string (e.g. '(?m)^$' or
'(?=\w-)(?=\w)') are rejected at all. They never worked with current regex
engine. Updated the documentation.
Could anyone please make a review and correct my wording. It is desirable to
Antoine Pitrou added the comment:
I don't really understand why this is definitely a bug.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22818
___
anupama srinivas murthy added the comment:
The comment is captured only in the absence of a docstring within the function.
The capture happens whether the function is nested or otherwise
--
nosy: +anupama.srinivas.murthy
___
Python tracker
Roundup Robot added the comment:
New changeset 2eea364c2863 by Antoine Pitrou in branch '3.4':
Issue #23248: Update ssl error codes from latest OpenSSL git master.
https://hg.python.org/cpython/rev/2eea364c2863
New changeset 15f46b850257 by Antoine Pitrou in branch 'default':
Issue #23248:
Serhiy Storchaka added the comment:
And needed tests.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9393
___
___
Python-bugs-list mailing list
steve added the comment:
Thanks
I killed the Intel task and the Python install worked without problems.
There is almost no information on the web about what these Intel tasks do
which made the Python install a little scary. Minor warning messages
sometimes mask big problems.
I'm amazed
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22765
___
___
Serhiy Storchaka added the comment:
Because users expect that split() supports zero-width patterns (as sub()
supports them) and regexps in other languages support splitting on zero-width
patterns. This looks as accidental implementation detail (see my patch in
issue22817 -- the difference is
Serhiy Storchaka added the comment:
Then I'll remove it. Could you please make a review of optimized patch?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23133
___
Stephan Sokolow added the comment:
Well, then the code which chooses a backend is broken because I have xdg-open
and, according to WinPdb, it's using the Mozilla backend.
This was my local workaround:
if os.name == 'posix' and not platform.mac_ver()[0]:
with open(os.devnull, 'wb')
Antoine Pitrou added the comment:
Well, then the code which chooses a backend is broken because I have
xdg-open and, according to WinPdb, it's using the Mozilla backend.
You have xdg-open under Windows?
--
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
Oops, sorry. The best way forward would be for you to investigate and find out
why xdg-open isn't preferred in your setting.
--
versions: +Python 3.5 -Python 3.2, Python 3.3
___
Python tracker rep...@bugs.python.org
Stephan Sokolow added the comment:
WinPdb = Windowed Pdb, not MS Windows Pdb.
`sudo apt-get install winpdb`
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23262
___
Stephan Sokolow added the comment:
Noted. I'm not sure what my schedule will be like, but I'll try.
(I may get back to you with an answer later today or I may not within the week.)
--
___
Python tracker rep...@bugs.python.org
Martin Panter added the comment:
Spotted code in Python’s own library that maintains a persistent connection and
works around this issue:
Lib/xmlrpc/client.py:1142
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3566
Martin Panter added the comment:
I would support adding ENOTCONN under the ConnectionError umbrella. It is
caught for shutdown() calls in a few standard library modules. Here is a demo
showing how to trigger it (at least on Linux):
from socket import create_connection, SHUT_RDWR
from
Georg Brandl added the comment:
Agreed. of the current thread is a good addition. The sleep() docs are
already longer than I would like.
--
nosy: +georg.brandl
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23251
Serhiy Storchaka added the comment:
Deduplication should not be omitted. This slowed down collapsing of duplicated
addresses.
$ ./python -m timeit -s import ipaddress; ips =
[ipaddress.ip_address('2001:db8::1000') for i in range(1000)] --
ipaddress.collapse_addresses(ips)
Before
Antoine Pitrou added the comment:
Good catch. What is the performance on the benchmark posted here?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23266
___
Stephan Sokolow added the comment:
The proper solution is to prefer `start` (Windows), `open` (OSX), or `xdg-open`
(everything else... usually but not always present) when present instead of
calling the browser directly.
That way, you're using the same delegate to the desktop's associations
Antoine Pitrou added the comment:
That doesn't really answer the question. The webbrowser module is already able
to use xdg-open (though not open), but it has a fallback on various
concrete browsers (including Firefox) in case xdg-open doesn't work / doesn't
exist.
--
Serhiy Storchaka added the comment:
What is the performance on the benchmark posted here?
The same as with current code.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23266
___
Antoine Pitrou added the comment:
Then +1. The patch looks fine to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23266
___
___
Roundup Robot added the comment:
New changeset 021b23a40f9f by Serhiy Storchaka in branch 'default':
Issue #23266: Restore the performance of ipaddress.collapse_addresses() whith
https://hg.python.org/cpython/rev/021b23a40f9f
--
___
Python tracker
Changes by Serhiy Storchaka storch...@gmail.com:
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23266
___
Serhiy Storchaka added the comment:
Could you please look at the patch Senthil?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7665
___
___
Roundup Robot added the comment:
New changeset 781b54f7bccc by Serhiy Storchaka in branch 'default':
Issue #23133: Pickling of ipaddress objects now produces more compact and
https://hg.python.org/cpython/rev/781b54f7bccc
--
nosy: +python-dev
___
Serhiy Storchaka added the comment:
Thank you Antoine.
And here is comparison of pickle size.
Unpatched:
len(pickle.dumps([ipaddress.ip_address('192.0.2.%s'%i) for i in range(1,
101)]))
2971
len(pickle.dumps([ipaddress.ip_address('2001:db8::%x'%i) for i in range(1,
101)]))
4071
Raymond Hettinger added the comment:
I'll just close this one. There seems to be little interest in it.
Originally, I characterized freeslot tracking as an optimization that mildly
benefited an uncommon case (adds/deletes/moreadds) at the expense of the common
cases (uniquification,
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23261
___
Serhiy Storchaka added the comment:
Ping.
If this patch will be accepted I'll provide larger patch for similar issues in
close methods of other classes.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21802
Serhiy Storchaka added the comment:
I think we should add a check to ensure than heap types have the __module__
attribute.
--
assignee: - serhiy.storchaka
stage: - needs patch
___
Python tracker rep...@bugs.python.org
Antoine Pitrou added the comment:
The patch looks fine to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23133
___
___
Python-bugs-list
Changes by Serhiy Storchaka storch...@gmail.com:
--
assignee: - serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9678
___
___
Serhiy Storchaka added the comment:
If no one interesting in testing this issue I'll close it.
--
status: open - pending
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9678
___
Gwenlliana added the comment:
The capture actually worked correctly. It seems to be caused by the artifacts
introduced by the evaluation function decorators.
Decorator lists for functions are compiled to a series of high-order function
applications to the original function, followed by an
Gwenlliana added the comment:
Though standard library contains a workaround on the decorator issue
(functools.wraps), but it still failed to patch func_code.co_firstlineno, which
led the pydoc module to capture the wrong comment.
--
___
Python
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
Removed message: http://bugs.python.org/msg234210
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23259
___
Roundup Robot added the comment:
New changeset 712ac77b772b by Serhiy Storchaka in branch 'default':
Fixed tests for issue #23133 (pickling of IPv4Network was not tested).
https://hg.python.org/cpython/rev/712ac77b772b
--
___
Python tracker
Roundup Robot added the comment:
New changeset 0f90a3bd07f7 by Raymond Hettinger in branch 'default':
Issue 23261: Clean-up the hack to store the set.pop() search finger in a hash
field instead of the setobject.
https://hg.python.org/cpython/rev/0f90a3bd07f7
--
nosy: +python-dev
Andrew Svetlov added the comment:
I'm with Antoine.
Yes, GIL is extremely important but please don't put GIL mentions everywhere.
On Sun, Jan 18, 2015 at 4:39 PM, Antoine Pitrou rep...@bugs.python.org wrote:
Antoine Pitrou added the comment:
Please let's stop it. Mentioning the GIL in
99 matches
Mail list logo