[issue23841] py34 OrderedDict is using weakref for root reference

Changes by Raymond Hettinger : -- priority: normal -> high ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue23841] py34 OrderedDict is using weakref for root reference

Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue22977] Unformatted “Windows Error 0x%X” exception message on Wine

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue22977] Unformatted “Windows Error 0x%X” exception message on Wine

Roundup Robot added the comment: New changeset 7907746baa0d by Serhiy Storchaka in branch '3.4': Issue #22977: Fixed formatting Windows error messages on Wine. https://hg.python.org/cpython/rev/7907746baa0d New changeset cf0cac11813d by Serhiy Storchaka in branch 'default': Issue #22977: Fixed f

[issue22977] Unformatted “Windows Error 0x%X” exception message on Wine

Serhiy Storchaka added the comment: Yes, you are right. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue6766] Cannot modify dictionaries inside dictionaries using Managers from multiprocessing

Changes by Ned Deily : -- nosy: +davin, sbt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue23846] asyncio : ProactorEventLoop raised BlockingIOError when ThreadPoolExecutor has many workers

Changes by SeungHyun.Hwang : -- type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue23731] Implement PEP 488

Eric Snow added the comment: Thanks for doing this, Brett. It's so simple a change yet such a great one. :) -- ___ Python tracker ___ ___

[issue22977] Unformatted “Windows Error 0x%X” exception message on Wine

Martin Panter added the comment: All the other occurrences of capitalized %X that I can find are not using Python’s string formatting functions. Please point them out if you can, but all I can see are some using a Microsoft vfwprintf_s() API, some calling standard C sprintf(), sscanf(), fprint

[issue22350] nntplib file write failure causes exception from QUIT command

Martin Panter added the comment: Serhiy, regarding _getresp() calling resp.decode(): You are probably right that a failure decoding the response line is recoverable in some circumstances, such a GROUP command. But in other cases, say an ARTICLE command, the response won’t have been fully drain

[issue23844] test_ssl: fails on recent libressl version with BAD_DH_P_LENGTH

Roundup Robot added the comment: New changeset 1ad7c0253abe by Benjamin Peterson in branch '3.4': replace 512 bit dh key with a 2014 bit one (closes #23844) https://hg.python.org/cpython/rev/1ad7c0253abe New changeset 4f2391e86643 by Benjamin Peterson in branch '2.7': replace 512 bit dh key with

[issue23846] asyncio : ProactorEventLoop raised BlockingIOError when ThreadPoolExecutor has many workers

New submission from SeungHyun.Hwang: I tested on python3.4.2, windows 7 1. Only proactorEvent issued. 2. ThreadPoolExecutor has many workers (in the attached example file, worker count 20,000) 3. The loop does run_in_executor more call than worker count (in the attached example file, 40,000 ca

[issue12849] Cannot override 'connection: close' in urllib2 headers

Changes by xiaobing jiang : -- nosy: +s7v7nisla...@gmail.com ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue16991] Add OrderedDict written in C

Eric Snow added the comment: Thanks for speaking up, Antoine. Keep in mind that a C implementation of OrderedDict has a strict compatibility requirement with the existing pure Python one. The Python implementation subclasses dict so the C implementation must as well. I agree that it would b

[issue23566] RFE: faulthandler.register() should support file descriptors

Wei Wu added the comment: @haypo, would you review issue23566_fd_tests_v2.patch? It's been a time since the last update of it. However I think the fd tests on windows is just fine to be skipped. So what's the next plan? Shall we continue to work on it or just resolve this issue? -- _

[issue23738] Clarify documentation of positional-only default values

Martin Panter added the comment: pos-defaults.v2.patch includes the results of “make clinic” to fix the doc strings. Is there a consensus to use PEP 457’s slash “/” notation? At one point I think I saw Serhiy was concerned that it might be confusing. -- Added file: http://bugs.python.

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

Roundup Robot added the comment: New changeset 920b700d9509 by Victor Stinner in branch 'default': Issue #23834: Fix sock_call(), set deadline_initialized to recompute the timeout https://hg.python.org/cpython/rev/920b700d9509 -- ___ Python tracker <

[issue16991] Add OrderedDict written in C

Antoine Pitrou added the comment: >From a cursory glance, I still think this is the wrong approach. There's a lot >of complication due to the simple fact that it is subclassing from dict (and >therefore trying to be ABI-compatible, kind of). The linked list scheme should >be much simpler (perh

[issue23843] ssl.wrap_socket doesn't handle virtual TLS hosts

Antoine Pitrou added the comment: Not sure why you're using wrap_socket() directly. Most of the time you should be using a higher-level library instead (for example a HTTP(S) library). In any case, the doc already mentions that "Starting from Python 3.2, it can be more flexible to use SSLConte

[issue23844] test_ssl: fails on recent libressl version with BAD_DH_P_LENGTH

Antoine Pitrou added the comment: Thanks for the patch. It should probably also remove the old file, unless it's also used somewhere else? -- nosy: +pitrou stage: -> patch review versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

Matt Chung added the comment: Based off of storchaka's comment, moving the -- Added file: http://bugs.python.org/file38799/tokenize.patch ___ Python tracker ___ _

[issue22671] Typo in class io.BufferedIOBase docs

Martin Panter added the comment: read-defaults.v3.patch: * Split off test_RawIOBase_readall() * Changed BufferedIOBase tests to matrix of tuples * Added tests for empty buffer * Test that unused part of buffer remains untouched -- Added file: http://bugs.python.org/file38798/read-default

[issue12319] [http.client] HTTPConnection.putrequest not support "chunked" Transfer-Encodings to send data

Changes by Demian Brecht : Added file: http://bugs.python.org/file38797/issue12319_5.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

shiyao.ma added the comment: Based upon the previous review. Catch the TextWrapper, move the test into a function. -- Added file: http://bugs.python.org/file38796/tokenizeV2.patch ___ Python tracker __

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

Matt Chung added the comment: Updated patch based off of haypo's comment. Changed "except Exception as err:" -> "except" -- Added file: http://bugs.python.org/file38795/tokenize.patch ___ Python tracker __

[issue19511] lib2to3 Grammar file is no longer a Python 3 superset

Changes by Gregory P. Smith : -- versions: +Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue19511] lib2to3 Grammar file is no longer a Python 3 superset

Changes by Gregory P. Smith : -- versions: -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue19511] lib2to3 Grammar file is no longer a Python 3 superset

Gregory P. Smith added the comment: This is blocking Python auto formatters from working properly on Python 3 syntax code. For example: https://github.com/google/yapf/issues/61 -- assignee: -> gregory.p.smith nosy: +gregory.p.smith priority: low -> normal

[issue23376] getargs.c: redundant C-contiguity check

Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

STINNER Victor added the comment: Snow Leopard doesn't like me (or the opposite?), the changeset 358a2bcd0d0b introduced a regression. I'm unable to reproduce, I ran test_socket on Linux (3.18), Mac OS X (Yosemite, Mac OS X 10.10) and FreeBSD (10). I don't see a significant difference in sock_

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

STINNER Victor added the comment: > Yes. Any comment on the test? Yes, as I wrote, I reviewed patches. You may get a notification by email. Anyway, it's here: http://bugs.python.org/review/23840/diff/14417/Lib/test/test_tokenize.py (I also commented tokenize.py) -- ___

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

shiyao.ma added the comment: On Wed, Apr 1, 2015 at 6:18 PM, STINNER Victor wrote: > Oh, right. But TextIOWrapper can fail for differen reasons. For example, > CTRL+c may send KeyboardInterrupt. Yes. Any comment on the test? I wil update a second patch. Regards. -- 吾輩は猫である。ホームーページはhttp:/

[issue23845] test_ssl: fails on recent libressl with SSLV3_ALERT_HANDSHAKE_FAILURE

New submission from Cédric Krier: SSLv3 has been deactivated by default [1], as stated in the commit message it can be reactivated by clearing the option. So here is a patch that reactivate it in the test when needed. [1] http://marc.info/?l=openbsd-cvs&m=141339479327258&w=2 -- files:

[issue23796] BufferedReader.peek() crashes if closed

Martin Panter added the comment: New patch with tests looks good to me. The BufferedReaderTest class is a sensible place for the test. -- ___ Python tracker ___

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

STINNER Victor added the comment: > ITSM it's not the TextIOWrapper but the detect_encoding fails and throws an > error. Oh, right. But TextIOWrapper can fail for differen reasons. For example, CTRL+c may send KeyboardInterrupt. Try for example: with unittest.mock.patch.object(tokenize,

[issue9026] argparse subcommands not printed in the same order they were added

ddve...@ucar.edu added the comment: This problem is occurring again in python 2.7.7, can we open it again? -- nosy: +ddve...@ucar.edu ___ Python tracker ___ __

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

Matt Chung added the comment: I believe it goes here under the TestTokenize class. Going to give it a shot now. -- ___ Python tracker ___ ___

[issue23756] Tighten definition of bytes-like objects

Martin Panter added the comment: I will to pull the stdtypes.rst changes out into a separate patch and issue, if that will make review easier. I think they are an improvement because the previous version was incorrect and misleading, but they are probably not necessary for people to understand

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

Matt Chung added the comment: Curious, @haypo, are you looking for a new unittest or a function within an existing unit test? Perhaps go under TestTokenize? 1227 def test_main(): 1228 from test import test_tokenize 1229 support.run_doctest(test_tokenize, True) 1230 support.run_uni

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

Roundup Robot added the comment: New changeset b3c7ae99b8e0 by Victor Stinner in branch 'default': Issue #23834: Modify socket.sendall() to reuse sock_call() with https://hg.python.org/cpython/rev/b3c7ae99b8e0 -- ___ Python tracker

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

Matt Chung added the comment: Comparing to introom. Any reason to not wrap the entire in a try? Attached patch. -- nosy: +itsmemattchung Added file: http://bugs.python.org/file38793/issue23840.patch ___ Python tracker

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

shiyao.ma added the comment: ITSM it's not the TextIOWrapper but the detect_encoding fails and throws an error. So I wrapped a try/catch block around that. -- keywords: +patch nosy: +introom Added file: http://bugs.python.org/file38792/tokenize.patch __

[issue23844] test_ssl: fails on recent libressl version with BAD_DH_P_LENGTH

New submission from Cédric Krier: Since [1], libressl fails if DH keys are too small (<1024). Here is a patch to increase the dh keys to 1024 for the tests. [1] http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/ssl/s3_clnt.c?rev=1.108&content-type=text/x-cvsweb-markup -- file

[issue23839] Clear caches after every test

Robert Collins added the comment: +1 on moving to the summary classes rather than actual tracebacks in unittest. (Or perhaps even just serialised tracebacks like we do in testtools). -- ___ Python tracker

[issue23839] Clear caches after every test

Robert Collins added the comment: I'd like to see a definite profile of a bloated stdlib test process before we assume we know the issue - the usual leak I see in test code is used test objects, and I'm not sure we've ported the usual fix for that into unittest yet (we should). As far as line

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

Roundup Robot added the comment: New changeset 358a2bcd0d0b by Victor Stinner in branch 'default': Issue #23834: Add sock_call() helper function https://hg.python.org/cpython/rev/358a2bcd0d0b -- nosy: +python-dev ___ Python tracker

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list ma

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Serhiy Storchaka added the comment: Oh, this is a catch when backport to 2.7. Here is a patch that makes dev_t converter to support int and int-like types. Added tests (surprisingly there were no tests for makedev/major/minor at all). > so maybe revert that optimization for the released branch

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

STINNER Victor added the comment: Obviously, an unit test is missing ;) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue23796] BufferedReader.peek() crashes if closed

STINNER Victor added the comment: John Hergenroeder added the comment: > my assumption is that a 0-length read on a closed BufferReader should fail, > not return an empty bytestring. I agree. -- ___ Python tracker

[issue23731] Implement PEP 488

Paul Moore added the comment: A few minor review comments. Nothing substantial, tbh. Looks good. -- ___ Python tracker ___ ___ Python-

[issue23830] Add AF_IUCV support to sockets

Neale Ferguson added the comment: Corrected a length error in the strip routine Initialized the end of string indicator -- Added file: http://bugs.python.org/file38789/af_iucv.patch ___ Python tracker _

[issue23588] Errno conflicts in ssl.SSLError

John Nagle added the comment: If SSL error reporting is getting some attention, something should be done to provide better text messages for the SSL errors. All certificate verify exceptions return the string "certificate verify failed (_ssl.c:581)". The line number in _ssl.c is not particula

[issue23830] Add AF_IUCV support to sockets

Neale Ferguson added the comment: Updated patch - Removes tabs - Strips name/user/node returned by connect - Checks lengths of name/user/node -- Added file: http://bugs.python.org/file38788/af_iucv.patch ___ Python tracker

[issue23731] Implement PEP 488

Steve Dower added the comment: I don't actually see any essential changes. The bdist_wininst and bdist_msi changes are just for usage help, and presumably they'll go from "do not compile .py to .pyo (optimized)" to "do not compile .py to optimized .pyc". I'd prefer to leave the .pyo file assoc

[issue23843] ssl.wrap_socket doesn't handle virtual TLS hosts

New submission from John Nagle: ssl.wrap_socket() always uses the SSL certificate associated with the raw IP address, rather than using the server_host feature of TLS. Even when wrap_socket is used before calling "connect(port, host)", the "host" parameter isn't used by TLS. To get proper TLS

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Changes by Matthias Klose : -- nosy: +benjamin.peterson priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-lis

[issue6766] Cannot modify dictionaries inside dictionaries using Managers from multiprocessing

Changes by Dan O'Reilly : -- nosy: +dan.oreilly versions: +Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Matthias Klose added the comment: casting to a long works ... >>> os.major(long(os.makedev(8,65))) 8 so maybe revert that optimization for the released branches? -- ___ Python tracker

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Matthias Klose added the comment: no, simpler: >>> import os >>> os.minor(os.makedev(8,65)) Traceback (most recent call last): File "", line 1, in SystemError: ../Objects/longobject.c:998: bad argument to internal function >>> os.major(os.makedev(8,65)) Traceback (most recent call last): Fi

[issue23796] BufferedReader.peek() crashes if closed

John Hergenroeder added the comment: Thanks for the feedback, Berker! I've added a test case that closes a buffered reader and then attempts to both peek and read1 it. I tacked it onto the end of the BufferedReaderTest class in test_io, but let me know if there's a better place to put it. I'v

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Matthias Klose added the comment: so the culprit is an "optimization": "Committed to 2.7 with small change: stat() and makedev() should return int instead of long if possible." the test case however expects a long. st_dev is now not always a long, but an int or long depending on the value. -

[issue23836] PEP 475: Enhance faulthandler to handle better reentrant calls

Roundup Robot added the comment: New changeset 60e001ec141d by Victor Stinner in branch 'default': Issue #23836: Add _Py_write_noraise() function https://hg.python.org/cpython/rev/60e001ec141d New changeset d9b9e2a68e7c by Victor Stinner in branch 'default': Issue #23836: Document functions rele

[issue23836] PEP 475: Enhance faulthandler to handle better reentrant calls

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

STINNER Victor added the comment: > return '%d:%d' % (os.major(st.st_rdev), os.minor(st.st_rdev)) Can you check if the error comes from os.major() or os.minor(), and please provide the value of st_rdev? You can modify the unit test to catch SystemError and raise a new exception with more info

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue23830] Add AF_IUCV support to sockets

Terry J. Reedy added the comment: The CA ack is a * added after your name here. May take a week. If you are asking whether to submit a new patch against 3.5, with suggested fixes, yes, please do . -- nosy: +terry.reedy stage: -> patch review versions: +Python 3.5 -Python 2.7

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

New submission from Matthias Klose: an unreleased version of cinder fails a test when run with python 2.7 from the branch. I don't have a test case yet, but looking at the error message and list of fixed issues after the 2.7.9 release, the fix for issue #23098 could be the culprit. FAIL: ci

[issue23830] Add AF_IUCV support to sockets

Neale Ferguson added the comment: Thanks. Question/responses in-line On 4/1/15, 11:14 AM, "Amaury Forgeot d'Arc" wrote: > >Amaury Forgeot d'Arc added the comment: > >Hi, >First, please fill and submit a Contribution Agreement: >https://www.python.org/psf/contrib/ Done but I never got the email

[issue23731] Implement PEP 488

Brett Cannon added the comment: Here is a patch that implements PEP 488 **except** for Windows installer stuff. I don't think the Windows changes need to block this patch going in, but I will need someone on Windows to help fix up PC/, PCbuild/, Tools/msi, Lib/distutils/command/bdist_msi.py, a

[issue23731] Implement PEP 488

Changes by Brett Cannon : Removed file: http://bugs.python.org/file38785/be7d966b660a.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23731] Implement PEP 488

Changes by Brett Cannon : Added file: http://bugs.python.org/file38786/8ce8e9b1f3e7.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue23731] Implement PEP 488

Changes by Brett Cannon : -- keywords: +patch Added file: http://bugs.python.org/file38785/be7d966b660a.diff ___ Python tracker ___ __

[issue23485] PEP 475: handle EINTR in the select and selectors module

Roundup Robot added the comment: New changeset 65ac8e587bb0 by Victor Stinner in branch 'default': Issue #22117, issue #23485: Fix _PyTime_AsMilliseconds() and https://hg.python.org/cpython/rev/65ac8e587bb0 -- ___ Python tracker

[issue23731] Implement PEP 488

Changes by Brett Cannon : -- hgrepos: +303 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue22117] Rewrite pytime.h to work on nanoseconds

Roundup Robot added the comment: New changeset 65ac8e587bb0 by Victor Stinner in branch 'default': Issue #22117, issue #23485: Fix _PyTime_AsMilliseconds() and https://hg.python.org/cpython/rev/65ac8e587bb0 -- ___ Python tracker

[issue23484] SemLock acquire() keyword arg 'blocking' is invalid

Berker Peksag added the comment: I use "enhancement" for non-trivial documentation patches. Also, quoting from https://docs.python.org/devguide/triaging.html#type "Also used for improvements in the documentation and test suite and for other refactorings." In this case, your patch fixes a docu

[issue23830] Add AF_IUCV support to sockets

Amaury Forgeot d'Arc added the comment: Hi, First, please fill and submit a Contribution Agreement: https://www.python.org/psf/contrib/ Then about the patch: - This is a patch against Python2.7, which is frozen for new developments. This change will only be applied to python 3.5 or later. - Th

[issue23756] Tighten definition of bytes-like objects

Serhiy Storchaka added the comment: See also issue23376. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue23756] Tighten definition of bytes-like objects

R. David Murray added the comment: Stefan, since he's the current maintainer of the memoryview implementation. Fortunately he spotted the issue :) Maybe Antoine, too; he's done work in this area. I'll add him. -- nosy: +pitrou ___ Python tracker

[issue23756] Tighten definition of bytes-like objects

Serhiy Storchaka added the comment: What people are needed? The patch looks as great improvement to me. -- ___ Python tracker ___ ___

[issue23756] Tighten definition of bytes-like objects

R. David Murray added the comment: I found the explanation of C-contiguous vs Fortran-contiguous helpful (and I've programmed in both of those languages, though granted not much :). However, based on that it is not obvious to me why having a fortran-contiguous buffer prevents it from being us

[issue23756] Tighten definition of bytes-like objects

R. David Murray added the comment: Oh, and about the general concern: I agree that this issue was apparently about the glossary entry, so making other changes is suspect and at a minimum requires adding relevant people from the experts list to nosy to get proper review of other proposed change

[issue23838] linecache and MemoryError

Serhiy Storchaka added the comment: Thank you for your review Victor. Will look on OpenIndiana buildbot. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue23821] test_pdb fails under -O

Serhiy Storchaka added the comment: Thank you for your review Xavier. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue23821] test_pdb fails under -O

Roundup Robot added the comment: New changeset 26778732099d by Serhiy Storchaka in branch '3.4': Issue #23821: Fixed test_pdb failure under -O. https://hg.python.org/cpython/rev/26778732099d New changeset 23442d957793 by Serhiy Storchaka in branch 'default': Issue #23821: Fixed test_pdb failure

[issue23838] linecache and MemoryError

Roundup Robot added the comment: New changeset d96e714a by Serhiy Storchaka in branch '2.7': Issue #23838: linecache now clears the cache and returns an empty result on https://hg.python.org/cpython/rev/d96e714a New changeset 88a0e6cd93c3 by Serhiy Storchaka in branch '3.4': Issue #23838

[issue23837] read pipe transport tries to resume reading after loop is gone

STINNER Victor added the comment: Oh, it looks like all pause_reading() and resume_reading() methods of transports check the status the transport (especially the _closing attribute), except two transports: _UnixReadPipeTransport and _SSLProtocolTransport. For _SSLProtocolTransport, I don't thi

[issue23484] SemLock acquire() keyword arg 'blocking' is invalid

R. David Murray added the comment: behavior vs enhancment for doc changes is really pretty meaningless/arbitrary, IMO. -- nosy: +r.david.murray ___ Python tracker ___ __

[issue23824] in-place addition of a shadowed class field

R. David Murray added the comment: And I'm telling you that *this is how Python is designed*, and it is not going to change. Class attributes are *special*, for a reason. Please do not reopen this issue again. If you wish to pursue this further, the language design discussion forum is the py

[issue2211] Cookie.Morsel interface needs update

R. David Murray added the comment: Heh, I thought it was closed. I guess my eyes were distracted by the 'fixed' resolution. -- ___ Python tracker ___ ___

[issue23833] email.header.Header folding modifies headers that include semi-colons

R. David Murray added the comment: The header folding algorithm is...not all that smart. There's a better one in the new policies in email in python3, which does not have this problem (it does have a few others, but the plan is to treat them as bugs and fix them :) IMO this isn't worth fixing

[issue23838] linecache and MemoryError

STINNER Victor added the comment: linecache_memoryerror_3.patch reviewed (comments on Rietveld). -- ___ Python tracker ___ ___ Python-

[issue23838] linecache and MemoryError

Serhiy Storchaka added the comment: On other side, linecache tests already use updatecache(). Here is a patch with a test. -- Added file: http://bugs.python.org/file38783/linecache_memoryerror_3.patch ___ Python tracker

[issue23779] imaplib authenticate raises TypeError if authenticator tries to abort

R. David Murray added the comment: Looks good to me, thanks. -- stage: patch review -> commit review ___ Python tracker ___ ___ Python

[issue23838] linecache and MemoryError

Serhiy Storchaka added the comment: This test depends on implementation details. I prefer to avoid adding such tests for trivial changes. -- ___ Python tracker ___ _

[issue23838] linecache and MemoryError

Changes by Serhiy Storchaka : -- type: -> resource usage versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___ ___ Pyt

[issue23838] linecache and MemoryError

STINNER Victor added the comment: > The question is left: should the patch be applied only on 3.5 or all versions? linecache_memoryerror_2.patch looks good to me, but it would be better with an unit test. IMO Python 2.7 and 3.4 can be fixed too. -- ___

[issue23838] linecache and MemoryError

STINNER Victor added the comment: > It is hard to write reliable test Ah? Why not using something like mock.patch('mock.updatecache', side_effect=MemoryError)? -- ___ Python tracker __

  1   2   >