Neale Ferguson added the comment:
Attaching a patch based off 3.5.0a3.
Note, for Py_ssize_t I had to add:
#ifdef PY_SSIZE_T_CLEAN
Py_ssize_t lNode, lUser, lName;
#else
int lNode, lUser, lName;
#endif
As if I did not, the values I got back were garbage. Is this because of some
Arfrever Frehtes Taifersar Arahesis added the comment:
New changeset 66e4ef9a7467 by Victor Stinner in branch 'default':
Issue #23648: Complete the list of modified functions for the PEP 475
https://hg.python.org/cpython/rev/66e4ef9a7467
+* special cases: :func:`os.close` and
Serhiy Storchaka added the comment:
Thanks for your outsight Arfrever.
--
resolution: - fixed
stage: - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
Roundup Robot added the comment:
New changeset 5cc0a090829a by Serhiy Storchaka in branch '3.4':
Issue #22977: Remove unconditional import of ctypes.
https://hg.python.org/cpython/rev/5cc0a090829a
New changeset f46454229cf5 by Serhiy Storchaka in branch 'default':
Issue #22977: Remove
Jeffrey Armstrong added the comment:
Oops, I meant WITH_THREAD. Thanks for the quick fix!
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23877
___
Fred L. Drake, Jr. added the comment:
Sorry for the delay. pprint_safe_key.patch looks good to me.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22721
___
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
components: +XML
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2174
___
Serhiy Storchaka added the comment:
For now there are three non-underscored names in subprocess that are missed in
__all__: SubprocessError, TimeoutExpired, and list2cmdline. SubprocessError and
TimeoutExpired are documented.
--
nosy: +serhiy.storchaka
stage: - needs patch
versions:
Changes by Ryan Gonzalez rym...@gmail.com:
Removed file: http://bugs.python.org/file38579/issue_20306.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
Changes by Piotr Dobrogost p...@bugs.python.dobrogost.net:
--
nosy: +piotr.dobrogost
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23246
___
___
Paul Moore added the comment:
Presumably this would just be a case of moving activate from
venv/scripts/posix to venv/scripts/common? I don't think including csh or fish
scripts on Windows is worthwhile...
Attached is a patch on that basis. I didn't see any tests for which scripts
were
Bill Parker added the comment:
Per Ned Deily, I did send 'ffi.c.patch' to the guys upstream at:
https://sourceware.org/libffi/
So hopefully they can review and fix it in the next release :)...
Given that Python is spread out, perhaps when a component is selected, it could
display source
Cyd Haselton added the comment:
Thanks Ryan, the patch worked.
Latest error (when building Modules/pwdmodule.c:)
^
./Modules/pwdmodule.c:86:2: error: stray '#' in program
+#endif
^
./Modules/pwdmodule.c:86:3: error: 'endif' undeclared (first use in this
function)
+#endif
^
Serhiy Storchaka added the comment:
Thank you for your review Fred.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22721
Ned Deily added the comment:
Thanks for the patches. For future reference, it would be better to open
separate issues for problems found in different areas of Python as there may be
different reviewers and dependencies. For example, libffi is a separate
project, mirrored with some patches
Roundup Robot added the comment:
New changeset c8815035116b by Serhiy Storchaka in branch 'default':
Issue #22721: An order of multiline pprint output of set or dict containing
https://hg.python.org/cpython/rev/c8815035116b
--
nosy: +python-dev
___
Fred L. Drake, Jr. added the comment:
Given that this has languished this long, patching historical releases seems
pointless.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2174
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
components: +Library (Lib) -Documentation, XML
resolution: - fixed
stage: - resolved
versions: +Python 3.5 -Python 2.7, Python 3.1, Python 3.2
___
Python tracker
Neale Ferguson added the comment:
Removed two debug statements
--
Added file: http://bugs.python.org/file38852/af_iucv.patch35
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23830
___
Ryan Gonzalez added the comment:
Remove the + at the beginning of line 87.
I re-uploaded issue_20306.patch to fix that issue.
--
Added file: http://bugs.python.org/file38853/issue_20306.patch
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22649
___
Mark Lawrence added the comment:
Can this be closed as there are ongoing discussions about libffi, particularly
with respect to bring it into the Windows external build system? I've tried to
find the relevant issue numbers but have failed, sorry :(
--
nosy: +BreamoreBoy
STINNER Victor added the comment:
I close the issue.
--
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23571
___
___
STINNER Victor added the comment:
I'm not more interested to work on this issue, so I just close it. I'm not
convinced that there is a real need for it in Python, and it's not obvious how
it should be exposed.
Open a new issue or reopen this issue if you want to work the issue.
--
STINNER Victor added the comment:
However I think the fd tests on windows is just fine to be skipped. So what's
the next plan? Shall we continue to work on it or just resolve this issue?
issue23566_fd_tests_v2.patch makes test_faulthandler.py a little more complex.
It's maybe better to just
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: -haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
___
Python-bugs-list
STINNER Victor added the comment:
Buildbot issues were unrelated and have been fixed. I close the issue.
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23752
STINNER Victor added the comment:
This issue was fixed in Python 3.5 as part of the PEP 475: see issue #23618
which modified socket.socket.connect() to handle EINTR. It's not as simple as
retrying connect() in a loop. You must respect the socket timeout (it's better
to have a monotonic clock
Roundup Robot added the comment:
New changeset cdc83da0b0f8 by Victor Stinner in branch 'default':
Issue #23853: socket.socket.sendall() does no more reset the socket timeout
https://hg.python.org/cpython/rev/cdc83da0b0f8
New changeset 5983f3fdacdb by Victor Stinner in branch 'default':
Issue
Roundup Robot added the comment:
New changeset af664f48b9b8 by Victor Stinner in branch 'default':
Issue #22117: Fix sock_call_ex() for non-blocking socket
https://hg.python.org/cpython/rev/af664f48b9b8
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset 7f54676348d3 by Victor Stinner in branch 'default':
Issue #23834: Fix initial value of the socket timeout
https://hg.python.org/cpython/rev/7f54676348d3
--
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23853
___
STINNER Victor added the comment:
tokenize.patch is wrong: you should not call buffer.close() if TextIOWrapper()
was created successfully.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23840
STINNER Victor added the comment:
No consensus was found, I close the issue.
--
resolution: - rejected
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23570
___
STINNER Victor added the comment:
But os.dup2 is not mentioned in PEP 475.
Currently, What's in Python 3.5 is more complete than the PEP 475. Another
example, the PEP doesn't mention signal.sigtimedwait(). The PEP should be
updated when the implementation will be finished.
--
Roundup Robot added the comment:
New changeset 1b509a7e3b99 by Victor Stinner in branch '2.7':
Issue #23458: Remove test_os.test_urandom_fd_non_inheritable()
https://hg.python.org/cpython/rev/1b509a7e3b99
--
___
Python tracker rep...@bugs.python.org
Changes by STINNER Victor victor.stin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23458
___
Yassine ABOUKIR added the comment:
Any updates concerning this issue ? is it going to be fixed or at least modify
the documentation in order to warn developers about this behaviour ?
--
___
Python tracker rep...@bugs.python.org
Serhiy Storchaka added the comment:
Proposed patch converts the _io module to Argument Clinic. Total 86 methods are
converted.
--
keywords: +patch
nosy: +benjamin.peterson, pitrou, serhiy.storchaka, stutzbach
stage: needs patch - patch review
Added file:
Alex Shkop added the comment:
When caller adds duplicate filter maybe we should promote his filter to the
beginning of filters list? This feels more correct to me. So if user adds
duplicate filter everything will work as if we added it.
--
Added file:
Nick Coghlan added the comment:
The change in 2.7.9 upstream was *absolutely* the right thing for the upstream
CPython community to do. The problem was real, it needed to be fixed, and the
community fixed it in a way that works just fine for folks in the earlier parts
of the technology
New submission from Jeffrey Armstrong:
If threads are disabled, either via --disable-threads or using a
compiler/standard library that doesn't support threads, the build will fail
when linking the Python interpreter because the following is undefined:
PyGILState_GetThisThreadState
The error
Alex Gaynor added the comment:
I'm concerned the _ssl changes will make security backports significantly more
difficult.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20179
___
New submission from Serhiy Storchaka:
Argument parsing code for functions _ssl.enum_certificates() and
_ssl.enum_crls() look not correct.
if (!PyArg_ParseTupleAndKeywords(args, kwds, s|s:enum_certificates,
kwlist, store_name)) {
return NULL;
Serhiy Storchaka added the comment:
_ssl.enum_certificates() and _ssl.enum_crls() is not converted because their
parsing code look incorrect (issue23875).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20179
New submission from Jeffrey Armstrong:
Within Modules/posixmodule.c:4914 (in 3.5.0a3), the preprocessor checks for
compiler macros as such:
#if ( defined(__WATCOMC__) || defined(PYCC_VACPP) ) !defined(__QNX__)
result = mkdir(path-narrow);
#else
result = mkdir(path-narrow,
Serhiy Storchaka added the comment:
Proposed patch converts the _ssl module to Argument Clinic. Total 39 methods
converted.
--
keywords: +needs review
nosy: +alex, christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou,
serhiy.storchaka
stage: needs patch - patch review
Added
Roundup Robot added the comment:
New changeset 29f51c4ae11a by Benjamin Peterson in branch 'default':
fix building without threads (closes #23877)
https://hg.python.org/cpython/rev/29f51c4ae11a
--
nosy: +python-dev
resolution: - fixed
stage: - resolved
status: open - closed
Neale Ferguson added the comment:
Corrected declaration of args to PyArg_ParseTuple() from int to Py_ssize_t.
--
Added file: http://bugs.python.org/file38845/af_iucv.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23830
Ryan Gonzalez added the comment:
Ah, crud. androidfn.h was a header I added but forgot to put the patch for. I
just attached the patch for that now.
The commit I based the patches on was by Alexander Belopolsky and was named
merge. Committed on February 28.
--
Added file:
Antoine Pitrou added the comment:
Le 06/04/2015 13:29, Nick Coghlan a écrit :
So while this isn't a feature upstream itself needs, it's one
potentially needed by multiple *downstreams*, so in my view it makes
sense for us to work with upstream to come up with the one obvious way
for
Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19817
___
Bill Parker added the comment:
In directory 'PC', file '_msi.c', I found another call to
malloc() which was not checked for a return value of NULL
which would indicate failure. The new patch file is below:
--- _msi.c.orig 2015-04-02 15:01:02.882326352 -0700
+++ _msi.c 2015-04-04
Roundup Robot added the comment:
New changeset e0ba8d3bed7e by Benjamin Peterson in branch '3.4':
remove extra arguments in arg parsing format codes (closes #23875)
https://hg.python.org/cpython/rev/e0ba8d3bed7e
New changeset 5f27e13faae2 by Benjamin Peterson in branch '2.7':
remove extra
Arfrever Frehtes Taifersar Arahesis added the comment:
Unconditional 'import ctypes' in Lib/test/test_exceptions.py was not yet
deleted.
--
nosy: +Arfrever
resolution: fixed -
stage: resolved -
status: closed - open
___
Python tracker
Bill Parker added the comment:
Addition of file 'ffi.c.patch'...
--
Added file: http://bugs.python.org/file38849/ffi.c.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23878
___
New submission from Bill Parker:
Hello All,
In reviewing code for Python-3.4.3 in directory
'Modules/_ctypes/libffi/src/arm', file 'ffi.c', I found a pair
of calls to calloc() which do not test for a return value
of NULL, indicating failure. The patch file below corrects
this issue:
---
Benjamin Peterson added the comment:
Good catch.
--
nosy: +benjamin.peterson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23875
___
___
58 matches
Mail list logo