[issue23830] Add AF_IUCV support to sockets

2015-04-06 Thread Neale Ferguson

Neale Ferguson added the comment:

Attaching a patch based off 3.5.0a3.

Note, for Py_ssize_t I had to add:

#ifdef PY_SSIZE_T_CLEAN
Py_ssize_t lNode, lUser, lName;
#else
int lNode, lUser, lName;
#endif

As if I did not, the values I got back were garbage. Is this because of some 
configuration parameter I failed to use?

However, the patch builds on s390x and x86_64 and the test passes on the former 
and is skipped on the latter.

--
Added file: http://bugs.python.org/file38850/af_iucv.patch35

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23830
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23648] PEP 475 meta issue

2015-04-06 Thread Arfrever Frehtes Taifersar Arahesis

Arfrever Frehtes Taifersar Arahesis added the comment:

 New changeset 66e4ef9a7467 by Victor Stinner in branch 'default':
 Issue #23648: Complete the list of modified functions for the PEP 475
 https://hg.python.org/cpython/rev/66e4ef9a7467

 +* special cases: :func:`os.close` and :func:`os.dup2` now ignore
 +  :py:data:`~errno.EINTR` error, the syscall is not retried (see the PEP
 +  for the rationale)

But os.dup2 is not mentioned in PEP 475.

--
nosy: +Arfrever

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23648
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22977] Unformatted “Windows Error 0x%X” exception message on Wine

2015-04-06 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Thanks for your outsight Arfrever.

--
resolution:  - fixed
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22977] Unformatted “Windows Error 0x%X” exception message on Wine

2015-04-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 5cc0a090829a by Serhiy Storchaka in branch '3.4':
Issue #22977: Remove unconditional import of ctypes.
https://hg.python.org/cpython/rev/5cc0a090829a

New changeset f46454229cf5 by Serhiy Storchaka in branch 'default':
Issue #22977: Remove unconditional import of ctypes.
https://hg.python.org/cpython/rev/f46454229cf5

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23877] Build fails when threads are disabled during configure step

2015-04-06 Thread Jeffrey Armstrong

Jeffrey Armstrong added the comment:

Oops, I meant WITH_THREAD.  Thanks for the quick fix!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23877
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22721] pprint output for sets and dicts is not stable

2015-04-06 Thread Fred L. Drake, Jr.

Fred L. Drake, Jr. added the comment:

Sorry for the delay.  pprint_safe_key.patch looks good to me.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22721
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2174] xml.sax.xmlreader does not support the InputSource protocol

2015-04-06 Thread Arfrever Frehtes Taifersar Arahesis

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:


--
components: +XML

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2174
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10838] subprocess __all__ is incomplete

2015-04-06 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

For now there are three non-underscored names in subprocess that are missed in 
__all__: SubprocessError, TimeoutExpired, and list2cmdline. SubprocessError and 
TimeoutExpired are documented.

--
nosy: +serhiy.storchaka
stage:  - needs patch
versions: +Python 3.5 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10838
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-06 Thread Ryan Gonzalez

Changes by Ryan Gonzalez rym...@gmail.com:


Removed file: http://bugs.python.org/file38579/issue_20306.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23246] distutils fails to locate vcvarsall with Visual C++ Compiler for Python

2015-04-06 Thread Piotr Dobrogost

Changes by Piotr Dobrogost p...@bugs.python.dobrogost.net:


--
nosy: +piotr.dobrogost

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23246
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22343] Install bash activate script on Windows when using venv

2015-04-06 Thread Paul Moore

Paul Moore added the comment:

Presumably this would just be a case of moving activate from 
venv/scripts/posix to venv/scripts/common? I don't think including csh or fish 
scripts on Windows is worthwhile...

Attached is a patch on that basis. I didn't see any tests for which scripts 
were installed, so I don't think there's anything to change there.

--
keywords: +patch
nosy: +paul.moore
Added file: http://bugs.python.org/file38851/activate.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22343
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23878] Missing sanity checks for various C library function calls...

2015-04-06 Thread Bill Parker

Bill Parker added the comment:

Per Ned Deily, I did send 'ffi.c.patch' to the guys upstream at:

https://sourceware.org/libffi/ 

So hopefully they can review and fix it in the next release :)...

Given that Python is spread out, perhaps when a component is selected, it could 
display source directories and/or files (just a suggestion here)...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23878
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-06 Thread Cyd Haselton

Cyd Haselton added the comment:

Thanks Ryan, the patch worked.

Latest error (when building Modules/pwdmodule.c:)

^
./Modules/pwdmodule.c:86:2: error: stray '#' in program
 +#endif
  ^
./Modules/pwdmodule.c:86:3: error: 'endif' undeclared (first use in this 
function)
 +#endif
   ^
./Modules/pwdmodule.c:86:3: note: each undeclared identifier is reported only 
once for each function it appears in
./Modules/pwdmodule.c:75:21: error: expected ';' before 'sets'
 #define SETS(i,val) sets(v, i, val)
 ^
./Modules/pwdmodule.c:87:5: note: in expansion of macro 'SETS'
 SETS(setIndex++, p-pw_dir);
 ^
./Modules/pwdmodule.c: At top level:
./Modules/pwdmodule.c:81:0: error: unterminated #else
 #ifdef HAVE_PASSWD_GECOS_FIELD
 ^
make: *** [Modules/pwdmodule.o] Error 1
/bld/python/cpython-master $

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22721] pprint output for sets and dicts is not stable

2015-04-06 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Thank you for your review Fred.

--
resolution:  - fixed
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22721
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23878] Missing sanity checks for various C library function calls...

2015-04-06 Thread Ned Deily

Ned Deily added the comment:

Thanks for the patches.  For future reference, it would be better to open 
separate issues for problems found in different areas of Python as there may be 
different reviewers and dependencies.  For example, libffi is a separate 
project, mirrored with some patches in the Python source repo.  You should 
report your proposed arm/ffi.c patch upstream: https://sourceware.org/libffi/

--
nosy: +ned.deily

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23878
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22721] pprint output for sets and dicts is not stable

2015-04-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset c8815035116b by Serhiy Storchaka in branch 'default':
Issue #22721: An order of multiline pprint output of set or dict containing
https://hg.python.org/cpython/rev/c8815035116b

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22721
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2174] xml.sax.xmlreader does not support the InputSource protocol

2015-04-06 Thread Fred L. Drake, Jr.

Fred L. Drake, Jr. added the comment:

Given that this has languished this long, patching historical releases seems 
pointless.

--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2174
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2174] xml.sax.xmlreader does not support the InputSource protocol

2015-04-06 Thread Arfrever Frehtes Taifersar Arahesis

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:


--
components: +Library (Lib) -Documentation, XML
resolution:  - fixed
stage:  - resolved
versions: +Python 3.5 -Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2174
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23830] Add AF_IUCV support to sockets

2015-04-06 Thread Neale Ferguson

Neale Ferguson added the comment:

Removed two debug statements

--
Added file: http://bugs.python.org/file38852/af_iucv.patch35

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23830
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-06 Thread Ryan Gonzalez

Ryan Gonzalez added the comment:

Remove the + at the beginning of line 87.

I re-uploaded issue_20306.patch to fix that issue.

--
Added file: http://bugs.python.org/file38853/issue_20306.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22649] Use _PyUnicodeWriter in case_operation()

2015-04-06 Thread STINNER Victor

Changes by STINNER Victor victor.stin...@gmail.com:


--
resolution:  - rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22649
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22176] update internal libffi copy to 3.1, introducing AArch64 and POWER ELF ABIv2

2015-04-06 Thread Mark Lawrence

Mark Lawrence added the comment:

Can this be closed as there are ongoing discussions about libffi, particularly 
with respect to bring it into the Windows external build system?  I've tried to 
find the relevant issue numbers but have failed, sorry :(

--
nosy: +BreamoreBoy

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22176
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23571] Raise SystemError if a function returns a result with an exception set

2015-04-06 Thread STINNER Victor

STINNER Victor added the comment:

I close the issue.

--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23571
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23459] Linux: expose the new execveat() syscall

2015-04-06 Thread STINNER Victor

STINNER Victor added the comment:

I'm not more interested to work on this issue, so I just close it. I'm not 
convinced that there is a real need for it in Python, and it's not obvious how 
it should be exposed.

Open a new issue or reopen this issue if you want to work the issue.

--
resolution:  - later
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23459
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23566] RFE: faulthandler.register() should support file descriptors

2015-04-06 Thread STINNER Victor

STINNER Victor added the comment:

 However I think the fd tests on windows is just fine to be skipped. So what's 
 the next plan? Shall we continue to work on it or just resolve this issue?

issue23566_fd_tests_v2.patch makes test_faulthandler.py a little more complex. 
It's maybe better to just skip tests on Windows, the code is already well 
tested on other platforms, and faulthandler.c doesn't contain code specific to 
Windows when handling file descriptors.

I close the issue, thanks for your patches Wei Wu!

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23566
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-06 Thread STINNER Victor

Changes by STINNER Victor victor.stin...@gmail.com:


--
nosy:  -haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23752] Cleanup io.FileIO

2015-04-06 Thread STINNER Victor

STINNER Victor added the comment:

Buildbot issues were unrelated and have been fixed. I close the issue.

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23752
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20611] socket.create_connection() doesn't handle EINTR properly

2015-04-06 Thread STINNER Victor

STINNER Victor added the comment:

This issue was fixed in Python 3.5 as part of the PEP 475: see issue #23618 
which modified socket.socket.connect() to handle EINTR. It's not as simple as 
retrying connect() in a loop. You must respect the socket timeout (it's better 
to have a monotonic clock here, it's now always the case in Python 3.5). When 
connect() returns EINTR, the connection runs asynchronously, you have to call 
select() to wait until the connection completes or fails. Then you have to call 
getsockopt() to get the socket error code.

In Python 3.5, socket.socket.connect() still raises InterruptedError if the 
socket is non-blocking:
https://docs.python.org/dev/library/socket.html#socket.socket.connect

issue20611-connect-eintr-gps01.diff calls again connect() if connect() failed 
with EINTR. According to the issue #23618, it might work on some platforms, but 
it's not portable.

For Python 2.7 and 3.4, instead of fixing socket.socket.connect(), which 
requires complex code, we may only workaround the issue in create_connection(). 
If connect() raises OSError(EINTR), drop the socket and retry with a fresh 
connection in a loop until the connection completes or raises a different 
exception. (And do that for each address.)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20611
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23853] PEP 475: handle EINTR in the ssl module

2015-04-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset cdc83da0b0f8 by Victor Stinner in branch 'default':
Issue #23853: socket.socket.sendall() does no more reset the socket timeout
https://hg.python.org/cpython/rev/cdc83da0b0f8

New changeset 5983f3fdacdb by Victor Stinner in branch 'default':
Issue #23853: Methods of SSL socket don't reset the socket timeout anymore each
https://hg.python.org/cpython/rev/5983f3fdacdb

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23853
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22117] Rewrite pytime.h to work on nanoseconds

2015-04-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset af664f48b9b8 by Victor Stinner in branch 'default':
Issue #22117: Fix sock_call_ex() for non-blocking socket
https://hg.python.org/cpython/rev/af664f48b9b8

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22117
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

2015-04-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 7f54676348d3 by Victor Stinner in branch 'default':
Issue #23834: Fix initial value of the socket timeout
https://hg.python.org/cpython/rev/7f54676348d3

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23834
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23853] PEP 475: handle EINTR in the ssl module

2015-04-06 Thread STINNER Victor

Changes by STINNER Victor victor.stin...@gmail.com:


--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23853
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

2015-04-06 Thread STINNER Victor

STINNER Victor added the comment:

tokenize.patch is wrong: you should not call buffer.close() if TextIOWrapper() 
was created successfully.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23840
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23570] Change with subprocess.Popen(): (context manager) to ignore broken pipe error

2015-04-06 Thread STINNER Victor

STINNER Victor added the comment:

No consensus was found, I close the issue.

--
resolution:  - rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23570
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23648] PEP 475 meta issue

2015-04-06 Thread STINNER Victor

STINNER Victor added the comment:

 But os.dup2 is not mentioned in PEP 475.

Currently, What's in Python 3.5 is more complete than the PEP 475. Another 
example, the PEP doesn't mention signal.sigtimedwait(). The PEP should be 
updated when the implementation will be finished.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23648
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-04-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 1b509a7e3b99 by Victor Stinner in branch '2.7':
Issue #23458: Remove test_os.test_urandom_fd_non_inheritable()
https://hg.python.org/cpython/rev/1b509a7e3b99

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23458
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23458] [2.7] random: make the file descriptor non-inheritable (on POSIX)

2015-04-06 Thread STINNER Victor

Changes by STINNER Victor victor.stin...@gmail.com:


--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23458
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23505] Urlparse insufficient validation leads to open redirect

2015-04-06 Thread Yassine ABOUKIR

Yassine ABOUKIR added the comment:

Any updates concerning this issue ? is it going to be fixed or at least modify 
the documentation in order to warn developers about this behaviour ?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23505
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20175] Derby #6: Convert 50 sites to Argument Clinic across 8 files

2015-04-06 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Proposed patch converts the _io module to Argument Clinic. Total 86 methods are 
converted.

--
keywords: +patch
nosy: +benjamin.peterson, pitrou, serhiy.storchaka, stutzbach
stage: needs patch - patch review
Added file: http://bugs.python.org/file38840/io_clinic.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20175
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18383] test_warnings modifies warnings.filters when running with -W default

2015-04-06 Thread Alex Shkop

Alex Shkop added the comment:

When caller adds duplicate filter maybe we should promote his filter to the 
beginning of filters list? This feels more correct to me. So if user adds 
duplicate filter everything will work as if we added it.

--
Added file: 
http://bugs.python.org/file38841/issue18383_remove_dups_and_test.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18383
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23857] Make default HTTPS certificate verification setting configurable via global ini file

2015-04-06 Thread Nick Coghlan

Nick Coghlan added the comment:

The change in 2.7.9 upstream was *absolutely* the right thing for the upstream 
CPython community to do. The problem was real, it needed to be fixed, and the 
community fixed it in a way that works just fine for folks in the earlier parts 
of the technology adoption curve.

Change management for the folks in the latter half of the technology adoption 
curve is a key part of what commercial redistributors get paid for. Delaying 
PEP 476 while we figured out the details of how that was going to work would 
have been a bad plan from a community perspective, so I took a speculative shot 
at providing a very simple solution for the redistributor case and 
unfortunately missed the target.

The reason I still want to negotiate the technical details of the feature 
upstream (despite missing the mark in PEP 476 itself) is so that all of us that 
need this functionality can provide the *same* behaviour to our respective 
customers, rather than having Red Hat do one thing, Suse another, Canonical a 
third, and then cross-platform Python redistributors like eGenix and 
ActiveState also needing to figure out their own scheme. It's akin to the 
problem faced by Linux redistributors that independently provide stable ABI 
guarantees, but also aim to collaborate on backporting fixes to the *same* 
stable ABI to reduce duplicated effort: 
http://crunchtools.com/deep-dive-rebase-vs-backport/#Brief_History

So while this isn't a feature upstream itself needs, it's one potentially 
needed by multiple *downstreams*, so in my view it makes sense for us to work 
with upstream to come up with the one obvious way for redistributors to 
handle the problem (now that we know that my initial attempt at providing such 
a way doesn't work in practice).

Probably the closest precedents to this idea are PEP 394 (regarding management 
of the unqualified python symlink) and the section with recommendations for 
downstream redistributors in PEP 453 (bundling pip).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23857
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23877] Build fails when threads are disabled during configure step

2015-04-06 Thread Jeffrey Armstrong

New submission from Jeffrey Armstrong:

If threads are disabled, either via --disable-threads or using a 
compiler/standard library that doesn't support threads, the build will fail 
when linking the Python interpreter because the following is undefined:

PyGILState_GetThisThreadState

The error is caused by a change since 3.5.0a1 that uses a call to this function 
in Python/pylifecycle.c:1303 without first checking if the WITH_THREADS macro 
is defined.  If WITH_THREADS is undefined, the function 
PyGILState_GetThisThreadState is not built.

I've attached a simple patch correcting the issue, but it should be trivial to 
add a simple macro check around the call.

--
components: Interpreter Core
files: pylifecycle-threads-3.5.0a3.patch
keywords: patch
messages: 240154
nosy: Jeffrey.Armstrong
priority: normal
severity: normal
status: open
title: Build fails when threads are disabled during configure step
type: compile error
versions: Python 3.5
Added file: http://bugs.python.org/file38844/pylifecycle-threads-3.5.0a3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23877
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

2015-04-06 Thread Alex Gaynor

Alex Gaynor added the comment:

I'm concerned the _ssl changes will make security backports significantly more 
difficult.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20179
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23875] Incorrect argument parsing in _ssl

2015-04-06 Thread Serhiy Storchaka

New submission from Serhiy Storchaka:

Argument parsing code for functions _ssl.enum_certificates() and 
_ssl.enum_crls() look not correct. 

if (!PyArg_ParseTupleAndKeywords(args, kwds, s|s:enum_certificates,
 kwlist, store_name)) {
return NULL;
}

The format contains codes for two string arguments. But only one address 
(store_name) is passed. And kwlist contains only one member, store_name.

These functions are provided only on Windows, so I can't check what happen if 
call them with two string arguments. May be crash or memory corruption.

--
components: Extension Modules
messages: 240151
nosy: alex, christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou, 
serhiy.storchaka
priority: normal
severity: normal
status: open
title: Incorrect argument parsing in _ssl
type: behavior
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23875
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

2015-04-06 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

_ssl.enum_certificates() and _ssl.enum_crls() is not converted because their 
parsing code look incorrect (issue23875).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20179
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23876] Fix mkdir() call for Watcom compilers on UNIX-like platforms

2015-04-06 Thread Jeffrey Armstrong

New submission from Jeffrey Armstrong:

Within Modules/posixmodule.c:4914 (in 3.5.0a3), the preprocessor checks for 
compiler macros as such:

#if ( defined(__WATCOMC__) || defined(PYCC_VACPP) )  !defined(__QNX__)
result = mkdir(path-narrow);
#else
result = mkdir(path-narrow, mode);
#endif

The purpose of the code was to detect if we're compiling using Watcom, but not 
on QNX, or VisualAge as our compiler, where mkdir() wouldn't accept a mode.  
However, Watcom supports Linux as well and properly implements the mode 
argument, causing the compilation to fail.

The proper check, rather than looking for !defined(__QNX__) would be 
!defined(__UNIX__), which would allow the code to properly compile using 
Watcom on either Linux or QNX:

#if ( defined(__WATCOMC__) || defined(PYCC_VACPP) )  !defined(__UNIX__)
result = mkdir(path-narrow);
#else
result = mkdir(path-narrow, mode);
#endif


FYI, in Watcom, the __UNIX__ macro is defined on both Linux and QNX, so this 
change will not break code for people who are still using Watcom to build 
Python for QNX (which is probably nobody at all).

There are two other places where the __QNX__ macro should be replaced in 
Modules/posixmodule.c, and the attached patch fixes both.

--
components: Interpreter Core
files: watcom_qnx_to_unix-3.5.0a3.patch
keywords: patch
messages: 240153
nosy: Jeffrey.Armstrong
priority: normal
severity: normal
status: open
title: Fix mkdir() call for Watcom compilers on UNIX-like platforms
type: compile error
versions: Python 3.5
Added file: http://bugs.python.org/file38843/watcom_qnx_to_unix-3.5.0a3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23876
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

2015-04-06 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Proposed patch converts the _ssl module to Argument Clinic. Total 39 methods 
converted.

--
keywords: +needs review
nosy: +alex, christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou, 
serhiy.storchaka
stage: needs patch - patch review
Added file: http://bugs.python.org/file38842/ssl_clinic.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20179
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23877] Build fails when threads are disabled during configure step

2015-04-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 29f51c4ae11a by Benjamin Peterson in branch 'default':
fix building without threads (closes #23877)
https://hg.python.org/cpython/rev/29f51c4ae11a

--
nosy: +python-dev
resolution:  - fixed
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23877
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23830] Add AF_IUCV support to sockets

2015-04-06 Thread Neale Ferguson

Neale Ferguson added the comment:

Corrected declaration of args to PyArg_ParseTuple() from int to Py_ssize_t.

--
Added file: http://bugs.python.org/file38845/af_iucv.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23830
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-06 Thread Ryan Gonzalez

Ryan Gonzalez added the comment:

Ah, crud. androidfn.h was a header I added but forgot to put the patch for. I 
just attached the patch for that now.

The commit I based the patches on was by Alexander Belopolsky and was named 
merge. Committed on February 28.

--
Added file: http://bugs.python.org/file38846/androidfn.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23857] Make default HTTPS certificate verification setting configurable via global ini file

2015-04-06 Thread Antoine Pitrou

Antoine Pitrou added the comment:

Le 06/04/2015 13:29, Nick Coghlan a écrit :
 
 So while this isn't a feature upstream itself needs, it's one
potentially needed by multiple *downstreams*, so in my view it makes
sense for us to work with upstream to come up with the one obvious way
for redistributors to handle the problem (now that we know that my
initial attempt at providing such a way doesn't work in practice).

So would it be possible for the actual implementation to be done outside
of CPython? (in a dedicated fork, for example)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23857
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19817] tracemalloc add a memory limit feature

2015-04-06 Thread Arfrever Frehtes Taifersar Arahesis

Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:


--
nosy: +Arfrever

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19817
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

2015-04-06 Thread Bill Parker

Bill Parker added the comment:

In directory 'PC', file '_msi.c', I found another call to
malloc() which was not checked for a return value of NULL
which would indicate failure.  The new patch file is below:

--- _msi.c.orig 2015-04-02 15:01:02.882326352 -0700
+++ _msi.c  2015-04-04 16:36:56.919605881 -0700
@@ -324,6 +324,10 @@
 code = MsiRecordGetInteger(err, 1); /* XXX code */
 if (MsiFormatRecord(0, err, res, size) == ERROR_MORE_DATA) {
 res = malloc(size+1);
+   if (res == NULL) /* malloc() failed, out of memory... */
+   PyErr_SetString(MSIError, out of memory);
+   return NULL;
+   }
 MsiFormatRecord(0, err, res, size);
 res[size]='\0';
 }
@@ -547,6 +551,10 @@
 fval, sval, ssize);
 if (status == ERROR_MORE_DATA) {
 sval = malloc(ssize);
+   if (sval == NULL) { /* malloc() failed, out of memory... */
+   PyErr_SetString(MSIError, out of memory);
+   return NULL;
+   }
 status = MsiSummaryInfoGetProperty(si-h, field, type, ival,
 fval, sval, ssize);
 }

--
Added file: http://bugs.python.org/file38847/_msi.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23855
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23875] Incorrect argument parsing in _ssl

2015-04-06 Thread Roundup Robot

Roundup Robot added the comment:

New changeset e0ba8d3bed7e by Benjamin Peterson in branch '3.4':
remove extra arguments in arg parsing format codes (closes #23875)
https://hg.python.org/cpython/rev/e0ba8d3bed7e

New changeset 5f27e13faae2 by Benjamin Peterson in branch '2.7':
remove extra arguments in arg parsing format codes (closes #23875)
https://hg.python.org/cpython/rev/5f27e13faae2

New changeset c9b9fb86d3fa by Benjamin Peterson in branch 'default':
merge 3.4 (#23875)
https://hg.python.org/cpython/rev/c9b9fb86d3fa

--
nosy: +python-dev
resolution:  - fixed
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23875
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22977] Unformatted “Windows Error 0x%X” exception message on Wine

2015-04-06 Thread Arfrever Frehtes Taifersar Arahesis

Arfrever Frehtes Taifersar Arahesis added the comment:

Unconditional 'import ctypes' in Lib/test/test_exceptions.py was not yet 
deleted.

--
nosy: +Arfrever
resolution: fixed - 
stage: resolved - 
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22977
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23878] Missing sanity checks for various C library function calls...

2015-04-06 Thread Bill Parker

Bill Parker added the comment:

Addition of file 'ffi.c.patch'...

--
Added file: http://bugs.python.org/file38849/ffi.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23878
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23878] Missing sanity checks for various C library function calls...

2015-04-06 Thread Bill Parker

New submission from Bill Parker:

Hello All,

   In reviewing code for Python-3.4.3 in directory
'Modules/_ctypes/libffi/src/arm', file 'ffi.c', I found a pair
of calls to calloc() which do not test for a return value
of NULL, indicating failure.  The patch file below corrects
this issue:

--- ffi.c.orig  2015-04-04 15:43:19.662709073 -0700
+++ ffi.c   2015-04-04 15:51:27.142665269 -0700
@@ -629,12 +629,21 @@
 
 /* We have valid trampoline and config pages */
 table = calloc (1, sizeof(ffi_trampoline_table));
+if (table == NULL) { /* oops, calloc() failed, now what??? */
+  fprintf(stderr, vm calloc() failure: %d at %s:%d\n, kt, __FILE__, 
__LINE__);
+  return NULL; /* go home??? */
+}
 table-free_count = FFI_TRAMPOLINE_COUNT;
 table-config_page = config_page;
 table-trampoline_page = trampoline_page;
 
 /* Create and initialize the free list */
 table-free_list_pool = calloc(FFI_TRAMPOLINE_COUNT, 
sizeof(ffi_trampoline_table_entry));
+if (table-free_list_pool == NULL) { /* oops, calloc() failed, now what */
+  fprintf(stderr, vm calloc() failure: %d at %s:%d\n, kt, __FILE__, 
__LINE__);
+  free(table);  /* free table (from previos calloc() call) */
+  return NULL;  /* go home??? *
+}
 
 uint16_t i;
 for (i = 0; i  table-free_count; i++) {

In directory 'Modules', file 'getpath.c', I found a call to fseek()
which is not checked for a return value  0, indicating failure.  The
patch file below corrects this issue:

--- getpath.c.orig  2015-04-04 16:07:25.540472702 -0700
+++ getpath.c   2015-04-04 16:09:30.988416490 -0700
@@ -265,7 +265,9 @@
 int result = 0; /* meaning not found */
 char buffer[MAXPATHLEN*2+1];  /* allow extra for key, '=', etc. */
 
-fseek(env_file, 0, SEEK_SET);
+if (fseek(env_file, 0, SEEK_SET)  0)
+return result;
+   
 while (!feof(env_file)) {
 char * p = fgets(buffer, MAXPATHLEN*2, env_file);
 wchar_t tmpbuffer[MAXPATHLEN*2+1];

I am attaching the patch file(s) to this bug report...

Bill Parker (wp02855 at gmail dot com)

--
components: Interpreter Core
files: getpath.c.patch
keywords: patch
messages: 240160
nosy: dogbert2
priority: normal
severity: normal
status: open
title: Missing sanity checks for various C library function calls...
type: behavior
versions: Python 3.4
Added file: http://bugs.python.org/file38848/getpath.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23878
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23875] Incorrect argument parsing in _ssl

2015-04-06 Thread Benjamin Peterson

Benjamin Peterson added the comment:

Good catch.

--
nosy: +benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23875
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com