[issue21148] avoid memset in small tuple creation

2015-04-13 Thread Raymond Hettinger

Raymond Hettinger added the comment:

I think this looks promising.

Don't worry too much about the modest timing improvement.  For the most part, 
we should almost always take steps to eliminate work that is known to be 
unnecessary.  The timings serve as a guide but it would be easy for us to get 
trapped in local minimums on a particular machine or compiler.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23943] Misspellings in a few files

2015-04-13 Thread Berker Peksag

Berker Peksag added the comment:

Thanks Piotr.

--
nosy: +berker.peksag
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions: +Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23943] Misspellings in a few files

2015-04-13 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 9f2bd9939d4b by Berker Peksag in branch '3.4':
Issue #23943: Fix typos. Patch by Piotr Kasprzyk.
https://hg.python.org/cpython/rev/9f2bd9939d4b

New changeset 4fb2075952a4 by Berker Peksag in branch 'default':
Issue #23943: Fix typos. Patch by Piotr Kasprzyk.
https://hg.python.org/cpython/rev/4fb2075952a4

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23908] Check path arguments of os functions for null character

2015-04-13 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

I can't test the patch on UNIX, this branch of the code is executed only on 
Windows.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17582] xml.etree.ElementTree does not preserve whitespaces in attributes

2015-04-13 Thread Raymond Hettinger

Changes by Raymond Hettinger :


--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

2015-04-13 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

How long time the test run (if there is enough memory)? May be we should 
decrease memory requirements by using shared values?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23937] IDLE start maximized

2015-04-13 Thread Raymond Hettinger

Raymond Hettinger added the comment:

I also teach students and prefer the current behavior.   It is egregious for 
apps to assume that they are the only thing running and to hide everything else 
(i.e. docs viewed through a browser).  This isn't the norm for most apps I work 
with either.

Though I'm -1 on this, I would support adding IDLE configuration option so that 
the user can specify that they want maximization.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18383] test_warnings modifies warnings.filters when running with "-W default"

2015-04-13 Thread Alex Shkop

Alex Shkop added the comment:

Removed unnecessary assertWarns() contexts and fixed spelling errors.

--
Added file: 
http://bugs.python.org/file38982/issue18383_assert_warns_and_dups_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23507] Tuple creation is too slow

2015-04-13 Thread Raymond Hettinger

Raymond Hettinger added the comment:

Unassigning because I don't have an interest in going further down this path.  
I used this technique with zip() because tuple reuse nicely benefited the 
common case of "for a,b,c in zip(alist, blist, clist): ...".  

On another thread, I did see mention of removing the memset() from tuple 
creation and that seems like a promising direction.

--
assignee: rhettinger -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23310] Mock constructor configuration fails for magic methods

2015-04-13 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 4d1236b180be by Łukasz Langa in branch 'default':
Issue #23310: Fix MagicMock's initializer to work with __methods__.
https://hg.python.org/cpython/rev/4d1236b180be

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20309] Not all method descriptors are callable

2015-04-13 Thread Raymond Hettinger

Raymond Hettinger added the comment:

I don't agree that this is a bug that should be fixed.  It adds code that will 
likely never get called or needed (i.e. there has never been a request for this 
in the decade long history of desciptors and it seems like a made up 
requirement to me.  

I concur with Amrin's comment that this "is good enough" and Nick's comment 
that "it's just a matter of pattern of use'.  I recommend that this be closed 
as "not-a-bug" and that we avoid gratuitous API expansion for what Larry states 
is likely "foolish consistency".  

If someone object to recommendation to close and really wants to push for this, 
I recommend making a business case for acceptance and then assigning this issue 
to Guido for a decision.  This is his code and AFAICT he intentionally didn't 
go down a number of possible paths for descriptors simply because there weren't 
motivating use cases.  To the extent that __call__ was omitted on some 
descriptors, I don't think it was an accident (most of this code was developed 
as the same time by the same person with deliberate differences between each of 
them).   His write-ups for descriptors when they were introduced make no 
mention of an implied requirement for callability.


FWIW, issue 19072 isn't really related to this one.  That issue is a feature 
request to support descriptor chainging and it isn't clear whether that should 
be supported or left as-in.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

2015-04-13 Thread Joe Jevnik

Joe Jevnik added the comment:

Steve, we talked about the possibility of having you run some of these tests on 
a machine with a large amount of ram; I am adding you to the nosy list.

--
nosy: +steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22631] Feature Request CAN_RAW_FD_FRAMES

2015-04-13 Thread Joe Jevnik

Joe Jevnik added the comment:

So I think the patch could be applied to 3.4; I will look into moving the other 
back sometime this week.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23350] Content-length is incorrect when request body is a list or tuple

2015-04-13 Thread Demian Brecht

Demian Brecht added the comment:

Vincent: The logic to determine content length is undergoing a bit of an 
overhaul as part of #12319, which I'm hoping to wrap up in the next week or so.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23377] HTTPResponse may drop buffer holding next response

2015-04-13 Thread Demian Brecht

Demian Brecht added the comment:

> I think it's ok to slightly break a non-public API since it's required to fix 
> an obvious bug.

To play devil's advocate here, /is/ this really non-public API? According to 
documented Python naming conventions, HTTPResponse is part of the public API. 
From code I've written myself, this would likely create a number of breakages. 
Granted, it would largely be in lower level testing code, but it would still 
create a headache. Is something that's lightly documented as being non-public 
take precedence over well known and used naming conventions? I'd argue no, it 
shouldn't.

That said, I'm not overly enthused about the alternative Martin describes, so 
at first thought, I'm pretty much square on the fence about this.

> By the way, I guess we don't support HTTP pipelining, right?

As Martin pointed out, sadly no. There's currently an internal state machine 
that seems to possibly be remnants of an initial implementation (just a guess, 
I haven't done any research into it to prove that though) that prevents 
pipelining. It's on my list of things to tackle as it seems to be a natural 
progression to HTTP/2.0 multiplexing, but unfortunately my time is a little 
shorter than usual at the moment (taking a new job has cut into my spare time a 
little).

@Martin:

I haven't had a chance to review the change in detail yet, but I think the 
idea's sound. I'll try to get some time over the next few days to dig into it 
further.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23193] Please support "numeric_owner" in tarfile

2015-04-13 Thread Berker Peksag

Berker Peksag added the comment:

* +.. method:: TarFile.extractall(path=".", members=None, numeric_owner=False)

  numeric_owner can be a keyword-only argument.

* TarFile.extract and TarFile.extractall docs need a versionchanged directive.

* It would be nice to add an entry to Doc/whatsnew/3.5.rst

* +filename_1 = fname
  +dirname_1 = dirname
  +filename_2 = os.path.join(dirname, fname)

  I'd just yield fname, dirname, os.path.join(dirname, fname) here.

* +for name, uid, gid, typ, contents in [(fname, 99, 98, 
tarfile.REGTYPE, fobj),
  +  (dirname, 77, 76, 
tarfile.DIRTYPE, None),
  +  (os.path.join(dirname, 
fname), 88, 87, tarfile.REGTYPE, fobj),
  +  ]:

  Moving the list to a new variable would be more readable.

* Typo: # ceate -> # create

* +def root_is_uid_gid_0():

  Question: Can't we use something like root_in_posix in test_os here?

* +with tarfile.open(tar_filename) as r:

  Nitpick: What does "r" mean here? "tar" or "tarobj" looks more readable to me.

* Nitpick: I'd prefer ``None`` over :const:`True`. However, the current style 
is just "true" in the tarfile documentation.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23193] Please support "numeric_owner" in tarfile

2015-04-13 Thread Eric V. Smith

Eric V. Smith added the comment:

Other than Misc/NEWS, I think this is the final version of this patch.

--
Added file: 
http://bugs.python.org/file38981/tarfile-numeric-owner-with-tests-3.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20362] longMessage attribute is ignored in unittest.TestCase.assertRegexpMatches etc

2015-04-13 Thread Ilia Kurenkov

Ilia Kurenkov added the comment:

Thanks for the quick response, Berker! Let me address your comments in the 
order you made them.

#1: removing checking for "kot" in the exception args.
This line was causing the tests to fail, which is how I noticed it. The reason 
it fails (I think) is caused by the changes made in the patch. Namely, the fact 
that we're strictly sticking to longMessage=False means the custom message 
passed by the user (in this particular case that's "Message") is be the *only* 
thing sent to AssertionError. Thus checking for the presence of "kot" in this 
error's args doesn't seem to make much sense and will simply keep breaking our 
tests.
Now it goes without saying that I may have missed something, please let me know 
if that's the case.

#2
For some reason I got the impression that the tests should be using the newer 
method names, but since using the old ones didn't break them on my machine, 
I've updated the patch file accordingly. I'll upload it pending your feedback 
regarding #1.

Glad to help!
Ilia.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-13 Thread Zachary Ware

Zachary Ware added the comment:

Will do in the morning.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-13 Thread Larry Hastings

Larry Hastings added the comment:

If you give me a test case I'll knock this out.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23925] test_cmd_line failing on PYTHONSTARTUP

2015-04-13 Thread Jamiel Almeida

Jamiel Almeida added the comment:

As pointed by ncoghlan, the test needs to (by definition) not use -E or -I, but 
PYTHONSTARTUP env var breaks the test, so the patch makes the env not have any 
pre-existing PYTHON* env vars.

Ideally this should be another type of helper in script_helper, no?

--
keywords: +patch
Added file: http://bugs.python.org/file38980/fix-issue23925.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21916] Create unit tests for turtle textonly

2015-04-13 Thread R. David Murray

R. David Murray added the comment:

I made some review comments on ways to use test.support and test.subTest to 
simplify the code and make it even clearer.  Also, I suggest not using Mock 
unless necessary (see review comments).

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-13 Thread Zachary Ware

New submission from Zachary Ware:

For example:

_winapi_CreateFile_impl(PyModuleDef *module, LPCTSTR file_name, DWORD 
desired_access, DWORD share_mode, LPSECURITY_ATTRIBUTES security_attributes, 
DWORD creation_disposition, DWORD flags_and_attributes, HANDLE template_file)

--
components: Argument Clinic
messages: 240831
nosy: larry, zach.ware
priority: low
severity: normal
stage: needs patch
status: open
title: Argument Clinic: wrap impl's declaration if it's too long
type: enhancement
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19543] Add -3 warnings for codec convenience method changes

2015-04-13 Thread Dustin J. Mitchell

Dustin J. Mitchell added the comment:

This fixes the four cases Nick referred to, although not in the functions 
expected:

 - str.encode no longer exists
 - unicode.decode no longer exists
 - encoders used by str.encode must return bytes (does not apply to 
codecs.encode)
 - decoders used by unicode.decode must return unicode (does not apply to 
codecs.decode)

--
keywords: +patch
nosy: +djmitche
Added file: http://bugs.python.org/file38979/issue19543.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22812] Documentation of unittest -p usage wrong on windows.

2015-04-13 Thread Zachary Ware

Zachary Ware added the comment:

As an aside: Pam, I got a bounce notice from the email that Rietveld tried to 
send you.  It claims that your email account is disabled, though I suspect that 
might be it's way of saying it thinks Rietveld is spam (since it tries to send 
in the reviewer's name).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22812] Documentation of unittest -p usage wrong on windows.

2015-04-13 Thread Zachary Ware

Zachary Ware added the comment:

I left a comment on Rietveld.  Also, the test doesn't pass on Windows:

test test_unittest failed -- Traceback (most recent call last):
  File "C:\Data\code\CPython\hg.python.org\devinabox\cpython\lib\unittest\test\t
est_discovery.py", line 677, in test_command_line_handling_do_discovery_calls_lo
ader
self.assertEqual(Loader.args, [('.', "'test*.py'", None)])
AssertionError: Lists differ: [('.', 'test*.py', None)] != [('.', "'test*.py'",
None)]

First differing element 0:
('.', 'test*.py', None)
('.', "'test*.py'", None)

- [('.', 'test*.py', None)]
+ [('.', "'test*.py'", None)]
?+  +

--
nosy: +zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12485] textwrap.wrap: new argument for more pleasing output

2015-04-13 Thread Gijsbert Anthony van der Linden

Gijsbert Anthony van der Linden added the comment:

Updated the patch and added tests. Fixed a problem with the previous patch: 
result of map function was assumed to be list, however map in Python3 returns 
an interator. So I replaced it with a list comprehension.

--
nosy: +gavanderlinden
versions: +Python 3.5 -Python 3.3
Added file: http://bugs.python.org/file38978/Issue12485.v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23921] Standardize documentation whitespace, formatting

2015-04-13 Thread James Edwards

James Edwards added the comment:

Thanks Berker, I responded to most of your comments in rietveld.

A few of your comments suggested "we should get rid of X", and while I can't 
say I disagree, I really tried to limit the scope of the changes to whitespace 
and formatting.

As far as the script goes, it still requires significant human interaction.

Of the 1983 code snippets it extracts[1], 346 still raise warnings and require 
human verification.  The majority of these snippets aren't actually intended to 
be Python code.  Some of the snippets are C code, others are optparse/argparse 
command line examples, configparser config files, or just sections where the 
author wanted to use a literal block in the documentation.[2]

Of course, when the script triggers on one of these blocks, I ignore it.

Eventually, my goal was to have the script also verify interactive code blocks, 
much like doctest, but I thought a good intermediary step was to unify the 
whitespace.

As for the value, I understand the concern one might have before embarking on 
the process of standardizing the whitespace and formatting -- but given that 
it's mostly done and comes neatly packaged in a patch, I'm not sure I 
understand any remaining concerns.  In other words, if it's not something you 
would spend time on personally, because you have better ways to contribute/ 
spend your time, I absolutely understand that.  But given that the majority of 
the leg work is done by the patch, I hope you'll consider merging the changes.

In general the goal was to make the snippets, especially in the tutorial-type 
sections consistent, to allow the reader to become comfortable with the 
language instead of being distracted by varied formatting and to facilitate 
readability.  I hope this explains the motivation behind the effort.

[1] Some files were ignored from future runs after the snippets were validated, 
because they contained too many false positives, e.g. ctypes.rst.  So this 
count doesn't reflect the blocks in those ignored files.

[2] I wonder if explicitly indicating which rst literal blocks are intended to 
be python code would be of some benefit.  For example, adding such a tag could 
trigger the automatic formatting checks and, for interactive blocks, run the 
automatic doctest-type verification I was envisioning.  I may think more about 
the feasibility of this and bring it to python-ideas/python-dev.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23943] Misspellings in a few files

2015-04-13 Thread Piotr Kasprzyk

New submission from Piotr Kasprzyk:

Correct misspellings in various files.

--
assignee: docs@python
components: Documentation
files: misspellings.patch
keywords: patch
messages: 240825
nosy: docs@python, kwadrat
priority: normal
severity: normal
status: open
title: Misspellings in a few files
type: enhancement
versions: Python 3.5
Added file: http://bugs.python.org/file38977/misspellings.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14484] missing return in win32_kill?

2015-04-13 Thread Zachary Ware

Zachary Ware added the comment:

That's a fair point.  So to make my plan work, we'd really need a good
way to differentiate CTRL_C_EVENT and 0.  If anybody has any good
ideas on that, I still like my plan.  If not, I'm afraid I have to
agree that os.kill will need to go down as doomed by Windows'
incompatibility with the rest of the world.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23719] PEP 475: port test_eintr to Windows

2015-04-13 Thread John Ehresman

John Ehresman added the comment:

Here's the 1st draft of a test for interrupts during time.sleep().  It creates 
a thread to generate the ctrl-c events which seems to work well (note that 
kill() on win32 is quite limited in terms of sending events to other 
processes).  The creation and use of the subthread probably could be improved.  
I also needed to add a way of specifying creationflags for a subprocess so a 
new console could be created; otherwise the parent test process is also 
interrupted by the ctrl-c.

I have not tested the modified test on a non-win32 platform

--
keywords: +patch
nosy: +jpe
Added file: http://bugs.python.org/file38976/win32-sleep-test.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-13 Thread Cyd Haselton

Cyd Haselton added the comment:

Unfortunately starting from scratch did not solve the issue.  Still getting a 
segfault when the newly built binary tries to run sysconfig

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23686] Update Windows and OS X installer OpenSSL to 1.0.2a

2015-04-13 Thread Marc-Andre Lemburg

Marc-Andre Lemburg added the comment:

On 14.04.2015 01:36, Ned Deily wrote:
> 
>> https://github.com/openssl/openssl/pull/218
>> (certificate expiry checks not working)
> 
> That issue appears to have been fixed in 1.0.2a, no?

Yes, but it shows the kind of errors to expect in the early
stages of a new branch. The above was a complete bummer.

However, I'm more concerned about the security issues that
were found so far in the 1.0.2 release. IMO, we should at least
wait for a 1.0.2b or 1.0.2c release before pushing 1.0.2 to
the users - at least for patch level releases of stable Python
versions such as Python 2.7 or 3.4.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13814] Document why generators don't support the context management protocol

2015-04-13 Thread R. David Murray

R. David Murray added the comment:

Looks like the right approach, I hadn't thought of the design FAQ, but it makes 
sense as a place to put it.  I made a couple of review comments.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14484] missing return in win32_kill?

2015-04-13 Thread John Ehresman

John Ehresman added the comment:

A problem with os.kill with CTRL_C_EVENT is that CTRL_C_EVENT == 0 and on unix 
kill w/ a signal number of 0 is how you test to see if a process is running.  
This means that code written on unix to see if a process exists will try to 
send a ctrl-c to the other process; it will fail because 
GenerateConsoleCtrlEvent is so limited but the error message is likely to be 
confusing.

Not using the kill() name also means that developers coming from unix won't 
expect other signal numbers to work.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-13 Thread Christie

Christie added the comment:

Okee dokee, I'll tackle that first!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13850] Summary tables for argparse add_argument options

2015-04-13 Thread Stéphane Wirtel

Stéphane Wirtel added the comment:

Hi all,

If you think the patch is ok, please merge it, we will close this issue.

Thanks

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue13850] Summary tables for argparse add_argument options

2015-04-13 Thread R. David Murray

R. David Murray added the comment:

I think it would be better to move the summary table to the end (just before 
the Action section), and add another link to the summary to the sentence "The 
following sections describe how each of these are used."  That is, follow that 
sentence with something like 'a summary table of the relevance of each paramter 
to the various possible actions is given at the end of the section', with a 
link on summary table.

Otherwise, the patch looks good to me.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14484] missing return in win32_kill?

2015-04-13 Thread Zachary Ware

Zachary Ware added the comment:

I think what I'd rather do is deprecate the use of os.kill (on Windows) with a 
signal other than CTRL_C_EVENT and CTRL_BREAK_EVENT, document very clearly that 
os.kill is strictly for sending signals, and add os.terminate to implement 
TerminateProcess.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23929] Minor typo (way vs. away) in os.renames docstring

2015-04-13 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 94c3cd410cf6 by Benjamin Peterson in branch '3.4':
remove useless word (closes #23929)
https://hg.python.org/cpython/rev/94c3cd410cf6

New changeset feb0717c1004 by Benjamin Peterson in branch '2.7':
remove useless word (closes #23929)
https://hg.python.org/cpython/rev/feb0717c1004

New changeset 4f90751edb4f by Benjamin Peterson in branch 'default':
merge 3.4 (#23929)
https://hg.python.org/cpython/rev/4f90751edb4f

--
nosy: +python-dev
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11754] Check calculated constants in test_string.py

2015-04-13 Thread R. David Murray

R. David Murray added the comment:

Thanks, Chalmer.  Hopefully Benjamin won't be too annoyed by these :)

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed
versions:  -Python 2.7, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11754] Check calculated constants in test_string.py

2015-04-13 Thread Roundup Robot

Roundup Robot added the comment:

New changeset e1457e9f340f by R David Murray in branch 'default':
#11754: test contents of string module attributes.
https://hg.python.org/cpython/rev/e1457e9f340f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23686] Update Windows and OS X installer OpenSSL to 1.0.2a

2015-04-13 Thread Marc-Andre Lemburg

Marc-Andre Lemburg added the comment:

On 14.04.2015 01:41, Donald Stufft wrote:
> 
> I'm pretty massively +1 in Python shipping 1.0.2 (or really, whatever the 
> latest OpenSSL is) wherever it can, including the OSX installers even on 
> systems where Apple ships it's ancient OpenSSL.

Eventually, yes, but the question is: is jumping on such an early
release of a new OpenSSL branch a good idea.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14484] missing return in win32_kill?

2015-04-13 Thread John Ehresman

John Ehresman added the comment:

I think at a minimum, a return should be added in the cases that call 
GenerateConsoleCtrlEvent and it fails.

Here's a more radical proposal, though: deprecate kill() on Windows and add a 
function that calls GenerateConsoleCtrlEvent and another that calls 
TerminateProcess.  The rationale is that the two do act quite a bit differently 
than kill does on non-Windows systems do and it's a bad idea to try to provide 
cross-platform functionality when it can't be done.  kill() on non-Windows 
systems would be left alone.

--
nosy: +jpe

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-13 Thread Ned Deily

Changes by Ned Deily :


--
nosy: +twouters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23686] Update Windows and OS X installer OpenSSL to 1.0.2a

2015-04-13 Thread Donald Stufft

Donald Stufft added the comment:

I think 1.0.2 is the only version of OpenSSL that has the ability to short 
circuit the chain validation which is something that makes it easier for 
libraries like requests to remove the weak 1024 bit roots from their SSL 
certificate store.

It's also needed for ALPN support which libraries like hyper will need in order 
to support HTTP/2.

I'm pretty massively +1 in Python shipping 1.0.2 (or really, whatever the 
latest OpenSSL is) wherever it can, including the OSX installers even on 
systems where Apple ships it's ancient OpenSSL.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10612] StopTestRun exception to halt test run

2015-04-13 Thread R. David Murray

R. David Murray added the comment:

I've added some review comments.  I did not download the patch and run the 
tests etc; it would be great if you could find another sprinter (or anyone :) 
to do that level of review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23686] Update Windows and OS X installer OpenSSL to 1.0.2a

2015-04-13 Thread Ned Deily

Ned Deily added the comment:

I don't have a really strong feeling one way or the other.  It's not a big 
issue for the OS X installers as this only affects the much-less-used 
32-bit-only installer for old systems.  So this is really primarily an issue 
affecting the Windows installers.  I guess one could argue that 1.0.2 is the 
current path forward for OpenSSL particularly over the support lifetime of 
3.5.0 and there will be ample opportunity to update as necessary whatever 
version of the OpenSSL is included, both prior to the 3.5.0 release date and 
afterwards but there is something to be said for being a bit conservative wrt 
new OpenSSL release branches.  I think it would be good to solicit the opinion 
of the other core developers interested in security and the Windows installers 
and let Larry make the call, if necessary.

Alex, Donald, Antoine, Steve: any comments on shipping 1.0.1x vs 1.0.2x? 


> https://github.com/openssl/openssl/pull/218
> (certificate expiry checks not working)

That issue appears to have been fixed in 1.0.2a, no?

--
nosy: +dstufft, larry, pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-13 Thread Terry J. Reedy

Changes by Terry J. Reedy :


--
versions: +Python 3.5 -Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20586] Argument Clinic: functions with valid sig but no docstring have no __text_signature__

2015-04-13 Thread Zachary Ware

Zachary Ware added the comment:

Thanks Larry

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23922] turtle.py and turtledemo use the default tkinter icon

2015-04-13 Thread Terry J. Reedy

Terry J. Reedy added the comment:

The blue feather is the tk 8.6 icon.  The tk 8.5 and before icon is a red 
script 'Tk'.

The title bar icons for Idle were added in #20406.  It was a bit of a challenge 
to get them to work right and look good enough for all versions on all systems. 
 The icons were taken from the repository PC directory, which does not get 
installed.  I forget whether the ones committed were direct copies or modified. 
 I know I had in mind some future editing.  See msg209747

I agree with the general idea.  However, PEP 434 defines the idlelib api as 
mostly private.  Indeed, I might like to someday rename and refactor 
PyShell.py.  Rather than add an idlelib dependency (in particular PyShell.py) 
to turtle, I would prefer to move generic tkinter code to the tkinter tree.  (I 
might even like to remove the idlelib dependency from turtledemo this way, but 
this is a future issue.)

In this case, the tkinter addition would be a new method on the application 
window or toplevel class: def set_icon(self, icon_dir, icon_file): .  Icon_file is the base name which gets .ico, .gif, or 
.png added.  This non-obvious code would then be available to all.  Serhiy, 
what do you think of this?

However, I have no reason to rename the icon files, so turtle could reuse 
those.  But a better application icon for turtle and turtledemo might be new 
icons with the two snakes on the back of a turtle shell.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20586] Argument Clinic: functions with valid sig but no docstring have no __text_signature__

2015-04-13 Thread Roundup Robot

Roundup Robot added the comment:

New changeset e75fd221a53e by Zachary Ware in branch 'default':
Issue #20586: Argument Clinic now ensures signatures on functions without 
docstrings.
https://hg.python.org/cpython/rev/e75fd221a53e

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11754] Check calculated constants in test_string.py

2015-04-13 Thread chalmer_lowe

chalmer_lowe added the comment:

Based on review comments, in order to reduce unnecessary redundancy in the 
tests:
- composed later strings from previously defined substrings, where it made 
sense to do so.

--
Added file: http://bugs.python.org/file38975/issue11754_patch_2.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20586] Argument Clinic: functions with valid sig but no docstring have no __text_signature__

2015-04-13 Thread Larry Hastings

Larry Hastings added the comment:

LGTM

--
assignee:  -> zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-13 Thread R. David Murray

R. David Murray added the comment:

Apparently I was imaginig that script_helpers had been moved into test.support. 
 test.support was changed into a module in prep for doing so, but as far as I 
can see it was never moved.  So that does remain to be done as well, and should 
be done first.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23942] Explain naming of the patch files in the bug tracker

2015-04-13 Thread Maciej Szulik

New submission from Maciej Szulik:

During the lifecycle of a bug you do:
1. submit a patch
2. get a review with some comments
3. re-submit the patch

Talking to R. David Murray I got info there's no convention on naming those, I 
think it will be valuable to have some information in the devguide about that. 

Apparently you can either (when just fixing the patch) to stick with exactly 
the same name or add increasing suffix, eg. mypatch-1, mypatch-2, etc.).  
Otherwise you can change the name, but the review system will be able to pick 
up the right patch, so you should not worry about that.

--
components: Devguide
messages: 240800
nosy: ezio.melotti, maciej.szulik, willingc
priority: normal
severity: normal
status: open
title: Explain naming of the patch files in the bug tracker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22631] Feature Request CAN_RAW_FD_FRAMES

2015-04-13 Thread Matthias Klose

Matthias Klose added the comment:

it would be nice to have these constants backported to both 2.7 and 3.4. It may 
be good to check for other missing consgtants in this module in 2.7 and 3.4.

--
nosy: +doko

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21400] Code coverage documentation is out-of-date.

2015-04-13 Thread Ned Deily

Ned Deily added the comment:

Done.  Thanks for the patch, Heather.  (By the way, if you plan to contribute 
more changes, please sign the PSF Contributor Form as described here:  
https://docs.python.org/devguide/coredev.html#sign-a-contributor-agreement)

--
nosy: +ned.deily
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16914] timestamping in smtplib.py to help troubleshoot server timeouts/delays

2015-04-13 Thread Maciej Szulik

Maciej Szulik added the comment:

Uploading updated version of the patch.

--
Added file: http://bugs.python.org/file38974/issue16914.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21400] Code coverage documentation is out-of-date.

2015-04-13 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 24536e980c9e by Ned Deily in branch 'default':
Issue #21400: Update the code coverage section to remove out-of-date
https://hg.python.org/devguide/rev/24536e980c9e

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23686] Update Windows and OS X installer OpenSSL to 1.0.2a

2015-04-13 Thread Marc-Andre Lemburg

Marc-Andre Lemburg added the comment:

On 14.04.2015 00:29, Ned Deily wrote:
> 
> For what it's worth, the resolution of Issue23476 uses an API that was added 
> in OpenSSL 1.0.2.

Hmm, I don't think that's a good move at this time.

Most Linux users won't benefit from this since their system OpenSSL
will be 1.0.1 and 1.0.2 still has major security bugs being resolved:

https://www.openssl.org/news/secadv_20150319.txt
(look at the number of 1.0.2 only security bugs)

apart from 1.0.2a being the first 1.0.2 version which works at all:

https://github.com/openssl/openssl/pull/218
(certificate expiry checks not working)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-13 Thread Arnon Yaari

Changes by Arnon Yaari :


Added file: http://bugs.python.org/file38973/patch_4254.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23926] skipitem() in getargs.c still supports 'w' and 'w#', and shouldn't

2015-04-13 Thread Joe Jevnik

Joe Jevnik added the comment:

here is a patch and test case.
I added an entry to Misc/NEWS. I tried to follow the format; however, let me 
know if I have done this incorrectly.

--
keywords: +patch
nosy: +ll
Added file: http://bugs.python.org/file38972/skipitems.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-13 Thread Arnon Yaari

Changes by Arnon Yaari :


Added file: http://bugs.python.org/file38971/manual_test_4254.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4254] _cursesmodule.c callable update_lines_cols()

2015-04-13 Thread Arnon Yaari

Arnon Yaari added the comment:

Creating an automatic test for this issue proves difficult, as using curses to 
resize the terminal already updates the values, and using ioctls to try to 
bypass curses, doesn't work.
I'm adding a manual test program (mostly taken from 
http://www.gossamer-threads.com/lists/python/python/226137), and a newer patch 
with documentation.

--
nosy: +wiggin15

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21815] imaplib truncates some untagged responses

2015-04-13 Thread Maciej Szulik

Maciej Szulik added the comment:

Lita always look for them next to your uploaded file, there's a review link 
that points to Rietveld Code Review Tool. There you'll find all those 
information, just for future use :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21217] inspect.getsourcelines finds wrong lines when lambda used argument to decorator

2015-04-13 Thread Nick Coghlan

Nick Coghlan added the comment:

It sounds like at least a somewhat functional dis module is a pragmatic 
requirement for a Python implementation to support introspection, so +1 for 
reverting to the mandatory dependency on dis rather than duplicating its logic.

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21400] Code coverage documentation is out-of-date.

2015-04-13 Thread Carol Willing

Carol Willing added the comment:

Patch applies cleanly. The out of date link has been removed.
+1 ready for a core dev to merge.

--
nosy: +willingc
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23686] Update Windows and OS X installer OpenSSL to 1.0.2a

2015-04-13 Thread Ned Deily

Ned Deily added the comment:

For what it's worth, the resolution of Issue23476 uses an API that was added in 
OpenSSL 1.0.2.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21217] inspect.getsourcelines finds wrong lines when lambda used argument to decorator

2015-04-13 Thread Thomas Ballinger

Thomas Ballinger added the comment:

Use dis.findlinestarts() to find lines of function instead of grubbing with 
co_lnotab manually, making dis module dependency non-optional.

--
Added file: http://bugs.python.org/file38970/issue21217-v6.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23924] Add OS X to Dev Guide Quickstart build step

2015-04-13 Thread Ned Deily

Ned Deily added the comment:

Done.  Thanks for the patch!

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23924] Add OS X to Dev Guide Quickstart build step

2015-04-13 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 56b0001c7a29 by Ned Deily in branch 'default':
Issue #23924: Expand the QuickStart section to mention OS X and link
https://hg.python.org/devguide/rev/56b0001c7a29

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19907] gettext - Non ascii chars in header

2015-04-13 Thread Michael McFadden

Michael McFadden added the comment:

I'm having no luck reproducing this issue.

Regarding pygettext.py generating .po files:

I've used the messages.po file provided by the OP, and also using a generated 
.po file from pygettext.py with the offending header PO-Revision-Date:

As a side note, I'm not quite sure how you can get pygettext.py to generate 
anything but "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE" in python 3.3+, because 
it's a static line.

Regarding gettext.py

1: Tools/msgfmt.py -o locales/testlang/LC_MESSAGES/messages.mo 
locales/testlang/LC_MESSAGES/messages.po

 (all is good)

2: Run this simple script:
  import gettext

  t = gettext.translation('messages', 
   localedir='mytests/locales', 
   languages=['testlang'], )


  _ = t.gettext

  print('')
  print(_('TestMe'))
  print('')

Works without exceptions.

The only way I can recreate this issue is by saving my po file in a non-utf8 
format (latin-1) and running the above code.  It fails perfectly.

Can you help me recreate your issue?

--
nosy: +flipmcf

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20586] Argument Clinic: functions with valid sig but no docstring have no __text_signature__

2015-04-13 Thread Zachary Ware

Zachary Ware added the comment:

Here's an updated patch for clean application.  Larry, could you give this a 
look?

--
Added file: http://bugs.python.org/file38969/issue20586.v3.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23931] Update DevGuide link in Quickstart Step 1

2015-04-13 Thread Carol Willing

Carol Willing added the comment:

@berker.peksag I think that new contributors (esp. those at the sprints) want 
to get started quickly. Many do not read the whole devguide before starting 
even though the devguide is really helpful.

I like your suggested approach to keep the original link and add the "See ..."
phrase. Thanks :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23940] test__supports_universal_builds failure on Python 3.5.0a0 osx 10.6

2015-04-13 Thread Ned Deily

Changes by Ned Deily :


--
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23939] test_get_platform_osx failure on Python 3.5.0a0 osx 10.6

2015-04-13 Thread Ned Deily

Ned Deily added the comment:

No problem, and thanks for looking into it.

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23773] importlib does not properly remove frames when invoking external import hooks

2015-04-13 Thread Shiz

Shiz added the comment:

Ah, that is a very good point. I'll run the suite as soon as I find the time 
and will report back.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23939] test_get_platform_osx failure on Python 3.5.0a0 osx 10.6

2015-04-13 Thread Alex Lord

Alex Lord added the comment:

Ah, Alright. I thought that hg up would bring me up to speed. Sorry for that.

--
status: pending -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23941] Google Login not working

2015-04-13 Thread Ned Deily

Ned Deily added the comment:

Ernest, sorry you are having problems.  Issues with using the tracker itself 
are handled elsewhere.  Click on the "Report Tracker Problem" link in the 
"Help" section at the bottom of the left-hand column of this web page and that 
should take you to http://psf.upfronthosting.co.za/roundup/meta which is 
monitored by the maintainers of bugs.python.org.  It would be helpful to 
include there more details on what fields you are using and what errors you see.

--
nosy: +ned.deily
resolution:  -> third party
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23686] Update Windows and OS X installer OpenSSL to 1.0.2a

2015-04-13 Thread Marc-Andre Lemburg

Marc-Andre Lemburg added the comment:

Are you sure you want to go with OpenSSL 1.0.2a ? It typically takes a few 
patch level releases for them to clear out all the major bugs (including 
security relevant ones).

For egenix-pyopenssl, we've chose to stay with 1.0.1 for the time being until 
the dust settles on the 1.0.2 branch.

--
nosy: +lemburg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23924] Add OS X to Dev Guide Quickstart build step

2015-04-13 Thread Carol Willing

Carol Willing added the comment:

@ned.deily Thanks for the review. Please push for me. Thanks :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23931] Update DevGuide link in Quickstart Step 1

2015-04-13 Thread Berker Peksag

Berker Peksag added the comment:

Thanks for the patch, but I think the current link is correct. Contributors 
will need to read the whole page anyway :)

If you want to mention 
https://docs.python.org/devguide/setup.html#version-control-setup in index.rst, 
I'd suggest something like this:

1. :ref:`Get the source code `::
 
   hg clone https://hg.python.org/cpython

   See :ref:`vcsetup` on installing Mercurial.

--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22980] C extension naming doesn't take bitness into account

2015-04-13 Thread Matthias Klose

Matthias Klose added the comment:

On 04/13/2015 11:43 PM, Nick Coghlan wrote:
> 
> Nick Coghlan added the comment:
> 
> Maintaining the arch list can be delegated to the platform maintainers, but I 
> agree a test would be valuable.
> 
> I'd suggest a test in the platform module tests that cross-checks the 
> settings in SOABI. This will also be useful in defining an algorithm that 
> setuptools can backport to Python 2.7 for naming wheel files correctly.
> 
> For the new multiarch triplets, I believe the first two parts should match 
> platform.machine() and platform.system().lower(). I'm not sure what the third 
> part should match.

no, platform.machine() doesn't return any normalized machine name. At least for
ix86 (i386, i486, i586), ARM32 (armv4, armv5+, armv7, ...), ALPHA, and MIPS.

and testing for the second part only seems to be a bit odd.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22631] Feature Request CAN_RAW_FD_FRAMES

2015-04-13 Thread Larry Hastings

Larry Hastings added the comment:

Patch committed. Thanks, Joe!

--
assignee:  -> larry
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22631] Feature Request CAN_RAW_FD_FRAMES

2015-04-13 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 03ff92b26fa9 by Larry Hastings in branch 'default':
Issue #22631: Added Linux-specific socket constant CAN_RAW_FD_FRAMES.
https://hg.python.org/cpython/rev/03ff92b26fa9

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23730] Document return value for ZipFile.extract()

2015-04-13 Thread Zachary Ware

Zachary Ware added the comment:

Thanks for the patch!

--
nosy: +zach.ware
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23852] Wrong computation of max_fd on OpenBSD

2015-04-13 Thread Gregory P. Smith

Gregory P. Smith added the comment:

getrlimit() is not an async-signal-safe function according to 
http://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_04.html so 
you cannot call it from safe_get_max_fd().

having the getrlimit call done prior to the fork and using the value returned 
by that iff neither of the other two methods (fcntl and sysconf) are available 
or produced results seems like the best you can do.

also, rlim_t is an unsigned value yet the existing code in this module is using 
signed values for the file descriptors.  realistically i do not expect an 
rlim_t for max file descriptors to ever be > MAX_LONG as many file descriptor 
API calls require signed values for fds in order to use -1 as an error.

But checking the value for overflow and against the RLIM constants mentioned in 
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/resource.h.html 
before casting it via (long) seems pedantically wise.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23730] Document return value for ZipFile.extract()

2015-04-13 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 731e366885f5 by Zachary Ware in branch '2.7':
Issue #23730: Document the return value of ZipFile.extract
https://hg.python.org/cpython/rev/731e366885f5

New changeset 7ac1c2307a70 by Zachary Ware in branch '3.4':
Issue #23730: Document the return value of ZipFile.extract
https://hg.python.org/cpython/rev/7ac1c2307a70

New changeset d958c74ddb0c by Zachary Ware in branch 'default':
Closes #23730: merge with 3.4
https://hg.python.org/cpython/rev/d958c74ddb0c

--
nosy: +python-dev
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23642] Interaction of ModuleSpec and C Extension Modules

2015-04-13 Thread Raúl Cumplido

Changes by Raúl Cumplido :


--
nosy: +raulcd

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22980] C extension naming doesn't take bitness into account

2015-04-13 Thread Nick Coghlan

Nick Coghlan added the comment:

Maintaining the arch list can be delegated to the platform maintainers, but I 
agree a test would be valuable.

I'd suggest a test in the platform module tests that cross-checks the settings 
in SOABI. This will also be useful in defining an algorithm that setuptools can 
backport to Python 2.7 for naming wheel files correctly.

For the new multiarch triplets, I believe the first two parts should match 
platform.machine() and platform.system().lower(). I'm not sure what the third 
part should match.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23723] Provide a way to disable bytecode staleness checks

2015-04-13 Thread Raúl Cumplido

Changes by Raúl Cumplido :


--
nosy: +raulcd

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23940] test__supports_universal_builds failure on Python 3.5.0a0 osx 10.6

2015-04-13 Thread Ned Deily

Ned Deily added the comment:

This also appears to be due to not building with an up-to-date version of the 
source (see msg240759 in Issue23939).

--
resolution:  -> out of date
stage:  -> resolved
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21062] Evalute all import-related modules for best practices

2015-04-13 Thread Raúl Cumplido

Changes by Raúl Cumplido :


--
nosy: +raulcd

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23937] IDLE start maximized

2015-04-13 Thread Al Sweigart

Al Sweigart added the comment:

+1 to this idea. In classroom settings when I look over the shoulder of 
students, usually they're working with IDLE or an editor in a much smaller 
window. When I point out how to maximize it, they always enjoy the additional 
space.

It seems like a minor thing, but a lot of newbies don't realize they can 
maximize the window. Having this as the default start state is a good idea.

I'm trying to think of why you would want it to start windowed, and can't come 
up with anything.

--
nosy: +Al.Sweigart

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23773] importlib does not properly remove frames when invoking external import hooks

2015-04-13 Thread Raúl Cumplido

Changes by Raúl Cumplido :


--
nosy: +raulcd

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19956] inspect.getsource(obj.foo) fails when foo is an injected method constructed from another method

2015-04-13 Thread R. David Murray

R. David Murray added the comment:

Thanks for the patch.  I've made some review comments on the tests.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20309] Not all method descriptors are callable

2015-04-13 Thread Ernest

Changes by Ernest :


--
nosy: +ozialien

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23911] Move path-based bootstrap code to a separate frozen file.

2015-04-13 Thread Raúl Cumplido

Changes by Raúl Cumplido :


--
nosy: +raulcd

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23924] Add OS X to Dev Guide Quickstart build step

2015-04-13 Thread Ned Deily

Ned Deily added the comment:

The updates look good to me, thanks!  Are you able to push this?  If not, I can 
do it.

--
stage:  -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   >