[issue18654] modernize mingwcygwin compiler classes

2015-04-19 Thread Václav Šmilauer

Václav Šmilauer added the comment:

Ping? Roumen has been updaing the patch for one year and no reaction. Is there 
something which can be done?

--
nosy: +eudoxos

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18654
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24000] More fixes for the Clinic mapping of converters to format units

2015-04-19 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Doesn't always zeroes == length?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24000
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24005] Documentation Error: Extra line Break

2015-04-19 Thread Jaivish Kothari

Jaivish Kothari added the comment:

Please find the attached patch for review.

--
keywords: +patch
resolution:  - fixed
Added file: http://bugs.python.org/file39118/doc_patch.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24005
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23999] Undefined behavior in dtoa.c (rshift 32 of 32bit data type)

2015-04-19 Thread Christian Heimes

Christian Heimes added the comment:

You could be right. I didn't track all paths manually. All this bit shifting is 
making my head dizzy... :)

Anyways I have sent you an invite for Coverity, so you can check the result 
yourself. The Python test suite passes with assert(k  32); inside the 
problematic block, too.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23999
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23920] Should Clinic have nullable or types=NoneType?

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

p.s. I'm now leaning heavily towards renaming types to accept, and putting 
NoneType in the set passed to accept= instead of a separate parameter.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23920
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23999] Undefined behavior in dtoa.c (rshift 32 of 32bit data type)

2015-04-19 Thread Mark Dickinson

Mark Dickinson added the comment:

Ah, sorry; I see it.  Fix on the way.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23999
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24000] More fixes for the Clinic mapping of converters to format units

2015-04-19 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Converters with encoding=True are not used in converted code. es is never 
used in still non-converted code and et is used only 6 times (for idna and 
utf-8 encodings) and can be replaced with custom converter or inlined code. 
So I think the support of encoding=True should be removed from Argument Clinic 
soon.

Converters with length=True are used very rarely too, and they are mostly 
legacy converters. I think we should get rid of most of them in future.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24000
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22980] C extension naming doesn't take bitness into account

2015-04-19 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 558335559383 by doko in branch 'default':
- #22980: fix triplet configure test for more targets
https://hg.python.org/cpython/rev/558335559383

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22980
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22980] C extension naming doesn't take bitness into account

2015-04-19 Thread Matthias Klose

Matthias Klose added the comment:

 I'm not trying to discredit any use cases, I just don't see them.

so why do you see this on x86 for 32/64bit, but not for ARM 
soft-float/hard-float.  The example given was pretty clear.

 All Linux distributions I know place the 32-bit and 64-bit versions
 of shared libs into different directories rather than putting them all
 into a single dir and adding ABI flags to the .so files.

Well, then at least you don't know Debian, Ubuntu, and any of their derivates.

And even the Python default install on Linux installs into the same place.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22980
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24002] Add un-parse function to ast

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

Actually eval(ast) is all I need for #23967 too.  But eval is a builtin, so it 
feels wrong to have it supporting--and therefore dependent on--ast.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

Sadly, for political reasons, it's best that we not convert collections, 
itertools, or random for now.  I'll update this issue if the situation changes. 
 Sorry about that!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20180
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24002] Add un-parse function to ast

2015-04-19 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

I think there is standard way to transform ast to bytecode and evaluate it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23982] Tkinter in Python 3.4 for Windows incorrectly renders certain colors using non-TclTk RGB values

2015-04-19 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

I don't think that we should document such minor details in Tkinter 
documentation. There are larger differences between Tcl/Tk versions that can 
make Python programs fail (e.g. introducing new internal Tcl/Tk type), and they 
are not documented.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23982
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24003] variable naming

2015-04-19 Thread Steven D'Aprano

Steven D'Aprano added the comment:

This is not a bug. while is a keyword, it is part of Python's syntax, and you 
are not permitted to use keywords as variable names. This is not an accident, 
but a deliberate decision.

--
nosy: +steven.daprano
resolution:  - not a bug
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24003
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24005] Documentation Error: Extra line Break

2015-04-19 Thread Jaivish Kothari

New submission from Jaivish Kothari:

https://docs.python.org/2/whatsnew/2.4.html?highlight=decorators#pep-318-decorators-for-functions-and-methods
'''
def require_int (func):
def wrapper (arg):
assert isinstance(arg, int)
return func(arg)

return wrapper
'''

New line is ommited before return wrapper 

'''
def require_int (func):
def wrapper (arg):
assert isinstance(arg, int)
return func(arg)
return wrapper

'''

--
assignee: docs@python
components: Documentation
messages: 241508
nosy: docs@python, georg.brandl, janonymous
priority: normal
severity: normal
status: open
title: Documentation Error: Extra line Break
type: enhancement
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24005
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23996] _PyGen_FetchStopIterationValue() crashes on unnormalised exceptions

2015-04-19 Thread Stefan Behnel

Stefan Behnel added the comment:

Here's a better patch that avoids exception normalisation in all normal cases.

--
Added file: http://bugs.python.org/file39116/fix_stopiteration_crash.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23996
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23920] Should Clinic have nullable or types=NoneType?

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

I've posted about this to python-dev.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23920
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23999] Undefined behavior in dtoa.c (rshift 32 of 32bit data type)

2015-04-19 Thread Mark Dickinson

Mark Dickinson added the comment:

Looking more closely, the report doesn't make sense to me:  `k` is the return 
value from a call to `lo0bits`.  From the source of `lo0bits`, I don't see any 
way that `k` can be 32: it's always going to be in the range [0, 31].  
Christian: do you have any more information from Coverity?  This looks like a 
false positive to me.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23999
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23999] Undefined behavior in dtoa.c (rshift 32 of 32bit data type)

2015-04-19 Thread Mark Dickinson

Mark Dickinson added the comment:

Okay, so after looking more closely, this *still* looks like a false positive:  
`lo0bits` *can* return 32, but only for an input of zero.  In the code in 
question, we're doing `k = lo0bits(y)`, so the only way we can get a `k` of 
`32` is if `y = 0`.  But the whole thing is inside an if block that looks 
like `if ((y = word1(d))) { ... }` (yep, completely with the extra parentheses 
and the misleading equality-test-lookalike assignment), so that `if` block 
won't be executed if `y` is zero.

I edited the code to print out debugging information if `k` is ever 32 at that 
point, and saw no output.  So I don't think that line ever gets executed with 
`k = 32`.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23999
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23999] Undefined behavior in dtoa.c (rshift 32 of 32bit data type)

2015-04-19 Thread Mark Dickinson

Mark Dickinson added the comment:

 saw no output

Bah; missed a bit.  I saw no output when running the Python test suite, that 
is.  That's not definitive, of course.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23999
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23982] Tkinter in Python 3.4 for Windows incorrectly renders certain colors using non-TclTk RGB values

2015-04-19 Thread Martin Falatic

Martin Falatic added the comment:

No, I don't expect something like the color change to be documented here 
(unless that thing is incorrectly documented within python.org's current 
release trees).

I do expect that just as python.org's OSX releases document the recommended 
version of TclTk to use (e.g., https://www.python.org/download/mac/tcltk/) 
there should be equivalent documentation describing what version of TckTk is 
actualy compiled into the Windows releases here (e.g., 8.5.9 or 8.6.4 or such. 
(Note that Tkinter.TclVersion/TkVersion aren't sufficiently detailed to 
dynamically determine the exact in-built versions either).

Beyond that, it's up to the user to read more about that specified or 
recommended release in the external Tcl/Tk docs (except where such 
documentation is present in the doc trees on python.org).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23982
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15582] Enhance inspect.getdoc to follow inheritance chains

2015-04-19 Thread Martin Panter

Martin Panter added the comment:

Sometimes the doc string for the overridden method does not make much sense in 
the context of the subclass. Just wondering if this was considered; it seems 
like a fairly serious downside to this new feature. E.g. in a package I am 
reviewing, there is a class that inherits HTMLParser and converts HTML to PDF. 
There is no doc string, so previously there was just the signature in the 
“pydoc” output. Now the output looks like:

 |  __init__(self, pdf, image_map=None)
 |  Initialize and reset this instance.
 |  
 |  If convert_charrefs is True (the default), all character references
 |  are automatically converted to the corresponding Unicode characters.

The second paragraph mentions parameters and settings of the internal base 
class, which doesn’t make much sense for the subclass.

--
nosy: +vadmium

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15582
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24000] More fixes for the Clinic mapping of converters to format units

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

Oh, heavens, yes, that's much nicer.  Thanks for the suggestion, Serhiy!

--
Added file: 
http://bugs.python.org/file39115/larry.one.more.clinic.format.unit.map.cleanup.2.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24000
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24003] variable naming

2015-04-19 Thread john kaiser

New submission from john kaiser:

found error when naming variables with basic functions

how to replicate

while=123 #while should be treated as variable name
while True: #this should be treated as a function
print while #this should be as a variable name

result:
  File C:\Users\_you got served_\Desktop\bugs.py, line 1
while = 123
  ^
SyntaxError: invalid syntax

--
files: bugs.py
messages: 241502
nosy: kaiser
priority: normal
severity: normal
status: open
title: variable naming
type: behavior
versions: Python 2.7
Added file: http://bugs.python.org/file39117/bugs.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24003
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24004] avoid explicit generator type check in asyncio

2015-04-19 Thread Stefan Behnel

New submission from Stefan Behnel:

asyncio/coroutines.py contains this code:


_COROUTINE_TYPES = (types.GeneratorType, CoroWrapper)

def iscoroutine(obj):
Return True if obj is a coroutine object.
return isinstance(obj, _COROUTINE_TYPES)


In other places, it uses inspect.isgenerator() to do the same thing. This is 
inconsistent and should be changed. Code that wants to patch 
inspect.isgenerator() in order to support other generator types shouldn't also 
have to patch asyncio directly, and code that wants to support other generator 
types in asyncio shouldn't have to patch both places either.

--
components: asyncio
messages: 241506
nosy: gvanrossum, haypo, scoder, yselivanov
priority: normal
severity: normal
status: open
title: avoid explicit generator type check in asyncio
type: behavior
versions: Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24004
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24005] Documentation Error: Extra line Break

2015-04-19 Thread Georg Brandl

Georg Brandl added the comment:

Why is this a bug?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24005
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11587] METH_KEYWORDS alone gives METH_OLDARGS is no longer supported!

2015-04-19 Thread Antti Haapala

Antti Haapala added the comment:

This is *still* there in Hg tip: PyCFunction_Call in Objects/methodobject.c 
does not have a case for `METH_KEYWORDS` only at all.

The documentation for METH_KEYWORDS says that it is *typically* coupled with 
METH_VARARGS; however not having the case means that METH_KEYWORDS *cannot* be 
used without METH_VARARGS at all.

Furthermore, the default case should actually report the wrong flags value 
instead of calling it the METH_OLDARGS, since it can be caused by any future 
combination, by setting it to zero, or undefined behaviour causing the flag to 
be overwritten.

--
nosy: +ztane

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11587
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24002] Add un-parse function to ast

2015-04-19 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

For issue24001 you need rather eval(ast). But a function for stringifying ast 
would be useful in any case.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23999] Undefined behavior in dtoa.c (rshift 32 of 32bit data type)

2015-04-19 Thread Mark Dickinson

Mark Dickinson added the comment:

I'm pretty sure that our code was based on something rather more recent than 
2001: it was the most recent version available at the time (around 2008?), and 
it incorporates subsequent fixes from David Gay.

Please don't replace our dtoa.c with a current version: ours has diverged from 
the original, and includes fixes that aren't available upstream.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23999
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15582] Enhance inspect.getdoc to follow inheritance chains

2015-04-19 Thread Serhiy Storchaka

Changes by Serhiy Storchaka storch...@gmail.com:


--
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15582
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23982] Tkinter in Python 3.4 for Windows incorrectly renders certain colors using non-TclTk RGB values

2015-04-19 Thread Martin Falatic

Martin Falatic added the comment:

Yes, the python.org releases specify the TclTK they should be used with, for 
OSX:
https://www.python.org/download/mac/tcltk/

If there's another python.org bug report list let me know, but this still seems 
to be the right place. Since Python.org's windows distribution is what led to 
this question, I'd like to at least see it documented somewhere what TclTk is 
compiled into the Python.org windows distribution. I didn't find any info on 
what TclTk Python.org's Windows build includes, and that's something that can 
be rectified here. (Since there are documented *recommendations* for what to 
use with the OSX builds from this site then there ought to be some similar 
documentation what is *built in* to the Windows builds from this site.)

As for the failure of TclTk to properly document the change they made to their 
colors, that's a matter for their bug tracker. I took their documentation at 
face value, and didn't find information to the contrary when I searched prior 
to posting this.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23982
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23982] Tkinter in Python 3.4 for Windows incorrectly renders certain colors using non-TclTk RGB values

2015-04-19 Thread Martin Falatic

Martin Falatic added the comment:

FYI, I've filed a bug with the TclTk people regarding their documentation.

http://core.tcl.tk/tk/tktview/2a02881e4c23634022d0ae40a14383d9baad9eb9

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23982
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Eric Snow

Eric Snow added the comment:

Just to be clear, I'm still -1 on any of this.  On the one hand, there's a risk 
of backward-compatibility breakage (just as much a corner-case as the need 
expressed in this issue).  On the other hand, I'd actually push for 
_PyObject_LookupSpecial to be fixed to chain AttributeError coming from a 
descriptor into a TypeError.

Allowing instances to determine the capability of a class feels wrong and 
potentially broken.  Furthermore, doing so via AttributeError is problematic 
since it may mask an AttributeError that bubbles up (which is very confusing 
and hard to debug).  I've been bitten by this with pickle.

Still, it may be a good idea to expose _PyObject_LookupSpecial via the inspect 
module, but that should be addressed in a separate issue.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12712] weave build_tools library identification

2015-04-19 Thread Mark Lawrence

Mark Lawrence added the comment:

Is case sensitivity still an issue on Windows?  I've tried searching but there 
are so many issues referring to case sensitivity that I got swamped.

--
components: +Windows
nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12712
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-19 Thread Cyd Haselton

Cyd Haselton added the comment:

Ryan, 
Found the missing fix.

In ./Programs/python.c

#ifndef __ANDROID__
oldloc = _PyMem_RawStrdup(setlocale(LC_ALL, NULL));
if (!oldloc) {
fprintf(stderr, out of memory\n); 
 return 1;
}   
 #endif

Added the #ifndef __ANDROID__ #endif around lines 46-51

I'm now looking at the following syntax error:

File ./setup.py, line 1950
elif host_platform.startswith('arm-linux')
 ^
SyntaxError: invalid syntax
make: *** [sharedmods] Error 1

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24005] Documentation Error: Extra line Break

2015-04-19 Thread Berker Peksag

Berker Peksag added the comment:

That document is 10 years old :) I don't think it's worth to change now. Also, 
what's new documents shouldn't be used as a tutorial. There are many 
tutorials about writing decorators on the internet.

(Thanks for the report and the patch, Jaivish)

--
nosy: +berker.peksag

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24005
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-19 Thread Ryan Gonzalez

Ryan Gonzalez added the comment:

On Sun, Apr 19, 2015 at 7:16 PM, Cyd Haselton rep...@bugs.python.org
wrote:


 Cyd Haselton added the comment:

 Ryan,
 Found the missing fix.

 In ./Programs/python.c

 #ifndef __ANDROID__
 oldloc = _PyMem_RawStrdup(setlocale(LC_ALL, NULL));
 if (!oldloc) {
 fprintf(stderr, out of memory\n);
   return 1;
 }
   #endif

 Added the #ifndef __ANDROID__ #endif around lines 46-51


...that was in android_segfault_fix.patch...

are you sure you're on the same commit as I am?

 I'm now looking at the following syntax error:

 File ./setup.py, line 1950
 elif host_platform.startswith('arm-linux')
  ^
 SyntaxError: invalid syntax
 make: *** [sharedmods] Error 1


I forgot to put a colon and the end of the line. I'll upload a fixed
kbox_fixes.patch.

 --

 ___
 Python tracker rep...@bugs.python.org
 http://bugs.python.org/issue23496
 ___


--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-19 Thread Cyd Haselton

Cyd Haselton added the comment:

Patch for python.c that prevents segfault on Android

--
Added file: http://bugs.python.org/file39135/python.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24005] Documentation Error: Extra line Break

2015-04-19 Thread Carol Willing

Carol Willing added the comment:

janonymous, Thanks for the contribution. I agree with George that this is not a 
bug. The whitespace exists for developer readability and maintainability of 
code. Here's a section from PEP8 about the use of whitespace 
(https://www.python.org/dev/peps/pep-0008/#id15). I am closing this issue as 
not a bug. I do hope you will contribute to Python again. Thanks.

Close as not a bug.

--
nosy: +willingc
resolution: fixed - not a bug
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24005
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24000] More fixes for the Clinic mapping of converters to format units

2015-04-19 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

 Doesn't always zeroes == length?

 zeroes requires length, but length does not require zeroes.  As it 
 happens all the format units supported by str always have both parameters 
 either True or False.  But the Py_UNICODE converter accepts length for 
 format units u# and Z#, and doesn't support zeroes.

length=True implies zeroes=True in the Py_UNICODE converter. u and Z 
don't allow null characters, u# and Z# allow null characters. zeroes 
doesn't add any information and isn't needed.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24000
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24001] Clinic: use raw types in types= set

2015-04-19 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Looks as this is a patch for different issue.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24001
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18654] modernize mingwcygwin compiler classes

2015-04-19 Thread R. David Murray

R. David Murray added the comment:

Find someone from the packaging sig willing to review it, maybe?  As in, get on 
that mailing list and ask.

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18654
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com




[issue23701] Drop extraneous comment from winreg.QueryValue's docstring

2015-04-19 Thread Claudiu Popa

Changes by Claudiu Popa pcmantic...@gmail.com:


--
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23701
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24003] variable naming

2015-04-19 Thread Ned Deily

Ned Deily added the comment:

(... and is documented in The Python 3 and 2 Language Reference manuals: 
https://docs.python.org/3/reference/lexical_analysis.html#keywords and 
https://docs.python.org/2/reference/lexical_analysis.html#keywords)

--
nosy: +ned.deily

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24003
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Eric Snow

Eric Snow added the comment:

s/TypeError/RuntimeError/

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8706] accept keyword arguments on most base type methods and builtins

2015-04-19 Thread Berker Peksag

Changes by Berker Peksag berker.pek...@gmail.com:


--
components: +Extension Modules, Interpreter Core
nosy: +berker.peksag
versions: +Python 3.5 -Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8706
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Eric Snow

Eric Snow added the comment:

 Ionel Cristian Mărieș added the comment:
 #1. It's specified/documented, therefore it's intended

 The first thing a maintainer does is check the docs. This is a sensible thing 
 to do - as you cannot have all the details in your hear. The main question at 
 that point: is it really like that?.

 However, it's easy to miss the fact that the documentation explains an 
 implementation issue (`callable` is not really reliable, blablabla), and not 
 the intent of `callable`.

 I mean, the name is pretty clear on what it's supposed to do: is the object 
 callable or not? - simple as that. If the intent of `callable` is being 
 unreliable then maybe we should just rename it to `maybe_callable` or 
 `unreliable_callable`, or maybe even crappy_callable_we_dont_want_to_fix.

callable refers to the compatibility of the object with the call
syntax - simple as that.  The call syntax is turned into a special
lookup for __call__ that explicitly skips lookup on the instance (in
CPython it is a call to _PyObject_LookupSpecial) and then a call on
the resulting value.

You are correct that callable does not do the descriptor part of that
lookup.  However, that is consistent across Python and has been this
way for a long time (so there are backward compatibility concerns that
cannot be ignored).


 #2. But the call could fail anyway, so what's the point of fixing this?

You are correct that the availability of __call__ is the only relevant
issue here.


 #3. But it's going to be too slow!

 I don't want to be mean here, but this is just FUD. Lets measure this first. 
 Is there really a measurable and significant performance impact on major 
 applications?

It's not just applications.  Grep for PyCallable_Check in the
CPython code base.


 Does the argument even make sense in theory? A function call is pretty 
 expensive in python, a mere attribute lookup wouldn't increase the cost by an 
 order of magnitude (like 10x), would it?

A mere attribute lookup involves invoking the descriptor protocol.
This would add a discernible performance impact and the possibility of
running arbitrary code for the sake of a rare corner case.  The
overall impact would be small, especially considering the use of
PyCallable_Check in the CPython code base, but do not assume it would
be insignificant.

 Python 3 regressed performance in various aspects (and improved other things, 
 of course), why would this be a roadblock now?

My apology for being so blunt, but that's a terrible rationale!  Let's
make it better not worse.


 #4. It's too tricky, and I had a bad time with pickle one time ago, or: 
 Exception masking issues

 This is certainly a problem, but it's not a new problem. There are already 
 dozens of places where AttributeError is masked into something else (like a 
 TypeError, or just a different result).

It not a problem currently for callable.  It is one you are proposing
to introduce.  It is one which current users of callable don't have to
worry about.


 Were do we draw the line here?

We don't add to the problem.  Instead, we work to decrease it.

 Do we want to eventually get rid of all exception masking in an eventual 
 Python 4.0 - what's the overarching goal here? Or is this just one of the 
 many quirks of Python?

 What's worse - a quirk or a inconsistent quirk?

What's the quirk here?  I'd argue that the quirk is that special
method lookup (_PyObject_LookupSpecial) doesn't turn AttributeError
from a getter into RuntimeError.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23496] Steps for Android Native Build of Python 3.4.2

2015-04-19 Thread Ryan Gonzalez

Changes by Ryan Gonzalez rym...@gmail.com:


Added file: http://bugs.python.org/file39134/kbox_fix.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23496
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22619] Possible implementation of negative limit for traceback functions

2015-04-19 Thread Dmitry Kazakov

Dmitry Kazakov added the comment:

I'll do that tomorrow. The patch still needs a review though...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22619
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23982] Tkinter in Python 3.4 for Windows incorrectly renders certain colors using non-TclTk RGB values

2015-04-19 Thread Martin Falatic

Martin Falatic added the comment:

Thank you. Before going down the road of revising PEP 101 (which appears to be 
very non-trivial despite the simple (and certainly always present) data 
involved), I'd like to know: is version information about the pre-compiled 
Windows binaries (of which this is one) already being captured anywhere else 
publically visible on a per-release or per-build basis? It's useful that such 
binaries exist given Windows' unique requirements versus other systems, but are 
these binaries themselves documented anywhere as they are updated (e.g., how to 
re-create them)? Such a source of truth would simplify that revision request.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23982
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Raymond Hettinger

Changes by Raymond Hettinger raymond.hettin...@gmail.com:


--
assignee:  - rhettinger
nosy: +rhettinger

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24007] Write PyArg_Parse* format in a line with a function

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

I don't care about this, but the patch looks fine.  If this really helps then 
LGTM.

Please hold off checking this in until after 3.5.0 alpha 4 is released.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24007
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Eric Snow

Eric Snow added the comment:

 What would be the right thing?

My suggestion of using a metaclass is actually not effective here because 
__call__ has meaning for metaclasses.  Otherwise you could have made __call__ 
more dynamic via a metaclass.  Except that is another reason why my suggestion 
is incorrect.  What you are asking for is that, effectively, the state of the 
instance might be able to impact the resolution of special methods of a class.  
So a metaclass approach would not have helped since the instance would not have 
been involved in the lookup.

Regardless, this makes it more clear to me what you are trying to accomplish 
for the sake of a proxy type.  The question is, should an instance be able to 
influence the resolution of special methods that are called on its behalf?

Before answering that, consider why methods that are special to the interpreter 
get treated differently.  The language specifies that rather than using 
obj.__getattribute__ to look up special methods, they are effectively located 
in type(obj).__dict__.  They likewise are not looked up on 
obj.__class__.__dict__.  Here are the key reasons why this matters:

 * speed
 * the special methods will still be available even if the class implements its 
own __getattribute__

Once the methods are looked up, the descriptor protocol is invoked, if 
applicable.  However, it does not fall back to obj.__getattr__.  See 
Objects/typeobject.c:_PyObject_LookupSpecial.  So ultimately the descriptor 
protocol allows instances to have a say in both the existence and the behavior 
of special methods.  However, I think that the former is unfortunate since it 
obviously muddies the water here.  I doubt it was intentional.

Back to the question, should instances be allowed to influence the *lookup* of 
special methods?  Your request is that they should be and consistently.  As 
noted, the interpreter already uses the equivalent of the following when 
looking up special methods:

def _PyObject_LookupSpecial(obj, name):
attr = inspect.getattr_static(obj, name)
try:
f = inspect.getattr_static(attr, '__get__')
except AttributeError:
return attr
else:
return f(attr, obj, type(obj))

What you are asking is that callable should do this too, rather than skipping 
the descriptor part).  I expect the same would need to be done for any other 
helper that also checks for special capability.  For example, see the various 
__subclasshook__ implementations in Lib/_collections_abc.py.  We should be 
consistent about it if we are going to do it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Ionel Cristian Mărieș

Ionel Cristian Mărieș added the comment:

I want to address the four main points of criticism in fixing this issue, just 
in case it's not clear why I think those lines of thought are wrong:

#1. It's specified/documented, therefore it's intended

The first thing a maintainer does is check the docs. This is a sensible thing 
to do - as you cannot have all the details in your hear. The main question at 
that point: is it really like that?. 

However, it's easy to miss the fact that the documentation explains an 
implementation issue (`callable` is not really reliable, blablabla), and not 
the intent of `callable`.

I mean, the name is pretty clear on what it's supposed to do: is the object 
callable or not? - simple as that. If the intent of `callable` is being 
unreliable then maybe we should just rename it to `maybe_callable` or 
`unreliable_callable`, or maybe even crappy_callable_we_dont_want_to_fix.

#2. But the call could fail anyway, so what's the point of fixing this?

The problem with this argument is that it's the same argument people bring up 
to remove the `callable` builtin. The problem is that you wouldn't use 
`callable` at all if you can just try/call/except. So this argument is not 
pertinent to the problem at hand (`callable` doing incomplete checks).

#3. But it's going to be too slow!

I don't want to be mean here, but this is just FUD. Lets measure this first. Is 
there really a measurable and significant performance impact on major 
applications? 

Does the argument even make sense in theory? A function call is pretty 
expensive in python, a mere attribute lookup wouldn't increase the cost by an 
order of magnitude (like 10x), would it?

 py -3 -mtimeit -s def foo(): pass foo.__call__
1000 loops, best of 3: 0.0585 usec per loop

 py -3 -mtimeit -s def foo(): pass callable(foo)
1000 loops, best of 3: 0.0392 usec per loop

Is this a significant margin? Also, I'm pretty sure those numbers can be 
improved.

Python 3 regressed performance in various aspects (and improved other things, 
of course), why would this be a roadblock now?

#4. It's too tricky, and I had a bad time with pickle one time ago, or: 
Exception masking issues

This is certainly a problem, but it's not a new problem. There are already 
dozens of places where AttributeError is masked into something else (like a 
TypeError, or just a different result).

Were do we draw the line here? Do we want to eventually get rid of all 
exception masking in an eventual Python 4.0 - what's the overarching goal here? 
Or is this just one of the many quirks of Python?

What's worse - a quirk or a inconsistent quirk?

The problem with this argument is that it attacks a different problem, that's 
just being made more visible if and when this problem of `callable` is fixed.

Lets consider this strawman here: if a an user writes code like this:

try:
do important stuff
except:
pass # have fun debugging, haha

who's at fault here? Is it the user that wrote that debugging black hole or is 
it python for letting the user do things like that? I don't think it's 
reasonable for Python to prevent exception masking bugs if the user was brave 
enough to write a descriptor.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Eric Snow

Eric Snow added the comment:

Note that (in my mind, unfortunately) the pickle module looks up several
dunder methods on instances.  That isn't quite the same thing since the
issue is about callable not triggering the descriptor protocol.  However it
is closely related.  I point this out because this similar behavior of
pickle is a source of mysterious, hard to understand bugs in many of the
same corner cases.  Thus I'm -1 on changing the behavior of callable.

From what I understand, the motivation here is in the case of proxies that
dynamically determine their capability and raise AttributeError
accordingly.  If that is the case then consider prior art such as MagicMock
or other existing proxy types on PyPI.

Also consider if there is a proxy-specific approach that can resolve the
matter.  I've long thought there is room in the stdlib for a proxy module
that holds proxy-related helpers and classes.

Finally, instead of changing callable, why not use a metaclass that does
the right thing?  I believe MagicMock does something along those lines.

--
nosy: +eric.snow

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23967] Make inspect.signature expression evaluation more powerful

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

Whoops.  Here's the revised patch.

--
Added file: 
http://bugs.python.org/file39123/larry.improved.signature.expressions.2.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23967
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23967] Make inspect.signature expression evaluation more powerful

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

Thanks to #24002 I now know how to write evalify_node properly.  This patch is 
now much better.

Note that I deliberately made the new function _eval_ast_expr() as a private 
module-level routine.  I need that same functionality in Argument Clinic too, 
so if both patches are accepted I'll have Clinic switch to calling this version.

--
nosy: +brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23967
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24008] inspect.getsource is failing for sys.excepthook

2015-04-19 Thread Anand Reddy Pandikunta

New submission from Anand Reddy Pandikunta:

 inspect.getsource(sys.excepthook)
Traceback (most recent call last):
  File stdin, line 1, in module
  File /usr/local/lib/python2.7/inspect.py, line 701, in getsource
lines, lnum = getsourcelines(object)
  File /usr/local/lib/python2.7/inspect.py, line 690, in getsourcelines
lines, lnum = findsource(object)
  File /usr/local/lib/python2.7/inspect.py, line 526, in findsource
file = getfile(object)
  File /usr/local/lib/python2.7/inspect.py, line 420, in getfile
'function, traceback, frame, or code object'.format(object))
TypeError: built-in function excepthook is not a module, class, method, 
function, traceback, frame, or code object

--
components: Library (Lib)
files: trace4.py
messages: 241537
nosy: ChillarAnand
priority: normal
severity: normal
status: open
title: inspect.getsource is failing for sys.excepthook
versions: Python 2.7
Added file: http://bugs.python.org/file39124/trace4.py

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24008
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24000] More fixes for the Clinic mapping of converters to format units

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

 u# and Z# allow null characters.

Not according to the documentation.  'u' explicitly says it does not allow NUL 
characters.  'Z', 'u#', and 'Z#' all say they are variants of 'u' but never 
mention that they might allow NUL characters.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24000
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Ethan Furman

Ethan Furman added the comment:

The right thing, using a meta-class, is to have the meta-class check if the 
proxied object is callable, and if so, put in the __call__ function in the 
class that is being created.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24001] Clinic: use raw types in types= set

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

Here's the right patch.

--
Added file: http://bugs.python.org/file39128/larry.clinic.use.raw.types.2.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24001
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24001] Clinic: use raw types in types= set

2015-04-19 Thread Larry Hastings

Changes by Larry Hastings la...@hastings.org:


Removed file: 
http://bugs.python.org/file39122/larry.one.more.clinic.format.unit.map.cleanup.2.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24001
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24011] Add error checks to PyInit_signal()

2015-04-19 Thread Christian Heimes

New submission from Christian Heimes:

The init function of the signal module fails to check for errors in a couple of 
places. The patch replaces PyDict_SetItemString() calls with 
PyModule_AddIntMacro() and error checks. An exception is unlikely so I'm OK 
when the patch just lands in 3.4 and 3.5.

CID 1295026 (#41 of 41): Dereference null return value (NULL_RETURNS)
dereference: Dereferencing a pointer that might be null x when calling 
PyDict_SetItemString

--
components: Extension Modules
files: signalmodule.patch
keywords: patch
messages: 241551
nosy: christian.heimes
priority: normal
severity: normal
stage: patch review
status: open
title: Add error checks to PyInit_signal()
type: behavior
versions: Python 3.4, Python 3.5
Added file: http://bugs.python.org/file39127/signalmodule.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24011
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24001] Clinic: use raw types in types= set

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

Whoops.  I'll fix that.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24001
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Steven D'Aprano

Steven D'Aprano added the comment:

This bug report seems to be completely based on a false premise. In the very 
first message of this issue, Ionel says:

it return True even if __call__ is actually an descriptor that raise 
AttributeError (clearly not callable at all).

but that is wrong. It *is* callable, and callable() is correct to return True. 
If you look at the stack trace, the __call__ method (function/property, 
whatever you want to call it) is called, and it raises an exception. That is no 
different from any other method or function that raises an exception.

It is wrong to think that raising AttributeError *inside* __call__ makes the 
object non-callable.

Ionel, I raised these issues on Python-list here:

https://mail.python.org/pipermail/python-ideas/2015-April/033078.html

but you haven't responded to them.

--
nosy: +steven.daprano

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24000] More fixes for the Clinic mapping of converters to format units

2015-04-19 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

 Not according to the documentation.  'u' explicitly says it does not allow 
 NUL characters.  'Z', 'u#', and 'Z#' all say they are variants of 'u' but 
 never mention that they might allow NUL characters.

I understand the note in u description as explicitly saying that u# allows 
null characters.

The documentation for format units needs an update for other reasons and there 
is an issue with ready patch for this.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24000
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22080] Add windows_helper module helper

2015-04-19 Thread Claudiu Popa

Claudiu Popa added the comment:

The latest patch drops the symlink check, since it can be added later.

--
Added file: http://bugs.python.org/file39133/issue22080_2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22080
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24000] More fixes for the Clinic mapping of converters to format units

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

 Doesn't always zeroes == length?

zeroes requires length, but length does not require zeroes.  As it 
happens all the format units supported by str always have both parameters 
either True or False.  But the Py_UNICODE converter accepts length for format 
units u# and Z#, and doesn't support zeroes.

I want the converters to accept common parameters.  That will make 
comprehension easier for the casual reader.  So I want to keep length as a 
separate parameter, even for str.


 So I think the support of encoding=True should be removed
 from Argument Clinic soon.  [...]  I think we should get rid
 of [length] in future.

I disagree. My goal with Argument Clinic is that third-party developers will 
use it to write extensions.  And we don't know how many extension modules are 
using es, es#, et, et#, s#, y#, z#, u#, and U#.  I don't think we can remove 
any of this functionality until 4.0.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24000
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23275] Can assign [] = (), but not () = []

2015-04-19 Thread R. David Murray

R. David Murray added the comment:

There is also no reason to break currently working code, which turning this 
into a syntax error would od.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23275
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24000] More fixes for the Clinic mapping of converters to format units

2015-04-19 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

 I disagree. My goal with Argument Clinic is that third-party developers will 
 use it to write extensions.  And we don't know how many extension modules are 
 using es, es#, et, et#, s#, y#, z#, u#, and U#.  I don't think we can remove 
 any of this functionality until 4.0.

But we can deprecate them sooner.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24000
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24007] Write PyArg_Parse* format in a line with a function

2015-04-19 Thread Serhiy Storchaka

New submission from Serhiy Storchaka:

Proposed patch makes Argument Clinic to output format argument of PyArg_Parse, 
PyArg_ParseTuple and PyArg_ParseTupleAndKeywords in a line with a function 
itself. First, this makes generated code more compact and easier to read and 
compare with old code. Second, it makes easier to grep sources for used format 
units. Format argument always (or almost always) is written in a line with a 
function.

--
components: Argument Clinic, Demos and Tools
files: clinic_format_argument.patch
keywords: patch
messages: 241531
nosy: larry, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Write PyArg_Parse* format in a line with a function
type: enhancement
versions: Python 3.5
Added file: http://bugs.python.org/file39121/clinic_format_argument.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24007
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24001] Clinic: use raw types in types= set

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

Thanks to #24002 I now know how to write evalify_node properly.  This revision 
of the patch is much better, and maybe ready for checkin.

--
Added file: 
http://bugs.python.org/file39122/larry.one.more.clinic.format.unit.map.cleanup.2.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24001
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24003] variable naming

2015-04-19 Thread Zachary Ware

Changes by Zachary Ware zachary.w...@gmail.com:


--
stage:  - resolved

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24003
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24000] More fixes for the Clinic mapping of converters to format units

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

New diff based on Serhiy's latest round of comments.  Thanks, Serhiy!  You are 
inexhaustable!

--
Added file: 
http://bugs.python.org/file39125/larry.one.more.clinic.format.unit.map.cleanup.3.txt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24000
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23994] argparse fails to detect program name when there is a slash at the end of the program's path

2015-04-19 Thread R. David Murray

R. David Murray added the comment:

Thanks for the patch.  We'll want a unit test for the behavior before 
committing this.

--
nosy: +r.david.murray
stage:  - test needed
versions: +Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23994
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24009] Get rid of rare format units in PyArg_Parse*

2015-04-19 Thread Serhiy Storchaka

New submission from Serhiy Storchaka:

There are a lot of format units supported in PyArg_Parse* functions, but some 
of them are rarely or never used in current CPython code. Some of format units 
are legacy from Python 2 and are not needed in modern Python 3 code or can be 
replaced with custom converter.

Here are results of grepping (not including Modules/_testcapimodule.c).

es, es#, et#, z*, Z# are not used.

y#:
Modules/_io/textio.c:2334:if (!PyArg_ParseTuple(_state, y#i, 
dec_buffer, dec_buffer_len, dec_flags)) { \

z#:
Modules/_ctypes/_ctypes.c:3327:if (!PyArg_ParseTuple(args, is|Oz#, 
index, name, paramflags, iid, iid_len))

u#:
Modules/arraymodule.c:248:if (!PyArg_Parse(v, u#;array item must be 
unicode character, p, len))
PC/winreg.c:1547:if (!PyArg_ParseTuple(args, OZiu#:SetValue,

y:
Modules/_io/textio.c:2334:if (!PyArg_ParseTuple(_state, y#i, 
dec_buffer, dec_buffer_len, dec_flags)) { \
Modules/_cursesmodule.c:2790:if (!PyArg_ParseTuple(args,y;str, str))
Modules/_cursesmodule.c:3026:if (!PyArg_ParseTuple(args, 
y|i:tparm,
Modules/posixmodule.c:3767:if (!PyArg_ParseTuple (args, 
y:_getfullpathname,
Modules/posixmodule.c:3872:if (!PyArg_ParseTuple(args, y:_isdir, path))
Modules/faulthandler.c:941:if (!PyArg_ParseTuple(args, y:fatal_error, 
message))

et:
Modules/socketmodule.c:4499:if (!PyArg_ParseTuple(args, et:gethostbyname, 
idna, name))
Modules/socketmodule.c:4667:if (!PyArg_ParseTuple(args, 
et:gethostbyname_ex, idna, name))
Modules/socketmodule.c:4744:if (!PyArg_ParseTuple(args, et:gethostbyaddr, 
idna, ip_num))
Modules/_tkinter.c:2099:if (!PyArg_ParseTuple(args, et:splitlist, 
utf-8, list))
Modules/_tkinter.c:2162:if (!PyArg_ParseTuple(args, et:split, utf-8, 
list))
Modules/_ssl.c:3038:if (!PyArg_ParseTupleAndKeywords(args, kwds, 
O!iet:_wrap_socket, kwlist,
Modules/_ssl.c:3070:if (!PyArg_Parse(hostname_obj, et, idna, 
hostname))

s*:
Modules/_codecsmodule.c:188:if (!PyArg_ParseTuple(args, 
s*|z:escape_decode,
Modules/_codecsmodule.c:552:if (!PyArg_ParseTuple(args, 
s*|z:unicode_escape_decode,
Modules/_codecsmodule.c:569:if (!PyArg_ParseTuple(args, 
s*|z:raw_unicode_escape_decode,
Modules/_codecsmodule.c:696:if (!PyArg_ParseTuple(args, 
s*|z:readbuffer_encode,
Modules/_ssl.c:3734:if (!PyArg_ParseTuple(args, s*d:RAND_add, view, 
entropy))
Modules/fcntlmodule.c:225:if (PyArg_Parse(ob_arg, s*:ioctl, pstr)) {
Modules/clinic/arraymodule.c.h:278:if (!PyArg_Parse(arg, s*:fromstring, 
buffer))

s#:
Modules/_gdbmmodule.c:128:if (!PyArg_Parse(key, s#, krec.dptr, 
krec.dsize) )
Modules/_gdbmmodule.c:176:if (!PyArg_Parse(v, s#, krec.dptr, 
krec.dsize) ) {
Modules/_gdbmmodule.c:194:if (!PyArg_Parse(w, s#, drec.dptr, 
drec.dsize)) {
Modules/fcntlmodule.c:71:if (PyArg_Parse(arg, s#, str, len)) {
Modules/_ctypes/_ctypes.c:2569:if (!PyArg_ParseTuple(args, Os#, dict, 
data, len))
Modules/clinic/unicodedata.c.h:361:if (!PyArg_Parse(arg, s#:lookup, 
name, name_length))
Modules/clinic/_dbmmodule.c.h:62:if (!PyArg_ParseTuple(args, s#|O:get,
Modules/clinic/_dbmmodule.c.h:95:if (!PyArg_ParseTuple(args, 
s#|O:setdefault,
Modules/clinic/_gdbmmodule.c.h:150:if (!PyArg_Parse(arg, s#:nextkey, 
key, key_length))
Modules/_dbmmodule.c:108:if (!PyArg_Parse(key, s#, krec.dptr, tmp_size) 
)
Modules/_dbmmodule.c:132:if ( !PyArg_Parse(v, s#, krec.dptr, tmp_size) 
) {
Modules/_dbmmodule.c:150:if ( !PyArg_Parse(w, s#, drec.dptr, 
tmp_size) ) {
Modules/_dbmmodule.c:336:if ( !PyArg_Parse(default_value, s#, 
val.dptr, tmp_size) ) {

In future may be we could deprecate some format units and remove them in 4.0.

This issue is a meta issue. Every case should be considered individually.

--
assignee: serhiy.storchaka
components: Interpreter Core
messages: 241546
nosy: serhiy.storchaka
priority: low
severity: normal
status: open
title: Get rid of rare format units in PyArg_Parse*
type: enhancement
versions: Python 3.5, Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24009
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24006] Multiprocessing fails when using functions defined in interactive interpreter.

2015-04-19 Thread R. David Murray

R. David Murray added the comment:

I'm guessing you are on Windows.  Please read 
https://docs.python.org/2/library/multiprocessing.html#windows.  You can't do 
what you show on windows (though you can on unix, since it uses fork).

--
nosy: +r.david.murray
resolution:  - not a bug
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24006
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24010] Add error checks to PyInit__locale()

2015-04-19 Thread Christian Heimes

New submission from Christian Heimes:

The init function of the locale module fails to check for errors in a couple of 
places. The patch replaces PyDict_SetItemString() calls with 
PyModule_AddIntMacro() and error checks. An exception is unlikely so I'm OK 
when the patch just lands in 3.4 and 3.5.

CID 1295027 (#8 of 8): Dereference null return value (NULL_RETURNS)
dereference: Dereferencing a pointer that might be null x when calling 
PyDict_SetItemString

--
components: Extension Modules
files: localemodule.patch
keywords: patch
messages: 241550
nosy: christian.heimes, lemburg, loewis
priority: normal
severity: normal
stage: patch review
status: open
title: Add error checks to PyInit__locale()
type: behavior
versions: Python 3.4, Python 3.5
Added file: http://bugs.python.org/file39126/localemodule.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24010
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22619] Possible implementation of negative limit for traceback functions

2015-04-19 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Needed a documentation. I'm not interested in writing it.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22619
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24013] Improve os.scandir() and DirEntry documentation

2015-04-19 Thread Ben Hoyt

New submission from Ben Hoyt:

Victor Stinner's documentation for os.scandir and DirEntry is a great start 
(https://docs.python.org/dev/library/os.html#os.scandir), however there are a 
few mistakes in it, and a few ways I think it could be improved. Attaching a 
patch with the following overall changes:

1. Tweak the see also note on os.listdir() to mention *why* you'd want to use 
scandir -- namely that it includes file attribute info, and performance.
2. Move that str/bytes note in the scandir() docs down a bit, as I think that's 
really a detail and the other stuff is more important.
3. More details on why you'd want to use scandir -- to increase the 
performance of code that also needs file type or file -- and be more specific 
about what system calls are and are not required.
4. Replace POSIX with Unix, per the rest of the os module docs when talking 
about generic Unix-like operating systems. It seems POSIX is used 
specifically when talking about the POSIX standard.
5. Remove half-true statement in DirEntry docs, if a file is deleted between 
calling scandir and stat, a FileNotFoundError can be raised -- but the method 
docs state that they specifically don't raise FileNotFoundError.
6. Removed unfortunately, the behaviour of errors depends on the platform. 
This is always the case and doesn't add anything.
7. Tried to simplify and clarify the is_dir() and is_file() docs. Not sure I've 
succeeded here. This is hard!
8. Added Availability: Unix, Windows. to scandir docs like listdir and most 
other os functions have.
9. Remove the see also about how the listdir function returns the names of the 
directory entries as that's already stated/implied above.

--
assignee: docs@python
components: Documentation
files: scandir_doc_tweaks.patch
keywords: patch
messages: 241560
nosy: benhoyt, docs@python, haypo, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Improve os.scandir() and DirEntry documentation
versions: Python 3.5
Added file: http://bugs.python.org/file39131/scandir_doc_tweaks.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24013
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24006] Multiprocessing fails when using functions defined in interactive interpreter.

2015-04-19 Thread ppperry

New submission from ppperry:

An AttributeError is raised when starting a new process with an object defined 
in the interactive interpreter
def test():print test
test()
test
from threading import Thread
Thread(target=test).start()
test
from multiprocessing import Process
Process(target=test).start()
traceback, ending with
File path to python/Lib/pickle.py, line 1126, in find_class
  klass = getattr(mod, name)
AttributeError: 'module' object has no attribute 'test'
running similar code in a file works and does not raise an error.

--
components: Interpreter Core, Library (Lib)
messages: 241521
nosy: ppperry
priority: normal
severity: normal
status: open
title: Multiprocessing fails when using functions defined in interactive 
interpreter.
type: behavior
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24006
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-04-19 Thread R. David Murray

Changes by R. David Murray rdmur...@bitdance.com:


--
stage: patch review - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23725
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24002] Add un-parse function to ast

2015-04-19 Thread Larry Hastings

Larry Hastings added the comment:

There is!  compile() will do it, though the docstring doesn't mention it. (The 
full documentation does.)

The following function meets both my use cases:

def eval_ast_expr(node, symbols=None, *, filename='-'):

Takes an ast.Expr node.  Compiles and evaluates it.
Returns the result of the expression.

symbols represents the globals dict the expression
should see.  (There's no equivalent for locals here.)


if not isinstance(node, ast.Expr):
raise RuntimeError(
eval_ast_expr: node must be of type ast.Expr)

if symbols == None:
symbols = globals()

a = ast.Expression(node.value)
co = compile(a, filename, 'eval')
fn = types.FunctionType(co, symbols)
return fn()

I am therefore closing this bug.  It still seems like a nice-to-have but I'll 
let somebody else do it when *they* have a use case.

--
resolution:  - later
stage: needs patch - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24002
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17227] devguide: buggy heading numbers

2015-04-19 Thread Carol Willing

Carol Willing added the comment:

Berker, Thanks for the patch review. I'm going to work with the folks at Sphinx 
project this week to see if the headings are fixed in a newer Sphinx version. 
If so, I will make the change here. If not, I will follow your recommendation 
to close and create an issue on the Sphinx issue tracker.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17227
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Ionel Cristian Mărieș

Ionel Cristian Mărieș added the comment:

On Sun, Apr 19, 2015 at 9:01 PM, Eric Snow rep...@bugs.python.org wrote:

 Finally, instead of changing callable, why not use a metaclass that does
 the right thing?  I believe MagicMock does something along those lines.


​What would be the right thing? AFAIK this cannot be achieved with a
metaclass, since the check in `callable` just does a dumb check for
`x-ob_type-tp_call​`. Seriously, if you know a way to make
`x-ob_type-tp_call​` run any python code please let me know :-)

Thanks,
-- Ionel Cristian Mărieș, http://blog.ionelmc.ro

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23982] Tkinter in Python 3.4 for Windows incorrectly renders certain colors using non-TclTk RGB values

2015-04-19 Thread Terry J. Reedy

Terry J. Reedy added the comment:

The tkinter docs need to be expanded, but that is a different issue.

The complete tcl/tk version is displayed in Idle - Help - About Idle using 
self.tk.call('info', 'patchlevel').  Pending a reason not to, I would be in 
favor of adding this full info as a tkinter attribute (.version ?, .patch_level 
?) in addition to the current .TclVersion and .TkVersion attributes (which are 
now always the same, though once probably not).  This would be a new tracker 
issue.  

Adding the tcl/tk version included with the windows installer to the download 
web page seems reasonable to me.  This would be a third issue, involving 
revision of PEP 101 on making releases.  The first change would be the RM 
(Release Manager) getting the info from the WE (Windows Expert).  This would go 
somewhere under The WE then generates Windows installer files. Then somewhere 
under Now it's time [for the RM] to twiddle the web site. would be something 
about inserting the tcl/tk version is a revised template page, or whatever.  I 
leave it to you to look as the site for the specific page to revise and how, 
and to read this section of the PEP.  Proposed PEP changes are usually sent to 
PEP editors.  If you want to pursue this, you might first email Barry to see 
what he would prefer.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23982
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue22619] Possible implementation of negative limit for traceback functions

2015-04-19 Thread Riley Banks

Changes by Riley Banks waul...@gmail.com:


--
nosy: +vaultah

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22619
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24005] Documentation Error: Extra line Break

2015-04-19 Thread Tim Golden

Tim Golden added the comment:

One small thing to bear in mind is that the existing code (ie with the extra 
linefeed) raises an IndentationError if cut-and-pasted into the interactive 
interpreter; with the OP's change, it succeeds. Might not have been their 
intention, but certainly is the case.

(Doesn't make it a bug, as such, but makes it more than a stylistic difference 
of opinion).

--
nosy: +tim.golden

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24005
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue21574] Port image types detections from PIL to the imghdr module

2015-04-19 Thread Claudiu Popa

Changes by Claudiu Popa pcmantic...@gmail.com:


--
stage: needs patch - test needed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21574
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24012] Add error checks to PyInit_pyexpat()

2015-04-19 Thread Christian Heimes

New submission from Christian Heimes:

Similar to #24011 and #24010 the pyexpat module's init function fails to check 
some return values for NULL. The patch doesn't include proper reference 
cleanups as most of the other parts of PyInit_pyexpat() don't cleanup on error, 
too.

CID 982779 (#2 of 2): Dereference null return value (NULL_RETURNS)
dereference: Dereferencing a pointer that might be null sys_modules when 
calling PyDict_SetItem

CID 982240 (#2 of 2): Unchecked return value (CHECKED_RETURN)
check_return: Calling PyDict_SetItem without checking return value (as is done 
elsewhere 158 out of 174 times)

--
components: Extension Modules
files: pyexpat.patch
keywords: patch
messages: 241555
nosy: christian.heimes, eli.bendersky, scoder
priority: normal
severity: normal
stage: patch review
status: open
title: Add error checks to PyInit_pyexpat()
type: behavior
versions: Python 3.4, Python 3.5
Added file: http://bugs.python.org/file39129/pyexpat.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24012
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23993] Use surrogateescape error handler by default in open() if the LC_CTYPE locale is C at startup

2015-04-19 Thread STINNER Victor

STINNER Victor added the comment:

Related issues and discussions:
- [Python-Dev] open(): set the default encoding to 'utf-8' in Python 3.3?
  https://mail.python.org/pipermail/python-dev/2011-June/112086.html
- Issue #12451: open: avoid the locale encoding when possible
  https://bugs.python.org/issue12451

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23993
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Ionel Cristian Mărieș

Ionel Cristian Mărieș added the comment:

On Sun, Apr 19, 2015 at 10:01 PM, Ethan Furman rep...@bugs.python.org
wrote:

 The right thing, using a meta-class, is to have the meta-class check if
 the proxied object is callable, and if so, put in the __call__ function in
 the class that is being created.

​Yes indeed, for a plain proxy. Unfortunately for a *lazy* proxy this is
not acceptable as it ​would create (or access) the target. The point is
to delay that till it's actually needed, not when the proxy is created.

Thanks,
-- Ionel Cristian Mărieș, http://blog.ionelmc.ro

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24008] inspect.getsource is failing for sys.excepthook

2015-04-19 Thread Claudiu Popa

Claudiu Popa added the comment:

That's actually expected, since sys.excepthook is a builtin, so there's no 
source code to be retrieved (the same holds for other builtins, such as next, 
range etc).

--
nosy: +Claudiu.Popa
resolution:  - not a bug
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24008
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23998] PyImport_ReInitLock() doesn't check for allocation error

2015-04-19 Thread Roundup Robot

Roundup Robot added the comment:

New changeset d70995cf44b3 by Christian Heimes in branch '2.7':
Issue #23998: PyImport_ReInitLock() now checks for lock allocation error
https://hg.python.org/cpython/rev/d70995cf44b3

New changeset 7d7bf5c34d7e by Christian Heimes in branch '3.3':
Issue #23998: PyImport_ReInitLock() now checks for lock allocation error
https://hg.python.org/cpython/rev/7d7bf5c34d7e

New changeset e0bd083fc9c1 by Christian Heimes in branch '3.4':
Issue #23998: PyImport_ReInitLock() now checks for lock allocation error
https://hg.python.org/cpython/rev/e0bd083fc9c1

New changeset 7ae8fd62d743 by Christian Heimes in branch 'default':
Issue #23998: PyImport_ReInitLock() now checks for lock allocation error
https://hg.python.org/cpython/rev/7ae8fd62d743

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23998
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue24005] Documentation Error: Extra line Break

2015-04-19 Thread Carol Willing

Carol Willing added the comment:

Tim, A good point re: the interpreter. I've attached an output from IPython 
interpreter.

Georg, Given Tim's additional insight, I'm inclined to reopen the issue and 
review the patch as a positive change. Though not a bug, but as an enhancement 
for learners to copy-paste doc code into an interpreter. Thoughts?

--
Added file: http://bugs.python.org/file39130/Screen Shot 2015-04-19 at 12.19.07 
PM.png

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24005
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Joe Jevnik

Joe Jevnik added the comment:

This is a different case from raising an AttributeError inside the __call__;


 class C(object):
... def __call__(self):
... raise AttributeError()
...
 hasattr(C(), '__call__')
True
 class D(object):
... @property
... def __call__(self):
... raise AttributeError()
...
 hasattr(C(), '__call__')
False

AttributeError was picked very intentionally for the example.

The docs show that n(args) == n.__call__(args) if n has a __call__; however, if 
a property raises an AttributeError, then it really does not have a __call__.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23990
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23990] Callable builtin doesn't respect descriptors

2015-04-19 Thread Ionel Cristian Mărieș

Ionel Cristian Mărieș added the comment:

On Sun, Apr 19, 2015 at 10:29 PM, Steven D'Aprano rep...@bugs.python.org
wrote:

 This bug report seems to be completely based on a false premise. In the
 very first message of this issue, Ionel says:

 it return True even if __call__ is actually an descriptor that raise
 AttributeError (clearly not callable at all).

 but that is wrong. It *is* callable, and callable() is correct to return
 True. If you look at the stack trace, the __call__ method
 (function/property, whatever you want to call it) is called, and it raises
 an exception. That is no different from any other method or function that
 raises an exception.

 It is wrong to think that raising AttributeError *inside* __call__ makes
 the object non-callable.

 Ionel, I raised these issues on Python-list here:

 https://mail.python.org/pipermail/python-ideas/2015-April/033078.html

 but you haven't responded to them.

I was hoping my other replies had addressed those issues. Note that the
presence of __call__ on the callstack is merely an artefact of how
@property works, and it's not actually the __call__ method (it's just
something that property.__get__ calls).

Here's an example that hopefully illustrates the issue more clearly:

 class CallDescriptor:
... def __get__(self, inst, owner):
... target = inst._get_target()
... if callable(target):
... return target
... else:
... raise AttributeError('not callable')
...
 class LazyProxy:
... __call__ = CallDescriptor()
... def __init__(self, get_target):
... self._get_target = get_target
...
 def create_stuff():
... # heavy computation here
... print(Doing heavey computation)
... return 1, 2, 3
...
 proxy = LazyProxy(create_stuff)
 callable(proxy)  ### this should be false!
True
 hasattr(proxy, '__call__')
Doing heavey computation
False

 def create_callable_stuff():
... # heavy computation here
... print(Doing heavey computation)
... def foobar():
... pass
... return foobar
...
 proxy = LazyProxy(create_callable_stuff)
 callable(proxy)
True
 hasattr(proxy, '__call__')
Doing heavey computation
True​

Now it appears there's a second issue, slightly related - if you actually
call the proxy object AttributeError is raised (instead of the TypeError):

 proxy = LazyProxy(create_stuff)
 callable(proxy)
True
 hasattr(proxy, '__call__')
Doing heavey computation
False
 proxy()
Doing heavey computation
Traceback (most recent call last):
  File stdin, line 1, in module
  File stdin, line 7, in __get__
AttributeError: not callable

 target = create_stuff()
Doing heavey computation
 target()
Traceback (most recent call last):
  File stdin, line 1, in module
TypeError: 'tuple' object is not callable

Contrast that to how iter works - if the descriptor raise AttributeError
then iter raises TypeError (as expected):

 class IterDescriptor:
... def __get__(self, inst, owner):
... target = inst._get_target()
... if hasattr(type(target), '__iter__') and hasattr(target,
'__iter__'):
... return target.__iter__
... else:
... raise AttributeError('not iterable')
...
 class LazyProxy:
... __iter__ = IterDescriptor()
... def __init__(self, get_target):
... self._get_target = get_target
...
 def create_iterable_stuff():
... # heavy computation here
... print(Doing heavey computation)
... return 1, 2, 3
...
 proxy = LazyProxy(create_iterable_stuff)
 iter(proxy)
Doing heavey computation
tuple_iterator object at 0x02B7C908

 def create_noniterable_stuff():
... # heavy computation here
... print(Doing heavey computation)
... def foobar():
... pass
... return foobar
...
 proxy = LazyProxy(create_noniterable_stuff)
 iter(proxy)
Doing heavey computation
Traceback (most recent call last):
  File stdin, line 1, in module
TypeError: 'LazyProxy' object is not iterable

 proxy.__iter__
Doing heavey computation
Traceback (most recent call last):
  File stdin, line 1, in module
  File stdin, line 7, in __get__
AttributeError: not iterable

​
​So this is why I'm bringing this up. If `iter` wouldn't handle it like
that then I'd think that maybe this is the intended behaviour.​
​

I hope the blatant inconsistency is more clear​
​ now​
​, and you'll understand that this bug report is not just some flagrant
misunderstanding of how __call__ works.

To sum this up, the root of this issue is that `callable` doesn't do all
the checks that are done right before actually performing the call (like
the descriptor handling). It's like calling your doctor for an appointment
where the secretary schedules you, but forgets to check if the doctor is in
vacation or not.

Thanks,
-- Ionel Cristian Mărieș, http://blog.ionelmc.ro

--

___
Python tracker rep...@bugs.python.org

[issue23917] please fall back to sequential compilation when concurrent doesn't exist

2015-04-19 Thread Claudiu Popa

Claudiu Popa added the comment:

Here's the patch.

--
keywords: +patch
stage: needs patch - patch review
Added file: http://bugs.python.org/file39132/issue23917.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23917
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23993] Use surrogateescape error handler by default in open() if the LC_CTYPE locale is C at startup

2015-04-19 Thread R. David Murray

R. David Murray added the comment:

Well, previously our answer has been you have to understand unicode.  If we 
are going to change that, it probably needs a python-dev discussion.  But like 
I said, providing the *tools* to make it possible to easily do this, just not 
as a default, seems like mostly a no-brainer.  It's making it the default that 
is controversial, IMO.  (Call me -0.5 at this point in the discussion, as 
regards making it the default).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23993
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15582] Enhance inspect.getdoc to follow inheritance chains

2015-04-19 Thread Ethan Furman

Ethan Furman added the comment:

Sounds like good incentive to add good docstrings.  :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15582
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >