[issue20184] Derby #16: Convert 50 sites to Argument Clinic across 9 files

2015-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch that converts 3 functions in the _json module to Argument Clinic. All other functions doesn't fit with Argument Clinic. -- Added file: http://bugs.python.org/file39292/json_clinic.patch ___ Python t

[issue24113] shlex constructor unreachable code

2015-05-04 Thread Berker Peksag
Changes by Berker Peksag : -- stage: needs patch -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue24113] shlex constructor unreachable code

2015-05-04 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- priority: normal -> low resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Pyth

[issue24113] shlex constructor unreachable code

2015-05-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 395e190ead36 by Raymond Hettinger in branch 'default': Issue #24113: Remove unreachable code in shlex. https://hg.python.org/cpython/rev/395e190ead36 -- nosy: +python-dev ___ Python tracker

[issue24117] Wrong range checking in GB18030 decoder.

2015-05-04 Thread Ma Lin
Ma Lin added the comment: I found another bug in hz codec. hz encoding uses 7-bit ASCII to represent Chinese characters, it was popular in USENET networks in the late 1980s and early 1990s. I will do more check and fix them together, then I will invite you to review the patch. u = 'hi~python

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

2015-05-04 Thread David D. Riddle
David D. Riddle added the comment: I have made the changes you suggested. Please tell me if any further changes are needed. > The unclosed file suggests a cleanup bug in linecache which we should > fix for hygiene, but is separate :) Should I file a bug report? -- Added file: http://b

[issue24125] Fix for #23865 breaks docutils

2015-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch that keeps error column and line after closing ExpatParser if error was occurred. -- keywords: +patch stage: -> patch review type: -> behavior versions: +Python 3.5 Added file: http://bugs.python.org/file39290/expatreader_keep_col_li

[issue24085] large memory overhead when pyc is recompiled

2015-05-04 Thread Buck Evan
Buck Evan added the comment: @serhiy.storchaka This is a very stable piece of a legacy code base, so we're not keen to refactor it so dramatically, although we could. We've worked around this issue by compiling pyc files ahead of time and taking extra care that they're preserved through deplo

[issue24125] Fix for #23865 breaks docutils

2015-05-04 Thread Dmitry Shachnev
Changes by Dmitry Shachnev : -- nosy: +larry versions: +Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: I don't know why you're bringing up previous versions of Python. The clinic.py under review here is for 3.5. -- ___ Python tracker ___ ___

[issue24125] Fix for #23865 breaks docutils

2015-05-04 Thread Matthias Klose
Changes by Matthias Klose : -- nosy: +benjamin.peterson priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-lis

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: The length attribute is an internal implementation detail, so its name is not relevant. It's used in the generation of the accompanying "length" parameter for the impl function for this converter. "length" is a good name for it. "zeroes" is not a good name

[issue23865] Fix possible leaks in close methods

2015-05-04 Thread Dmitry Shachnev
Dmitry Shachnev added the comment: This broke docutils, see issue #24125. -- nosy: +mitya57 ___ Python tracker ___ ___ Python-bugs-lis

[issue24125] Fix for #23865 breaks docutils

2015-05-04 Thread Dmitry Shachnev
New submission from Dmitry Shachnev: Fix for issue #23865 (i.e. https://hg.python.org/cpython/rev/f7ddec2e9e93 in 2.7 branch) introduced a change for xml.sax.expatreader.ExpatParser class that makes its close() method delete _parser object. This breaks docutils, which handles exceptions in par

[issue8372] socket: Buffer overrun while reading unterminated AF_UNIX addresses

2015-05-04 Thread Mark Lawrence
Mark Lawrence added the comment: As this is flagged as a high priority security issue shouldn't we be implementing needed source code changes? According to msg138224 "The patches look good to me". -- nosy: +BreamoreBoy versions: +Python 3.5 ___ Pyth

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In Python 2 and earlier in Python 3 there were no restrictions that arguments for format units "s", "y", "u", "z" and "Z" (matching Argument Clinic converters with length=False) shouldn't contain NUL. And this was considered as a bug. As for NUL, ask Victor

[issue21069] test_fileno of test_urllibnet intermittently fails when using www.example.com

2015-05-04 Thread Mark Lawrence
Mark Lawrence added the comment: I tried reproducing this on Windows 8.1 with the code snippet from msg216429 but got Traceback (most recent call last): File "C:\Users\Mark\Documents\MyPython\mytest.py", line 9, in with os.fdopen(fd, 'rb') as f: File "c:\python34\lib\os.py", line 980,

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: As for "why not length instead of zeroes": Because the primary reason for the parameter is specifying that the string can contain embedded zeroes. Returning the length is a side-effect of this, not the main point. If the string didn't have embedded zeroes, w

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: I don't think those are better names. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: May be "string", or "data", or "buffer" would be better names? "str" looks as Python type. -- ___ Python tracker ___

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Why not left the length parameter instead? First, current code uses "length". Second, the main effect from C side is that an argument is a pair (pointer, length), not just a pointer. Third, currently everywhere in Python documentation and error messages the

[issue23911] Move path-based bootstrap code to a separate frozen file.

2015-05-04 Thread Eric Snow
Changes by Eric Snow : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: As for "str doesn't even accept str for y and y#", the name "str" is not for the Python type, it's for the C type. -- ___ Python tracker ___ __

[issue17477] update the bsddb module do build with db 5.x versions

2015-05-04 Thread Mark Lawrence
Mark Lawrence added the comment: >From >http://www.oracle.com/technetwork/database/database-technologies/berkeleydb/downloads/index.html > the latest version is 6.1.23. Given the extended life span of 2.7 I'd assume >that the patch here is worth updating. See also #18734. -- nosy: +B

[issue1100942] Add datetime.time.strptime and datetime.date.strptime

2015-05-04 Thread Mark Lawrence
Mark Lawrence added the comment: @Alexander as the datetime expert could you get this committed in time for 3.5? -- nosy: +BreamoreBoy ___ Python tracker ___ __

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: Here's an updated patch where I've removed the "length" parameter to converters, instead relying solely on the "zeroes" parameter. -- Added file: http://bugs.python.org/file39289/larry.one.more.clinic.format.unit.map.cleanup.5.txt

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: I have no interest in naming "str" to "pchar". Yes, *most* of the other converters are named after the C type they translate to. But so far converter names doesn't mention whether or not they represent pointers to types--it's "object", not "pobject", it's "Py

[issue3367] Uninitialized value read in parsetok.c

2015-05-04 Thread Mark Lawrence
Mark Lawrence added the comment: The fix proposed by Alexander in issue3367.diff has never been applied. How would I go about reproducing the original issue on Windows? -- nosy: +BreamoreBoy versions: +Python 3.4, Python 3.5 -Python 3.3 ___ Python t

[issue23911] Move path-based bootstrap code to a separate frozen file.

2015-05-04 Thread Eric Snow
Changes by Eric Snow : -- resolution: -> fixed status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue23911] Move path-based bootstrap code to a separate frozen file.

2015-05-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 36b902bbc992 by Eric Snow in branch 'default': Issue #23911: Fix mixed bytes/strings. https://hg.python.org/cpython/rev/36b902bbc992 -- ___ Python tracker

[issue24086] Configparser interpolation is unexpected

2015-05-04 Thread Trevor Bekolay
Trevor Bekolay added the comment: Thanks for the quick response! I can see the use case for using interpolation in .pypirc. Unfortunately for me, I push releases for both Python 2 and Python 3, so having the double percent sign will cause problems for me on Python 2. The exception that's being

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I would say it is very unlikely. In any case, if we have a pointer and a length, we always can check for zeros after parsing. May be rename the str converter to pchar and the Py_UNICODE converter to pwchar? Usually the converter is named by C type, not Pytho

[issue24000] More fixes for the Clinic mapping of converters to format units

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: Here's a freshened version of the patch. I updated the Clinic HOWTO. Serhiy: You're right, length and zeroes always have the same value. Would you ever want length without allowing zeroes? Like, in the future, would we ever want str(length=True) so we'r

[issue24001] Clinic: use raw types in types= set

2015-05-04 Thread Larry Hastings
Changes by Larry Hastings : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue24119] Carry comments with the AST

2015-05-04 Thread Christian Heimes
Changes by Christian Heimes : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue24088] yield expression confusion

2015-05-04 Thread R. David Murray
R. David Murray added the comment: I don't think anything about frames is guaranteed as part of the language, so I'm not sure that mention of it belongs in the description. Personally, I find your reformulation more confusing that the original with 'a' replaced by 'the'. -- _

[issue24119] Carry comments with the AST

2015-05-04 Thread Brett Cannon
Brett Cannon added the comment: Normally I would agree comments don't belong there, but if we are going to start giving them semantic meaning then I don't think it's not so clear to me anymore. As to where to attach, simple place is off of the Module node. Another is to have it be fundamental

[issue24088] yield expression confusion

2015-05-04 Thread Jim Jewett
Jim Jewett added the comment: OK, then how about Current: """ When a generator function is called, it returns an iterator known as a generator. That generator then controls the execution of a generator function. The execution starts when one of the generator’s methods is called. """ Proposed:

[issue24001] Clinic: use raw types in types= set

2015-05-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset 41fb7fd04b5d by Larry Hastings in branch 'default': Issue #24001: Argument Clinic converters now use accept={type} https://hg.python.org/cpython/rev/41fb7fd04b5d -- nosy: +python-dev ___ Python tracker <

[issue23911] Move path-based bootstrap code to a separate frozen file.

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: This checkin broke the buildbots. If you build trunk then run ./python -bb -m test test_site the test fails. "-bb" is used by the normal test runner ("make test"). The problem is in the lines self.assertTrue(os.path.isabs(os__file__),

[issue24102] Multiple type confusions in unicode error handlers

2015-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Also fixed handling errors of PyObject_IsSubclass() (issue24115) in the _codecs module. -- Added file: http://bugs.python.org/file39287/codecs_error_handlers_issubclass_3.patch ___ Python tracker

[issue24124] Two versions of instructions for installing Python modules

2015-05-04 Thread Skip Montanaro
New submission from Skip Montanaro: I was hunting around the current website for notes on installing Python. Couldn't find any (BTW), so I looked in the Python source. Imagine my surprise to find two apparently overlapping files describing how to build Python modules: ./Doc/install/index.rst .

[issue20159] Derby #7: Convert 51 sites to Argument Clinic across 3 files -> Derby: Convert the ElementTree module to use Argument Clinic

2015-05-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: -serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue20159] Derby #7: Convert 51 sites to Argument Clinic across 3 files -> Derby: Convert the ElementTree module to use Argument Clinic

2015-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Original issue is resolved and I have no any relations to modules added by Larry. -- dependencies: -Add docstrings for ElementTree module stage: patch review -> needs patch ___ Python tracker

[issue20148] Derby: Convert the _sre module to use Argument Clinic

2015-05-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue20168] Derby: Convert the _tkinter module to use Argument Clinic

2015-05-04 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24116] --with-pydebug has no effect when the final python binary is compiled

2015-05-04 Thread Skip Montanaro
Skip Montanaro added the comment: > It's confusing that the CFLAGS specified when running make are passed further > sometimes but not always. So I guess that's a workaround? Or CFLAGS should > never be specified to make directly? In my experience, all the magic happens in configure. Most of th

[issue20159] Derby #7: Convert 51 sites to Argument Clinic across 3 files -> Derby: Convert the ElementTree module to use Argument Clinic

2015-05-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset fea94f9cb5a0 by Serhiy Storchaka in branch 'default': Issue #20159. Converted the _elementtree module to Argument Clinic. https://hg.python.org/cpython/rev/fea94f9cb5a0 -- nosy: +python-dev ___ Python tra

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: Clinic's syntax is diverging from what shipped with 3.4. So if you copied _ssl.c over, it wouldn't work with the Clinic that shipped with 3.4. Maybe the best thing is if Clinic in trunk supports "legacy mode", where the code it generates is compatible with pr

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

2015-05-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I can propose three remedies: > > A) back out the Clinic conversion in _ssl.c > B) support Clinic in 2.7 just for _ssl.c > C) do a one-time backport of the Clinic generated code for _ssl.c I'd rather have A or C than B. By the way, this discussion seems to fo

[issue24100] Use after free in siftdown (2)

2015-05-04 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue24101] Use after free in siftup

2015-05-04 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue24099] Use after free in siftdown (1)

2015-05-04 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue24123] Python 2.7 Tutorial Conflicting behavior with WeakValueDictionary.

2015-05-04 Thread R. David Murray
R. David Murray added the comment: Well, technically it is probably not a bug. IPython is doubtless holding on to a reference to 'a' because it was defined at the prompt. Perhaps it could use a weakvaluedict for that, though :) On the other hand they might consider it a feature that objects

[issue15993] Windows: 3.3.0-rc2.msi: test_buffer fails

2015-05-04 Thread Mark Lawrence
Mark Lawrence added the comment: Is this now fixed in VS? I don't believe I can test myself as I've only got express/community editions. -- components: +Windows nosy: +BreamoreBoy ___ Python tracker _

[issue24122] Install fails after configure sets the extending/embedding install directory to NONE

2015-05-04 Thread Xavier de Gaye
Changes by Xavier de Gaye : -- nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue3786] _curses, _curses_panel & _multiprocessing can't be build in 2.6b3 w/ SunStudio 12

2015-05-04 Thread Wessel Badenhorst
Changes by Wessel Badenhorst : -- type: -> compile error ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue3539] Problem with testembed make dependencies in certain circumstances

2015-05-04 Thread Wessel Badenhorst
Changes by Wessel Badenhorst : -- type: -> compile error ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue2824] zipfile to handle duplicate files in archive

2015-05-04 Thread Wessel Badenhorst
Changes by Wessel Badenhorst : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue23670] Modifications to support iOS as a cross-compilation target

2015-05-04 Thread Russell Keith-Magee
Russell Keith-Magee added the comment: This new patch (20150504.diff) adds support for running the Python test suite The new patch is standalone, and contains everything in the previous patch. An XCode project (Tools/iOS-test) has been added to the source tree; this project contains bootstrap

[issue20159] Derby #7: Convert 51 sites to Argument Clinic across 3 files -> Derby: Convert the ElementTree module to use Argument Clinic

2015-05-04 Thread Larry Hastings
Larry Hastings added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue20159] Derby #7: Convert 51 sites to Argument Clinic across 3 files -> Derby: Convert the ElementTree module to use Argument Clinic

2015-05-04 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Made compatible with Windows compiler (I hope). -- Added file: http://bugs.python.org/file39285/etree_clinic_3.patch ___ Python tracker ___ __