[issue16261] Fix bare excepts in various places in std lib

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Resolved conflicts, fixed some noted issues in the patch and committed 
unquestionable changes. Thank you for your patch Ramchandra.

--
resolution:  - fixed
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16261
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16261] Fix bare excepts in various places in std lib

[Roundup Robot]

Roundup Robot added the comment:

New changeset b3a7215b9ce4 by Serhiy Storchaka in branch 'default':
Issue #16261: Converted some bare except statements to except statements
https://hg.python.org/cpython/rev/b3a7215b9ce4

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16261
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24245] Eliminate do-nothing exception handlers

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
assignee:  - serhiy.storchaka
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24245
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16261] Fix bare excepts in various places in std lib

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
assignee:  - serhiy.storchaka
stage: needs patch - patch review
versions: +Python 3.5 -Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16261
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Added comments on Rietveld. But I'm not sure that this change is worth to do. 
Only low-level functions in os.path and os modules (and few other) support 
bytes names (and only bytes, not bytearray!). High level interfaces, such as in 
tarfile or zipfile, work only with str paths. The question is what level the 
tempfile module?

In any way Mercurial people need their own wrapper if they want to support 
Python 3.5.

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24230
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21259] replace except: pass by except Exception: pass

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Just committed smaller patch in issue16261 and closed the issue.

Not all changes in the patch in this issue look innocent and correct.

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21259
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

[Martin Panter]

Martin Panter added the comment:

Doing a quick review, expect a few comments on Rietveld

--
nosy: +vadmium

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24230
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24245] Eliminate do-nothing exception handlers

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Changes look mostly good, but IDLE changes should be applied to all versions 
and the code in test_queue.py is dim.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24245
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

[R. David Murray]

R. David Murray added the comment:

We have a number of other places in the stdlib where bytes-in-bytes-out is 
observed, at various levels of abstraction.  I think this is reasonable.  To 
answer your direct question, I think tempfile is a convenience-and-do-it-right 
wrapper around what is really a pretty low level operation (creating a 
temporary file/directory securely).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24230
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24246] mimetypes.guess_extension returns different values when init() is called several times

[Emmanuel Gamby]

Changes by Emmanuel Gamby e.ga...@gmail.com:


--
type:  - behavior

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24246
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24243] behavior for finding an empty string is inconsistent with documentation

[swanson]

swanson added the comment:

Thanks for pointing out how count and replace operate.  I don't mind the 
ValueError: empty separator on split and partition - makes sense to me.

re: at least as long as the slice indexes are within range
If the slices indexes had to be in range, that would be inconsistent with the 
behavior of slicing, which is inconsistent with the docs, which was my main 
point.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24243
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24245] Eliminate do-nothing exception handlers

[Roundup Robot]

Roundup Robot added the comment:

New changeset 004c689d259c by Serhiy Storchaka in branch 'default':
Issue #24245: Eliminated senseless expect clauses that have no any effect.
https://hg.python.org/cpython/rev/004c689d259c

New changeset 56e1d24806b3 by Serhiy Storchaka in branch '2.7':
Issue #24245: Eliminated senseless expect clauses that have no any effect in
https://hg.python.org/cpython/rev/56e1d24806b3

New changeset f10ba5313fbb by Serhiy Storchaka in branch '3.4':
Issue #24245: Eliminated senseless expect clauses that have no any effect in
https://hg.python.org/cpython/rev/f10ba5313fbb

New changeset 5deb169ebb22 by Serhiy Storchaka in branch 'default':
Issue #24245: Eliminated senseless expect clauses that have no any effect in
https://hg.python.org/cpython/rev/5deb169ebb22

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24245
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24246] mimetypes.guess_extension returns different values when init() is called several times

[Emmanuel Gamby]

New submission from Emmanuel Gamby:

Hi,

Following the principle of least astonishment, I would expect the function to 
return the same value.

Python 2.7.3 (default, Mar 13 2014, 11:03:55) 
[GCC 4.7.2] on linux2
Type help, copyright, credits or license for more information.
 import mimetypes
 mimetypes.init()
 mimetypes.guess_extension('text/plain') 
'.ksh'
 mimetypes.init()
 mimetypes.guess_extension('text/plain') 
'.asc'
 mimetypes.init()
 mimetypes.guess_extension('text/plain') 
'.txt'

It seems that each call overrides the global dictionnary, which changes the 
iteration order of the next call.

Best Regards,
Emmanuel

--
components: Library (Lib)
messages: 243655
nosy: egamby
priority: normal
severity: normal
status: open
title: mimetypes.guess_extension returns different values when init() is called 
several times
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24246
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24243] behavior for finding an empty string is inconsistent with documentation

[Martin Panter]

Martin Panter added the comment:

There are a few related issues here I think:

1. Empty string search: I think it is completely valid to be able to find an 
empty string inside another string, at least as long as the slice indexes are 
within range. Although I remember it was a bit of a revelation the first time I 
considered this. Anyway, the documentation should explicitly mention this case.

2. .find(, 1, 0) - -1: This is inconsistent with startswith() and slicing, 
but the only reasonable alternative would be to return 1, which would be a 
strange index for an empty string. Certainly needs documenting though.

3. starts/endswith() slice arguments: I think they should be described 
equivalently to find() etc. So “start” points to the first character, “end” 
points after the last character, negative indexes from the end, etc.

4. .startswith(, 1, 0): This is True for str, and False for bytes, which is 
terribly inconsistent. My gut says both should be False, to match how find() 
works.

Some other related undocumented quirks:

 abcd.count()  # Infinity? End of the universe? No!
5
 abcd.replace(, _, 10)  # Might expect 10 underscores
'_a_b_c_d_'
 abcd.split(, 10)  # Might expect a list of 11 strings
ValueError: empty separator
 abcd.partition()  # Why not (, , abcd)?
ValueError: empty separator

--
nosy: +vadmium

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24243
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24068] statistics module - incorrect results with boolean input

[Matteo Dell'Amico]

Changes by Matteo Dell'Amico de...@linux.it:


--
nosy: +della

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24068
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24245] Eliminate do-nothing exception handlers

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Committed all changes except test_queue.py. Looks as this file is worth 
separate issue for refactoring. For example asserRaises() can be used in 
multiple places instead of try/fail/except idiom. May be there is other 
non-idiomatic code.

--
resolution:  - fixed
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24245
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10653] test_time test_strptime fails on windows

[eryksun]

eryksun added the comment:

This solution no longer works. If the system is configured to use the Japanese 
system locale and language pack, then 3.4.3 returns codepage 932 mojibake for 
the %Z time zone name. Originally [this approach worked][1] because it called 
PyUnicode_Decode using the 'mbcs' encoding.
Currently it calls PyUnicode_DecodeLocaleAndSize, which just ends up calling 
mbstowcs. That's pretty much what wcsftime does. In the default C locale, 
mbstowcs casts the byte values to wchar_t:

 time.strftime('%Z')
'\x91\xbe\x95\xbd\x97m\x89\xc4\x8e\x9e\x8a\xd4'
 time.strftime('%Z').encode('latin-1').decode('932')
'太平洋夏時間'

The problem is worse for 3.5 built with VC++ 14. In the new CRT strftime 
decodes the format string via MultiByteToWideChar, calls _Wcsftime_l, and 
encodes the result back via WideCharToMultiByte. The outer conversions use the 
default LC_TIME codepage, which is ANSI (ACP), so they're not the problem. The 
problem is the internal _mbstowcs_s_l conversion of the ANSI time zone name, 
which creates the above-shown mojibake 'unicode' string. This is then 
compounded by calling WideCharToMultiByte on the result:

 time.strftime('%Z')
'?m?A???O'

There's no way to fix this by transcoding. The result is just garbage.

[1]: https://hg.python.org/cpython/file/79e60977fc04/Modules/timemodule.c#l501

--
nosy: +eryksun
versions: +Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10653
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python Crash on strftime with %f on Python 3

[eryksun]

eryksun added the comment:

 I cannot reproduce it based on the existing issues using python 
 3.4.1 on Windows 7.

Majeed could be referring to the ValueError that gets raised for this [only on 
Windows][1]. In Linux %f passes through silently. Maybe for 3.5 an alternate 
approach would be to disable the Windows CRT's invalid parameter handler using 
_Py_BEGIN_SUPPRESS_IPH and _Py_END_SUPPRESS_IPH.

Looking at this brought issue 10653 to my attention. It seems VC++ 14 has 
exacerbated that problem, but that the current solution no longer works even in 
3.4.3 with VC++ 10. Should the issue be reopened or a new issue opened? 

[1]: https://hg.python.org/cpython/file/413e0e0004f4/Modules/timemodule.c#l611

--
nosy: +eryksun

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python Crash on strftime with %f on Python 3

[Majeed Arni]

Majeed Arni added the comment:

When we have this for format:
date_format = '%Y %m %d %H:%M:%S %z'
I see our logs as:
[2015 05 19 17:36:09 -0500] watcher modified

When I change the format to:
[2015 05 20 08:51:24 -0500] stderr AttributeError: 'StreamLogger' object has no 
attribute 'flush'

Unhandled exception in thread started by

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24243] behavior for finding an empty string is inconsistent with documentation

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Changing behavior of such base methods is dangerous and can break existing 
code. Even if the behavior is wrong, some code can depends on it. We should be 
very careful with this.

There are several simple invariants for these methods.

s1.index(s2, start, end) (for non-negative indices) returns minimal index i 
such that start = i and i + len(s2) = end and s1[i: i + len(s2)] = s2. Or 
raise an exception if such index doesn't exist. find() returns -1 instead of an 
exception. Therefore .find(, 1, 0) should be -1 and it is. All right.

The only bug is in inconsistency in startswith/endswith between str and bytes 
(unicode and str in Python 2). The worse, the behavior of str in Python 2 and 
Python 3 is different.

s1.startswith(s2, start, end) (for non-negative indices and non-tuple s2) is 
equivalent to start + len(s2) = end and s2[start: start + len(s2)] == s2. Or 
to s1.find(s2, start, end) == start. Therefore .startswith(, 1, 0) should 
be False, and it is for bytes and str in Python 2. The behavior of 
.startswith(, 1, 0) in Python 3 and u.startswith(u, 1, 0) in Python 3 
is wrong.

The question is can we fix this behavior in default branch (I think rather yes) 
and should we fix it in maintained releases (doubt)?

--
components: +Interpreter Core, Unicode
nosy: +benjamin.peterson, ezio.melotti, haypo, lemburg, pitrou, serhiy.storchaka
versions: +Python 2.7, Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24243
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows

[R. David Murray]

R. David Murray added the comment:

So, this is expected behavior on Windows.  I'm inclined to close the issue as 
not a bug unless the Windows folks think eryksun suggestion is worth 
considering.  (If the error is suppressed, does windows fill in the rest of the 
values and just leave the %f in the string?)

--
components: +Windows
nosy: +steve.dower, tim.golden, zach.ware
title: Python Crash on strftime with %f on Python 3 and Python 2 - Python 
exception on strftime with %f on Python 3 and Python 2 on windows

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24243] behavior for finding an empty string is inconsistent with documentation

[R. David Murray]

R. David Murray added the comment:

Serhiy: I agree.  I think the consistency with python2's string is the deciding 
factor, and we ought to fix it in default.  But not 3.4, because it is a 
behavior change.  I'd like other people's opinions, though.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24243
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows

[eryksun]

eryksun added the comment:

 If the error is suppressed, does windows fill in the rest of 
 the values and just leave the %f in the string?

No, it does not. I understand now why ValueError was an intentional choice 
here. The CRT actually breaks the loop with a goto if any call to expand_time 
fails. So raising a Python exception is the only reasonable course of action. 
(I still think maybe it's a good place to use the new _Py_BEGIN_SUPPRESS_IPH 
macro. That way instead of presuming what's a valid format code, it could just 
handle the EINVAL.)

--
components:  -Windows
versions:  -Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24246] mimetypes.guess_extension returns different values when init() is called several times

[R. David Murray]

R. David Murray added the comment:

This is a duplicate of issue 4963.

--
nosy: +r.david.murray
resolution:  - duplicate
stage:  - resolved
status: open - closed
superseder:  - mimetypes.guess_extension result changes after mimetypes.init()

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24246
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python Crash on strftime with %f on Python 3

[R. David Murray]

R. David Murray added the comment:

The ValueError is not a bug.  Not all format codes are supported on all 
platforms (we start from what the platform supports, and then we have a few we 
have implemented cross platform, but that isn't one of them).  We also pass 
through the behavior of the underlying system as far as handling unknown codes. 
 Whether that is the best policy or not is an interesting question, but one 
that should probably be addressed on python-ideas if someone wants to tackle 
it, since it has backward compatibility implications (and the wider discussion 
would affect the the behavior on FreeBSD as well, where unknown codes are 
handled differently than they are on linux, though they don't produce an 
exception.)

For the other I think you should open a new issue referencing the old one.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23699] Add a macro to ease writing rich comparisons

[Stefan Krah]

Stefan Krah added the comment:

It seems that it won't be easy to find an API that pleases everyone.

I don't want to prolong the discussion much, but if the macro goes in,
returning PyErr_BadArgument() in the default case would be better than
NotImplemented.

assert(0) would be fine as well.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23699
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python Crash on strftime with %f on Python 3 and Python 2

[Majeed Arni]

Majeed Arni added the comment:

Actually it is happening in Python 2.7 too..

Here is the format we are trying to use:

 date_format = '%Y %m %d %H:%M:%S:%f %z'

Also, is there something millisecond if not microsecond?

--
title: Python Crash on strftime with %f on Python 3 - Python Crash on strftime 
with %f on Python 3 and Python 2
versions: +Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24243] behavior for finding an empty string is inconsistent with documentation

[R. David Murray]

R. David Murray added the comment:

If the slices indexes had to be in range, that would be inconsistent with the 
behavior of slicing

No, it wouldn't.  Your slice example is two operations: the slice returns an 
empty string (because that's how the *substring* operation is defined to behave 
for an out-of-range slice), and *then* the search operation is called on it; 
but in the call with index arguments, the indicies are specifying the slice to 
search in using the slice semantics of the indicies, but that substring is 
invalid for the *search* operation.

I agree that the startswith/endswith difference between string a bytes looks 
like a bug, and that the bytes case looks to be the correct one, in terms of 
consistency with the other search operations.  Those operations are a bit 
different from the other search operations, though, so I could see it argued 
the other way.

The point is that the slice notation specifies how to compute the substring, 
but what happens if the substring is out of range depends on the *operation*.

--
nosy: +r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24243
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I was vague about this feature, but if other core developer found it useful, I 
have no objections. Only few nitpicks to the implementation.

--
nosy: +georg.brandl, ncoghlan, pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24230
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17797] Visual C++ 11.0 reports fileno(stdin) == 0 for non-console program

[Mateusz Loskot]

Mateusz Loskot added the comment:

Re msg238016, I confirm python-3.5.0a2-fdvalidation.patch fixes the problem for 
Python 3.5.0a4 and VS2013.

The only issue I encountered was with HAVE_FSTAT which is missing from 
PC/pyconifg.h, so I edited the patch and removed the check if 
defined(HAVE_FSTAT). Does PC/pyconifg.h need update?

I also confirm vanilla Python 3.5.0a4 with VS2015RC does not require this 
patch, because the fileno regression/bug has been fixed in VS2015RC (details at 
https://connect.microsoft.com/VisualStudio/feedback/details/785119/).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17797
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22955] Pickling of methodcaller, attrgetter, and itemgetter

[Roundup Robot]

Roundup Robot added the comment:

New changeset 435bc22f39e3 by Serhiy Storchaka in branch 'default':
Issue #22955: attrgetter, itemgetter and methodcaller objects in the operator
https://hg.python.org/cpython/rev/435bc22f39e3

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22955
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21259] replace except: pass by except Exception: pass

[Terry J. Reedy]

Terry J. Reedy added the comment:

A couple of years ago, when I pushed 'except: pass', I was told in post-review 
that grandfathered bad code is no excuse for more bad code and that I should be 
explicit, including if I actually meant except BaseException:, which in this 
case I did.  No other developer said otherwise.  I took the above to be the 
general consensus. I agree with it, one reason being that bare excepts are 
speed bumps when reading someone else's code.

Victor generic change except: pass to except Exception: pass
This is not correct without case-by-case examination.

#16261 had 2 patches.  The patch for doc examples changed 3 'except:'s to 
'except Exception:'  I believe these are correct, or correct enough.  They all 
need to *not* catch KeyboardInterrupt.  The patch for lib code never changed to 
Exception, but something tighter.

The patch committed for #16261 patched 7 files (down from the original proposed 
11).  Even that took a couple of years to get a second review.  I think further 
followup patches should probably change even fewer files and be attached to 
new, narrowly focused issues.

Raymond, since you closed this once, and since no new patch has been submitted, 
I presume you do not mind if I reclose this.

--
resolution:  - duplicate
stage:  - resolved
status: open - closed
type:  - enhancement

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue21259
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24215] test_trace uses test_pprint

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2c074a8dd084 by Serhiy Storchaka in branch '3.4':
Issue 24215: Added tests for more builtin types in test_pprint.
https://hg.python.org/cpython/rev/2c074a8dd084

New changeset da711bdcc1bf by Serhiy Storchaka in branch 'default':
Issue 24215: Added tests for more builtin types in test_pprint.
https://hg.python.org/cpython/rev/da711bdcc1bf

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24215
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows

[Steve Dower]

Steve Dower added the comment:

_Py_*_SUPPRESS_IPH is the right thing to use here. It still displays an 
assertion dialog in debug builds, but ignoring it has the correct effect.

Patch attached for 3.5

--
keywords: +patch
Added file: http://bugs.python.org/file39438/24244_1.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24134] assertRaises can behave differently

[Roundup Robot]

Roundup Robot added the comment:

New changeset cbe28273fd8d by Serhiy Storchaka in branch '2.7':
Issue #24134: Use assertRaises() in context manager form in test_slice to
https://hg.python.org/cpython/rev/cbe28273fd8d

New changeset 3a1ee0b5a096 by Serhiy Storchaka in branch '3.4':
Issue #24134: Use assertRaises() in context manager form in test_slice to
https://hg.python.org/cpython/rev/3a1ee0b5a096

New changeset 36c4f8af99da by Serhiy Storchaka in branch 'default':
Issue #24134: Use assertRaises() in context manager form in test_slice to
https://hg.python.org/cpython/rev/36c4f8af99da

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24134
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24134] assertRaises can behave differently

[Serhiy Storchaka]

Changes by Serhiy Storchaka storch...@gmail.com:


--
resolution:  - fixed
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24134
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

[Augie Fackler]

Augie Fackler added the comment:

I'll build a patched Python3.5 tomorrow (I'm on the road today) and let you 
know if this does everything we need. I'd be shocked if it wasn't plenty.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24230
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9858] Python and C implementations of io are out of sync

[Roundup Robot]

Roundup Robot added the comment:

New changeset 962b42d67b9e by Antoine Pitrou in branch 'default':
Issue #9858: Add missing method stubs to _io.RawIOBase.  Patch by Laura 
Rupprecht.
https://hg.python.org/cpython/rev/962b42d67b9e

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9858
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9858] Python and C implementations of io are out of sync

[Antoine Pitrou]

Antoine Pitrou added the comment:

I've pushed this to the default branch. Thanks!

--
resolution:  - fixed
stage: commit review - resolved
status: open - closed
versions:  -Python 2.7, Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9858
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24248] Deprecate inspect.Signature.from_function and from_builtin

[Yury Selivanov]

Yury Selivanov added the comment:

Patch is attached.

--
keywords: +patch
Added file: http://bugs.python.org/file39439/sig_warns.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24248
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows

[R. David Murray]

R. David Murray added the comment:

OK.  What made me wonder is that I saw that the 'invalid format string' 
exception was removed by the patch...I guess that is also raised at a higher 
level in the code.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24249] unittest API for detecting test failure in cleanup/teardown

[R. David Murray]

New submission from R. David Murray:

I have a situation where it would be really helpful to know in my cleanup 
routine whether or not the test failed.  The situation is this: I'm running a 
command in a subprocess, and sometimes it writes output to stderr that I 
normally want to ignore.  But if the test fails, I'd like my cleanup routine 
(that shuts down the test subprocess) to print out the stderr, because usually 
the information as to what went wrong is in stderr.

I figure out this hack (for python3.4):

for what, result in self._outcome.errors:
if what._testMethodName == self._testMethodName and result:
print(self.p.stderr.read().decode())

but obviously that uses non-public APIs.

--
keywords: easy
messages: 243694
nosy: ezio.melotti, michael.foord, r.david.murray, rbcollins
priority: normal
severity: normal
stage: needs patch
status: open
title: unittest API for detecting test failure in cleanup/teardown
type: enhancement
versions: Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24249
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24250] Optimization for strcpy(..., ) in file 'install.c'

[Bill Parker]

New submission from Bill Parker:

In reviewing calls to strcpy(string, ), I found three instances which could 
be re-written as *string = '\0'; which would save the minor overhead of a 
function call.  The patch file is below:

--- install.c.orig  2015-05-20 14:11:27.723397005 -0700
+++ install.c   2015-05-20 14:14:00.862860244 -0700
@@ -1640,8 +1640,8 @@
 PSWIZB_BACK);
 SetDlgItemText(hwnd, IDC_PATH, );
 SetDlgItemText(hwnd, IDC_INSTALL_PATH, );
-strcpy(python_dir, );
-strcpy(pythondll, );
+   *python_dir = '\0'; /*  replaces strcpy(python_dir, ) */
+   *pythondll = '\0';  /*  replaces strcpy(pythondll, )  */
 } else {
 char *pbuf;
 int result;
@@ -1680,7 +1680,7 @@
 }
 free(pbuf);
 } else
-strcpy(pythondll, );
+   *pythondll = '\0';  /*  replaces strcpy(pythondll, )  
*/
 /* retrieve the scheme for this version */
 {
 char install_path[_MAX_PATH];

I am attaching the patch file to this bug report...

--
components: Windows
files: install.c.patch
keywords: patch
messages: 243697
nosy: dogbert2, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Optimization for strcpy(..., ) in file 'install.c'
type: enhancement
versions: Python 3.4
Added file: http://bugs.python.org/file39440/install.c.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24250
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24240] PEP 448: Update the language reference

[Benjamin Peterson]

Changes by Benjamin Peterson benja...@python.org:


--
resolution:  - duplicate
status: open - closed
superseder:  - document PEP 448

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24240
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows

[Steve Dower]

Steve Dower added the comment:

It raises ValueError just like now (no visible change), but it won't crash and 
doesn't require being able to validate the complete format string.

If we want any different behaviour, we need to reimplement strftime for Python, 
which I'd be okay with, but I'm not the one to do it :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows

[Steve Dower]

Steve Dower added the comment:

It's raised by the existing handling for EINVAL at the end of the function. 
Previously we'd crash before getting that far because of the invalid parameter 
handler.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24248] Deprecate inspect.Signature.from_function and from_builtin

[Yury Selivanov]

New submission from Yury Selivanov:

I want to deprecate Signature.from_function and Signature.from_builtin in 3.5.

There is no use for these methods (they aren't generic), and we also now have a 
very handy 'from_callable' for easy Signature subclassing.

--
assignee: yselivanov
components: Library (Lib)
messages: 243684
nosy: brett.cannon, larry, ncoghlan, yselivanov
priority: normal
severity: normal
status: open
title: Deprecate inspect.Signature.from_function and from_builtin
type: behavior
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24248
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20691] inspect.signature: Consider exposing 'follow_wrapper_chains' option in public API

[Roundup Robot]

Roundup Robot added the comment:

New changeset 0c298f1ee3f6 by Yury Selivanov in branch 'default':
Issue 20691: Add follow_wrapped arg to inspect.signature/from_callable.
https://hg.python.org/cpython/rev/0c298f1ee3f6

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20691
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22955] Pickling of methodcaller, attrgetter, and itemgetter

[Roundup Robot]

Roundup Robot added the comment:

New changeset c93e5ba1cc20 by Serhiy Storchaka in branch 'default':
Issue #22955: Fixed test_operator. It left Python implementation in
https://hg.python.org/cpython/rev/c93e5ba1cc20

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue22955
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9858] Python and C implementations of io are out of sync

[Antoine Pitrou]

Antoine Pitrou added the comment:

__weakref__ is just an implementation detail of how heap types expose weak 
references (actually, I'm not sure why it's exposed at all).

Laura, thank you for contributing. Your patch looks good to me.

--
assignee: gregory.p.smith - 
resolution: accepted - 
stage: needs patch - commit review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9858
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows

[R. David Murray]

R. David Murray added the comment:

What's the behavior after this patch?  Does it just return the string 
unmodified?  Or return a null string?  Or is the traceback generated at a 
higher level (and if so what is the error message?)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24247] unittest discover does modify sys.path

[Sergey Skripnick]

New submission from Sergey Skripnick:

unittest discover does add some directories to sys.path

later some modules can not work with modified sys.path

Here module `pdb` is trying to import standard module `cmd` but does import 
`cmd` module from `tests` directory:

unittest discover should not modify sys.path in any way.

http://dpaste.com/2RYV8E0

$ mkdir /tmp/t
$ cd /tmp/t
$ mkdir tests
$ mkdir tests/cmd
$ touch tests/cmd/__init__.py
$ echo import pdb  tests/test_nothing.py
$ python -m unittest discover tests
E
==
ERROR: test_nothing (unittest.loader.ModuleImportFailure)
--
ImportError: Failed to import test module: test_nothing
Traceback (most recent call last):
  File /usr/lib/python2.7/unittest/loader.py, line 254, in _find_tests
module = self._get_module_from_name(name)
  File /usr/lib/python2.7/unittest/loader.py, line 232, in 
_get_module_from_name
__import__(name)
  File /tmp/t/tests/test_nothing.py, line 1, in module
import pdb
  File /usr/lib/python2.7/pdb.py, line 59, in module
class Pdb(bdb.Bdb, cmd.Cmd):
AttributeError: 'module' object has no attribute 'Cmd'


--
Ran 1 test in 0.000s

FAILED (errors=1)

--
messages: 243681
nosy: redixin
priority: normal
severity: normal
status: open
title: unittest discover does modify sys.path
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24247
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20691] inspect.signature: Consider exposing 'follow_wrapper_chains' option in public API

[Yury Selivanov]

Yury Selivanov added the comment:

Closing this one.

--
resolution:  - fixed
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue20691
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9858] Python and C implementations of io are out of sync

[Laura Rupprecht]

Laura Rupprecht added the comment:

Can anyone provide feedback on this patch?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9858
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9858] Python and C implementations of io are out of sync

[Robert Collins]

Robert Collins added the comment:

I think ignoring weakref is wrong: it means the two implementations are 
different.

--
nosy: +rbcollins

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9858
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24248] Deprecate inspect.Signature.from_function and from_builtin

[Yury Selivanov]

Yury Selivanov added the comment:

Forgot to mention: from_function and from_builtin are not documented.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24248
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24251] Different behavior for argparse between 2.7.8 and 2.7.9 when adding the same arguments to the root and the sub commands

[Hao Huang]

New submission from Hao Huang:

When I was trying to add the same argument to both the root command and the sub 
command and you put the arguments before the subcommand, In 2.7.8 the arguments 
would be parsed correctly. But in 2.7.9, they wouldn't but these arguments 
would show up in the help doc:(

For python2.7.8
~$ python2.7
Python 2.7.8 (default, Oct 29 2014, 13:45:48)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type help, copyright, credits or license for more information.
 import argparse

 parser = argparse.ArgumentParser()
 parser.add_argument(-s, dest=start)
_StoreAction(option_strings=['-s'], dest='start', nargs=None, const=None, 
default=None, type=None, choices=None, help=None, metavar=None)

 subparsers = parser.add_subparsers()
 subparser = subparsers.add_parser(command)
 subparser.add_argument(-s, dest=start)
_StoreAction(option_strings=['-s'], dest='start', nargs=None, const=None, 
default=None, type=None, choices=None, help=None, metavar=None)

 parser.parse_args([-s, 1, command])
Namespace(start='1')
 parser.parse_args([command, -s, 1])
Namespace(start='1')

For python 2.7.9
~$ python2.7
Python 2.7.9 (default, Apr 2 2015, 15:33:21)
[GCC 4.9.2] on linux2
Type help, copyright, credits or license for more information.
 import argparse
 parser = argparse.ArgumentParser()
 parser.add_argument(-s, dest=start)
_StoreAction(option_strings=['-s'], dest='start', nargs=None, const=None, 
default=None, type=None, choices=None, help=None, metavar=None)

 subparsers = parser.add_subparsers()
 subparser = subparsers.add_parser(command)
 subparser.add_argument(-s, dest=start)
_StoreAction(option_strings=['-s'], dest='start', nargs=None, const=None, 
default=None, type=None, choices=None, help=None, metavar=None)

 parser.parse_args([-s, 1, command])
Namespace(start=None)
 parser.parse_args([command, -s, 1])
Namespace(start='1')

--
components: Argument Clinic
messages: 243700
nosy: hhuang, larry
priority: normal
severity: normal
status: open
title: Different behavior for argparse between 2.7.8 and 2.7.9 when adding the 
same arguments to the root and the sub commands
type: behavior
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24251
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24251] Different behavior for argparse between 2.7.8 and 2.7.9 when adding the same arguments to the root and the sub commands

[Hao Huang]

Hao Huang added the comment:

I think this patch cause the difference:
https://hg.python.org/cpython/rev/1a3143752db2

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24251
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23377] HTTPResponse may drop buffer holding next response

[Demian Brecht]

Demian Brecht added the comment:

Added comments to Rietveld.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23377
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24252] IDLE removes elements from tracebacks.

[ppperry]

New submission from ppperry:

When reproducing issue24160 in IDLE, I saw this traceback:
Traceback (most recent call last):
  File pyshell#14, line 1, in module
pdb.run(reload(test3))
  File C:\Python27\lib\pdb.py, line 1238, in run
Pdb().run(statement, globals, locals)
  File C:\Python27\lib\bdb.py, line 400, in run
exec cmd in globals, locals
  File string, line 1, in module
  File test3.py, line 1, in module
[contents of test3.py]
  File C:\Python27\lib\bdb.py, line 51, in trace_dispatch
return self.dispatch_call(frame, arg)
  File C:\Python27\lib\bdb.py, line 80, in dispatch_call
self.user_call(frame, arg)
  File C:\Python27\lib\pdb.py, line 148, in user_call
self.interaction(frame, None)
  File C:\Python27\lib\pdb.py, line 210, in interaction
self.cmdloop()
  File C:\Python27\lib\cmd.py, line 142, in cmdloop
stop = self.onecmd(line)
  File C:\Python27\lib\pdb.py, line 279, in onecmd
return cmd.Cmd.onecmd(self, line)
  File C:\Python27\lib\cmd.py, line 221, in onecmd
return func(arg)
  File C:\Python27\lib\pdb.py, line 622, in do_clear
err = self.clear_bpbynumber(i)
KeyError: 'c:\\documents and 
settings\\perry\\desktop\\coding_projects\\python\\test3.py'

Reproducing the same bug in the standard interpreter produces a more detailed 
traceback:
Traceback (most recent call last):
  File pyshell#592, line 1, in module
pdb.run(reload(test3))
  File C:\Python27\lib\pdb.py, line 1238, in run
Pdb().run(statement, globals, locals)
  File C:\Python27\lib\bdb.py, line 400, in run
exec cmd in globals, locals
  File string, line 1, in module
  File test3.py, line 1, in module
foo = 7789
  File C:\Python27\lib\bdb.py, line 51, in trace_dispatch
return self.dispatch_call(frame, arg)
  File C:\Python27\lib\bdb.py, line 80, in dispatch_call
self.user_call(frame, arg)
  File C:\Python27\lib\pdb.py, line 148, in user_call
self.interaction(frame, None)
  File C:\Python27\lib\pdb.py, line 210, in interaction
self.cmdloop()
  File C:\Python27\lib\cmd.py, line 142, in cmdloop
stop = self.onecmd(line)
  File C:\Python27\lib\pdb.py, line 279, in onecmd
return cmd.Cmd.onecmd(self, line)
  File C:\Python27\lib\cmd.py, line 221, in onecmd
return func(arg)
  File C:\Python27\lib\pdb.py, line 622, in do_clear
err = self.clear_bpbynumber(i)
  File C:\Python27\lib\bdb.py, line 297, in clear_bpbynumber
self._prune_breaks(bp.file, bp.line)
  File C:\Python27\lib\bdb.py, line 268, in _prune_breaks
self.breaks[filename].remove(lineno)
KeyError: 'c:\\documents and 
settings\\perry\\desktop\\coding_projects\\python\\test3.py'

The actual error message is irrelevant, other than the fact that in the 
standard interpreter, the traceback contains two more entries.

--
components: IDLE
messages: 243709
nosy: kbk, ppperry, roger.serwy, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE removes elements from tracebacks.
type: behavior
versions: Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24252
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16991] Add OrderedDict written in C

[Eric Snow]

Eric Snow added the comment:

These are the leaks I'm seeing in test_collections (14/24 tests):

 test_copying : 178
 test_iterators   : 40
 test_update  : 29
 test_init: 22
 test_move_to_end : 21
 test_sorted_iterators: 20
 test_setdefault  : 16
 test_clear   : 5
 test_setitem : 5
 test_delitem : 4
 test_repr_recursive  : 4
 test_repr: 3
 test_override_update : 2
 test_reinsert: 1

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23699] Add a macro to ease writing rich comparisons

[Petr Viktorin]

Petr Viktorin added the comment:

Well, in my opinion NotImplemented is a good value for unknown operation, but 
I'll be happy to change to PyErr_BadArgument(); return NULL; if there's support 
for that.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23699
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24251] Different behavior for argparse between 2.7.8 and 2.7.9 when adding the same arguments to the root and the sub commands

[Ned Deily]

Changes by Ned Deily n...@acm.org:


--
components: +Library (Lib) -Argument Clinic
nosy: +bethard, r.david.murray -larry

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24251
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24249] unittest API for detecting test failure in cleanup/teardown

[Martin Panter]

Martin Panter added the comment:

Ah sorry I didn’t see the keyword “subprocess”, so --buffer won’t work! But 
maybe you can dump the subprocess’s stderr to sys.stderr?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24249
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows

[eryksun]

Changes by eryksun eryk...@gmail.com:


--
components: +Windows

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24244
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24248] Deprecate inspect.Signature.from_function and from_builtin

[Yury Selivanov]

Yury Selivanov added the comment:

 For the documentation, in addition to noting the deprecation itself, it may 
 also be worth noting how to explicitly recreate the type restriction.

Nick, what do you mean by type restriction?  Also, since the functions aren't 
documented, I think we don't need to document that they are deprecated?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24248
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24247] unittest discover does modify sys.path

[Ned Deily]

Changes by Ned Deily n...@acm.org:


--
nosy: +ezio.melotti, michael.foord, rbcollins

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24247
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24249] unittest API for detecting test failure in cleanup/teardown

[Martin Panter]

Martin Panter added the comment:

Can’t you use the -b or --buffer command-line option 
https://docs.python.org/dev/library/unittest.html#cmdoption-unittest-b, or 
equivalent option to unittest.main() or whatever?

The standard output and standard error streams are buffered during the test 
run. Output during a passing test is discarded. Output is echoed normally on 
test fail or error and is added to the failure messages.

--
nosy: +vadmium

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24249
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24243] behavior for finding an empty string is inconsistent with documentation

[Raymond Hettinger]

Raymond Hettinger added the comment:

 Changing behavior of such base methods is dangerous 
 and can break existing code.

I agree.  The time to argue an API design is before it released not years later 
after people have written code that relies on the behavior.  

 To me, semantically, the whole idea of finding nothing, 
 whether in something or in nothing is complete and utter nonsense. 

It might not be something you don't agree with, but it isn't nonsense.  There 
are a number of ways to view it sensibly (empty sets always a subset of other 
sets).  There a reason that any() and all() are well-defined for empty 
iterables.  There a reason that math.factorial(0) returns 1.  Those are useful 
corner cases that save us from writing special case code.

 Empty string search: I think it is completely valid to be able to find an 
 empty string inside another string,

I concur.

I am closing this one as not a bug.

Primum non nocere.  First Do No Harm.  Don't break existing code because the 
OP would prefer that any attempt to find nothing would result in an exception 
being raised.  That is a terrible reason to break code.  For better or worse, 
this state of affairs has existed for a long time and no harm seems to have 
arisen.

Also keep in mind that the current behaviors are tested, meaning that it is not 
accidental and is guaranteed across implementations.  See 
Lib/test/string_tests.py.

Though this is closed as not a bug, feel free to add an example or a mention in 
the documentation.  Keep it short though.  The purpose of the docs for 
str.count and str.index are to teach how to use the common case rather than 
getting lost in a discussion of corner case behavior.  Also, the docs should be 
affirmatively worded (here is how something works and how to use it) rather 
than negatively worded (omg, finding nothing is something is nonsense).

--
nosy: +rhettinger
resolution:  - not a bug
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24243
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24248] Deprecate inspect.Signature.from_function and from_builtin

[Nick Coghlan]

Nick Coghlan added the comment:

+1 from me.

The deprecation warning text in the patch has a typo (callback instead of 
callable).

For the documentation, in addition to noting the deprecation itself, it may 
also be worth noting how to explicitly recreate the type restriction.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24248
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16991] Add OrderedDict written in C

[Eric Snow]

Eric Snow added the comment:

I've updated the cordereddict branch on the feature repo to fix the ref leak on 
None.  I'm still seeing other leaks (regrtest -R 3:3), but I don't think that 
should block landing before the feature freeze.

However, I'm concerned about a segfault I'm seeing roughly 3% of the time when 
running the following:

  ./python -m unittest test.test_configparser.ConfigParserTestCase.test_basic

Presumably there is a dealloc bug there which manifests intermittently due to a 
GC race.  I'm going work on tracking it down but help is appreciated. :)

I'm also seeing consistent test failures in test_enum.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16991] Add OrderedDict written in C

[Antoine Pitrou]

Antoine Pitrou added the comment:

A patch shouldn't be integrated if there are known bugs with it (especially 
segfaults).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24251] Different behavior for argparse between 2.7.8 and 2.7.9 when adding the same arguments to the root and the sub commands

[smparkes]

Changes by smparkes smpar...@smparkes.net:


--
nosy: +smparkes

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24251
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16991] Add OrderedDict written in C

[Eric Snow]

Eric Snow added the comment:

Agreed.  I wanted to be clear about what is blocking landing the patch.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23973] PEP 484 implementation

[Guido van Rossum]

Guido van Rossum added the comment:

I am going to commit this (or something very close to it) unless I hear an 
explicit rejection notice from Mark Shannon. Off-list he's promised he'll 
approve the PEP provisionally, and the window for beta 1 is closing. It's 
better to iterate than to miss the window entirely.

--
keywords: +patch
Added file: http://bugs.python.org/file39441/pep484.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23973
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24248] Deprecate inspect.Signature.from_function and from_builtin

[Nick Coghlan]

Nick Coghlan added the comment:

Oh, right - you said they weren't documented, and I completely glazed over that 
bit.

The type restrictions comment isn't valid in the absence of documentation, 
but it was basically about how to fully replicate the behaviour of the existing 
functions in conjunction with from_callable.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24248
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24248] Deprecate inspect.Signature.from_function and from_builtin

[Roundup Robot]

Roundup Robot added the comment:

New changeset 64fba4ea031b by Yury Selivanov in branch 'default':
Issue 24248: Deprecate inspect.Signature.from_function and .from_builtin
https://hg.python.org/cpython/rev/64fba4ea031b

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24248
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24253] pydoc for namespace packages indicates FILE as built-in

[Antony Lee]

New submission from Antony Lee:

All's in the title: the output of pydoc foo where foo is a namespace package 
(... e.g. any directory in the cwd) says that the package is defined as a 
builtin (under the FILE entry) -- which is certainly incorrect.

--
components: Library (Lib)
messages: 243728
nosy: Antony.Lee
priority: normal
severity: normal
status: open
title: pydoc for namespace packages indicates FILE as built-in
versions: Python 3.4, Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24253
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24249] unittest API for detecting test failure in cleanup/teardown

[R. David Murray]

R. David Murray added the comment:

Having to specify a command line option to get a normally clean test run just 
doesn't feel like a good API.  If there is a way to set that on the TestCase, 
that would be OK.

There are other reasons to want the API I suggest, though...there is at least 
one StackOverflow question asking about how to do it, which is where I got the 
clue for implementing my hack.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24249
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24248] Deprecate inspect.Signature.from_function and from_builtin

[Yury Selivanov]

Changes by Yury Selivanov yseliva...@gmail.com:


--
resolution:  - fixed
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24248
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24248] Deprecate inspect.Signature.from_function and from_builtin

[Yury Selivanov]

Yury Selivanov added the comment:

OK, committed! Thanks for the review, Nick.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24248
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24243] behavior for finding an empty string is inconsistent with documentation

[R. David Murray]

R. David Murray added the comment:

Raymond: this is currently marked as a documentation bug, and documentation is 
mostly what the OP was asking for.  So I'm reopening it.

That said, I think it is very appropriate to discuss fixing the behavior of 
string's endswith and startswith, because people are still (and will be for a 
while yet) porting from python2 and supporting single-code-base code, where 
string behaves the way bytes does in python3.  That should be addressed in a 
separate issue.  So in fact, history and code written for the current 
behavior comes down, IMO, on the side of fixing this edge case.  I'm willing 
to be argued out of that, though :)

--
resolution: not a bug - 
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24243
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

[Nick Coghlan]

Nick Coghlan added the comment:

Given the two-release deprecation cycle, would it be worth using 
PendingDeprecationWarning here? That way folks that only turned on 
DeprecationWarning (rather than -Wall) wouldn't need to worry about this until 
3.6.

As far as our own test suite goes, when ResourceWarning was introduced, dealing 
with those in the test suite became an ongoing cleanup task. Are there really 
all that many warnings triggered for PEP 479?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24237
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16991] Add OrderedDict written in C

[Eric Snow]

Eric Snow added the comment:

I've fixed most of the leaks now.  The only remaining ones are:

 test_clear   : 5
 test_repr_recursive  : 3

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

[Yury Selivanov]

Changes by Yury Selivanov yseliva...@gmail.com:


--
nosy: +gvanrossum

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24237
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

[Yury Selivanov]

Yury Selivanov added the comment:

Nick, please review the patch.

BTW, we will have *a lot* of warnings now when running tests with -Wall. Are we 
going to employ from __future__ import generator_stop everywhere in 3.5?

--
keywords: +patch
nosy: +yselivanov
priority: normal - release blocker
stage:  - patch review
versions: +Python 3.5
Added file: http://bugs.python.org/file39442/gen_stop_warn.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24237
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

[Yury Selivanov]

Changes by Yury Selivanov yseliva...@gmail.com:


Added file: http://bugs.python.org/file39443/gen_stop_warn.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24237
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

[Yury Selivanov]

Changes by Yury Selivanov yseliva...@gmail.com:


Removed file: http://bugs.python.org/file39443/gen_stop_warn.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24237
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

[Yury Selivanov]

Changes by Yury Selivanov yseliva...@gmail.com:


Removed file: http://bugs.python.org/file39442/gen_stop_warn.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24237
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16991] Add OrderedDict written in C

[Eric Snow]

Eric Snow added the comment:

Regarding the segfault, the following does not fail:

  ./python -m test.regrtest --forever -m test_basic test_configparser

but this does:

  for i in `seq 1 20`; do ./python -m test.regrtest -m test_basic 
test_configparser ; done

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16991] Add OrderedDict written in C

[Yury Selivanov]

Yury Selivanov added the comment:

Eric, could you please upload your latest patch?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24248] Deprecate inspect.Signature.from_function and from_builtin

[Yury Selivanov]

Yury Selivanov added the comment:

I documented the deprecation in the whatsnew section anyways.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24248
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

[Yury Selivanov]

Yury Selivanov added the comment:

Had to regenerate the patch. Fixed some typos + now I use PyErr_WriteUnraisable 
if PyErr_WarnFormat returns non-zero.

And yeah, PendingDeprecationWarning is a better choice.

--
Added file: http://bugs.python.org/file39444/gen_stop_warn.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24237
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16991] Add OrderedDict written in C

[Eric Snow]

Eric Snow added the comment:

Here's a diff from the current cordereddict branch of the feature repo.

--
Added file: http://bugs.python.org/file39445/cOrderedDict-4.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used

[Yury Selivanov]

Yury Selivanov added the comment:

 Are there really all that many warnings triggered for PEP 479?

Actually, with the attached patch the number of warnings is pretty low, we can 
definitely fix/silence them where necessary.  (I think I had a bug in one of my 
first patches that triggered some false-positives).

- test_difflib - will have to fix difflib;

- test_contextlib - tests StopIteration propagation on purpose; will silence 
the warning;

- test_with

- test_generators

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24237
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12319] [http.client] HTTPConnection.putrequest not support chunked Transfer-Encodings to send data

[Demian Brecht]

Demian Brecht added the comment:

BTW, thanks for the reviews Martin and the nudge Antoine!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12319
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12319] [http.client] HTTPConnection.putrequest not support chunked Transfer-Encodings to send data

[Demian Brecht]

Demian Brecht added the comment:

Latest patch should address all outstanding comments.

--
Added file: http://bugs.python.org/file39447/issue12319_6.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12319
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24254] Make class definition namespace ordered by default

[Eric Snow]

New submission from Eric Snow:

Here's a work-in-progress patch that uses OrderedDict as the default class 
definition namespace (instead of dict).  While the actual class namespace is a 
dict, the definition order is preserved on a new attribute on class objects: 
__definition_order__.  This is useful for cases such as class decorators that 
would make use of the definition order to post-process the class.  This is 
something that Guido okay'ed a while back.

It may be a stretch to get this into 3.5, but the final change should be pretty 
small.  It also depends on the C implementation of OrderedDict (see issue 
#16991) which has not landed and may not make it in time.

Note that the patch is still a bit buggy, partly due to bugs in the C 
OrderedDict patch.  Also, the attached patch is based off the C OrderedDict 
patch, so I expect reitveld won't be able to handle it.  The code on which the 
patch is based may be found in the class-namespace branch of 
https://pypi.python.org/pypi/cyordereddict.

--
assignee: eric.snow
components: Interpreter Core
files: odict-class-definition-namespace.diff
keywords: patch
messages: 243729
nosy: eric.snow, ncoghlan
priority: normal
severity: normal
status: open
title: Make class definition namespace ordered by default
type: behavior
versions: Python 3.5
Added file: 
http://bugs.python.org/file39446/odict-class-definition-namespace.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24254
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24230] tempfile.mkdtemp() doesn't work with bytes paths

[Augie Fackler]

Augie Fackler added the comment:

 In any way Mercurial people need their own wrapper if they want to support 
 Python 3.5.

We need format operations on bytes objects, so we have no plans to support 
Python3 for any version before 3.5.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24230
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com